[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #34 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing l

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master V

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #33 from Katrin Fischer --- Had to fix a small conflict in the first patch and the unit test due to CSRF changes. This means that if this was to be backported, we'd probably need some small changes. Fixed commit message:

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #32 from Pedro Amorim --- Rebased on bug 34478 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-commun

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #160637|0 |1 is obsolete|

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #160636|0 |1 is obsolete|

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #160635|0 |1 is obsolete|

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #28 from Pedro Amorim --- Created attachment 162813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162813&action=edit Bug 35331: CSRF follow-up Update method to op -- You are receiving this mail beca

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #160634|0 |1 is obsolete|

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #26 from Pedro Amorim --- It no longer applied after bug 35070. Rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list K

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #159109|0 |1 is obsolete|

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #159108|0 |1 is obsolete|

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #159107|0 |1 is obsolete|

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Attachment #159106|0 |1 is obsolete|

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Blocks||35581 Referenced Bugs: htt

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #21 from Kyle M Hall --- Created attachment 159109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159109&action=edit Bug 35331: (QA follow-up): Patron ILL history With the previous patches applied and

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #20 from Kyle M Hall --- Created attachment 159108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159108&action=edit Bug 35331: (QA follow-up): Avoid code pattern iterating on plugin responses (see bug

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #19 from Kyle M Hall --- Created attachment 159107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159107&action=edit Bug 35331: Add plugin hook tests prove t/db_dependent/Koha/Plugins/Ill_hooks.t Sign

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Kyle M Hall changed: What|Removed |Added Attachment #159105|0 |1 is obsolete|

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Kyle M Hall changed: What|Removed |Added Attachment #159046|0 |1 is obsolete|

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receivi

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #16 from Pedro Amorim --- Brilliant, David. Thank you, you're awesome! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koh

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #15 from David Nind --- Testing notes (using KTD): 1. Without the 4th patch applied, go to Patrons > [Patron account] > Ill requests history. The screen displays the ILL requests history table headers and shows "Processi

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 David Nind changed: What|Removed |Added Attachment #159037|0 |1 is obsolete|

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 David Nind changed: What|Removed |Added Attachment #158993|0 |1 is obsolete|

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 David Nind changed: What|Removed |Added Attachment #158917|0 |1 is obsolete|

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 David Nind changed: What|Removed |Added Attachment #158916|0 |1 is obsolete|

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivi

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #10 from Pedro Amorim --- (In reply to David Nind from comment #7) > I'm not a developer, so I don't know whether tests should pass with and > without the koha-plugin-ill-actions plugin enabled. If we run the following

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #9 from Pedro Amorim --- Created attachment 159037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159037&action=edit Bug 35331: (QA follow-up): Patron ILL history With the previous patches applied and

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are re

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #8 from Pedro Amorim --- (In reply to David Nind from comment #7) > Tests pass if the koha-plugin-ill-actions plugin is disabled. > > Note: with version 1.0.1 of the plugin, the new action no longer works[1] > (it did pr

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #7 from David Nind --- Tests pass if the koha-plugin-ill-actions plugin is disabled. Note: with version 1.0.1 of the plugin, the new action no longer works[1] (it did previously with v1.0.0), but I don't know if that is

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #6 from Pedro Amorim --- Created attachment 158993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158993&action=edit Bug 35331: (QA follow-up): Avoid code pattern iterating on plugin responses (see bug

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #5 from Pedro Amorim --- (In reply to David Nind from comment #3) > Everything works for me, except running the tests - which fail 8-(... > > kohadev-koha@kohadevbox:koha(bz35331)$ prove > t/db_dependent/Koha/Plugins/Ill

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 David Nind changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA CC|

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are re

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #2 from Pedro Amorim --- Created attachment 158917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158917&action=edit Bug 35331: Add plugin hook tests prove t/db_dependent/Koha/Plugins/Ill_hooks.t --

[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #1 from Pedro Amorim --- Created attachment 158916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158916&action=edit Bug 35331: Add table actions hook to ILL table Test plan, k-t-d, apply patches: 1) I