https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Victor Grousset/tuxayo changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to main
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Jonathan Druart changed:
What|Removed |Added
Assignee|vic...@tuxayo.net |jonathan.dru...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Jonathan Druart changed:
What|Removed |Added
Attachment #161631|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Jonathan Druart changed:
What|Removed |Added
Resolution|FIXED |---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Emily Lamancusa changed:
What|Removed |Added
Blocks||36581
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Owen Leonard changed:
What|Removed |Added
Keywords|RM_priority |
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #51 from Victor Grousset/tuxayo ---
Nice :D
I'll submit my additional changes in another ticket.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Katrin Fischer changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #49 from Katrin Fischer ---
I have pushed the first patch yesterday as a compromise and to get this moving.
So far, Jenkins seems happy, but as this was a random failure, we are not
totally out of the woods yet.
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #48 from Victor Grousset/tuxayo ---
(In reply to Katrin Fischer from comment #47)
> what is needed to move forward?
The questions on comment 42 for Jonathan that are mostly about whether or not
the changes that I added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Katrin Fischer changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Victor Grousset/tuxayo changed:
What|Removed |Added
URL|https://gitlab.com/tuxayo/K |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #46 from Victor Grousset/tuxayo ---
Yes, that's the one I was talking about and which looks reliable to fix the
issue without creating a new one. And is a cleaner approach.
My additional patch is just a complement to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #45 from Katrin Fischer ---
Hi Victor, did you get a chance to look at Joubu's alternative patch approach?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #161609|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #44 from Victor Grousset/tuxayo ---
Created attachment 161631
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161631=edit
Bug 35506: additional hardening of selenium/regressions.t
For "Encoding in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #43 from Victor Grousset/tuxayo ---
Created attachment 161630
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161630=edit
Bug 35506: Move the checkouts table load delay logic out of document ready
==
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #160976|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #160975|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #42 from Victor Grousset/tuxayo ---
After some quick testing, the unexpected login page is also something that can
happen with the 1st proposal.
(In reply to Jonathan Druart from comment #41)
> There is nothing else,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #41 from Jonathan Druart ---
(In reply to Victor Grousset/tuxayo from comment #39)
> note: I'm running on top of b54da05c73 and not main/master since the last
> big push makes the alternate patch not apply.
Rebased.
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Jonathan Druart changed:
What|Removed |Added
Attachment #161302|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #39 from Victor Grousset/tuxayo ---
note: I'm running on top of b54da05c73 and not main/master since the last big
push makes the alternate patch not apply.
If the alternate patch still is pursued, the refactor that moves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Katrin Fischer changed:
What|Removed |Added
Keywords||RM_priority
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #38 from Victor Grousset/tuxayo ---
(In reply to Jonathan Druart from comment #36)
> Then why don't we simply add the event outside of the document.ready?
There is a reason to waiting for the document to be ready. **By
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Jonathan Druart changed:
What|Removed |Added
Attachment #161301|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Jonathan Druart changed:
What|Removed |Added
Depends on|33945 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Jonathan Druart changed:
What|Removed |Added
Depends on||33945
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #36 from Jonathan Druart ---
Then why don't we simply add the event outside of the document.ready?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #35 from Jonathan Druart ---
Created attachment 161301
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161301=edit
Bug 35506: [ALTERNATIVE PATCH] Move the checkouts table load delay logic out of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #33 from Victor Grousset/tuxayo ---
Created attachment 160976
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160976=edit
Bug 35506: Demo of the fix that uses flag in page JS
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #32 from Victor Grousset/tuxayo ---
Created attachment 160975
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160975=edit
Bug 35506: sabotage checkouts.js to reproduce flacky tests
== test plan ==
1.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #31 from Katrin Fischer ---
This one is back on D11 as of today:
koha_1 |
koha_1 | # Failed test 'Checkouts table must be correctly aligned'
koha_1 | # at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #30 from Jonathan Druart ---
Can you attach here one patch to recreate the problem and one (as simple as
possible) patch to fix it?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #29 from Jonathan Druart ---
(In reply to Victor Grousset/tuxayo from comment #28)
> In checkouts.js
> After `$(document).ready(function() {`
> Add `wait (5000);`
"Uncaught ReferenceError: wait is not defined"
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #28 from Victor Grousset/tuxayo ---
(In reply to Jonathan Druart from comment #27)
> However I do not see how your approach is correct. Selenium waits for the
> page to load before starting the tests.
It's a confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #27 from Jonathan Druart ---
I do not longer recreate the failure locally so it's hard to help here.
However I do not see how your approach is correct. Selenium waits for the page
to load before starting the tests.
I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #26 from Victor Grousset/tuxayo ---
Great, so the main idea of the patch doesn't have a fatal flaw. That was the
main focus of the last few days.
> What's the next step then
There is this question remaining:
Instead of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #25 from Jonathan Druart ---
What's the next step then, Victor?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #24 from Victor Grousset/tuxayo ---
After rerunning 2 times, I got the other error
# Failed test 'Checkouts table must be correctly aligned'
# at t/db_dependent/selenium/regressions.t line 213.
#
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #23 from Victor Grousset/tuxayo ---
I commented the calls to wait_for_page_fully_ready and after 7 run, I got again
this error:
Can't call method "get_text" on an undefined value at
t/db_dependent/selenium/regressions.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #22 from Victor Grousset/tuxayo ---
(In reply to Jonathan Druart from comment #21)
> window._pageFullyReady
>
> I don't understand how this is useful. Selenium should wait for the page to
> be loaded before starting the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #21 from Jonathan Druart ---
window._pageFullyReady
I don't understand how this is useful. Selenium should wait for the page to be
loaded before starting the tests.
If it's because of async statements, then this won't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Victor Grousset/tuxayo changed:
What|Removed |Added
URL|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #160511|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #20 from Victor Grousset/tuxayo ---
(In reply to Jonathan Druart from comment #19)
> > 1. What is DT_delay for?
>
> We want to make sure the AJAX request is there. In some cases (see bug
> 35284), the wait_for_ajax was
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #19 from Jonathan Druart ---
(In reply to Victor Grousset/tuxayo from comment #18)
> So it's almost done. Questions:
> 1. What is DT_delay for?
We want to make sure the AJAX request is there. In some cases (see bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #18 from Victor Grousset/tuxayo ---
> Created attachment
> Just a guess, we should wait for the ajax response before looking for
> the element in the table.
Wait, I'm really on this! Yes, that's one of things, at this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #17 from Jonathan Druart ---
Created attachment 160511
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160511=edit
Bug 35506: Trying to fix selenium error: Can't call method "get_text"
Just a guess, we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #16 from Jonathan Druart ---
(In reply to Victor Grousset/tuxayo from comment #14)
> Found some tactics that seem effective on test 'Encoding in session
> variables'
> and test 'Display circulation table correctly'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #15 from Katrin Fischer ---
Failed again with yesterday's run #2771.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #13 from Victor Grousset/tuxayo ---
> "show checkouts" button is greyed. Either it got clicked too fast before
> having it's
> handler and stayed like that with no action triggered. Or it tries very fast
> to do
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #12 from Nick Clemens ---
(In reply to Martin Renvoize from comment #10)
> I'm failing to replicate this locally :(.
I reproduced it with KitchenSink installed, which prevented the checkout
because of barcode mismatch -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #9 from Jonathan Druart ---
(In reply to Victor Grousset/tuxayo from comment #8)
> I can reproduce «Can't call method "get_text" on an undefined value»
How? Can you screenshot at this step?
> (In reply to Jonathan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Jonathan Druart changed:
What|Removed |Added
Keywords|RM_priority |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #7 from Jonathan Druart ---
Or fix both, will see.
Another thing to confirm: we click "#issues-table-load-now-button" but we do
not make sure it's ticked (maybe we untick it?!)
317
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #6 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #5)
> koha_1 | # Failed test 'Checkouts table must be correctly
> aligned'
> koha_1 | # at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #5 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #4)
> Still failing as of today on D11
>
> not ok 7 - Encoding in session variables
koha_1 | # Failed test 'Checkouts table must be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Katrin Fischer changed:
What|Removed |Added
Keywords||RM_priority
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #4 from Katrin Fischer ---
Still failing as of today on D11
not ok 7 - Encoding in session variables
OK when run locally:
prove t/db_dependent/selenium/regressions.t
t/db_dependent/selenium/regressions.t .. 6/8 Wide
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #3 from Katrin Fischer ---
Failing again with today's run:
https://jenkins.koha-community.org/job/Koha_Master/2762/
t_db_dependent_selenium_regressions_t.Display circulation table correctly (344)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
Jonathan Druart changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #2 from Jonathan Druart ---
Different one Koha_Master/2759 Docker_11
koha_1 | # Failed test 'Encoding in session variables'
koha_1 | # at t/db_dependent/selenium/regressions.t line 340.
koha_1 |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506
--- Comment #1 from Jonathan Druart ---
Same failure Koha_Master/2758 on Docker_8
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
71 matches
Mail list logo
