https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Katrin Fischer changed:
What|Removed |Added
Keywords|RM_priority |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Lucas Gass changed:
What|Removed |Added
Status|Pushed to stable|Pushed to oldstable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Fridolin Somers changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #67 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Katrin Fischer changed:
What|Removed |Added
Version(s)||24.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Martin Renvoize changed:
What|Removed |Added
Attachment #159860|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Martin Renvoize changed:
What|Removed |Added
Attachment #159848|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #63 from Marcel de Rooy ---
prove $(git grep -l Koha::Plugin | grep -P "^t\/db")
t/db_dependent/ImportBatch.t . ok
t/db_dependent/Koha/Patron/Consents.t ok
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #62 from Marcel de Rooy ---
I finally got the least harmful approach now. Removing the Method->delete here
and postponing that approach to 35536 and adding a verbose parameter in
Koha::Plugins at the can_load calls.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Marcel de Rooy changed:
What|Removed |Added
Attachment #159849|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #60
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #59 from Marcel de Rooy ---
(In reply to Kyle M Hall from comment #58)
> Signed-off-by: Kyle M Hall
Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #58 from Kyle M Hall ---
Created attachment 159850
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159850=edit
Bug 35507: (follow-up) Fix PluginRoutes.t
Why this works, is a mystery to me :)
Test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #57 from Kyle M Hall ---
Created attachment 159849
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159849=edit
Bug 35507: Add Plugins::Method->delete
Delete record in plugin_data too and clear cache.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Kyle M Hall changed:
What|Removed |Added
Attachment #159817|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #55 from Marcel de Rooy ---
Created attachment 159847
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159847=edit
Bug 35507: (follow-up) Fix PluginRoutes.t
Why this works, is a mystery to me :)
Test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Marcel de Rooy changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #54 from Marcel de Rooy ---
Created attachment 159846
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159846=edit
Bug 35507: Add Plugins::Method->delete
Delete record in plugin_data too and clear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #53 from Marcel de Rooy ---
Hmm reintroducing this guy now:
t/db_dependent/Koha/REST/Plugin/PluginRoutes.t ... 3/4
# Failed test 'Plugin enabled, route defined as
C4::Context->needs_install is false'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Marcel de Rooy changed:
What|Removed |Added
Attachment #159818|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #51 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #35)
> Still thinking too about the REPLACE with 0 in Method->delete. We could also
> remove but then we need to explicitly clear cache.
Martin: This
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #50 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #29)
> Not whole story yet, but now seeing this in KitchenSink:
>
> return C4::Context->dbh->do( "
> CREATE TABLE IF NOT EXISTS $table (
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #49 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #48)
> InstallPlugins contains
> Koha::Plugins::Methods->search({ plugin_class => $plugin_class })->delete();
>
> So this is restricted to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #48 from Marcel de Rooy ---
InstallPlugins contains
Koha::Plugins::Methods->search({ plugin_class => $plugin_class })->delete();
So this is restricted to $plugin_class. What is scary exactly?
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #47 from Martin Renvoize ---
Comment on attachment 159818
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159818
Bug 35507: Add Plugins::Method->delete
Review of attachment 159818:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #46 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #45)
> Trusting Marcel to continue the work he has started here.
Bug 35536 has been submitted now.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #45 from Jonathan Druart ---
Trusting Marcel to continue the work he has started here.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #44 from Jonathan Druart ---
Created attachment 159818
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159818=edit
Bug 35507: Add Plugins::Method->delete
Delete record in plugin_data too and clear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Jonathan Druart changed:
What|Removed |Added
Attachment #159801|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Marcel de Rooy changed:
What|Removed |Added
Attachment #159802|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
--- Comment #41 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #37)
> Note: Adding the singular delete, makes the plural loop and
> call the singular in Koha::Objects. Clearing the cache is
> done in the store_data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Marcel de Rooy changed:
What|Removed |Added
Summary|TestBuilder.t is failing|Fix handling plugins in
39 matches
Mail list logo
