[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Needs documenting

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 --- Comment #12 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 --- Comment #11 from Martin Renvoize --- Branch pushed to https://github.com/PTFS-Europe/koha/tree/bug_35788 -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Martin Renvoize changed: What|Removed |Added URL|

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 David Nind changed: What|Removed |Added CC||da...@davidnind.com

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Martin Renvoize changed: What|Removed |Added Blocks|35781 | Referenced Bugs:

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Martin Renvoize changed: What|Removed |Added Blocks||35248 Referenced Bugs:

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Martin Renvoize changed: What|Removed |Added Depends on|29002 | Referenced Bugs:

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #9

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 --- Comment #8 from Martin Renvoize --- I think Jonathan is right here.. as much as I'd love to just lean on the database to handle this, it doesn't take our timezone handling into account.. These are DATETIME fields, not

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Martin Renvoize changed: What|Removed |Added Depends on||29002 Referenced Bugs:

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 --- Comment #7 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #5) > Jonathan: if you agree with the follow-up, I'd say this is PQA. I don't know, we never decided what was the correct pattern. I always use

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 --- Comment #6 from Martin Renvoize --- I have a branch with tests in progress, they need submitting up.. I'll get in that. Thanks for this patchset chaps, looking good to me. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 --- Comment #5 from Tomás Cohen Arazi --- Jonathan: if you agree with the follow-up, I'd say this is PQA. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Tomás Cohen Arazi changed: What|Removed |Added Blocks||35789 Referenced

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 161041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161041=edit Bug 35788: Simplify code We should not load DateUtils and deal with DateTime objects

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 161040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161040=edit Bug 35788: Test for current day booking The implemented tests checked past and future

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Tomás Cohen Arazi changed: What|Removed |Added Attachment #160961|0 |1 is obsolete|

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 --- Comment #1 from Jonathan Druart --- Created attachment 160961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160961=edit Bug 35788: Remove Koha::Template::Plugin::Biblio::BookingsCount We need a new method

[Koha-bugs] [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You