https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Fridolin Somers changed:
What|Removed |Added
Status|Pushed to main |Needs documenting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #55 from Katrin Fischer ---
Hm yes and no - instructions for developers are probably helpful, but we also
need to know beforehand if a package makes sense/should be used. A check by PM
could highlight issues with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #54 from Martin Renvoize ---
Perhaps we should just highlight the relevant option for KTD.. or set the
default differently:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #53 from Katrin Fischer ---
(In reply to David Cook from comment #52)
> (In reply to Marcel de Rooy from comment #50)
> > (In reply to Katrin Fischer from comment #48)
> > > (In reply to Katrin Fischer from comment #46)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #51 from Katrin Fischer ---
(In reply to Marcel de Rooy from comment #50)
> (In reply to Katrin Fischer from comment #48)
> > (In reply to Katrin Fischer from comment #46)
> > > Note: This introduces a new dependency on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #50 from Marcel de Rooy ---
(In reply to Katrin Fischer from comment #48)
> (In reply to Katrin Fischer from comment #46)
> > Note: This introduces a new dependency on libalgorithm-munkres-perl.
>
> I have learned now
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #48 from Katrin Fischer ---
(In reply to Katrin Fischer from comment #46)
> Note: This introduces a new dependency on libalgorithm-munkres-perl.
I have learned now that this is a bigger deal than I thought.
Ideally the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #47 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Pushed to main
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #46 from Katrin Fischer ---
Note: This introduces a new dependency on libalgorithm-munkres-perl.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Katrin Fischer changed:
What|Removed |Added
Keywords||dependency
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #45 from Andreas Jonsson ---
I also recommend bug 35899 for busy libraries with many holds.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #44 from Katrin Fischer ---
(In reply to Nick Clemens from comment #43)
> (In reply to Martin Renvoize from comment #42)
> > Testing to PQA so it hurts Katrins queue again.
>
> Punish the RM with patches! :-D
I am
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #43 from Nick Clemens ---
(In reply to Martin Renvoize from comment #42)
> Testing to PQA so it hurts Katrins queue again.
Punish the RM with patches! :-D
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Andreas Jonsson changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Andreas Jonsson changed:
What|Removed |Added
Attachment #164505|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Andreas Jonsson changed:
What|Removed |Added
Attachment #164504|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Andreas Jonsson changed:
What|Removed |Added
Attachment #164503|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Andreas Jonsson changed:
What|Removed |Added
Attachment #164502|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Andreas Jonsson changed:
What|Removed |Added
Attachment #164501|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Kyle M Hall changed:
What|Removed |Added
Status|Passed QA |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Martin Renvoize changed:
What|Removed |Added
Attachment #163645|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Martin Renvoize changed:
What|Removed |Added
Attachment #163644|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Martin Renvoize changed:
What|Removed |Added
Attachment #163643|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Martin Renvoize changed:
What|Removed |Added
Attachment #163642|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Martin Renvoize changed:
What|Removed |Added
Attachment #163641|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Lisette Scheer changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #29 from Kyle M Hall ---
Created attachment 163645
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163645=edit
Bug 35826: Make copy of cost matrix when substituting inf
Signed-off-by: Kyle M Hall
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #28 from Kyle M Hall ---
Created attachment 163644
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163644=edit
Bug 35826: Add unit tests.
Signed-off-by: Kyle M Hall
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #27 from Kyle M Hall ---
Created attachment 163643
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163643=edit
Bug 35826: Keep items on retry.
Signed-off-by: Kyle M Hall
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #26 from Kyle M Hall ---
Created attachment 163642
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163642=edit
Bug 35826: Fix errors in transport cost optimization
Signed-off-by: Kyle M Hall
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Kyle M Hall changed:
What|Removed |Added
Attachment #161373|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Kyle M Hall changed:
What|Removed |Added
Status|In Discussion |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #24 from Andreas Jonsson ---
Created attachment 163107
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163107=edit
Bug 35826: Make copy of cost matrix when substituting inf
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #23 from Andreas Jonsson ---
Created attachment 163018
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163018=edit
Bug 35826: Add unit tests.
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #22 from Andreas Jonsson ---
Created attachment 163017
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163017=edit
Bug 35826: Keep items on retry.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #21 from Kyle M Hall ---
(In reply to Kyle M Hall from comment #20)
> (In reply to Andreas Jonsson from comment #19)
> > We have been running this in a test system of a large coalition of regional
> > Libraries, but I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Katie Bliss changed:
What|Removed |Added
CC||kebl...@dmpl.org
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #20 from Kyle M Hall ---
(In reply to Andreas Jonsson from comment #19)
> We have been running this in a test system of a large coalition of regional
> Libraries, but I think that we need a collection of unit tests to
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #19 from Andreas Jonsson ---
We have been running this in a test system of a large coalition of regional
Libraries, but I think that we need a collection of unit tests to sufficiently
test all aspects. It is too tedious
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #18 from Kyle M Hall ---
(In reply to George Williams (NEKLS) from comment #17)
> Is there a test plan for this?
I would say the test plan would be something along the lines of:
1) Enable the Transport Cost Matrix, set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
George Williams (NEKLS) changed:
What|Removed |Added
CC||geo...@nekls.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Michelle Spinney changed:
What|Removed |Added
CC||mspin...@clamsnet.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #16 from Nick Clemens ---
*** Bug 33796 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #15 from Kyle M Hall ---
Tests with production data from a large library with 61661 holds on 218573
records with 1798064 items:
kohadev-koha@kohadevbox:koha((fee4368cd81...))$ git checkout origin/master;
hyperfine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #14 from Kyle M Hall ---
More benchmarks:
build_holds_queue.pl with 3364 holds ( no tcm )
Master: ./misc/cronjobs/holds/build_holds_queue.pl
Time (mean ± σ): 6.447 s ± 0.678 s[User: 4.801 s, System: 0.196 s]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #13 from Kyle M Hall ---
(In reply to Andreas Jonsson from comment #11)
> I have created an RFC:
> https://wiki.koha-community.org/wiki/
> Optimize_holds_queue_building_using_the_Hungarian_Algorithm
>
> The discussion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #12 from Andreas Jonsson ---
Created attachment 161956
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161956=edit
Bug 35826: Fix errors in transport cost optimization
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #11 from Andreas Jonsson ---
I have created an RFC:
https://wiki.koha-community.org/wiki/Optimize_holds_queue_building_using_the_Hungarian_Algorithm
The discussion is on whether the community thinks that this is a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #9 from Andreas Jonsson ---
I have done some profiling using real library data from region libraries and
the algorithm itself cannot even be seen in the flame graph. It is the setup
that is costly. The setup is more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #8 from Kyle M Hall ---
kohadev-koha@kohadevbox:koha((24874c76354...))$ hyperfine --warmup 3 --runs 100
'perl t/db_dependent/HoldsQueue.t'
Benchmark 1: perl t/db_dependent/HoldsQueue.t
Time (mean ± σ): 4.009 s ±
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #7 from Andreas Jonsson ---
Sure:
https://github.com/Kreablo/Koha/tree/feature-optimize-holds-queue-with-transport-cost-matrix
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #6 from Kyle M Hall ---
Can you publish a branch somewhere?
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 35826: optimize on transport cost when building holds queue
error: sha1 information is lacking or useless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Catrina Berka changed:
What|Removed |Added
CC||catr...@bywatersolutions.co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #5 from Andreas Jonsson ---
Created attachment 161373
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161373=edit
Bug 35826: optimize on transport cost when building holds queue
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #4 from Kyle M Hall ---
(In reply to Andreas Jonsson from comment #3)
> Provided that all rows with all values being "infinity" and all columns with
> all values being "infinity" is removed from the cost matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #3 from Andreas Jonsson ---
Provided that all rows with all values being "infinity" and all columns with
all values being "infinity" is removed from the cost matrix beforehand and
there's still something left in the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #2 from Kyle M Hall ---
(In reply to Andreas Jonsson from comment #1)
> Created RFC:
> https://wiki.koha-community.org/wiki/
> Optimize_holds_queue_building_using_the_Hungarian_Algorithm
This all looks really great but
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
--- Comment #1 from Andreas Jonsson ---
Created RFC:
https://wiki.koha-community.org/wiki/Optimize_holds_queue_building_using_the_Hungarian_Algorithm
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Andreas Jonsson changed:
What|Removed |Added
URL|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35826
Andreas Jonsson changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun
69 matches
Mail list logo
