https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Fridolin Somers changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #73 from Fridolin Somers ---
(In reply to Katrin Fischer from comment #72)
> Hi Frido, why add the keyword, when this is already pushed?
Sorry it was to remember no backport to 23.11.x ;)
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Katrin Fischer changed:
What|Removed |Added
Keywords|rel_24_05_candidate |
--- Comment #72 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Fridolin Somers changed:
What|Removed |Added
Keywords||rel_24_05_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #71 from Emmi Takkinen ---
(In reply to Jonathan Druart from comment #69)
> (In reply to Emmi Takkinen from comment #68)
> > I'm currently facing problem with patron search in current master. There is
> > an error in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #70 from Pedro Amorim ---
(In reply to Emmi Takkinen from comment #68)
> I'm currently facing problem with patron search in current master. There is
> an error in browsers console
> > Uncaught ReferenceError:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #69 from Jonathan Druart ---
(In reply to Emmi Takkinen from comment #68)
> I'm currently facing problem with patron search in current master. There is
> an error in browsers console
> > Uncaught ReferenceError:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Emmi Takkinen changed:
What|Removed |Added
CC||emmi.takki...@koha-suomi.fi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #67 from Katrin Fischer ---
Missing patches pushed to master!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #66 from Katrin Fischer ---
Note to myself: push second and third patch too!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #64 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Pushed to master
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Katrin Fischer changed:
What|Removed |Added
Keywords|additional_work_needed |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #63 from Katrin Fischer ---
Follow-up "Restore passing deferLoading to DT" pushed to master.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #62 from Jonathan Druart ---
Created attachment 164005
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164005=edit
bug 36302: Restore passing deferLoading to DT
Signed-off-by: Pedro Amorim
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #61 from Jonathan Druart ---
Created attachment 164004
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164004=edit
Bug 36302: members-home.pl defers loading, member.pl does not
Signed-off-by: Jonathan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Jonathan Druart changed:
What|Removed |Added
Attachment #163917|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #59 from Pedro Amorim ---
I couldn't see the blinking but there was definitely a GET happening in the
background. I think this should be good to go as is?
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Pedro Amorim changed:
What|Removed |Added
Attachment #163974|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #57 from Jonathan Druart ---
(In reply to Pedro Amorim from comment #56)
> (In reply to Jonathan Druart from comment #54)
> > You have not put back defer_loading to DT's options, was it expected? If we
> > don't the GET
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #56 from Pedro Amorim ---
(In reply to Jonathan Druart from comment #54)
> You have not put back defer_loading to DT's options, was it expected? If we
> don't the GET is done (ie. we will fetch the first 20 patrons).
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #55 from Jonathan Druart ---
+let defer_loading = Number( '[% defer_loading | html %]' || 1 );
This is kind of working but it reads really bad IMO.
Number ('0' || 1) => 0
Number (0 || 1) => 1
Javascript...
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #54 from Jonathan Druart ---
You have not put back defer_loading to DT's options, was it expected? If we
don't the GET is done (ie. we will fetch the first 20 patrons).
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #53 from Jonathan Druart ---
Created attachment 163974
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163974=edit
bug 36302: Restore passing deferLoading to DT
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #52 from Jonathan Druart ---
I am wondering if loading the table is expected when coming from this link:
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
233
We
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Katrin Fischer changed:
What|Removed |Added
Status|REOPENED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Katrin Fischer changed:
What|Removed |Added
Resolution|FIXED |---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #50 from Pedro Amorim ---
Created attachment 163918
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163918=edit
Bug 36302: members-home.pl defers loading, member.pl does not
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #49 from Pedro Amorim ---
Created attachment 163917
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163917=edit
Bug 36302: Reinstate defer_loading
defer_loading is now a patron_search_js BLOCK param -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Jonathan Druart changed:
What|Removed |Added
Keywords|RM_priority |additional_work_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #48 from Jonathan Druart ---
Regression: patron list is loaded when placing a hold:
http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=9
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Fridolin Somers changed:
What|Removed |Added
Status|Pushed to master|RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #46 from Martin Renvoize ---
It's a fix for a bug caused by the csrf work.. so I don't believe it's required
for your branch fridolin.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #44 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Katrin Fischer changed:
What|Removed |Added
Version(s)||24.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #43 from Jonathan Druart ---
Not convinced this is the best we can do but at least we are fixing the bad
bug. We will see for the side-effects later.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Jonathan Druart changed:
What|Removed |Added
Attachment #163122|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #41 from Jonathan Druart ---
(In reply to Pedro Amorim from comment #40)
> (In reply to Jonathan Druart from comment #39)
> > I've tested the ALTERNATIVE patch alone and I get a weird JS error in the
> > console:
> >
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #40 from Pedro Amorim ---
(In reply to Jonathan Druart from comment #39)
> I've tested the ALTERNATIVE patch alone and I get a weird JS error in the
> console:
>
> Uncaught SyntaxError: unexpected token: '!'
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #39 from Jonathan Druart ---
I've tested the ALTERNATIVE patch alone and I get a weird JS error in the
console:
Uncaught SyntaxError: unexpected token: '!'
http://localhost:8081/cgi-bin/koha/members/members-home.pl
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #38 from Pedro Amorim ---
(In reply to Katrin Fischer from comment #34)
> I think this is/was about saving clicks for the circulation desk mostly. If
> you scan a card, they want to go directly to the patron account. I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Nick Clemens changed:
What|Removed |Added
Attachment #163207|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #36 from Katrin Fischer ---
(In reply to Nick Clemens from comment #35)
> (In reply to Katrin Fischer from comment #34)
> > (In reply to Pedro Amorim from comment #31)
> > > I don't agree with this behavior, i.e.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #35 from Nick Clemens ---
(In reply to Katrin Fischer from comment #34)
> (In reply to Pedro Amorim from comment #31)
> > I don't agree with this behavior, i.e. redirecting to the single search
> > result if only one is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #34 from Katrin Fischer ---
(In reply to Pedro Amorim from comment #31)
> I don't agree with this behavior, i.e. redirecting to the single search
> result if only one is returned:
> 1) Maybe this is the norm? But I have
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #33 from Pedro Amorim ---
The noop approach is/was hacky and it doesn't seem to fix the issue entirely
anyway.
I'm submitting my first approach again as an alternative patch and let others
decide which route is better.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #32 from Pedro Amorim ---
Created attachment 163207
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163207=edit
Bug 36302: [ALTERNATIVE] Get rid of defer_loading
Same test plan as the other patch,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #31 from Pedro Amorim ---
I don't agree with this behavior, i.e. redirecting to the single search result
if only one is returned:
1) Maybe this is the norm? But I have personally not seen other search systems
with this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Julian Maurice changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #29 from Nick Clemens ---
(In reply to Jonathan Druart from comment #28)
> Nick, do you know what is the behaviour in stable branches?
On a 23.05 site
In firefox I get redirected to patron if I hit back
In chrome I get
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #28 from Jonathan Druart ---
Nick, do you know what is the behaviour in stable branches?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #27 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #26)
> Ha good catch! There is another form to adjust!
Absolutely not!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #26 from Jonathan Druart ---
Ha good catch! There is another form to adjust!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #25 from Nick Clemens ---
(In reply to Jonathan Druart from comment #24)
> I am sorry but... I am still getting the redirect to the patron detail page
> after hitting the back button.
>
> BUT I have tried v23.11.00 and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #24 from Jonathan Druart ---
I am sorry but... I am still getting the redirect to the patron detail page
after hitting the back button.
BUT I have tried v23.11.00 and it behaving like that as well.
Sure I tried
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
David Nind changed:
What|Removed |Added
Attachment #163121|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Lucas Gass changed:
What|Removed |Added
Attachment #163113|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Lucas Gass changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Pedro Amorim changed:
What|Removed |Added
Attachment #163108|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #20 from Jonathan Druart ---
Still not happy with it, under Firefox:
* Go to mainpage
* Click "Patrons" in the header
=> You are on http://localhost:8081/cgi-bin/koha/members/members-home.pl
* "Search for patrons":
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #19 from Pedro Amorim ---
(In reply to Brendan Lawlor from comment #7)
> Not sure if I'm missing something, but with this patch applied the back
> button still works how I would expect it to.
>
> If I search from the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #18 from Pedro Amorim ---
Created attachment 163109
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163109=edit
Bug 36302: use replace instead of href
This will change URL but not fiddle with browser
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Pedro Amorim changed:
What|Removed |Added
Attachment #163099|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Pedro Amorim changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Pedro Amorim changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #16 from Jonathan Druart ---
(In reply to Pedro Amorim from comment #13)
> Created attachment 163106 [details] [review] [review]
> Bug 36302: Remove unused code
>
> Please can someone tell me why we need this code?
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #15 from Jonathan Druart ---
(In reply to Pedro Amorim from comment #12)
> Created attachment 163105 [details] [review]
> Bug 36302: Use replace instead of href
>
> This will change URL but not fiddle with browser
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #14 from Jonathan Druart ---
(In reply to Pedro Amorim from comment #13)
> Created attachment 163106 [details] [review]
> Bug 36302: Remove unused code
>
> Please can someone tell me why we need this code?
> Inititally
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #13 from Pedro Amorim ---
Created attachment 163106
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163106=edit
Bug 36302: Remove unused code
Please can someone tell me why we need this code?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #12 from Pedro Amorim ---
Created attachment 163105
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163105=edit
Bug 36302: Use replace instead of href
This will change URL but not fiddle with browser
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Pedro Amorim changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #11 from Pedro Amorim ---
Having discussed this with Jonathan, the regression he mentions on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302#c9
is only reproduce able with Firefox, not Chrome.
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #10 from Jonathan Druart ---
Another regression/behaviour change is that hitting
http://localhost:8081/cgi-bin/koha/members/members-home.pl will load the table
and display the X first patrons.
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #9 from Jonathan Druart ---
defer_loading is coming from
commit f6394501f2ae6468cef8279ba8e296427cb69188
Bug 30063: Restore back behaviour
See 30063 comment 23 (point 6).
To recreate:
1. search 'henry'
2. the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #8 from Jonathan Druart ---
defer_loading is coming from
commit f6394501f2ae6468cef8279ba8e296427cb69188
Bug 30063: Restore back behaviour
See 30063 comment 23 (point 6).
To recreate:
1. search 'henry'
2. the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #7 from Brendan Lawlor ---
Not sure if I'm missing something, but with this patch applied the back button
still works how I would expect it to.
If I search from the main page for Henry, it takes me directly to that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #6 from Katrin Fischer ---
(In reply to Pedro Amorim from comment #4)
> I believe this defer_loading check was added here to have the "back" browser
> behavior work in the event that a search only returned 1 result and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Brendan Lawlor changed:
What|Removed |Added
CC||blaw...@clamsnet.org
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Brendan Lawlor changed:
What|Removed |Added
Attachment #163096|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Brendan Lawlor changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #4 from Pedro Amorim ---
I believe this defer_loading check was added here to have the "back" browser
behavior work in the event that a search only returned 1 result and the
cgi->redirect to that result kicks in (as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Pedro Amorim changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Pedro Amorim changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
--- Comment #2 from Pedro Amorim ---
Created attachment 163096
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163096=edit
Bug 36302: Remove defer_loading logic
Test plan, ktd:
1) Search "henry" on the top search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Pedro Amorim changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Katrin Fischer changed:
What|Removed |Added
Severity|enhancement |critical
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36302
Martin Renvoize changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun
93 matches
Mail list logo
