[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Fridolin Somers changed: What|Removed |Added CC|

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 --- Comment #12 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Passed QA -- You are

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 --- Comment #11 from Martin Renvoize --- Created attachment 164910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164910=edit Bug 36343: (QA follow-up) Add warning in DB update -- You are receiving this mail

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 --- Comment #10 from Martin Renvoize --- Good questions.. we can certainly add a DB update to visibly warn people at upgrade time. In the longer term I'd like to see this sort of thing documented in the developers' side of the

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA -- You are

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 --- Comment #9 from Katrin Fischer --- Agree with the change, but would like to see a reply to Marcel's comment before pushing. Another thing we should do is update the hooks wiki page with a note. -- You are receiving this mail

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 --- Comment #8 from Marcel de Rooy --- min or enh? What about backports? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 --- Comment #7 from Marcel de Rooy --- Apart from release notes maybe even db rev to print warning? How do we arrange for the needed follow-up ? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Marcel de Rooy changed: What|Removed |Added Keywords||release-notes-needed --

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 --- Comment #6 from Marcel de Rooy --- Created attachment 164456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164456=edit Bug 36343: (QA follow-up) Adjust two other occurrences Signed-off-by: Marcel de Rooy

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Marcel de Rooy changed: What|Removed |Added Attachment #163768|0 |1 is obsolete|

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 --- Comment #4 from Marcel de Rooy --- sub generate_userid { my ( $self ) = @_; my @responses = Koha::Plugins->call( 'patron_generate_userid', { patron => $self }, -- You are receiving this mail because: You are

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 --- Comment #3 from Marcel de Rooy --- sub _after_item_action_hooks { my ( $self, $params ) = @_; my $action = $params->{action}; Koha::Plugins->call( 'after_item_action', { action =>

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Frédéric Demians changed: What|Removed |Added Attachment #163328|0 |1 is obsolete|

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Frédéric Demians changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 --- Comment #1 from Martin Renvoize --- Created attachment 163328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163328=edit Bug 36343: Add support for 'payload' to _after_biblio_action This patch adds support

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Martin Renvoize changed: What|Removed |Added Severity|enhancement |minor -- You are

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Martin Renvoize changed: What|Removed |Added Keywords||Hackfest -- You are

[Koha-bugs] [Bug 36343] The 'after_biblio_action' hooks have an inconsistent signature compared to before_biblio_action, and actions in reserves and items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36343 Martin Renvoize changed: What|Removed |Added CC|