http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Status|Pushed to Master|RESOLVED
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Passed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Marc Véron ve...@veron.ch changed:
What|Removed |Added
CC||ve...@veron.ch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #81 from Marc Véron ve...@veron.ch ---
I got the following Error in the Web Installer (Step 3)
ERROR 1064 (42000) at line 2821: You have an error in your SQL syntax; check
the manual that corresponds to your MySQL server
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #82 from Marc Véron ve...@veron.ch ---
Created attachment 9159
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9159action=edit
Bug 5668 Error during during insall with web installer, Step 3
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Marc Véron ve...@veron.ch changed:
What|Removed |Added
Status|Pushed to Master|ASSIGNED
--
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Marc Véron ve...@veron.ch changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #8706|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Severity|critical
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #9159|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Attachment #9163|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #88 from Mason James m...@kohaaloha.com ---
(In reply to comment #85)
Hi Mason, can you attach your signed off patch to the bug please? Thank you!
Also updating severity, because currently it breaks installation.
yep,
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Passed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Attachment #8705|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #73 from Mason James m...@kohaaloha.com ---
(In reply to comment #68)
Comment on attachment 8537 [details]
Bug 5668 - Star ratings in the opac
Had to rebase anyway, so the above mention change (remove use C4::Serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Attachment #8548|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Attachment #8537|1 |0
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Status|Failed QA |Passed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #76 from Mason James m...@kohaaloha.com ---
Created attachment 8704
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8704action=edit
Bug 5668 - Star ratings in the opac
patch applied to commit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Attachment #8537|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Passed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Passed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #70 from Mason James m...@kohaaloha.com ---
(In reply to comment #69)
QA comment:
I checked perlcritic and there's an error:
opac/opac-ratings-ajax.pl: Subroutine prototypes used at line 107, column 1.
See page 194 of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #71 from Mason James m...@kohaaloha.com ---
Created attachment 8613
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8613action=edit
Attachment to Bug 5668 - Star ratings in the opac
mason@xen1:~/g/head2$
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Status|Failed QA |Passed QA
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #61 from Ian Walls koha.sek...@gmail.com ---
Created attachment 8514
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8514action=edit
Enh 5668 Followup: fix BakerTaylorContentURL typo
Restores
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #62 from Mason James m...@kohaaloha.com ---
System preference is classed as Choice, between 'yes', 'no' and 'details',
but the default value is 0, and the code tests on 1|details. Need to sort
out this to consistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #63 from Mason James m...@kohaaloha.com ---
(In reply to comment #62)
System preference is classed as Choice, between 'yes', 'no' and 'details',
but the default value is 0, and the code tests on 1|details. Need to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #64 from Mason James m...@kohaaloha.com ---
(In reply to comment #62)
System preference is classed as Choice, between 'yes', 'no' and 'details',
but the default value is 0, and the code tests on 1|details. Need to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Attachment #8359|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #67 from Ian Walls koha.sek...@gmail.com ---
Created attachment 8548
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8548action=edit
[PASSED QA] Bug 5668 - Star ratings in the opac
Signed-off-by: Nicole C.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Ian Walls koha.sek...@gmail.com changed:
What|Removed |Added
Attachment #8537|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #59 from Ian Walls koha.sek...@gmail.com ---
Looking good, almost there.
Problems:
Unit tests don't work on other database than the testing db, leading to errors
in auto testing suites. --- I have a followup patch to fix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #60 from Ian Walls koha.sek...@gmail.com ---
Created attachment 8459
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8459action=edit
Enh 5668 Followup: only run borrower-specific unit tests if borrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Attachment #8326|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #54 from Ian Walls koha.sek...@gmail.com ---
Created attachment 8312
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8312action=edit
Bug 5668 - Star ratings in the opac
applied to commit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Ian Walls koha.sek...@gmail.com changed:
What|Removed |Added
Attachment #8202|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #55 from Ian Walls koha.sek...@gmail.com ---
I've rebased this as part of the QA process, and figured I'd attach it here
since I'm at a stopping point for the moment.
This seems to work alright, but
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #56 from Mason James m...@kohaaloha.com ---
(In reply to comment #55)
I've rebased this as part of the QA process, and figured I'd attach it here
since I'm at a stopping point for the moment.
This seems to work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Attachment #8312|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Nicole C. Engard neng...@gmail.com changed:
What|Removed |Added
Attachment #8199|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Nicole C. Engard neng...@gmail.com changed:
What|Removed |Added
Status|Needs Signoff |Signed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #50 from Mason James m...@kohaaloha.com ---
so heres my patch... with all the outstanding issued resolved ;)
1/ Why did you comment some unit tests ? They are ok.
FIXED
2/ You declare OpacStarRatings for template in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Attachment #8027|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Assignee|srd...@catalyst.net.nz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #48 from Owen Leonard oleon...@myacpl.org ---
(In reply to comment #46)
Embeding IF tags: that is a great pain. I have a workaround, but I don't
really understand the issue here. checked needs no translation, but
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #49 from Srdjan Jankovic srd...@catalyst.net.nz ---
Yes, it uses ?. I thought I could trick, it but the script is too clever for me
:)
I would change it if there was no other way, but the whole thing *is* wrong:
* ? (or IF,
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #46 from Srdjan Jankovic srd...@catalyst.net.nz ---
This is a patch that I'm trying to upstream, so I cannot give exact answers for
all:
1/ Why did you comment some unit tests ? They are ok.
Fixed
2/ You declare
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Srdjan Jankovic srd...@catalyst.net.nz changed:
What|Removed |Added
Attachment #7798|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Srdjan Jankovic srd...@catalyst.net.nz changed:
What|Removed |Added
Status|Failed QA |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Srdjan Jankovic srd...@catalyst.net.nz changed:
What|Removed |Added
Attachment #7604|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Srdjan Jankovic srd...@catalyst.net.nz changed:
What|Removed |Added
Status|Patch doesn't apply |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
Status|Needs Signoff |Patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Srdjan Jankovic srd...@catalyst.net.nz changed:
What|Removed |Added
Attachment #7165|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #39 from Mason James m...@kohaaloha.com 2012-01-18 12:59:58 UTC
---
Created attachment 7215
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7215
[SIGNED-OFF] Bug 5668: Follow up - Star ratings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Priority|PATCH-Sent (DO NOT USE) |P3
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #7116|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #38 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-15
22:05:54 UTC ---
Created attachment 7166
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7166
Bug 5668: Follow up - Star ratings
- adds new
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Attachment #5792|0 |1
is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Version|rel_3_6 |master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #34 from Mason James m...@kohaaloha.com 2012-01-09 02:47:59 UTC
---
(In reply to comment #30)
The dependency on Smart::Comments should be removed, and the SQL error is due
to a change from having an ID column to having a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #28 from Magnus Enger mag...@enger.priv.no 2011-12-29 19:27:38
UTC ---
When I run updatedatabase.pl I get this error: DBD::mysql::db do failed: Key
column 'rating_id' doesn't exist in table at
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #30 from Robin Sheat ro...@catalyst.net.nz 2011-12-29 19:34:05
UTC ---
The dependency on Smart::Comments should be removed, and the SQL error is due
to a change from having an ID column to having a composite key (as you
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #32 from Robin Sheat ro...@catalyst.net.nz 2011-12-29 19:44:13
UTC ---
IIRC Smart::Comments is a development/debugging thing, so there's no real need
nor want to keep it in the production code.
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Magnus Enger mag...@enger.priv.no changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Liz Rea wizzy...@gmail.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #25 from Liz Rea wizzy...@gmail.com 2011-11-04 20:33:57 UTC ---
do note this introduces a dependency for Smart::Comments. You will need it for
proper testing (it won't work without it).
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #26 from Liz Rea wizzy...@gmail.com 2011-11-04 20:36:06 UTC ---
http://screencast.com/t/tt56vcqqQT38 here is a screencast of what I was
experiencing.
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Patch Status|Pushed For QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #21 from Robin Sheat ro...@catalyst.net.nz 2011-10-11 02:34:01
UTC ---
Created attachment 5833
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5833
Bug 5668 - fix comments in the SQL definition so MySQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #18 from Mason James m...@kohaaloha.com 2011-10-08 11:11:50 UTC
---
(In reply to comment #16)
Some issues, in order of descending importance:
hi Ian
i have subitted a patch to address your 3 BLOCKER issues...
1)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Patch Status|Failed QA |Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #19 from Mason James m...@kohaaloha.com 2011-10-08 11:16:22 UTC
---
Created attachment 5794
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5794
pix
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #20 from Mason James m...@kohaaloha.com 2011-10-08 11:18:58 UTC
---
(In reply to comment #17)
Created attachment 5792 [details]
patch
patch applied to commit cfe8b6bd9a4f1921cb728d784083300344bcf2b1
Author: Jonathan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Patch Status|Needs Signoff |Pushed For QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
AssignedTo|ro...@catalyst.net.nz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Ian Walls ian.wa...@bywatersolutions.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Nicole C. Engard neng...@gmail.com changed:
What|Removed |Added
Patch Status|Needs Signoff |Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #10 from Robin Sheat ro...@catalyst.net.nz 2011-08-25 00:16:54
UTC ---
Created attachment 5136
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5136
Bug 5668 - star ratings in the OPAC
This takes the work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Robin Sheat ro...@catalyst.net.nz changed:
What|Removed |Added
Patch Status|Failed QA |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Nicole C. Engard neng...@gmail.com changed:
What|Removed |Added
Patch Status|Needs Signoff |Does not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Nicole C. Engard neng...@gmail.com changed:
What|Removed |Added
Attachment #5097|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Nicole C. Engard neng...@gmail.com changed:
What|Removed |Added
Attachment #5098|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Nicole C. Engard neng...@gmail.com changed:
What|Removed |Added
Attachment #5136|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Nicole C. Engard neng...@gmail.com changed:
What|Removed |Added
Patch Status|Does not apply |Signed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #15 from Robin Sheat ro...@catalyst.net.nz 2011-08-25 01:25:09
UTC ---
I think you applied on top of the already applied patch, rather than from
master, which is what caused those messages. But, all good that it's working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #7 from Robin Sheat ro...@catalyst.net.nz 2011-08-23 00:39:15 UTC
---
Created attachment 5097
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5097
Bug 5668 - star ratings in the OPAC
This takes the work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Robin Sheat ro...@catalyst.net.nz changed:
What|Removed |Added
Priority|P5 |PATCH-Sent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #8 from Robin Sheat ro...@catalyst.net.nz 2011-08-23 00:44:37 UTC
---
Created attachment 5098
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5098
Bug 5668 - adds the 'delete.gif' image
This was
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Mason James m...@kohaaloha.com changed:
What|Removed |Added
Version|rel_3_4 |rel_3_6
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Robin Sheat ro...@catalyst.net.nz changed:
What|Removed |Added
Status|NEW |ASSIGNED
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-04-25
00:30:25 UTC ---
What is the status of this bug?
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Blocks||1598
100 matches
Mail list logo