[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|enhancement |new

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Blocks||9919 --

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #41 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #40) Hi Jared, I can see what you mean, but 0 is the default behaviour for the other fields (max holds, max renwals) so from this point of

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #43 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #40) Hi Jared, I can see what you mean, but 0 is the default behaviour for the other fields (max holds, max renwals) so from this point of

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #44 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I agree with you - just saying that the inconsistency was not introduced by this patch - it's there already and there is no regression. :) -- You are receiving this

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #40 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jared, I can see what you mean, but 0 is the default behaviour for the other fields (max holds, max renwals) so from this point of view it's consistent. -- You are

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #29 from jmbroust jean-manuel.bro...@univ-lyon2.fr --- (En réponse au commentaire 28) Hi, I think this might be a configuation issue - could you check the value in the system preference RenewalPeriodBase? If it's set to

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16382 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16382action=edit Bug 8365: Followup Force DateTime type for the datedue

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16386 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16386action=edit Bug 8365: FIX Return issue values instead of item values

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #34 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 16396 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16396action=edit Bug 8365: FIX Return issue values instead of item values Before

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #16386|0 |1

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #16213|0 |1

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #36 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16434 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16434action=edit [PASSED QA] Bug 8365: Add unit tests and fix QA issues This

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #37 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16435 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16435action=edit [PASSED QA] Bug 8365: Followup Force DateTime type for the

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #38 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16436 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16436action=edit [PASSED QA] Bug 8365: FIX Return issue values instead of item

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 16214 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16214action=edit Bug 8365: Add unit tests and fix QA issues This patch adds

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #16120|0

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 jmbroust jean-manuel.bro...@univ-lyon2.fr changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #28 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi, I think this might be a configuation issue - could you check the value in the system preference RenewalPeriodBase? If it's set to calculate from today's date, the

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, the new unit tests don't pass the QA script - can you take a look please? But I will continue testing :) * t/db_dependent/Circulation_issuingrules.t

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #20) Hi Jonathan, the new unit tests don't pass the QA script - can you take a look please? But I will continue testing :) *

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #15360|0 |1

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16121 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16121action=edit [PASSED QA] Bug 8365: Add unit tests and fix QA issues This

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #15301|0 |1

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #19 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15361 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15361action=edit Bug 8365: Add unit tests and fix QA issues This patch adds some

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I learned that iff is not a typo, so ignore that :) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14142|0

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15300|0

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, thx for taking my comments into account! The follow up looks good to me, but I think the commit message belongs to another patch? -- You are receiving this

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15302|0

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC|

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, I read through your code and have some questions, mostly about documentation: 1) I was wondering if this line in the POD for CanBookBeRenewed makes sense:

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #13972|0 |1

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Patch

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #12054|0

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #2) Hello Owen, Thanks for your question. It permits me to improve this patch :) How is the renewal date calculated if the renewals period is

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #2 from Owen Leonard oleon...@myacpl.org --- How is the renewal date calculated if the renewals period is set to zero (as it will be when the feature is added on top of an existing installation) ? Shouldn't this feature

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 12054 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12054action=edit Bug 8365: Add a renewal duration in the issuing rules Renew

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Blocks||8362

[Koha-bugs] [Bug 8365] Renewal duration in issuingules

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 claire.hernan...@biblibre.com claire.hernan...@biblibre.com changed: What|Removed |Added CC|