https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #234 from Aleisha Amohia ---
There are lots of signoffs on these patches, can this be marked Passed QA?
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
George Williams (NEKLS) changed:
What|Removed |Added
CC||geo...@nekls.org
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
koha-US bug tracker changed:
What|Removed |Added
CC||bugzi...@koha-us.org
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
ByWater Sandboxes changed:
What|Removed |Added
Attachment #147807|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
ByWater Sandboxes changed:
What|Removed |Added
Attachment #147806|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
ByWater Sandboxes changed:
What|Removed |Added
Attachment #147805|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
ByWater Sandboxes changed:
What|Removed |Added
Attachment #147804|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
ByWater Sandboxes changed:
What|Removed |Added
Attachment #147803|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
ByWater Sandboxes changed:
What|Removed |Added
Attachment #147802|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
ByWater Sandboxes changed:
What|Removed |Added
Attachment #147801|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
ByWater Sandboxes changed:
What|Removed |Added
Attachment #147800|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
ByWater Sandboxes changed:
What|Removed |Added
Attachment #147799|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
ByWater Sandboxes changed:
What|Removed |Added
Attachment #147798|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #223 from David Cook ---
I'm interested in this one, so planning to take a look. Have a few other things
I need to do first, but just a FYI
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Nick Clemens changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Nick Clemens changed:
What|Removed |Added
Status|Passed QA |Signed Off
--- Comment #222 f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #221 from Nick Clemens ---
Created attachment 147807
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147807&action=edit
Bug 8367: (QA follow-up) Improve display when value not set for rule
When a rule is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #220 from Nick Clemens ---
Created attachment 147806
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147806&action=edit
Bug 8376: (QA follow-up) Update message on Hold waiting pickup report
Signed-off-by
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #219 from Nick Clemens ---
Created attachment 147805
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147805&action=edit
Bug 8367: (follow-up) possible to delete circ rule
Signed-off-by: Emmi Takkinen
Si
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #218 from Nick Clemens ---
Created attachment 147804
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147804&action=edit
Bug 8367: (follow-up) Remove unnecessary code and atomic update
Signed-off-by: Emmi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #217 from Nick Clemens ---
Created attachment 147803
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147803&action=edit
Bug 8367: (follow-up) Fix tests
Signed-off-by: Emmi Takkinen
Signed-off-by: Nick C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #216 from Nick Clemens ---
Created attachment 147802
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147802&action=edit
Bug 8367: (follow-up) Remove pickup delay message from OPAC
It adds unnecessary com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #215 from Nick Clemens ---
Created attachment 147801
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147801&action=edit
Bug 8367: (follow-up) Fix pickup delay text on OPAC and other bits
Signed-off-by: E
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #214 from Nick Clemens ---
Created attachment 147800
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147800&action=edit
Bug 8367: Make database update idempotent (across different MariaDB versions)
The p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #213 from Nick Clemens ---
Created attachment 147799
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147799&action=edit
Bug 8367: Make database update idempotent
Signed-off-by: Emmi Takkinen
Signed-off-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Nick Clemens changed:
What|Removed |Added
Attachment #144097|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Emmi Takkinen changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Emmi Takkinen changed:
What|Removed |Added
Attachment #145644|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #210 from Aleisha Amohia ---
Created attachment 145644
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145644&action=edit
Bug 8367: (follow-up) possible to delete circ rule
--
You are receiving this mai
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Sara Brown changed:
What|Removed |Added
CC||sbr...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Emmi Takkinen changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #209 f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #208 from Katrin Fischer ---
(In reply to Emmi Takkinen from comment #207)
> Tested this again and everything seems to work as described. However
> circulation rule with "Holds pickup period (day)" column filled cannot be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #207 from Emmi Takkinen ---
Tested this again and everything seems to work as described. However
circulation rule with "Holds pickup period (day)" column filled cannot be
deleted. There is a similar problem with column "De
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Emmi Takkinen changed:
What|Removed |Added
Attachment #144103|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #142903|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #142902|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #142901|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #142900|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #142899|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #142898|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #142897|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #198 from Emmi Takkinen ---
Note that there is a bug here similar to bug 30694 but with
holds_pickup_period.
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #197 from David Cook ---
I'll try to keep my eyes upon to QA this one when it's ready.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Emmi Takkinen changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- Comm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #195 from Aleisha Amohia ---
Created attachment 142903
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142903&action=edit
Bug 8367: (follow-up) Remove unnecessary code and atomic update
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #133094|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #133093|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #133092|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #133091|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #133090|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #133089|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Katrin Fischer changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Katrin Fischer changed:
What|Removed |Added
CC||jza...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Joelle Hannert changed:
What|Removed |Added
CC||jhann...@nmc.edu
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #187 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
CC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #131724|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #131723|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #131722|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #131720|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #131719|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #131718|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Owen Leonard changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Emmi Takkinen changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #180
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Emmi Takkinen changed:
What|Removed |Added
Attachment #131300|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Emmi Takkinen changed:
What|Removed |Added
Attachment #131647|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Emmi Takkinen changed:
What|Removed |Added
Attachment #131646|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Emmi Takkinen changed:
What|Removed |Added
Attachment #131302|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Emmi Takkinen changed:
What|Removed |Added
Attachment #131301|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #175 from Emmi Takkinen ---
Created attachment 131719
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131719&action=edit
Bug 8367: Make database update idempotent
Signed-off-by: Emmi Takkinen
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Emmi Takkinen changed:
What|Removed |Added
Attachment #131299|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #173 from Aleisha Amohia ---
Created attachment 131647
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131647&action=edit
Bug 8367: (follow-up) Fix tests
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #172 from Aleisha Amohia ---
Created attachment 131646
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131646&action=edit
Bug 8367: (follow-up) Remove pickup delay message from OPAC
It adds unnecessary c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Emmi Takkinen changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #171 f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #170 from Aleisha Amohia ---
Created attachment 131302
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131302&action=edit
Bug 8367: (follow-up) Fix pickup delay text on OPAC and other bits
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #125087|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #124568|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Attachment #118021|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Aleisha Amohia changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #166 from Emmi Takkinen ---
What's the status of this bug? Is it still Failed QA or could it be changed as
Needs Signoff?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #165 from David Cook ---
Created attachment 125087
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125087&action=edit
Bug 8367: Make database update idempotent (across different MariaDB versions)
The pre
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #164 from David Cook ---
(In reply to David Cook from comment #157)
> Created attachment 124568 [details] [review]
> Bug 8367: Make database update idempotent
This query works on MariaDB 10.1.48 (used by koha-testing-dock
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Andrew Fuerste-Henry changed:
What|Removed |Added
CC||and...@bywatersolution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #163 from David Cook ---
(In reply to David Cook from comment #161)
> I don't think this patch takes into account
> C4::Reserves::CancelExpiredReserves which gets called by the cronjob
> /usr/share/koha/bin/cronjobs/holds/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #162 from David Cook ---
Actually, I don't think we really need the changes to opac-reserve.pl and
opac-reserve.tt. Those changes just add complexity. While they give patrons a
little bit more information about when the ho
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #161 from David Cook ---
I don't think this patch takes into account C4::Reserves::CancelExpiredReserves
which gets called by the cronjob
/usr/share/koha/bin/cronjobs/holds/cancel_expired_holds.pl
--
You are receiving th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #160 from David Cook ---
Comment on attachment 118021
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118021
Bug 8367: Add holds_pickup_period circulation rule
Review of attachment 118021:
-->
(https:/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #159 from David Cook ---
Comment on attachment 118021
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118021
Bug 8367: Add holds_pickup_period circulation rule
Review of attachment 118021:
-->
(https:/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #158 from David Cook ---
I'm finding this test plan a bit difficult to follow.
What does "7) Revert the waiting status" mean?
--
Repeating Rhonda's mention that the pickup message doesn't change for "8)
Re-place the hol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #157 from David Cook ---
Created attachment 124568
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124568&action=edit
Bug 8367: Make database update idempotent
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #156 from David Cook ---
The bug_8367-add_holds_pickup_period_circrule.perl script is not idempotent. It
shouldn't re-add the rule on subsequent runs.
--
You are receiving this mail because:
You are watching all bug chan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
--- Comment #155 from David Cook ---
We're interested in this one too. I might be able to take a look at this one.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
Rebecca Coert changed:
What|Removed |Added
CC||rco...@arlingtonva.us
--
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--
Yo
101 - 200 of 416 matches
Mail list logo