[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #32884|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #32885|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #20301|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #32826|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Olli-Antti Kivilahti changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #32786|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #81 from Katrin Fischer --- Hm, introducing a new module just for testing seems a bit out of scope :) Have you taken a look at some of the other tests for recently added features? I think there are some for the new automati

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Olli-Antti Kivilahti changed: What|Removed |Added Status|ASSIGNED|In Discussion --- Comm

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #79 from Olli-Antti Kivilahti --- Created attachment 32786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32786&action=edit Bug 8367 - How long is a hold waiting for pickup at a more granular level This p

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Olli-Antti Kivilahti changed: What|Removed |Added Status|Patch doesn't apply |ASSIGNED --- Comment #

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Olli-Antti Kivilahti changed: What|Removed |Added CC||olli-antti.kivila...@jn

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #77 from Paul Poulain --- (In reply to Agnes Rivers-Moore from comment #76) > We would like the option to have a shorter pickup period for some item types. Sorry, but this patch does not apply anymore, and should be rewrit

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Agnes Rivers-Moore changed: What|Removed |Added CC||a...@hanover.ca --- Comm

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comm

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #73 from Jonathan Druart --- Created attachment 20304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20304&action=edit Bug 8367: Fix the maxpickupdate when we set waitingdate to NOW() ModReserveAffect get

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #74 from Jonathan Druart --- (In reply to Katrin Fischer from comment #68) > Hi Kyle, > there is a conflict in Reserves.pm I am not sure how to fix - could you take > a look please? I think it's because your patch for using

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #72 from Jonathan Druart --- Created attachment 20303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20303&action=edit Bug 8367: Skip to next open day if max pickup date is a holiday Test plan: 1) Note yo

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #71 from Jonathan Druart --- Created attachment 20302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20302&action=edit Bug 8367: Followup FIX a sql statement (bad conflict merge) Signed-off-by: Kyle M Hal

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are rece

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Attachment #20300|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Attachment #19180|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comm

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #67 from Kyle M Hall --- (In reply to Katrin Fischer from comment #66) > Ok, maybe we could take a look at the NOW()s another time. Yes, I would suggest filing a bug report to take care of any NOW()'s in the codebase. It s

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #66 from Katrin Fischer --- Ok, maybe we could take a look at the NOW()s another time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs ma

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Attachment #19361|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivin

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #64 from Jonathan Druart --- (In reply to Katrin Fischer from comment #63) > Hmm, I think NOW() is a mysqlism. I know we probably have lots of those in > the codebase already, but maybe worth trying not to add more and find

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #63 from Katrin Fischer --- Hmm, I think NOW() is a mysqlism. I know we probably have lots of those in the codebase already, but maybe worth trying not to add more and find best practices for replacing them? Mtj suggested

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #62 from Jonathan Druart --- Created attachment 19361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19361&action=edit Bug 8367: Fix the maxpickupdate when we set waitingdate to NOW() ModReserveAffect get

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Attachment #19181|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #60 from Jonathan Druart --- Kyle, I agree with your test plan. I am signing off your patch. But I think I found a bug, could you take a look at this new patch please? -- You are receiving this mail because: You are watch

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #59 from Kyle M Hall --- You're right, I think the test plan should be: Test plan: 1) Note your ReservesMaxPickUpDelay setting. 2) Create and trap a hold 3) View waitingreserves.pl, note the last pickup date, and the picku

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #58 from Jonathan Druart --- (In reply to Kyle M Hall from comment #56) > Created attachment 19181 [details] [review] > Bug 8367: Skip to next open day if max pickup date is a holiday Kyle, I don't understand how this patc

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Attachment #19108|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Attachment #19107|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Attachment #19116|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are recei

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivin

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are r

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #54 from Jonathan Druart --- Created attachment 19116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19116&action=edit Bug 8367: Followup FIX a sql statement (bad conflict merge) -- You are receiving thi

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #53 from

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #52 from Jonathan Druart --- Note: Unit tests for GetMaxPickupDate are provided by bug 10487 (depends on 10289) -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Blocks||10487 -- You are receiving

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are r

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Attachment #19104|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #51 from Jonathan Druart --- Created attachment 19108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19108&action=edit Bug 8367: Skip to next open day if max pickup date is a holiday Test plan: 1) Note yo

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiv

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Attachment #19093|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #48 from Jonathan Druart --- Created attachment 19105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19105&action=edit Bug 8367: Skip to next open day if max pickup date is a holiday Test plan: 1) Note yo

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiv

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #46 from Jonathan Druart --- I rebased 4 patches and added a test plan for the last one. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are rece

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #45 from Jonathan Druart --- Created attachment 19096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19096&action=edit Bug 8367: Skip to next open day if max pickup date is a holiday Test plan: 1) Note yo

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #44 from Jonathan Druart --- Created attachment 19095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19095&action=edit Bug 8367: Followup Add more granular level for ReservesMaxPickUpDelay This patch remo

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Attachment #15334|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #43 from Jonathan Druart --- Created attachment 19094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19094&action=edit Bug 8367: Add more granular level for ReservesMaxPickUpDelay - Followup Signed-off-by

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Galen Charlton changed: What|Removed |Added Blocks||9004 -- You are receiving t

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Patch doesn't apply --- Comment

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #40 from Jonathan Druart --- (In reply to comment #39) > The last patch needs a commit message with a test plan. Kyle, since this patch is from you, could you provide a test plan please? -- You are receiving this mail be

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #39 from

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #38 from Kyle M Hall --- (In reply to comment #37) > Created attachment 15659 [details] [review] > Bug 8367: Skip to next open day if max pickup date is a holiday I should note this also fixes a bug, where the call to GetR

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are recei

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Attachment #15658|Bug 8367: Followup Add more |[SIGNED-OFF] Bug 8367: d

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Attachment #15335|Bug 8367: Add more granular |[SIGNED-OFF] Bug 8367: Add

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Attachment #15334|Bug 8367: Add more granular |[SIGNED-OFF] Bug 8367: Add

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #37 from Kyle M Hall --- Created attachment 15659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15659&action=edit Bug 8367: Skip to next open day if max pickup date is a holiday -- You are receiving thi

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivin

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Attachment #15613|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Attachment #15498|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are r

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #34 from Jonathan Druart --- (In reply to comment #32) > Preliminary comments: > Report Holds awaiting pickup: > A DateTime object can only be compared to another DateTime object > (DateTime=HASH(0x53d7020), 2013-02-22). at

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #33 from M. de Rooy --- Please have a look too at bug 5786. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 M. de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community.

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 M. de Rooy changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #32 from M

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #31 from M. de Rooy --- QA: Looking again here now.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-co

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community.

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #29 from Katrin Fischer --- As I said - I think thre are arguments for both approaches. :) Only I am thinking that this would not work: >If the library closes, they should stop confirming holds in due time, limiting >>th

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #28 from M. de Rooy --- (In reply to comment #25) > Hm, there is a downside to the new column too - we loose a bit of > flexibility. Say a library closes for some time and changes the pickup delay > to be longer, so the hol

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Attachment #15369|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #27 from Jonathan Druart --- Created attachment 15498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15498&action=edit Bug 8367: Followup Add more granular level for ReservesMaxPickUpDelay This patch remo

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #26 from Jonathan Druart --- (In reply to comment #23) > Just a question from quickly glancing through your code. In > CancelExpiredReserves: > +my $query = "SELECT * FROM reserves WHERE TO_DAYS( NOW() ) - > TO_DAYS

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de ---

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #24 from M. de Rooy --- (In reply to comment #22) > Questions, does this take into account days the library is closed? It would > make sense for the expiration day for pickups to skip to the next open day > if they land on

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #23 from M. de Rooy --- (In reply to comment #20) > It is a great idea even though it was not so easy :) Yes, I see. In circulation nothing seems to be easy.. Will try to have a look at your patches again later this week.

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #22 from Kyle M Hall --- Questions, does this take into account days the library is closed? It would make sense for the expiration day for pickups to skip to the next open day if they land on a holiday. This is something th

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #21 from Jonathan Druart --- Created attachment 15369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15369&action=edit Bug 8367: Followup Add more granular level for ReservesMaxPickUpDelay This patch remo

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are r

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #20 from Jonathan Druart --- (In reply to comment #18) > QA Comment: > Note that you could easily resolve this by looking at a maxpickupdate when > adding this to the reserve table and calculating it at confirm hold time.

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #19 from M. de Rooy --- Just another thought: If you would remove the pref, please add a db change to copy it into the new column of the existing issuing rules. -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 M. de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #18 from M

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 M. de Rooy changed: What|Removed |Added Attachment #13624|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 M. de Rooy changed: What|Removed |Added Attachment #13603|0 |1 is obsolete|

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #17 from M. de Rooy --- Created attachment 15335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15335&action=edit Bug 8367: Add more granular level for ReservesMaxPickUpDelay - Followup Signed-off-by: Jon

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #16 from M. de Rooy --- Created attachment 15334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15334&action=edit Bug 8367: Add more granular level for ReservesMaxPickUpDelay This patch adds: - a new colu

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #14 from Paul Poulain --- (In reply to comment #13) > It's been a month without another signer. I think it's time to move these > patches to QA. agreed (and agreed also because now QAers are supposed to test the patch) --

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #13 from

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are recei

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|-

<    1   2   3   4   5   >