[Koha-bugs] [Bug 14363] OAI-PMH should handle records without marcxml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363

--- Comment #9 from Frédéric Demians  ---
Pushed in 3.20.8.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #56 from Marcel de Rooy  ---
Putting this back where it came from (PQA)
Any reason why you moved this back to SO, Mark?
If it was a hard rebase, getting another signoff should imo go via NSO.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #48586|0   |1
is obsolete||

--- Comment #25 from Mirko Tietgen  ---
Created attachment 48587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48587=edit
Bug 14168 Follow-up: require WWW::YouTube::Download only when syspref enabled

This patch fixes the problem of missing WWW::YouTube::Download breaking
record detail views. Instead of a general 'use', the module is only
required if the related syspref is enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

--- Comment #24 from Mirko Tietgen  ---
I added a followup. Expected results:

- without libwww-youtube-download-perl
-- HTML5MediaYouTube disabled: detail views work fine
-- HTML5MediaYouTube enabled: detail views throw an error ('Can't locate
WWW/YouTube/Download.pm in @INC …')

- with libwww-youtube-download-perl
-- HTML5MediaYouTube disabled: detail views work fine
-- HTML5MediaYouTube enabled: detail views work fine and YT video works

I can't switch this back to needs signoff for some reason.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #48542|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

--- Comment #23 from Mirko Tietgen  ---
Created attachment 48586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48586=edit
Bug 14168 Follow-up: require WWW::YouTube::Download only when syspref enabled

This patch fixes the problem of missing WWW::YouTube::Download breaking
record detail views. Instead of a general 'use', the module is only
required if the related syspref is enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15951] Use Font Awesome icons for acquisitions order cancellation confirmation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15951

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #48561|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 48585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48585=edit
[PASSED QA] Bug 15951: Use Font Awesome icons for acquisitions order
cancellation confirmation

In Acquisitions, when you delete (cancel) an order, a dialog asks you to
confirm. This dialog should be styled with Font Awesome icons.

Other minor edit: Changing page grid style for centered main content
area.

To test, apply the patch and locate a basket in Acquisitions with an
order.

- View the details for the basket.
- Click the 'Delete' link next to the order you want to delete.
- Confirm that the dialog is correctly styled.
- Test the cancel operation and verify that you are correctly redirected
  back to where you were.
- Test the confirmation operation and verify that your order is deleted.
- Also test the deletion process from Acquisitions -> Vendor -> Invoices
-> Invoice -> Go to receipt page -> Delete order.

Signed-off-by: Hector Castro 
Works as advertised

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15951] Use Font Awesome icons for acquisitions order cancellation confirmation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15951

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #48563|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 48584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48584=edit
[PASSED QA] Bug 15961 - Use Font Awesome icons for confirmation of currency
deletion

When deleting a currency, the confirmation and error dialogs should use
Font Awesome icons. This patch makes this change.

To test, apply the patch and go to Administration -> Currencies and
exchange rates.

- Click the "delete" link next to any currency.
- Verify that the confirmation dialog is correctly styled.
  - Test the both cancel and confirm operations.
  - Verify that the deletion confirmation dialog is correctly styled.

Bug 15962 prevents testing the error dialog which should appear if you
try to delete a currency which is use (defined as a currency in a vendor
record). To test this error you could manually enter a currency code
into aqbooksellers.currency and then try to delete that currency.

Signed-off-by: Nicole C Engard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15864] SMS cellular providers link missing from administration sidebar menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15864

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15864] SMS cellular providers link missing from administration sidebar menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15864

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #48550|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 48583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48583=edit
[PASSED QA] Bug 15864 - SMS cellular providers link missing from administration
sidebar menu

When the SMSSendDriver system preference is set to "Email" a link to the
SMS cellular providers management page should appear in the left-hand
sidebar menu on Administration pages. This patch adds the link to
admin-menu.inc.

To test, apply the patch set your SMSSendDriver system preference to
"Email." View various Administration pages which show the left-hand
sidebar menu and confirm that "SMS cellular providers" is in the list.

Empty the SMSSendDriver preference and confirm that the link no longer
appears.

Signed-off-by: Nicole C Engard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15950] Use Font Awesome icons for acquisitions basket close confirmation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15950

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15950] Use Font Awesome icons for acquisitions basket close confirmation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15950

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #48518|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 48582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48582=edit
[PASSED QA] Bug 15950: Use Font Awesome icons for acquisitions basket close
confirmation

When closing a basket in Acquisitions the confirmation dialog should be
styled using Font Awesome icons. This patch adds them.

The cancel button has been moved into its own form so that we can get
rid of several problematic JavaScript issues: The use of the
"javascript:" pseudo-protocol, the use of an "onclick" attribute, and
the use of a JS redirect where a GET action will do.

To test, apply the patch and locate an open basket in Acquisitions which
can be closed.

- Click the 'Close this basket' button and confirm that the icons in the
  dialog look correct.
- Test the cancel operation to make sure you are redirected back to the
  page showing the basket details.
- Test the confirm operation and verify that the basket is closed.

Signed-off-by: Hector Castro 
Works as advertised

Signed-off-by: Katrin Fischer 
Please note that the confirmation message display depends on
BasketConfirmations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15962] Currency deletion doesn't correctly identify currencies in use

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15962

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Nice catch! I think you are right about currency being no longer in use - I had
to track down the deletion problem a little while ago.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11039] SIP Server responds with valid CHECKIN to SC but fails to checkin item on Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11039

--- Comment #3 from Katrin Fischer  ---
That would be nice - thx for the update Colin!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15755] Default item type is not marked as "All" in circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15755] Default item type is not marked as "All" in circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #48541|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 48581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48581=edit
[PASSED QA] Bug 15755: Display default item type as "All" in circ rules

Bug 15354 did not fix correctly the issue with the item type display.
The default item type '*' should be "All", at the moment nothing is
displayed in the column.

Test plan:
1/ Define a rule for default item types (All/*) and for specific item
types.
2/ Translate some item type descriptions used in previous step
3/ Default item type should be "All" and correct translations should be
displayed.

Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off
 CC||mtomp...@hotmail.com

--- Comment #42 from M. Tompsett  ---
Conflict was with bug 15629 adding Koha::Libraries on the first patch.
Everything is code identical. Ran t/db_dependent/Circulation_dateexpiry.t and
t/db_dependent/DecreaseLoanHighHolds.t with no issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46866|0   |1
is obsolete||

--- Comment #39 from M. Tompsett  ---
Created attachment 48578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48578=edit
Bug 14694 [QA Followup] - Fix typos

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46867|0   |1
is obsolete||

--- Comment #40 from M. Tompsett  ---
Created attachment 48579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48579=edit
Bug 14694 [QA Followup] - Fix syspref order

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46865|0   |1
is obsolete||

--- Comment #38 from M. Tompsett  ---
Created attachment 48577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48577=edit
Bug 14694 [QA Followup] - Fix unit tests

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46868|0   |1
is obsolete||

--- Comment #41 from M. Tompsett  ---
Created attachment 48580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48580=edit
Bug 14694: Create data the tests need

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694

M. Tompsett  changed:

   What|Removed |Added

  Attachment #46864|0   |1
is obsolete||

--- Comment #37 from M. Tompsett  ---
Created attachment 48576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48576=edit
Bug 14694 - Make decreaseloanHighHolds more flexible

This patch allows for more flexibility for determining when the number
of holds a record has should trigger the reduction of the loan length
for items on that record.

This patch adds a new system preference decreaseLoanHighHoldsControl,
which defaults to 'static', the original behavior of the feature.
It also has a new behavior 'dynamic' which makes the feature only
decrease the loan length if the number of holds on the record exceeds
the number of holdable items + decreaseLoanHighHoldsValue.

It also allows items to be filtered from the list of items based
on the damaged, lost, not for loan, and withdrawn values even if
those values would have allowed holds ( i.e. values < 0 )

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Set decreaseLoanHighHolds to Enable
4) Set decreaseLoanHighHoldsControl to "over the number of items on the record"
5) Set decreaseLoanHighHoldsDuration to 1
6) Set decreaseLoanHighHoldsValue to 3
7) Create a record with 5 items
8) Please 8 or more holds on the record
9) Check out one of the items to a patron
10) Note the loan length is reduced to 1 day
11) Set decreaseLoanHighHoldsValue to 3 to 2
12) Check out one of the items to a patron
13) Note the loan length is *not* reduced
14) Enbale all the filters possible in decreaseLoanHighHoldsIgnoreStatuses
15) Set one item to be damaged
16) Note the loan length is reduced
17) Unset the damaged status
18) Repeat steps 15 - 17 for lost, not for loan, and withdrawn

Signed-off-by: Christopher Brannon 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off
 CC||mtomp...@hotmail.com

--- Comment #82 from M. Tompsett  ---
I'm running through patch does not apply queue.
Only HoldsQueue.t file changed in terms of use statements.
Test file proves fine. Everything else identical.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

M. Tompsett  changed:

   What|Removed |Added

  Attachment #47247|0   |1
is obsolete||

--- Comment #81 from M. Tompsett  ---
Created attachment 48575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48575=edit
Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing
purposes

Bug 12803 [QA Followup] - Remove use of C4::Dates

C4::Dates was being included, but not used in the code!

Bug 12803 [QA Followup] - Fix koha-qa.pl errors

Bug 12803 [QA Followup] - Update unit tests due to changes in master

Bug 12803 [QA Followup] - Fix to stop failing unit tests

Bug 12803 [QA Followup] - Remove duplicate 'use' lines

Bug 12803 [QA Followup] - Remove NO_CACHE

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

M. Tompsett  changed:

   What|Removed |Added

  Attachment #47246|0   |1
is obsolete||

--- Comment #80 from M. Tompsett  ---
Created attachment 48574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48574=edit
Bug 12803 - Add ability to skip closed libraries when generating the holds
queue

The holds queue is typically generated many times a day in order to
select items to fill holds. Often these items are to be sent to a
different library. However, if the library whose item is picked to fill
a hold is closed, that hold will remain unfilled even if there are other
open libraries who own that item. It would be helpful if we could skip
closed libraries for the purpose of selecting items to fill holds.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create a record with two items on it, one at Branch A, and one at
   Branch B
4) Place a hold for pickup at Branch C
5) Generate the holds queue
6) Note which branch's item is selected for the hold
7) Enable the new system preference HoldsQueueSkipClosed
8) Add today as a holiday for that branch noted in step 6
9) Regenerate the holds queue
10) View the holds queue, notice the item selected is not from
the closed branch!
11) prove t/db_dependent/HoldsQueue.t

Signed-off by: Jason Robb 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #55 from M. Tompsett  ---
Sorry, Marcel, my rebase lost your sign-off markers at the end of the files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

M. Tompsett  changed:

   What|Removed |Added

  Attachment #47958|0   |1
is obsolete||

--- Comment #53 from M. Tompsett  ---
Created attachment 48572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48572=edit
Bug 12426: Allow resend for sent messages

This patch allows to resend both sent and failed messages.

With messages in 'sent' status, we have to be careful not to accidentally send
sent messages again. With the previous patch using GET request, this was likely
to happen because of browser storing the GET parameters.

This patch changes request method from GET to POST. Instead of a simple link,
we now have a form element.

In notices.pl we redirect back to notices.pl, because with POST there is a risk
of resending the message accidentally by form resubmission at refresh.

To test, find/create a Patron that has sent or failed notices in message_queue:
1. Enable EnchancedMessagingPreferences system preference
2. Go to Patrons -> Notices
3. In the Notice column, click the title of the sent or failed message
4. Observe that there is nothing for resending the sent or failed message
5. Apply the patches.
6. Reload Notices page and repeat step 3
7. Observe that there is now a link "Resend" in the Status-column
8. Click Resend
9. Observe that the message gets into 'pending' status

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

M. Tompsett  changed:

   What|Removed |Added

  Attachment #48049|0   |1
is obsolete||

--- Comment #54 from M. Tompsett  ---
Created attachment 48573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48573=edit
Bug 12426: [QA Follow-up] Clear to_address to force update

When resending an email from the Notices tab in Patrons, we would like
to use the recent email address.

Test plan:
[1] Look up a patron with some notices sent.
[2] Adjust the patron email address (watch AutoEmailPrimaryAddress).
[3] Resend the notice. Verify if the new address was used.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

M. Tompsett  changed:

   What|Removed |Added

  Attachment #47956|0   |1
is obsolete||

--- Comment #51 from M. Tompsett  ---
Created attachment 48570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48570=edit
Bug 12426: Allow resending of messages from the notices tab in the patron
account

This patch adds a link 'Resend' under a notice in 'failed' status
in the Patron's Notices tab.

By clicking the link, we will request notices.pl with parameter
"resendnotice=X" where X is message_id. In notices.pl,
we then check whether the given message is actually in 'failed'
status. If so, we use the C4::Letters::ResendMessage(123) to
change the status of the message into 'pending'. This way it
will be processed again by the cronjob process_message_queue.pl.

To test, find/create a Patron that has failed notices in message_queue:
1. Enable EnchancedMessagingPreferences system preference
2. Go to Patrons -> Notices
3. In the Notice column, click the title of the failed message
4. Observe that there is nothing for resending the failed message
5. Apply patch.
6. Reload Notices page and repeat step 3
7. Observe that there is now a link "Resend" in the Status-column
8. Click Resend
9. Observe that the message gets into 'pending' status

Works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

M. Tompsett  changed:

   What|Removed |Added

  Attachment #47957|0   |1
is obsolete||

--- Comment #52 from M. Tompsett  ---
Created attachment 48571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48571=edit
Bug 12426: Simplify the code adding a new subroutine GetMessage

The C4::Letters module does not have a GetMessage subroutine, which
could be quite useful.
This patch adds it and simplifies the code added by the previous patch.
It also adds a few tests and fixes POD typos.

Note that ResendNotice only resends failed messages. This will avoid to
resend already sent messages (using an url from the browser history for
instance).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15905] Remove use of makepayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #4 from M. Tompsett  ---
(In reply to Aleisha Amohia from comment #3)
> fatal: sha1 information is lacking or useless (t/db_dependent/Accounts.t).

Confirmed. 15895 (3 way merge okay), 15896, 15906, and 15907 all apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #2 from M. Tompsett  ---
Oops... forgot to apply 15895. Sorry.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15966] New: Move MARC frameworks actions into a drop down menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15966

Bug ID: 15966
   Summary: Move MARC frameworks actions into a drop down menu
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15965] Koha to MARC mapping - table changes with selection of drop down menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15965

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15965] Koha to MARC mapping - table changes with selection of drop down menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15965

--- Comment #1 from Aleisha Amohia  ---
Created attachment 48569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48569=edit
Bug 15965: Koha to MARC mapping - table changes with selection of drop down
menu

To test:

1) Go to Admin -> Koha to MARC Mapping
2) Test selecting biblio / biblioitems / items
3) Confirm the table content changes and behaves as it should which each
selection

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15965] New: Koha to MARC mapping - table changes with selection of drop down menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15965

Bug ID: 15965
   Summary: Koha to MARC mapping - table changes with selection of
drop down menu
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

See /cgi-bin/koha/tools/overduerules.pl
When you select a new library in the drop down, the table showing rules updates
automatically to show the rules for that library.

This change should be added to cgi-bin/koha/admin/koha2marclinks.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15953] Patroncards toolbar is now broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15953

Aleisha Amohia  changed:

   What|Removed |Added

   Severity|enhancement |critical

--- Comment #1 from Aleisha Amohia  ---
Setting to Critical because it actually disrupts the use of this feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15905] Remove use of makepayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #3 from Aleisha Amohia  ---
fatal: sha1 information is lacking or useless (t/db_dependent/Accounts.t).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15932] Moving Authorities actions into a drop-down menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #48534|0   |1
is obsolete||

--- Comment #4 from Aleisha Amohia  ---
Created attachment 48568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48568=edit
Bug 15932: Moving Authorities actions into a drop-down menu

Edit: Removed ddatatables stuff and fixed merge conflict

To test:
1) Go to Authorities and do an authority search (authorities-home.pl)
2) Confirm that the options (Edit, Merge, Delete) are there and behave
   as expected.

Sponsored-by: Catalyst IT
Signed-off-by: Frédéric Demians 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15932] Moving Authorities actions into a drop-down menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15952] Moving cataloging search actions into a drop-down menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15952

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #48566|0   |1
is obsolete||

--- Comment #5 from Aleisha Amohia  ---
Created attachment 48567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48567=edit
Bug 15952: Moving cataloging search actions into a drop-down menu

Edit: Have removed the datatables stuff - wasn't necessary. Also fixed a merge
conflict

To test:
1) Go to Cataloging and do a search in the catalog and reservoir
   (cataloguing/addbooks.pl)
2) Confirm that for the results found in catalog, the options (MARC and
   Card preview, Edit biblio, Add/edit items) are there and behave as
   expected.
3) Confirm that for the results found in reservoir, the options (MARC
   and Card preview, Add biblio) are there and behave as expected.
4) Set user permissions so that the user cannot edit the catalog or
   items. (editcatalogue -> edit_catalogue and edit_items)
5) Confirm that you no longer see the options to edit or add
   items/biblio in either table.

Sponsored-by: Catalyst IT
Signed-off-by: Frédéric Demians 
  Expected result following the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15952] Moving cataloging search actions into a drop-down menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15952

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #48537|0   |1
is obsolete||

--- Comment #4 from Aleisha Amohia  ---
Created attachment 48566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48566=edit
Bug 15952: Moving cataloging search actions into a drop-down menu

Edit: Have removed the datatables stuff - wasn't necessary. Also fixed a merge
conflict

To test:
1) Go to Cataloging and do a search in the catalog and reservoir
   (cataloguing/addbooks.pl)
2) Confirm that for the results found in catalog, the options (MARC and
   Card preview, Edit biblio, Add/edit items) are there and behave as
   expected.
3) Confirm that for the results found in reservoir, the options (MARC
   and Card preview, Add biblio) are there and behave as expected.
4) Set user permissions so that the user cannot edit the catalog or
   items. (editcatalogue -> edit_catalogue and edit_items)
5) Confirm that you no longer see the options to edit or add
   items/biblio in either table.

Sponsored-by: Catalyst IT
Signed-off-by: Frédéric Demians 
  Expected result following the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15952] Moving cataloging search actions into a drop-down menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15952

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #48147|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824

--- Comment #5 from Aleisha Amohia  ---
Created attachment 48565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48565=edit
Bug 15824 - 'Done' button is unclear on batch item modification and deletion

To test:

MODIFICATION
1) Go to a biblio record page (ie
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1)
2) Click edit -> Edit items in a batch
3) Click Save (you don't need to make any changes)
4) Validate 'Done' button. Confirm that there is now a link in dialog message
box which takes you back to the record detail page.

5) Go to a biblio record page
6) Select one or some or all items in the record
7) Click modify selected items
8) Click Save
9) Validate 'Done' button. Confirm that there is now a link in dialog message
box which takes you back to the record detail page.

10) Go to batch item modification
(http://localhost:8081/cgi-bin/koha/tools/batchMod.pl)
11) Write some barcodes into the barcode list and click Continue
12) Click Save
13) Validate 'Done' button. Confirm that there is now a link in dialog message
box which takes you back to the batch item mod page.

DELETION
14) Go to a biblio record page (ie
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1)
15) Click edit -> Delete items in a batch
16) Unselect all the items so you don't actually delete them, then click Delete
selected items
17) Validate 'Done' button. Confirm that there is now a link in dialog message
box which takes you back to the record detail page.

18) Go to a biblio record page
19) Select one or some or all items in the record
20) Click Delete selected items
21) Unselect all the items so you don't actually delete them, then click Delete
selected items
22) Validate 'Done' button. Confirm that there is now a link in dialog message
box which takes you back to the record detail page.

23) Go to batch item deletion
(http://localhost:8081/cgi-bin/koha/tools/batchMod.pl?del=1)
24) Write some barcodes into the barcode list and click Continue
25) Unselect all the items so you don't actually delete them, then click Delete
selected items
26) Validate 'Done' button. Confirm that there is now a link in dialog message
box which takes you back to the batch item deletion page.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133

--- Comment #13 from Nick Clemens  ---
I think there is a problem here.

Unless I missed something the lines below will now never be triggered, so the
notice will not be pushed to output_chunks, so it will never be sent to the
library in the case of a patron with no emails or sms


727 if ( ($mtt eq 'email' and not scalar
@emails_to_use) or ($mtt eq 'sms' and not $data->{smsalertnumber}) ) {
728 push @output_chunks,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #46 from Brendan Gallagher  ---
Pushed last patch - thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

--- Comment #45 from Brendan Gallagher  ---
(In reply to Brendan Gallagher from comment #44)
> Didn't apply cleanly - I know because of the moving target that master is. 
> Please rebase.  Once it's done - leave me an @later in #koha and I'll jump
> right on it.  Thank you so much for the time and bother of rebasing.
> 
> Brendan

Sorry - my mistake - need the last patch - that applies :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11023] Automatic item modification by age (Was "Toggle new status for items")

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #106 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 Release. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9296] overduerules table needs restructuring to allow future extension

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9296

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #50 from Brendan Gallagher  ---
Didn't apply cleanly - I know because of the moving target that master is. 
Please rebase.  Once it's done - leave me an @later in #koha and I'll jump
right on it.  Thank you so much for the time and bother of rebasing.

Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #79 from Brendan Gallagher  ---
Didn't apply cleanly - I know because of the moving target that master is. 
Please rebase.  Once it's done - leave me an @later in #koha and I'll jump
right on it.  Thank you so much for the time and bother of rebasing.

Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Patch doesn't apply

--- Comment #36 from Brendan Gallagher  ---
Didn't apply cleanly - I know because of the moving target that master is. 
Please rebase.  Once it's done - leave me an @later in #koha and I'll jump
right on it.  Thank you so much for the time and bother of rebasing.

Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s]

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

--- Comment #24 from Brendan Gallagher  ---
Didn't apply cleanly - I know because of the moving target that master is. 
Please rebase.  Once it's done - leave me an @later in #koha and I'll jump
right on it.  Thank you so much for the time and bother of rebasing.

Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Patch doesn't apply

--- Comment #37 from Brendan Gallagher  ---
Didn't apply cleanly - I know because of the moving target that master is. 
Please rebase.  Once it's done - leave me an @later in #koha and I'll jump
right on it.  Thank you so much for the time and bother of rebasing.

Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

--- Comment #44 from Brendan Gallagher  ---
Didn't apply cleanly - I know because of the moving target that master is. 
Please rebase.  Once it's done - leave me an @later in #koha and I'll jump
right on it.  Thank you so much for the time and bother of rebasing.

Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Patch doesn't apply

--- Comment #6 from Brendan Gallagher  ---
Didn't apply cleanly - I know because of the moving target that master is. 
Please rebase.  Once it's done - leave me an @later in #koha and I'll jump
right on it.  Thank you so much for the time and bother of rebasing.

Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

--- Comment #14 from Brendan Gallagher  ---
Didn't apply cleanly - I know because of the moving target that master is. 
Please rebase.  Once it's done - leave me an @later in #koha and I'll jump
right on it.  Thank you so much for the time and bother of rebasing.

Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #21 from Brendan Gallagher  ---
Didn't apply cleanly - I know because of the moving target that master is. 
Please rebase.  Once it's done - leave me an @later in #koha and I'll jump
right on it.  Thank you so much for the time and bother of rebasing.

Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Patch doesn't apply

--- Comment #47 from Brendan Gallagher  ---
Didn't apply cleanly - I know because of the moving target that master is. 
Please rebase.  Once it's done - leave me an @later in #koha and I'll jump
right on it.  Thank you so much for the time and bother of rebasing.

Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #30 from Brendan Gallagher  ---
Didn't apply cleanly - I know because of the moving target that master is. 
Please rebase.  Once it's done - leave me an @later in #koha and I'll jump
right on it.  Thank you so much for the time and bother of rebasing.

Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15887] Revise layout and behavior of item search fields management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #12 from Brendan Gallagher  ---
Pushed to Mater - Should be in the May 2016 Release.  thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964

Josef Moravec  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14168

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15927] Remove use of for alternating row colors.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15927

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #4 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15964

--- Comment #22 from Josef Moravec  ---
Héctor moved the patch to newly created bug 15964, that's propably the reason
of obsoleting my followup here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15947] SIPILS.t should be moved to t/db_dependent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #5 from Brendan Gallagher  ---
Pushed to Master - should be in the May 2016 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

--- Comment #21 from Brendan Gallagher  ---
Just marking that last patch - as not obsolete until we've got another patch
that does what we need.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #48542|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #201 from Brendan Gallagher  ---
(In reply to Jonathan Druart from comment #199)
> I would like to get other opinions on the discussion on comment 38 and
> comment 39 about the idea to reuse existing search scripts and templates.
> IMO it will be a mess in a near future:
> 1/ we will want to implement things for ES, not supported by Zebra
> 2/ at some point the features already implemented for Zebra won't be
> available for ES
> => We will have to write switch (if se=='es' {} elsif se == 'zebra')
> everywhere.


A sort of road map that I have in mind (and yes I'll back that up with funding
etc.)

1. Get Elastic into Koha (marked as experimental) - making sure that we aren't
breaking anything with Zebra!  (that's the main testing we need now)
2. Elasticsearch talks JSON
3. As we want to develop new features that are ES centric and not Zebra - we
split those off
4. Meaning we can build a new frontend for it, that uses elasticsearch to
search, and the restful api to get records. 
5. New Frontend for it - that is not C4::Search (no one really wants to work
that anymore).
6. introducing the Catmandu libraries into Koha should be a good thing - we can
start to explore RDF etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964

--- Comment #5 from Josef Moravec  ---
I should be more often on IRC ;)

Thanks Mirko for clarification, I'm looking forward to your patch ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #4 from Mirko Tietgen  ---
Hi Héctor and Josef,

we talked about this on IRC today and the plan is to fix it in a different way.

The module is not available in Wheezy and it is not a core function, only a few
people will actually need it. We will change the "use WWW::YouTube:Download" to
a 'require' with the condition of the youtube-syspref being enabled, so people
on Wheezy don't get bothered by this. I plan to add a patch tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964

--- Comment #3 from Josef Moravec  ---
Thanks Héctor, also for sign-off ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15959] Use Font Awesome icons for attach item confirmations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #48551|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 48564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48564=edit
[SIGNED-OFF]Bug 15959: Use Font Awesome icons for attach item confirmations

When attaching an existing item to a record, the confirmation and error
dialogs should be styled using Font Awesome icons. This patch revises
the buttons and revises the global CSS file.

To test, apply the patch and clear your cache if necessary.

- Locate a record in the catalog to which you can attach an item.
- Select "Attach item" from the "Edit" menu.
- Submit a barcode for an exising item.
- Verify that the confirmation dialog is correctly styled.
  - Test the operation of both the "OK" and the "Attach another item"
buttons.
- Submit an invalid barcode.
- Verify that the error dialog is correctly styled.
  - Test the operation of both the "OK" and the "Try again"
buttons.

Signed-off-by: Hector Castro 
Works as described

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15959] Use Font Awesome icons for attach item confirmations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
  Attachment #48542|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #48555|0   |1
is obsolete||

--- Comment #2 from Nicole C. Engard  ---
Created attachment 48563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48563=edit
[SIGNED-OFF] Bug 15961 - Use Font Awesome icons for confirmation of currency
deletion

When deleting a currency, the confirmation and error dialogs should use
Font Awesome icons. This patch makes this change.

To test, apply the patch and go to Administration -> Currencies and
exchange rates.

- Click the "delete" link next to any currency.
- Verify that the confirmation dialog is correctly styled.
  - Test the both cancel and confirm operations.
  - Verify that the deletion confirmation dialog is correctly styled.

Bug 15962 prevents testing the error dialog which should appear if you
try to delete a currency which is use (defined as a currency in a vendor
record). To test this error you could manually enter a currency code
into aqbooksellers.currency and then try to delete that currency.

Signed-off-by: Nicole C Engard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

Version|unspecified |master
   Assignee|gmcha...@gmail.com  |josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com,
   ||mi...@abunchofthings.net,
   ||neng...@gmail.com
 Status|Needs Signoff   |Signed Off

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Hi Josef Moravec

I move your patch to this new bug

Regard

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794

Nicole C. Engard  changed:

   What|Removed |Added

  Change sponsored?|Sponsored   |Seeking cosponsors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964

--- Comment #1 from Héctor Eduardo Castro Avalos  ---
Created attachment 48562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48562=edit
[SIGNED-OFF]Bug 15964: Followup: make module WWW::YouTube::Download required

Module C4::HTML5Media is used in detail.pl,
so if you don't have installled module for YouTube,
you get an internal server error.

This patch make module WWW::YouTube::Download required and adds it to package
dependencies

Test plan:
1. Don't have installed module WWW::YouTube:Download, neither package
libwww-youtube-download-perl
2. Try to access biblio detail in staff client (detail.pl) - you'll be
presented withh internal server error
3. Check the About page -> Perl modules, the WWW::YouTube::Download should be
reported as missing optional
4. Apply the patch
5. Check the About page -> Perl modules, the WWW::YouTube::Download should now
be reported as missing required
6. Create and install debian package, the libwww-youtube-download-perl should
be the dependency and so installed with koha-common package (use apt-get
install -f, if neccessery)
7. Check the About page -> Perl modules, the WWW::YouTube::Download should now
be reported as Module current
8. Try to access biblio detail in staff client (detail.pl) - it should be
display, no error now

Signed-off-by: Hector Castro 
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15964] New: Cannot view detail bib record because missing perl module WWW::YouTube::Download

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964

Bug ID: 15964
   Summary: Cannot view detail bib record because missing perl
module WWW::YouTube::Download
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: hector.hecax...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

WWW::YouTube::Download needs to be marked as required

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15951] Use Font Awesome icons for acquisitions order cancellation confirmation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15951

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15951] Use Font Awesome icons for acquisitions order cancellation confirmation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15951

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #48548|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 48561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48561=edit
[SIGNED-OFF]Bug 15951: Use Font Awesome icons for acquisitions order
cancellation confirmation

In Acquisitions, when you delete (cancel) an order, a dialog asks you to
confirm. This dialog should be styled with Font Awesome icons.

Other minor edit: Changing page grid style for centered main content
area.

To test, apply the patch and locate a basket in Acquisitions with an
order.

- View the details for the basket.
- Click the 'Delete' link next to the order you want to delete.
- Confirm that the dialog is correctly styled.
- Test the cancel operation and verify that you are correctly redirected
  back to where you were.
- Test the confirmation operation and verify that your order is deleted.
- Also test the deletion process from Acquisitions -> Vendor -> Invoices
-> Invoice -> Go to receipt page -> Delete order.

Signed-off-by: Hector Castro 
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15963] Use Font Awesome icons for confirmation after deleting MARC tag

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15963

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15963] Use Font Awesome icons for confirmation after deleting MARC tag

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15963

--- Comment #1 from Owen Leonard  ---
Created attachment 48560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48560=edit
Bug 15963 - Use Font Awesome icons for confirmation after deleting MARC tag

This patch revises the dialog which appears after you have deleted a
MARC tag.

To test, apply the patch and go to Administration -> MARC frameworks ->
MARC sturcture -> Delete.

- Confirm that you want to delete a MARC tag.
- Verify that the confirmation dialog you are shown is styled correctly.
- Verify that clicking "OK" redirects you to the right place.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

  Attachment #48078|0   |1
is obsolete||

--- Comment #42 from Rémi Mayrand-Provencher 
 ---
Created attachment 48557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48557=edit
Bug 11879 - Fix syspref BorrowerUnwantedField

How I tested:
Apply 1st patch
Apply this patch
Edit syspref BorrowerUnwantedField to exclude fields
Edit patron's contact information
Make sure that fields do not longer appear in drop down for Main contact

Wors as expected

http://bugs.koha-community.org/show_bug.cgi?id=11879
Signed-off-by: Marc Veron 

Signed-off-by: Kyle M Hall 
Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #44 from Rémi Mayrand-Provencher 
 ---
Created attachment 48559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48559=edit
Bug 11879 QA follow-up

Changed "Mobile Phone" to Other Phone, modified deletedborrowers table
structute and added the field in opac

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

  Attachment #48079|0   |1
is obsolete||

--- Comment #43 from Rémi Mayrand-Provencher 
 ---
Created attachment 48558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48558=edit
Bug 11879 - Update BDIx schema and show main contact method in moremember.pl

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

  Attachment #48077|0   |1
is obsolete||

--- Comment #41 from Rémi Mayrand-Provencher 
 ---
Created attachment 48556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48556=edit
Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on
current master for testing)

http://bugs.koha-community.org/show_bug.cgi?id=11879

To test this patch:
Update database
Edit a borrower's informations.
The "Main Contact Method" selectbox appears in the form and its
value is correctly.

Works as expected.
For handling of syspref BorrowerUnwantedField use second patch-

Signed-off-by: Marc Veron 

Signed-off-by: Kyle M Hall 
Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785

Owen Leonard  changed:

   What|Removed |Added

 Blocks||15963


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15963
[Bug 15963] Use Font Awesome icons for confirmation after deleting MARC tag
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15963] New: Use Font Awesome icons for confirmation after deleting MARC tag

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15963

Bug ID: 15963
   Summary: Use Font Awesome icons for confirmation after deleting
MARC tag
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/admin/marctagstructure.pl
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 15785

After deleting a MARC tag the user is presented with a confirmation dialog
which should use Font Awesome.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785
[Bug 15785] Use Font Awesome icons in confirmation dialogs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961

--- Comment #1 from Owen Leonard  ---
Created attachment 48555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48555=edit
Bug 15961 - Use Font Awesome icons for confirmation of currency deletion

When deleting a currency, the confirmation and error dialogs should use
Font Awesome icons. This patch makes this change.

To test, apply the patch and go to Administration -> Currencies and
exchange rates.

- Click the "delete" link next to any currency.
- Verify that the confirmation dialog is correctly styled.
  - Test the both cancel and confirm operations.
  - Verify that the deletion confirmation dialog is correctly styled.

Bug 15962 prevents testing the error dialog which should appear if you
try to delete a currency which is use (defined as a currency in a vendor
record). To test this error you could manually enter a currency code
into aqbooksellers.currency and then try to delete that currency.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/