date:20160324

[Koha-bugs] [Bug 15397] Pay selected does not works as expected

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15397

--- Comment #7 from bondiurbano  ---
Created attachment 49574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49574=edit
Pay selected test

This is my test in 3.22.4. Simply pay fines selecting all account lines (as
Koha suggests). It doesn't work.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #85 from Katrin Fischer  ---
I am sorry, this fails when I try to receive a serial issue:

Can't use an undefined value as an ARRAY reference at
/home/katrin/kohaclone/serials/serials-collection.pl line 131.

And after running the Schema update script:
DBIx::Class::Schema::resultset(): resultset() expects a source name at
/home/katrin/kohaclone/Koha/Objects.pm line 235

Please take a look!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14686] New menu option and permission for file uploading

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m
 Status|Signed Off  |Failed QA

--- Comment #12 from Jesse Weaver  ---
I strongly believe that for consistency with the rest of Koha (and due to
frustrations that changing the autogenerated schema files causes), that the sub
allows_add_by should be moved to a Koha:: module. The code has no tie to the
uploaded_files table anyway.

Koha::UploadedFiles might be a good name, as that could later easily become a
Koha::Objects subclass, but that's just a suggestion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16145] Regression: Bug 15632 broke display of library name on circulation messages

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16145

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #49571|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 49573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49573=edit
[PASSED QA] Bug 16145: Regression: Bug 15632 broke display of library name on
circulation messages

Wrong var loop used!

Test plan:
Add a message for a patron on the checkouts page.
The library name should be displayed.

Signed-off-by: Christopher Brannon 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16145] Regression: Bug 15632 broke display of library name on circulation messages

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16145

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000

--- Comment #25 from Christopher Brannon  ---
Schedule button duplicates after update or save as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

--- Comment #50 from Mirko Tietgen  ---
Created attachment 49572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49572=edit
screenshot

Tried again with updated Apache config. No 404 anymore, but it does not seem
like the files are reloaded. It looks like a redirect to me and the files used
are the ones in the cache, see attached screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000

--- Comment #24 from Christopher Brannon  ---
(In reply to Katrin Fischer from comment #23)
> Showing an existing export, the schedule button appears twice now.
> (cgi-bin/koha/reports/guided_reports.pl?reports=1=Show%20SQL)

Yep. I missed that one.  :/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16145] Regression: Bug 15632 broke display of library name on circulation messages

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16145

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com
 Status|Needs Signoff   |Signed Off

--- Comment #2 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16145] Regression: Bug 15632 broke display of library name on circulation messages

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16145

--- Comment #3 from sandbo...@biblibre.com  ---
Created attachment 49571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49571=edit
Bug 16145: Regression: Bug 15632 broke display of library name on circulation
messages

Wrong var loop used!

Test plan:
Add a message for a patron on the checkouts page.
The library name should be displayed.

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16145] Regression: Bug 15632 broke display of library name on circulation messages

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16145

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #49560|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #23 from Katrin Fischer  ---
Showing an existing export, the schedule button appears twice now.
(cgi-bin/koha/reports/guided_reports.pl?reports=1=Show%20SQL)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15931] If Authority is not used by any records, remove link to cataloguing search

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15931

--- Comment #9 from Jonathan Druart  
---
Created attachment 49570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49570=edit
Bug 15931: Replace relative path with /cgi-bin/koha/

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15931] If Authority is not used by any records, remove link to cataloguing search

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15931

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #49539|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 49569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49569=edit
Bug 15931: Removing link to records if authority is not used by any records

EDIT:
Fixing typo: records(s) -> record(s)
On details page, if authority is not used in any records, the page will display
a more used friendly message: "This authority is not used in any records."

To test:
1) Do an authority search on authorities-home.pl. Notice that authorities not
used in any records have a clickable link (under 'Used in:' column) which
redirects to a catalog search with no results
2) Go back to your authority search results on authorities-home.pl and click
'Details'. Notice that under the auth name, there is a 'Used in X records' link
that again returns a catalog search with no results.
3) Apply patch
4) Repeat steps 1, 2. Authorities not used in any records should no longer have
clickable links and links to authorities which are used in records should work
as expected.
5) Confirm it now says record(s) instead of records(s)
6) Confirm that on detail page for an authority which is not used by any
records, it now says more friendly message.

Sponsored-by: Catalyst IT

Signed-off-by: Nick Clemens 
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15931] If Authority is not used by any records, remove link to cataloguing search

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15931

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #49555|0   |1
is obsolete||

--- Comment #43 from Jesse Weaver  ---
Created attachment 49568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49568=edit
Bug 16044: Populate the L1 cache when L2 is fetched

The whole patch set is not very pertinent is the L1 cache is not
populated when L2 is fetched!
This patch fixes this inconsistency.

Signed-off-by: Jesse Weaver 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15413] Adding colons where they should appear in forms etc to be consistent

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15413

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
These ones may be missing:

  23 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt:   
Title
  29 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt:   
Vendor invoice 
  32 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt:Primary acquisitions contact
  33 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt:Primary serials contact
  34 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt:Receives claims for late orders
  35 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt:Receives claims for late issues

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15413] Adding colons where they should appear in forms etc to be consistent

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15413

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #49531|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 49567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49567=edit
Bug 15413: Adding colons where appropriate

To test:

Apply patch and go to pretty much every page on the Intranet - look out
for labels on forms etc where there should be colons but aren't. If you
see any that I've missed but I'm 99% sure I got all of them! Make sure
to click through some forms where creating a new thing involves
continuing the submission on multiple pages.

Signed-off-by: Owen Leonard 

Rebased on current master and checked all changed pages.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15413] Adding colons where they should appear in forms etc to be consistent

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15413

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16146] [3.22] ACQ: Previewed records in Z39.50 search results are wrong

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|ACQ: Previewed records in   |[3.22] ACQ: Previewed
   |Z39.50 search results are   |records in Z39.50 search
   |wrong   |results are wrong

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16146] ACQ: Previewed records in Z39.50 search results are wrong

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #49558|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 49566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49566=edit
[PASSED QA] Bug 16146 - ACQ: Previewed records in Z39.50 search results are
wrong

For 3.22.x only:

This patch fixes a bug which was fixed in cataloging by Bug 6367 and
fixed in master by Bug 15318. A misplaced line of JavaScript means that
the popup menu of options shown when clicking in a table cell links to
the wrong record.

To test:

1. Apply the patch and navigate to Acquisitions.
2. Locate an exsiting basket or create a new one.
3. Add to the basket using the option to order from an external source..
4. Perform a search which will return multiple results.
5. Test the "MARC" and "Card" links for multiple results and confirm
   that the correct data is shown each time.
6. Click anywhere in the results table to show the hidden menu and test
   the "Preview MARC," "Preview card," and "Order" links it displays,
   confirming that the actions complete using the correct record.

Signed-off-by: Jonathan Druart 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16146] ACQ: Previewed records in Z39.50 search results are wrong

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441

Katrin Fischer  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #14 from Katrin Fischer  ---
*** Bug 11528 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11528] TrackClicks feature messes up proxied EBSCO e-books links?

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11528

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #6 from Katrin Fischer  ---
I think this is a duplicate to bug 14441 - please reopen if problem remains!

*** This bug has been marked as a duplicate of bug 14441 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15838] syspref SubscriptionDuplicateDroppedInput does not work for all fields

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15838

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
This patch is not perfect, but the feature is so ugly (I have written it...)
and so poorly documented that I am almost sure nobody uses it.
The id/name does not match the db column in all cases, I don't understand how a
librarian could guess them!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15838] syspref SubscriptionDuplicateDroppedInput does not work for all fields

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15838

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15838] syspref SubscriptionDuplicateDroppedInput does not work for all fields

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15838

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #49526|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 49565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49565=edit
Bug 15838 - Subscription duplicating: Reset fields from
SubscriptionDuplicateDroppedInput syspef by getting them using name instead of
id

How I tested:
Verified bug with start and end date (were not cleared without patch).
After applying the patch all fields defined in
SubscriptionDuplicateDroppedInput
were cleared as expected.

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15914] LocalHoldsPriority is not honored when new item is first triggered

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15914

Christopher Brannon  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REOPENED|RESOLVED

--- Comment #4 from Christopher Brannon  ---
Can't seem to reproduce in a test environment.  May not have all settings or
conditions accounted for, but this may be resolved with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514.  Going to mark
this as a duplicate for now.  Will reopen if the problem persists after that
patch is released.

Christopher

*** This bug has been marked as a duplicate of bug 14514 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #7 from Christopher Brannon  ---
*** Bug 15914 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16139] Renaming 'Unseen since' column in Inventory/Stocktaking

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16139

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #49524|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 49564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49564=edit
Bug 16139: Renaming 'Unseen since' column to 'Last seen'

To test:
1) Go to Tools -> Inventory/Stocktaking
2) Submit empty form to bring back all records (or specify, up to you)
3) Notice column name 'Unseen since'
4) Apply patch and go back to Inventory/Stocktaking, resubmit form
5) Confirm column name is now 'Last seen' and makes more sense

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16139] Renaming 'Unseen since' column in Inventory/Stocktaking

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16139

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11498] Prevent bypassing sco timeout with print dialog

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11498

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #47859|0   |1
is obsolete||

--- Comment #5 from Mirko Tietgen  ---
Created attachment 49562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49562=edit
Bug 11498 - Prevent bypassing sco timeout with print dialog

This patch prevents bypassing the self check timeout with the print dialog.

To test:
- Set syspref 'WebVasedSelfCheck' to 'Enable'
- Set syspref 'SelfCheckoutReceivePrompt' to 'Show'
- Set syspref 'SelfCheckTimeout' to 20 seconds
- Apply patch
- Go to SCO page (/cgi-bin/koha/sco/sco-main.pl)
- Enter card number
- Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears.
- Confirm printing without waiting 20 seconds
  => Result: Print slip, SCO page shows 'Please enter your card number'
- Enter card number again
- Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears.
- Wait > 20 seconds (value of SelfCheckTimeout) and then confirm.
  => Result: Message appears "Timeout while waiting for print confirmation"
- Click on OK.
  => Result: Self checkout page refreshes (shows 'Please enter your card
number')

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16141] Making 'Transfers to receive' action a button

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16141

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16141] Making 'Transfers to receive' action a button

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16141

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #49523|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 49563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49563=edit
Bug 16141: Making Transfers to Receive action a button

To test:

1) Go to Circ -> Transfer to Receive
2) Confirm 'Cancel transfer' now shows as a button and works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11498] Prevent bypassing sco timeout with print dialog

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11498

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16142] Making 'order' a button for new order suggestions

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16142

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16142] Making 'order' a button for new order suggestions

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16142

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #49522|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 49561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49561=edit
Bug 16142: Making 'Order' a button for New Order Suggestions

To test:

1) Go to Acquisitions and find a vendor
2) Add to a basket from a suggestion
3) Confirm that 'Order' next to the suggestions looks like a button and works
as expected

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

--- Comment #49 from Jonathan Druart  
---
Could you confirm you have updated your apache config?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16145] Regression: Bug 15632 broke display of library name on circulation messages

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16145

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 Blocks|15632   |
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||15632
   Patch complexity|--- |Trivial patch


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632
[Bug 15632] Move the messages related code to Koha::Patron::Messages
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16145
 Depends on|16145   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16145
[Bug 16145] Regression: Bug 15632 broke display of library name on circulation
messages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16145] Regression: Bug 15632 broke display of library name on circulation messages

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16145

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16145] Regression: Bug 15632 broke display of library name on circulation messages

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16145

--- Comment #1 from Jonathan Druart  
---
Created attachment 49560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49560=edit
Bug 16145: Regression: Bug 15632 broke display of library name on circulation
messages

Wrong var loop used!

Test plan:
Add a message for a patron on the checkouts page.
The library name should be displayed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15846] Move MARC Framework JavaScript into separate file

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15846

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15846] Move MARC Framework JavaScript into separate file

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15846

Jesse Weaver  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #7 from Jesse Weaver  ---
Will be in the May 2015 release, thanks for your work!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #45983|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 49559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49559=edit
Bug 12178: Update serial status to "claimed" when exporting to CSV

On the same way as late issues, the serial status should be updated to
'claimed' when the issues as exported as csv.

QA note: The updateClaim and UpdateClaimdateIssues subroutine did almost the
same thing, I kick the second on off to centralize the code.

Test plan:
1/ Export some late issues as CSV (serials/claims.pl).
2/ Refresh the page (the export does not do it) and confirm that the
status, the claim date and the claim count have been updated.
3/ Select some others issues, select a notice and send the notification.
Confirm that the behavior is the same.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14614] Multiple URLs (856) in cart/list email are broken

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14614

--- Comment #9 from Katrin Fischer  ---
Thx a lot for fixing this!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net
 Status|Needs Signoff   |Failed QA

--- Comment #48 from Mirko Tietgen  ---
I tried this, and I see the scripts having version numbers, but they are part
of the file name and so they all throw 404s.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16146] ACQ: Previewed records in Z39.50 search results are wrong

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146

--- Comment #5 from Jonathan Druart  
---
(In reply to Owen Leonard from comment #3)
> (In reply to Jonathan Druart from comment #2)
> > Both MARC and Card look good on 3.22.x for me.
> 
> It's not the links in the last table cell in each row, but in the little
> menu which appears if you click within one of the other table cells.

Indeed!
Sorry not to read commit messages with attention...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16146] ACQ: Previewed records in Z39.50 search results are wrong

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16146] ACQ: Previewed records in Z39.50 search results are wrong

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #49540|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 49558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49558=edit
Bug 16146 - ACQ: Previewed records in Z39.50 search results are wrong

For 3.22.x only:

This patch fixes a bug which was fixed in cataloging by Bug 6367 and
fixed in master by Bug 15318. A misplaced line of JavaScript means that
the popup menu of options shown when clicking in a table cell links to
the wrong record.

To test:

1. Apply the patch and navigate to Acquisitions.
2. Locate an exsiting basket or create a new one.
3. Add to the basket using the option to order from an external source..
4. Perform a search which will return multiple results.
5. Test the "MARC" and "Card" links for multiple results and confirm
   that the correct data is shown each time.
6. Click anywhere in the results table to show the hidden menu and test
   the "Preview MARC," "Preview card," and "Order" links it displays,
   confirming that the actions complete using the correct record.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #13 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441

--- Comment #12 from Katrin Fischer  ---
Rebased - fixed conflict with the recent security fix in the first patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16147] New: OpacItemLocation and not for circulation Item types

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16147

Bug ID: 16147
   Summary: OpacItemLocation and not for circulation Item types
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ed.v...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

If you set the OpacItemLocation to anything other than "Call number only" the
call number is repeated on the Location line for all items with item types that
don't circulate. 

 [Call number:
]

 [Call number: ]

Ed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441

--- Comment #11 from Katrin Fischer  ---
Created attachment 49557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49557=edit
Bug 14441: TrackClicks cuts off/breaks URLs (XSLT)

Same test plan as previous patch, but for opac defail and result using
the XSLT views.

Signed-off-by: Katrin Fischer 
I am amazed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #48486|0   |1
is obsolete||
  Attachment #48522|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 49556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49556=edit
Bug 14441 - TrackClicks cuts off/breaks URLs

to test...

1/ set TrackClicks syspref to 'track'

2/ add a problematic multipart url to an item's 'url' field
example url: http://foo.corg?key1=val1=val2

3/ test url in opac-detail.pl - url is corrupt

4/ apply patch - url is corrct

Signed-off-by: Katrin Fischer 
Only fixes the item URLs - a follow-up for the URLs
in the bibliographic record (856 for MARC21) is still
needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

--- Comment #42 from Jonathan Druart  
---
I was going to ask Tomas or Jacek, but Jesse is around at this time :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16146] ACQ: Previewed records in Z39.50 search results are wrong

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146

--- Comment #3 from Owen Leonard  ---
(In reply to Jonathan Druart from comment #2)
> Both MARC and Card look good on 3.22.x for me.

It's not the links in the last table cell in each row, but in the little menu
which appears if you click within one of the other table cells.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14686] New menu option and permission for file uploading

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686

--- Comment #11 from Marcel de Rooy  ---
(In reply to Mirko Tietgen from comment #10)
> Works as advertised.
> 
> One question: without upload_manage permission users are able to delete the
> files they uploaded themselves. I suppose that is intended, but it was not
> explicitly mentioned in the test plan. Is it the intended behaviour?

Thx for testing.
Yes, it is intended. (I wrote it in the first commit message, maybe should have
been more explicit).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

--- Comment #41 from Brendan Gallagher  ---
(In reply to Jonathan Druart from comment #40)
> Created attachment 49555 [details] [review]
> Bug 16044; Populate the L1 cache when L2 is fetched
> 
> The whole patch set is not very pertinent is the L1 cache is not
> populated when L2 is fetched!
> This patch fixes this inconsistency.

Skip QA ok?  Or I can ask piano to look.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

--- Comment #40 from Jonathan Druart  
---
Created attachment 49555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49555=edit
Bug 16044; Populate the L1 cache when L2 is fetched

The whole patch set is not very pertinent is the L1 cache is not
populated when L2 is fetched!
This patch fixes this inconsistency.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

--- Comment #39 from Jonathan Druart  
---
(In reply to Jacek Ablewicz from comment #19)
> BTW, that part of the 1st followup:
> 
>  my $get_sub = $self->{ref($self->{$cache}) . "_get"};
> -return $get_sub ? $get_sub->($key) : $self->{$cache}->get($key);
> +my $value = $get_sub ? $get_sub->($key) : $self->{$cache}->get($key);
> +
> +$L1_cache{$key} = $value;
> +
> +return $value;
> 
> is essential if you want to test this bug with L2 = memcache; without it, L1
> cache is not getting populated in such setups. Which explains case 1) from
> comment #17 ;)

This comment was very relevant and I should have submitted a follow-up to make
this patchset pertinent and useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16146] ACQ: Previewed records in Z39.50 search results are wrong

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
Both MARC and Card look good on 3.22.x for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793

--- Comment #18 from Jonathan Druart  
---
(In reply to Owen Leonard from comment #17)
> (In reply to Aleisha Amohia from comment #12)
> > This patch has no floating toolbar or names styled as links. I've removed
> > the radio buttons. The row is clickable and will redirect you to the user's
> > page.
> 
> I strongly disagree with this solution. There is no indication at all, now,
> that the user can perform any action. Nothing looks like a link and the
> mouse cursor doesn't change to indicate anything is clickable.

Does the solution work for you if we change the cursor?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #30 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14686] New menu option and permission for file uploading

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #10 from Mirko Tietgen  ---
Works as advertised.

One question: without upload_manage permission users are able to delete the
files they uploaded themselves. I suppose that is intended, but it was not
explicitly mentioned in the test plan. Is it the intended behaviour?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #38 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14686] New menu option and permission for file uploading

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #49261|0   |1
is obsolete||

--- Comment #9 from Mirko Tietgen  ---
Created attachment 49554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49554=edit
Bug 14686: Add Upload to Tools menu

This patch makes sure that the added granular permissions work as
advertised.

Note: The field owner was not included in the Koha::Upload->get response.
The code to verify if a user is allowed to delete an upload, is concentrated
in the template now. When get returns a Koha::Object, this check could be
relocated.

Test plan:
[1] Verify that the current user has permission for tools, or has
at least upload_general_files.
[2] Do you see Upload in the Tools menu? Follow the link.
[3] Upload a permanent file (with a category).
[4] Do you see the Delete button in the results form?
[5] Make sure that another user has no permission to upload.
[6] Login as that user and check the Tools menu.
Try the URL [yourserver]/cgi-bin/koha/tools/upload.pl
You should have no access to the upload form.
[7] Enable upload_general_files for this user. Go to upload and search for
the upload from step 3. You should not see a Delete button.
[8] Enable upload_manage for this user. Search for the upload again.
Delete the upload.
[9] Go to upload via the Cataloguing editor (856$u plugin) or add
parameter "plugin=1" to the URL. You should not see the Tools menu.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14686] New menu option and permission for file uploading

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #49260|0   |1
is obsolete||

--- Comment #8 from Mirko Tietgen  ---
Created attachment 49553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49553=edit
Bug 14686: Add two granular permission for upload under tools

[1] Upload_general_files
This will allow you to access the tools/upload form via the Tools menu.
And it will also allow you to add permanent uploads.

[2] Upload_manage
It will allow you to delete uploads from other users.
Note that anyone may delete his own uploads.
It is not meant to include upload_general_files.

In order to not disturb existing users that now have edit_catalogue and are
using the plugin (read: added at least one record to uploaded_files), we
will add the first permission for them. New users will need to be authorized
in the usual way thereafter.

Note: If you only have one of the other permissions checked in allows_add_by,
e.g. stage_marc_import, you can add temporary uploads, but not permanent
uploads.

Test plan:
We are only testing the dbrev here, not if the perm works as advertised.
[1] Run the dbrev and check that you see the perms with a description on
the Patron/Set permissions page.
[2] If you had records in uploaded_files and a user with edit_catalogue
*only*, verify that this user now also has upload_general_files.

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14686] New menu option and permission for file uploading

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #49257|0   |1
is obsolete||

--- Comment #7 from Mirko Tietgen  ---
Created attachment 49552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49552=edit
Bug 14686: Add allows_add_by to check permissions for uploading

The three permissions in tools/upload-file.pl are moved to a custom
routine in DBIx's UploadedFile.pm. An additional granular permission
upload_general_files is added. (The dbrev patch will contain it too.)
At some point in time this could be moved to a Koha::Object class.

The routine is tested in Upload.t.

Test plan:
[1] Run t/db_dependent/Upload.t
[2] If you only apply this patch, you can also test uploading with a
user that has edit_catalogue but does not have tools or circulate.
Upload status should say: Denied.

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16140] Only clear L1 cache when needed

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #3 from Tomás Cohen Arazi  ---
Are we sure it doesn't cost more to calculate the invalidated-status than to
retrieve the data on each request?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16070] Empty (undef) system preferences may cause some issues in combination with memcache

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16070

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #49254|0   |1
is obsolete||

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 49551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49551=edit
Bug 16070: Add atomic update file

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16070] Empty (undef) system preferences may cause some issues in combination with memcache

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16070

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16070] Empty (undef) system preferences may cause some issues in combination with memcache

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16070

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #49196|0   |1
is obsolete||

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 49550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49550=edit
Bug 16070: Default value for sysprefs should be an empty string

The default value for sysprefs should not be NULL but an empty string.
When a pref is cleared, it's set to an empty string, so it does not make
sense to create it with an undefined value.

The main purpose of this patch is to remove the warning in logs when a
pref is accessed for the first time and the cache is not yet populated.
It also ensures that the behavior will be the same for the first access
and the others.

Test plan:
SELECT COUNT(*) FROM systempreferences WHERE value IS NULL;
Should not return any results after the update DB entry executed.

Signed-off-by: Srdjan 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14993] rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14993

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net
 Status|Needs Signoff   |Failed QA

--- Comment #4 from Mirko Tietgen  ---
Zebra is not going away any time soon. ES is not going to be a replacement, but
an alternative, at least for the foreseeable future.

If this is being touched, it should fix the problem by creating the folders
instead of failing because they are missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #37 from Tomás Cohen Arazi  ---
Looks good, works as expected. Great job guys.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #49494|0   |1
is obsolete||

--- Comment #36 from Tomás Cohen Arazi  ---
Created attachment 49549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49549=edit
Bug 16044: Add an unsafe flag to Koha::Cache->get_from_cache

If the caller/developer knows what he is doing, he can decide not to
deep copy the structure. It will be faster but unsafe!
If the structure is modified, the cache will also be updated.
This option must be used with care and is not the default behavior.

Signed-off-by: Jesse Weaver 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #49492|0   |1
is obsolete||

--- Comment #34 from Tomás Cohen Arazi  ---
Created attachment 49547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49547=edit
Bug 16044: Add tests to make sure structures will be copied

Signed-off-by: Jesse Weaver 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #49493|0   |1
is obsolete||

--- Comment #35 from Tomás Cohen Arazi  ---
Created attachment 49548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49548=edit
Bug 16044: Add deep cloning

To avoid the cache to be modified unfortunately, the default behavior of
get_from_cache will be to deep copy if we are getting a structure.
If the item is a scalar, it's simply returned.

Signed-off-by: Jesse Weaver 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #49491|0   |1
is obsolete||

--- Comment #33 from Tomás Cohen Arazi  ---
Created attachment 49546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49546=edit
Bug 16044: Make tests from t/Cache.t pass

The timeout does not impact the L1 cache (it would be to time consuming
and not really useful to do that for this cache).
To simulate the real timeout, we need to flush this L1 cache when
needed.
It would be also done adding a disable_L1_cache method.

Signed-off-by: Jesse Weaver 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #49490|0   |1
is obsolete||

--- Comment #32 from Tomás Cohen Arazi  ---
Created attachment 49545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49545=edit
Bug 16044: Use the L1 cache for any objects set in cache

Signed-off-by: Jesse Weaver 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16117] Feature request: Log borrower cardnumbers and item barcodes which are not valid

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com
   Assignee|koha-b...@lists.koha-commun |bar...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16117] Feature request: Log borrower cardnumbers and item barcodes which are not valid

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117

Nicole C. Engard  changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16079] Retrieving system preferences from database via DBIx is not fast enough

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079

Jacek Ablewicz  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12670] Show materials label instead of code

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12670

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #27 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000

--- Comment #22 from sandbo...@biblibre.com  ---
Created attachment 49544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49544=edit
Bug 16000: Simplify JS code

Signed-off-by: Owen Leonard 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000

--- Comment #21 from sandbo...@biblibre.com  ---
Created attachment 49543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49543=edit
Bug 16000 [Revised] Duplicate a report from the New Reports button

This patch creates a combined edit/duplicate/delete toolbar menu option
similar to the one on the bibliographic detail page. Also added is the
"Schedule" link which was previously only available from the main list
of saved reports. Also added is some deletion confirmation JavaScript
for deletions initiated from the toolbar.

To test, apply the patch and go to Reports -> Saved reports.

- Click "Show" in the menu for any saved report. The toolbar which
  appears on this page should show the new menu items.
- Confirm the behavior of all the buttons.
- As you check the behavior of the button actions, check that the
  toolbar is shown and hidden appropriately for each action.
- Confirm that the toolbar is correctly shown or hidden when building a
  guided report.
- Confirm that the "Schedule" button is shown or hidden according to the
  logged-in user's "schedule_tasks" permission.
- Confirm that clicking the "Delete" menu option triggers a JS
  confirmation.

Revision passes the sql data to the template in the case of the
"save_successful" screen.

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #49541|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #49542|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #28 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #20 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15932] Moving Authorities actions into a drop-down menu

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #18 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16011] Remove $VERSION from our modules

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #31 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000

Owen Leonard  changed:

   What|Removed |Added

  Attachment #49277|0   |1
is obsolete||

--- Comment #19 from Owen Leonard  ---
Created attachment 49542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49542=edit
Bug 16000: Simplify JS code

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000

Owen Leonard  changed:

   What|Removed |Added

  Attachment #49276|0   |1
is obsolete||

--- Comment #18 from Owen Leonard  ---
Created attachment 49541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49541=edit
Bug 16000 [Revised] Duplicate a report from the New Reports button

This patch creates a combined edit/duplicate/delete toolbar menu option
similar to the one on the bibliographic detail page. Also added is the
"Schedule" link which was previously only available from the main list
of saved reports. Also added is some deletion confirmation JavaScript
for deletions initiated from the toolbar.

To test, apply the patch and go to Reports -> Saved reports.

- Click "Show" in the menu for any saved report. The toolbar which
  appears on this page should show the new menu items.
- Confirm the behavior of all the buttons.
- As you check the behavior of the button actions, check that the
  toolbar is shown and hidden appropriately for each action.
- Confirm that the toolbar is correctly shown or hidden when building a
  guided report.
- Confirm that the "Schedule" button is shown or hidden according to the
  logged-in user's "schedule_tasks" permission.
- Confirm that clicking the "Delete" menu option triggers a JS
  confirmation.

Revision passes the sql data to the template in the case of the
"save_successful" screen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11450] Hold Request Confirm Deletion

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450

--- Comment #4 from Christopher Brannon  ---
Still valid in master as of 3/24/16.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16028] Remove redundant hold links

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16028

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #7 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16100] Buttons in patron toolbar are styled differently

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16100

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #11 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2016-03-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #211 from Mirko Tietgen  ---
And, auth search is broken for Zebra too.

Software error:

Can't locate object method "simple_search_compat" via package
"Koha::SearchEngine::Zebra::Search" at /home/koha/koha/C4/AuthoritiesMarc.pm
line 357.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 3 >

1 - 100 of 218 matches

Mail list logo