[Koha-bugs] [Bug 16058] Add a button to delete an individual news item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16058

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16058] Add a button to delete an individual news item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16058

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16058] Add a button to delete an individual news item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16058

--- Comment #2 from Aleisha Amohia  ---
Created attachment 49617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49617=edit
Bug 16058: Delete individual news item from koha-news.pl

This patch adds a confirm message for deleting a news item from the home page
in the staff client. It also gives the ability to delete an individual news
item from koha-news.pl with a confirm message. The buttons on koha-news.pl are
now styled as font awesome buttons.

To test:
1) Go to main intranet page. Click 'Delete' for a news item.
2) Confirm that Cancel stops the Delete, and OK deletes the item and takes you
to tools/koha-news.pl
3) Confirm that the buttons (Edit and Delete) on koha-news.pl are now styled as
font awesome buttons and the buttons don't wrap on a narrow browser.
4) Confirm that the column heading for the buttons is now "Actions".
5) Confirm that clicking Delete triggers a confirm message. Confirm that Cancel
stops the Delete, and OK deletes the item and it no longer shows in the News
table or anywhere else.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11172] Reports need a clear filter button

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11172

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #3 from Aleisha Amohia  ---
Is this still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2324] Undo Import should have a confirm dialog

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2324

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com
   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2324] Undo Import should have a confirm dialog

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2324

--- Comment #2 from Aleisha Amohia  ---
Created attachment 49616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49616=edit
Bug 2324: Adding confirm dialog when undoing import

To test:
1) Go to Tools -> Staged MARC Management
2) Click on a batch to see details
3) If not already imported, then import, otherwise you should already see the
button to undo import into catalog.
4) Click this button. Confirm you are asked to confirm. Confirm clicking Cancel
will cancel the undo. Confirm clicking OK will continue with the undo.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2324] Undo Import should have a confirm dialog

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2324

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #92 from M. Tompsett  ---
See the test plan in comment #61.
Known failings: MARCXML stuff.
Known failings: LEADER fields.
Desired extensions beyond the scope of this particular bug: Authorized Values.
I still have to fully test. But this is provided so as to see whether it
addresses comment #86 sufficiently.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett  changed:

   What|Removed |Added

  Attachment #49291|0   |1
is obsolete||

--- Comment #91 from M. Tompsett  ---
Created attachment 49615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49615=edit
Tweak C4/XSLT to delete field when no subfields left.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett  changed:

   What|Removed |Added

  Attachment #49290|0   |1
is obsolete||

--- Comment #90 from M. Tompsett  ---
Created attachment 49614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49614=edit
Biblio tweak for MARCSUBJECT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett  changed:

   What|Removed |Added

  Attachment #49289|0   |1
is obsolete||

--- Comment #89 from M. Tompsett  ---
Created attachment 49613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49613=edit
Applying filtering to opac interface.

Applying the filtering and then...
Debugging opac/opac-detail.pl filtering
Debugging opac/opac-ISBDdetail.pl more
Debugging opac/opac-export.pl
Tweak opac/opac-export.pl fix variable declarations, conditional assignments
Debugging opac/opac-showmarc.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett  changed:

   What|Removed |Added

  Attachment #49288|0   |1
is obsolete||

--- Comment #88 from M. Tompsett  ---
Created attachment 49612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49612=edit
Bug 11592 - Add should_hide_marc method to filter

Add should_hide_marc to ViewPolicy filter
Add should_hide_marc tests to t/db_dependent/Filter_MARC_ViewPolicy.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824

--- Comment #9 from Aleisha Amohia  ---
(In reply to Marc Véron from comment #8)
> Created attachment 49525 [details]
> Button and link in batch item deletion result page
> 
> Buttons for batch item modification look fine.
> 
> Regarding batch item deletion:
> 
> The "Return" button appears in addition to the "Return" links on all Batch
> item deletion results.
> I think it would be better to replace the link with the button at the
> position where the link is (inside the blueish result message box).

Hi Marc,

Can I ask why you think this would look better? The behaviour is exactly the
same for batch item modification.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #49520|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #49521|0   |1
is obsolete||

--- Comment #19 from Aleisha Amohia  ---
Created attachment 49611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49611=edit
Bug 15793 - UX of circulation patron search with long lists of returned
borrowers

Okay how about this:
This patch has no floating toolbar or names styled as links. I've removed the
radio buttons. The row is clickable and will redirect you to the user's page.

EDIT: This patch makes the cursor a pointer when hovering over the patrons. The
row will also be highlighted on hover to make it even clearer.

To test:
1) Put in a patron search that will bring back a long list of patrons (ie the
letter 'a')
2) Select a patron by clicking anywhere on the row - confirm you are taken to
the correct patron page

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793

Aleisha Amohia  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #49497|0   |1
is obsolete||

--- Comment #4 from Aleisha Amohia  ---
Created attachment 49610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49610=edit
Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron
toolbar

This patch moves all the code into an include which can be accessed from the
'Add a new message' link or the patron toolbar.

EDIT: Ensuring modal opens on all pages

To test:
1) Go to a patron circ page (circ/circulation.pl?borrowernumber=X)
2) Click 'Add a new message' under Messages
3) Confirm this brings up the modal to add a message. Confirm clicking Save
saves your message. If it is an OPAC message (for the user), confirm it shows
as expected on the OPAC.
4) Click Cancel. Confirm this closes the modal.
5) Click 'Add message' button in toolbar. Complete steps 3 and 4.
6) Confirm the modal opens from all other pages with the members toolbar (ie
Details, Fines etc)

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9259] batch delete marc batches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259

--- Comment #1 from Aleisha Amohia  ---
Created attachment 49609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49609=edit
Bug 9259: Ability to delete a staged file once it has been cleaned

To test:
1) Go to Tools -> Staged MARC Management and clean a file. If you have no files
to clean, go to 'Stage MARC for import' and upload one to clean following the
necessary steps.
2) Confirm that once the file has been cleaned, the Action column now shows a
Delete button. Confirm this button only shows for cleaned files.
3) Click the Delete button.
4) Confirm that clicking Cancel exits the pop-up message and does not delete
the file.
5) Confirm that clicking OK refreshes the list of staged records and the one
you just deleted is no longer on it (has been deleted). You can confirm this by
checking for the file in mysql (SELECT * FROM import_batches WHERE
import_batch_id = X;)

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9259] batch delete marc batches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9259] batch delete marc batches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored
   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Failed QA

--- Comment #32 from Katrin Fischer  ---
Some first tests:
1) New permissions need to be added to the permissions.inc file for
translation.
2) Datatables on the new tools page are broken.
3) Misses tools sidebar navigation.

I feel like the templates look a bit odd - maybe it would be better to have the
different parts in separate boxes? Once this is progressed a bit further, we
can worry about prettying thing up :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #52 from Katrin Fischer  ---
Hm, taking a first look at this.

If I understand it correctly, this will replace the strings 'on the fly' from
the new po file 'messages' as the string is in the .pl file and no longer in
the .tt file?

I am concerned how this will impact performance especially if we start using
this more and more and when the .po file grows.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
I think I agree with Jonathan here: In order to have some consistency I'd add a
searchable flag in the field configuration and use that to determine if the
field shows up in the result list and if it's searchable. 
This would copy the behaviour from the additional subscription fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11844] Additional fields for order lines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Jesse Weaver  changed:

   What|Removed |Added

 CC|pianohac...@gmail.com   |jwea...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11844] Additional fields for order lines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #19 from Katrin Fischer  ---
Just some first notes on this:

1) New "add order line fields" page

a) Test plan calls for adding fields with AV category and MARC field, but this
always results in this error message for me:
You cannot select an authorised value category and a marcfield

b) why have the datatable search field below the table instead of above? I know
we have other places where it's like this, but it always irritates me - the
search is most useful for a big table and this will require you to scroll all
the way to the end of the table first.

c) this looks like a tiny translation issue:
'aLengthMenu': [[10, 20, 50, 100, -1], [10, 20, 50, 100, "All"]],

d) it would be nice, if the table could use the new buttons we for Edit and
Delete as introduced for a lot of other tables recently to match the new design
pattern.

e) Icon icon-plus and others should be FA icons.

Otherwise this seems to work ok. :)

I am wondering what the next step is - this patch will allow to see and
manipulate the fields on adding an order, but later, once the basket is closed
you won't be able to see or search for them. So we should try and get bug 11870
sorted and maybe think about a way to show the fields on receive and on the
basket summary page (in separate bugs).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11498] Prevent bypassing sco timeout with print dialog

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11498

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
This improves the situation as it's no longer so easily possible to print a
slip from another patron. 

It would be good if we also had a way to reset the summary screen in the
background after the timeout so the checked out items are no longer visible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11498] Prevent bypassing sco timeout with print dialog

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11498

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11498] Prevent bypassing sco timeout with print dialog

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11498

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #49562|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 49608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49608=edit
[PASSED QA] Bug 11498 - Prevent bypassing sco timeout with print dialog

This patch prevents bypassing the self check timeout with the print dialog.

To test:
- Set syspref 'WebVasedSelfCheck' to 'Enable'
- Set syspref 'SelfCheckoutReceivePrompt' to 'Show'
- Set syspref 'SelfCheckTimeout' to 20 seconds
- Apply patch
- Go to SCO page (/cgi-bin/koha/sco/sco-main.pl)
- Enter card number
- Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears.
- Confirm printing without waiting 20 seconds
  => Result: Print slip, SCO page shows 'Please enter your card number'
- Enter card number again
- Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears.
- Wait > 20 seconds (value of SelfCheckTimeout) and then confirm.
  => Result: Message appears "Timeout while waiting for print confirmation"
- Click on OK.
  => Result: Self checkout page refreshes (shows 'Please enter your card
number')

Signed-off-by: Mirko Tietgen 

Signed-off-by: Katrin Fischer 

https://bugs.koha-community.org/show_bug.cgi?id=11497

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #79 from Katrin Fischer  ---
Repeated my test from comment#45 - this looks much better now.
Fixed a FA icon that got undone by the patch set in a tiny follow-up.

Please provide tests for the changes made to Members.pm in order for this to
move forward.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #78 from Katrin Fischer  ---
Created attachment 49607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49607=edit
Bug 10612: Follow-up - correcting icon to be Font Awesome

- check print icon on the patron list summary page is correct

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #212 from Chris Cormack  ---
(In reply to Mirko Tietgen from comment #211)
> And, auth search is broken for Zebra too.
> 
> Software error:
> 
> Can't locate object method "simple_search_compat" via package
> "Koha::SearchEngine::Zebra::Search" at /home/koha/koha/C4/AuthoritiesMarc.pm
> line 357.

Sweet thanks for finding that, I'm mostly concerned in finding things that are
broken when not using ElasticSearch. Because those are the blockers. I'll try
to get a fix for this, sometime this week.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #48890|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682

--- Comment #2 from Nick Clemens  ---
Created attachment 49606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49606=edit
Bug 15682 - Only allow merging of 2 or more records form lsits (for
consistency)

Test as above but on shelves.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682

--- Comment #1 from Nick Clemens  ---
Created attachment 49605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49605=edit
Bug 15682 - Merging records from cataloguing search only allows to merge 2
records

To test:
1 - Perform a cataloging search
2 - Attempt to merge 0 results - should fail
3 - Attempt to merge 1 resutls - should fail
4 - Attempt to merge 2 results - should succeed
5 - Attempt to merge 3 results - should succeed
6 - Test any other amount of records and if more than 1 it should
succeed

**Note: On shelves.pl you can merge a single record.  I think that is
incorrect so made this only work for 2. Will add a followup to fix
shelves.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682

Nick Clemens  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #49 from Katrin Fischer  ---
Some notes:

1) a & in the URL breaks the detail page. How can we handle this? I tried
testing the feature with a service that requires you to pass on a library ID
and some other parameters in order to use the service.

2) We already have a system preference mentioning OpenURL: [Don't
include|Include] COinSinOPACResults COinS / OpenURL / Z39.88 in OPAC search
results. Warning: Enabling this feature will slow OPAC search response times.
It has no effect on the OpenURL feature added by this patch. I'd suggest
rephrasing it, but not sure about a suggestion. Maybe just an addition that the
OpenURL feature is separate?

3) Further tests with the service I tried using showed that a lot of the
attributes were invalid (after researching a bit I think we might provide 1.0
valid, while the service is a lower OpenURL version) - so I can't really use
that for testing :(
I'd still much appreciate a 'real life example' to test this with.

4) Please take a look at comment#44

... still needs testing with UNIMARC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16138] Restart plack when rotating logfiles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16138] Restart plack when rotating logfiles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 49604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49604=edit
Bug 16138: Restart plack when rotating logfiles

On log rotation Starman/Plack keeps failing (Auth.pm related problems) due to
permission issues:

Could not compile /usr/share/koha/opac/cgi-bin/opac/opac-search.pl: Can't
locate Authen/CAS/Client/Response/Failure.pm
:   ./Authen/CAS/Client/Response/Failure.pm: Permission denied at
/usr/share/perl/5.20/base.pm line 97.
...propagated at /usr/share/perl/5.20/base.pm line 106.
BEGIN failed--compilation aborted at
/usr/share/perl5/Authen/CAS/Client/Response.pm line 68.
Compilation failed in require at /usr/share/perl5/Authen/CAS/Client.pm line 8.
BEGIN failed--compilation aborted at /usr/share/perl5/Authen/CAS/Client.pm line
8.
Compilation failed in require at /usr/share/koha/lib/C4/Auth_with_cas.pm line
25.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth_with_cas.pm
line 25.
Compilation failed in require at /usr/share/koha/lib/C4/Auth.pm line 63.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth.pm line 90.
Compilation failed in require at
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34.
BEGIN failed--compilation aborted at
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34.

As we do with zebra daemons, starman should be restarted as it doesn't handle
log file rotation
gracefully[1].

I'm not sure how to reproduce it on a dev environment.

[1] https://github.com/miyagawa/Starman/issues/55

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |n...@bywatersolutions.com
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Nicole C. Engard  changed:

   What|Removed |Added

 Blocks||16151


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151
[Bug 16151] can't place holds from lists
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16151] New: can't place holds from lists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151

Bug ID: 16151
   Summary: can't place holds from lists
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 14544

Looks like https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544
might have broken the ability to place holds from lists. 

*  selected the public list 
* placed a check next to the first and fourth items on the list at the top of
the list, I selected 'Place Hold'
* Got the following error message:

Can't call method "field" on an undefined value at
/home/load17/kohaclone/C4/Items.pm line 1491.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544
[Bug 14544] Move the list related code to Koha::Virtualshelves
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #86 from Katrin Fischer  ---
I tried running misc/devel/update_dbix_class_files.pl, but I still get the
error message on trying to save the received issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #87 from M. Tompsett  ---
(In reply to Tomás Cohen Arazi from comment #86)
> I think that function [ShouldHideMARC] is a mistake! Should be using
> C4::Biblio::GetMarcStructure instead. C4::Biblio::GetMarcStructure is cached
> already, and using yours will only make performance worse.

Granted, another SQL query is a performance hit. However, the result is not
keyed on kohafield. I'll post a revision that uses GetMarcStructure, as per
your suggestion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16094] error editing (borrowers, reports) with mysql enterprise

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16094

--- Comment #2 from Humberto Blanco  ---
Hi Jonathan, 
This errors happend using the Koha interface, occurs when we are testing the
koha database in mysql enterprise. Nothing happend in mysql community version.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2523] holds queue report needs additional fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2523

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 CC||n...@bywatersolutions.com

--- Comment #2 from Nick Clemens  ---
I think these are all present now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #86 from Tomás Cohen Arazi  ---
(In reply to M. Tompsett from comment #79)
> Created attachment 49288 [details] [review]
> Add ShouldHideMARC to ViewPolicy filter

I think that function is a mistake! Should be using
C4::Biblio::GetMarcStructure instead. C4::Biblio::GetMarcStructure is cached
already, and using yours will only make performance worse.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15625] Add CLI tool to enable/disable public z39 service, for a Koha instance

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15625

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16149] New: Generate and send custom notices based on report output

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149

Bug ID: 16149
   Summary: Generate and send custom notices based on report
output
 Change sponsored?: Seeking cosponsors
   Product: Koha
   Version: master
  Hardware: All
   URL: http://devs.bywatersolutions.com/projects/custom-notic
es-based-report-output/
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Work to be done: Write a cron script that will
a) Accept parameters for
1) a report id
2) a notice code
3) a notice module
4a) a branchcode
4b) or database column from which to select the branchcode
5) a column from which to select the email address to send to ( if not set,
Koha will use the first available email address for the patron )
6a) A "from" email address
6b) A column from which to select the "from" email address
b) The script will run the report and for each row of results will generate a
notice and queue it for sending. All and only the columns from the report will
be available to be used in the notice text.

Looking for sponsors:
http://devs.bywatersolutions.com/projects/custom-notices-based-report-output/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/