[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens  changed:

   What|Removed |Added

  Attachment #53046|0   |1
is obsolete||

--- Comment #5 from Nick Clemens  ---
Created attachment 53047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53047=edit
Bug 8030 - Change pickup location of a hold from patron record

To test:
1 - Place some holds for a patron
2 - Load the patron into checkout module
3 - View thier holds tab, should have a dropdwon for location
4 - Alter the location
5 - You should recieve a confirmation box
6 - Confirm that pressing cancel does not update holds
7 - Confirm that pressing Yes does update the hold
8 - Confirm that waiting holds are not updateable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #4 from Nick Clemens  ---
needs to adjust for in transit holds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #3 from Nick Clemens  ---
Created attachment 53046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53046=edit
Bug 8030 - Change pickup location of a hold from patron record

To test:
1 - Place some holds for a patron
2 - Load the patron into checkout module
3 - View thier holds tab, should have a dropdwon for location
4 - Alter the location
5 - You should recieve a confirmation box
6 - Confirm that pressing cancel does not update holds
7 - Confirm that pressing Yes does update the hold
8 - Confirm that waiting holds are not updateable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16840] New: URLs for old releases are broken with every new release

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16840

Bug ID: 16840
   Summary: URLs for old releases are broken with every new
release
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Project website
  Assignee: wizzy...@gmail.com
  Reporter: jsn.sher...@gmail.com

I'm working up a nice CentOS 7 ansible role that builds Koha from the tarball
release. The way you shuffle tarball upon release makes automating koha builds
more difficult than it has to be, and is user hostile.

When you move tarballs under old releases, you don't offer a redirect to the
new location, instead you return a 404. When you publish content to the web,
you should treat that URL as valid for as long as you have the associated
content. In this case, you still have the content, and you know exactly where
it is.  Ideally, you would offer clients a 301 redirect to the new location.
You should only return a 404 when you deleted content or honestly have no idea
what the client is asking for.

This is a general website stewardship issue, and it may not seem like the most
critical thing when you are trying to get a release out the door, so I would be
happy to contribute my expertise and/or time to improve this aspect of release
management for Koha.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16838] Elasticsearch - mapping tables are not populated on new installs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16838

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16836] Document unused parameters of SearchAuthorities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836

--- Comment #3 from Marcel de Rooy  ---
(In reply to Héctor Eduardo Castro Avalos from comment #2)
> If you query $ git grep 'SearchAuthorities'
> 
> 
> There are some lines that use the two parameters, maybe exist more:
> 
> 
> authorities/auth_finder.pl:  SearchAuthorities( \@marclist, \@and_or,
> \@excluding, \@operator, \@value,
> authorities/authorities-home.pl:#my ( $results, $total ) =
> SearchAuthorities(
> authorities/ysearch.pl:my ( $results, $total ) = SearchAuthorities(
> \@marclist, \@and_or, \@excluding, \@operator, \@value, $startfrom *
> $resultsperpage, $resultsperpage, $authtypecode, $orderby );
> cataloguing/value_builder/unimarc_field_210c.pl:###TODO To rewrite in order
> to use SearchAuthorities
> cataloguing/value_builder/unimarc_field_210c.pl:my ($results,$total)
> = SearchAuthorities( \@tags,\@and_or,
> cataloguing/value_builder/unimarc_field_225a.pl:my ($results,$total) =
> SearchAuthorities( \@tags,\@and_or,
> 
> Regards

Hello Hector,

That is true. The parameters are passed to the routine, but they actually do
nothing. This patch makes that fact more visible without having to change all
calls of the routine. Note that this allows someone to adjust the routine to do
something useful with these parameters.

Marcel

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819

--- Comment #5 from Jonathan Druart  
---
Comment on attachment 53031
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53031
[SIGNED-OFF]Bug 16819: C4::Members::DelMember should use Koha::Holds to delete
holds

Review of attachment 53031:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=16819=53031)
-

::: C4/Members.pm
@@ +1662,5 @@
>  #warn "in delmember with $borrowernumber";
>  return unless $borrowernumber;# borrowernumber is mandatory.
> +# Delete Patron's holds
> +my @holds = Koha::Holds->search({ borrowernumber => $borrowernumber });
> +map { $_->delete } @holds;

I'd have written that `$_->delete for @holds`. Since map is supposed to return
something I guess it can perturb a new developer. Do you agree?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52722|0   |1
is obsolete||

--- Comment #37 from Jonathan Druart  
---
Created attachment 53040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53040=edit
Bug 15128 - Followup

Only check limit for signed in borrower
Show all suggestions after a new one is added

Signed-off-by: Barbara Walters 

Signed-off-by: Kyle M Hall 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #42 from Jonathan Druart  
---
Created attachment 53045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53045=edit
Bug 15128: Do not display "New suggestion" if limit has just been reached

If limit is X and patrons has X-1 pending suggestions, when a new one is
added, the "New suggestion" should not been added.
to avoid another call to SearchSuggestions, we assume than the
suggestion has been correctly added.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53034|0   |1
is obsolete||

--- Comment #40 from Jonathan Druart  
---
Created attachment 53043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53043=edit
Bug 15128 - (QA Followup) Don't get patrons suggestions if limit not set

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #41 from Jonathan Druart  
---
Created attachment 53044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53044=edit
Bug 15128: Revert Display all purchase suggestions whether or not suggestion
was added

This does not work correctly and should be handle on another bug report.
The behavior existed prior to this patchset.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53033|0   |1
is obsolete||

--- Comment #39 from Jonathan Druart  
---
Created attachment 53042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53042=edit
Bug 15128 - (QA Followup) Fix use of 'my' variable causing loss of data

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52719|0   |1
is obsolete||

--- Comment #34 from Jonathan Druart  
---
Created attachment 53037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53037=edit
Bug 15128 - Add ability to limit patrons open purchase suggestions

To test:
1 - Define a number of MaxOpenSuggestions
2 - Add some suggestions for a patron
3 - Note they cannot add any more suggestions if limit is reached
4 - Delete a suggestion and note you can add another
5 - Add them to limit again
6 - Accept a suggestion in the staff client and note user can add more
7 - Repeat above with rejecting or deleting
8 - Sign off.

Sponsored by:
North Central Regional Library (http://ncrl.org/)

Signed-off-by: Barbara Walters 

Signed-off-by: Kyle M Hall 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #38 from Jonathan Druart  
---
Created attachment 53041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53041=edit
Bug 15128 (QA Followup) Display all purchase suggestions whether or not
suggestion was added Correct enforcement of 0 limit

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52721|0   |1
is obsolete||

--- Comment #36 from Jonathan Druart  
---
Created attachment 53039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53039=edit
Bug 15128 [QA Followup 2] - Only count pending suggestions for the limit

Signed-off-by: Barbara Walters 

Signed-off-by: Kyle M Hall 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52720|0   |1
is obsolete||

--- Comment #35 from Jonathan Druart  
---
Created attachment 53038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53038=edit
Bug 15128 [QA Followup] - Make suggestion display after being added

Also fixes the issue that the add suggestion link would sometimes
show even if the patron could not make an additional suggestion.

Signed-off-by: Barbara Walters 

Signed-off-by: Kyle M Hall 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16839] New: Sort Title (A-Z) doesn't work with some non-latin alphabets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16839

Bug ID: 16839
   Summary: Sort Title (A-Z) doesn't work with some non-latin
alphabets
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 53036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53036=edit
View of ordered results under ICU

Using ICU or not the sorting of a list of results in opac/staff client is
ineffective for character sets such as cyrillic

Without ICU the sorting seems to be by length

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] Add API route for getting an item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #52947|0   |1
is obsolete||

--- Comment #3 from Lari Taskula  ---
Created attachment 53035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53035=edit
Bug 16825: Add API route for getting an item

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #33 from Nick Clemens  ---
Created attachment 53034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53034=edit
Bug 15128 - (QA Followup) Don't get patrons suggestions if limit not set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #32 from Nick Clemens  ---
Created attachment 53033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53033=edit
Bug 15128 - (QA Followup) Fix use of 'my' variable causing loss of data

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
I think that the goal of this table (on the acq home page) was to display a
simplified version of the table on the "all funds" view.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16813] OPACBaseURL cannot be emptied

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16813

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #52889|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 53032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53032=edit
[SIGNED-OFF]Bug 16813: Allow empty string for OPACBaseURL

The pref is prefixed by 'http://', but it should not when the pref is
set to an empty string.
This will fix the bug raised on bug 14790 comment 14.

Test plan:
Empty OPACBaseURL and confirm that it's save as it in DB

Signed-off-by: Hector Castro 
OPACBaseURL is saved up empty. Prefix http:// is not saved anymore

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16813] OPACBaseURL cannot be emptied

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16813

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16838] New: Elasticsearch - mapping tables are not populated on new installs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16838

Bug ID: 16838
   Summary: Elasticsearch - mapping tables are not populated on
new installs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 12478

The yaml file is not used to populate ES mapping tables (search_field,
search_marc_map and search_marc_to_field) when doing a fresh install.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
[Bug 12478] Elasticsearch support for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16838


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16838
[Bug 16838] Elasticsearch - mapping tables are not populated on new installs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #52930|0   |1
is obsolete||

--- Comment #4 from Héctor Eduardo Castro Avalos  ---
Created attachment 53031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53031=edit
[SIGNED-OFF]Bug 16819: C4::Members::DelMember should use Koha::Holds to delete
holds

This patch makes C4::Members::DelMember proprely use Koha::Holds to delete
holds. This is important as holds actions are started to be logged.

To reproduce:
- Apply the patch
- Run:
  $ prove t/db_dependent/Members.t
=> SUCCESS: Tests pass
- Sign off :-D

Sponsored-by: NEKLS
Signed-off-by: Hector Castro 
All tests pass successfully

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #52929|0   |1
is obsolete||

--- Comment #3 from Héctor Eduardo Castro Avalos  ---
Created attachment 53030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53030=edit
[SIGNED-OFF]Bug 16819: Unit tests for C4::Members::DelMember

The C4::Members::DelMember function actually deletes reserves, and it is
not properly tested.

To test:
- Apply the patch
- Run:
  $ prove  t/db_dependent/Members.t
=> SUCCESS: Tests pass
- Sign off

Sponsored-by: NEKLS
Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #31 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #28)
> This cannot be signed off, the patchset does not work at all, there is no
> limitation!

Still valid...
Nick, could you confirm that these patches have been tested correctly?
They do not work for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16836] Document unused parameters of SearchAuthorities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
If you query $ git grep 'SearchAuthorities'


There are some lines that use the two parameters, maybe exist more:


authorities/auth_finder.pl:  SearchAuthorities( \@marclist, \@and_or,
\@excluding, \@operator, \@value,
authorities/authorities-home.pl:#my ( $results, $total ) =
SearchAuthorities(
authorities/ysearch.pl:my ( $results, $total ) = SearchAuthorities(
\@marclist, \@and_or, \@excluding, \@operator, \@value, $startfrom *
$resultsperpage, $resultsperpage, $authtypecode, $orderby );
cataloguing/value_builder/unimarc_field_210c.pl:###TODO To rewrite in order to
use SearchAuthorities
cataloguing/value_builder/unimarc_field_210c.pl:my ($results,$total) =
SearchAuthorities( \@tags,\@and_or,
cataloguing/value_builder/unimarc_field_225a.pl:my ($results,$total) =
SearchAuthorities( \@tags,\@and_or,

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #51 from Marcel de Rooy  ---
(In reply to Colin Campbell from comment #49)
> Comment on attachment 53013 [details] [review]
> Bug 15006: Add timeout and strikes to raw_transport
> 
> This is unnecessary - The bogus 3 strikes was already removed in commit 
> 078ce11e113b172726f9ab3180e52a06334d4aab
> 
> 
> Test plan is ambiguous this routine is not called when using "telnet"
> authentication. On a raw connection session is started when a sip login is
> received. If that login fails, the session is terminated. (The login is from
> the client machine's config so it wont try again with different values) and
> sends a failed login response before shutting down. If the input is not a
> login message or a random string it does not respond or login the session
> but falls through to sip_protocol_loop and times out on the time out set
> there. I think this should be considered a bug. Its probably the reason why
> adding a timeout to that had an effect on building up sip sessions as that
> is meant to be an endless (until logout or connection drop) loop - I think
> this a bug and that if a connection is not established raw_transport should
> exit without entering sip_loop

>From testing i recall seeing that raw_transport does respond to requests; one
of the reasons that I made it more restrict in a previous patch (relaxed it
later again for minimal behavior changes).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #6 from Jonathan Druart  
---
Does the issue exist on master?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807

--- Comment #7 from Colin Campbell  ---
(In reply to Marcel de Rooy from comment #6)
> (In reply to Kyle M Hall from comment #5)
> > Passing QA provisionally, we should deal with the interaction with bug 13807
> > before anything is pushed.
> 13807->15006
> I rebased 15006 on top of this one. So it can go first..

I'm trying to add to 15006 a solution to the log in bug I identified, I'll
generated that on top of this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52894|0   |1
is obsolete||

--- Comment #95 from Jonathan Druart  
---
Created attachment 53029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53029=edit
Bug 14048: (QA followup) Default to 1 if no default rule

This patch answers Jonathan's request to simplify this patchset a bit.

It removes the need for the .sql file, as _default_rule now defaults to
a fixed value (1, which was set by the removed .sql file).
This allowed to remove the overloaded ->delete method.

The tests have been adjusted to reflect this changes, including tests for
the new 'default'-if-absent situation.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52883|0   |1
is obsolete||

--- Comment #94 from Jonathan Druart  
---
Created attachment 53028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53028=edit
Bug 14048: Use mock_preference in tests

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52876|0   |1
is obsolete||

--- Comment #93 from Jonathan Druart  
---
Created attachment 53027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53027=edit
Bug 14048: (QA folloup) C4::Context->preference should be used

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52843|0   |1
is obsolete||

--- Comment #91 from Jonathan Druart  
---
Created attachment 53025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53025=edit
Bug 14048: (QA followup) Fix typo on syspref value

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52844|0   |1
is obsolete||

--- Comment #92 from Jonathan Druart  
---
Created attachment 53026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53026=edit
Bug 14048: (followup) Use the original holding branch

This patch picks the item's holding branch *before* it gets fixed
by using the checkin library instead. This way the RefundLostOnReturnControl
syspref set to ItemHoldingBranch is respected (otherwise, as Nick explained
this behaves just like if CheckinLibrary was set)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52841|0   |1
is obsolete||

--- Comment #89 from Jonathan Druart  
---
Created attachment 53023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53023=edit
Bug 14048 [QA Followup] - Delete only the removed system preference

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52839|0   |1
is obsolete||

--- Comment #87 from Jonathan Druart  
---
Created attachment 53021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53021=edit
Bug 14048: [QA Followup]

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52842|0   |1
is obsolete||

--- Comment #90 from Jonathan Druart  
---
Created attachment 53024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53024=edit
Bug 14048: (QA followup) Update syspref name for HEA

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52838|0   |1
is obsolete||

--- Comment #86 from Jonathan Druart  
---
Created attachment 53020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53020=edit
Bug 14048: Hook new rules into C4::Circulation

This patch makes AddIssue and AddReturn use the new implementation

The behaviour should respect the specification.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52840|0   |1
is obsolete||

--- Comment #88 from Jonathan Druart  
---
Created attachment 53022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53022=edit
Bug 14048: Add syspref and atomic update

This patch introduces the changes to the sysprefs and the atomic update
that creates the new table.

It picks the syspref value for RefundLostItemFeeOnReturn and uses it to
create a default (branchcode='*') rule on the new table.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52836|0   |1
is obsolete||

--- Comment #84 from Jonathan Druart  
---
Created attachment 53018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53018=edit
Bug 14048: Unit tests

This patch introduces unit tests for the feature.
To test:
- Have all patches from this bug applied
- Run:
  $ prove -v t/db_dependent/RefundLostItemFeeRule.t
=> SUCCESS: All tests pass!

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52837|0   |1
is obsolete||

--- Comment #85 from Jonathan Druart  
---
Created attachment 53019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53019=edit
Bug 14048: Add a refund rules setting form in smart-rules

This patch introduces the CRUD UI for managing the refund lost item fee
rules on the general 'Circulation and fines rules' page.

Verify that rules can be added and changed.

Rules are correctly associated to the chosen branch (or the
general default rule).

To test:
- Apply the patch
- Open smart-rules.pl
=> SUCCESS: The text and refund rules section correctly refers to default
global rules.
   The policy can be set to Yes and No, and works as expected.
- Pick a specific branch
=> SUCCESS: The rule refers to the specific branch
=> SUCCESS: It detects the default rule is picked
=> SUCCESS: On changing the rules values are correctly retrieved if entering
   again to the page.
=> SUCCESS: The 'Use default' text is suffixed with the correct value set by
the user
   in the 'All libraries' scenario.
=> Sign off :-D

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52835|0   |1
is obsolete||

--- Comment #83 from Jonathan Druart  
---
Created attachment 53017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53017=edit
Bug 14048: Add RefundLostItemFeeRule table and classes

This patch introduces new classes for handling refund lost item fee
rules. It introduces a new table for storing this rules.

It is designed so it is possible to define a global rule, and then
branch-specific ones. The specific is prefered if available.

This behaviour is fully tested by unit tests introduced by the following
patches.

This cannot be tested on its own.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16583] Strangeness in the staff client on ubuntu 16.04 and MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583

--- Comment #4 from Ian Palko  ---
(In reply to Nicholas van Oudtshoorn from comment #3)
> Are there any plans for debian to migrate from MySQL to MariaDB? Latest
> mariadb works fine with Koha under fedora...

This is because MariaDB still is configured to accept the less-than-strict way
things have been implemented in Koha.

Since MySQL 5.1 there has been a strict mode. I would have caused the same
problems back then, but "strict mode" was not the default. It became default in
5.7.

MySQL 5.7 will work fine with Koha if it is put in the less-strict mode. It
also would work fine if we translate the less-than-strict calls into strict
calls. It also would work fine if the Koha code is cleaned-up to conform to
strict behaviour. The latter seems to me the most preferable long-term
solution, since it guarantees future compatibility without hacky fixes. That's
a lot of work to do that, however, the first two options would make for a more
short-term solution to get Koha running on MySQL 5.7.

I don't know that there are plans to move to MariaDB or officially support it.
Still, to be clear, this is a MySQL problem, it's a Koha problem. MariaDB
simply allows for our less-than-strict implementation, but if it too eventually
decides to follow MySQL's lead, we would have the same issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Colin Campbell  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #50 from Colin Campbell  ---
I'll try and tidyup the way login on raw connections handles poor connections.
The changes introduced in 13432 was a major regression for us and were no
longer using the standard SIPServer.pm as many sites are dependent on large
numbers of SIP connections. I'll see if that can all pull together in one
patch. I'm resetting the status for the moment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52941|0   |1
is obsolete||
  Attachment #52942|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  
---
Created attachment 53015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53015=edit
Bug 14968 - found shouldn't be set to null when cancelling holds

Signed-off-by: JM Broust 

Signed-off-by: Broust 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968

--- Comment #13 from Jonathan Druart  
---
Created attachment 53016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53016=edit
Bug 14968 - Provides unit test

Signed-off-by: Broust 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #49 from Colin Campbell  ---
Comment on attachment 53013
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53013
Bug 15006: Add timeout and strikes to raw_transport

This is unnecessary - The bogus 3 strikes was already removed in commit 
078ce11e113b172726f9ab3180e52a06334d4aab


Test plan is ambiguous this routine is not called when using "telnet"
authentication. On a raw connection session is started when a sip login is
received. If that login fails, the session is terminated. (The login is from
the client machine's config so it wont try again with different values) and
sends a failed login response before shutting down. If the input is not a login
message or a random string it does not respond or login the session but falls
through to sip_protocol_loop and times out on the time out set there. I think
this should be considered a bug. Its probably the reason why adding a timeout
to that had an effect on building up sip sessions as that is meant to be an
endless (until logout or connection drop) loop - I think this a bug and that if
a connection is not established raw_transport should exit without entering
sip_loop

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #52111|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #53012|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #53011|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #48 from Marcel de Rooy  ---
Kyle: Please verify your signoff. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #46 from Marcel de Rooy  ---
Created attachment 53013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53013=edit
Bug 15006: Add timeout and strikes to raw_transport

The code in raw_transport includes setting a $SIG{ALRM}, but did not
use it. For consistency, we add an alarm statement here.

Similarly, we add the "three strikes" to raw_transport just as
telnet_transport does. Note that raw_transport still responds to other
requests, but will exit if there is no valid login within three
attempts. (If we want more restrictions, add them later?)

Test plan:
[1] Start sip session with telnet on raw port 6001.
Wait until it times out (probably the default 60 seconds).
[2] Change SIPconfig.xml: set timeout=5 for service port 6001.
Restart SIP and start another telnet 6001 session.
Did it timeout within 5 seconds?
[3] Start another 6001 session. Give three wrong requests or false
login attempts. Does the connection close?

Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #47 from Marcel de Rooy  ---
Created attachment 53014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53014=edit
Bug 15006: Centralize timeout logic and allow zero client timeout

Moving timeout logic to one routine in Sip.pm (with unit test).

This further implements two suggestions from Kyle and Larry:

[1] You could use a client_timeout of 0 to specify no timeout at all.
[2] Have the client_timeout default to the timeout if not defined.

Test plan:
[1] Run t/SIP_Sip.t
[2] Test login timeout for raw and telnet.
[3] Check ACS status message for timeout value. Should match policy
timeout from institution.
[4] Test client timeout (zero and non-zero).
[5] Remove client timeout. Test fallback to service.
[6] Remove service timeout too. Test fallback to 30 at login.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 
Amended after feedback of Colin. Added a test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16818] CAS redirect broken under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818

--- Comment #1 from Fridolin SOMERS  ---
I've had this issue.
Indeed OPAC url is /cgi-bin/koha/opac-user.pl but for plack it is
/opac/opac-user.pl

Did you use the koha debian package ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16818] CAS redirect broken under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16818] CAS redirect broken under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818

Fridolin SOMERS  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16747] Fix regression in patron card creator (patron image)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #8 from Julian Maurice  ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16729] Use member-display-address-style*-includes when printing user summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #7 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.9

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16693] reserve/renewscript.pl is not used and should be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16693

--- Comment #7 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.9

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16541] Make edit and delete links styled buttons in cities administration

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16541

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #6 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.9

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16543] Make edit and delete links styled buttons in patron attribute types administration

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16543

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #5 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.9

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16127] Add discharge menu item to patron toolbar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 Depends on||8007
 CC||julian.maur...@biblibre.com

--- Comment #6 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.9


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007
[Bug 8007] Discharge management
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8007] Discharge management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Julian Maurice  changed:

   What|Removed |Added

 Blocks||16127


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127
[Bug 16127] Add discharge menu item to patron toolbar
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css and other issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #9 from Julian Maurice  ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16717] Remove hardcoded category from Holds.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16717

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #7 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.9

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155

Julian Maurice  changed:

   What|Removed |Added

 Blocks||16607


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607
[Bug 16607] Remove CPL/MPL from two unit tests
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11023] Automatic item modification by age (Was "Toggle new status for items")

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Julian Maurice  changed:

   What|Removed |Added

 Blocks||16607


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607
[Bug 16607] Remove CPL/MPL from two unit tests
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16607] Remove CPL/MPL from two unit tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Depends on||16155, 11023


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023
[Bug 11023] Automatic item modification by age (Was "Toggle new status for
items")
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155
[Bug 16155] Composite keys in TestBuilder and more
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

Julian Maurice  changed:

   What|Removed |Added

 Depends on||16155
 CC||julian.maur...@biblibre.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155
[Bug 16155] Composite keys in TestBuilder and more
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155

Julian Maurice  changed:

   What|Removed |Added

 Blocks||16500


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500
[Bug 16500] Catch two warns in TestBuilder.t with warning_like
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #45 from Marcel de Rooy  ---
(In reply to Kyle M Hall from comment #35)
> Marcel, would you be able to rebase these patches on top of bug 13807?

I did now. But in view of Colin's comments I will still have a look on the last
patch. Working on it..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #6 from Marcel de Rooy  ---
(In reply to Kyle M Hall from comment #5)
> Passing QA provisionally, we should deal with the interaction with bug 13807
> before anything is pushed.
13807->15006
I rebased 15006 on top of this one. So it can go first..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16720] DBIx ActionLogs.pm should be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16720

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #7 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.9

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #43 from Marcel de Rooy  ---
Created attachment 53011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53011=edit
Bug 15006: [COUNTERPATCH] Add timeout and strikes to raw_transport

The code in raw_transport includes setting a $SIG{ALRM}, but did not
use it. For consistency, we add an alarm statement here.

Similarly, we add the "three strikes" to raw_transport just as
telnet_transport does. Note that raw_transport still responds to other
requests, but will exit if there is no valid login within three
attempts. (If we want more restrictions, add them later?)

Test plan:
[1] Start sip session with telnet on raw port 6001.
Wait until it times out (probably the default 60 seconds).
[2] Change SIPconfig.xml: set timeout=5 for service port 6001.
Restart SIP and start another telnet 6001 session.
Did it timeout within 5 seconds?
[3] Start another 6001 session. Give three wrong requests or false
login attempts. Does the connection close?

Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #44 from Marcel de Rooy  ---
Created attachment 53012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53012=edit
Bug 15006: [COUNTERPATCH] Timeout logic in sip_protocol_loop

Instead of adding yet another client timeout, I propose to use the
policy timeout that we also communicate in send_acs_status.
Although I agree that we perhaps better move it from institution to
account/login level, this c/should be done on another report. We
may have issues with existing configurations.

In order to find a compromise between bug 13432 and the originally
proposed 15006 patch, this patch allows you to put a zero in the
policy timeout entry in the SIPconfig.

The timeout logic is moved to a Sip.pm subroutine. Will add a test :)

Test plan:
[1] Check timeout after login with policy/timeout > 0.
[2] Check timeout after login with policy/timeout = 0. (No timeout!)
[3] Check timeout after login with no policy timeout. Fallback to service.
[4] Check timeout after login with no policy and service timeout.
Should fallback to 30 seconds for both login process and after login.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #52850|0   |1
is obsolete||
  Attachment #52851|0   |1
is obsolete||
  Attachment #52852|0   |1
is obsolete||
  Attachment #52853|0   |1
is obsolete||

--- Comment #41 from Marcel de Rooy  ---
Created attachment 53009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53009=edit
Bug 15006: [QA Follow-up] Indentation for two subroutines

Remove tabs from telnet_transport and sip_protocol_loop. Correct
indentation.

Test plan:
Compare files before and after without whitespace (diff -b).
Notice only two split lines.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #42 from Marcel de Rooy  ---
Created attachment 53010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53010=edit
Bug 15006 Sip separate global from login timeouts

Timeout logic has been added to the main sip loop
However the timeout parameter was initially for the login process which
requires a short duration applying such a brief timeout to
the main sip loop causes instability in many selfcheck units

Most selfchecks have persistent connections and send a
periodic status request at intervals (approx every 5mins appears
the norm) The timeout was dropping connections by default every 30secs
which for the client appears as a very flakey network

This patch adds a separate parameter client_timeout that can be
used if you do want to force a disconnect if the client sends
no requests for a period. By not defining it you can switch off
the timeout in the main loop, I recommend this unless you
have a good reason not too. If you do want this behaviour you can
at least now set it to a more realistic value (see sample config
file)

Removed the commented out html entry in the config file, this was
dead code born of a misconception and was just a source
of confusion for users

Signed-off-by: Frederic Demians 
Signed-off-by: Jonathan Druart 
Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16692] Error "No method update!" when creating new serial issue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16692

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #6 from Julian Maurice  ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16670] CGI->param used in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16670

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #13 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.9

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #24 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.9

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #18 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.9

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #33 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.9

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10459] borrowers should have a timestamp

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

--- Comment #78 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.9

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/