date:20170913

[Koha-bugs] [Bug 17153] Logging in during a search navigates to account page instead of back to search results

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17153] Logging in during a search navigates to account page instead of back to search results

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54782|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19309] Add ReservesMaxPickUpDelay to the Circulation Matrix

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19309

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19309] New: Add ReservesMaxPickUpDelay to the Circulation Matrix

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19309

Bug ID: 19309
   Summary: Add ReservesMaxPickUpDelay to the Circulation Matrix
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jza...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Some libraries would love to have the option to specify the
ReservesMaxPickUpDelay by itemtype, rather than specify the
ReservesMaxPickUpDelay for all items via the system preference. There are times
when specific item types like popular or new items, DVD's or even Museum passes
may not want to sit on a shelf for 7 days waiting for the patron to pick it up.
Versus a non popular item that can wait for 7 days for the patron to pick the
item up. 

Moving ReservesMaxPickUpDelay to the circ matrix would allow the library to
choose the patron category and item type providing more flexibility for items
waiting to be picked up by the patron.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304

--- Comment #1 from Jonathan Druart  
---
Created attachment 67126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67126=edit
Bug 19304: Move C4::Members::GetNoticeEmailAddress to
Koha::Patron->notice_email_address

This subroutine is quite trivial and can be replaced easily with a new
method of Koha::Patron

Test plan:
Overdue notices and shelf sharing must be send the to an email address,
according to the value of the pref AutoEmailPrimaryAddress

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to the code namespace

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

--- Comment #3 from Jonathan Druart  
---
Created attachment 67121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67121=edit
Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - Remove the subroutine

At this point the subroutine is not longer in use, we can remove it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to the code namespace

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

--- Comment #2 from Jonathan Druart  
---
Created attachment 67120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67120=edit
Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed

This patchset move The OPACItemHoldsAllowed logic
(issuingrules.opacitemholds) to a new class method of
Koha::IssuingRules: get_opacitemholds_policy

On the way, this patch will certainly fix the same problem as bug
19298 with onshelfholds.

Test plan:
Make sure the opacitemholds policy is correct when placing a hold at the
OPAC or the staff interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to the code namespace

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

--- Comment #1 from Jonathan Druart  
---
Created attachment 67119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67119=edit
Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - tests

This patch proves that we will not introduce trivial regression.
With the same tests, we will execute the existing code and the new code.

Test plan:
With only this patch applied, prove t/db_dependent/Koha/IssuingRules.t
should return green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19310] Warning on UpdateTotalIssuesOnCirc should be revisited

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19310

Nick Clemens  changed:

   What|Removed |Added

 Depends on||6557


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557
[Bug 6557] biblioitems.totalissues unused
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6557] biblioitems.totalissues unused

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557

Nick Clemens  changed:

   What|Removed |Added

 Blocks||19310


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19310
[Bug 19310] Warning on UpdateTotalIssuesOnCirc should be revisited
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19310] New: Warning on UpdateTotalIssuesOnCirc should be revisited

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19310

Bug ID: 19310
   Summary: Warning on UpdateTotalIssuesOnCirc should be revisited
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

It seems this pref was added...temporarily? It has a large warning:

 (WARNING! This increases server load significantly; if performance is a
concern, use the update_totalissues.pl cron job to update the total issues
count).

The bug report seems to indicate use of DOM of GRS1 should make this
unnecessary.

With plack as well I wonder if we need this warning which essentially ensures
no one will enable this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19299] Replace C4::Reserves::GetReservesForBranch with Koha::Holds-> waiting

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19299] Replace C4::Reserves::GetReservesForBranch with Koha::Holds-> waiting

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299

--- Comment #1 from Jonathan Druart  
---
Created attachment 67117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67117=edit
Bug 19299: Replace C4::Reserves::GetReservesForBranch with Koha::Holds->waiting

GetReservesForBranch simply returns the waiting holds, for a specific
branch of not. This can easily be replaced with a call to
Koha::Holds->waiting

To avoid any regressions, I reuse the exact conditions (priority = 0),
but I do not think it is useful.

Test plan:
Make sure the holds information are correctly displayed on the waiting
holds screen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the code namespace

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to the code namespace

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the code namespace

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

--- Comment #1 from Jonathan Druart  
---
Created attachment 67122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67122=edit
Bug 19301: Move C4::Reserves::OnShelfHoldsAllowed to get_onshelfholds_policy

Following the pattern introduced by bug 19300, we are going to move the
OnShelfHoldsAllowed logic to Koha::IssuingRules->get_onshelfholds_policy

Test plan:
Make sure the onshelfholds policy is correct when placing a hold

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the code namespace

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

--- Comment #2 from Jonathan Druart  
---
Created attachment 67123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67123=edit
Bug 19301: Remove C4::Reserves::OnShelfHoldsAllowed

At this point the subroutine is not used anymore

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19299] Replace C4::Reserves::GetReservesForBranch with Koha::Holds-> waiting

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #67117|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 67118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67118=edit
Bug 19299: Replace C4::Reserves::GetReservesForBranch with Koha::Holds->waiting

GetReservesForBranch simply returns the waiting holds, for a specific
branch of not. This can easily be replaced with a call to
Koha::Holds->waiting

To avoid any regressions, I reuse the exact conditions (priority = 0),
but I do not think it is useful.

Test plan:
Make sure the holds information are correctly displayed on the waiting
holds screen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19303] Move C4::Members::GetFirstValidEmailAddress to Koha::Patron-> first_valid_email_address

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303

--- Comment #1 from Jonathan Druart  
---
Created attachment 67125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67125=edit
Bug 19303 - Move C4::Members::GetFirstValidEmailAddress to
Koha::Patron->first_valid_email_address

This new Koha::Patron->first_valid_email_address already exists, it
should be called directly

Test plan:
With a logged in user who have an email address defined, send a basket.
The email should be marked sent by this email address

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

--- Comment #1 from Jonathan Druart  
---
Created attachment 67116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67116=edit
Bug 19298: Placing a hold from a list at the OPAC should respect issuing rules

The issuing rule retrieve to know if a hold can be placed on a record of
a list is not correct.

Test plan:
0/ With item-level_itypes = item level
1/ Define a item.itype=BK and biblioitems.itemtype=CF
2/ Create a default rule to allow on shelf holds
3/ Create a specific rule for CF with on shelf holds="If any
unavailable"
4/ Add this bibliographic record to a list and view the list
=> Without this patch you will not see "Place hold"
=> With this patch applied you will see the "Place hold" button,
respecting the correct issuing rule

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302

--- Comment #1 from Jonathan Druart  
---
Created attachment 67124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67124=edit
Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest

Almost everywhere we call IsAvailableForItemLevelRequest we already have
a Koha::Patron and Koha::Item object. It makes sense to use them to
avoid a refetch

Test plan:
It would be good to test this patch on top of 19300 and 19301 and make
sure everything works as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to the code namespace

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19302


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302
[Bug 19302] Pass objects to IsAvailableForItemLevelRequest
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the code namespace

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19302


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302
[Bug 19302] Pass objects to IsAvailableForItemLevelRequest
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||19300, 19301


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300
[Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to the code namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301
[Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the code namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the code namespace

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||19298


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298
[Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19301


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301
[Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the code namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19303] Move C4::Members::GetFirstValidEmailAddress to Koha::Patron-> first_valid_email_address

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19297] Standardize "can place hold" calculations

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19297

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||19300, 19301


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300
[Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to the code namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301
[Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the code namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19311] New: E-mail staff about items on a watch list

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19311

Bug ID: 19311
   Summary: E-mail staff about items on a watch list
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

I would love it if we could create a watch list for staff members.  For
example, I need to know when certain electronics are overdue so I can have them
deactivated.

I would see the following with this feature:
* Feature would be available to users by patron id # or patron category
* Tab would appear in user account
* User would be able to list item by barcode or item number, and could be
notified by e-mail when an item's status changes to a particular value.
* Option of specifying how many days a status must be at a particular value
before sending a notification (not a notification delay).
* Option to create notification groups (group of items) that could be watched
by a single watch rule.
* Option of sharing watch group with specific users by combinations of patron
id, card number, branch, and patron category.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15428] Different timeout preference for opac and intranet

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428

--- Comment #1 from Lisette  ---
This seems like it could be a huge privacy issue on Catalog computers in public
libraries. 
It would be nice if we could set the staff and OPAC to different timeouts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Dilan Johnpullé  changed:

   What|Removed |Added

  Attachment #67070|0   |1
is obsolete||

--- Comment #2 from Dilan Johnpullé  ---
Created attachment 67127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67127=edit
Bug 19293: Prevent error when receiving shipment with order with deleted biblio

Patch applies and works as described when test plan is followed.

Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19293] Internal server error when receiving shipment with order with deleted biblio

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Dilan Johnpullé  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the code namespace

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19297


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19297
[Bug 19297] Standardize "can place hold" calculations
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to the code namespace

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19297


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19297
[Bug 19297] Standardize "can place hold" calculations
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15428] Different timeout preference for opac and intranet

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19165] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165

Christophe Croullebois  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #6 from Christophe Croullebois 
 ---
Hello Alex,
ok I understand, in fact this patch is the same than Bug 18468, and in this one
people asked to create a new bug report for 16.11.x.
I have done that and to test you have to use a branch 16.11.x to apply it not
the master.
Normally it must be ok on a branch 16.11.x.
Thx again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19165] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19165

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #5 from Alex Buckley  ---
Sorry Christophe unfortunately it still cannot apply correctly on up to date
master branch.

Bug 19165 - When adding from a staged file order discounts are not passed into
C4::Acquisitions::populate_order_with_prices

67078 - new rebased patch

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19165 - When adding from a staged file order discounts are not
passed into C4::Acquisitions::populate_order_with_prices
fatal: sha1 information is lacking or useless (acqui/addorderiso2709.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 19165 - When adding from a staged file order discounts
are not passed into C4::Acquisitions::populate_order_with_prices
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/new-rebased-patch-iCks9Z.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19296] Tax is being subtracted from orders when vendor price does not include gst and ordering from a file

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19296

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19296] Tax is being subtracted from orders when vendor price does not include gst and ordering from a file

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19296

--- Comment #1 from Nick Clemens  ---
Created attachment 67110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67110=edit
Bug 19296 - Allow all tax processing to happen in
C4::Acquisition::populate_order_with_prices

To test:
 1 - Create an order file that includes prices and items
(MarcFieldsToOrder)
 2 - Stage the file
 3 - Set vendor to 'prices exclude tax'
 4 - Open a basket and add from the file
 5 - View the items in the basket
 6 - Prices are reduced by the tax rate and tax is calculated to return
prices to the value in the file
 7 - Apply patch
 8 - Repeat steps 1-6
 9 - Prices should now calculate correctly
10 - Repeat with 'MarcItemFieldsToOrder'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19306] Adding hooks to the plugin system

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19306

--- Comment #1 from Stefan Berndtsson  ---
Created attachment 67108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67108=edit
Bug in run_matching when plugins are not available

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19306] Adding hooks to the plugin system

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19306

--- Comment #2 from Stefan Berndtsson  ---
Created attachment 67109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67109=edit
Adding hooks to the plugin system

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19296] Tax is being subtracted from orders when vendor price does not include gst and ordering from a file

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19296

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19308] New: Barcode

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19308

Bug ID: 19308
   Summary: Barcode
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: PC
OS: Windows
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: wanjuhi.kah...@gmail.com
QA Contact: testo...@bugs.koha-community.org

I have been trying to print out barcodes but some are going out of the labels,
i have tried aligning them but no change, i am using code 39, and printing on a
laser printer, using Avery labels 7651, 65 labels per sheet, size 38.1x21.2,

Please help.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

David Bourgault  changed:

   What|Removed |Added

  Attachment #59446|0   |1
is obsolete||
  Attachment #64802|0   |1
is obsolete||
  Attachment #64824|0   |1
is obsolete||

--- Comment #53 from David Bourgault  ---
Created attachment 67115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67115=edit
Bug 12532 - Send emails to guarantee and guarantor

Adds setting "RedirectGuaranteeEmail". When setting is enabled,
emails to patron with a guarantor will be send to both guarantor
and guarantee.

Does this by amending the C4::Members::GetNoticeEmail() sub. It does
not affect values in the message_queue table.

Test plan:

Before applying
1) Select patron with guarantor
2) Enable checkout emails
3) Checkout item. Email will be sent only to guarantee
4) Apply patch
5) Run updatedatabase.pl
6) Enable 'RedirectGuaranteeEmail' in system preferences
7) Go through step 1) to 3). Email should now be sent to both.
8) Run t/db_dependant/Members.t

Obsoletes all previous patches, which failed to apply/

Sponsored by: Ville de Victoriaville

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

David Bourgault  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19307] t/db_dependent/Circulation/ NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307

Nick Clemens  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|n...@bywatersolutions.com
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19198] Renewal as issue causes too many error

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198

--- Comment #9 from Nick Clemens  ---
Created attachment 67113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67113=edit
Bug 19198 (QA Followup) Fix typo in conditions

'&' should be '&&'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19198] Renewal as issue causes too many error

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198

--- Comment #8 from Nick Clemens  ---
Created attachment 67112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67112=edit
Bug 19198 - Renewal as issue causes too many error

This patch moves some code and prevents checking for too many checkouts
when performing a renewal via checkout

To test:
1 - Set a rule to limit checkouts to a single issue, allowing renewal
2 - Issue an item to a patron
3 - Issue the same item
4 - In staff client you get a confirm to renew and a notice of Too Many
checkouts, don't confirm
5 - VIA Sip - you get a renewal response, but in logs the renewal fails
as a 'too
6 - Apply patch
7 - Via staff client you shoudl get renewal confirm with no too many
error
8 - SIP checkout should renew

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19198] Renewal as issue causes too many error

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198

Nick Clemens  changed:

   What|Removed |Added

  Attachment #66670|0   |1
is obsolete||
  Attachment #66671|0   |1
is obsolete||

--- Comment #7 from Nick Clemens  ---
Created attachment 67111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67111=edit
Bug 19198 - Unit tests

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19198] Renewal as issue causes too many error

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19307] New: t/db_dependent/Circulation/ NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307

Bug ID: 19307
   Summary: t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
fails if AllowFineOverride set to allow
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

We count on getting an issuing impossible, but if this pref enabled we get a
needs confirmation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19307] t/db_dependent/Circulation/ NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19307] t/db_dependent/Circulation/ NoIssuesChargeGuarantees.t fails if AllowFineOverride set to allow

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19307

--- Comment #1 from Nick Clemens  ---
Created attachment 67114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67114=edit
Bug 19307 - Mock the AllowFineOverride preference to ensure expected result

To test:
 1 - Set 'AllowFineOverride' to allow
 2 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
 3 - 1 test fails
 4 - Apply patch
 5 - prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
 6 - All tests pass
 7 - Set 'AllowFineOverride' to 'Don't allow'
 8 - Tests should still pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19306] New: Adding hooks to the plugin system

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19306

Bug ID: 19306
   Summary: Adding hooks to the plugin system
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: stefan.berndts...@ub.gu.se
QA Contact: testo...@bugs.koha-community.org

We've been working on adding hook functionality to the existing plugin system.

This is very much proof-of-concept code at the moment, but here is how it
works.

1. Somewhere in the code you add a hook-call with a name for that hook, and
pass in some data relevant to that hook.
2. Each plugin with a method matching the hook name is called in sequence, with
the data as input and returning data of similar form, which is then passed on
to the next matching plugin.
3. The end result is returned back from the hook-call, is put back in place,
and code execution is resumed.

The PoC code adds a Koha::Plugins::Handler->run_matching() method that looks up
the relevant loaded plugins (using GetPlugins) and calls
Koha::Plugins::Handler->run() on each of them.

If plugins are not enabled, or if there is no plugin matching the hook, the
input data is returned back, resulting in unaffected operation.

One hook is added in Koha::SearchEngine::Elasticsearch::QueryBuilder.pm, in
build_query_compat with the name "build_query_before", which is simply run
before the query parsing takes place.

A very simple example plugin is available at:
https://github.com/ub-digit/koha-plugin-build-query-example/releases

This plugin edits a query beginning with "Provider:" to do "publisher:"
instead. A simple example that when using Elasticsearch makes publisher links
in the bibliographic detail view clickable. The current XSLT uses the Zebra
based links, that result in an unusable search. This is not meant to be the
solution to the Zebra/Elasticsearch conflict in the XSLT, but it's a simple
demonstration of the hook feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19306] Adding hooks to the plugin system

2017-09-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19306

Stefan Berndtsson  changed:

   What|Removed |Added

  Attachment #67108|0   |1
is obsolete||
  Attachment #67108|1   |0
   is patch||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

58 matches

Mail list logo