[Koha-bugs] [Bug 19786] Move template JavaScript to the footer: Authorities, part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19786] Move template JavaScript to the footer: Authorities, part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71820|0   |1
is obsolete||

--- Comment #7 from Katrin Fischer  ---
Created attachment 72287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72287=edit
Bug 19786: Move template JavaScript to the footer: Authorities, part 2

This patch modifies the staff client patron lists templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template.

I've made one change to the JavaScript in addition to moving it: I've
made it so that the blank window which pops up briefly in this process
is 100px x 100px instead of full screen.

- Cataloging -> Add or edit bibliographic record in a framework which
  has authorities linked to a tag
  -> Click authorities plugin link
 -> Create new authority button
 -> Autocomplete on text inputs (except "Search all headings")
 -> Search
-> Select authority record ("choose")
   -> Click authorities plugin link again
  -> Clear field

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19786] Move template JavaScript to the footer: Authorities, part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72212|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 72288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72288=edit
Bug 19786: (follow-up) Correct js include path, popup window size

This follow-up adds the required KOHA_VERSION variable to two templates
where it was missing.

This patch also adds a 'window_size' parameter to a popup window
function so that self-closing windows like blinddetail-biblio-search.pl
can appear small and others at a reasonable size.

To test, apply the patch and clear your browser cache if
necessary.

- Confirm that the QA tools do not complain about missing KOHA_VERSION
  in auth_finder.tt and searchresultlist_auth.tt.

- Open a bibliographic record for editing in the basic editor using a
  framework in which a field is linked to authorities.
- Trigger the authority selection window for that field.
- Click the "Clear field" button at the top of the authority search
  pop-up window. Another smaller popup window should briefly appear, and
  then both windows should close.
- Trigger the authority selection window again.
- Click the "Create new authority" button. A new window should appear
  with the MARC authority editor. The window should be a usable size.

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72250|0   |1
is obsolete||

--- Comment #25 from Katrin Fischer  ---
Created attachment 72286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72286=edit
Bug 20173: Fix favicon.ico path in installer

This patch corrects the favicon.ico path for the installer.

On git installs, it used to point to ./koha-tmpl/favicon.ico,
and on regular installs, it probably just didn't work.

https://bugs.koha-community.org/show_bug.cgi?id=20173
Signed-off-by: Fridolin Somers 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72249|0   |1
is obsolete||

--- Comment #24 from Katrin Fischer  ---
Created attachment 72285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72285=edit
Bug 20173: Clean up koha-tmpl directory

This patch removes some HTML and ico files that are no longer
used in Koha.

Signed-off-by: Mark Tompsett 
Signed-off-by: Fridolin Somers 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

--- Comment #23 from Katrin Fischer  ---
Favicons still display, can find no references to the files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #33 from Katrin Fischer  ---
Can't wait to have this, but currently blocked by FAILED QA on bug 18790 -
Kyle, can you put this in our queue again once the other is in? Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20309] Machine generated 'Invoice or Receipt Number' against every fine receipt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20309

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||katrin.fisc...@bsz-bw.de
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
Hi Sujan, I thnk bug 19036 is a duplicate.

*** This bug has been marked as a duplicate of bug 19036 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19036] Number payment receipts / payment slips

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Katrin Fischer  changed:

   What|Removed |Added

 CC||sujan@gmail.com

--- Comment #1 from Katrin Fischer  ---
*** Bug 20309 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19360] Give items URL a link text

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360

--- Comment #24 from Katrin Fischer  ---
Hi Alex, welcome back!

> If so, couldn't I simply remove the $k subfield and store this data value
> (with a data delimiter) in the $u subfield, rather than adding a brand new
> field url|text?

Yes, I think that was the thought, also to keep the last subfield $k free for
now.

> 
> I am not familiar with Koha plugins so I've had a look at the kitchen sink
> example plugin and it looks like I'd need to make a tool plugin and it would
> need to be accessed via a link in the cataloguing/addbiblio.tt file.

Sorry, need to clarify. There are different kinds of plugins in Koha :) I was
thinking of a value builder that you can link to the subfield via the framework
configuration (look for plugin as an option there). It's older and a bit
simpler than the new plugins. We use one for dateacccessioned in items, and
some others are present in the record, as the helpers for the 00x fields or the
authority linker.

> The .tt file of this plugin will contain two inputs (url and link text
> inputs) which the backend logic concatenates and separates with a delimiter
> before this data value is stored in the 952$u database field of
> marc_subfield_structure database table.

That was the idea - but my initial suggestion of | is not good I think. If you
mark $u repeatable in the frameworks, Koha uses | for sorting multiples. Might
have to think about something else, that is no tin a URL.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20309] New: Machine generated 'Invoice or Receipt Number' against every fine receipt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20309

Bug ID: 20309
   Summary: Machine generated 'Invoice or Receipt Number'  against
every fine receipt
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: sujan@gmail.com
QA Contact: testo...@bugs.koha-community.org

Now we can very easy to manage 'Fines and Fees' system in Koha ILS. But at
present we could not able to set automatically  machine generated 'Invoice or
Receipt Number'  against every fine receipt.
It also require to count Total 'Amount' on the basis of total 'Quantity' for
the money receipt  in creation of 'manual invoice receipt' For Reprography
services.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20275] Add comment to let users know they can define multiple plugindirs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20275

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||mtomp...@hotmail.com

--- Comment #2 from M. Tompsett  ---
Shouldn't this also modify debian/templates/koha-conf.xml.in?

Though, we also probably have a koha documentation bug report on hand:
https://koha-community.org/manual/18.05/en/html/14_plugins.html?highlight=plugin
Strange no mention of this parameter in the manual.
References on the wiki don't mention it, but the kitchen sink plug readme.md
seems to mention pluginsdir in passing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18820] The different parts in the main don't automatically adjust with the available space.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820

Dilan Johnpullé  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18820] The different parts in the main don't automatically adjust with the available space.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820

Dilan Johnpullé  changed:

   What|Removed |Added

  Attachment #72098|0   |1
is obsolete||

--- Comment #19 from Dilan Johnpullé  ---
Created attachment 72284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72284=edit
Bug 18820: Main block size now adjust to OpacNavRight like it would for
opacuserlogin

Test plans  :
- "beforepatch.png" shows the result you get when OpacNavRight and opacnav are
set to false.
- "opacuserlogin=f_opacnav=f.png" shows the result with the patch and
OpacNavRight and opacnav set to false
- "opacuserlogin=t_opacnav=f.png" shows the result with the patch and
OpacNavRight set to true and opacnav set to false

Applied patch, can confirm it functions as expected.
Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20264] Syspref checkdigit is no longer in used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264

Dilan Johnpullé  changed:

   What|Removed |Added

 CC||di...@calyx.net.au

--- Comment #3 from Dilan Johnpullé  ---
Patch failed to apply with the following error message:

vagrant@kohadevbox:kohaclone(master)$ git bz apply -s 20264
Bug 20264 - Syspref checkdigit is no longer in used

72049 - Bug 20264: Remove syspref checkdigit

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 20264: Remove syspref checkdigit
fatal: sha1 information is lacking or useless (C4/Members.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 20264: Remove syspref checkdigit
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-20264-Remove-syspref-checkdigit-H8JTSx.patch
vagrant@kohadevbox:kohaclone(master|AM 1/1)$

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19360] Give items URL a link text

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360

Alex Buckley  changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

--- Comment #23 from Alex Buckley  ---
Thanks for the comments. Sorry I have been travelling for the last few months
and so haven't worked on this for a little while, however I am back into it now
and am keen to push it forward. 

So Katrin and Josef to clarify would you like a single database field holding
both the uri and link text with a delimiter? 

Then when the user loads the item page the value of this field is split at the
delimiter and the URL is set as the form action and the link text is displayed?

If so, couldn't I simply remove the $k subfield and store this data value (with
a data delimiter) in the $u subfield, rather than adding a brand new field
url|text?

I am not familiar with Koha plugins so I've had a look at the kitchen sink
example plugin and it looks like I'd need to make a tool plugin and it would
need to be accessed via a link in the cataloguing/addbiblio.tt file.

The .tt file of this plugin will contain two inputs (url and link text inputs)
which the backend logic concatenates and separates with a delimiter before this
data value is stored in the 952$u database field of marc_subfield_structure
database table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547

Dilan Johnpullé  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547

Dilan Johnpullé  changed:

   What|Removed |Added

  Attachment #68851|0   |1
is obsolete||

--- Comment #7 from Dilan Johnpullé  ---
Created attachment 72283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72283=edit
Bug 19547: Deal with --create-db missing debian.cnf issue

Followed test plan. Patch functions as described and both commands execute.
Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20308] New: "Login with Google" not Visible on Main OPAC when using OAuth2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20308

Bug ID: 20308
   Summary: "Login with Google" not Visible on Main OPAC when
using OAuth2
 Change sponsored?: ---
   Product: Koha
   Version: 17.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: rcmcdonal...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Simple:

On the main OPAC site (when unauthenticated), there should be a blue button
"Login with Google" easily available to the user.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153

--- Comment #19 from Katrin Fischer  ---
Thx for commenting - it's good. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153

--- Comment #18 from Hugh Rundle  ---
Great, ok I'll wait a bit to see if Marc or Nick can shed any light and if they
think further testing is needed we might be able to test at Brimbank.

(In reply to Katrin Fischer from comment #17)
> It looks like Christopher moved this into 'in Discussion' pointing out some
> issues he found - moving to failed QA to get some feedback from the
> developer.
> 
> It could help if you could test the patch and confirm good/bad behaviour
> looking at the test plans. 
> 
> I also notice the bug was not assigned, so might have slipped through the
> saved searches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|In Discussion   |Failed QA
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

--- Comment #17 from Katrin Fischer  ---
It looks like Christopher moved this into 'in Discussion' pointing out some
issues he found - moving to failed QA to get some feedback from the developer.

It could help if you could test the patch and confirm good/bad behaviour
looking at the test plans. 

I also notice the bug was not assigned, so might have slipped through the saved
searches.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18790] Add ability to void payments

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #32 from Katrin Fischer  ---
Comment on attachment 72035
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72035
Bug 18790: Add ability to void payments

Review of attachment 72035:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18790=72035)
-

Was looking for the line - found some other small stuff instead (sorry!)

::: installer/data/mysql/account_offset_types.sql
@@ +9,5 @@
>  ('Dropbox'),
>  ('Rental Fee'),
>  ('Fine Update'),
> +('Fine'),
> +('Void Payment');

Capitalization... but that's already a little late here.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
@@ +60,4 @@
>[% CASE 'Pay00' %]Payment, thanks (cash via SIP2)
>[% CASE 'Pay01' %]Payment, thanks (VISA via SIP2)
>[% CASE 'Pay02' %]Payment, thanks (credit card via SIP2)
> +  [% CASE 'VOID' %]Payment, Voided

Capitalization - not too late here :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153

Hugh Rundle  changed:

   What|Removed |Added

 CC||hu...@brimbank.vic.gov.au

--- Comment #16 from Hugh Rundle  ---
This bug has been listed since 2014 and a patch provided 12 months ago. It is a
really big problem for multi-branch libraries and as others have noted, the
workarounds are cumbersome.

What needs to happen to close this off? 

I note the issue raised by Christopher but it seems unclear whether this is
caused by the patch or is simply revealing a different bug. My own preference
would be to note it as a separate bug and push this patch, which will do the
job in most scenarios. Not getting the right info in a popup telling staff who
the hold is for is a minor problem compared to not getting any indication at
all that an item has an allocated hold on it and needs to be transferred.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18790] Add ability to void payments

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #31 from Katrin Fischer  ---
Comment on attachment 72036
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72036
Bug 18790: Add logging for voided payments

Review of attachment 72036:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18790=72036)
-

::: Koha/Account/Line.pm
@@ +18,4 @@
>  use Modern::Perl;
>  
>  use Carp;
> +use Data::Dumper;

Left over from debugging?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17505] Add routes for messaging preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact||tomasco...@gmail.com
Summary|REST API: Add route for |Add routes for messaging
   |messaging preferences   |preferences
 Status|Signed Off  |In Discussion
   Keywords||needs_rfc

--- Comment #16 from Tomás Cohen Arazi  ---
Hi Jiri, all looks good. We agreed new endpoints need to be proposed in the
form of an RFC and voted on a dev meeting. This is mostly because (usually) the
attribute names might require some tweaks. Could you please add an RFC [1],
check the agreed coding guidelines for the REST api [2] and add the RFC for
consideration on a dev meeting [3]? It should be (probably straight forward,
but a needed step). I will help with the process if needed!

Thanks for your contributions and looking forward to communicate with you about
your work on the REST api!

[1] https://wiki.koha-community.org/wiki/REST_api_RFCs
[2] https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API
[3] https://wiki.koha-community.org/wiki/Next_IRC_meetings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123

--- Comment #25 from Katrin Fischer  ---
+1 for asking questions and documentation - we have too many things hidden away
already.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19797] Subscriptions to email notifications for new serial issues are broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #9 from Chris Cormack  ---
Pushed to 16.11.x will be in 16.11.17

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17956] Provide additional functionality in the onboarding tool through configuring z-targets, and providing information on setting up SIP and LDAP services

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17956

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #21 from Katrin Fischer  ---
I think I agree with Marcel. I it's only textual information, we should
probably provide it in another way as we are not good at keeping multiple
things maintained. There is also the question, what to mention and what not -
For example this only mentions z-targets, but not SRU... LDAP, but not
Shibboleth, CAS...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20306] Negative values break funds edit

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20306

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Tomás Cohen Arazi  ---
I'm closing this bug, because I belive there was a problem on the data, due to
tests not cleaning up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20307] New: Language overlay for authorized values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

Bug ID: 20307
   Summary: Language overlay for authorized values
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 14100


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100
[Bug 14100] Add base to make item types, branch names, sysprefs values and
authorised values translatable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14100] Add base to make item types, branch names, sysprefs values and authorised values translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20307


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307
[Bug 20307] Language overlay for authorized values
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16690] Installing DB on remote server fails without GRANT ALL, because wrong permissions are checked

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690

M. Tompsett  changed:

   What|Removed |Added

Summary|Installing DB on remote |Installing DB on remote
   |server fails without *.*|server fails without GRANT
   |permissions |ALL, because wrong
   ||permissions are checked

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123

--- Comment #24 from Jonathan Druart  
---
I was asking questions and clarifications about how it could be setup on a
server (I suggested a wiki page). I think it is good to ask questions before
things get integrated. Maybe the authors of the patches did not think about
everything.

I did not ask anything else.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20306] New: Negative values break funds edit

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20306

Bug ID: 20306
   Summary: Negative values break funds edit
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

To reproduce:
- Have a budget and a fund on it.
- Spend more than what's in the fund
- Confirm you allow to surpass the funds max.
- Go to the budgets/funds list
=> SUCCESS: A negative value shows
- Choose (on the fund's dropdown) to edit the fund
=> FAIL: Kaboom!

Template process failed: undef error - round() overflow. Try smaller precision
or use Math::BigFloat at /home/vagrant/kohaclone/Koha/Number/Price.pm line 64.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123

--- Comment #23 from M. Tompsett  ---
(In reply to Tomás Cohen Arazi from comment #19)
> Having a new multi-timezone-aware cron tool might be out of the scope of
> this bug, LOL.

I agree. That is out of scope. +1 for the idea, but let's try to keep scopes
small and easy to measure and test.


> It's an interesting idea, tough. I've been looking at ways of using Minion
> for the tasks BTW.

Links?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123

M. Tompsett  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #22 from M. Tompsett  ---
Please add something, even commented into koha-conf and koha-conf.in template
files for the  tag.

"America/Toronto" generated noise on an upgrade. Perhaps more clarity on what
needs to go in there?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #34 from Kyle M Hall  ---
Created attachment 72282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72282=edit
Bug 18786: Remove use of Koha::Patron::Images

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19617] Allow 'writeoff of selected'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617

Martha Fuerst  changed:

   What|Removed |Added

 CC||mfue...@hmcpl.org

--- Comment #2 from Martha Fuerst  ---
Yes please!

This would be very useful when working with patrons with lots of fines, etc.
when you don't want to writeoff all of their outstanding fines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20302] Allow translating Delete button in Patron batch mod tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20302

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20296] Untranslatable "All" in patrons table filter

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20296

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #6 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20301] Allow translating "View" in manage MARC import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20301

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20234] Make maintenance scripts use koha-zebra instead of koha-*-zebra

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20234

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #7 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20301] Allow translating "View" in manage MARC import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20301

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 18.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20295] Allow translating link title in ILL module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20295

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20218] Tracklinks fails when URL has special characters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20218

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #7 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20141] Untranslatable string in Transport cost matrix

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20141

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20139] Improve MARC mapping translatable strings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20139

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19610] Make koha-common.logrotate use copytruncate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19610

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #8 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20303] Receive order fails if no "authorised_by" value

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20303

Jonathan Druart  changed:

   What|Removed |Added

Version|17.11   |master
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

--- Comment #3 from Jonathan Druart  
---
Barry, do you have more info about how it happens?

I guess it can happen on a very old DB (before aqbaskets.authorisedby) or if
the librarian record has been deleted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20303] Receive order fails if no "authorised_by" value

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20303

--- Comment #2 from Jonathan Druart  
---
Created attachment 72281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72281=edit
Bug 20303: Do not explode when receiving an order if authorisedby not set

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20303] Receive order fails if no "authorised_by" value

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20303

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20303] Receive order fails if no "authorised_by" value

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20303

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||17829

--- Comment #1 from Jonathan Druart  
---
I guess this is caused by bug 17829.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829
[Bug 17829] Move GetMember to Koha::Patron
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20303


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20303
[Bug 20303] Receive order fails if no "authorised_by" value
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deleted/old tables with their "alive" cousins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #33 from Katrin Fischer  ---
As the payment types are ok as key value pairs and you wouldn't need more, I
think having them as an authorised value is ok. But we should start to make AV
translatable one by one (or all at once - wouldn't mind that!). It is the next
logical step, especially for values exposed in the OPAC like location and
collection.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18790] Add ability to void payments

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #30 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #29)
> *
> +use Koha::Patron::Images;
> 
> line readded by these patches

I'm not seeing this line in any of the patches. Can you point me to it?

> 
> * Koha::Account::Line->void must use a transaction to make sure the log will
> be done only if the offset has been created successfully.

Good idea!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20286] Subscribing to a search via rss goes to an empty page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20286

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #7 from Jonathan Druart  
---
Can anyone test these patches with BakerTaylor* prefs set correctly?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20286] Subscribing to a search via rss goes to an empty page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20286

--- Comment #6 from Jonathan Druart  
---
Created attachment 72280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72280=edit
Bug 20286: Fix filter for BakerTaylor* prefs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged, withdrawn, or not-for-loan items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged, withdrawn, or not-for-loan items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC|marjorie.barry-vila@collect |
   |o.ca|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

Joel Sasse  changed:

   What|Removed |Added

 CC||jsa...@plumcreeklibrary.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #32 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #31)
> Cannot we try to be exhaustive and list all (or at least several to start)
> payment types in a separate table? We could have a FK at DB level and make
> them translatable.

These are not hard coded payment types, they are meant to be added by the
librarians, just as we already use a AV category for librarian defined fee
types.

Really, what we need is for authorised values to be translatable, but that's a
bit outside the scope of this bug ; )

If you would like me to add an example payment type to the sample data, I'd be
happy to do so!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20286] Subscribing to a search via rss goes to an empty page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20286

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #5 from Jonathan Druart  
---
https://[% BakerTaylorBookstoreURL |uri %]

This is wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #31 from Jonathan Druart  
---
Cannot we try to be exhaustive and list all (or at least several to start)
payment types in a separate table? We could have a FK at DB level and make them
translatable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Passed QA   |Signed Off

--- Comment #30 from Jonathan Druart  
---
We are going to add yet another AV that cannot be translatable.
Moreover this patch set does not create some default ones for existing or new
installations.

I'd like to get more QA pov on that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19524] Share patron lists between staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

Indranil Das Gupta  changed:

   What|Removed |Added

 CC||indr...@l2c2.co.in

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18790] Add ability to void payments

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #29 from Jonathan Druart  
---
*
+use Koha::Patron::Images;

line readded by these patches

* Koha::Account::Line->void must use a transaction to make sure the log will be
done only if the offset has been created successfully.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18790] Add ability to void payments

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #28 from Jonathan Druart  
---
Please add POD to the new method.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19797] Subscriptions to email notifications for new serial issues are broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #8 from Jonathan Druart  
---
Not for master, sending to RMaints queue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20302] Allow translating Delete button in Patron batch mod tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20302

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |String patch
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Trivial, skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20302] Allow translating Delete button in Patron batch mod tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20302

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #72254|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 72279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72279=edit
Bug 20302: Allow translating Delete button in Patron batch mod tool

There is an untranslatable Delete-button in the patron batch modification
tool. Allow translating it.

Test plan:

1) Go to Home -> Tools -> Batch patron modification, put a patron's
   card number in the box, and click on Continue
2) At the bottom of the screen there is an drop-down entry for
   Attribute, click on the "New" at the nd of that line
3) There should now be another Attribute -line, with "Delete" -link
   at the end of that line
4) Apply patch, install a language
5) Repeat 1-3 in that language, the Delete-link should be shown in
   the correct language, if the msgid "Delete" was translated
   in xx-YY-staff-prog.po

Signed-off-by: Pasi Kallinen 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20301] Allow translating "View" in manage MARC import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20301

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Patch complexity|--- |String patch

--- Comment #3 from Jonathan Druart  
---
Trivial, skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20301] Allow translating "View" in manage MARC import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20301

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20301] Allow translating "View" in manage MARC import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20301

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #72251|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 72278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72278=edit
Bug 20301: Allow translating "View" in manage MARC import

When looking at the table showing the staged MARC records, the "View"
text in the Diff-column is not translatable. Make it so.

Test plan:

1) Go to Home -> Tools -> Stage MARC records for import
2) Select eg. t/db_dependent/www/data/marc21record.mrc and upload the file
3) Click on Stage for import
   -> Manage staged records
   -> Import this batch into the catalog
4) Wait for zebra to reindex, or trigger it yourself by
   running rebuild_zebra.pl -a -b -r
5) Go to Home -> Tools -> Stage MARC records for import
6) Select the same file as in part 2 and upload the file
7) Change the Record matching rule to ISBN (020$a)
8) Click on Stage for import
   -> Manage staged records
9) In the table below, there should now be a line showing
   the staged MARC record matches biblio
10) Note the "View"-text in the "Diff"-column
11) Apply patch
12) Install a language, view the same batch in the
Manage staged MARC records -page in that language
13) The "View" should show up correctly, and if the
msgid "View" was translated in the xx-YY-staff-prog.po,
should show up in the correct language

Signed-off-by: Pasi Kallinen 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20302] Allow translating Delete button in Patron batch mod tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20302

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20141] Untranslatable string in Transport cost matrix

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20141

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20141] Untranslatable string in Transport cost matrix

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20141

Jonathan Druart  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Trivial, skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20139] Improve MARC mapping translatable strings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20139

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |String patch
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Trivial, skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20141] Untranslatable string in Transport cost matrix

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20141

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #71246|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 72277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72277=edit
Bug 20141: Untranslatable string in transport cost matrix

Make the "Disable" checkboxes in transport cost matrix translatable

Test plan:

1) Go to Home -> Administration -> Transport cost matrix
2) Click on any cell
3) Note the "Disable" checkbox text
4) Install patch, add a language, translate the text, etc
5) Repeat 1-3, the "Disable" text should now be translated

Signed-off-by: Pasi Kallinen 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20139] Improve MARC mapping translatable strings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20139

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #71241|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 72276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72276=edit
Bug 20139: Improve MARC mapping translatable strings

- Allow translating one error message
- Use string formatting with placeholders instead of concatenation

Test plan:

1) Go to Home -> Administration -> Koha to MARC Mapping
2) Click on the "Add" button to add a new mapping
3) Note the popup text looks correct
4) Enter something invalid
5) Note the error message
6) Click on any of the "Remove" buttons to remove a mapping
7) Note the popup text looks correct
8) Update, translate the new msgid's, and install a language
9) Repeat 1-7, note how the message are in the correct
   language

Signed-off-by: Pasi Kallinen 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20139] Improve MARC mapping translatable strings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20139

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20296] Untranslatable "All" in patrons table filter

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20296

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Patch complexity|--- |String patch

--- Comment #5 from Jonathan Druart  
---
Trivial, skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20296] Untranslatable "All" in patrons table filter

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20296

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #72197|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 72275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72275=edit
Bug 20296: Untranslatable "All" in patrons table filter

There's an untranslatable "All" in the "Show X entries" filter
when browsing the patrons.

Test plan:

1) Home --> Patrons --> Browse by last name.
2) In the table filtering toolbar, there's a dropdown with
   "Show [20] entries" and the last in the dropdown is "All".
3) Update and install a language, check that msgid "All" is
   translated and isn't fuzzy.
4) Check the "All" in the dropdown, it is not translated.
5) Install patch, repeat 1-3, and check the "All" in the dropdown,
   it should now be translated.

Signed-off-by: Pasi Kallinen 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20295] Allow translating link title in ILL module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20295

Jonathan Druart  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Passed QA

--- Comment #3 from Jonathan Druart  
---
Trivial, skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20296] Untranslatable "All" in patrons table filter

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20296

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20295] Allow translating link title in ILL module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20295

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #72196|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 72274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72274=edit
Bug 20295: Allow translating link title in ILL module

Allow translating "View borrower details" link title in the ILL module.

Signed-off-by: Pasi Kallinen 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20295] Allow translating link title in ILL module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20295

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20111] Patron card creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
We should surround these strings with a HTML tag (span?) to avoid TT directives
in the po files (please apply the fix to both .tt)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20085] Better translatability of smart-rules.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20085

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
(In reply to Fridolin SOMERS from comment #1)
> Also adds  on "Unlimited" and "None defined" so that there are more
> visible
> and that there translation is more simple.

Why do you want to make them more visible? I do not think it should be done in
this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20305] Warnings in tools scripts need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20305

--- Comment #1 from Jonathan Druart  
---
Created attachment 72273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72273=edit
Bug 20305: Remove warnings from tools scripts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20304] Warnings in cataloguing scripts need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304

--- Comment #3 from Jonathan Druart  
---
I am going to attach patches when I find these warnings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20304] Warnings in cataloguing scripts need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #72271|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 72272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72272=edit
Bug 20304: Remove warnings from cataloguing scripts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20305] Warnings in tools scripts need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20305

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20304] Warnings in cataloguing scripts need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304

--- Comment #1 from Jonathan Druart  
---
Created attachment 72271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72271=edit
Bug 20304: Remove warnings from cataloguing scripts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20304] Warnings in cataloguing scripts need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20305] New: Warnings in tools scripts need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20305

Bug ID: 20305
   Summary: Warnings in tools scripts need to be removed
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 20017

Since bug 20017 we have now warnings in tools scripts.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017
[Bug 20017] use Modern::Perl in Tools perl scripts
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20017] use Modern::Perl in Tools perl scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20305


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20305
[Bug 20305] Warnings in tools scripts need to be removed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20304] New: Warnings in cataloguing scripts need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304

Bug ID: 20304
   Summary: Warnings in cataloguing scripts need to be removed
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 19996

Since bug 19996 we have now warnings in cataloguing scripts.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996
[Bug 19996] use Modern::Perl in cataloguing perl scripts
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/