[Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #13 from Katrin Fischer  ---
The tests don't pass for me :(

kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Letters/TemplateToolkit.t
t/db_dependent/Letters/TemplateToolkit.t .. ERROR PROCESSING TEMPLATE: plugin
error - Remove_MARC_punctuation: plugin not found at
t/db_dependent/Letters/TemplateToolkit.t line 104.
# Looks like your test exited with 2 before it could output anything.
t/db_dependent/Letters/TemplateToolkit.t .. Dubious, test returned 2 (wstat
512, 0x200)
Failed 18/18 subtests 

Test Summary Report
---
t/db_dependent/Letters/TemplateToolkit.t (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 18 tests but ran 0.


 FAIL   C4/Letters.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   FAIL   pod

empty =head3
*** ERROR: 

 in file C4/Letters.pm
   FAIL   pod coverage
POD is missing for add_tt_filters
POD is missing for getletter
   OK spelling
   OK valid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #30 from Katrin Fischer  ---

Hi Jonathan, 

Continuing testing:

I've used the SQL from the installer file to create my ACQ framework.

1) Looking at the code, why this change on the ISBD view?
 filters => 'ViewPolicy',
 options => {
 interface => 'intranet',
-frameworkcode => $framework
+frameworkcode => 'ACQ'
 },

2) The input fields are much shorter with the ACQ framework active. Can we
extend them a bit to be a similar size than before? Especially title and series
fields are too short.

3) The descriptions of the fields coming from the default framework are not
very nice because they are out of context without the field description. For
example 440 says title, but it's not clear it's the series title. The MARC
helps a bit.

4) I filled in title and series title and got an error on saving:
Indicator in 440 is empty at /home/vagrant/kohaclone/C4/Biblio.pm line 2294.
:13: parser error : Opening and ending tag mismatch: record line 6 and
datafield

^
:14: parser error : Opening and ending tag mismatch: collection line 2 and
record

 ^
:15: parser error : Extra content at the end of the document


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20489] Prevent DB user login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #17 from M. Tompsett  ---
See comment #9 and comment #10 for how I tested.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20489] Prevent DB user login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489

M. Tompsett  changed:

   What|Removed |Added

  Attachment #73528|0   |1
is obsolete||

--- Comment #15 from M. Tompsett  ---
Created attachment 73543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73543=edit
Bug 20489: Prevent DB user login

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20489] Prevent DB user login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489

M. Tompsett  changed:

   What|Removed |Added

  Attachment #73529|0   |1
is obsolete||

--- Comment #16 from M. Tompsett  ---
Created attachment 73544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73544=edit
Bug 20489: Remove warnings from the interface

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16690] Remote DB installation fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690

M. Tompsett  changed:

   What|Removed |Added

   Severity|minor   |major

--- Comment #10 from M. Tompsett  ---
Increased importance, because I really feel the local install of the DB on the
same machine as the web server is not something larger enterprises wish to do.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16690] Remote DB installation fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690

M. Tompsett  changed:

   What|Removed |Added

Summary|Installing DB on remote |Remote DB installation
   |server fails without GRANT  |fails
   |ALL, because wrong  |
   |permissions are checked |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

--- Comment #56 from Srdjan Jankovic  ---
Rebased, and fines look fine, however I think checkouts list is somewhat broken
on the circ issuing screen. And I believe that's not to do with this patch, but
cannot be 100% sure. Can you please have a look. Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #66261|0   |1
is obsolete||

--- Comment #55 from Srdjan Jankovic  ---
Created attachment 73542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73542=edit
Bug 14803 follow-up: outstanding-fees-amount is a class, not id

Multiple outstanding-fees-amount displays on the page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #65868|0   |1
is obsolete||

--- Comment #54 from Srdjan Jankovic  ---
Created attachment 73541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73541=edit
bug 14803: KOHA.Checkouts js object

* Use javascript to:
- update fines/checkouts info
- show/hide checkouts form and messages
* Created svc/patron/fines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #30 from Benjamin Rokseth  ---
rebased against master and added fixes to comments except OAI.

Ere, since you voluntered to add the neccessary fixes to OAI, I leave them to
you ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #27 from Benjamin Rokseth  ---
Created attachment 73538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73538=edit
Bug 20271: update kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73093|0   |1
is obsolete||

--- Comment #26 from Benjamin Rokseth  ---
Created attachment 73537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73537=edit
Bug 20271: fix remaining tests, add checks and report in atomicupdate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #29 from Benjamin Rokseth  ---
Created attachment 73540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73540=edit
Bug 20271: remove comments regarding deleteditems and -biblio*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #28 from Benjamin Rokseth  ---
Created attachment 73539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73539=edit
Bug 20271: delete biblio and biblio_metadata in one go

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73091|0   |1
is obsolete||

--- Comment #24 from Benjamin Rokseth  ---
Created attachment 73535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73535=edit
Bug 20271: merging delete biblio/items

NOTE: deleteditems/biblio on OAI
not sure how to test this, but the changes should be good enough

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #73092|0   |1
is obsolete||

--- Comment #25 from Benjamin Rokseth  ---
Created attachment 73536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73536=edit
Bug 20271 - merge deletedbiblio and -items back - add atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20462] Duplicate barcodes in batch item deletion cause software error if deleting biblio records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20462

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|Duplicate barcodes in batch |Duplicate barcodes in batch
   |item deletion cause |item deletion cause
   |software error if deleting  |software error if deleting
   |biblio records. |biblio records

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20494] Remove unused code in neworderempty.pl and addbiblio.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20494

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20462] Duplicate barcodes in batch item deletion cause software error if deleting biblio records.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20462

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20497] LibraryThing: always use https instead of http

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20497

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20385] ElasticSearch authority search raises Software error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20369] Analytics search is broken with QueryAutoTruncate set to 'only if * is added'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20369

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #7 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19892] Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19892

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20052] Add Reports object class

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20052

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #10 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #16 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #11 from Katrin Fischer  ---
I've tested it and I think it's still a little confusing.

Right now it is: total of holds / holds on on order items

Which can lead to the 1 / 0 that Jonathan pointed out. Maybe it would make more
sense to switch the values? Or just show the total number of holds = record
level + item level on on order items?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20291] Add a StaffLoginInstructions system preference to add text to the staff client login box

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #14 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20282] Wrong attribute in template calls to match holding branch when adding/editing a course reserve item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20282

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19907] Email validation on patron add/edit not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #8 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18820] The different parts in the main don't automatically adjust with the available space

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #19 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18382] action_logs entry for module HOLDS, action SUSPEND is spammy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18382

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #22 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18474] Placing multiple holds from results breaks when patron is searched for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18474

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18820] The different parts in the main don't automatically adjust with the available space

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820

--- Comment #24 from Jonathan Druart  
---
Patches pushed to master.

Congratulations Roch and Philippe for your first patches in!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #16 from Katrin Fischer  ---
Hi Jonathan, 

some thoughts:

1) sub _get_base_url doesn't look quite right yet.
a) It hardcodes en. Ideally we should try to check for the existence of a
translated manual and use that, with a fallback to en. If we can't do that,
we'll maybe need to add a pref where you can add the lanugage codes to use.
b) For the local manual URL you combine:
C4::Context->preference('staffClientBaseURL') . $KohaManualBaseURL;
I think it might be good to allow for a full URL in KohaManualBaseURL. That way
you could have the help on the same server or at another location.

2) If the permission doesn't work yet, I would not include it :)

3) The manual layout doesn't work well in the small pop up. I wonder if there
is a way to leave off the side navigation, but probably we can just make the
window a bit wider.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20467] Add ability to batch add items to a course

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Passed QA   |Failed QA

--- Comment #11 from Jonathan Druart  
---
1. Need to be patched with changes on bug 20282

2. I think you should use the TT plugin AuthorisedValues (and include file
options_for_authorised_value_categories) for CCODE and LOC

3. You should use uniq on @barcodes (and use the same split we already do in
tools/*: \s\n)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #9 from Jonathan Druart  
---
Translatable strings must be put in .tt files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #8 from Jonathan Druart  
---
Any good reasons to use custom tag elements here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20329] Text input fields are wider than the fieldset class they are inside of

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |minor
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Passed QA   |Failed QA
   Keywords||rel_18_05_candidate

--- Comment #10 from Jonathan Druart  
---
It is not a good idea to specify a size in px, you should use a relative lenght
instead.

We already have
 div.yui-b fieldset.brief select {  
width: 12em;
 }

12em sounds like a good value here.

Maybe the following addition would be enough:
 div.yui-b fieldset.brief input {
width: 12em;
 }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add index from UI

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Passed QA   |Failed QA

--- Comment #8 from Jonathan Druart  
---
1. What's the point of the JS function valid_line?
I think you should double-check it, it does not do what you expect it to do.

2. You are reusing code to duplicate a new mapping but for something else. You
should rename the variables to avoid confusion then.
For instance "search_fields" is not an index name

3. Bug report's title is wrong, we are not adding/removing indices

4. I did not implement that part on the original patch because it's hard to
keep an interface consistent.
For instance:
- create a new search field
=> You cannot create a new mapping, you have to save first
- create a new search field, save
=> You can delete it. So it you create a mapping using it, you can still delete
it. If you save => kaboom
=> If you have a search field already mapped and delete the mapping, you cannot
delete the search field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

--- Comment #10 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #9)
> (In reply to Jonathan Druart from comment #8)
> > There is an access to the removed variable "holds" in the template
> > loop_order.holds
> > 
> > That means we now see "Can't delete catalog record, see constraints below",
> > but without anything below...
> 
> The code you are referencing is in loop_orders, but this patch only alters
> loop_received which does not have that message. I'm not sure how this patch
> could be causing that. If you can give me some line numbers I'd be happy to
> take another look!

Indeed, sounds like I mixed the 2 tables reading the code.

Something else:
1. What about comment 6?

2. "1 / 0" reads wrong, but I have no idea how it could be better.

3. line 141 $line{holds} = 0;
should be removed, right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #28 from Katrin Fischer  ---

> That's how I had it before Jonathan Druart asked me to put the symbols in
> place in comment #18 above. I don't mind either way as long as the QA team
> and RM can agree (or do I have to add in a syspref for this? :-) ).
> 
> I'll await a decision before changing this simple patch again.

I talked to Joubu and removing the currency symbols will be safe ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20282


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20282
[Bug 20282] Wrong attribute in template calls to match holding branch when
adding/editing a course reserve item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20282] Wrong attribute in template calls to match holding branch when adding/editing a course reserve item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20282

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||15758

--- Comment #4 from Jonathan Druart  
---
Caused by
  commit 9b9803b69c8bde879768ccfa3cc4688ef46b7799
  Bug 15758: Koha::Libraries - Remove GetBranchesLoop


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758
[Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20385] ElasticSearch authority search raises Software error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385

--- Comment #11 from Jonathan Druart  
---
We really need tests for these ES methods!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20509] New: Data consistency - authority types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509

Bug ID: 20509
   Summary: Data consistency - authority types
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 20385

>From bug 20385.

We should display a message on the about page (or a new page dedicated to data
consistency) if an authtypecode of authority records does not correspond to an
authority type defined in the system.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385
[Bug 20385] ElasticSearch authority search raises Software error
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20385] ElasticSearch authority search raises Software error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20509


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509
[Bug 20509] Data consistency - authority types
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17373] Elasticsearch - Authority mappings for UNIMARC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #13 from Jonathan Druart  
---
Please fix patches' author (name and email).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the About Koha page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18820] The different parts in the main don't automatically adjust with the available space

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the About Koha page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72214|0   |1
is obsolete||

--- Comment #3 from M. Tompsett  ---
Created attachment 73533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73533=edit
Bug 18674: Added timezone information to about page

Before patch: No timezone section
After patch: timezone section at bottom of
 Server information tab.

Actual is what is being used. Config overrides environment variables.
So if there is confusion why the environment variables aren't working,
it will be visible why.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the About Koha page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674

--- Comment #4 from M. Tompsett  ---
Created attachment 73534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73534=edit
Bug 18674: Follow up on missing TZ SetEnv for plack

It should also be noted that
/etc/apache2/sites-enabled/{configuration file}
should also contain:
RequestHeader add X-Koha-SetEnv "TZ {timezone}"
Where {timezone} is the desired instance timezone.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18474] Placing multiple holds from results breaks when patron is searched for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18474

Jonathan Druart  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #11 from Jonathan Druart  
---
*** Bug 20392 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20392] Multiple biblio holding does not work when patron is not set

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20392

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Passed QA   |RESOLVED

--- Comment #7 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 18474 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318

--- Comment #15 from Jonathan Druart  
---
Created attachment 73532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73532=edit
Bug 20318: Add class 'required' to the label

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
  Attachment #72969|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #72975|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20502] Record URL broken, when there is more than one 856 on the record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
We should not use biblioitems.url but GetMarcUrls instead

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff
   Severity|normal  |major
   Keywords||rel_18_05_candidate

--- Comment #27 from Jonathan Druart  
---
I have attached a patch to test, it makes the pref multiple to bring
flexibility.

We need to resolve this for 18.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #26 from Jonathan Druart  
---
Created attachment 73531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73531=edit
Bug 19974: Make MarkLostItemsAsReturned multiple

Given the confusion regarding this behaviour it sounds better to make it
configurable.
This pref will take 4 different values, 1 per place an item can be
marked as lost.

Test plan:
Mark items as lost and confirm the item is returned or not, depending on
the value of the system preference.

- from the longoverdue cronjob (--mark-returned takes precedence if set)
- from the batch item modification tool
- when cataloguing an item
- from the items tab of the catalog module

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18757] Problem when importing only items in MARC records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757

--- Comment #8 from M. Tompsett  ---
BTW, it should be noted that this same problem shows itself as an "Internal
Server Error" if one tries to manually catalogue a record in UNIMARC, and uses
something clearly bad, like "KABOOM!" in the 100$a field. :)

substr outside of string at /usr/share/perl5/MARC/File/XML.pm line 561 (#2)
(W substr)(F) You tried to reference a substr() that pointed outside of
a string.  That is, the absolute value of the offset was larger than the
length of the string.  See "substr" in perlfunc.  This warning is fatal if
substr is used in an lvalue context (as the left hand side of an
assignment or as a subroutine argument for example).

Use of uninitialized value $enc in string eq at
/usr/share/perl5/MARC/File/XML.pm line 563 (#1)
Use of uninitialized value $enc in string eq at
/usr/share/perl5/MARC/File/XML.pm line 565 (#1)
Use of uninitialized value $enc in concatenation (.) or string at
/usr/share/perl5/MARC/File/XML.pm line 568 (#1)
Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a ->
kaboom at /usr/share/perl5/MARC/File/XML.pm line 568.

No need to make any 200 rules.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20426] Can't import all titles from a stage file with default values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426

--- Comment #4 from Jonathan Druart  
---
Created attachment 73530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73530=edit
Bug 20426: Fix default fund value when adding orders from iso2709 file

A new bug has been highlighted since:
  commit b830349f45007629f141a9835e05b95f90ee4b92
  Bug 19453: Incorrect jQuery selector for fund drop down validation

Prior to bug 19453 the check on the existence of the fund did not work
as expected, no select with name='budget_code' existed and the error was
never raised.
Now it works but expect a fund to be selected for every record to
import.
This check must only be done if there is no default value selected.

Test plan:
- Create an order from a staged file
- Do not select any funds
=> You must get a warning
- Select a specific fund for some of the records
=> You must get a warning
- Select a default fund in the last tab
=> You must not get a warning and the records must be imported and
inserted with the correct fund

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20426] Can't import all titles from a stage file with default values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19453] Client side validation broken for "Fund" select

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||20426


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426
[Bug 20426] Can't import all titles from a stage file with default values
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20426] Can't import all titles from a stage file with default values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19453

--- Comment #3 from Jonathan Druart  
---
Ha, I think I found the problem.

It has been caused by
  commit b830349f45007629f141a9835e05b95f90ee4b92
  Bug 19453: Incorrect jQuery selector for fund drop down validation


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453
[Bug 19453] Client side validation broken for "Fund" select
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18757] Problem when importing only items in MARC records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #7 from M. Tompsett  ---
https://archive.ifla.org/VI/8/projects/UNIMARC-HoldingsFormat.pdf
-- but isn't there supposed to be a 100?!

12-15 Character Set (Mandatory)
These four character positions indicate the principal graphic character sets
used in the record.
Positions 12-13 designate the G0 set and positions 14-15 designate the G1 set.
If a G1 set is
not needed, positions 14-15 contain blanks.
01 = ISO 646, IRV version (basic Latin set)
02 = ISO Registration # 37 (basic Cyrillic set)
03 = ISO 5426 (extended Latin set)
04 = ISO DIS 5427 (extended Cyrillic set)
05 = ISO 5428 (Greek set)
06 = ISO 6438 (African coded character set)
07 = ISO 10586 (Georgian set)
08 = ISO 8957 (Hebrew set) Table 1
09 = ISO 8957 (Hebrew set) Table 2
10 = [Reserved]
11 = ISO 5426-2 (Latin characters used in minor European languages and obsolete
typography)
50 = ISO 10646 Level 3 (Unicode)

Oh yuck... reading the MARC::File::XML library... it basically fakes it.

# Does the record think it is already Unicode?
if ($original_encoding ne 'a' && lc($format) !~ /^unimarc/o) {
# If not, we'll make it so
$_transcode++;
substr($ldr,9,1,'a');
$record->leader( $ldr );
}

which is why the as_xml in elsewhere does the "USMARC" thing. Okay. I'll test
this, since I'm assuming Fridolin has already tested in a UNIMARC context
before submitting this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20508] New: Validation for *MandatoryField and *UnwantedField sysprefs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20508

Bug ID: 20508
   Summary: Validation for *MandatoryField  and *UnwantedField
sysprefs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

When any the system preferences

BorrowerMandatoryField
BorrowerUnwantedField
PatronSelfModificationBorrowerUnwantedField
PatronSelfRegistrationBorrowerMandatoryField
PatronSelfRegistrationBorrowerUnwantedField

are being populated, we should check that

a) The entered fields are columns in the borrowers table
b) Mandatory / Unwanted fields that refer to the same form
(BorrowerMandatoryField/BorrowerUnwantedField and
PatronSelfRegistrationBorrowerMandatoryField/PatronSelfRegistrationBorrowerUnwantedField)
do not contain the same fields.
c) If autoMemberNum is set, don't allow cardnumber in *MandatoryField

See also:

* Bug 17433
* Bug 19642
* Bug 19225

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price display on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #27 from Jonathan Druart  
---
(In reply to Jon Knight from comment #26)
> (In reply to Katrin Fischer from comment #25)
> > Hi Séverine, there is no a setting in administration > currency for each
> > currency, where you can define if there should be a space or not.
> > 
> > I am torn about seeing the currency. I think we agreed a long while ago that
> > we should not show the currency symbols in acq as long as it's the active
> > currency as it would clutter a lot of the displays, where you deal with a
> > lot of numbers and prices. Would you agree to remove the currency symbol
> > display?
> >  $Price with_symbol => 1 
> 
> That's how I had it before Jonathan Druart asked me to put the symbols in
> place in comment #18 above. I don't mind either way as long as the QA team
> and RM can agree (or do I have to add in a syspref for this? :-) ).
> 
> I'll await a decision before changing this simple patch again.

IIRC you displayed the currency code :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

--- Comment #12 from Jonathan Druart  
---
Test plan:
- Confirm that the new tests pass. That should be enough to confirm this change
make sense.

Test plan (manual):
- Create a biblio with a title ending with a punctuation (like
"with_punctuation_"), or any other fields of biblio/biblioitem
- Generate a notice which will display this field (CHECKIN for instance)

Use the historical syntax and the TT syntax, both should display the title
without the punctuation character at the end

CHECKIN historical:
The following items have been checked in:

<>


CHECKIN TT syntax:
The following items have been checked in:

[% biblio.title %]


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20077] Patroncards are printed blank

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20077

Chris Nighswonger  changed:

   What|Removed |Added

 CC||cnighswon...@foundations.ed
   ||u

--- Comment #7 from Chris Nighswonger  ---
(In reply to Sven H. from comment #3)
> 
> 
> I have a similar problem.
> 
> When I try to print the patron cards, the
> /usr/share/koha/intranet/cgi-bin/patroncards/create-pdf.pl does not finish
> and runs with 100% CPU load.
> 
> In plack-error.log I find the following lines:
> Use of uninitialized value $batch_id in concatenation (.) or string at
> /usr/share/koha/intranet/cgi-bin/patroncards/create-pdf.pl line 68.
> Use of uninitialized value in multiplication (*) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 239.
> Use of uninitialized value in addition (+) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 256.
> Use of uninitialized value in multiplication (*) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 288.
> Use of uninitialized value in multiplication (*) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 239.
> Use of uninitialized value in addition (+) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 256.
> Use of uninitialized value in multiplication (*) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 288.
> Use of uninitialized value in multiplication (*) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 239.
> Use of uninitialized value in addition (+) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 256.
> 
> The problem first appeared in February 2018 after I started the Ubuntu
> updates. Unfortunately I don't remember what has been updated.
> 

snip

> 
> Unfortunately I am not able to print patron cards at the moment. It would be
> great if there was a solution for this soon.

I'm not sure what is going on in this particular instance, but taking the same
steps on my production system results in a PDF containing the expected cards
and nearly zero CPU usage.

Unless someone else can confirm the problem, I would look at something local.
Perhaps a Koha update did not apply well or some such, resulting in a script
not being updated.

Also, this appears to be a different problem than the one the OP reported. It
would be good to open a new bug for it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20489] Prevent DB user login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489

--- Comment #14 from Jonathan Druart  
---
(In reply to M. Tompsett from comment #11)
> This tweak is the one I don't understand.

It was not related to this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20489] Prevent DB user login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489

--- Comment #13 from Jonathan Druart  
---
Created attachment 73529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73529=edit
Bug 20489: Remove warnings from the interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20489] Prevent DB user login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #73400|0   |1
is obsolete||
  Attachment #73425|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  
---
Created attachment 73528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73528=edit
Bug 20489: Prevent DB user login

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #15 from Jonathan Druart  
---
Done, note that the last patch does nothing (new permission is not used).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #69807|0   |1
is obsolete||
  Attachment #69808|0   |1
is obsolete||
  Attachment #70131|0   |1
is obsolete||
  Attachment #70132|0   |1
is obsolete||
  Attachment #70133|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 73523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73523=edit
Bug 19817: Redirect to the online manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #14 from Jonathan Druart  
---
Created attachment 73527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73527=edit
Bug 19817: Add new permission edit_help

Change in existing behaviour!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #11 from Jonathan Druart  
---
Created attachment 73524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73524=edit
Bug 19817: Remove local help files + edit help feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #13 from Jonathan Druart  
---
Created attachment 73526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73526=edit
Bug 19817: Move code to Koha::Manual to make it testable and reusable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #12 from Jonathan Druart  
---
Created attachment 73525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73525=edit
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20304] Warnings in cataloguing scripts need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304

--- Comment #6 from Jonathan Druart  
---
(In reply to M. Tompsett from comment #4)
> Comment on attachment 72272 [details] [review]
> Bug 20304: Remove warnings from cataloguing scripts
> 
> Review of attachment 72272 [details] [review]:
> -
> 
> ::: cataloguing/additem.pl
> @@ +157,5 @@
> >  my $temp2 = $temp->field($CNtag);
> >  if ($temp2) {
> > +my $value = q{};
> > +$value .= $temp2->subfield($CNsubfield)  if 
> > $temp2->subfield($CNsubfield);
> > +$value .= $temp2->subfield($CNsubfield2) if 
> > $temp2->subfield($CNsubfield2);
> 
> Where's the space gone?

lost, but I found it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20304] Warnings in cataloguing scripts need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #72272|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 73522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73522=edit
Bug 20304: Remove warnings from cataloguing scripts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20116] Cache language list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116

--- Comment #7 from Jonathan Druart  
---
(In reply to M. Tompsett from comment #5)
> Comment on attachment 71098 [details] [review]
> Bug 20116: Cache language list
> 
> Review of attachment 71098 [details] [review]:
> -
> 
> ::: C4/Languages.pm
> @@ +122,3 @@
> >  if ($interface && $interface eq 'opac' ) {
> >  my $htdocs = C4::Context->config('opachtdocs');
> >  @languages = _get_opac_language_dirs( $htdocs, $theme );
> 
> Forgot to delete this line, I think.

Indeed, thanks for catching it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20116] Cache language list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #71098|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 73521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73521=edit
Bug 20116: Cache language list

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20507] New: Shelf browser does not update image sources when paging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507

Bug ID: 20507
   Summary: Shelf browser does not update image sources when
paging
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When using a cover source other than Amazon (which uses static links) the shelf
browser does not fire a call to the image sources when moving to a new page

To recreate:
Enable coce (https://coce.bywatersolutions.com) and enable all sources except
amazon
Enable shelf browser
View a title in the opac
View the shelf browser, note images load on first page
Page left or right and note images are not loaded

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20506] How do I get drop menu help for classification in koha?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20506

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
Bugzilla is used for reporting bugs and enhancement requests, but this reads
more like a support request. Please ask your questions on the mailing list:
https://koha-community.org/support/koha-mailing-lists/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20506] New: How do I get drop menu help for classification in koha?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20506

Bug ID: 20506
   Summary: How do I get drop menu help for classification in
koha?
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: manjun...@tapmi.edu.in
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

we have installed koha s/w in our library. we are not able to make the s/w auto
appenadable field for books, journal issues, project reports separately. we
ahave separate Accno/barcode for each item type. similarly, how do we get DDC
classno & subject help from current pool of classnos and subject headings in
the collection?. we have table of classnos and subejct headings in the book
collection. we need the selection help to avoid typo errors. can KOHA community
help us?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346

--- Comment #10 from Alex Buckley  ---
Created attachment 73520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73520=edit
Bug 20346 - Making JS strings translatable

This is based on tester feedback in comments 7 and 8

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #53 from Katrin Fischer  ---
Alex, should this be set back to Signed off with your follow-up?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/