[Koha-bugs] [Bug 20116] Cache language list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116

Jonathan Druart  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
   ||, tomasco...@gmail.com
   Keywords||rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #66 from M. Tompsett  ---
Comment on attachment 73873
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73873
Bug 12310 : Decimal separator issues: fixes in fines

Review of attachment 73873:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12310=73873)
-

::: koha-tmpl/intranet-tmpl/prog/en/includes/decimal-input-js.inc
@@ +19,5 @@
> +// remove everything except digits, minuses, and the chars in 
> DecimalSeparators syspref
> +var formatted_decimal = formatted_decimal
> +  .replace(/[^0-9-[% 
> Koha.Preference('DecimalSeparators') %]]/g, '');
> +var decimal = formatted_decimal
> +.replace(/[[% Koha.Preference('DecimalSeparators') 
> %]]/g, '.');

Sorry, but this doesn't quite work.
5,123.12 -> 5.123.12

The decimal point is likely the LAST one that matches the DecimalSeparators.
While everything else is either noise or thousands separators.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20305] Warnings in tools scripts need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20305

Julian Maurice  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20305] Warnings in tools scripts need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20305

Julian Maurice  changed:

   What|Removed |Added

  Attachment #73868|0   |1
is obsolete||

--- Comment #11 from Julian Maurice  ---
Created attachment 73876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73876=edit
Bug 20305: Remove warnings from tools scripts

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #73872|0   |1
is obsolete||

--- Comment #23 from Jonathan Druart  
---
Created attachment 73877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73877=edit
Bug 19817: Use the language from the interface if valid

Use the UI language for the manual, if exists. Use the pref as a
fallback.

With the call to get_template_and_user the value of preferred_language
switched from 'es' (spanish) to 'en' from one click to another (??)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Readonly::XS version not detected

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #73407|0   |1
is obsolete||

--- Comment #12 from Victor Grousset/tuxayo  ---
Created attachment 73879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73879=edit
Bug 20103: Readonly::XS is completely bogus post perl 5.8

A ha! Lie about who we are, and the module will return a version.

./koha_perl_deps.pl -a
-- before patch Readonly::XS is 0
-- after patch it has a version number.
run koha qa test tools

Signed-off-by: Victor Grousset 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Readonly::XS version not detected

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||victor.grous...@biblibre.co
   ||m
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi  ---
What is the status for this? Is anyone going to work on this for 18.05?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||13958
   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=13958   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958
[Bug 13958] Add a suspensionsCalendar syspref
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13958] Add a suspensionsCalendar syspref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||19204
   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=19204   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204
[Bug 19204] Fines in days restriction calculation is not taking calender into
account
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20467] Add ability to batch add items to a course

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #21 from Tomás Cohen Arazi  ---
I feel like the dev is good enough to be considered for inclusion. In the
merge-patrons case, I did the rewrite because I didn't want to have code in
Koha::* that diverted from what we've been doing for a couple years, but the
logic itself was good too.
In this case, those controller scripts... I don't think this matter of taste
should care that much.

If I was asked before this dev was written, I would've agreed with a same-page
approach. And a REST endpoint to handle CRUD. But I don't think this should be
rejected because of it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #67 from M. Tompsett  ---
Using DecimalSeparator as ',.', we should be able to enter #,###,###.## and get
###.## back.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #65 from M. Tompsett  ---
Created attachment 73880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73880=edit
Bug 12310: Follow up to prevent updatedatabase noise

Added IGNORE into the SQL statement.
TEST PLAN
-
run the atomic update multiple times.
-- noise
apply patch
run the atomic update multiple times.
-- no noise

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515

--- Comment #4 from Andrew Isherwood  ---
Created attachment 73875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73875=edit
Bug [20515] - [Follow up]

Removed the test for CAN_user_superlibrarian as requested

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20528] Remove the items tab from the detailed bibliographic view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20528

Fanny Mion Mouton  changed:

   What|Removed |Added

 CC||fanny.mion-mou...@bulac.fr

--- Comment #7 from Fanny Mion Mouton  ---
Hi, our library also developped some workflows using the item tab (Withdrawn
status,Lost status) and we find this compact tab very useful to get easily some
informations such as circulation history.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20541] extern Z39.50 search bring no matches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20541

--- Comment #3 from Katrin Fischer  ---
If it was from the same server, that rules out the IP problem. Can you double
check your config and post what you used? (preferrably on the mailing list :) )

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #46 from Katrin Fischer  ---
Hi Aleisha, is this ready for retesting or one follow-up missing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20179] Remove GROUP BY in get_shelves_containing_record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20179

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #6 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20180] Remove GROUP BY clause in manage-marc-import.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #7 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #13 from M. Tompsett  ---
Tests trigger all changed code. Thanks, Kyle. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #70918|0   |1
is obsolete||
  Attachment #70919|0   |1
is obsolete||

--- Comment #46 from Jonathan Druart  
---
Created attachment 73881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73881=edit
Bug 19287: Add ability to mark an item 'Lost' from 'Holds to pull' list

The goal to this enhancement is to add the ability to cancel a hold and
mark items as lost from the 'Holds to pull' page.
A new pref is added to control the behaviour, default is off

To mark items as lost you need to set the new pref CanMarkHoldsToPullAsLost to
one of these two values:
- "Allow to mark items as lost"
=> The item will be marked as lost and the hold will be cancelled
- "Allow to mark items as lost and notify the patron"
=> Same as previously but the patron will be notified as well.

The notification is done using a new notice template
(code=CANCEL_HOLD_ON_LOST).
Feel free to suggest another default wording.

To update the values of the items when one of these 2 buttons are used, you
need to
fill the UpdateItemWhenLostFromHoldList with something like: 'itemlost: 1'

Test plan:
1/ Place holds on some items
2/ Go to Home > Circulation > Holds to pull
From here you can cancel the hold or
3/ Mark the items as lost
=> You will receive feedback messages depending on different situations:
* The CANCEL_HOLD_ON_LOST does not exist
* The patron does not have an email address (but the notice has been
enqueued! It is the current behaviour with other notices)
* The notice has been enqueued
* The hold has been cancelled

QA Notes:
From which library do we want to pick the notice? This patch use
reserves.branchcode

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #47 from Jonathan Druart  
---
Created attachment 73882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73882=edit
Bug 19287: Fix conflict with bug 19304

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #49 from Jonathan Druart  
---
Created attachment 73884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73884=edit
Bug 19287: Use the notice defined for the homebranch of the patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #48 from Jonathan Druart  
---
Created attachment 73883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73883=edit
Bug 19287: Fix conflict with bug 19974

Note that these patches should be pushed along with bug 19984 to avoid
regressions (if the syspref is changed between the 2 update DB entries)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #51 from Jonathan Druart  
---
Created attachment 73886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73886=edit
Bug 19287: Add column action to columns settings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #50 from Jonathan Druart  
---
Created attachment 73885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73885=edit
Bug 19287: Add CANCEL_HOLD_ON_LOST to installer files for all languages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #53 from Jonathan Druart  
---
Created attachment 73888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73888=edit
Bug 19287: Do not display buttons for biblio level holds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #52 from Jonathan Druart  
---
Created attachment 73887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73887=edit
Bug 19287: Update UpdateItemWhenLostFromHoldList description

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #54 from Jonathan Druart  
---
Created attachment 73889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73889=edit
Bug 19287: Shorten button text

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10732] use a stricter SQL_MODE

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10732

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |RESOLVED

--- Comment #1 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 17258 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Jonathan Druart  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #8 from Jonathan Druart  
---
*** Bug 10732 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #24 from M. Tompsett  ---
Comment on attachment 73523
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73523
Bug 19817: Redirect to the online manual

Review of attachment 73523:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19817=73523)
-

::: help.pl
@@ +1,3 @@
>  #!/usr/bin/perl
>  
> +# Copyright 2017 Koha Development team

I would prefer 2010-2017 or even 2010,2017 so we do not lose track of the
original date in quickly obvious statement.
(https://www.plagiarismtoday.com/2011/11/08/how-to-write-a-copyright-notice/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #55 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #45)
> Comment on attachment 70918 [details] [review]
> Bug 19287: Add ability to mark an item 'Lost' from 'Holds to pull' list
> 
> Review of attachment 70918 [details] [review]:

Thanks Katrin!
All your remarks have been taken into account in different patch to ease next
reviews.
They can be squashed if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
We already have "Add message" in the toolbar, should not we remove this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789

--- Comment #82 from Jonathan Druart  
---
Created attachment 73890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73890=edit
Bug 18789: (follow-up) Pass a Koha::Patron object from returns.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

M. Tompsett  changed:

   What|Removed |Added

  Attachment #73175|0   |1
is obsolete||

--- Comment #10 from M. Tompsett  ---
Created attachment 73891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73891=edit
Bug 18821 - TrackLastPatronActivity is a performance killer

Enabling TrackLastPatronActivity can cause an extreme performance hit,
especially on the staff side during checkin and checkout. It makes more sense
to only update the last activity timestamp on the first access of a given
session. This will greatly improve performance while retaining the same basic
information.

Test Plan:
1) Apply this patch
2) Start a new session ( a private browser window works well )
3) Note the lastseen column in the borrowers table is updated
4) Browse a few pages, not the lastseen column is not updated again
5) Close the browser window and repeat steps 2-4
6) prove t/db_dependent/Members.t

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

M. Tompsett  changed:

   What|Removed |Added

  Attachment #73706|0   |1
is obsolete||

--- Comment #11 from M. Tompsett  ---
Created attachment 73892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73892=edit
Bug 18821: [DO NOT PUSH] Print STDERR Scaffolding

Tests must trigger all STDERRs added.
prove t/db_dependent/Members.t
prove t/db_dependent/Auth.t

Patrons 3 and 4 not triggered.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

M. Tompsett  changed:

   What|Removed |Added

  Attachment #73863|0   |1
is obsolete||

--- Comment #12 from M. Tompsett  ---
Created attachment 73893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73893=edit
Bug 18821 [QA Followup]: Add additional unit tests for completeness

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20467] Add ability to batch add items to a course

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

--- Comment #22 from Jonathan Druart  
---
When I edit an item, I get:
  "This course already has this item on reserve."
and
  "Number of courses reserving this item: 1"

Are they expected? (with and without the patch)

Also the legend of the fieldset always says "Add" (instead of edit)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds extra null fields to indexes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||additional_work_needed
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #19 from Jonathan Druart  
---
Lot of failures from t/db_dependent/Koha_Elasticsearch.t:

#   Failed test at t/db_dependent/Koha_Elasticsearch.t line 153.
#  got: 'marc_map('110a','author__sort.$append', )'
# expected: 'marc_map('110a','author__sort.$append', -split => 1)'
# Looks like you failed 23 tests of 49.

Please fix ASAP

https://jenkins.koha-community.org/job/Koha_Master_D8/425/consoleFull

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19804] Suspension calculation doesn't honor 'Suspension charging interval'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

--- Comment #26 from Jonathan Druart  
---
Created attachment 73894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73894=edit
Bug 19804: Fix test in GetHardDueDate.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19804] Suspension calculation doesn't honor 'Suspension charging interval'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

--- Comment #27 from Jonathan Druart  
---
Created attachment 73895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73895=edit
Bug 19804: Fix test in maxsuspensiondays.t

We do not want a random value of suspension_chargeperiod from
TestBuilder

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds extra null fields to indexes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

--- Comment #20 from Jonathan Druart  
---
Created attachment 73896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73896=edit
Bug 19581: Fix Koha_Elasticsearch.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds extra null fields to indexes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

--- Comment #21 from Jonathan Druart  
---
Ok done, pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19804] Suspension calculation doesn't honor 'Suspension charging interval'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

--- Comment #28 from Jonathan Druart  
---
Last two patches pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #25 from M. Tompsett  ---
Comment on attachment 73525
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73525
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL

Review of attachment 73525:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19817=73525)
-

The http URL redirects to an https one, so it makes more sense to use https
immediately.

::: help.pl
@@ +39,2 @@
>  # FIXME /en/ must be configurable (or guessed)
> +my $KohaManualBaseURL = C4::Context->preference('KohaManualBaseURL') || 
> 'http://koha-community.org/manual';

please use https.

::: installer/data/mysql/atomicupdate/bug_19817.sql
@@ +1,2 @@
> +INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, 
> `explanation`, `type` )
> +VALUES ('KohaManualBaseURL','http://koha-community.org/manual/','','Where is 
> the Koha manual/documentation located?','Free');

please use https.

::: installer/data/mysql/sysprefs.sql
@@ +238,4 @@
>  
> ('itemBarcodeInputFilter','','whitespace|T-prefix|cuecat|libsuite8|EAN13','If 
> set, allows specification of a item barcode input filter','Choice'),
>  ('itemcallnumber','082ab',NULL,'The MARC field/subfield that is used to 
> calculate the itemcallnumber (Dewey would be 082ab or 092ab; LOC would be 
> 050ab or 090ab) could be 852hi from an item record','free'),
>  ('KohaAdminEmailAddress','root@localhost','','Define the email address where 
> patron modification requests are sent','free'),
> +('KohaManualBaseURL','http://koha-community.org/manual/','','Where is the 
> Koha manual/documentation located?','Free'),

please use https.

:::
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref
@@ +394,5 @@
> +Manual:
> +-
> +- Location of the Koha manual
> +- pref: KohaManualBaseURL
> +- You can specify the location of the Koha manual to use. By 
> default it is http://koha-community.org/manual/

please use https.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #26 from M. Tompsett  ---
Comment on attachment 73526
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73526
Bug 19817: Move code to Koha::Manual to make it testable and reusable

Review of attachment 73526:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19817=73526)
-

I may have missed commenting on other changes which had just http in them.

::: Koha/Manual.pm
@@ +17,5 @@
> +}
> +
> +sub _get_base_url {
> +# FIXME /en/ must be configurable (or guessed)
> +my $KohaManualBaseURL = C4::Context->preference('KohaManualBaseURL') || 
> 'http://koha-community.org/manual';

Please use https.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #27 from M. Tompsett  ---
Comment on attachment 73651
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73651
Bug 19817: Add pref KohaManualLanguage

Review of attachment 73651:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19817=73651)
-

::: Koha/Manual.pm
@@ +20,2 @@
>  my $KohaManualBaseURL = C4::Context->preference('KohaManualBaseURL') || 
> 'http://koha-community.org/manual';
> +my $KohaManualLanguage = C4::Context->preference('KohaManualLanguage') 
> || 'en';

If there are multiple languages selected, this will be ugly and broken, I think
(haven't tested yet).

::: installer/data/mysql/sysprefs.sql
@@ +47,4 @@
>  ('AnonSuggestions','0',NULL,'Set to enable Anonymous suggestions to 
> AnonymousPatron borrowernumber','YesNo'),
>  ('AnonymousPatron','0',NULL,'Set the identifier (borrowernumber) of the 
> anonymous patron. Used for Suggestion and reading history privacy',''),
>  ('ArticleRequests', '0', NULL, 'Enables the article request feature', 
> 'YesNo'),
> +('ArticleRequestsMandatoryFields', '', NULL, 'Comma delimited list of 
> required fields for bibs where article requests rule = ''yes''', 'Choice'),

Was this another bug fix someewhere? multiple->Choice and removal of end of
line whitespace.

@@ +239,4 @@
>  ('itemcallnumber','082ab',NULL,'The MARC field/subfield that is used to 
> calculate the itemcallnumber (Dewey would be 082ab or 092ab; LOC would be 
> 050ab or 090ab) could be 852hi from an item record','free'),
>  ('KohaAdminEmailAddress','root@localhost','','Define the email address where 
> patron modification requests are sent','free'),
>  ('KohaManualBaseURL','http://koha-community.org/manual/','','Where is the 
> Koha manual/documentation located?','Free'),
> +('KohaManualLanguage','en','en|ar|cs|es|fr|it|pt_BR|tr|zh_TW','What is the 
> language of the online manual you want to use?','multiple'),

I like the idea of calling up the language which is currently selected, if
possible. However, multiple differs from Choice used in the atomic update. Need
to correct somehow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18585] Connect to RDF triplestore

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

David Cook  changed:

   What|Removed |Added

 Blocks||18713


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713
[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

David Cook  changed:

   What|Removed |Added

 Depends on||18585


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585
[Bug 18585] Connect to RDF triplestore
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #25 from David Cook  ---
(In reply to Mirko Tietgen from comment #24)
> (In reply to David Cook from comment #23)
> > Or maybe I added the dependency to #18585 ...
> 
> I'd say you either could set this bug to 'depends on' one of the bugs that
> have the dependency declared, or you also add it for this one.

Done :)

Guess I better update #18585 now then..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18585] Connect to RDF triplestore

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

David Cook  changed:

   What|Removed |Added

  Attachment #71016|0   |1
is obsolete||

--- Comment #26 from David Cook  ---
Created attachment 73897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73897=edit
Bug 18585 - Connect to RDF triplestore

This commit adds a 'triplestore' method to C4::Context. It takes
a model name as a parameter and returns a RDF::Trine::Model object
if triplestore.yaml is properly configured.

(At the moment, it just supports RDF::Trine::Store::SPARQL,
but it would be trivial to add support for RDF::Trine::Store::DBI too,
or any other RDF::Trine::Store::* backend.)

This code will provide a base from which people can use RDF::Trine
for querying and updating a RDF triplestore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18585] Connect to RDF triplestore

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

David Cook  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #28 from M. Tompsett  ---
Comment on attachment 73524
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73524
Bug 19817: Remove local help files + edit help feature

Review of attachment 73524:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19817=73524)
-

::: t/db_dependent/00-strict.t
@@ +19,4 @@
>  'catalogue', 'cataloguing',
>  'changelanguage.pl', 'circ',
>  'debian','docs',
> +'errors','fix-perl-path.PL',

But help.pl is no longer listed.

@@ -19,5 @@
>  'catalogue', 'cataloguing',
>  'changelanguage.pl', 'circ',
>  'debian','docs',
> -'edithelp.pl',   'errors',
> -'fix-perl-path.PL',  'help.pl',

help.pl is still here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #29 from M. Tompsett  ---
Preliminary testing was generally positive. Though, I think these points should
be discussed, if not addressed, before considering sign off.

- https vs http in the urls used.
- choice vs multiple in the added KohaManualLanguage sys pref
- help.pl removed from 00-strict.t
- postfix slash the default URL creates a // in the URL.
  remove the '/' in the URL building in Koha::Manual?
  build smarter?

kshell
cd misc/translator
for i in `ls po | cut -f1-2 -d'-' | sed -e "s#-opac##g" | sed -e
"s#-pref.po##g" | sed -e "s#-staff##g" | sed -e "s#-marc##g" | sort -u`; do
echo $i;perl translate install $i;done
-- noisy! Though, I suspect correct.
perhaps help po files need to be deleted too?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

--- Comment #6 from M. Tompsett  ---
(In reply to Martin Renvoize from comment #0)
> if a user attempts to navigate
> directly to any of the ILL forms they are faced with an error rather than
> the standard login redirect.

Aaaah! That's the problem... okay, got it. Reproduced. YAY!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

--- Comment #7 from M. Tompsett  ---
When OpacPublic is Enabled, going directly to
 http://kohadev.mydnsname.org/cgi-bin/koha/opac-illrequests.pl
on a kohadevbox doesn't give the log in, but rather attempts to show the page.
It should always require log in for ILL requests.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

M. Tompsett  changed:

   What|Removed |Added

  Attachment #73847|0   |1
is obsolete||

--- Comment #8 from M. Tompsett  ---
Created attachment 73898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73898=edit
Bug 20536 - ILL: authnotrequired should be explicitly unset on opac

* koha/opac-illrequest.pl - Added explicit setting of authnotrequired

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

M. Tompsett  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20546

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20546] Shelving location not displayed on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20546

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18276

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20377] Add transaction and skip_merge to 'remove_unused_authorities.pl' script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20377

Mason James  changed:

   What|Removed |Added

Summary|Various speed tweaks to |Add transaction and
   |'remove_unused_authorities. |skip_merge to
   |pl' script  |'remove_unused_authorities.
   ||pl' script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20549] New: Avoid indexer race condition when moving item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20549

Bug ID: 20549
   Summary: Avoid indexer race condition when moving item
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20549] Avoid indexer race condition when moving item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20549

--- Comment #1 from Alex Buckley  ---
Created attachment 73899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73899=edit
WR 289187 - Avoid biblio index race condition after moving item

The moveitem.pl script loops through a 2 value array containing "new"
and "old". The first loop value "new" is handed as an optional argument
to the MoveItemFromBiblio() function in C4/Items.pm. This updates the
biblios and only reindexes the new biblio.

If a 1 if returned from the call to MoveItemFromBilio() to moveitem.pl
then the loop iterates through the second value in the array "old" this
calls the MoveItemFromBiblio() function as well but this time the
aforementioned function only does one thing which is add the old biblio
to the zebraqueue.

Due to calling the ModItemFromBiblio() function twice from two different
iterations of the loop in moveitem.pl there is a 1 second gap between
the new biblio and old biblio being added to the zebraqueue table.

This reduces the chances of a race condition of the old biblio being
indexed before the new biblio.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20534] Floating toolbar when editing vendors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20534

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Passed QA   |Failed QA

--- Comment #5 from Jonathan Druart  
---
Owen, same problem as we had on the patron edit page:
https://screenshots.firefox.com/pvWlqcxFqUDgRU0L/pro.kohadev.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

Shane Sammons  changed:

   What|Removed |Added

 CC||ssamm...@npelem.com

--- Comment #12 from Shane Sammons  ---
I just wanted to note that search result being relevant is an issue. I just
migrated from 3.20.00 to 17.11(Debian Packages on Ubuntu 16.04LTS) and I had to
change Trunction to require *, otherwise expected top results were mixed in the
results.

I don't care if it is a fix switching to other "stack", a patch to this issue,
or whatever, but I wanted to comment that something should be done.

Thankfully you are all a great community and super helpful so IRC chat helped
me learn about this bug and we turned it from auto to require * to get far
better search results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20406] Remove ISBD display

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20406

Jasimudeen  changed:

   What|Removed |Added

 CC||jasim...@gmail.com

--- Comment #11 from Jasimudeen  ---
Old is gold ! :)

Its better not to remove ISBD display.its a feature which makes Koha more
welcoming to Indian users.Forget the undocumented internal syntax for a while.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19804] Suspension calculation doesn't honor 'Suspension charging interval'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #25 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20122] Empty and close link on cart page not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20122

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #14 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds extra null fields to indexes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #18 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789

--- Comment #83 from Jonathan Druart  
---
Last patch pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204

--- Comment #5 from Katrin Fischer  ---
We are looking into it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #39 from Jonathan Druart  
---
Created attachment 73878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73878=edit
Bug 19289: (follow-up) Add existing fields to the ACQ framework

Changes for other frameworks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Readonly::XS version not detected

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

--- Comment #11 from M. Tompsett  ---
TEST PLAN
-

In your kohaclone directory run:
./koha_perl_deps.pl -a | grep Readonly::XS
-- There will be a "0 *" shown for the installed version

Apply the patch and repeat the above command.
-- There will be a valid version number shown.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #22 from Jonathan Druart  
---
Created attachment 73872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73872=edit
Bug 19817: Use the language from the interface if valid

Use the UI language for the manual, if exists. Use the pref as a
fallback.

With the call to get_template_and_user the value of preferred_language
switched from 'es' (spanish) to 'en' from one click to another (??)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #63 from Victor Grousset/tuxayo  ---
Created attachment 73873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73873=edit
Bug 12310 : Decimal separator issues: fixes in fines

The main goal is to prevent
- x100 or /100 of the amounts
- decimal part truncation

Fixes Bug 19521 - Partial fine payment is not working with comma decimal
separator

Bonuses:
- Gets rid of the spaces, currency symbols, names (EUR)
  There is nothing specific about currency symbols is this patch.
  It just removes everything that is not a digit a minus or a separator.

It handles:
- by default comma and dot as decimal separators on the same instance
- dot or comma as thousands separators if choose to use only one of them
as decimal separator. See DecimalSeparators syspref.
- minuses, doesn't remove them
- non-decimal values: it doesn't touch them

== Test plan ==
1. Use a translation of the staff interface if possible.
2. When you pay an existing fine (more details in the next steps if needed).
 Check that you can't enter any string except like "XX.XX" (examples in
 Annex 1) without having an issue after validation. (x100,
 truncation, etc)
3. Apply this patch
4. run ~/src/installer/data/mysql/updatedatabase.pl
5. In the manual invoice (cgi-bin/koha/members/maninvoice.pl)
6. Apply the annex 1 to the "Amount" field
7. When paying a fine (cgi-bin/koha/members/paycollect.pl)
8. Click on "Pay amount" to go to the page to pay all fines
9. Apply the annex 1 to the "Collect from patron" field
10. Click on "Pay" to go to the page to pay fine
11. Apply the annex 1 to the "Collect from patron" field
12. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl)
13. Apply the annex 1 to the "Amount" field
14. If you have ideas of stuff to try to find *regressions* from the previous
versions, then try. You might spare librarian tears by finding something
before it's released. (and prevent me from having bounty on my head)
15. Express your happiness. This is important, otherwise the sign off spell
won't
work! The details of expressing your happiness depend on your culture and
habits.

=== Annex 1: Subpart for each concerned page ===
1. Set DecimalSeparators syspref to ",."
2. Input "12,34"
3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the
 conversion. Validating the form does the same but it's a trick to test
more
 quickly by not switching to another page.
4. The value should have been converted to 12.34
5. What follows is just a list of examples. They don't have to be tried on each
 field.
6. Do the same with "12,34 EUR" and ensure that it's converted to "12,34"
7. Same with "EUR 12.34" -> "12.34"
8. "EUR 12.34€hi lyonthree" -> "12.34"
9. "123 456,7" -> "123456.7"
10. "2" -> "2"
11. "2,0" -> "2.0"
12. "-1'345.95" -> "-1345.95"
13. ",1234" -> ".1234"
14. Set DecimalSeparators syspref to ","
15. Reload the page with the form
16. "1.000" -> "1000"
17. "1.000.000,10" -> "100.10"
18. Set DecimalSeparators syspref to "."
19. Reload the page with the form
20. "1,000" -> "1000"
21. "1,000,000.10" -> "100.10"
22. Validate the form and check that the final value with the dot was
  well handled.
23. Think about Koalas and smile. 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

--- Comment #64 from Victor Grousset/tuxayo  ---
Created attachment 73874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73874=edit
Bug 12310 : Follow up to keep the example text in fines

This puts the example text back in with the correct decimal
separator. The example uses the first char of the syspref.

TEST PLAN
-
1) set the I18N/L10N DecimalSeparators syspref to ","
2) go to a patron's fines tab.
3) open Create manual invoice and Create manual credit tabs
4) check both tabs
   -- Example: 5.00 appears
5) apply this patch
6) reload the page and check both create tabs.
   -- Example: 5,12 appears
7) set the I18N/L10N DecimalSeparators syspref to ".,"
8) go back and check both tabs.
   -- Example: 5.12 appears (only the first separator is picked)
9) optionnal: run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #73874|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #73784|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #73785|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12310] Accept different monetary formats as input

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #73874|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518

--- Comment #6 from Katrin Fischer  ---
I think this is a good cosmetic fix, but we could rethink removing some in
favor of the existing button separately. That said, I think the add link makes
sense when there are already some messages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20546] Shelving location not displayed on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20546

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73850|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 73900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73900=edit
Bug 20546: Display shelving location on checkin

Currently, the sehlving location is not being displayed in the table
of checked in items on /cgi-bin/koha/circ/returns.pl

To test:
- Make sure you have a couple of books with a value for shelving location
(952$c)
- Check the books out
- Check the books in
- Verify nothing is displayed in the "Shelving location" column
- Apply this patch
- Check the books out and in again
- Verify the shelving location is now being displayed

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20546] Shelving location not displayed on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20546

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #50 from Julian Maurice  ---
Patches do not apply on master. Please rebase.

> Applying: Bug 17981: Move svc/letters to svc/letters/get
> Applying: Bug 17981: Add a 'letter' param to GetPreparedLetter
> Applying: Bug 17981: Add a preview mode for notice templates
> error: sha1 information is lacking or useless (C4/Letters.pm).
> error: could not build fake ancestor
> Patch failed at 0001 Bug 17981: Add a preview mode for notice templates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123

--- Comment #21 from Katrin Fischer  ---
I've tried it with the example from the commit message in Firefox and Chromium
and no problems found (without patch). Maybe something is missing from the test
plan?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8000] Test mode for notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion
 CC||julian.maur...@biblibre.com

--- Comment #132 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #131)
> (In reply to ByWaterSandboxes from comment #130)
> > It does not affect messages in the message_queue.
> 
> So it's not "all emails" :)
> I was going to fail QA this patch because I was testing overdue notices.
> 
> However it seems that is was the first intention of this patch (see first
> patch, in comment 3). Why did you change your mind?

This comment needs an answer. Changing status to In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #40 from Katrin Fischer  ---
Looks ok, but I think you missed pl-PL in the last follow-up?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #56 from Katrin Fischer  ---
The third patch won't apply, can you please take a look?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19287: Add ability to mark an item 'Lost' from 'Holds to pull'
list
Applying: Bug 19287: Fix conflict with bug 19304
Applying: Bug 19287: Fix conflict with bug 19974
error: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref).
error: could not build fake ancestor
Patch failed at 0001 Bug 19287: Fix conflict with bug 19974
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-19287-Fix-conflict-with-bug-19974-Ayu3UB.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED
 CC||julian.maur...@biblibre.com

--- Comment #35 from Julian Maurice  ---
Changing status to BLOCKED as it depends on a "does not apply" bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310

--- Comment #7 from Marcel de Rooy  ---
(In reply to Maksim Sen from comment #4)
> Created attachment 73805 [details] [review]
> Bug 20310: Introduce Koha::Biblio->host_record
> 
> This is a more generic method that allows you to get to the host record
> as defined in MARC21 field 773$w.
> 
> Test plan:
> Run t/db_dependent/Koha/Biblio/host_record.t
> 
> Signed-off-by: Marcel de Rooy 
> Signed-off-by: Maksim Sen 

Maksim: You only signed off one record ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20539] Warnings in catalogue/search.pl need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539

Julian Maurice  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||julian.maur...@biblibre.com
   Assignee|koha-b...@lists.koha-commun |julian.maur...@biblibre.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20544] New: Wrong comment in items.itemnotes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20544

Bug ID: 20544
   Summary: Wrong comment in items.itemnotes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Database
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pasi.kalli...@joensuu.fi
QA Contact: testo...@bugs.koha-community.org

kohastructure.sql has a wrong comment on items.itemnotes, claiming it is MARC21
952$x, when it should be 952$z

kohastructure.sql:

  `itemnotes` LONGTEXT, -- public notes on this item (MARC21 952$x)


marc21_framework_DEFAULT.sql:
  ('952', 'x', 'Non-public note', 'Non-public note', 0, 0,
'items.itemnotes_nonpublic' ...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20539] Warnings in catalogue/search.pl need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20406] Remove ISBD display

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20406

Indranil Das Gupta  changed:

   What|Removed |Added

 CC||indr...@l2c2.co.in

--- Comment #7 from Indranil Das Gupta  ---
I disagree and with good reason! yes, agreed that the way it is implemented is
not in the best possible manner. 

The ISBD display support is one of the __MAJOR__ reason that has allowed the
massive use of Koha across the entire Indian sub-continent. Without the ISDB
display (and I do not mean the code) as an option on the OPAC and staff client,
Koha will stand to lose the position of de-facto choice. many libraries here
have infact use the ISBD display as the primary display.

So, yes I don't mind a code upgrade / cleanup. But that display is *needed* and
needs to stay. Koha users are not all from the 1st world countries and
thousands are still using AACR2 instead of RDA.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310

--- Comment #6 from Marcel de Rooy  ---
(In reply to paxed from comment #5)
> Comment on attachment 73805 [details] [review]
> Bug 20310: Introduce Koha::Biblio->host_record
> 
> Shouldn't this also check that the 003 fields match? AFAIUI, 001+003 is
> unique, 001 is not guaranteed to be - because you could import data from
> different organization.

Not sure if this is done consistently in Koha, but sounds good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20539] Warnings in catalogue/search.pl need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539

--- Comment #1 from Julian Maurice  ---
Created attachment 73849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73849=edit
Bug 20539: Remove warnings in catalogue/search.pl

Test plan:
1. Start a search from intranet
2. See several warnings in logs
3. Apply patch (&& reload starman)
4. Start a new search
5. Confirm that warnings are gone and that the search still works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/