[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589

Andrew Isherwood  changed:

   What|Removed |Added

 Depends on||20651


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651
[Bug 20651] Improve display of "Toggle full supplier metadata"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20651] Improve display of "Toggle full supplier metadata"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651

Andrew Isherwood  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Depends on||7317
   Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ
   |ity.org |e.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Andrew Isherwood  changed:

   What|Removed |Added

 Blocks||20651


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651
[Bug 20651] Improve display of "Toggle full supplier metadata"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20651] New: Improve display of "Toggle full supplier metadata"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651

Bug ID: 20651
   Summary: Improve display of "Toggle full supplier metadata"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: ILL
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andrew.isherw...@ptfs-europe.com

Currently, any additional metadata supplied by an ILL supplier that doesn't fit
into our "core" set of metadata is just appended to the bottom of the page
behind a "Toggle full supplier metadata" link. We should improve this, probably
utilising a modal, as per "MARC preview" in Cataloguing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #74806|0   |1
is obsolete||

--- Comment #2 from Martin Renvoize  ---
Created attachment 74811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74811=edit
Bug 20639: Add ILLOpacbackends syspref

This adds the ILLOpacbackends syspref, allowing users to refine the ill
backends available to opac users for initiating ill requests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20649] C4::Auth should use C4::Context->IsSuperLibrarian()

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649

Jonathan Druart  changed:

   What|Removed |Added

 Status|REOPENED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20649] C4::Auth should use C4::Context->IsSuperLibrarian()

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649

Jonathan Druart  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |---

--- Comment #3 from Jonathan Druart  
---
Actually yes, userenv is set in checkauth which has been called few lines
above.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20646] "ILL Request" menu options not displayed when user has superlibrarian permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20646

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #74797|0   |1
is obsolete||

--- Comment #3 from Martin Renvoize  ---
Created attachment 74810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74810=edit
Bug 20646: ILL Request menu should be visible for superlibrarian

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|7317|
 CC||martin.renvoize@ptfs-europe
   ||.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|18589   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
[Bug 18589] Show ILLs as part of patron profile
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20649] C4::Auth should use C4::Context->IsSuperLibrarian()

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Resolution|--- |INVALID

--- Comment #2 from Jonathan Druart  
---
No, C4::Context->IsSuperlibrarian tells if the logged in user has the
superlibrarian flags.
In C4::Auth::get_template_and_user the user is not logged in yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #31 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #30)
> I've tried again, same result:
> 
>  FAIL koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc
>OK   forbidden patterns
>OK   git manipulation
>OK   spelling
>OK   tt_valid
>FAIL valid_template
>   The method quick_add_display is not covered by tests!

Hum, this looks like a false positive. If you do not recreate the problem using
the interface I'd ignore it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589

--- Comment #2 from Andrew Isherwood  ---
Dependencies have been added to reflect other pending patches that touch
ill-requests.tt, which has been substantially refactored here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Andrew Isherwood  changed:

   What|Removed |Added

 Blocks||18589


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
[Bug 18589] Show ILLs as part of patron profile
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Andrew Isherwood  changed:

   What|Removed |Added

 Blocks||18589


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
[Bug 18589] Show ILLs as part of patron profile
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589

Andrew Isherwood  changed:

   What|Removed |Added

 Depends on||20548, 20600, 20581, 20563


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548
[Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563
[Bug 20563] ILL request list gives no indication of source and/or target
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581
[Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600
[Bug 20600] Provide the ability for users to filter ILL requests
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548

Andrew Isherwood  changed:

   What|Removed |Added

 Blocks||18589


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
[Bug 18589] Show ILLs as part of patron profile
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563

Andrew Isherwood  changed:

   What|Removed |Added

 Blocks||18589


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
[Bug 18589] Show ILLs as part of patron profile
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589

--- Comment #1 from Andrew Isherwood  ---
Created attachment 74809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74809=edit
Bug 18589: Show ILLs as part of patron profile

This patch moves the display of a patron's ILL requests to be inline in
the Patron Profile page, as per all other patron information.

It includes a substantial refactor of
koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it
moves the display of the illlist table (which is populated by an API
request) into it's own separate include file. It also moves the
datatable related Javascript for this table into it's own JS file. Doing
this allows us to reuse both in both the new members/ill-requests.tt
template and the pre-existing ill/ill-requests.tt template.

To test:
1) Ensure ILL is enabled and your user has sufficient permissions
2) Ensure your user has some ILL requests
3) Navigate to the user's patron profile page
4) Click on the "Interlibrary loans" tab
5) Observe that the requests table is displayed inline
6) Observe that only your user's requests are displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589

Andrew Isherwood  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20407] Hide some fields from unauthorized users

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20407

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard  changed:

   What|Removed |Added

 CC||cnighswon...@foundations.ed
   ||u

--- Comment #1 from Owen Leonard  ---
*** Bug 7906 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7906] Optimize the order of styles and scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7906

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 17858 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18593] Suggestions aren't updated when one biblio is merged with another

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #13 from Fridolin SOMERS  ---
Pushed to 17.05.x for 17.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20217] Make header's catalog search menu into a split button

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20217] Make header's catalog search menu into a split button

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217

Owen Leonard  changed:

   What|Removed |Added

  Attachment #73335|0   |1
is obsolete||
  Attachment #73336|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  ---
Created attachment 74807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74807=edit
Bug 20217: Make header's catalog search menu into a split button

This patch modifies the markup for the staff client header's catalog
search menu so that it mimics the behavior of a Bootstrap split button
(As seen on the cataloging home page's 'New from Z39.50' button).

To test, apply the patch, run 'yarn build' to regenerate the staff
client's CSS, and clear your browser cache.

- View any page in the staff client.
- Hover your mouse over the "Search" link in the header. It should
  trigger a hover affect on the adjacent menu link.
- Clicking the "Search" link should take you directly to the advanced
  search page.
- Clicking the adjacent menu link should display a menu containing links
  to advanced search and item search.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20217] Make header's catalog search menu into a split button

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217

--- Comment #8 from Owen Leonard  ---
Created attachment 74808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74808=edit
Bug 20217: (follow up) Compiled CSS

This patch contains the compiled CSS.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11936] Consistent log message for item insert

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #12 from Fridolin SOMERS  ---
Pushed to 17.05.x for 17.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639

--- Comment #1 from Martin Renvoize  ---
Created attachment 74806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74806=edit
Bug 20639: Add ILLOpacbackends syspref

This adds the ILLOpacbackends syspref, allowing users to refine the ill
backends available to opac users for initiating ill requests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20607] Elasticsearch - ability to add a relevancy weight in mappings.yaml file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607

--- Comment #2 from Alex Arnaud  ---
Created attachment 74805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74805=edit
Bug 20607 - Make
Koha::SearchEngine::Elasticsearch::reset_elasticsearch_mappings take weight
into account

Test plan:
  - apply BZ 18316 and this one,
  - update DB and schema files,
  - edit admin/searchengine/elasticsearch/mappings.yaml
to add weight for some fields,
  - go to admin > search engine configuration,
  - reset your mappings (add ?op=reset_know_what_i_am_doing=1 to url),
  - check that weights you've added are set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20607] Elasticsearch - ability to add a relevancy weight in mappings.yaml file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607

Alex Arnaud  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20383] Hide link to plugin management if plugins are not enabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20383

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin SOMERS  ---
Pushed to 17.05.x for 17.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20650] New: Switch single-column templates to Bootstrap grid: Various, part 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650

Bug ID: 20650
   Summary: Switch single-column templates to Bootstrap grid:
Various, part 3
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 19980

This patch will convert several unrelated templates to use the Bootstrap grid:

- patroncards/print.tt
- patron_lists/add-modify.tt
- plugins/plugins-disabled.tt
- plugins/plugins-upload.tt
- tools/tools-home.tt
- virtualshelves/merge.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980
[Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980

Owen Leonard  changed:

   What|Removed |Added

 Depends on||20650


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650
[Bug 20650] Switch single-column templates to Bootstrap grid: Various, part 3
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

--- Comment #47 from Ere Maijala  ---
Oops, now fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Ere Maijala  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Ere Maijala  changed:

   What|Removed |Added

  Attachment #74227|0   |1
is obsolete||

--- Comment #46 from Ere Maijala  ---
Created attachment 74804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74804=edit
Bug 14716: URI-encode URLs in MARC21 xsl templates.

https://bugs.koha-community.org/show_bug.cgi?id=14716

Test plan:

1. Catalog a record with series name "Series & more"
2. Find the record
3. Make sure clicking the "Series & more" link works and the ampersand is
properly encoded in the URL.
4. Also try the attached test records and make sure their links work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20641] Switch single-column templates to Bootstrap grid: Various, part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20641] Switch single-column templates to Bootstrap grid: Various, part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641

--- Comment #1 from Owen Leonard  ---
Created attachment 74803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74803=edit
Bug 20641: Switch single-column templates to Bootstrap grid: Various, part 2

This patch updates various unrelated templates to use the Bootstrap
grid. In each case, confirm that the indicated page looks correct.

 - Acquisitions -> Vendor -> Add to basket -> From a staged file.
 - Logged-in user menu (in the upper right) -> Search history.
 - With plugins disabled in koha-conf.xml, go to Tools -> Tools plugins.
 - With the EasyAnalyticalRecords system preference set to 'Display,'
   view a bibliographic record.
   - Choose Edit -> Link to host item.
   - Submit a barcode to be linked.
 - Configure a MARC subfield (e.g. 100$a) to use the
   unimarc_field_225a_bis plugin.
   From the MARC edit page, trigger the plugin and confirm that the
   page in the popup window looks correct. Confirm that changes made in
   the popup window are saved to the corresponding field in the editor.
 - Administration -> Funds -> Edit a fund.
   - Click 'Select owner.'
   - Search for a patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171

Owen Leonard  changed:

   What|Removed |Added

  Attachment #74710|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  ---
Created attachment 74802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74802=edit
Bug 19171: Attempt to make "no holds possible" messages less confusing

At the moment, when no holds are possible, the OPAC reads something
like:

Sorry, none of these items can be placed on hold.
No items available.

This is confusing to the patrons, because the records have items,
but they are not showing. The record also may have available items,
they are just not permitted to place holds on them.

Changes:
- Only display the first message, when somoene tried unsuccessfully
  to place holds on multiple records.
- Change first message to: Sorry, none of these titles can be placed on hold.
- Change the second message to read:
  No items available to be placed on hold.
- Remove  around Sorry for better translatability.

To test:
- Try to place a hold on single record, where no hold is possible.
- Try to place a hold on a single record, where a hold is possible.
- Try to place holds on multiple records where no hold is possible.
- Try to place holds on multiple records where at least one hold
  is possible.

  Verify the screen messages make sense in all cases.

https://bugs.koha-community.org/show_bug.cgi?id=14716

Fixed stray  during signoff.
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19171] Confusing message "no items available" when placing a hold in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calendar into account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calendar into account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74780|0   |1
is obsolete||

--- Comment #22 from Tomás Cohen Arazi  ---
Created attachment 74801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74801=edit
Bug 19204: Add tests for new days_mode parameter

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calendar into account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74779|0   |1
is obsolete||

--- Comment #21 from Tomás Cohen Arazi  ---
Created attachment 74800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74800=edit
Bug 19204: Add a test: holiday is expiration date

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calendar into account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74777|0   |1
is obsolete||

--- Comment #19 from Tomás Cohen Arazi  ---
Created attachment 74798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74798=edit
Bug 19204: Make the debarment date calculation depends on finesCalendar

This patchs adds the ability to calculate the end of the suspension date
(debarment date) using the finesCalendar syspref.
Prior to this patch it was never calculating without taking into account
the calendar.

calculated without taking holidays into account.
This was a problem because the restriction could end in the middle of a
period the library is closed.

Test plan:
- Set finescalendar to 'not including days the library is closed'
- Set a circulation condition with no fine/maxfine, but fine days and
max fine days instead
- Check out an item with a due date in the past
- Check the item in and verify the restriction date
- Clean the restriction

- Add holidays to your calendar on the calculated restriction date
- Check the item out again with the same due date in the past
- Check in the item again
- Verify the calculated restriction end date has changed, it's set to the day
after the holiday.

Fines in days restriction calculation is correctly taking calendar
into account.

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calendar into account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74778|0   |1
is obsolete||

--- Comment #20 from Tomás Cohen Arazi  ---
Created attachment 74799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74799=edit
Bug 19204: Clean the tests a bit to reuse the same pattern

The same pattern is used several times in test:
checkout, checkin, get the debarment, compare the dates and remove the
debarment.
Let's move that to a separate subroutine

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11249] Add db indexes on borrowers names

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249

Fridolin SOMERS  changed:

   What|Removed |Added

  Attachment #74372|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20646] "ILL Request" menu options not displayed when user has superlibrarian permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20646

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20646] "ILL Request" menu options not displayed when user has superlibrarian permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20646

--- Comment #1 from Martin Renvoize  ---
Created attachment 74797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74797=edit
Bug 20646: ILL Request menu should be visible for superlibrarian

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20646] "ILL Request" menu options not displayed when user has superlibrarian permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20646

--- Comment #2 from Martin Renvoize  ---
Thanks for the pointer Katrin

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20649] C4::Auth should use C4::Context->IsSuperLibrarian()

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649

--- Comment #1 from Katrin Fischer  ---
Probably here too, noting that on bug 20515:

 297 if ( $flags && $flags->{superlibrarian} == 1 ) {
 298 $template->param( CAN_user_circulate=> 1 );

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515

--- Comment #17 from Katrin Fischer  ---
I think we miss a change in Auth.pm:

 297 if ( $flags && $flags->{superlibrarian} == 1 ) {
 298 $template->param( CAN_user_circulate=> 1 );

And that should probably use IsSuperLibrarian()for the check (see bug 20649)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20649] C4::Auth should use C4::Context->IsSuperLibrarian()

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20479] Superlibrarians cannot log into opac

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||20649


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649
[Bug 20649] C4::Auth should use C4::Context->IsSuperLibrarian()
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20649] New: C4::Auth should use C4::Context->IsSuperLibrarian()

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649

Bug ID: 20649
   Summary: C4::Auth should use C4::Context->IsSuperLibrarian()
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org
Depends on: 20479

We had a lot of trouble with superlibrarian checks in the past, which is why we
introduced C4::Context->IsSuperLibrarian(). C4::Auth should use it instead of:

06 && $flags && $flags->{superlibrarian} != 1

http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=C4/Auth.pm;h=e0cbbc567746dbce7415253f966ce227c58956d7;hp=1b24c4fdb10f746ff81184b6f6edbff17eb4a3d8;hb=d8b3497368b839e4fc594661719351efbe3433cc;hpb=51d7a02726b81b28325f7a151c8670e2f2293f71


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479
[Bug 20479] Superlibrarians cannot log into opac
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20648] Attribute option "Display in check-out" should be rename

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #14 from Séverine Queune  ---
(In reply to Josef Moravec from comment #13)
> (In reply to Séverine Queune from comment #12)
> > Attributes checked "Display in check-out" are now displayed on side panel of
> > all tabs in patron account (that's useful).
> > 
> > Maybe the description of this option on the "Attribute menu" should be
> > modifiy now.
> > "Display in check-out: Check to show this attribute in patron check-out."
> > --> "Display in patron's brief information" ?
> 
> Definitely makes sense to me, would you mind to fill a bug for this?

No problem ! Done with Bug 20648.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20648] New: Attribute option "Display in check-out" should be rename

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648

Bug ID: 20648
   Summary: Attribute option "Display in check-out" should be
rename
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: severine.que...@bulac.fr
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Attributes checked "Display in check-out" are now displayed on side panel of
all tabs in patron account thanks to Bug 12159.

The description "Display in check-out: Check to show this attribute in patron
check-out" on the "Attribute menu" should be modifiy now.
--> "Display in patron's brief information" ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Pedro Amorim  changed:

   What|Removed |Added

 CC||pjamori...@gmail.com

--- Comment #268 from Pedro Amorim  ---
Hello everyone, after using this feature I noticed that e-mails are not being
sent for patrons upon status update for the article requests.

I checked the database and the to_address field is NULL in the message_queue
table.

Could it be that we need to define

to_address => $borrower{'email'},
from_address =>   C4::Context->preference('KohaAdminEmailAddress'),

in the EnqueueLetter call in

https://github.com/Koha-Community/Koha/blob/master/Koha/ArticleRequest.pm#L124

Or am I missing something else?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #13 from Josef Moravec  ---
(In reply to Séverine Queune from comment #12)
> Attributes checked "Display in check-out" are now displayed on side panel of
> all tabs in patron account (that's useful).
> 
> Maybe the description of this option on the "Attribute menu" should be
> modifiy now.
> "Display in check-out: Check to show this attribute in patron check-out."
> --> "Display in patron's brief information" ?

Definitely makes sense to me, would you mind to fill a bug for this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||20647


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647
[Bug 20647] When ILL is enabled the hover effect on the ILL requests button is
wrong.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the ILL requests button is wrong.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||7317


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20647] New: When ILL is enabled the hover effect on the ILL requests button is wrong.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647

Bug ID: 20647
   Summary: When ILL is enabled the hover effect on the ILL
requests button is wrong.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The Icon part of the button on the main staff client page does not highlight
with the text for the ILL requests button the same was as it does for all other
module buttons on that page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17449] Let users choose action in self checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17449

Magnus Enger  changed:

   What|Removed |Added

  Attachment #57996|0   |1
is obsolete||

--- Comment #5 from Magnus Enger  ---
Created attachment 74796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74796=edit
Bug 17449 - Let users choose action in self checkout

Currently if you have a stack of 15 books that you want to renew
through the self checkout, you need to read the barcode of each
item and then click "renew" for each of them. Same for returning
books. One of my customers wants to change the SCO screen so that
users can choose the action they want to take up front, then
let them do the 15 renewals by just scanning the barcodes.

This patch uses "Bootstrap tabs". I tried using "jQuery tabs", in
a similar way to how it is done in e.g. record detail display in the
OPAC. This resulted in weird conflicts between jQuery and Bootstrap,
hence the use of Bootstrap for the final patch.

To test:
- Apply this patch
- Make sure self check is enabled
- Log in to self check
- Process some barcodes, first by borrowing, then renewing, then
  returning. Verify that the selected tab is still active and has
  focus after each barcode has been processed.
- Now try "illegal" actions and check that you get appropriate
  responses:
  - Try to borrow a barcode you have already borrowed.
  - Try to return a barcode that you have not already borrowed.
  - Etc.
- Try this with and without AllowSelfCheckReturns

2018-04-24: Fixed conflicts and problems with renew and return.

Sponsored-by: Hylte Public Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17449] Let users choose action in self checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17449

Magnus Enger  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|20646   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20646
[Bug 20646] "ILL Request" menu options not displayed when user has
superlibrarian permission
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20646] "ILL Request" menu options not displayed when user has superlibrarian permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20646

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|7317|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||20646


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20646
[Bug 20646] "ILL Request" menu options not displayed when user has
superlibrarian permission
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20646] New: "ILL Request" menu options not displayed when user has superlibrarian permission

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20646

Bug ID: 20646
   Summary: "ILL Request" menu options not displayed when user has
superlibrarian permission
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: ILL
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
CC: andrew.isherw...@ptfs-europe.com,
jonathan.dru...@bugs.koha-community.org,
katrin.fisc...@bsz-bw.de,
martin.renvo...@ptfs-europe.com
Depends on: 7317, 20515

If the user has 'superlibrarian' permission, the menu is missing :(


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515
[Bug 20515] "ILL Request" menu options displayed when user has no ILL
permissions
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||20646


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20646
[Bug 20646] "ILL Request" menu options not displayed when user has
superlibrarian permission
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15486] Restrict number of holds placed by day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||severine.que...@bulac.fr

--- Comment #58 from Séverine Queune  ---
I can't apply the patch on master branch 17.12.00.037 :

Bug 15486 - Restrict number of holds placed by day

71314 - Bug 15486: DB structure change
71315 - Bug 15486: DBIC update
71316 - Bug 15486: Unit tests
71317 - Bug 15486: Extend CanItemBeReserved so it handles daily holds limits
71318 - Bug 15486: Modify request.tt to handle the new error string
72709 - Bug 15486: Make circ rules UI handle holds_per_day

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 15486: DB structure change
Applying: Bug 15486: DBIC update
Using index info to reconstruct a base tree...
M   Koha/Schema/Result/Issuingrule.pm
Falling back to patching base and 3-way merge...
Auto-merging Koha/Schema/Result/Issuingrule.pm
CONFLICT (content): Merge conflict in Koha/Schema/Result/Issuingrule.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 15486: DBIC update
The copy of the patch that failed is found in:
   /var/repositories/koha/.git/rebase-apply/patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20444] Remove C4::Members::Attributes::GetAttributes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20444

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #13 from Séverine Queune  ---
I tried with several notices (predue, suggestion accepted, article request
completed) and it always worked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20444] Remove C4::Members::Attributes::GetAttributes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20444

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74789|0   |1
is obsolete||

--- Comment #11 from Séverine Queune  ---
Created attachment 74794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74794=edit
Bug 20444: Update test

0) Apply this patch
1) prove t/db_dependent/Members/Attributes.t
should return green

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20444] Remove C4::Members::Attributes::GetAttributes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20444

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20444] Remove C4::Members::Attributes::GetAttributes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20444

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74788|0   |1
is obsolete||

--- Comment #10 from Séverine Queune  ---
Created attachment 74793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74793=edit
Bug 20444: Use Koha::Patron::Attribute::Types object for getting patron
attributes in letter.pl

Test plan:
0) Apply the patch
1) Do not have any patron attribute types defined
2) Go to Tools -> Notices and slips
3) Edit any slip/letter which uses table borrower
4) Confirm the editing works, and the slip/letter itself works
5) Add some patron attributes types and define them a value for any
patron
6) Go to Tools -> Notices and slips and edit any slip/letter which uses
table borrower
7) Confirm, the attributes are listed in available fields
8) Confirm the slip/letter is working when you add a attribute to it

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20444] Remove C4::Members::Attributes::GetAttributes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20444

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74790|0   |1
is obsolete||

--- Comment #12 from Séverine Queune  ---
Created attachment 74795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74795=edit
Bug 20444: Remove sub GetAttributes

0) Apply this patch
1) git grep GetAttributes should return no occurencies

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310

paxed  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #19 from paxed  ---
in Koha/Biblio.pm, you have:

my $marc = C4::Biblio::GetMarcBiblio($self->biblionumber);

but in C4/Biblio.pm, GetMarcBiblio does this:

my $biblionumber = $params->{biblionumber};

causing:

Can't use string ("11") as a HASH ref while "strict refs" in use at
/usr/share/koha/lib/C4/Biblio.pm line 1131.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer where the destination is the same as the source

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344

--- Comment #5 from Victor Grousset/tuxayo  ---
Forget, the previous comments. I was confused when rereading the test plans and
though bug 19530 wasn't in master at that time.

(marking the comments as obsolete)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

--- Comment #12 from Séverine Queune  ---
Attributes checked "Display in check-out" are now displayed on side panel of
all tabs in patron account (that's useful).

Maybe the description of this option on the "Attribute menu" should be modifiy
now.
"Display in check-out: Check to show this attribute in patron check-out."
--> "Display in patron's brief information" ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer where the destination is the same as the source

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344

--- Comment #4 from Victor Grousset/tuxayo  ---
bug 19530#24

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer where the destination is the same as the source

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344

--- Comment #3 from Victor Grousset/tuxayo  ---
Thanks to #19530, the first transfer should be cancelled, resolving half of the
issue. See #19530#24

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74781|0   |1
is obsolete||

--- Comment #10 from Séverine Queune  ---
Created attachment 74791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74791=edit
Bug 12159: Fix getting extended patron attributes for circ-menu

Changes:
- Replace getting preference ExtendedPatronAttributes by Koha.Preference
in templates
- Add Koha::Patron->attributes for getting patrons extended attributes
- Use this method in circ-menu.inc
- Remove getting attributes from members perl scripts

Test plan:
0) Apply the patch
1) Add some patron attributes type - with free text, authorised value,
limited by libraries...
2) Add some values to this attributes for some patrons
3) Go through as many patron pages as you can and confirm that
attributes are shown at side panel when they shoul and are not shown
when they should not be shown

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74782|0   |1
is obsolete||

--- Comment #11 from Séverine Queune  ---
Created attachment 74792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74792=edit
Bug 12159: Add tests

Test plan:
prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20372] Correct toolbar markup on some pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20372

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #7 from Fridolin SOMERS  ---
Pushed to 17.05.x for 17.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20444] Remove C4::Members::Attributes::GetAttributes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20444

--- Comment #9 from Josef Moravec  ---
(In reply to M. Tompsett from comment #5)
> Comment on attachment 73083 [details] [review]
> Bug 20444: Use Koha::Patron::Attribute::Types object for getting patron
> attributes in letter.pl
> 
> Review of attachment 73083 [details] [review]:
> -
> 
> ::: tools/letter.pl
> @@ +463,4 @@
> >  }
> >  }
> >  if ($table eq 'borrowers') {
> > +my $attribute_types = Koha::Patron::Attribute::Types->search;
> 
> This let's you loop like an array, but it isn't ordered by code as far as I
> can tell. Feel free to correct me. Does this need to be code equivalent? Or
> just similar functionally?
> 
> @@ -462,4 @@
> >  }
> >  }
> >  if ($table eq 'borrowers') {
> > -if ( my $attributes = C4::Members::Attributes::GetAttributes() ) {
> 
> This is a sorted array of codes...

Fixed for preserving functionality

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20444] Remove C4::Members::Attributes::GetAttributes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20444

--- Comment #7 from Josef Moravec  ---
Created attachment 74789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74789=edit
Bug 20444: Update test

0) Apply this patch
1) prove t/db_dependent/Members/Attributes.t
should return green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20444] Remove C4::Members::Attributes::GetAttributes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20444

--- Comment #8 from Josef Moravec  ---
Created attachment 74790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74790=edit
Bug 20444: Remove sub GetAttributes

0) Apply this patch
1) git grep GetAttributes should return no occurencies

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20444] Remove C4::Members::Attributes::GetAttributes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20444

Josef Moravec  changed:

   What|Removed |Added

  Attachment #73083|0   |1
is obsolete||
  Attachment #73084|0   |1
is obsolete||
  Attachment #73085|0   |1
is obsolete||

--- Comment #6 from Josef Moravec  ---
Created attachment 74788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74788=edit
Bug 20444: Use Koha::Patron::Attribute::Types object for getting patron
attributes in letter.pl

Test plan:
0) Apply the patch
1) Do not have any patron attribute types defined
2) Go to Tools -> Notices and slips
3) Edit any slip/letter which uses table borrower
4) Confirm the editing works, and the slip/letter itself works
5) Add some patron attributes types and define them a value for any
patron
6) Go to Tools -> Notices and slips and edit any slip/letter which uses
table borrower
7) Confirm, the attributes are listed in available fields
8) Confirm the slip/letter is working when you add a attribute to it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #90 from Séverine Queune  ---
Feature works fine.
A detail : maybe the pull down menu is too far from the selected line (1 or 2
lines down). I can't remember exactly what the first feature looked like.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74040|0   |1
is obsolete||

--- Comment #89 from Séverine Queune  ---
Created attachment 74787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74787=edit
Bug 12747: Adjustment to Z39.05 search template

Removed some old columns that were moved in a previous patch and brought back
in while rebasing.
Also moved the additionnal fields column to the left of the action columns, so
the pull down menu
stays at the far right of the line.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74039|0   |1
is obsolete||

--- Comment #88 from Séverine Queune  ---
Created attachment 74786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74786=edit
Bug 12747: (follow-up) Removed unwanted tab character and fixed typo in tests

Removed a typo introduced while adding missing `use t::lib::Mocks ...` to
Breeding.t
Also removed tab character from z3950_search.tt

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589

Andrew Isherwood  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||andrew.isherwood@ptfs-europ
   ||e.com
   Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ
   |ity.org |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74037|0   |1
is obsolete||

--- Comment #87 from Séverine Queune  ---
Created attachment 74785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74785=edit
Bug 12747: Switch date field on marc flavour

Amended _add_rowdata to check only for the marcflavour-appropriate date field.
This makes the test pass without noise.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Séverine Queune  changed:

   What|Removed |Added

  Attachment #72981|0   |1
is obsolete||

--- Comment #85 from Séverine Queune  ---
Created attachment 74783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74783=edit
Bug 12747 - Add extra column in Z3950 search

This is a complete squash of previous patches, with additional code quality
improvments following M. Tompsett's feedback. Squashing was done (as suggested)
because many lines add be added and subsequently deleted, which made for
confusing patches.

New changes:
* Major enhancement to _add_custom_rowdata(), as suggested by QA. The $_
variable is no longer used (at all), and the split() routine is used.
* t/db_dependent/Breeding.t now uses the mocked preference logic to avoid
sysprefs being affected.

Functionality and test plan have not changed.

--

This patch makes it possible to add an extra column to Z3950 search results.
The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC
field/subfields are displayed in the column.

Testing:

I Apply the patch
II Run updatedatabase.pl

ACQUISITIONS
0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch
1) Create a new basket or use an existing one
2) In -Add order to basket-, click "From an external source"
3) Select some search targets and enter a subject heading ex. house
4) Click Search bouton
5) Validate "Additional fields" column with the field/subfield value.

CATALOGUING
0) Shares same syspref as above
1) Go to cataloguing, click New from z3950
2) Fill to result in a successful search
3) Validate column Addition Fields

Sponsored-by: CCSR (https://ccsr.qc.ca)
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #86 from Séverine Queune  ---
Created attachment 74784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74784=edit
Bug 12747 - Missing use in tests

Adds missing `use t::lib::Mocks ...` to Breeding.t

Tests should now pass correctly.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/