[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

--- Comment #12 from Katrin Fischer  ---
(In reply to David Cook from comment #11)
> (In reply to Katrin Fischer from comment #10)
> > (In reply to Sophie MEYNIEUX from comment #9)
> > > The field used for OpacSuppression should be set in a syspref : 942$n is
> > > used in marc21 but not in Unimarc
> > 
> > Could we hardcode a field for UNIMARC? You also need an index with a
> > specific name for it to work - would be good to have a default. Or have
> > harcoded values and a pref if they don't apply, with a warning that you have
> > to take care of indexing?
> > 
> > Anyway, we will need a new bug! :)
> 
> I'm thinking it's worthwhile having a database field for OpacSuppression,
> and then people can map the relevant MARC field using
> /cgi-bin/koha/admin/koha2marclinks.pl

It would be cleaner by fitting in better with existing patterns, but it
wouldn't solve the problem that you'd need an index defined. Having a
pre-defined index for UNIMARC could help people being able the feature in Koha
out of the box.

Btw. this bug has been fixed ages ago.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20660] AddReturn should use return date override for debarments

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |In Discussion

--- Comment #2 from M. Tompsett  ---
(In reply to David Bourgault from comment #1)
> Created attachment 74857 [details] [review]
> Bug 20660: AddReturn uses return_date override for new debarments
> 
> This patches is a minor tweak (single line) to C4::Circulation to use the
> return_date value as $today when calculating new debarments in AddReturn.
> 
> I've also added a test in t/db_dependent/Circulation.t
> 
> TEST PLAN
> 
> 1) comment out line 1988 in Circulation.pm ("$today = $return_date if
> $return_date")
> 2) prove t/db_dependent/Circulation.t (Fail)
> 3) uncomment the line
> 4) prove t/db_dependent/Circulation.t (Pass)

It is better to split the test from the change, so that when you want to prove
the problem you just apply the test. Then if you wish to prove the solution
also apply the second patch, and have the tests pass.

Should dropbox override the return date logic being added?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20663] Dead report code for "Create Compound Report" since prior to 3.0.x

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20663

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20663] Dead report code for "Create Compound Report" since prior to 3.0.x

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20663

--- Comment #2 from M. Tompsett  ---
Created attachment 74872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74872=edit
Bug 20663: Add some POD, so koha test tools don't complain

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20663] Dead report code for "Create Compound Report" since prior to 3.0.x

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20663

--- Comment #1 from M. Tompsett  ---
Created attachment 74871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74871=edit
Bug 20663: Remove dead code related to compound reports

TEST PLAN
-
git grep "Create Compound Report"
-- only one file
git grep compound | grep 1
-- this is the only setting of the compound tt variable
less koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
-- There is an TT IF statement for compound.
-- In that statement it would trigger 'Save Compound'
git grep save_compound
-- only the template and the guided report perl
git grep create_compound
-- only triggered by the save code in the guided report perl
-- in the export for the C4/Reports/Guided.pm
git grep run_compound
-- left over in export

apply the patch
look around and see the pieces are cleaned up.

run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20663] Dead report code for "Create Compound Report" since prior to 3.0.x

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20663

M. Tompsett  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com
   |ity.org |
   Severity|enhancement |normal
Summary|Dead report code since  |Dead report code for
   |before 3.0.x|"Create Compound Report"
   ||since prior to 3.0.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20663] New: Dead report code since before 3.0.x

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20663

Bug ID: 20663
   Summary: Dead report code since before 3.0.x
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mtomp...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

git grep "Create Compound Report"
only generates one matching line in guided reports. It makes no sense to keep
this dead code and the code which it would trigger.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

M. Tompsett  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

M. Tompsett  changed:

   What|Removed |Added

  Attachment #74869|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 74870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74870=edit
Bug 20495: Remove get_saved_report

To test:
1 - prove t/db_dependent/Reports/Guided.t
2 - grep "get_saved_report" - ensure there are no occurences of the
singular form
3 - create, save, edit, and convert a report
4 - access a public report and report json from opac and staff client
5 - Ensure all function as expected

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

--- Comment #5 from M. Tompsett  ---
(In reply to M. Tompsett from comment #4)
> Nick, could you confirm that compound reports are not possible? I think one
> of your changes is valid, but pointless.

I jumped back to 3.0.x and:
   git grep "Create Compound Report"
only displays in guided reports once!

If you can't create compound reports, then you can't save them.
I think I'll create a bug to remove those parts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #11 from David Cook  ---
(In reply to Katrin Fischer from comment #10)
> (In reply to Sophie MEYNIEUX from comment #9)
> > The field used for OpacSuppression should be set in a syspref : 942$n is
> > used in marc21 but not in Unimarc
> 
> Could we hardcode a field for UNIMARC? You also need an index with a
> specific name for it to work - would be good to have a default. Or have
> harcoded values and a pref if they don't apply, with a warning that you have
> to take care of indexing?
> 
> Anyway, we will need a new bug! :)

I'm thinking it's worthwhile having a database field for OpacSuppression, and
then people can map the relevant MARC field using
/cgi-bin/koha/admin/koha2marclinks.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20662] The "most poplular" function on the opac does not honour opac supression

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20662

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17921

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17921] Shelf Browser does not take OpacSuppression or OpacHiddenItems into consideration

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17921

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20662

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20662] New: The "most poplular" function on the opac does not honour opac supression

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20662

Bug ID: 20662
   Summary: The "most poplular" function on the opac does not
honour opac supression
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

The "most popular" function on the OPAC does not honour the opac suppression in
the 942$n subfield. 

I think this is because "most popular" is based on a database query, and the
opac suppression is in a MARC field which is indexed in Zebra.

I think the solution is probably to create a biblio.suppressed field and have
the 942$n store data in that field. Then we check that database field for
things like "most popular" and other database queries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 24 + 25 (May and December 2017)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #1 from Bernardo Gonzalez Kriegel  ---
And update 23 (November 2016), so 3 updates.
Patch coming

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #4 from M. Tompsett  ---
Nick, could you confirm that compound reports are not possible? I think one of
your changes is valid, but pointless.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17230] borrowers table should be better normalized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17230

--- Comment #2 from Barton Chittenden  ---
(In reply to Barton Chittenden from comment #0)
> I've always been bothered by the fact that we have 3 separate sets of
> contact information in the borrowers table:
> 
> streetnumber
> streettype
> address
> address2
> city
> state
> zipcode
> country
> email
> phone
> 
> B_streetnumber
> B_streettype
> B_address
> B_address2
> B_city
> B_state
> B_zipcode
> B_country
> B_email
> B_phone
> 
> altstreetnumber
> altstreettype
> altaddress
> altaddress2
> altcity
> altstate
> altzipcode
> altcountry
> altemail
> altphone
> 
> These should be moved to a contacts table, which contains a 'contact_type'
> field corresponding to 'primary', 'B_' or 'alt' (although these also
> desperately need to be renamed), as well as a link to the borrower and a
> timestamp.

alt* is actually altcontact*.

Other borrower contact fields:

mobile
fax
emailpro
phonepro
smsalertnumber
sms_provider_id

Contact fields from other tables:

aqbooksellers:

address1
address2
address3
address4
phone
booksellerfax
bookselleremail
booksellerurl
postal
url
fax

branches:

branchaddress1
branchaddress2
branchaddress3
branchzip
branchcity
branchstate
branchcountry
branchphone
branchfax
branchemail
branchreplyto
branchreturnpath
branchurl 
geolocation (?)

This will require us to use a contact_id and some linking tables
(borrower_contact_link, branch_contact_link, aqbooksellers_contact_link)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

M. Tompsett  changed:

   What|Removed |Added

  Attachment #73423|0   |1
is obsolete||

--- Comment #3 from M. Tompsett  ---
Created attachment 74869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74869=edit
Bug 20495: Remove get_saved_report

To test:
1 - prove t/db_dependent/Reports/Guided.t
2 - grep "get_saved_report" - ensure there are no occurences of the
singular form
3 - create, save, edit, and convert a report
4 - access a public report and report json from opac and staff client
5 - Ensure all function as expected

NOTE: rebased and fixed typo "fund" vs. "find"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592

--- Comment #12 from David Cook  ---
(In reply to Jonathan Druart from comment #11)
> (In reply to David Cook from comment #6)
> > But I agree that a better solution would be to change ModItem rather than
> > updateitem.pl. I considered that, but I figured I would make the lightest
> > touch possible and test the one place where I knew there was a problem. Do
> > you know whether or not it's appropriate to return early from ModItem? What
> > impact does that have across Koha?
> 
> I would not expect side-effects as ModItem does not return a useful value.

I meant more in terms of other parts of Koha catching a fatal error with an
eval{} or something like that, and acting on the error. 

But I'm not fussed either way :).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
  Attachment #74868|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

--- Comment #2 from M. Tompsett  ---
Created attachment 74868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74868=edit
Bug 20495: Follow up to refactor tools/scheduler

TEST PLAN
-
This doesn't require the other patch applied.

-- Make sure you have at least 2 saved reports.
   If you create them from an empty DB, they are 1 and 2
   otherwise, you'll need to know their ID numbers.

Home -> Tools -> Task Scheduler
-- The Report Dropdown has content!

localhost:8081/cgi-bin/koha/tools/scheduler.pl?id=1
-- The Report Dropdown is non-empty and correctly selected
-- Attempt with id=2, different report selected.

apply this patch
restart_all

Home -> Tools -> Task Scheduler
-- Report dropdown has same content!

localhost:8081/cgi-bin/koha/tools/scheduler.pl?id=1
-- The Report Dropdown is non-empty and correctly selected
-- Attempt with id=2, different report selected.
-- effectively no change.

run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20578] When holds are restricted to bib-level or forced to item-level there should be an alert

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20578

Hugh Rundle  changed:

   What|Removed |Added

Summary|Bib level holds are allowed |When holds are restricted
   |with no warning when item   |to bib-level or forced to
   |level holds is set to   |item-level there should be
   |'Force' |an alert

--- Comment #4 from Hugh Rundle  ---
We're currently on 16.11 but I think I confused two different things.  I have
updated the name of the ticket accordingly.

All of the below refers to the staff interface (intranet)

When holds are only allowed at bib level, there is a note next to each item
saying: 

"Item level hold not allowed from OPAC"

When holds are forced to item level, there is a note next to each item saying: 

"Item level hold forced from OPAC"

However, there are effectively two 'sections' for placing holds - staff can
place bib-level holds without really looking at the items, and if they don't
see the note next to the items they can easily place a bib-level hold against
the rules with no further warning.

If the hold policy in 'Default holds policy by item type' is set to 'No holds
allowed', there is a pop-up alert saying either 'This item normally cannot be
put on hold' or 'None of these items can normally be put on hold for this
user', then 'Place hold?'

If the circulation rules force or prevent holds at item level, there should be
a similar pop-up warning and confirmation before staff can place a hold in
contravention of the rules.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20660] AddReturn should use return date override for debarments

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660

David Bourgault  changed:

   What|Removed |Added

 Blocks||17015


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
[Bug 17015] New Koha Calendar
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

David Bourgault  changed:

   What|Removed |Added

 Depends on||20660

--- Comment #147 from David Bourgault  ---
Marked bug 20660 as a dependency of this, as is required for the last patch to
work.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660
[Bug 20660] AddReturn should use return date override for debarments
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20531] IssueSlip is failing randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20531

--- Comment #8 from Jonathan Druart  
---
Created attachment 74867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74867=edit
Bug 20531: Set the timestamps to the same value to get a correct order

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20531] IssueSlip is failing randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20531

--- Comment #7 from Jonathan Druart  
---
That was quick!

https://jenkins.koha-community.org/job/Koha_Master_D8/457/console

koha_1   | # $VAR1 = [
koha_1   | #   {
koha_1   | # 'onsite_checkout' => '0',
koha_1   | # 'borrowernumber' => '200167',
koha_1   | # 'branchcode' => 'rFO7HD',
koha_1   | # 'itemnumber' => '1193',
koha_1   | # 'date_due' => '2018-04-25 21:59:00',
koha_1   | # 'auto_renew' => '0',
koha_1   | # 'note' => undef,
koha_1   | # 'notedate' => undef,
koha_1   | # 'timestamp' => '2018-04-25 20:20:45',
koha_1   | # 'returndate' => undef,
koha_1   | # 'issue_id' => '94',
koha_1   | # 'issuedate' => '2018-04-25 21:58:45',
koha_1   | # 'auto_renew_error' => undef,
koha_1   | # 'lastreneweddate' => undef,
koha_1   | # 'renewals' => undef
koha_1   | #   },
koha_1   | #   {
koha_1   | # 'auto_renew_error' => undef,
koha_1   | # 'issuedate' => '2018-04-24 20:20:45',
koha_1   | # 'lastreneweddate' => undef,
koha_1   | # 'renewals' => undef,
koha_1   | # 'itemnumber' => '1194',
koha_1   | # 'branchcode' => 'rFO7HD',
koha_1   | # 'borrowernumber' => '200167',
koha_1   | # 'onsite_checkout' => '0',
koha_1   | # 'issue_id' => '95',
koha_1   | # 'returndate' => undef,
koha_1   | # 'timestamp' => '2018-04-25 20:20:46',
koha_1   | # 'auto_renew' => '0',
koha_1   | # 'date_due' => '2018-04-25 21:59:00',
koha_1   | # 'note' => undef,
koha_1   | # 'notedate' => undef
koha_1   | #   }
koha_1   | # ];
koha_1   | # Looks like you failed 1 test of 2.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #146 from David Bourgault  ---
I reuploaded all the patches to improve that patch titles and match them to the
community guidelines.

QA tool is green. Tests pass.
Patch is ready for testing and signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #145 from David Bourgault  ---
Created attachment 74866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74866=edit
Bug 17015: Updated patch after bug 19204

This is a small modification to bring the patch up-to-date with current master
after the changes made in 19204. Tests in db_dependent/Circulation.thave been
changed slightly since DiscreteCalendar strictly prevents changing holidays in
the past. This patch requires 20660.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

David Bourgault  changed:

   What|Removed |Added

  Attachment #73145|0   |1
is obsolete||

--- Comment #144 from David Bourgault  ---
Created attachment 74865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74865=edit
Bug 17015: Add gen_time to TestBuilder

+ Adds a gen_time() function to TestBuilder.
TestBuilder now passes green.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

David Bourgault  changed:

   What|Removed |Added

  Attachment #72890|0   |1
is obsolete||

--- Comment #143 from David Bourgault  ---
Created attachment 74864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74864=edit
Bug 17015: Code quality fixes on QA feedback

Changes:

* Koha::DiscreteCalendar->new uses a hashref instead of a hash
This meant changing every call to the Calendar and explains why this patch is
so
big. Most changes are simply adding braces to the new() call.

+ Added table encoding to atomic update
+ Added table definition to kohastructure.sql

- Removed `repeatable_holidays`, `special_holidays` from kohastructure.sql
Also added relevant DROP TABLEs to a new atomicupdate (part3)

+ Added 'override' param to Koha::DiscreteCalendar
Without this param (off by default), edit_holiday will not modify past dates.
This caused issues with some tests that required this functionality to work
properly. Adding 'override => 1' to the function call will allow past dates to
happen, but should only be called for testing.

* Holds.t, Hold.t, CalcDateDue.t have been corrected.
Prior to his patch, theses tests used hardcoded dates to test calendar
functionalities, however, DiscreteCalendar is only usable one year into the
past
by default. They have been modified to be centered around '$today'

* 'use strict; use warnings;' changed to 'use Modern::Perl;' in modified files.
* Atomic update no longer takes params
* Javascript moved to the bottom of discrete_calendar.tt
* Calendar css moved out of tt file and into new discrete_calendar.css
* All references to C4::Calendar and Koha::Calendar should now be removed
* Some comments corrected

All relevant tests passed for me on a fresh database. QA tool green.
Test plan has not changed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

David Bourgault  changed:

   What|Removed |Added

  Attachment #71638|0   |1
is obsolete||

--- Comment #142 from David Bourgault  ---
Created attachment 74863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74863=edit
Bug 17015: Remove old Koha::Calendar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

David Bourgault  changed:

   What|Removed |Added

  Attachment #71637|0   |1
is obsolete||

--- Comment #141 from David Bourgault  ---
Created attachment 74862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74862=edit
Bug 17015: Peformance tests for Koha::DiscreteCalendar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

David Bourgault  changed:

   What|Removed |Added

  Attachment #71636|0   |1
is obsolete||

--- Comment #140 from David Bourgault  ---
Created attachment 74861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74861=edit
Bug 17015: Koha now uses the new DiscreteCalendar module

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

David Bourgault  changed:

   What|Removed |Added

  Attachment #71635|0   |1
is obsolete||

--- Comment #139 from David Bourgault  ---
Created attachment 74860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74860=edit
Bug 17015: Tests for DiscreteCalendar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|RM_priority |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

David Bourgault  changed:

   What|Removed |Added

  Attachment #71634|0   |1
is obsolete||

--- Comment #138 from David Bourgault  ---
Created attachment 74859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74859=edit
Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|RM_priority |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|RM_priority |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20661] Implement blocking errors for circulation scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20661

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_18_05_candidate

--- Comment #3 from Jonathan Druart  
---
I think it's quite complete for circ/* (and already done for members/*).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20661] Implement blocking errors for circulation scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20661

--- Comment #1 from Jonathan Druart  
---
Created attachment 74858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74858=edit
Bug 20661: Shortcut scripts if a blocking error appeared

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20661] Implement blocking errors for circulation scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20661

--- Comment #2 from Jonathan Druart  
---
I do not have time right now to implement this, but it seems something we
really need and should apply to scripts with mandatory parameters.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20661] New: Implement blocking errors for circulation scripts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20661

Bug ID: 20661
   Summary: Implement blocking errors for circulation scripts
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20660] AddReturn should use return date override for debarments

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660

--- Comment #1 from David Bourgault  ---
Created attachment 74857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74857=edit
Bug 20660: AddReturn uses return_date override for new debarments

This patches is a minor tweak (single line) to C4::Circulation to use the
return_date value as $today when calculating new debarments in AddReturn.

I've also added a test in t/db_dependent/Circulation.t

TEST PLAN

1) comment out line 1988 in Circulation.pm ("$today = $return_date if
$return_date")
2) prove t/db_dependent/Circulation.t (Fail)
3) uncomment the line
4) prove t/db_dependent/Circulation.t (Pass)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20660] AddReturn should use return date override for debarments

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660

David Bourgault  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20660] New: AddReturn should use return date override for debarments

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660

Bug ID: 20660
   Summary: AddReturn should use return date override for
debarments
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Circulation
  Assignee: david.bourga...@inlibro.com
  Reporter: david.bourga...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

C4::Circulation::AddReturn does not use the return_date override when
calculating new debarments. This causes issues when trying to test functions
with return dates in the future.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20659] Blocking errors are not longer displayed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20659

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #2 from Jonathan Druart  
---
Patch pushed to master for 18.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20659] Blocking errors are not longer displayed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20659

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20659] Blocking errors are not longer displayed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20659

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20659] Blocking errors are not longer displayed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20659

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20659] Blocking errors are not longer displayed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20659

--- Comment #1 from Jonathan Druart  
---
Created attachment 74856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74856=edit
Bug 20659: Fix blocking errors display

The include file blocking-errors.inc has been created to by-pass regular
processing and display an error that should block the elements of the
view.

For instance you call a patron's page with invalid borrowernumber => we
do not want the app to crash (500) or the page to display with broken
elements.

It worked well on bug 18403 but it's now broken, a blank page is
displayed instead.
It may be caused by the move of the JS to the bottom of the page.

Test plan:
hit /cgi-bin/koha/members/moremember.pl?borrowernumber=45432
Without this patch a blank page is displayed.
With this patch you see the blocking error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20659


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20659
[Bug 20659] Blocking errors are not longer displayed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20659] New: Blocking errors are not longer displayed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20659

Bug ID: 20659
   Summary: Blocking errors are not longer displayed
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 18403

The include file blocking-errors.inc has been created to by-pass regular
processing and display an error that should block the elements of the view.

For instance you call a patron's page with invalid borrowernumber => we do not
want the app to crash (500) or the page to display with broken elements.

It worked well on bug 18403 but it's now broken, a blank page is displayed
instead.
It may be caused by the move of the JS to the bottom of the page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403
[Bug 18403] Hide patron information if not part of the logged in user library
group
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #12 from David Gustafsson  ---
And about the searchable parameter, I think we are going to need this in the
future so included it as did not see a major downside of doing so. The problem
this might solve is that we would want to have exclusive "sort"-field mappings,
not included in the main field. The idea is to allow mappings to be written on
the form "035a|035b|035c", and this would mean that the first field that has a
value gets mapped, the rest skipped. We have disabled sorting since it's very
unpredictable for multivalued fields, and this was seen as a possible future
solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #11 from David Gustafsson  ---
Yes, I think the best option would be to try getting bug_18316 merged, and then
refactor this upon that. I completely missed bug_18316 before starting to work
on this. I tried applying bug_18316 but was unable to do so because of some
git-error, think there might be something wonky with the current patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #70 from David Gustafsson  ---
@Katrin Fischer Yes it could use some work, still have not gotten around to
updating the help-pages and tests. We are currently running this in production
though and has been doing so for a couple of weeks. It could take some time
though before have time to fix the above.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #69 from David Gustafsson  ---
Removed String::Similarity dependency and fixed an issue with the field data
hashing function.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson  changed:

   What|Removed |Added

  Attachment #72498|0   |1
is obsolete||

--- Comment #68 from David Gustafsson  ---
Created attachment 74855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74855=edit
Bug 14957 - Rule based permission for MARC fields

Add a rule based permission system for MARC field modifications.

Test plan:
1. Apply this patch
2. Run updatedatabase.pl
3. Log in to staff client
4. Enable new syspref MARCPermissions
5. You should see a new link "MARC field permissions" in the "Catalog"
   section under "Koha administrtion".
6. Go to the "MARC field permissions" page
7. Next to the page heading ("Manage MARC field permissions") there is a
   button with a question mark, click this for more information about the
   rule system.
8. Add desired rules to the rule table, press the +-button to add.
9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
10. Clicking the x-icon should remove corresponding rule after
confirmation.
11. Selecting one or more rules followed by clicking the trash-icon
should remove all selected rules after confirmation.
12. To test your rules, import or in other way modify a record.
13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library
Sponsored-by: Catalyst IT
Sponsored-by: Gothenbug University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20334] Option for escaping slashes in search queries

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334

--- Comment #10 from David Gustafsson  ---
Ok, done :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19181] Intranet and OPAC authentication selenium test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19181] Intranet and OPAC authentication selenium test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181

--- Comment #11 from Jonathan Druart  
---
Created attachment 74854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74854=edit
Bug 19181: Add new tests

This patch reuses the method newly added to Selenium.pm and improve
existing tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19181] Intranet and OPAC authentication selenium test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20486] Add --marc_conditions option to export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20486

--- Comment #8 from David Gustafsson  ---
I fixed the pod issue. The reason for the "# TODO: ??" was that not completely
sure how ta handle the case where marc target cannot be found for different
operators, but think it's handled correctly so removed this. Unfortunately we
do not have the resources to port this functionality to the web-UI as well as
we do not use it. This was initially just supposed to be a hard coded hack for
our local needs but I generalized the matching functionality so other targets
that the ones we use can be used for filtering in case someone else needed
this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20486] Add --marc_conditions option to export_records.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20486

David Gustafsson  changed:

   What|Removed |Added

  Attachment #73999|0   |1
is obsolete||

--- Comment #7 from David Gustafsson  ---
Created attachment 74853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74853=edit
Bug 20486: Add --marc_conditions option to export_records.pl

Add --marc_conditions option to export_records.pl script, for
excluding records based on conditions applied to MARC-record
data.

How to test:
1) Run tests in t/Exporter/Record.t
2) All tests should pass

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #18 from David Gustafsson  ---
About the version, I was wrong, seams we are running 5.4. I would assume it
would be as easy to just change the version string to get it working with 6
(but not sure how 6 handles _all fields and other deprecated things used by
Koha). We run a quite heavily patched version of Koha where those issues have
been fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20632] Staff users without superlibrarian can't log into OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20632

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|In Discussion   |RESOLVED

--- Comment #5 from Katrin Fischer  ---
You are right, I missed it because i was looking at the top level permission
with the others collapsed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20220] Move template JavaScript to the footer: Holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20220

--- Comment #1 from Owen Leonard  ---
Created attachment 74852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74852=edit
Bug 20220: Move template JavaScript to the footer: Holds

This patch modifies the holds template so that JavaScript is included in
the footer.

To test, apply the patch and initiate the process of placing a hold.
Throughout the process JavaScript-based interactions should work: Patron
autocomplete, datepickers, DataTables, cancel confirmations, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20220] Move template JavaScript to the footer: Holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20220

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20658] Move template JavaScript to the footer: Installer and onboarding

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

--- Comment #1 from Owen Leonard  ---
Created attachment 74851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74851=edit
Bug 20658: Move template JavaScript to the footer: Installer and onboarding

This patch updates the installer and onboarding templates so that
JavaScript is included in the footer instead of the header. A new
include file is added, installer-intranet-bottom.inc, so that only
required JS is being loaded.

Some markup changes are included to improve validity.

To test, apply the patch and start with a blank Koha database. Run
through the installer and onboarding processes and confirm that there
are no problems. Check especially JS-related interactions like
datepickers and fields which are validated via JS, like the password
inputs.

NOTE: The qa tool will flag this patch for not using the Asset plugin,
but it doesn't work correctly for installer files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20658] Move template JavaScript to the footer: Installer and onboarding

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19181] Intranet and OPAC authentication selenium test

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|alexbuck...@catalyst.net.nz |jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|BLOCKED |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17237] Stop koha-create from creating MySQL users without host restriction

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17237

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17237] Stop koha-create from creating MySQL users without host restriction

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17237

--- Comment #4 from M. Tompsett  ---
Created attachment 74850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74850=edit
Bug 17237: Remove CREATE USER 'user'@'%' line

Having a 'user'@'%' line decreases database security.
Bug 16690 closes the need for such a line, and this
bug removes the use of it.

TEST PLAN
-
While this depends on 16690, it is not required for testing.

On a kohadev box:
sudo koha-create --create-db test_17237_a
git bz apply 17237
sudo perl ~/misc4dev/cp_debian_files.pl
restart_all
sudo systemctl daemon-reload
sudo koha-create --create_db test_17237_b
sudo mysql -u root
SELECT user,host from mysql.user;
-- test_17237_a will have two entries, one being '%'
-- test_17237_b will only have one entry, not '%'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20655] Z3950 Authorities search is unordered

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20655

Bob Geoghegan  changed:

   What|Removed |Added

 CC||konigde...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16690] Remote DB installation is less secure.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690

M. Tompsett  changed:

   What|Removed |Added

Summary|Remote DB installation  |Remote DB installation is
   |fails   |less secure.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16690] Remote DB installation fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64847|0   |1
is obsolete||
  Attachment #64848|0   |1
is obsolete||
  Attachment #74510|0   |1
is obsolete||
  Attachment #74511|0   |1
is obsolete||

--- Comment #15 from M. Tompsett  ---
Created attachment 74849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74849=edit
Bug 16690: Simplify SHOW GRANTS to work when connected

If the DB is on a remote machine, the web server and the
db server are different, but the SHOW GRANTS code in
installer/install.pl is trying to use the SAME machine.
And even if the permissions were allowed accessing from
both the web and db servers, MySQL won't return the
SHOW GRANTS without access to the mysql.user table. To
install *.* permissions became easiest to get working.
Unless the DB is set up with 'user'@'%', which is also a
potential security issue.

MySQL / MariaDB allow the current connected user to
check their own grants with CURRENT_USER.
There is no need for the installer to know the
IP address of the webserver.

This also removes the need to have permissions for
'koha_kohadev'@'%', because the only process to be
accessing the koha DB is from a known host/ip.
This tightens security too.

TEST PLAN
-
Install 2 fresh VMs from a Debian ISO.
Make sure they are on the same network (192.168.50.x) as
the kohadevbox. You will need to remember one as DB_IPADDRESS.

On the DB VM & Third VM:
sudo apt-get install mariadb-server mariadb-client net-tools
-- the third vm just needs to be able to run mysql to access
   the DB VM.

On DB VM:
sudo vi /etc/mysql/mariadb.conf.d/50-server.cnf
-- make sure the bind-address line is commented out with a #
sudo service mariadb restart
-- congratulations, your DB server is listening to remote
   calls now.

sudo mysql -u root
CREATE DATABASE koha_kohadev;
GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'localhost'
IDENTIFIED BY 'password';
FLUSH PRIVILEGES;
-- now you have an empty DB ready to run a web install on.
   However, because only koha_kohadev from localhost is
   allowed, we expect failure when we try to run the web
   installation step when we get there.

Let's confirm that everything is working as expected
before trying.  It will also demonstrate the reason why
this patch is superior to the existing code.

On a kohadevbox:
mysql -u koha_kohadev -h DB_IPADDRESS -p
-- this should be denied

On DB VM:
DROP USER 'koha_kohadev'@'localhost';
GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'%' IDENTIFIED BY
'password';
FLUSH PRIVILEGES;

On a kohadevbox:
mysql -u koha_kohadev -h DB_IPADDRESS -p
-- this should give you a SQL prompt
SHOW GRANTS FOR CURRENT_USER;
-- this should show two lines based on 'koha_kohadev'@'%';
SHOW GRANTS FOR 'koha_kohadev'@'192.168.50.10';
-- this should give an access denied error.
SHOW GRANTS FOR 'koha_kohadev'@'%';
-- this should show two lines based on 'koha_kohadev'@'%';
QUIT
-- This case requires the unless code currently in place,
   because we aren't checking CURRENT_USER.

On DB VM:
DROP USER 'koha_kohadev'@'%';
GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'192.168.50.10'
IDENTIFIED BY 'password';
FLUSH PRIVILEGES;

On a kohadevbox:
mysql -u koha_kohadev -h DB_IPADDRESS -p
-- this should give you a SQL prompt
SHOW GRANTS FOR CURRENT_USER;
-- this should show two lines based on 'koha_kohadev'@'%';
SHOW GRANTS FOR 'koha_kohadev'@'192.168.50.10';
-- this should show two lines based on 'koha_kohadev'@'192.168.50.10';
SHOW GRANTS FOR 'koha_kohadev'@'%';
-- this should give an access denied error.
QUIT
-- This case demonstrates that we have two failure points:
   1) The GRANT command by the DB Admin and
   2) The koha-conf.xml setting.
   This is why CURRENT_USER is superior: only (2) is the
   failure point.

On DB VM:
GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'%' IDENTIFIED BY
'password';
FLUSH PRIVILEGES;
SELECT host,user FROM mysql.user;
-- Should see both koha_kohadev for 192.168.50.10 and %.

On a kohadevbox:
mysql -u koha_kohadev -h DB_IPADDRESS -p
-- this should give you a SQL prompt
SHOW GRANTS FOR CURRENT_USER;
-- this should show two lines based on 'koha_kohadev'@'192.168.50.10';
SHOW GRANTS FOR 'koha_kohadev'@'192.168.50.10';
-- this should show two lines based on 'koha_kohadev'@'192.168.50.10';
SHOW GRANTS FOR 'koha_kohadev'@'%';
-- this should give an access denied error.
QUIT
-- This case doesn't need the unless. CURRENT_USER still
   just works.

On an third VM on the same network:
mysql -u 

[Koha-bugs] [Bug 16690] Remote DB installation fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17237] Stop koha-create from creating MySQL users without host restriction

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17237

M. Tompsett  changed:

   What|Removed |Added

 Depends on||16690

--- Comment #3 from M. Tompsett  ---
Bug 16690 will remove the requirement for it from the code. This bug will fix
koha-create to not generate the '%'.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690
[Bug 16690] Remote DB installation fails
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16690] Remote DB installation fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690

M. Tompsett  changed:

   What|Removed |Added

 Blocks||17237


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17237
[Bug 17237] Stop koha-create from creating MySQL users without host restriction
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20658] New: Move template JavaScript to the footer: Installer and onboarding

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658

Bug ID: 20658
   Summary: Move template JavaScript to the footer: Installer and
onboarding
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for the installer and onboarding templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard  changed:

   What|Removed |Added

 Depends on||20658


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658
[Bug 20658] Move template JavaScript to the footer: Installer and onboarding
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard  changed:

   What|Removed |Added

 Depends on||20220


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20220
[Bug 20220] Move template JavaScript to the footer: Holds
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20220] Move template JavaScript to the footer: Holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20220

Owen Leonard  changed:

   What|Removed |Added

 Blocks||17858


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474

--- Comment #59 from Jonathan Druart  
---
I am stuck here and I need help:
https://framabin.org/?92fc14016eb1b26b#Ign1IDycTejFZj7suueyIXO/wEy2wFB13hxbqq5Yle0=

I changed .scss file and `yarn build` or `yarn css` does not update .css files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8000] Test mode for notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

David Bourgault  changed:

   What|Removed |Added

  Attachment #74110|0   |1
is obsolete||
  Attachment #74111|0   |1
is obsolete||

--- Comment #143 from David Bourgault  ---
Created attachment 74848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74848=edit
Bug 8000: Redirect all emails to SendAllEmailsTo

Rebased and squashed after changes to master.
Only difference from previous patches are small adjustements to conflicts in
t/db_dependent/Letters.t

Test plan:

1) Apply path
2) Run updatedatabase.pl
3) Clear all SendAllEmailsTo system preference
4) Send mail to a patron of your choosing, email will go to patron's
   email address as usual.
5) Set SendAllEmailsTo to a test email address
6) Send mail to the patron, email will be redirected to the email set
   in the systempreference.
7) Run prove -v t/db_dependent/Letters.t

It does not affect messages in the message_queue.

This patch obsoletes previous patches, because it achieves the same
functionality in a much more centralized way. (4 lines of code!)

Signed-off-by: Ed Veal 
Signed-off-by: BWS Sandboxes 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20531] IssueSlip is failing randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20531

--- Comment #6 from Jonathan Druart  
---
Last patch pushed, diag added. Let's wait next failure...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20531] IssueSlip is failing randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20531

--- Comment #5 from Jonathan Druart  
---
Created attachment 74847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74847=edit
Bug 20531: Add diag to help debug next failure

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20531] IssueSlip is failing randomly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20531

--- Comment #4 from Jonathan Druart  
---
Still failing:
https://jenkins.koha-community.org/job/Koha_Master_D8/455/console

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20632] Staff users without superlibrarian can't log into OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20632

Jonathan Druart  changed:

   What|Removed |Added

   Severity|critical|minor

--- Comment #4 from Jonathan Druart  
---
There is a note already:

" self_checkin_module Log into the self check-in module. Note: this permission
prevents the patron from using any other OPAC functionality "

https://screenshots.firefox.com/578CGKmzkgVDIjEa/pro.kohadev.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837

Andrew Isherwood  changed:

   What|Removed |Added

   Assignee|alex.sassmannshausen@gmail. |andrew.isherwood@ptfs-europ
   |com |e.com
 CC||andrew.isherwood@ptfs-europ
   ||e.com
  Component|Circulation |ILL
 QA Contact|testo...@bugs.koha-communit |
   |y.org   |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin Response

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517

Christophe Croullebois  changed:

   What|Removed |Added

 CC||christophe.croullebois@bibl
   ||ibre.com

--- Comment #1 from Christophe Croullebois 
 ---
Hello Magnus,

we have in Biblibre a specific dev on this topic.
We do not use it to indicate to the user where to put the item, but to be used
by a sorting machine.
I think it is the same, because we put the number of sort bin expected in the
CL field.
It is more complex than your suggestion, we use two config files .yaml, the
first just have the bin number in case of an hold on the item.
The second one is more complex, you can use conditions with eq/neq and/or to
chose the number of the sortbin based on all 995$ subfields (item fields in
Unimarc).
So the Library can give many conditions for each sortbin based on all item's
Marc subfield.
We do not submit this dev because we thought it was not sure it will be agreed
by the community.
Anyway if you want to examine it I could send it to you.
Best regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20538] Remove the need of writing [% KOHA_VERSION %] everywhere

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538

--- Comment #26 from Jonathan Druart  
---
(In reply to Julian Maurice from comment #25)
> Created attachment 74835 [details] [review]
> Bug 20538: Prevent warnings in xt/author/valid-templates.t

Pushed to master, thanks Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calendar into account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #25 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #38 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20657] New: Globally enable PRE_CHOMP and POST_CHOMP in Template Toolkit configuration

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20657

Bug ID: 20657
   Summary: Globally enable PRE_CHOMP and  POST_CHOMP in Template
Toolkit configuration
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

As it currently stands, the HTML output by Template Toolkit includes whitespace
anywhere there was a template tag. For example, this is a portion of the
generated source of the staff client home page:

 1
 2
 3
 4 
 5 
 6
 7
 8
 9
10 
11 
12
13 Koha staff client

Developer tools report: 26.69 KB / 5.83 KB transferred

In contrast, this what the same content looks like with PRE_CHOMP and 
POST_CHOMP enabled:

1 
2 
3 
4 Koha staff client

Developer tools report: 23.29 KB / 5.65 KB transferred

In the samples I looked at this change did not make the HTML source
significantly more difficult to read.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #23 from Jonathan Druart  
---
2 majors problems:

1. compare columns.def and patronfields.inc
=> They are the "same"

2. It does not work, and cannot work without changes to
C4/Utils/DataTables/Members.pm

Test: Add altcontactsurname to the pref, it appears in the dropdown list,
select it, search for something: everything is returned.

Because of the following:

my $searchfields = {
# list of available fields
then later:

130 for my $searchfield ( split /,/, $searchfields->{$searchfieldstype}
) {
131 push @where_strs_or, "borrowers." .
$dbh->quote_identifier($searchfield) . " LIKE ?";
132 push @where_args, $term;
133 }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #36 from Jonathan Druart  
---
1. when adding/editing a patron category, "Display in quick add: " is a bit
meaningless, I would add a quick description, like we have for "Default
privacy:", "Block expired patrons:", etc.

2. There is a condition ([% IF Koha.Preference('PatronQuickAddFields') ||
Koha.Preference('BorrowerMandatoryField') %]) template-side to display the
"Quick add new patron" button, should we do the same on the patron's category
form?


And a question: what is the use case here? It seems that it would have been
done in css or javascript easily... :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Signed Off

--- Comment #31 from Jonathan Druart  
---
I need either follow-ups, second signoff or another QA.
Moving out of PQA, back to "Signed Off"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|regression  |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100

--- Comment #37 from Jonathan Druart  
---
Created attachment 74846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74846=edit
Bug 20100: Set ProtectSuperlibrarianPrivileges by default

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/