date:20180510

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

--- Comment #4 from Giuseppe Ciaccio  ---
I've done a test with unimarc flavour and english or it-IT as the installation
language, nothing changes.  The inserted records become searchable only after
"service koha-common stop && service koha-common start".

However, after completing the install/config wizard, I looked at the output of
"ps ax" before and after service restart, and noted that, after restart, a new
daemon process appeared, called -koha-indexer, which was missing
before.  I will send a logfile to show this.

IMHO the wizard, or the initial koha-create command, fails launching the
koha-indexer, and that's why the indexing/searching provides no results until
the service is manually restarted.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20749] New: Unable to import MARC data

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20749

Bug ID: 20749
   Summary: Unable to import MARC data
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: menarialaxmi...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 75218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75218=edit
Issue

We are using Soul (A software from INFILIBNET Gujrat- India) from last 15 years
but now we wants to migrate the library software from SOUL to KOHA.

I have tried export MARC format from SOUL2.0 and tried to import in the KOHA
latest version, it stucked after STAGED. Nothing showing that data has
imported.

Attached a screen shot of the import process.

Please guide me if anything available.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

--- Comment #5 from Giuseppe Ciaccio  ---
Created attachment 75217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75217=edit
output of "ps ax" before and after koha-common service restart; note the
initial absence of koha-indexer (libraryname = ferrer)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Andrew Isherwood  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ
   |ity.org |e.com
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20750] New: Allow timestamped auditing of ILL request events

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Bug ID: 20750
   Summary: Allow timestamped auditing of ILL request events
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: ILL
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andrew.isherw...@ptfs-europe.com

Currently there is no audit trail provided for ILL requests, this is required.

At the most basic form this would be a timestamped record of changes of a
request's status. It would be useful to be able to also record other arbitrary
events.

This bug proposes the addition of a requests_actions log that allows either the
core ILL code or backends to record arbitrary events relating to a request.
This could then be displayed in the UI as an "audit trail" or reported upon.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20707] Permissions for circ/ysearch.pl override specific page level permissions and delete sessions improperly

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20707

Owen Leonard  changed:

   What|Removed |Added

  Attachment #75078|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 75220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75220=edit
Bug 20707: Replace circ/search.pl circulate permission requirement with
catalogue

To test:
 1 - Setup a staff patron with permissions:
   - catalogue
   - reserveforothers
   - course_reserves
 2 - Log in to staff client as that patron
 3 - Find a record and click to place a hold
 4 - Type more than three letters into the search bar but don't submit
 5 - Note that you will not receive autocomplete results
 6 - Either submit, or try to visit any page in staff client
 7 - Your session has been expired, you must log in again
 8 - Log in, go to course reserves
 9 - As before, trigger the autocomplete search in the instrcutor field
10 - Again your session has been terminated
11 - Apply patch
12 - Repeat above actions, this time you will not be kicked out

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20707] Permissions for circ/ysearch.pl override specific page level permissions and delete sessions improperly

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20707

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724

--- Comment #6 from Kyle M Hall  ---
Created attachment 75219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75219=edit
Bug 20724 [Alternate]: Try to fix ReservesNeedReturns wrong behaviour

We need to call Koha::Hold->set_waiting to correctly
calculate the expiration date.

It fixes a regression introduced by
  commit 26634151dbce0bf39ff6c9eda5b58bb993996a2d
  Bug 12063 - Fix QA failures

The expiration date has to be set for waiting holds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

--- Comment #6 from Jonathan Druart  
---
% sudo koha-create --create-db xxx
Koha instance is empty, no staff user created.
% ps aux | grep xxx-koha-zebra
xxx-koha  3534  0.1  0.0  18608   188 ?S10:09   0:00 daemon
--name=xxx-koha-zebra --pidfiles=/var/run/koha/xxx/
--errlog=/var/log/koha/xxx/zebra-error.log
--output=/var/log/koha/xxx/zebra-output.log --verbose=1 --respawn --delay=30
--user=xxx-koha.xxx-koha -- /usr/bin/zebrasrv -v none,fatal,warn -f
/etc/koha/sites/xxx/koha-conf.xml

Looks ok for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

--- Comment #8 from Jonathan Druart  
---
heh, it's missing :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.dru...@bugs.koha-c |tomasco...@gmail.com
   |ommunity.org|
   Keywords||rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15239] Add multiple items fail on barcode

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239

--- Comment #14 from Owen Leonard  ---
Could we get a test plan for this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20234] Make maintenance scripts use koha-zebra instead of koha-*-zebra

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20234

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20745


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745
[Bug 20745] indexing/searching not active at end of installation
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||20234

--- Comment #11 from Jonathan Druart  
---
Certainly caused by bug 20234.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20234
[Bug 20234] Make maintenance scripts use koha-zebra instead of koha-*-zebra
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15239] Add multiple items fail on barcode

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

--- Comment #9 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #8)
> heh, it's missing :)

--- a/misc/migration_tools/rebuild_zebra.pl
+++ b/misc/migration_tools/rebuild_zebra.pl
@@ -242,9 +242,14 @@ if ($daemon_mode) {
 if (_flock($LockFH, LOCK_EX|LOCK_NB)) {
 eval {
 $dbh = C4::Context->dbh;
-if( zebraqueue_not_empty() ) {
-Koha::Caches->flush_L1_caches() if $is_memcached;
-do_one_pass();
+if ( C4::Context->preference('Version') ) {
+if( zebraqueue_not_empty() ) {
+Koha::Caches->flush_L1_caches() if $is_memcached;
+do_one_pass();
+}
+}
+else {
+warn "Warning: Koha is not installed.";
 }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

--- Comment #10 from Jonathan Druart  
---
To my understanding the problem is in koha-zebra.

koha-create calls: koha-zebra --start "$name"

And then exit 1

it's because the function start_zebra (from koha-zebra) returns an error with:
   [ "$verbose" != "no" ] && \
   log_end_msg 0

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

--- Comment #7 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #6)
> % sudo koha-create --create-db xxx
> Koha instance is empty, no staff user created.
> % ps aux | grep xxx-koha-zebra
> xxx-koha  3534  0.1  0.0  18608   188 ?S10:09   0:00 daemon
> --name=xxx-koha-zebra --pidfiles=/var/run/koha/xxx/
> --errlog=/var/log/koha/xxx/zebra-error.log
> --output=/var/log/koha/xxx/zebra-output.log --verbose=1 --respawn --delay=30
> --user=xxx-koha.xxx-koha -- /usr/bin/zebrasrv -v none,fatal,warn -f
> /etc/koha/sites/xxx/koha-conf.xml
> 
> Looks ok for me.

what about the indexer?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

--- Comment #1 from Andrew Isherwood  ---
Discussed with joubu on IRC, suggestion was to use actions_logs rather than
bake our own recording mechanism

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724

--- Comment #9 from Jonathan Druart  
---
Created attachment 75223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75223=edit
Bug 20724: Add tests for ReservesNeedReturns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20696] Remove a few ugly "eq undef" comparisons

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20696

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20696] Remove a few ugly "eq undef" comparisons

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20696

Owen Leonard  changed:

   What|Removed |Added

  Attachment #74982|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 75224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75224=edit
Bug 20696: Fix a few ugly "eq undef" comparisons in Search.pm

Comparisons like $a eq undef should normally raise a warning like:
Use of uninitialized value in string eq at ...
But unfortunately we still suppress warnings here and there.

Test plan:
[1] Just read this patch and confirm the small changes.
[2] Git grep on "eq undef" and do not find other occurrences.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Owen Leonard 

Passes test plan and QA tools. Searching works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6172] Non-French UNIMARC frameworks need to be updated

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6172

--- Comment #12 from Jon Knight  ---
(In reply to Giuseppe Ciaccio from comment #11)
> It seems that Koha/unimarc/en is working properly, provided the indexer has
> started (which does not happen initially, but this is another story; see
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745).

As the Koha/unimarc/en is working OK, I assume you're happy for this case to
close?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20751] New: Marc21: Show i for 776

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20751

Bug ID: 20751
   Summary: Marc21: Show i for 776
 Change sponsored?: ---
   Product: Koha
   Version: 17.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

In 17.11 the marc21 776 field ( [15140] Add MARC21 776 to OPAC and staff
display
) became visible in the OPAC and staff client. This was specifically for
subfield $t and $w.  It would be great if the $i could also be visible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20707] Permissions for circ/ysearch.pl override specific page level permissions and delete sessions improperly

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20707

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 75227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75227=edit
Bug 20745: koha-zebra doesn't return the correct error codes

This patch makes koha-zebra return 0 (or 1) even when verbose mode is
off. This made koha-zebra --start always return a failure even when the
daemon was correctly launched.

To test:
- Have Zebra running for kohadev instance on your KohaDevBox
- Run:
  $ sudo koha-zebra --stop kohadev && echo yay || echo doh
=> FAIL: 'doh' is printed
- Run:
  $ sudo koha-zebra --start kohadev e&& echo yay || echo doh
=> FAIL: 'doh' is printed as well
- Apply this patch
- Run:
  $ sudo perl misc4dev/cp_debian_files.pl
  $ sudo koha-zebra --stop kohadev && echo yay || echo doh
=> SUCCESS: 'yay' is printed
- Run:
  $ sudo koha-zebra --start kohadev e&& echo yay || echo doh
=> SUCCESS: 'yay' is printed
- Sign off :-D

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

--- Comment #13 from Tomás Cohen Arazi  ---
Added the 17.11 RMaint because the original patches got backported.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20751] Marc21: Show i for 776

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20751

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

--- Comment #1 from Heather  ---
The 76X-78X Linking Entry Fields in MARC21 (including the 776 field) require
that $i contain "Relationship Information," i.e., "Online version," or "Large
print version," or "Print version."  Explanation with usage examples here:
https://www.loc.gov/marc/bibliographic/bd76x78x.html

There are more examples and explanations of usage in OCLC's Bibliographic
Formats & Standards:
https://www.oclc.org/bibformats/en/7xx/76x-78x.html

So libraries that catalog according to these standards have records that
conform to them--my library has LOTS of records that conform to these
standards.  So if the $i is not displaying, there is no indication of the
relationship between the record displayed and what it's linking to.  ByWater
Solutions in its training videos suggests changing/using the $t to indicate
relationship, but this isn't practical for us (too many records involved) and
we can't catalog this way since it doesn't conform to the MARC21 standards that
we follow & that we must use in OCLC.

In addition, many older records (including Library of Congress records) only
have a $i with relationship information and the $w with record numbers--the $t
for title information is not required and wasn't always included until OCLC
created a macro for pulling the information from the linked record.

So it would be wonderful if Koha could also conform to these standards to
display the relationship information using the subfield, $i, that the standards
use to display/store the relationship information.  Koha even calls the $i
"Display text" in the Bibliographic Frameworks, so if I have it checked to
display in the staff client & opac, I would love it to display.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11943] Prevent double accepts in Koha::Virtualshelfshare

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

--- Comment #20 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #19)
> The user click on a link and... nothing happens?
> 
> Should not we display a message to explain that the list is already shared?

This should be done on a separate bug report, to not block the inclusion into
18.05 (string changes).

However, should not we put the update DB entry on a separate bug report and
deal with the DB structure later? We will have to recheck the duplicate on
create the unique constraint anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20729] Update style of datepickers

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #75182|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 75232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75232=edit
Bug 20729: Update style of datepickers

This patch updates the styling of form fields which are configured to
use the jQueryUI datepicker widget. Some CSS has been added, and the
default datepicker configuration has been changed.

To test, apply the patch and clear your cache if necessary. Test pages
which include a datepicker to confirm that they look correct and work
correctly. Some examples:

 - Circulation -> Check out -> Specify due date
 - Patrons -> Add patron -> Date of birth, registration date, expiry
   date fields
 - Serials -> Search subscriptions -> Search results page sidebar
 - Tools -> News -> Add news item

And confirm that this change hasn't adversely affected the calendar
tool:

 - Tools -> Calendar

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20729] Update style of datepickers

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16739] generate edifact showing on basket groups

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16739

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #7 from Owen Leonard  ---
This looks like it's working correctly, but the QA tool has several complaints
about tab indentation. Indentation should always be done with 4 spaces.

There is one part of the template which I don't understand, starting at line
149:

[% IF (ediaccount) %]
 Generate EDIFACT order
[% ELSE %]

[% END %]

What is the purpose of the [% ELSE %] section? The  tag is incomplete, so I
would expect this to break HTML rendering somehow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20749] Unable to import MARC data

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20749

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |INVALID

--- Comment #1 from Katrin Fischer  ---
Hi,

it looks like the MARC you exported is not valid. 
Bugzilla is used for reporting bugs and enhancment wishes and only a few people
will this here. Please bring your question to the mailing list, where other
former SOUL users might be able to help you!

https://koha-community.org/support/koha-mailing-lists/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11943] Prevent double accepts in Koha::Virtualshelfshare

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943

--- Comment #19 from Jonathan Druart  
---
The user click on a link and... nothing happens?

Should not we display a message to explain that the list is already shared?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20746] Improve behaviour of onboarding tool for Italian by standardizing file structure of it-IT web installer

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20746

Katrin Fischer  changed:

   What|Removed |Added

Version|17.11   |master
 CC||katrin.fisc...@bsz-bw.de
Summary|when choosing italian   |Improve behaviour of
   |language for the install|onboarding tool for Italian
   |wizard, the "create a   |by standardizing file
   |patron category" step is|structure of it-IT web
   |skipped |installer

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20746] Improve behaviour of onboarding tool for Italian by standardizing file structure of it-IT installer

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20746

Katrin Fischer  changed:

   What|Removed |Added

Summary|Improve behaviour of|Improve behaviour of
   |onboarding tool for Italian |onboarding tool for Italian
   |by standardizing file   |by standardizing file
   |structure of it-IT web  |structure of it-IT
   |installer   |installer

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20746] Improve behaviour of onboarding tool for Italian by standardizing file structure of it-IT installer

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20746

--- Comment #5 from Katrin Fischer  ---
Created attachment 75228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75228=edit
k

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20746] Improve behaviour of onboarding tool for Italian by standardizing file structure of it-IT installer

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20746

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20737] Use https for Baker and Taylor cover images

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20737

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #75204|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 75230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75230=edit
Bug 20737: Use https for baker and taylor cover images

Easy change, should be able to verify with code review or testing with
dummy values

To test:
1 - Put some values in baker and taylor prefs (don't need to be valid)
2 - Do a search on the opac (and have some items with isbns)
3 - Inspect the cover images links to ensure they are formed correctly
4 - prove -v t/External/BakerTaylor.t

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16739] generate edifact showing on basket groups

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16739

--- Comment #8 from Jon Knight  ---
(In reply to Owen Leonard from comment #7)
> This looks like it's working correctly, but the QA tool has several
> complaints about tab indentation. Indentation should always be done with 4
> spaces.
> 
> There is one part of the template which I don't understand, starting at line
> 149:
> 
> [% IF (ediaccount) %]
>  class="fa fa-download"> Generate EDIFACT order
> [% ELSE %]
> 
> [% END %]
> 
> What is the purpose of the [% ELSE %] section? The  tag is incomplete, so
> I would expect this to break HTML rendering somehow.

Ah, good spot - I was putting in other text whilst testing the patch and left
the rump in there (but it didn't display on the browser so I didn't notice it).
 I'll get rid of the else clause (and see if I can munge the indentation into
something more acceptable!).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6172] Non-French UNIMARC frameworks need to be updated

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6172

--- Comment #13 from Giuseppe Ciaccio  ---
Yes I'm indeed :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75211|0   |1
is obsolete||
  Attachment #75219|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 75221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75221=edit
Bug 20724: Correctly mark an hold as waiting - ReservesNeedReturns

We need to call Koha::Hold->set_waiting to correctly
calculate the expiration date.

It fixes a regression introduced by
  commit 26634151dbce0bf39ff6c9eda5b58bb993996a2d
  Bug 12063 - Fix QA failures

The expiration date has to be set for waiting holds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|victor.grous...@biblibre.co |jonathan.dru...@bugs.koha-c
   |m   |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724

--- Comment #8 from Jonathan Druart  
---
Created attachment 75222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75222=edit
Bug 20724: Move the ReservesNeedReturns logic to AddReserve

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20120] Prevent writeoffs of more than the amount owed for a fee

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120

--- Comment #30 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #29)
> (In reply to Jonathan Druart from comment #27)
> > How do we get the redirect? Sounds like impossible as we have the JS check.
> 
> Never rely on client side validation ; )

Yes you are right, the problem is that it does not work.
It's easy to get the redirect:
  98 $amount=999;

Then you see: https://screenshots.firefox.com/8sNfHqHqxHpnMt45/pro.kohadev.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20623] PDF export of a basket group fails when an item has an itemtype that is not in the itemtype table

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20623

--- Comment #7 from Owen Leonard  ---
Created attachment 75225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75225=edit
Bug 20623: Fix basket group PDF when itemtype not itemtype table

When an item has an itemtype not in the itemtype table. Trying to fetch
it's description lead to an error.
Using authorized values like ccode to populate the itemtypes of the
biblioitems (instead of the itemtype table) can lead to such data.
Or importing records with invalid itemtype codes. Koha doesn't do enough
checks at import to at least warn about these issues.

== Test plan ==
1. first we need an item with an itype not in the item_types table
   1. download a record as MARCXML
   2. find it's item type in administration; and the related code
   3. open the MARCXML file and search for occurences of the code
and replace them by some non-existing value like "FOOBAR"
   4. also change the barcode so it won't be ignored because
it's a duplicate
   5. also change the title to easily find it later in the search
   6. tools → "Stage MARC records for import"
   7. upload your file
   8. "stage for import"
   9. click "Manage staged records"
You should end on the page related to your staged record
   10. "Import this batch into the catalog"

2. now we need it in a basket group
   1. have/create a active budget
   2. have/create a fund
   3. have/create a vendor with minimal info
   4. create a basket with minimal info
   5. add our imported item to the basket
for example search it by name
   6. go to the basket. URL should be
  /cgi-bin/koha/acqui/basket.pl?basketno=X
   7. close this basket
and tick "Attach this basket to a new basket group with the same name"
   8. you will end up in the basket groups lists
   9. go to the "closed" tab
   11. go to the basket group
  your vendor page => Basket groups => Closed

3. export as PDF, it should fail (internal server error)
 this is the bug (no kidding ^_^)
4. apply this patch
5. reexport the basket as PDF
6. it should work
7. create an item type (in administration)
 that has the same code as the one that you put in the MARCXML
8. reexport the basket as PDF
9. check that in the PDF that the description is here:
 table at the bottom of the document → "Document" column

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20623] PDF export of a basket group fails when an item has an itemtype that is not in the itemtype table

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20623

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19579] PatronSelfRegistrationEmailMustBeUnique does not prevent duplicates when using PatronSelfRegistrationVerifyByEmail

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19579

Owen Leonard  changed:

   What|Removed |Added

  Attachment #70136|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 75226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75226=edit
Bug 19579: Do not confirm the registration if email already used -
PatronSelfRegistrationEmailMustBeUnique

If PatronSelfRegistrationVerifyByEmail and
PatronSelfRegistrationEmailMustBeUnique are set, it should not be
possible to register twice with the same email.
However the test is made on already created patron cards when the
registration is done.
Which means it is possible to register several times with the same
email address and click on the registration link to finalise the
registration.

This patch adds a test when the registration link is clicked and display
the "Registration invalid" generic message if the same email is used

Test plan:
1. Patron submits self registration form using the same email address 3
   times
2. Patron receives 3 verification emails
3. Patron clicks on 3 verify token URLs
   => Only the first registration should succeed, the 2 others must fail

Maybe we should display a more specific message?

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20746] Improve behaviour of onboarding tool for Italian by standardizing file structure of it-IT installer

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20746

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #75212|0   |1
is obsolete||
  Attachment #75228|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 75229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75229=edit
Bug 20746: Move it-IT files to optional

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20735] Multiple LDAP servers

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20735

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Terence, Koha doesn't have a global road map, features get added as
libraries sponsor them to happen. If you are insterested in helping this along,
a starting point could be to switch this bug report to "Seeking cosponsors" or
even "Seeking developer". 

The feature itself I think would be an interesting addition to Koha.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75227|0   |1
is obsolete||

--- Comment #14 from M. Tompsett  ---
Created attachment 75231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75231=edit
Bug 20745: koha-zebra doesn't return the correct error codes

This patch makes koha-zebra return 0 (or 1) even when verbose mode is
off. This made koha-zebra --start always return a failure even when the
daemon was correctly launched.

To test:
- Have Zebra running for kohadev instance on your KohaDevBox
- Run:
  $ sudo koha-zebra --stop kohadev && echo yay || echo doh
=> FAIL: 'doh' is printed
- Run:
  $ sudo koha-zebra --start kohadev e&& echo yay || echo doh
=> FAIL: 'doh' is printed as well
- Apply this patch
- Run:
  $ sudo perl misc4dev/cp_debian_files.pl
  $ sudo koha-zebra --stop kohadev && echo yay || echo doh
=> SUCCESS: 'yay' is printed
- Run:
  $ sudo koha-zebra --start kohadev e&& echo yay || echo doh
=> SUCCESS: 'yay' is printed
- Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20120] Prevent writeoffs of more than the amount owed for a fee

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19579] PatronSelfRegistrationEmailMustBeUnique does not prevent duplicates when using PatronSelfRegistrationVerifyByEmail

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19579

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6172] Non-French UNIMARC frameworks need to be updated

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6172

--- Comment #11 from Giuseppe Ciaccio  ---
It seems that Koha/unimarc/en is working properly, provided the indexer has
started (which does not happen initially, but this is another story; see
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20737] Use https for Baker and Taylor cover images

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20737

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20746] Improve behaviour of onboarding tool for Italian by standardizing file structure of it-IT installer

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20746

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #8 from Katrin Fischer  ---
Counting Mark for SO and mine for QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789

--- Comment #85 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #84)
> Created attachment 75237 [details] [review]
> Bug 18789: Fix borrowernumber on members/files.tt

Pushed to master!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789

--- Comment #84 from Jonathan Druart  
---
Created attachment 75237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75237=edit
Bug 18789: Fix borrowernumber on members/files.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20719] Home library not displayed as expected

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #75143|0   |1
is obsolete||
  Attachment #75152|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 75238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75238=edit
Bug 20719: Add missing USE Branches to files.tt

Test

On a kohadevbox:
0. Enable the EnableBorrowerFiles system preference
1. Go to any patron, and click on the 'Files' tab in the
   left pane.
   -- the Home library is not displayed.
2. Apply the patch, restart_all, and reload the page.
   -- the Home library is now displayed.

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20719] Home library not displayed as expected

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719

--- Comment #9 from Katrin Fischer  ---
Created attachment 75239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75239=edit
Bug 20719: USE Branches in TT files

TEST PLAN
-
In the staff client on a kohadevbox:
1) Enable the HouseboundModule system preference.
2) Enable the EnableBorrowerFiles system preference.
3) Go to a patron detail page.
   -- note the Home library is shown.
4) Go to Fines tab (left pane)
   -- Home library is still shown.
5) Click each of the four horizontal tabs
   (Account, Pay fines, Create manual invoice,
Create manual credit)
   -- Home library not visible for both create tabs
  and the account tab
6) Click the 'Create manual invoice' tab, and create
   some kind of entry.
7) On the 'Account' tab, the table has a 'Details' button.
   Click that.
   -- Home library not visible.
8) Click the 'Details' tab in the left pane.
9) Click 'More' button and choose 'Delete'
   -- Home library not visible when asked for delete
  confirmation.
10) Cancel that, and if you know how to actually
set up the Norwegian system preferences you can
figure out how to test the nl-search change.

After seeing all these not visible, apply this patch.
Repeat all the steps, but this time the Home library
should be visible.

Works OK.

Signed-off-by: Amit Gupta 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20719] Home library not displayed as expected

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20719] Home library not displayed on all patron account tabs

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20719

Katrin Fischer  changed:

   What|Removed |Added

Summary|Home library not displayed  |Home library not displayed
   |as expected |on all patron account tabs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20752] Files tab in patron account is not properly capitalized

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20752

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20752] Files tab in patron account is not properly capitalized

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20752

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20752] Files tab in patron account is not properly capitalized

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20752

--- Comment #1 from Katrin Fischer  ---
Created attachment 75240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75240=edit
Bug 20752: Fix capitalization on the files tab for patron files

- Activate EnableBorrowerFiles
- Go to any patron account in staff
- Go to the files tab
- Check that strings on the page ar all properly capitalized
  - button
  - legend on section

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #75231|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 75233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75233=edit
Bug 20745: koha-zebra doesn't return the correct error codes

This patch makes koha-zebra return 0 (or 1) even when verbose mode is
off. This made koha-zebra --start always return a failure even when the
daemon was correctly launched.

To test:
- Have Zebra running for kohadev instance on your KohaDevBox
- Run:
  $ sudo koha-zebra --stop kohadev && echo yay || echo doh
=> FAIL: 'doh' is printed
- Run:
  $ sudo koha-zebra --start kohadev e&& echo yay || echo doh
=> FAIL: 'doh' is printed as well
- Apply this patch
- Run:
  $ sudo perl misc4dev/cp_debian_files.pl
  $ sudo koha-zebra --stop kohadev && echo yay || echo doh
=> SUCCESS: 'yay' is printed
- Run:
  $ sudo koha-zebra --start kohadev e&& echo yay || echo doh
=> SUCCESS: 'yay' is printed
- Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20745] indexing/searching not active at end of installation

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files)

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #75041|Bug 20706: Fixes the links  |Bug 20706: Fixes the links
description|to the manual to reflect|to the manual to reflect
   |chanced chapter file names  |changed chapter file names

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files)

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706

--- Comment #4 from Katrin Fischer  ---
Created attachment 75235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75235=edit
Bug 20706: Adds en language code to the links to the manual

As we don't have a fix yet to link to the right translated manual,
this adds /en to the links from the help files to the manual to
make them work again.

Check with both patches applied, that the links work.
You will have to change 17.11 to 18.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20729] Update style of datepickers

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Passed QA   |In Discussion

--- Comment #6 from Jonathan Druart  
---
Looks uglier for me, at least when editing a patron:

https://screenshots.firefox.com/yo0iX4PG4RacDzOX/pro.kohadev.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20752] New: Files tab in patron account is not properly capitalized

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20752

Bug ID: 20752
   Summary: Files tab in patron account is not properly
capitalized
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

Turn on EnableBorrowerFiles
Go to a patron record
Go to the Files tab

On the page displayed the button and the labels are not properly capitalized.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20695] Upload does not show all results when uploading multiple files

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20695] Upload does not show all results when uploading multiple files

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20695

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #75199|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 75234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75234=edit
Bug 20695: Fix multiple upload result in tools/upload script

Instead of calling UploadedFiles->find only once with $id, we should
extract all comma separated id's from the parameter.

Test plan:
[1] Before this patch, upload two files at once in Tools/Upload. After doing
so, you should see only one result reported. But both files should
have been uploaded.
[2] With this patch, repeat step 1 and see two upload results.

Signed-off-by: Marcel de Rooy 

Patch applies and functions as described.
Signed-off-by: Dilan Johnpullé 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20746] Improve behaviour of onboarding tool for Italian by standardizing file structure of it-IT installer

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20746

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75229|0   |1
is obsolete||

--- Comment #7 from M. Tompsett  ---
Created attachment 75236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75236=edit
Bug 20746: Move it-IT files to optional

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20746] Improve behaviour of onboarding tool for Italian by standardizing file structure of it-IT installer

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20746

M. Tompsett  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20746] Improve behaviour of onboarding tool for Italian by standardizing file structure of it-IT installer

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20746

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20722] Searching only for an ITEMTYPECAT itemtype is impossible

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20722

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #75153|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 75241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75241=edit
Bug 20722: Display search results when searching only by ITEMTYPECAT

- Create an entry for the ITEMTYPECAT authorised value category.
  Make sure to fill in the OPAC description.
- Go to administration > itemtypes and add the new category to 2 item types.
- Go to the OPAC and check that the advanced search shows your new itemtype
  group instead of the individual itemtypes.
- Check the checkbox and Search.

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20722] Searching only for an ITEMTYPECAT itemtype is impossible

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20722

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20404] Extended patron attributes should always be on

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20404

--- Comment #5 from Katrin Fischer  ---
Created attachment 75243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75243=edit
Bug 20404: Turn on ExtendedPatronAttributes by default for new installations

Extended patron attributes are a very useful feature that should be
more obvious. We should activate them by default for new installations.

For testing:
- Run the web isntaller on an empty database
- Check that after installation ExtendedPatronAttributs is turned on

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20404] Extended patron attributes should always be on

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20404

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20404] Extended patron attributes should always be on

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20404

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20707] Permissions for circ/ysearch.pl override specific page level permissions and delete sessions improperly

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20707

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #75220|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 75242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75242=edit
Bug 20707: Replace circ/search.pl circulate permission requirement with
catalogue

To test:
 1 - Setup a staff patron with permissions:
   - catalogue
   - reserveforothers
   - course_reserves
 2 - Log in to staff client as that patron
 3 - Find a record and click to place a hold
 4 - Type more than three letters into the search bar but don't submit
 5 - Note that you will not receive autocomplete results
 6 - Either submit, or try to visit any page in staff client
 7 - Your session has been expired, you must log in again
 8 - Log in, go to course reserves
 9 - As before, trigger the autocomplete search in the instrcutor field
10 - Again your session has been terminated
11 - Apply patch
12 - Repeat above actions, this time you will not be kicked out

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20707] Permissions for circ/ysearch.pl override specific page level permissions and delete sessions improperly

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20707

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20706

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20706] Fix links to help files for changed file structure (removed numbering on files)

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20706

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19817

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20754] Does table virtualshelfshares need a unique index on shelfnumber+borrowernumber+invitekey?

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20754

--- Comment #1 from Marcel de Rooy  ---
Created attachment 75245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75245=edit
Bug 20754: Db revision to remove double accepted shares

[Moved from bug 11943]

Although it is no problem to have them, we could do a cleanup.
This patch just removes duplicate rows from the table.

Note: I considered adding a unique index like:
ALTER TABLE virtualshelfshares ADD UNIQUE INDEX (shelfnumber,
borrowernumber, invitekey);
But the possible NULL values in borrowernumber and/or invitekey require
additional code changes. So I left it alone.

Test plan:
[1] Create two records with same borrowernumber and shelfnumber in the shares
table, if not present already.
[2] Run updatedatabase.pl

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017)

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

--- Comment #6 from Katrin Fischer  ---
Created attachment 75248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75248=edit
Bug 20709: (follow-up) Update GERMAN MARC frameworks to Update 26 (April 2018)

A follow-up in line with bug 20710.

Again, the files used here have been generated automatically
from the po files on translate.koha-community.org.

To test:
- Make sure the de-DE installer can install all mandatory files cleanly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Prevent double accepts in   |Koha::Virtualshelfshare
   |Koha::Virtualshelfshare |duplicates rows for the
   ||same list

--- Comment #21 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #19)

> The user click on a link and... nothing happens?

No, that is a misunderstanding. He clicks on the link and he is redirected to
view this shared list. The behavior interface-wise is exactly the same with and
without this patch. The only difference this bugfix makes is that the shared is
not duplicated.

> Should not we display a message to explain that the list is already shared?

I thought about it too. Strictly speaking, this bugfix can still be pushed
without string changes. And adding a message could be considered as an
enhancement for a new report. Opened bug 20753 for it.

In view of the above I am renaming/narrowing down the bug title. I will also
look at the commit message in that sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017)

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709

--- Comment #7 from Katrin Fischer  ---
(In reply to Bernardo Gonzalez Kriegel from comment #5)
> Hi Katrin, Bug 27010 adds a few new subfields.
> Translated files have been updated accordingly.
> 
> Maybe you could consider updating the patch (23+24+25+26)

Done, thx Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20754] Does table virtualshelfshares need a unique index on shelfnumber+borrowernumber+invitekey?

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20754

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=11943

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943

--- Comment #22 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #20)
> However, should not we put the update DB entry on a separate bug report and
> deal with the DB structure later? We will have to recheck the duplicate on
> create the unique constraint anyway.

I am not sure; see commit message. If we add a unique constraint, we need some
more code changes (replacing NULL by empty string and that kind).
We could move it to its own report and discuss further ;)
If we do not really care, the dbrev is sufficient with the changed code. I
opened report 20754 for it, but would certainly not mind pushing the third
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20754

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20754] New: Does table virtualshelfshares need a unique index on shelfnumber+borrowernumber+invitekey?

2018-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20754

Bug ID: 20754
   Summary: Does table virtualshelfshares need a unique index on
shelfnumber+borrowernumber+invitekey?
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Coming from bug 11943

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 110 matches

Mail list logo