[Koha-bugs] [Bug 21971] TestBuilder::build_sample_item

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Jonathan Druart changed: What|Removed |Added Attachment #82944|0 |1 is obsolete|

[Koha-bugs] [Bug 21971] TestBuilder::build_sample_item

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Jonathan Druart changed: What|Removed |Added Depends on||21798 Referenced Bugs:

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Jonathan Druart changed: What|Removed |Added Blocks||21971 Referenced Bugs:

[Koha-bugs] [Bug 21848] Handle encoding when calling Text::Unaccent::unac_string

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21848 --- Comment #8 from Marcel de Rooy --- Hmm. Something strange going on here. Note that adding use utf8; to Circulation.t also resolves the warning. Having trouble to catch the warn with warning_like and its friends. Should we

[Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 --- Comment #2 from Martin Renvoize --- Test plan: Prior to applying patch, both db_dependent/Circulation/Chargelostitem.t and db_dependent/Accounts.t tests should pass. After applying patch the above two tests should still pass.

[Koha-bugs] [Bug 21848] Handle encoding when calling Text::Unaccent::unac_string

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21848 --- Comment #9 from Marcel de Rooy --- Created attachment 83146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83146=edit Bug 21848: Counterpatch to resolve unac_string warning Just add "use utf8". Test plan:

[Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716 --- Comment #10 from Julian Maurice --- Created attachment 83147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83147=edit Bug 21716: Add missing $raw filters -- You are receiving this mail because: You are

[Koha-bugs] [Bug 21993] Be userfriendly when the CSRF token is wrong

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21993 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 21993] Be userfriendly when the CSRF token is wrong

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21993 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master -- You are

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #18 from Jonathan Druart --- Created attachment 83150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83150=edit Bug 21798: Unify the creation of bibliographic record in tests Using the newly created

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #19 from Jonathan Druart --- Created attachment 83151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83151=edit Bug 21798: Fix a wrong test Now biblioitem.itemtype has a value, GetItem should fill

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #20 from Jonathan Druart --- Created attachment 83152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83152=edit Bug 21798: Fix another test We should correctly generate the data we need, here we

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #22 from Jonathan Druart --- Created attachment 83154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83154=edit Bug 21798: replace gimme_a_biblio with build_sample_biblio -- You are receiving this

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Jonathan Druart changed: What|Removed |Added Attachment #82116|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #21 from Jonathan Druart --- Created attachment 83153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83153=edit Bug 21798: Replace 2 more occurrences -- You are receiving this mail because: You are

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Attachment #83156|0 |1 is obsolete|

[Koha-bugs] [Bug 21971] TestBuilder::build_sample_item

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 --- Comment #9 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #8) > I would expect to use builder inside build_sample_item and no longer see > C4::Items::AddItem. > No +1 from me ;) It does not work :) AddItem

[Koha-bugs] [Bug 21971] TestBuilder::build_sample_item

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 21605] Cannot create EDI account

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605 Marcel de Rooy changed: What|Removed |Added Attachment #81262|0 |1 is obsolete|

[Koha-bugs] [Bug 21931] Upgrade from 3.22 fails when running updatedatabase.pl script

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21931 Martin Renvoize changed: What|Removed |Added Attachment #83166|0 |1 is obsolete|

[Koha-bugs] [Bug 21988] Add SMSSendFrom system preference for specifying a source number for SMS messages

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 Kyle M Hall changed: What|Removed |Added Attachment #83132|0 |1 is obsolete|

[Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #38 from Marcel de Rooy --- Tomas, It seems that we still need your answer on the strict parameter question of Joubu now? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 21988] Add SMSSendFrom system preference for specifying a source number for SMS messages

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 21988] Add SMSSendFrom system preference for specifying a source number for SMS messages

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 --- Comment #6 from Kyle M Hall --- Created attachment 83176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83176=edit Bug 21988: (follow-up) Provide more open params Rather than specifying a very specific

[Koha-bugs] [Bug 21994] New: Multiple system preferences in a group should be separated into new lines

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21994 Bug ID: 21994 Summary: Multiple system preferences in a group should be separated into new lines Change sponsored?: --- Product: Koha Version: master

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #23 from Marcel de Rooy --- Created attachment 83156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83156=edit Bug 21798: (QA follow-up) Fix Biblios.t Global symbol "$bibnum" requires explicit package

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #24 from Marcel de Rooy --- This fails with me (with and without your patches): not ok 4 - Item on hold skipped, count makes sense # Failed test 'Item on hold skipped, count makes sense' # at

[Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize changed: What|Removed |Added Attachment #81889|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #32

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::build_sample_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #33 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #32) > Taking the liberty of passing QA in one run. > Nick: Only affects test suite. Multiple rebasing avoided? +1 -- You are receiving this mail

[Koha-bugs] [Bug 21971] TestBuilder::build_sample_item

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 21971] TestBuilder::build_sample_item

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #11

[Koha-bugs] [Bug 21605] Cannot create EDI account

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605 --- Comment #9 from Marcel de Rooy --- Created attachment 83167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83167=edit Bug 21605: Ensure EDI acct fields set to boolean val Validate the input to the fields

[Koha-bugs] [Bug 21605] Cannot create EDI account

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch

[Koha-bugs] [Bug 21605] Cannot create EDI account

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605 --- Comment #10 from Marcel de Rooy --- Created attachment 83168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83168=edit Bug 21605: (follow-up) Simple ternary boolean to number conversion Imo it is much easier

[Koha-bugs] [Bug 21880] "Relationship information" disappears when accessing paginated results in authority searches

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 --- Comment #11 from Marcel de Rooy --- (In reply to Andreas Roussos from comment #8) > (In reply to Marcel de Rooy from comment #4) > > I am trying to reproduce this under MARC21 with 400 but somehow i do not > > succeed to. Please

[Koha-bugs] [Bug 21880] "Relationship information" disappears when accessing paginated results in authority searches

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Marcel de Rooy changed: What|Removed |Added Attachment #82619|0 |1 is obsolete|

[Koha-bugs] [Bug 21880] "Relationship information" disappears when accessing paginated results in authority searches

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 --- Comment #10 from Marcel de Rooy --- Created attachment 83174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83174=edit Bug 21880: (follow-up) Add some uri filters Theoretically, source needs a filter.

[Koha-bugs] [Bug 21880] "Relationship information" disappears when accessing paginated results in authority searches

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off QA

[Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716 Julian Maurice changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 21991] Displaying more rows on report results does not work for reports with parameters

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21991 Martin Renvoize changed: What|Removed |Added Attachment #83141|0 |1 is obsolete|

[Koha-bugs] [Bug 21991] Displaying more rows on report results does not work for reports with parameters

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21991 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::build_sample_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Summary|We need |We need

[Koha-bugs] [Bug 21971] TestBuilder::build_sample_item

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 --- Comment #8 from Marcel de Rooy --- I would expect to use builder inside build_sample_item and no longer see C4::Items::AddItem. No +1 from me ;) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 21971] TestBuilder::build_sample_item

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch

[Koha-bugs] [Bug 21971] TestBuilder::build_sample_item

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Marcel de Rooy changed: What|Removed |Added Attachment #83139|0 |1 is obsolete|

[Koha-bugs] [Bug 21931] Upgrade from 3.22 fails when running updatedatabase.pl script

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21931 Kyle M Hall changed: What|Removed |Added Attachment #83001|0 |1 is obsolete|

[Koha-bugs] [Bug 21931] Upgrade from 3.22 fails when running updatedatabase.pl script

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21931 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Kyle M Hall changed: What|Removed |Added Attachment #83022|0 |1 is obsolete|

[Koha-bugs] [Bug 21988] Add SMSSendFrom system preference for specifying a source number for SMS messages

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 --- Comment #4 from Andrew Isherwood --- Created attachment 83170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83170=edit Bug 21988: (follow-up) Provide more open params Rather than specifying a very specific

[Koha-bugs] [Bug 21931] Upgrade from 3.22 fails when running updatedatabase.pl script

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21931 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #6

[Koha-bugs] [Bug 21880] "Relationship information" disappears when accessing paginated results in authority searches

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21880 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #12

[Koha-bugs] [Bug 21957] LinkBibHeadingsToAuthorities can be called twice when running link_bibs_to_authorities

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21957 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2

[Koha-bugs] [Bug 21988] Add SMSSendFrom system preference for specifying a source number for SMS messages

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 --- Comment #3 from Andrew Isherwood --- Test plan: - Apply the patch and do the database update - Navigate to the SMS preferences - TEST => Observe that a new "Define a number from which SMS messages will be sent" preference

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Attachment #83151|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Attachment #83149|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Attachment #83152|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Attachment #83150|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Attachment #83154|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Attachment #83153|0 |1 is obsolete|

[Koha-bugs] [Bug 21931] Upgrade from 3.22 fails when running updatedatabase.pl script

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21931 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize changed: What|Removed |Added Attachment #83164|0 |1 is obsolete|

[Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 --- Comment #5 from Martin Renvoize --- I will add tests for the new/altered behaviour here.. the existing tests do not cover the effect of the FinesLog at all right now. -- You are receiving this mail because: You are the

[Koha-bugs] [Bug 21957] LinkBibHeadingsToAuthorities can be called twice when running link_bibs_to_authorities

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21957 --- Comment #3 from Nick Clemens --- (In reply to Marcel de Rooy from comment #2) > You add this parameter. I would expect it to be used somewhere in the misc > script for instance? What am I missing? Looks like I missed a 'git

[Koha-bugs] [Bug 21950] query_cgi and limit_cgi must not be filtered template-side

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 21950] query_cgi and limit_cgi must not be filtered template-side

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950 Martin Renvoize changed: What|Removed |Added Attachment #83021|0 |1 is obsolete|

[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 21995] New: test

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21995 Bug ID: 21995 Summary: test Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: Windows Status: NEW Severity: normal

[Koha-bugs] [Bug 21973] CAS URL escaped twice, preventing login

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21973 Martin Renvoize changed: What|Removed |Added Attachment #83169|0 |1 is obsolete|

[Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #39 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #38) > Tomas, > It seems that we still need your answer on the strict parameter question of > Joubu now? I don't like it, generally. But I see no

[Koha-bugs] [Bug 21986] quotation marks are wrongly escaped in several places

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21986 Martin Renvoize changed: What|Removed |Added Attachment #83120|0 |1 is obsolete|

[Koha-bugs] [Bug 21986] quotation marks are wrongly escaped in several places

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21986 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 21950] query_cgi and limit_cgi must not be filtered template-side

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950 Bug 21950 depends on bug 21878, which changed state. Bug 21878 Summary: Fix few links for opac pagination and facets (no uri filter) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 What|Removed

[Koha-bugs] [Bug 21878] Fix few links for opac pagination and facets (no uri filter)

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 21995] test

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21995 piumi changed: What|Removed |Added Deadline||2018-12-31 -- You are receiving

[Koha-bugs] [Bug 21997] SIP patron information requests can lock patron out of account

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21997 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Trivial patch

[Koha-bugs] [Bug 21997] SIP patron information requests can lock patron out of account

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21997 --- Comment #1 from Kyle M Hall --- Created attachment 83183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83183=edit Bug 21997 - SIP patron information requests can lock patron out of account Many SIP services

[Koha-bugs] [Bug 21997] SIP patron information requests can lock patron out of account

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21997 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 20194] Display both biblioitems.itemtype and items.itype in circulation screens

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 21874] Encoding broken in list and cart email subjects

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21874 Jesse Maseto changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable

[Koha-bugs] [Bug 21644] UNIMARC XSLT display of 210 in intranet

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21644 Jesse Maseto changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable

[Koha-bugs] [Bug 21730] PA_CLASS missing from list of authorized values categories

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21730 Jesse Maseto changed: What|Removed |Added Status|Signed Off |Pushed for QA -- You are

[Koha-bugs] [Bug 21436] Switch two-column templates to Bootstrap grid: Tools part 4

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21436 Jonathan Druart changed: What|Removed |Added Attachment #82180|0 |1 is obsolete|

[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #27 from Jonathan Druart --- Created attachment 83180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83180=edit Bug 20959: Prevent the scrollbar to move to the top on click We could use

[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #28 from Jonathan Druart --- (In reply to Jonathan Druart from comment #27) > Created attachment 83180 [details] [review] > Bug 20959: Prevent the scrollbar to move to the top on click Hi Owen, can you give me your

[Koha-bugs] [Bug 21730] PA_CLASS missing from list of authorized values categories

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21730 Jesse Maseto changed: What|Removed |Added Resolution|FIXED |---

[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #7 from Jonathan Druart --- Kyle, Can you give an example please? How would you display table.column in iso format without the time part? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize changed: What|Removed |Added Attachment #83186|0 |1 is obsolete|

[Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize changed: What|Removed |Added Attachment #83187|0 |1 is obsolete|

[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #10 from Jonathan Druart --- Created attachment 83188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83188=edit Bug 21824: Add tests -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize changed: What|Removed |Added Attachment #83172|0 |1 is obsolete|

[Koha-bugs] [Bug 17006] Add route to change patron's password

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are

[Koha-bugs] [Bug 17006] Add route to change patron's password

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 --- Comment #64 from Jonathan Druart --- Sorry Tomas but I think we should use set_password (from bug 21178) now. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #6 from Nick Clemens --- (In reply to Jonathan Druart from comment #5) > Hi Nick, Kyle, > Can you give more info about the use cases? Which problems are you trying to > solve with these patches? When libraries want to

[Koha-bugs] [Bug 20194] Display both biblioitems.itemtype and items.itype in circulation screens

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are

[Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 --- Comment #10 from Martin Renvoize --- Test Plan 1) Confirm t/db_dependant/Account.t and t/db_dependant/Circulation/Chargelostitem.t test pass before applying any patches. 2) Confirm that one test fails in

[Koha-bugs] [Bug 20194] Display both biblioitems.itemtype and items.itype in circulation screens

2018-12-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 --- Comment #14 from Jonathan Druart --- (In reply to Katrin Fischer from comment #12) > I am not sure about the terminology of using Record type - this is still an > itemtype, just from a different level. I think it gives a wrong

  1   2   >