[Koha-bugs] [Bug 22045] New: cataloging UX enhancement

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045

Bug ID: 22045
   Summary: cataloging UX enhancement
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
  Target Milestone: ---

Created attachment 83473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83473=edit
vertical displaying tabs

it would be nice if on the cat_addbiblio page the ui-tabs-nav (0-9 tabs) were
either fixed OR also available at the bottom of the page so catalogers don't
have to scroll all the way back up to the top of the page each time they want
to switch tabs. 
I have experimented with displaying them vertical instead of horizontal, with a
position of fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22020] Configure Columns for Patron Issues checkin hides renewal

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22020

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #83401|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 83472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83472=edit
Bug 22020: (bug 21777 follow-up) Fix columns visibility for circulation.pl

The table is used by circulation.pl and moremember.pl
When it is modified we need to take care of the two view.

Test plan:
Use the columns settings to hide/show the "check in" and other columns
Confirm the this patch fixes the display for moremember.pl

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22020] Configure Columns for Patron Issues checkin hides renewal

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22020

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21170] Warnings in MARCdetail.pl - isn't numeric in numeric eq (==)

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21170

Pierre-Marc Thibault  changed:

   What|Removed |Added

  Attachment #83303|0   |1
is obsolete||

--- Comment #2 from Pierre-Marc Thibault  ---
Created attachment 83471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83471=edit
Bug 21170 Remove "isn't numeric in numeric eq (==)" warnings in MARCdetail

Easily removed switching the two conditions.

Test plan:
Hit catalogue/MARCdetail.pl?biblionumber=1
=> Without this patch you will see in the log warnings like
  Argument "ddc" isn't numeric in numeric eq (==) at
/home/vagrant/kohaclone/catalogue/MARCdetail.pl line 277.
=> With this patch applied the warnings do no longer appear

Signed-off-by: Pierre-Marc Thibault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21170] Warnings in MARCdetail.pl - isn't numeric in numeric eq (==)

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21170

Pierre-Marc Thibault  changed:

   What|Removed |Added

 CC||pierre-marc.thibault@inlibr
   ||o.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21961] Typo in permission keeps Did you mean? config from showing up

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21961

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #8 from Lucas Gass  ---
missing 14391 dependency not backporting to 18.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21908] biblio_metadata is missing from the rebuild_zebra.pl tables list

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #11 from Lucas Gass  ---
backported to 18.05 for 18.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959

Pierre-Marc Thibault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959

Pierre-Marc Thibault  changed:

   What|Removed |Added

  Attachment #83392|0   |1
is obsolete||

--- Comment #5 from Pierre-Marc Thibault  ---
Created attachment 83470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83470=edit
Bug 21959: Batch item modification - ability to apply regular expression on
text fields

Test plan:
  - go to Tools > Batch item modification,
  - select items to modify,
  - for one or some text fields, check the second checkbox (Use regular
expression) and type your regex,
  - check the regex has been applied.

Signed-off-by: Pierre-Marc Thibault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22039] Switching the language in staff sends you back to start page

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22039

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #5 from Katrin Fischer  ---
Hi Jonathan, thx for investigating! I had reset my installation and that had
also reset the BaseURLs (http://kohadev.myDNSname.org:80...). After correcting
them, everything works as expected!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||22016


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22016
[Bug 22016] Always send CT field for SIP checkin, even if empty
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22016] Always send CT field for SIP checkin, even if empty

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22016

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||22043


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043
[Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

--- Comment #1 from Nick Clemens  ---
Created attachment 83469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83469=edit
Bug 22044: Set default and add NoRenewalBeforePrecision preference for
new/affected installs

I am not sure the correct answer - for upgraded installs the pref was
set to date, which changed behaviour

For new installs the pref was unset, behaved as if 'exact_time' so we
shouldn't change behaviour?

If the perceived default is date then the code should be changed, or
this shouldn't be a pref at all?

To test:
1 - Have a new system missing this pref
2 - Note when searchign the pref in staff client if appears as 'date'
3 - Check the db to confirm value is 'NULL'
4 - Apply patch and run update
5 - Pref is now set to 'exact_time'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22044] NoRenewalBeforePrecision should be set by default for new installations

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Nick Clemens  changed:

   What|Removed |Added

Summary|NoRenewalBeforePrecision|NoRenewalBeforePrecision
   |should be set by default|should be set by default
   ||for new installations

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22044] New: NoRenewalBeforePrecision should be set by default

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22044

Bug ID: 22044
   Summary: NoRenewalBeforePrecision should be set by default
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

NoRenewalBeforePrecision was introduced in bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 but did not
recieve a default value

When not set the pref dropdown default to 'date' however, the behaviour if
unset matches 'exact time'

We should set it to 'exact time' by default since it is the default behaviour

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043

--- Comment #1 from Kyle M Hall  ---
Created attachment 83468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83468=edit
Bug 22043: SIP Checkin Response alert flag set to often set to Y incorrectly

If a checkin has any messages at all, even informational like LocalUse, the
alert flag ( 4th character of the response ) will be set to Y, even if we do
not prove a corresponding alert code in the CV field. We should only set the
alert flag if we are going to send a value in the CV field.If a checkin has any
messages at all, even informational like LocalUse, the alert flag ( 4th
character of the response ) will be set to Y, even if we do not prove a
corresponding alert code in the CV field. We should only set the alert flag if
we are going to send a value in the CV field.

Test Plan:
1) Set the checked_in_ok sip account flag to 1 for an account
2) Check in an already checked in item via SIP
3) Note the alert flag is set to Y
4) Apply this patch
5) Restart SIP
6) Check the item in again
7) Note the alert flag is set to N

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22027] Upload cover image

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22027

--- Comment #7 from Federico Paiz  ---
yes, I did all the steps but still asking for the tmp. There are some steps for
new ones for 18.11?, because in versions 16 they worked well for me and now
it's still the same

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22043] New: SIP Checkin Response alert flag set to often set to Y incorrectly

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043

Bug ID: 22043
   Summary: SIP Checkin Response alert flag set to often set to Y
incorrectly
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com
  Target Milestone: ---

If a checkin has any messages at all, even informational like LocalUse, the
alert flag ( 4th character of the response ) will be set to Y, even if we do
not prove a corresponding alert code in the CV field. We should only set the
alert flag if we are going to send a value in the CV field.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22032] Improve local cover image tab on detail page

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block refund generation when item is withdrawn and lost

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Martha Fuerst  changed:

   What|Removed |Added

 CC||mfue...@hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17406] Simplify pay.pl interface buttons

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17406

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

Blou  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #26 from Blou  ---
This patch does not fix the incongruities of having the 1.035 fine display as
1.04 in some screen and 1.03 in others.

But this simple patch (independant from the others offered, careful when
applying), does fix the impossible payment situation in a very elegant way.  I
think. :-)

This is the most important.  Trying to fix all the displays for quarter cents,
or all input methods if you manage, would still leave clients just migrating
with funky data in the situation of not being able to clear the fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21955] Cache::Memory should not be used as L2 cache

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21955

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_18_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #25 from Blou  ---
Created attachment 83467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83467=edit
Bug 17140: fix rounding errors when paying fines

Whenever a fine (accountlines in DB) has a precision longer than two floating
points, it becomes very hard for a user to clear it.
Ex: 1.035 will be displayed as 1.04 or 1.03 depending on the screen.  But
entering any of those value in Pay Fine will not clear it.
The user has no way to know the exact value to enter.

This fix makes sure that the intent of the user is met, by matching the EXACT
needed sum when the difference is less than 0.01.

TEST
1) Create a 1.035 fine
  - Go to a Patron screen
  - Fines tab on the left
  - Create manual invoice
2) go to Pay fines, click Pay amount on bottom left.
3) It will show 1.03 as Total, and as Collect from patron.  Click confirm.
4) An error message will appear.
5) Apply patch, do again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block refund generation when item is withdrawn and lost

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042

--- Comment #1 from Andrew  ---
Bug 21231 plugged this same hole for BlockReturnofLostItems:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21231

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22042] New: BlockReturnofWithdrawn Items does not block refund generation when item is withdrawn and lost

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042

Bug ID: 22042
   Summary: BlockReturnofWithdrawn Items does not block refund
generation when item is withdrawn and lost
 Change sponsored?: ---
   Product: Koha
   Version: 18.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

If BlockReturnofWithdrawnItems is set to block and an item that is both
withdrawn and lost is checked in, Koha will not mark the item as returned but
will mark it as found and generate a refund if circ rules allow refunds.

To test:
- Set BlockReturnofWithdrawnItems to Block
- Set BlockReturnofLostItems to Don't Block
- Set Default lost item fee refund on return policy to Yes
- Check out an item with a replacement cost to a patron
- Mark the item as lost
- Mark the item as withdrawn
- Note that the patron now has a charge for the replacement fee
- Check the item in
- Note that the patron now has a credit for the replacement fee

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21399] Sort patron fines in OPAC by date descending as a default

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21399

Devinim  changed:

   What|Removed |Added

  Attachment #82683|0   |1
is obsolete||

--- Comment #2 from Devinim  ---
Created attachment 83466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83466=edit
Bug 21399: Sort patron fines in OPAC by date descending as a default

This patch modifies the DataTables configuration of the logged-in user's
"Fines and charges" table in the OPAC so that the table is sorted by
date, descending.

To test, apply the patch and log in to the OPAC as a user with multiple
fines. Go to the "your fines" page and confirm that the table is sorted
by default on the first column with the newest entries first.

Signed-off-by: Devinim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21399] Sort patron fines in OPAC by date descending as a default

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21399

Devinim  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21962] The `searching entire record` option in authority searches is currently failing

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21962

Jonathan Druart  changed:

   What|Removed |Added

 CC||ha...@orex.es

--- Comment #10 from Jonathan Druart  
---
*** Bug 22040 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22040] authorities search

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22040

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #3 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 21962 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22034] Viewing record with Default framework doesn't work on MARC tab

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22034

Devinim  changed:

   What|Removed |Added

  Attachment #83437|0   |1
is obsolete||

--- Comment #2 from Devinim  ---
Created attachment 83465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83465=edit
Bug 22034: Handle default framework for MARC view with framework

To test:

- Create a record in any framework that is not default
- Search for the record in your catalog
- Switch to the MARC tab
- Change framework pull down to default on top
- Note the page reloads and the framework stay default
- Verify it works for other frameworks

Also test the "labeled MARC" view (you will need the pref viewLabeledMARC
turned on)

Signed-off-by: Devinim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22034] Viewing record with Default framework doesn't work on MARC tab

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22034

Devinim  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20128] Permission for advanced editor

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   Assignee|k...@bywatersolutions.com   |n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22040] authorities search

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22040

--- Comment #2 from Hugo Agud  ---
Yes, you’re right, if I search main heading it works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21962] The `searching entire record` option in authority searches is currently failing

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21962

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22040

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22040] authorities search

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22040

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21962
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
Hola Hugo,
Are you using the 'search entire record' tab?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22039] Switching the language in staff sends you back to start page

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22039

--- Comment #4 from Jonathan Druart  
---
I confirm it works at the staff interface too if the staffClientBaseURL pref is
correctly filled.
Double check the protocol part http[s?]://

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22031] C4::Auth->haspermission should allow checking for more than one subpermission

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #3 from Martin Renvoize  ---
This works well enough... But.. what if we wanted to introduce the ability to
compare logically with OR or AND in the future.. by adding arrayref as 'AND'
here we'll be doing the exact opposite of what SQL::Abstract does...  

I'm going to try and come up with an alternative that more closely resembles
SQL::Abstract so we're not dealing with two very similar but opposing
constructs in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22039] Switching the language in staff sends you back to start page

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22039

Jonathan Druart  changed:

   What|Removed |Added

Summary|Switching the language in   |Switching the language in
   |staff and OPAC sends you|staff sends you back to
   |back to start page  |start page
   Severity|major   |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22039] Switching the language in staff and OPAC sends you back to start page

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22039

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Works ok for me at the OPAC when OPACBaseURL is correctly filled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21577] Enable Koha to act as Shibboleth identity provider

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21577

--- Comment #2 from Josef Moravec  ---
I implemented a module for simplesamlphp that is using ils-di, it is here if
anybody interested:

https://gitlab.com/josef.moravec/simplesamlphp-koha-ils-di-authentication-module

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22009] Possible mistake in error messages for classification sources and filing rules

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22009

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #83440|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 83464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83464=edit
Bug 22009: Fix error messages for filing rules and splitting rules.

Some error messages were doubled up with different error codes.

To test:
I am not sure how to trigger those from the GUI, might
require a code review/code changes.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22009] Possible mistake in error messages for classification sources and filing rules

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22009

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515

Devinim  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||kohadevi...@devinim.com.tr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515

Devinim  changed:

   What|Removed |Added

  Attachment #83367|0   |1
is obsolete||

--- Comment #5 from Devinim  ---
Created attachment 83463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83463=edit
Bug 13515: Add a foreign key constraint to messages.borrowernumber

This patch adds a missing foreign key constraint to
mesages.borrowernumber.
To create it sucessfully the entries from the messages table that are
not linked with an existing patron will be removed.

Test plan:
0/ Do not apply the patch
1/ Add messages to different patrons
2/ Delete one of the patron's record
3/ Have a look at the messages table and notice that the messages for
the deleted patron's record still appear
4/ Apply the patch and execute the update DB entry
5/ Have a look again at the messages table and notice that the messages
for the deleted patron's record have been removed
6/ Delete a patron that have messages
7/ Notice that now the messages are deleted when the patron's record is
deleted

Signed-off-by: Devinim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/18.11.x)

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

--- Comment #15 from Martin Renvoize  ---
Pushed, thanks Mirko

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/18.11.x)

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #83442|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] Missing constraints on accountlines

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #10 from Martin Renvoize  ---
Oh.. I also made the DB update more reliably idempotent (so this can be easily
backported if we want)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] Missing constraints on accountlines

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #9 from Martin Renvoize  ---
Tests added, rebased now that 21065 is in master and DBIC Schema Updates patch
added for easy testing.

Man I wish we could just use the relations the dbic gives us for free once we
have proper constraints :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] Missing constraints on accountlines

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #7 from Martin Renvoize  ---
Created attachment 83461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83461=edit
Bug 22008: Add tests for new constraints

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] Missing constraints on accountlines

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #83280|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 83460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83460=edit
Bug 22008: Add missing constraints to accountlines

Add constraints for manager_id referencing the borrowers table and issue_id
referencing the issues table and update the itemnumber constraint from
`ON UPDATE SET NULL` to `ON UPDATE CASCADE`

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22008] Missing constraints on accountlines

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008

--- Comment #8 from Martin Renvoize  ---
Created attachment 83462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83462=edit
Bug 22008: DBIC Schema Updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #114 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #96)
> I like the approach of the new permission depending on order_manage and
> edit_subscription
Excellent!

> 1) You need to update installer/data/mysql/userpermissions.sql so the
> permission is installed for new installations.
Done!

> ::: admin/additional-fields.pl
> @@ +33,5 @@
> > +my $op = $input->param('op') // ( $tablename ? 'list' : 'list_tables' );
> > +
> > +if( $op ne 'list_tables' ){
> > +$flagsrequired{acquisition} = 'order_manage' if $tablename eq 
> > 'aqbasket';
> > +$flagsrequired{serials} = 'edit_subscription' if $tablename eq 
> > 'subscription';
> 
> 2) I think you'd want to change this to use the new permission now.
I do set it in the lines above - the main permission gets you to the page, you
need the others to access the individual modules

> 
> :::
> installer/data/mysql/atomicupdate/
> Bug_15774_add_additional_fields_permissions.perl
> @@ +6,5 @@
> > +(3,'manage_additional_fields','Add, edit, or delete additional 
> > custom fields for baskets or subscriptions (also requires order_manage or 
> > edit_subscription permissions)')
> > +});
> > +$dbh->do( q{
> > +INSERT INTO user_permissions (borrowernumber, module_bit, code)
> > +SELECT borrowernumber, 3, 'manage_additional_fields' FROM 
> > borrowers WHERE borrowernumber IN (SELECT DISTINCT borrowernumber FROM 
> > user_permissions WHERE code = 'order_manage' OR code = 'edit_subscription');
> 
> 3) This will work for everyone who has not full Serials permission. If the
> top level "Serials" permission is checked, the granular ones are not in
> user_permissions. You also need to check for those using the bit operation.
Updated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #113 from Katrin Fischer  ---
ah, I think I understand 2) now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #112 from Nick Clemens  ---
Created attachment 83459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83459=edit
Bug 15774: Add permission for managing additional fields

To test:
 1 - Have three borrowers, one with order_manage permission, one with
 edit_subscription permisson, andone with both
 2 - Apply patch, updatedatabase
 3 - Verify all three now have the manage_additional_fields permission
 4 - Visit the admin page with these users, they should all see the
 'Manage additional fields' link
 5 - Click the link
 6 - User with order_manage should see 'Order baskest'
 7 - User with edit_subscription should see 'Subscriptions'
 8 - User with both should see both
 9 - Remove the additional permissions from a user - they should see a
 note about needing additional permissions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #111 from Nick Clemens  ---
Created attachment 83458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83458=edit
Bug 15774: Remove unecessary returned value for ->delete

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #110 from Nick Clemens  ---
Created attachment 83457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83457=edit
Bug 15774: Do not fetch additional fields from GetSubscription

Finally we do not want that, they should be fetch when needed

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #109 from Nick Clemens  ---
Created attachment 83456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83456=edit
Bug 15774: Fix and unify additional_fields in C4::Serials

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #107 from Nick Clemens  ---
Created attachment 83454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83454=edit
Bug 15774: Fix insert and update for subscription

Call it a typo

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #108 from Nick Clemens  ---
Created attachment 83455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83455=edit
Bug 15774: Add missing tests for Koha::Object::Mixin::AdditionalFields

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #105 from Nick Clemens  ---
Created attachment 83452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83452=edit
Bug 15774: (follow-up) Address QA issues

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #106 from Nick Clemens  ---
Created attachment 83453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83453=edit
Bug 15774: Use the include file to display the subscription's additional fields

We have it, why not to use it?

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #98 from Nick Clemens  ---
Created attachment 83445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83445=edit
Bug 15774: (QA follow-up) Make sure that tablename is correctly saved

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #104 from Nick Clemens  ---
Created attachment 83451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83451=edit
Bug 15774: Fix JS check when AV and MARC field are both selected

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #103 from Nick Clemens  ---
Created attachment 83450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83450=edit
Bug 15774: (follow-up) Add html filters

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #101 from Nick Clemens  ---
Created attachment 83448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83448=edit
Bug 15774: Add POD and license notices

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #99 from Nick Clemens  ---
Created attachment 83446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83446=edit
Bug 15774: Fix additional fields filters

Addresses the following QA comments:

1/ Regression:
On serials/serials-search.pl, the filters are not filled with what the
users searched for and the additional fields linked to an AV are not
displayed as a dropdown list.

4/ When searching an order, there is no way not to set a "all" value for
additional fields linked to AV.

5/ When searching an order and the search does not return any results,
the field should contain what the user filled in.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #102 from Nick Clemens  ---
Created attachment 83449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83449=edit
Bug 15774: Show additional field values in edit form

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #100 from Nick Clemens  ---
Created attachment 83447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83447=edit
Bug 15774: Use Koha::Object(s) for additional fields

A lot of code can be removed just by using Koha::Object

It also makes fetching and updating additional field values easier.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15774] Additional fields for baskets

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

Nick Clemens  changed:

   What|Removed |Added

  Attachment #83349|0   |1
is obsolete||
  Attachment #83350|0   |1
is obsolete||
  Attachment #83351|0   |1
is obsolete||
  Attachment #83352|0   |1
is obsolete||
  Attachment #83353|0   |1
is obsolete||
  Attachment #83354|0   |1
is obsolete||
  Attachment #83355|0   |1
is obsolete||
  Attachment #83356|0   |1
is obsolete||
  Attachment #83357|0   |1
is obsolete||
  Attachment #83358|0   |1
is obsolete||
  Attachment #83359|0   |1
is obsolete||
  Attachment #83360|0   |1
is obsolete||
  Attachment #83361|0   |1
is obsolete||
  Attachment #83362|0   |1
is obsolete||
  Attachment #83363|0   |1
is obsolete||
  Attachment #83364|0   |1
is obsolete||

--- Comment #97 from Nick Clemens  ---
Created attachment 83444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83444=edit
Bug 15774: Add additional fields to order baskets

This also moves the admin page for additional fields for all tables to a
single common screen, and factors out display/input parsing logic.

Test plan:
  1. Create an additional field for a subscription (under Serials -> Add
 subscription fields).
  2. Apply patch.
  3. Visit Additional fields under administration, and verify that
 the field created above still shows under the list for the
 subscription table.
  4. Create at least four fields for aqbasket for each combination of
 searchable/not-searchable and with/without an authorized value.
  5. Create an order basket, and verify that all fields are visible and
 correctly save.
  6. Edit the basket, verifying that changes to these additional fields
 are saved.
  7. Add an order to the basket (contents are irrelevant).
  8. Go to advanced search within acquisitions.
  9. Verify that only the searchable fields show in the form, and that
 their contents may be searched.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||14591


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591
[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue
fines
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||14825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/18.11.x)

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/18.11.x)

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #14 from Mirko Tietgen  ---
Is in 18.11.01 package, please push for 18.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/18.11.x)

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Mirko Tietgen  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21491] When 'Default lost item fee refund on return policy' is unset it says no but acts as if 'yes'

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21491

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #4 from Martin Renvoize  ---
SO hat on, works fine signing off..

QA hat on.. could we perhaps have a regression test for this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21491] When 'Default lost item fee refund on return policy' is unset it says no but acts as if 'yes'

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21491

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #82639|0   |1
is obsolete||

--- Comment #3 from Martin Renvoize  ---
Created attachment 83443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83443=edit
Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set

To test:
1 - Delete all refund_lost_item_fee_rules form the db
delete from refund_lost_item_fee_rules;
2 - View the Standard circ rules - Default lost item fee refund shows as
'No'
3 - View circ rules for a single library, shows as 'Default (Yes)'
4 - Return a lost item, it actually does refund (this is in the
LostItemFeeRules code, default 1 if not set)
5 - Apply patch
6 - Rule shows as 'Yes'
7 - View a specifc rule, still says Default (Yes)

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22041] Not upgrade 18.11.01

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22041

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID
 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
The packages have not been updated yet, just try again in the next few days.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22041] New: Not upgrade 18.11.01

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22041

Bug ID: 22041
   Summary: Not upgrade 18.11.01
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Release tools
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: vbovic...@gmail.com
  Target Milestone: ---

not updated 18.11.01

http://debian.koha-community.org/koha stable main
OR
http://debian.koha-community.org/koha 18.11 main

apt-get install koha-common
Lendo listas de pacotes... Pronto
Construindo árvore de dependências
Lendo informação de estado... Pronto
koha-common is already the newest version (18.11.00-4).
Os seguintes pacotes foram instalados automaticamente e já não são necessários:
  libconvert-basen-perl libcrypt-gcrypt-perl libio-sessiondata-perl
  liblocale-maketext-lexicon-perl libossp-uuid-perl libossp-uuid16
  libsoap-lite-perl libxmlrpc-lite-perl linux-headers-4.15.0-39
  linux-headers-4.15.0-39-generic linux-image-4.15.0-39-generic
  linux-modules-4.15.0-39-generic linux-modules-extra-4.15.0-39-generic
Utilize 'apt autoremove' para os remover.
0 pacotes atualizados, 0 pacotes novos instalados, 0 a serem removidos e 3 não
atualizados.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22040] New: authorities search

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22040

Bug ID: 22040
   Summary: authorities search
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ha...@orex.es
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Koha 18.11.0 debian 9 from an upgrade

We are not able to search authorities at the OPAC, we're able to search in the
staff interface.

Searching authorities without fill in any term, it works... when you search any
term, any authority it always give you 'No results found'

At koha-plack.log you can find:

Use of uninitialized value $excluding[0] in concatenation (.) or string at
/usr/share/koha/opac/cgi-bin/opac/opac-authorities-home.pl line 81.
oAuth error: Unsupported Use attribute (114) all Bib-1
Use of uninitialized value $excluding[0] in concatenation (.) or string at
/usr/share/koha/opac/cgi-bin/opac/opac-authorities-home.pl line 81.

BaseURL is already configured

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22033] related_resultset is a hole in the Koha::Object logic

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22033

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22033] related_resultset is a hole in the Koha::Object logic

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22033

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22033] related_resultset is a hole in the Koha::Object logic

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22033

Martin Renvoize  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off
 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

--- Comment #4 from Martin Renvoize  ---
Trivial patch, going straight for PQA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22033] related_resultset is a hole in the Koha::Object logic

2018-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22033

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #83432|0   |1
is obsolete||

--- Comment #3 from Martin Renvoize  ---
Created attachment 83441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83441=edit
Bug 22033: Remove related_resultset from the list of available methods

It is not covered by tests.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/