[Koha-bugs] [Bug 15174] Allow borrowers to be members of additional categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15174 cfhong2...@gmail.com changed: What|Removed |Added CC||cfhong2...@gmail.com --- Comment #9 from cfhong2...@gmail.com --- Hi, Can this patch be applied to Koha 18.05? If so, how do I apply this patch? Thanks, Chee -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13654] Cannot place a hold for biblio with too many items to display unless viewing them all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 Charles Farmer changed: What|Removed |Added CC||charles.far...@inlibro.com --- Comment #11 from Charles Farmer --- In the case where neither CountItemsIssued nor $biblio->has_items_waiting_or_intransit return 1, pushing AllowOnShelfHolds => 1 to the template doesn't seem enough, since the ReservableItems variable wouldn't have been initialized in opac-details.pl. On my end, at least, this means that I'm still not able to see the 'Place hold' button after applying the patch. I would suggest either also sending ReservableItems to the template, or simply setting $allow_onshelf_holds = 1. Still a bit too early to put this as Failed QA, as I'm not a QA person myself, but the patch doesn't feel quite right. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21850] Remove search request from page title of OPAC result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 mikael Olangcay Brisebois changed: What|Removed |Added Attachment #83650|0 |1 is obsolete|| --- Comment #5 from mikael Olangcay Brisebois --- Created attachment 83673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83673=edit Bug 21850: Remove search request from page title of OPAC result list This patch modifies the OPAC search results template so that advanced search terms are not shown in the page title and breadcrumbs. This removes potentially confusing computer-oriented code from the public view. For simple searches the search term is displayed, using the same logic that determines whether the search bar should be populated with the last search term. To test: - Apply the patch - Peform a simple keyword search in the OPAC - On the results page the title and breadcrumbs should show 'Results of search for [your keyword] - Perform an advanced search with multiple parameters - The page title and breadrumbs should show only 'Search results' - The breadcrumbs should also show a link back to Advanced search using the returntosearch parameter Signed-off-by: Maryse Simard Signed-off-by: mikael -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Pierre-Marc Thibault changed: What|Removed |Added Attachment #83667|0 |1 is obsolete|| Attachment #83667|1 |0 is patch|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Maryse Simard changed: What|Removed |Added Attachment #83402|0 |1 is obsolete|| --- Comment #18 from Maryse Simard --- Created attachment 83672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83672=edit Bug 2: Use Modern::Perl in installer scripts To test: Check that we are using Modern::Perl when strict *and* warnings were used before, and commented lines and FIXMEs have been removed from the rest, out of files listed below. data/mysql/backfill_statistics.pl data/mysql/labels_upgrade.pl data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl data/mysql/updatedatabase.pl externalmodules.pl html-template-to-template-toolkit.pl install.pl Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #26 from Pierre-Marc Thibault --- Your test plan works and it doesn't seem there's a problem with the extended steps either. Sorry, for the mistakes I made while editing the page, I will try to be more focus next time. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #25 from Pierre-Marc Thibault --- (In reply to Pierre-Marc Thibault from comment #22) > Created attachment 83669 [details] [review] > Bug 10676: Add unit tests - GetItemsInfo > > To test: > prove t/db_dependent/Items.t > > Signed-off-by: Pierre-Marc Thibault > > https://bugs.koha-community.org/show_bug.cgi?id=22053 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault changed: What|Removed |Added Attachment #83668|0 |1 is obsolete|| --- Comment #23 from Pierre-Marc Thibault --- Created attachment 83670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83670=edit Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted The numerical restricted value was overwritten in GetItemsInfo with the description. So OpacHiddenItems would only work for restricted using the description, not the numerical value of the authorised value like for other similar status fields. This changes GetItemsInfo to use a separate variable for the description, as it's already done for notforloan and changes the template files where the variable is used accordingly. To test - Before applying patch - Configure OpacHiddenItems with: restricted: [1] - Find a record with more than one item and mark one of the items as "Restricted Access" (assume standard sample data - check authorised value if status doesn't exist) - Verify the item is still shown in OPAC. - Apply patch - Verify that the item is now hidden - Verify that the status still displays nicely in the staff detail page - Delete OpacHiddenItems - Verify that the status is showing nicely in the OPAC detail page Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault changed: What|Removed |Added Attachment #83669|0 |1 is obsolete|| --- Comment #24 from Pierre-Marc Thibault --- Created attachment 83671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83671=edit Bug 10676: Add unit tests - GetItemsInfo To test: prove t/db_dependent/Items.t Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14393] Add collection code filter to inventory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 Charles Farmer changed: What|Removed |Added CC||charles.far...@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #21 from Charles Farmer --- Merging seems to fail because of HTML filters and whatnot, pretty expected from a 2015 patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault changed: What|Removed |Added Attachment #83631|0 |1 is obsolete|| --- Comment #22 from Pierre-Marc Thibault --- Created attachment 83669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83669=edit Bug 10676: Add unit tests - GetItemsInfo To test: prove t/db_dependent/Items.t Signed-off-by: Pierre-Marc Thibault https://bugs.koha-community.org/show_bug.cgi?id=22053 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault changed: What|Removed |Added Attachment #83630|0 |1 is obsolete|| --- Comment #21 from Pierre-Marc Thibault --- Created attachment 83668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83668=edit Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted The numerical restricted value was overwritten in GetItemsInfo with the description. So OpacHiddenItems would only work for restricted using the description, not the numerical value of the authorised value like for other similar status fields. This changes GetItemsInfo to use a separate variable for the description, as it's already done for notforloan and changes the template files where the variable is used accordingly. To test - Before applying patch - Configure OpacHiddenItems with: restricted: [1] - Find a record with more than one item and mark one of the items as "Restricted Access" (assume standard sample data - check authorised value if status doesn't exist) - Verify the item is still shown in OPAC. - Apply patch - Verify that the item is now hidden - Verify that the status still displays nicely in the staff detail page - Delete OpacHiddenItems - Verify that the status is showing nicely in the OPAC detail page Signed-off-by: Pierre-Marc Thibault https://bugs.koha-community.org/show_bug.cgi?id=22053 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #9 from Pierre-Marc Thibault --- Created attachment 83666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83666=edit Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted The numerical restricted value was overwritten in GetItemsInfo with the description. So OpacHiddenItems would only work for restricted using the description, not the numerical value of the authorised value like for other similar status fields. This changes GetItemsInfo to use a separate variable for the description, as it's already done for notforloan and changes the template files where the variable is used accordingly. To test - Before applying patch - Configure OpacHiddenItems with: restricted: [1] - Find a record with more than one item and mark one of the items as "Restricted Access" (assume standard sample data - check authorised value if status doesn't exist) - Verify the item is still shown in OPAC. - Apply patch - Verify that the item is now hidden - Verify that the status still displays nicely in the staff detail page - Delete OpacHiddenItems - Verify that the status is showing nicely in the OPAC detail page Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22053] Ability to disable some plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 --- Comment #10 from Pierre-Marc Thibault --- Created attachment 83667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83667=edit Bug 10676: Add unit tests - GetItemsInfo To test: prove t/db_dependent/Items.t Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21929] Typo in orderreceive.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21929 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #11 from Lucas Gass --- backported to 18.05 for 18.05.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Katrin Fischer changed: What|Removed |Added Summary|OpacHiddenItems not working |OpacHiddenItems not working |for restricted |for restricted on OPAC ||detail --- Comment #20 from Katrin Fischer --- If I understood correctly, you can still sign off. This deals with the case, that not all items on a record are hidden and the OPAC detail pages. You could extend the test plan a bit: - Verify that if the restricted item is the only item, the record cannot be found in the OPAC - Verfy you can't access the record directly by URL - Verify the item information in the results is correct >From what Joy said those already work, but should not be broken by the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #19 from Pierre-Marc Thibault --- I didn't complete the test since there is a current conversation involving Joy which let me think there is a problem that is not in the test plan and that would make my sign off meaningless. I am wrong? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18355] Permanent location should show with cart location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 José-Mario Monteiro-Santos changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18355] Permanent location should show with cart location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 José-Mario Monteiro-Santos changed: What|Removed |Added Attachment #80153|0 |1 is obsolete|| --- Comment #41 from José-Mario Monteiro-Santos --- Created attachment 83665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83665=edit Bug 18355: Update opac-detail.pl/tt to show both Adding dependancy of bug 21503 for templates to fully fail correctly. To Test this patch: 1) Apply patch / restart_all 2) Check out an item. 3) Check item in with ReturnToShelvingCart set to Move. 4) View the item in opac-detail.pl and see the permanent location, and the cart location in parentesis. 5) Try removing opac description from the cart and item sleving location. Refresh opac-detail.pl. Should default to regular description. (If not, may need patch 21503 to test.) 6) To test for code replacement if regular and opac description are missing, you WILL need patch 21503. Signed-off-by: Jose-Mario -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #18 from Katrin Fischer --- Hi Joy, thx for checking again! I'd need to investigate a bit more, but it's possible the code for hiding the record is using a slightly different logic. Koha is always fun ;) Pierre, is it working ok now for you? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Maryse Simard changed: What|Removed |Added Attachment #83438|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 83664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83664=edit Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron entry page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813 Pierre-Marc Thibault changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21813] In-page JavaScript causes error on patron entry page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813 Pierre-Marc Thibault changed: What|Removed |Added Attachment #83632|0 |1 is obsolete|| --- Comment #6 from Pierre-Marc Thibault --- Created attachment 83663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83663=edit Bug 21813: In-page JavaScript causes error on patron entry page This patch removes a block of JavaScript from memberentrygen.tt which was being included in the page before jQuery is loaded. This causes a JavaScript error. To test, apply the patch, regenerate CSS, and clear your browser cache if necessary. - In Administration -> Patron categories, confirm that you have two patron categories with different default messaging preferences defined. - Go to Patrons -> New patron - Create a new patron using one of the categories with messaging preferences. - Confirm that when you switch the category selection to the other patron category, the patron messaging preference checkboxes are changed to the default for that category. - A "Loading" indicator should appear above the checkboxes to show that an operation is in process. It should disappear when new default prefs are loaded. - Manually change one or more patron messaging preference checkboxes. - Switch the patron category again and confirm that you are prompted to confirm resetting the preferences to the default for that category. - Perform the same set of tests when editing a patron. - Defaults should not be loaded during the edit process. - Confirm that there are no other JavaScript errors in the console. - Test again with EnhancedMessagingPreferences disabled. Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #17 from Pierre-Marc Thibault --- (In reply to Katrin Fischer from comment #14) > (In reply to Pierre-Marc Thibault from comment #11) > > All seems allright, except the last step where the item doesn't show up when > > OpacHiddenItems is empty in OPAC. Can you please verify if it's the same for > > you? > > Yes it did work - when the pref is empty and read correctly, there is no > more reason to hide it for Koha. > > Can you please check that the item didn't fit another criteria for being > hidden? > Is your system preference OpacHiddenItems really empty? > Is your system set up with memcached and Plack? Sorry, it was likely a mistake on the refresh of the content. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #16 from Joy Nelson --- Testing with Nick shows that this is dependent on the number of items. My test were for a bib with 1 item and that item was restricted. It does hide the title from the OPAC because the one item is 'hidden'. However when another item is added, the hidden item does not appear in search results (as available), but does appear in the detail page when the title is clicked on. (In reply to Joy Nelson from comment #15) > My framework is the Default framework. 952$5 is tied to RESTRICTED > authorized value list. The RESTRICTED auth value list has code of 1 and > description of "Restricted Access". > > OpacHiddenItems contains (with a blank line at end) > itype: [GAMES,EBOOK] > ccode: [REFERENCE,MUSIC] > location: [HOMESCHOOL,PARENTING] > restricted: [1] > > My item was none of the values listed below and appeared in OPAC searches. > When i edit the item to RESTRICTED (items.restricted=1), it dissappears from > searches. Although number of bibs still show the count of 5, where search > results only show 4. > > (In reply to Katrin Fischer from comment #13) > > Hi Joy, is it possible you used a framework that was not linked to the > > authorised value correctly? Looking at the code it can't work with the > > number, unless the number is in the description or the authorised value > > description cannot be found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip bad borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052 Charles Farmer changed: What|Removed |Added CC||charles.far...@inlibro.com Status|Needs Signoff |Signed Off --- Comment #6 from Charles Farmer --- Followed test plan, got the "DBD::mysql::st execute failed: Cannot delete or update a parent row..." has expected. Patch did what it advertised: self-reg'd borrower couldn't be deleted unless it had no checked out items, no fines, and all this without crashing the cron in the mean time. Signed off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #15 from Joy Nelson --- My framework is the Default framework. 952$5 is tied to RESTRICTED authorized value list. The RESTRICTED auth value list has code of 1 and description of "Restricted Access". OpacHiddenItems contains (with a blank line at end) itype: [GAMES,EBOOK] ccode: [REFERENCE,MUSIC] location: [HOMESCHOOL,PARENTING] restricted: [1] My item was none of the values listed below and appeared in OPAC searches. When i edit the item to RESTRICTED (items.restricted=1), it dissappears from searches. Although number of bibs still show the count of 5, where search results only show 4. (In reply to Katrin Fischer from comment #13) > Hi Joy, is it possible you used a framework that was not linked to the > authorised value correctly? Looking at the code it can't work with the > number, unless the number is in the description or the authorised value > description cannot be found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip bad borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052 Charles Farmer changed: What|Removed |Added Attachment #83546|0 |1 is obsolete|| --- Comment #5 from Charles Farmer --- Created attachment 83662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83662=edit Bug 22052: Refactor DeleteExpiredOpacReigstrations This patch changes the sub to use Koha::Objects and updates the tests. Previously the sub would die on borrowers with checkouts and would delete borrowers if they had fines To test: 1 - prove -v t/db_dependent/ 2 - Set your selfreg preferences: PatronSelfRegistration: Allow PatronSelfRegistrationDefaultCategory: SELFREG (or of your choice) PatronSelfRegistrationExpireTemporaryAccountsDelay: 30 3 - Register a patron into SELFREG or how you set above 4 - Set their date enrolled to two months ago 5 - Checkout an item to the patron 6 - Issue a fine to that patron 7 - perl misc/cronjobs/cleanup_database.pl --del-exp-selfreg -v 8 - The job should die with an error 9 - Check in the item 10 - run the corn again - patron is deleted, oops 11 - Apply patch 12 - Create another patron in the same way 13 - Checkout and fine the patron 14 - run the cron 15 - they are not deleted, and no error 16 - checkin the item 17 - run the cron 18 - they are not deleted and no error 19 - clear the fine 20 - run the cron 21 - patron is deleted, huzzah Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip bad borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052 Charles Farmer changed: What|Removed |Added Attachment #83660|0 |1 is obsolete|| --- Comment #4 from Charles Farmer --- Created attachment 83661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83661=edit Bug 22052: Unit tests Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22052] DeleteExpiredOpacRegistrations should skip bad borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22052 Charles Farmer changed: What|Removed |Added Attachment #83545|0 |1 is obsolete|| --- Comment #3 from Charles Farmer --- Created attachment 83660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83660=edit Bug 22052: Unit tests Signed-off-by: Charles Farmer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #14 from Katrin Fischer --- (In reply to Pierre-Marc Thibault from comment #11) > All seems allright, except the last step where the item doesn't show up when > OpacHiddenItems is empty in OPAC. Can you please verify if it's the same for > you? Yes it did work - when the pref is empty and read correctly, there is no more reason to hide it for Koha. Can you please check that the item didn't fit another criteria for being hidden? Is your system preference OpacHiddenItems really empty? Is your system set up with memcached and Plack? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #13 from Katrin Fischer --- Hi Joy, is it possible you used a framework that was not linked to the authorised value correctly? Looking at the code it can't work with the number, unless the number is in the description or the authorised value description cannot be found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #12 from Joy Nelson --- My testing of the original issue (on 18.06) could not replicate it. I was using the code for the Restricted value, not the description. The items were hidden on the opac when Restricted: [1] was in the opachiddenitems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||pierre-marc.thibault@inlibr ||o.com --- Comment #11 from Pierre-Marc Thibault --- All seems allright, except the last step where the item doesn't show up when OpacHiddenItems is empty in OPAC. Can you please verify if it's the same for you? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Charles Farmer changed: What|Removed |Added Attachment #83623|0 |1 is obsolete|| --- Comment #8 from Charles Farmer --- Created attachment 83658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83658=edit Bug 22051: Unit tests Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Charles Farmer changed: What|Removed |Added Attachment #83624|0 |1 is obsolete|| --- Comment #9 from Charles Farmer --- Created attachment 83659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83659=edit Bug 22051: Make Koha::Object->store translate incorrect value exceptions This patch adds a new condition to Koha::Object->store so it catches incorrect value-related DBIC exceptions. This DBIC exceptions get now translated into Koha::Exceptions::Object::BadValue exceptions with relevant parameters passed. To test: - Apply the exception and unit tests patches - Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Tests fail because this exception handling code is not implemented - Apply this patch - Run: k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22051] Make Koha::Object->store translate 'Incorrect value' exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22051 Charles Farmer changed: What|Removed |Added Attachment #83622|0 |1 is obsolete|| --- Comment #7 from Charles Farmer --- Created attachment 83657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83657=edit Bug 22051: Add Koha::Exceptions::Object::WrongValue This patch adds a new exception to be thrown in Koha::Object->store when a DBIC exception is thrown regarding bad data format. To test: - Apply this patch - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Charles Farmer changed: What|Removed |Added Attachment #83625|0 |1 is obsolete|| --- Comment #9 from Charles Farmer --- Created attachment 83654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83654=edit Bug 22049: Make MarkIssueReturned rely on returndate only This patch changes the params accepted by C4::Circulation::MarkIssueReturned by removing the $dropbox_branch param. This passed branchcode was only used to initialize the Koha::Calendar object, but the date arithmetic has already taken place in a couple places before we reach this point. This logic needs to be simplified (bug 14591), and this is the starting point. To test: - Apply this patch - Run: $ git grep MarkIssueReturned => SUCCESS: Check all the uses of the function either originally passed undef, or now pass the same date that would've been calculated anyway, in the returndate param. - Run: $ kshell k$ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Charles Farmer changed: What|Removed |Added Attachment #83627|0 |1 is obsolete|| --- Comment #11 from Charles Farmer --- Created attachment 83656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83656=edit Bug 22049: (follow-up) Remove leftover variable The $circControlBranch variable was originally set to be used to pick the right dropbox branch. It was only used in MarkIssueReturned, to get the right Koha::Calendar object. As this responsability was moved top to the AddReturn caller, and the fact that _GetCircControlBranch is actually used for fines rules, there's no use for it in this context. And it was left on the previous patch as a mistake. To test: - Make sure the variable is not actually used: $ git grep '$circControlBranch' => SUCCESS: removed variable is not actually used. - Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22049] MarkIssueReturned should rely on returndate only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 Charles Farmer changed: What|Removed |Added Attachment #83626|0 |1 is obsolete|| --- Comment #10 from Charles Farmer --- Created attachment 83655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83655=edit Bug 22049: Add tests The current tests only check some failure use cases. This patch makes it cover more use cases To test: - Apply this patchset - Run: $ kshell k$ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests pass! Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16457] Remove the use of "onclick" from the patron entry form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16457 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15912] Correct JSHint errors in datatables.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15912 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11894] Funds toolbar menu items greyed out without explanation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11894 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22067] Koha::Patron->can_see_patron_infos should return if no patron is passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22067 Maryse Simard changed: What|Removed |Added Attachment #83629|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 83653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83653=edit Bug 22067: Return if no patron passed to can_see_patron_infos To test: 1 - Find an adult patron 2 - Add a child to their account 3 - Delete the parent from the db 4 - Attempt to edit the child record 5 - Apply patch 6 - Repeat 7 - Note you can edit the child account 8 - Note guarantor id is not a link Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22067] Koha::Patron->can_see_patron_infos should return if no patron is passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22067 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21967] Switch two-column templates to Bootstrap grid: Patrons part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21967 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 21965 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21965] Switch two-column templates to Bootstrap grid: Patrons part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21965 --- Comment #4 from Owen Leonard --- *** Bug 21967 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Bug 20654 depends on bug 21967, which changed state. Bug 21967 Summary: Switch two-column templates to Bootstrap grid: Patrons part 4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21967 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22071] Make authenticate_api_request stash koha.user in OAuth use case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071 Charles Farmer changed: What|Removed |Added Attachment #83642|0 |1 is obsolete|| --- Comment #7 from Charles Farmer --- Created attachment 83652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83652=edit Bug 22071: Make authenticate_api_request stash koha.user in OAuth use case This patch makes the OAuth code stash the requestion Koha::Patron. To test: - Apply the tests patch: - Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => FAIL: Tests fail :-( - Apply this patch - Run: k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => SUCCESS: Tests pass :-D - Sign off =D Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22071] Make authenticate_api_request stash koha.user in OAuth use case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071 Charles Farmer changed: What|Removed |Added Attachment #83641|0 |1 is obsolete|| --- Comment #6 from Charles Farmer --- Created attachment 83651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83651=edit Bug 22071: Regression tests The authenticate_api_request() behaviour needs more tests. This patch adds tests for the stashed Koha::Patron object. It highlights the bug in the OAuth authentication case. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => FAIL: Tests fail in the OAuth case, pass in the cookie-based auth case. Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22071] Make authenticate_api_request stash koha.user in OAuth use case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||charles.far...@inlibro.com --- Comment #5 from Charles Farmer --- I was able to get the same behavior as described in the test plan: "not ok 1 - token-based tests" but "ok 2 - cookie-based tests" The following patch made all tests successful. Had to download Net::OAuth2::AuthorizationServer and activate the syspref RESTOAuth2ClientCredentials, if anybody needs additional instructions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21850] Remove search request from page title of OPAC result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21850] Remove search request from page title of OPAC result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Maryse Simard changed: What|Removed |Added Attachment #83640|0 |1 is obsolete|| --- Comment #4 from Maryse Simard --- Created attachment 83650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83650=edit Bug 21850: Remove search request from page title of OPAC result list This patch modifies the OPAC search results template so that advanced search terms are not shown in the page title and breadcrumbs. This removes potentially confusing computer-oriented code from the public view. For simple searches the search term is displayed, using the same logic that determines whether the search bar should be populated with the last search term. To test: - Apply the patch - Peform a simple keyword search in the OPAC - On the results page the title and breadcrumbs should show 'Results of search for [your keyword] - Perform an advanced search with multiple parameters - The page title and breadrumbs should show only 'Search results' - The breadcrumbs should also show a link back to Advanced search using the returntosearch parameter Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #49 from Nick Clemens --- (In reply to Katrin Fischer from comment #42) > Just a thought: would it be hard to use itemcallnumber if cn_sort is > empty/not set? That might give some flexibility. We could, but I am afraid ti wouldn't help since the range passed into the template is transformed using the classification rules - so an untransformed callnumebr would likely remain outside the range > It might be nice to add a script to help people populating this field if it > was somehow missed during migration or set to a wrong value, but that is out > of scope here for sure! Thank you, file a bug and we can look at a future time :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #46 from Nick Clemens --- Created attachment 83647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83647=edit Bug 19915: Only show class sources in use Signed-off-by: Marcel de Rooy https://bugs.koha-community.org/show_bug.cgi?id=19905 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #44 from Nick Clemens --- Created attachment 83645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83645=edit Bug 19915: (QA follow-up) Tidy up GetItemsForInventory.t Standard edits like modules, schema, Koha objects instead of DBIC. Removing unneeded autoflush. Moving initial test to a first subtest. No need to clear issues if you clear items. Adding a FIXME for OldWay; would be nice to remove that code.. Signed-off-by: Marcel de Rooy https://bugs.koha-community.org/show_bug.cgi?id=19905 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #45 from Nick Clemens --- Created attachment 83646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83646=edit Bug 19915: Use cn_sort values for getting inventory items To test: 1 - Catalog an item under LCC with callnumber GT95 2 - cn_sort should calculate as GT0095 3 - Go to inventory tool 4 - Enter a range that should have your item e.g LC GT90 to GT100 5 - Item is not returned 6 - Apply patch 7 - Item should be returned 8 - Verify things otherwise work as expected Signed-off-by: Anne-Claire Bernaudin Signed-off-by: Marcel de Rooy https://bugs.koha-community.org/show_bug.cgi?id=19905 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #48 from Nick Clemens --- Created attachment 83649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83649=edit Bug 19915: (follow-up) Fix test count from rebase https://bugs.koha-community.org/show_bug.cgi?id=19905 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #47 from Nick Clemens --- Created attachment 83648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83648=edit Bug 19915: Don't delete in tests https://bugs.koha-community.org/show_bug.cgi?id=19905 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Nick Clemens changed: What|Removed |Added Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Nick Clemens changed: What|Removed |Added Attachment #81816|0 |1 is obsolete|| Attachment #81817|0 |1 is obsolete|| Attachment #81818|0 |1 is obsolete|| Attachment #81819|0 |1 is obsolete|| Attachment #81820|0 |1 is obsolete|| Attachment #81821|0 |1 is obsolete|| --- Comment #43 from Nick Clemens --- Created attachment 83644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83644=edit Bug 19915: Add unit test to GetItemsForInventory.t prove -v t/db_dependent/Items/GetItemsForInventory.t Signed-off-by: Anne-Claire Bernaudin Signed-off-by: Marcel de Rooy Moved the betwen typo edit back here. https://bugs.koha-community.org/show_bug.cgi?id=19905 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Nick Clemens changed: What|Removed |Added Assignee|n...@bywatersolutions.com |oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 --- Comment #11 from Nick Clemens --- I updated the patches to respect AllowItemsOnHoldCheckout and updated the pref description. This patch only affects sites using the holds queue and will only affect items that have been currently selected to be pulled for a hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Nick Clemens changed: What|Removed |Added Attachment #58549|0 |1 is obsolete|| --- Comment #10 from Nick Clemens --- Created attachment 83643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83643=edit Bug 15505 - Mark Hold Items 'On hold' instead of 'Available' This patch adds a 'pending hold' column to C4::Items:GetItemsInfo to allow for displaying status of an item when it has been selected for a hold by the holdsqueue and AllowItemsOnHoldCheckout is set to 'Don't allow' To test: 00 - Set AllowItemsOnHoldCheckout to 'Allow' 01 - Place a hold on an item 02 - Build the holdsqueue (kohadevbox example below) sudo koha-shell kohadev perl misc/cronjobs/holds/build_holds_queue.pl 03 - Search for the item on the OPAC 04 - Note item shows as 'Available' in results and details 05 - Toggle AllowItemsOnHOldCheckout to 'Don't allow' 06 - Repeat search, note there is no change 06 - Apply Patch 07 - Search for the item on the OPAC 08 - Note that item now shows as 'Pending hold' 09 - Toggle AllowItemsOnHoldCheckout to Allow 10 - Note item shows as available 11 - prove -v t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Nick Clemens changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15806] Remove obsolete vendor prefixes from staff client CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15806 Owen Leonard changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #1 from Owen Leonard --- Fixed by Bug 19474 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17119] Shouldn't have to scroll to see submit button in Z39.50 authority search popup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17119 Owen Leonard changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #1 from Owen Leonard --- This was fixed by Bug 19946 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15051] 245 Marc Field Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051 --- Comment #7 from Owen Leonard --- Is this bug still valid? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22071] Make authenticate_api_request stash koha.user in OAuth use case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83639|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 83642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83642=edit Bug 22071: Make authenticate_api_request stash koha.user in OAuth use case This patch makes the OAuth code stash the requestion Koha::Patron. To test: - Apply the tests patch: - Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => FAIL: Tests fail :-( - Apply this patch - Run: k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => SUCCESS: Tests pass :-D - Sign off =D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22071] Make authenticate_api_request stash koha.user in OAuth use case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83638|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 83641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83641=edit Bug 22071: Regression tests The authenticate_api_request() behaviour needs more tests. This patch adds tests for the stashed Koha::Patron object. It highlights the bug in the OAuth authentication case. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => FAIL: Tests fail in the OAuth case, pass in the cookie-based auth case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21850] Remove search request from page title of OPAC result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 --- Comment #3 from Owen Leonard --- Created attachment 83640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83640=edit Bug 21850: Remove search request from page title of OPAC result list This patch modifies the OPAC search results template so that advanced search terms are not shown in the page title and breadcrumbs. This removes potentially confusing computer-oriented code from the public view. For simple searches the search term is displayed, using the same logic that determines whether the search bar should be populated with the last search term. To test: - Apply the patch - Peform a simple keyword search in the OPAC - On the results page the title and breadcrumbs should show 'Results of search for [your keyword] - Perform an advanced search with multiple parameters - The page title and breadrumbs should show only 'Search results' - The breadcrumbs should also show a link back to Advanced search using the returntosearch parameter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21850] Remove search request from page title of OPAC result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22071] Make authenticate_api_request stash koha.user in OAuth use case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21850] Remove search request from page title of OPAC result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22071] Make authenticate_api_request stash koha.user in OAuth use case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22071] Make authenticate_api_request stash koha.user in OAuth use case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 83639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83639=edit Bug 22071: Make authenticate_api_request stash koha.user in OAuth use case This patch makes the OAuth code stash the requestion Koha::Patron. To test: - Apply the tests patch: - Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => FAIL: Tests fail :-( - Apply this patch - Run: k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => SUCCESS: Tests pass :-D - Sign off =D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22071] Make authenticate_api_request stash koha.user in OAuth use case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071 Tomás Cohen Arazi changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22071] Make authenticate_api_request stash koha.user in OAuth use case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 83638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83638=edit Bug 22071: Regression tests The authenticate_api_request() behaviour needs more tests. This patch adds tests for the stashed Koha::Patron object. It highlights the bug in the OAuth authentication case. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => FAIL: Tests fail in the OAuth case, pass in the cookie-based auth case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Alex Arnaud changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 --- Comment #9 from Alex Arnaud --- Created attachment 83637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83637=edit Bug 21738: make call of CanBookBeReserved more safe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21198] authenticate_api_request should stash the reason access is granted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21198 Tomás Cohen Arazi changed: What|Removed |Added Depends on||22071 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071 [Bug 22071] Make authenticate_api_request stash koha.user in OAuth use case -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22071] Make authenticate_api_request stash koha.user in OAuth use case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21198 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21198 [Bug 21198] authenticate_api_request should stash the reason access is granted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22071] New: Make authenticate_api_request stash koha.user in OAuth use case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22071 Bug ID: 22071 Summary: Make authenticate_api_request stash koha.user in OAuth use case Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: REST api Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com Target Milestone: --- The patron that made the request is not being stashed in OAuth authentication. Regression tests and fixes to be submitted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 --- Comment #10 from Owen Leonard --- (In reply to Aleisha Amohia from comment #9) > Wasn't able to complete the Search. After clicking Search, this error shows: > > Template process failed: undef error - WHILE loop terminated (> 1000 > iterations) > at /home/vagrant/kohaclone/C4/Templates.pm line 122 I'm obsoleting that comment because it's really long and I think the above snippet is what's really relevant: My changed template tries to use a WHILE loop with result pages and there is a hard limit of 1000 for that kind of loop. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #39 from Maryse Simard --- Created attachment 83636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83636=edit Bug 18421: (follow-up) Center image in results table Adds the "thumbnail" class to the image to have it centered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard changed: What|Removed |Added Attachment #80139|0 |1 is obsolete|| --- Comment #38 from Maryse Simard --- Created attachment 83635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83635=edit Bug 18421: (follow-up) Adding missing filters This patch adds template filters as prompted by the QA tool. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard changed: What|Removed |Added Attachment #80138|0 |1 is obsolete|| --- Comment #37 from Maryse Simard --- Created attachment 83634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83634=edit Bug 18421: (follow-up) QA fixes Use the community's terminology, change coce.js's path, update
[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard changed: What|Removed |Added Attachment #80137|0 |1 is obsolete|| --- Comment #36 from Maryse Simard --- Created attachment 83633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83633=edit Bug 18421: Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22070] New: OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Bug ID: 22070 Summary: OpacBrowseResults has broken link back to search results Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Under certain conditions the OPACBrowseResults (navigation between results in OPAC) feature will have a broken link "back to results". To test: - Search for a term with diacritics. You can cheat a little here and search for something like "bööks" with the sample data. (ö will also find o). It's important that it's at least to result pages. - Go to the last result of the first result page - Verify the URL "back to results" works and diacritic shows up nicely - Go to the last result of the first page again - Navigate "Next >>" - Check "Back to results" again - Verify the link is broken and the diacritics are mangled Link looks something like this: http://localhost:8080/cgi-bin/koha/opac-search.pl?offset=20=b%C3%83%C2%83%C3%82%C2%B6%C3%83%C2%83%C3%82%C2%B6ks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22065] Can't receive isses when there is no serial with status 1 (expected)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22065 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Katrin Fischer --- It works nicely on master: If there is no expected issue you are forwarded to the serial collection page where you can generate the next issue or change status of one of the older issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21460] Filtering ILL requests on borrowernumber does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460 --- Comment #20 from Andrew Isherwood --- Thanks for taking the time to post that patch Jonathan, it makes for an interesting experiment! I'll create a patch that will iterate the and escape the prefilters in the .pl then constructs the string in the template. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #10 from Katrin Fischer --- Created attachment 83631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83631=edit Bug 10676: Add unit tests - GetItemsInfo To test: prove t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #9 from Katrin Fischer --- Created attachment 83630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83630=edit Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted The numerical restricted value was overwritten in GetItemsInfo with the description. So OpacHiddenItems would only work for restricted using the description, not the numerical value of the authorised value like for other similar status fields. This changes GetItemsInfo to use a separate variable for the description, as it's already done for notforloan and changes the template files where the variable is used accordingly. To test - Before applying patch - Configure OpacHiddenItems with: restricted: [1] - Find a record with more than one item and mark one of the items as "Restricted Access" (assume standard sample data - check authorised value if status doesn't exist) - Verify the item is still shown in OPAC. - Apply patch - Verify that the item is now hidden - Verify that the status still displays nicely in the staff detail page - Delete OpacHiddenItems - Verify that the status is showing nicely in the OPAC detail page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676
--- Comment #8 from Katrin Fischer ---
After some debugging I think I have found the reason. It won't work with the
numeric value of the authorised value used, it needs the description:
restricted: ['Restricted Access']
For other values like Damaged it will works with numerics.
The reason is some code in GetItemsInfo:
# get notforloan complete status if applicable
$descriptions =
Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode =>
$data->{frameworkcode}, kohafield => 'items.notforloan', authorised_value =>
$data->{itemnotforloan} });
$data->{notforloanvalue} = $descriptions->{lib} // '';
$data->{notforloanvalueopac} = $descriptions->{opac_description} // '';
# get restricted status and description if applicable
$descriptions =
Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode =>
$data->{frameworkcode}, kohafield => 'items.restricted', authorised_value =>
$data->{restricted} });
$data->{restricted} = $descriptions->{lib} // '';
$data->{restrictedopac} = $descriptions->{opac_description} // '';
While it uses a new variable "*value*" for notforloan, it overwrites the
restricted numerical value with the description.
I think the clean solution is to change it so that OpacHiddenItems works like
for the other item fields with authorised values, using the codes.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Katrin Fischer changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #7 from Katrin Fischer --- Hi Joy, I tested again today on master - it still doesn't work for me. Here is what I did: OpacHiddenItems: restricted: [1] Changed 1 item out of 4 to be restricted. Opac now shows it as: Available (Restricted Access) Not hidden... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
