[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Katrin Fischer changed: What|Removed |Added QA Contact||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #25 from Katrin Fischer --- Hi Joy, sorry, I missed getting back to this :( (In reply to Joy Nelson from comment #24) > Katrin, > Currently this analytic feature only works where the leader7=s. I'd like to > propose the following changes to this feature to allow it be used by your > library and others in a more standard method. > > 1. Allow the link to appear when leader7 =s or leader7=m. Both monographs > and serial records can have component parts and as such have children that > should be displayed by this feature. The Show analytics link is searching > for bib-level:a (Monographic component part) and bib-level:b (Serial > component part). Yes, that makes sense. Actually we have that link in some custom XSLT, but use a different class to allow changing visibility independently for m and s. > > 2. Add a search function to this display page that checks the index > (Host-item) to see if any children are present. If so, then display the > "Show Analytics Link". This search would search for control number or title > depending on the value of usecontrolnumber sys pref. I would be totally ok with that. I just never figured out how to do this myself. Some help here would be great. I am not sure Host-item will work as an index or if a new index for $w in 773 would be needed for the controlnumber part. > 3. Add a syspref for this method of analytic cataloging, much like we have > for Easy Analytics and 'use control number'. Allow libraries the ability to > turn off the analytic cataloging if they don't use it. Call it > "ShowLinktoChildfromParent"? I am not sure about adding more and more prefs when CSS would work, but if we add the function in 2) it makes sense to have a real switch to avoid unnecessary processing. I had some hope that [Bug 11175] Show the parent record's component parts in the detailed views would help resolve the issues or replace the current way, but it hasn't worked out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Martin Renvoize changed: What|Removed |Added QA Contact|martin.renvoize@ptfs-europe |testo...@bugs.koha-communit |.com|y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #4 from David Cook --- (In reply to Jonathan Druart from comment #1) > Discussions: > > 2. Even if we do not go for RabbitMQ I think we could start moving the code > from pl to Koha::BackgroundJob::*pm > It will be "easy" (nothing is easy, right?) to replace it with something > else. I totally agree; it would nice to be as message queue implementation agnostic as possible. > Going further: > 1. Implement Koha::BackgroundJob for the different background jobs > 2. Provide a koha-worker script to consume to jobs > 3. Rewrite the task scheduler with Koha::BackgroundJob (1993) It's been a couple years since I looked at RabbitMQ. Is there a way to cancel/remove/delete a message once it is enqueued? I think this would be useful for a task scheduler. I built that into the POE-based task scheduler I built for https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662. (Actually, I also built-in the ability for in-progress jobs to be canceled in the event a big batch job was started and a person realized it was a mistake.) > 4. Provide a configuration file to prioritize or postpone jobs (for instance > no batch modification on Wednesday between 9-17) - Or maybe we won't need > that (?) Fridolin mentioned something like this to me when I was talking about https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 with him at Kohacon18 in Portland. He pointed out that for a multi-tenant server you might not want all the different Koha instances on the server to run their background jobs at the same time due to restraints like performance, rate-limiting, connection limits, etc. Off the top of my head, I don't have a solution for this one though, although in the case of https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 I use separate task schedulers for every Koha instance on the server. In this case, we could potentially use 1 RabbitMQ server, and X number of workers... although we'd have to have a way of setting the KOHA_CONF for each task. That might be the best way to handle multi-tenant scenarios. Alternatively, I think we'd need to have unique queues for each Koha instance and workers for those unique queues. Requires a bit of thought in any case. > 5. What would be your needs? > Ideally, it would be nice to replace my home-made task scheduler in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 with this one. I like that mine can add/start/pause/stop/remove tasks, but I haven't seen a mainstream task scheduler that is capable of doing that, so that might be too difficult to do here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- I've taken a brief look at the code and the screenshots and it's looking good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21247] Cannot add more than one emoji across the entire database as a tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21247 Tomás Cohen Arazi changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Tomás Cohen Arazi --- Please QA 21846 and this will be history. *** This bug has been marked as a duplicate of bug 21846 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Tomás Cohen Arazi changed: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #25 from Tomás Cohen Arazi --- *** Bug 21247 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #24 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #23) > (In reply to Tomás Cohen Arazi from comment #19) > > (In reply to Katrin Fischer from comment #15) > > > - But: tags table in the db is empty (should it be?) > > > > The 'tags' table is used by a tool that is not related to the tags feature, > > but the subject cloud for french terms. > > OK > > > > > > - Tag cloud shows 2 tacos instead of one bigger taco > > > > This seems to be a bug in master already, with or without emojis. > > You are right, this is a regression. I am not sure when it was introduced, > but we need to fix it. The font should go bigger with increased use of a tag > to get the normal cloud picture. I know for sure it still works in 17.11 but > could not test further. I filled bug 22420, and Jonathan provided a fix already. > I also had added multiple tags according to Nicks test plan in comment 1. > The taco was extra :) Ok -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #23 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #19) > (In reply to Katrin Fischer from comment #15) > > - But: tags table in the db is empty (should it be?) > > The 'tags' table is used by a tool that is not related to the tags feature, > but the subject cloud for french terms. OK > > > - Tag cloud shows 2 tacos instead of one bigger taco > > This seems to be a bug in master already, with or without emojis. You are right, this is a regression. I am not sure when it was introduced, but we need to fix it. The font should go bigger with increased use of a tag to get the normal cloud picture. I know for sure it still works in 17.11 but could not test further. I also had added multiple tags according to Nicks test plan in comment 1. The taco was extra :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Bob Birchall changed: What|Removed |Added CC||b...@calyx.net.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for overdue notices with a print type specified where a patron has an email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937 --- Comment #4 from Jonathan Druart --- Comment on attachment 83829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83829 Bug 20937: Truncate items for print notices when user has an email Review of attachment 83829: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20937=83829) - ::: misc/cronjobs/overdue_notices.pl @@ +683,4 @@ > # email or sms is requested but not exist, do a > print. > $effective_mtt = 'print'; > } > +my @notice_items = @items; Why a new variable? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21988] Add SMSSendFrom system preference for specifying a source number for SMS messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #10 from Jonathan Druart --- Should not it be in the config (sms_send_config) instead? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #459 from Jonathan Druart --- t/db_dependent/Koha/SharedContent.t:C4::Context->set_userenv(0,0,0, ->set_userenv should no longer be used in tests. See bug 21817. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #29 from Jonathan Druart --- I am getting the following line in the Koha logs on hitting opac-search.pl, I guess it comes from here. File not found : lib/jquery/plugins/jquery.rating.js at /home/vagrant/kohaclone/Koha/Template/Plugin/Asset.pm line 83. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #49 from Jonathan Druart --- Created attachment 85754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85754=edit Bug 22368: Make sure the tests will always pass Who knows! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 --- Comment #25 from Josef Moravec --- Rebased needed because of bug 21206 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 Josef Moravec changed: What|Removed |Added Attachment #85635|0 |1 is obsolete|| --- Comment #22 from Josef Moravec --- Created attachment 85751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85751=edit Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer Test plan: 1) Use log viewer, try different parameters 2) Try screen and file export 3) prove t/db_dependent/Koha/ActionLogs.t Signed-off-by: Andrew Isherwood Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 Josef Moravec changed: What|Removed |Added Attachment #85636|0 |1 is obsolete|| --- Comment #23 from Josef Moravec --- Created attachment 85752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85752=edit Bug 22363: Update Circulation.t to use Koha::ActionLogs instead of GetLogs Test plan: prove t/db_dependent/Circulation.t Signed-off-by: Andrew Isherwood Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 Josef Moravec changed: What|Removed |Added Attachment #85637|0 |1 is obsolete|| --- Comment #24 from Josef Moravec --- Created attachment 85753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85753=edit Bug 22363: (follow-up) Fix pod Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 Josef Moravec changed: What|Removed |Added Attachment #85634|0 |1 is obsolete|| --- Comment #21 from Josef Moravec --- Created attachment 85750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85750=edit Bug 22363: Add tests Signed-off-by: Andrew Isherwood Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 Josef Moravec changed: What|Removed |Added Attachment #85633|0 |1 is obsolete|| --- Comment #20 from Josef Moravec --- Created attachment 85749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85749=edit Bug 22363: Add Koha::ActionLog[s] objects Signed-off-by: Andrew Isherwood Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Kyle M Hall changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22420] Tag cloud feature broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Jonathan Druart changed: What|Removed |Added Assignee|mtomp...@hotmail.com|jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22420] Tag cloud feature broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 --- Comment #2 from Jonathan Druart --- Created attachment 85748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85748=edit Bug 22420: Remove duplicated tags Caused by commit e1b5fa657de843a177fb4bf57947a1376152d021 Bug 14385: Squash of a lot of patches rebased Test plan: - Have the OPAC tags feature enabled - Add a couple tags to different records, make sure some of them are used more than once - Go to 'Tag cloud' in the OPAC => the repeated tags must not be repeated many times. [- Enjoy the lack of tests.] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22420] Tag cloud feature broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #48 from Kyle M Hall --- Created attachment 85747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85747=edit Bug 22368: (QA follow-up) Changed to LEFT JOIN as requested Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #46 from Kyle M Hall --- Created attachment 85745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85745=edit Bug 22368: (QA follow-up) Missing comma in kohastructure.sql Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #47 from Kyle M Hall --- Created attachment 85746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85746=edit Bug 22368: (QA follow-up) Switch to using foreign_key_exists Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #45 from Kyle M Hall --- Created attachment 85744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85744=edit Bug 22368: (QA follow-up) Mute db errors in test Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #44 from Kyle M Hall --- Created attachment 85743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85743=edit Bug 22368: Add missing constraints to `suggestions` Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Kyle M Hall changed: What|Removed |Added Attachment #85739|0 |1 is obsolete|| --- Comment #43 from Kyle M Hall --- Created attachment 85742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85742=edit Bug 22368: Add tests Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #21 from Jonathan Druart --- Created attachment 85740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85740=edit Bug 21846: Fix pod2usage return values According to existing pattern. However I am not sure it makes sense to return an errno (and print to STDERR) if --help is passed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #22 from Jonathan Druart --- Created attachment 85741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85741=edit Bug 21846: Simplify ugly double for loops -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Kyle M Hall changed: What|Removed |Added Attachment #85723|0 |1 is obsolete|| Attachment #85725|0 |1 is obsolete|| Attachment #85726|0 |1 is obsolete|| Attachment #85727|0 |1 is obsolete|| Attachment #85728|0 |1 is obsolete|| Attachment #85729|0 |1 is obsolete|| --- Comment #42 from Kyle M Hall --- Created attachment 85739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85739=edit Bug 22368: Add tests Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22420] Tag cloud feature broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21846 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22420 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #20 from Jonathan Druart --- 1. Maybe we should display the WARNING during the updatedb process only if really needed? 2. How do I test the maintenance script? 3. Why no module for tags_all? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #19 from Kyle M Hall --- Won't this cause all accountline issue_ids to be nullified on checkin? I think that's a showstopper for that constraint. One solution would be to have issue_id and old_issue_id columns in the accountlines, and move the issue_id between them at checkin time. Also, Bug 19489 relies on issue_id not being nullified at checkin time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22403] Temporary Card
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22403 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #2 from Lisette Scheer --- For us it would be logging into pc reservation for in the library. Really any of our databases that use SIP connection could also have the same issue, though we don't write it out for them in that case, only in the case of needing to log onto the computer today. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22420] Tag cloud feature broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 --- Comment #1 from Tomás Cohen Arazi --- I'm sure it was caused by bug 14385 because it overwrites $results with something they calculate, and commmenting out the overwriting line fixes the problem. 324} 325#$results = \@filtered_results; 326stratify_tags(10, $results); # work out the differents sizes for things -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22420] Tag cloud feature broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Assignee|oleon...@myacpl.org |mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22420] Tag cloud feature broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Tomás Cohen Arazi changed: What|Removed |Added Depends on||14385 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22420] New: Tag cloud feature broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Bug ID: 22420 Summary: Tag cloud feature broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Steps to reproduce: - Have the OPAC tags feature enabled - Add a couple tags to different records, make sure some of them are used more than once - Go to 'Tag cloud' in the OPAC => FAIL: the repeated tags are displayed the same size of the other ones, and repeated many times (one per use). This was caused by bug 14385. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Tomás Cohen Arazi changed: What|Removed |Added Blocks||22420 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 [Bug 22420] Tag cloud feature broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008
--- Comment #18 from Jonathan Druart
---
Comment on attachment 85614
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85614
Bug 22008: Add missing constraints to accountlines
Review of attachment 85614:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=22008=85614)
-
Replace NOT IN with LEFT JOIN... NOT NULL?
::: installer/data/mysql/atomicupdate/bug_22008.perl
@@ +14,5 @@
> +$dbh->do("ALTER TABLE accountlines ADD CONSTRAINT
> `accountlines_ibfk_issues` FOREIGN KEY (`issue_id`) REFERENCES `issues`
> (`issue_id`) ON DELETE SET NULL ON UPDATE CASCADE");
> +}
> +
> +# Rename accountlines_ibfk_2 to accountlines_ibfk_items
> +if( foreign_key_exists( 'accountlines', 'accountlines_ibfk_2' ) ) {
You should test for accountlines_ibfk_items as well.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #15) > - But: tags table in the db is empty (should it be?) The 'tags' table is used by a tool that is not related to the tags feature, but the subject cloud for french terms. > - Tag cloud shows 2 tacos instead of one bigger taco This seems to be a bug in master already, with or without emojis. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #57 from Kyle M Hall --- Created attachment 85738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85738=edit Bug 19489: (QA follow-up) Revert changes in printinvoice It would be change behaviour, libraries are often using POS printers and wider table could make a problem for them and break theirs workflow. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Kyle M Hall changed: What|Removed |Added Attachment #85668|0 |1 is obsolete|| Attachment #85669|0 |1 is obsolete|| Attachment #85670|0 |1 is obsolete|| Attachment #85671|0 |1 is obsolete|| Attachment #85672|0 |1 is obsolete|| Attachment #85673|0 |1 is obsolete|| Attachment #85674|0 |1 is obsolete|| Attachment #85675|0 |1 is obsolete|| --- Comment #50 from Kyle M Hall --- Created attachment 85731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85731=edit Bug 19489: Koha::Account::Line->issue method and Unit test Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #52 from Kyle M Hall --- Created attachment 85733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85733=edit Bug 19489: Change method name issue --> checkout Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #56 from Kyle M Hall --- Created attachment 85737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85737=edit Bug 19489: (QA follow-up) Remove passing issue_id in pay form This is not needed Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #55 from Kyle M Hall --- Created attachment 85736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85736=edit Bug 19489: (QA follow-up) Update test to use objects and module methods for creating needed data Test plan: prove t/db_dependent/Koha/Account/Lines.t Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #53 from Kyle M Hall --- Created attachment 85734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85734=edit Bug 19489: (follow-up) Fix typos in the tests Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #54 from Kyle M Hall --- Created attachment 85735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85735=edit Bug 19489: (QA follow-up) Cache checkout object in variable Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #51 from Kyle M Hall --- Created attachment 85732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85732=edit Bug 19489: Detailed Description of charges in Patron accounting Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 --- Comment #12 from Nick Clemens --- Reverted from master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 85730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85730=edit Bug 21846: (QA follow-up) Fix maintenance script path Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #17 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #15) > Leaving this for tcohen to have another look: > > What I did: > - Added taco to 2 separate records > - Applied patches > - updatedatabase - dbic - maint script > - Report: Added => > - Checked the OPAC > - Clicking on taco now finds the 2 correct records, other tags work as well > - But: tags table in the db is empty (should it be?) > - Tag cloud shows 2 tacos instead of one bigger taco Katrina, in order to test this, you better add a couple tags on different biblios you can differentiate (both the biblios and the tags). I did, and this is what I got: https://snag.gy/VwboRH.jpg The last two SELECT are after the maintenance script is run. So the source for truth is the 'tags_all' table. And, initially, the 'tags_approval' and 'tags_index' tables contain wrong calculated data, due to the fact that all emojis are considered the same. The 'tags' table (which I hadn't had any idea about) is filled by misc/cronjobs/build_browser_and_cloud.pl. I would say leave that for another bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407
--- Comment #3 from Jonathan Druart
---
We have already everything in our code:
Koha::Item->biblio
93 sub biblio {
94 my ( $self ) = @_;
95 my $biblio_rs = $self->_result->biblio;
96 return Koha::Biblio->_new_from_dbic( $biblio_rs );
97 }
Koha::Item->checkout
121 sub checkout {
122 my ( $self ) = @_;
123 my $checkout_rs = $self->_result->issue;
124 return unless $checkout_rs;
125 return Koha::Checkout->_new_from_dbic( $checkout_rs );
126 }
Koha::Item->current_holds
271 sub current_holds {
272 my ( $self ) = @_;
273 my $attributes = { order_by => 'priority' };
274 my $dtf = Koha::Database->new->schema->storage->datetime_parser;
275 my $params = {
276 itemnumber => $self->itemnumber,
277 suspend => 0,
278 -or => [
279 reservedate => { '<=' => $dtf->format_date(dt_from_string) },
280 waitingdate => { '!=' => undef },
281 ],
282 };
283 my $hold_rs = $self->_result->reserves->search( $params, $attributes );
284 return Koha::Holds->_new_from_dbic($hold_rs);
285 }
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407
--- Comment #2 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #1)
> Yes, and no.
>
> You can only do that if you know the patron has a guarantor, which is not
> always true.
>
> You must do:
> sub guarantor {
> my ( $self ) = @_;
> my $guarantor_rs = $self->_result->guarantorid;
> return unless $guarantor_rs;
> return Koha::Patron->_new_from_dbic($guarantor_rs);
> }
>
> I am definitely in favor of that, we should have a guideline about it IMO.
The pattern should cover the one-to-many use case as well. And yes, the idea is
to propose a coding guideline!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407
--- Comment #1 from Jonathan Druart
---
Yes, and no.
You can only do that if you know the patron has a guarantor, which is not
always true.
You must do:
sub guarantor {
my ( $self ) = @_;
my $guarantor_rs = $self->_result->guarantorid;
return unless $guarantor_rs;
return Koha::Patron->_new_from_dbic($guarantor_rs);
}
I am definitely in favor of that, we should have a guideline about it IMO.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20545] Add multi-language support to SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20545 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Attachment #85609|0 |1 is obsolete|| --- Comment #37 from Martin Renvoize --- Created attachment 85725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85725=edit Bug 22368: Add missing constraints to `suggestions` Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #41 from Martin Renvoize --- Created attachment 85729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85729=edit Bug 22368: (QA follow-up) Changed to LEFT JOIN as requested Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Attachment #85608|0 |1 is obsolete|| --- Comment #36 from Martin Renvoize --- Created attachment 85723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85723=edit Bug 22368: Add tests Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Attachment #85610|0 |1 is obsolete|| --- Comment #38 from Martin Renvoize --- Created attachment 85726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85726=edit Bug 22368: (QA follow-up) Mute db errors in test Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Attachment #85612|0 |1 is obsolete|| --- Comment #40 from Martin Renvoize --- Created attachment 85728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85728=edit Bug 22368: (QA follow-up) Switch to using foreign_key_exists Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize changed: What|Removed |Added Attachment #85611|0 |1 is obsolete|| --- Comment #39 from Martin Renvoize --- Created attachment 85727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85727=edit Bug 22368: (QA follow-up) Missing comma in kohastructure.sql Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22419] New: removing multiple items from basket.pl causes browser timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22419 Bug ID: 22419 Summary: removing multiple items from basket.pl causes browser timeout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Target Milestone: --- Created attachment 85724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85724=edit timeout_screenshot Removing multiple items from basket.pl on the staff client causes the browser to timeout. (see attached) I can recreate this in both Firefox and Chrome. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22395] Data in 245 field (subfield a or b) will be deleted if it has Quotation Marks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22395 Jonathan Druart changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m, ||lu...@bywatersolutions.com --- Comment #5 from Jonathan Druart --- CCing Lucas (Rmaint 18.05) and Fridolin (Rmaint 17.11) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21986] Quotation marks are wrongly escaped in several places
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21986 --- Comment #17 from Jonathan Druart --- Lucas and Fridolin, take a look at bug 22395, it seems that this patch should not have been backported into your versions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 --- Comment #16 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #15) > I reported in Bug 22369 that combination of To.JSON and |html is wrong for > double quotes. JSON converts to \" and then html converts to \ which > is a non valid JSON. > You may test it also in list description. Read and tried the patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22245] MARC modification templates does not allow move or copy control fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- > > 2) > > This does not allow copy/move of a control field in the subfield of a > > regular field, ie 005 => 998$d. > > This should be allowed ? A very common use case would be 001 > 035$a + Adding a prefix in MARC21. So it would be nice if that worked. > > What is surely not allowed is : 005 => 998 I agree, in this case the 998 should have a subfield. Not sure the standard has a say about this, but a lot of code I think assumed only <10 have no subfields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22245] MARC modification templates does not allow move or copy control fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245
Jonathan Druart changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--- Comment #4 from Jonathan Druart
---
(In reply to Fridolin SOMERS from comment #3)
> 1)
> With this patch, if I set "from" with control field (ie 003) and "to" with a
> regular field (ie 998$e) :
>
> I get message :
> MSG_MMT_SUBFIELDS_MATCH = _("Both subfield values should be filled or
> empty.");
>
> I think this message is only for regular fields in "from" and "to", so you
> don't move a entire field to a subfield for example.
I would not add complexity to the JS code, the message is correct even if it
could be more exact. You can provide a follow-up if you think it's really
needed, I personally think it's not that important.
> 2)
> This does not allow copy/move of a control field in the subfield of a
> regular field, ie 005 => 998$d.
> This should be allowed ?
> What is surely not allowed is : 005 => 998
Maybe, maybe not.
This limitation has been added by commit 1079f971e3bc "Raise an alert if
control field is used". Added on bug 11395 comment 36 without explanations. I
cannot remember why, maybe you can find it on the BibLibre bug tracker?
Anyway it's for another bug report.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22418] Authority link magnifying glass icon doesn't appear for 655 subject tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22418 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22418] Authority link magnifying glass icon doesn't appear for 655 subject tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22418 --- Comment #1 from Nick Clemens --- Created attachment 85722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85722=edit Bug 22418: Add magnifying glass to 655 results To test: 1 - Have some 655 fields linked to authorities 2 - Notice they have no magnifyiung glass 3 - Apply patch 4 - Note they have one now -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21065] Data in account_offsets and accountlines is deleted with the patron leaving gaps in financial reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21065 --- Comment #30 from Jonathan Druart --- (In reply to Martin Renvoize from comment #29) > Did I mess up here.. should we be replacing the query to INFORMATION SCHEMA > with foreign_key_exists? > > Jonathan Druart, I'd appreciate your thoughts here... I'm happy to code it > up as a followup or a new bug. I do not think so. We are dropping the FK to recreate it with a different ON DELETE clause value. So we could have used foreign_key_exists but rename the FK. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22418] Authority link magnifying glass icon doesn't appear for 655 subject tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22418 Andrew changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22418] New: Authority link magnifying glass icon doesn't appear for 655 subject tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22418 Bug ID: 22418 Summary: Authority link magnifying glass icon doesn't appear for 655 subject tags Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- For authority-linked 650 tags, the catalog shows a magnifying glass icon that links to the authority record. It does not do the same for authority-linked 655 tags. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Martin Renvoize changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 --- Comment #11 from Martin Renvoize --- Ack, as this would require use packaging a more recent version of perlcritic I don't feel it's a big enough win to warrant the cleanup.. I'm inclined to agree with Jonathan that this point and suggest we revert it until a point in the future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #2 from Jonathan Druart --- And the screenshots: https://snag.gy/WVeqDf.jpg What you get once the job has been enqueued https://snag.gy/1GgnN5.jpg Detail of a non started job https://snag.gy/ySnlaF.jpg Detail of a finished job https://snag.gy/s5dF7n.jpg List of jobs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|In Discussion --- Comment #1 from Jonathan Druart --- I first tried Minion but found problematic issues for us (Koha): - The mysql backend requide Mojo::mysql which requires DBD::mysql 4.042 However Jessie has 4.028 and Stretch 4.041 - We could have used the Postgres backend, but we would have require MySQL/MariaDB and Postgres, which is not acceptable. I then gave a try to RabbitMQ (https://www.rabbitmq.com/documentation.html), which is an implementation of AMQP in Erlang. If you want more information about it I let you follow the link. The result is quite good, I managed to have a working POC, adapt to our uses, in a single day. Test plan: 0. Prerequisite: % sudo apt install libanyevent-rabbitmq-perl rabbitmq-server % sudo cpanm Net::RabbitFoot # Quid of the debian package? Then make sure the RabbitMQ server is running: % sudo service rabbitmq-server status and start it if needed with % sudo service rabbitmq-server start Then create, or make sure you have a MARC Modification Template, with template_id=1 (like add new field 123$z=foo) 1. To test this patch set you should first understand how the enqueue/consume process work: % perl new_koha_job.pl # Launch it 1+ times => The job must have been enqueued (no error in the output) % perl koha_worker.pl # Will consume the 1+ tasks you enqueued Do not close this worker and start another one in another console, then enqueue more new jobs. Enjoy :) (yes it should be fun) 2. Watch the history of the jobs Hit admin/background_jobs.pl (logged in as superlibrarian) This is an interface (to improve) to the list of pending/running and finished processes 3. Use this whole stuff in a real Koha world: Play with the "Batch record modification" tool (with biblios) Notice the different in the last (report) step and click on the "View detail of the enqueued job" link Discussions: 1. Please grep TODO and FIXME in the patchset, there are lot to do/fix. 2. Even if we do not go for RabbitMQ I think we could start moving the code from pl to Koha::BackgroundJob::*pm It will be "easy" (nothing is easy, right?) to replace it with something else. 3. With this base we will want to answer different needs: * background jobs * task scheduler * reindex process (?) Going further: 1. Implement Koha::BackgroundJob for the different background jobs 2. Provide a koha-worker script to consume to jobs 3. Rewrite the task scheduler with Koha::BackgroundJob (1993) 4. Provide a configuration file to prioritize or postpone jobs (for instance no batch modification on Wednesday between 9-17) - Or maybe we won't need that (?) 5. What would be your needs? Code is at https://gitlab.com/joubu/Koha/commits/bug_22417 (as the code will evolve in the next days I will not pollute here). Switched to 'In Discussion' to collect thoughts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #373 from Jonathan Druart --- CREATE TABLE statements do not follow the usual pattern: CREATE TABLE IF NOT EXISTS stockrotationitems vs DROP TABLE IF EXISTS `circulation_rules`; CREATE TABLE `circulation_rules` ( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] New: Delegate background jobs execution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Bug ID: 22417 Summary: Delegate background jobs execution Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Target Milestone: --- This is related to: Bug 15032 - [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected Bug 1993 - Task Scheduler Needs Re-write And many others. The goal here would be to remove the background execution in real time we are doing right now and delegate the jobs to an external service (handling several workers, load balancing, etc.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22417 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22417 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #59 from Cori Lynn Arnold --- In order to test this I clicked around a bunch everything looked good. Then went through a “normal” cataloging process for our company and found an issue. 1. Start by importing a batch of records. [We do some pre-processing here that does 75% of the copy cataloging pieces automagically] So I went to Tools->Stage records for import 2. Once this is complete, I go to Settings->Import batches and see that the batch shows up in “Import Batches” Yay! 3. I select this batch to be searchable, but not a save target. I want my records to go into FAW (the client that I’m cataloging for) https://paste.pics/fb6948f2a662bd927011008d40993c0c 4. I search for the record I want to catalog for FAW. Yay! It comes up! So I hit “Import” 5. I make the required changes *Problem* Though the batch is set as _unchecked_ for “Save Target” it is automatically selected for “Save to:” https://paste.pics/fc0f4afded30ad1d83ff94188578742e -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22411] Dates in log viewer not formatted correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22411 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22397] Wrong message in koha-sip --start
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22397 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22378] Fix sound alerts on SCO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22396] koha-sip script does not start the server correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21870] Convert browser alerts to modals: OPAC user summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #37 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Martin Renvoize changed: What|Removed |Added QA Contact|colin.campbell@ptfs-europe. |testo...@bugs.koha-communit |com |y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
