[Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Martin Renvoize changed: What|Removed |Added Attachment #90573|0 |1 is obsolete|

[Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 --- Comment #10 from Martin Renvoize --- (In reply to Jonathan Druart from comment #6) > Should we really ignore this case? It sounds like the library owes money to > somebody. > I have no idea how we could handle it properly

[Koha-bugs] [Bug 21671] Koha/Patron/Modifications.t is failing randomly

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED

[Koha-bugs] [Bug 21671] Koha/Patron/Modifications.t is failing randomly

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21671 Martin Renvoize changed: What|Removed |Added Version(s)|19.05.00, 18.11.06 |19.05.00, 18.11.06,

[Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You

[Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 --- Comment #1 from Andrew Isherwood --- Just to clarify, in the above workflows, at the stage: - User can then either choose a result and be taken to it, or choose none and continue with the request as normal If no sources return

[Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Jonathan Field changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff ---

[Koha-bugs] [Bug 22741] Koha/Patrons.t is failing randomly on test BorrowerLogs and TrackLastPatronActivity

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Martin Renvoize changed: What|Removed |Added Attachment #90850|0 |1 is obsolete|

[Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Andrew Isherwood changed: What|Removed |Added CC||mag...@libriotech.no,

[Koha-bugs] [Bug 23173] New: ILL should be able to search third party sources prior to request creation

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Bug ID: 23173 Summary: ILL should be able to search third party sources prior to request creation Change sponsored?: --- Product: Koha Version: master

[Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 --- Comment #9 from Marcel de Rooy --- Strange. Circulation.t passes and fails with me: not ok 19 - AddReturn must have debarred the patron # Failed test 'AddReturn must have debarred the patron' # at

[Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #8

[Koha-bugs] [Bug 23103] Cannot checkin items lost by deleted patrons with fines attached

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23103 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Marcel de Rooy changed: What|Removed |Added Attachment #90710|0 |1 is obsolete|

[Koha-bugs] [Bug 23140] Typo in returns.tt prevents printing branchcode in transfer slips

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 23159] Reindent addbiblio.tt

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 --- Comment #13 from Marcel de Rooy --- (In reply to M. Tompsett from comment #2) > Your insertion of comments while clarifying, would have been better in a > separate commit, so it would be easier to check. Agree completely.

[Koha-bugs] [Bug 23159] Reindent addbiblio.tt

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 23159] Reindent addbiblio.tt

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Marcel de Rooy changed: What|Removed |Added Attachment #90794|0 |1 is obsolete|

[Koha-bugs] [Bug 23159] Reindent addbiblio.tt

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 23159] Reindent addbiblio.tt

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Marcel de Rooy changed: What|Removed |Added Attachment #90792|0 |1 is obsolete|

[Koha-bugs] [Bug 23159] Reindent addbiblio.tt

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23159 Marcel de Rooy changed: What|Removed |Added Attachment #90793|0 |1 is obsolete|

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #23 from Marcel de Rooy --- @RM: Passing QA with a follow-up. Note that the current query also fails on strict SQL mode. So not blocking for that. And yes, it could be moved to a module on a new report. -- You are

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #22 from Marcel de Rooy --- Created attachment 90872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90872=edit Bug 13640: (QA follow-up) Allow NULL values for default_branch_item_rules.holdallowed If

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What|Removed |Added Attachment #90639|0 |1 is obsolete|

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #20 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #14) > Signing off as in a testing it appears to work as expected.. > > I'd love to see this query moved into a module and unit tested really, but >

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #19 from Marcel de Rooy --- The where condition is wrong. It should also incorporate the case that default_branch_item_rules is NULL (for istance, no corresponding record found for a biblio level hold). Will add a

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #18 from Marcel de Rooy --- Fails on strict sql mode: DBD::mysql::st execute failed: 'koha_master.reserves.reserve_id' isn't in GROUP BY [for Statement [ ... etc ] -- You are receiving this mail because: You are

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 23133] Rename reserves.item_level_hold for reserves.item_level

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23133 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Marcel de Rooy changed: What|Removed |Added Attachment #90822|0 |1 is obsolete|

[Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 23090] MySQL validate_password plugin breaks koha-create

2019-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23090 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

<    1   2   3