[Koha-bugs] [Bug 23194] Public notes items in the OPAC should allow for HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 --- Comment #16 from Christopher Brannon --- Is there a version of this that works for the staff interface? Links are just turned into static text. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23194] Public notes items in the OPAC should allow for HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 --- Comment #15 from Christopher Brannon --- This works great! Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Bouzid Fergani changed: What|Removed |Added Attachment #93113|0 |1 is obsolete|| --- Comment #32 from Bouzid Fergani --- Created attachment 93218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93218=edit Bug 18958: Make check reserves find in transit holds To test: Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB and LibraryC respectively. Now, a patron places two record level holds for pickup at LibraryD. When any of the items are checked in, that item is trapped to fill the first hold, but a side affect is that the next open hold because item level for the item that was just checked in! This is clearly incorrect and prevents the patron from placing more record level holds on the record. The problem seems to be that we use GetOtherReserves to initiate transfers for holds This routine calls CheckReserves to see what holds are on the record. We have an implicit assumption here that anything matching the holds queue is the correct hold. This worked when we couldn't have multiple holds on a record, but now it can end up with false positive. The solution seems to be returning the in-transit hold before returning a second hold on the record to make sure we affect the correct reserve. Test Plan: 1 - Create and use a patron that can place multiple record level holds per record 2 - Create a record with X items, each at a different library 3 - Place X 'Next available' holds on the record for the patron using the 'Holds to place' box 4 - perl misc/cronjobs/holds/build_holdsqueue.pl 5 - Check in LibraryA's copy as LibraryA and confirm the hold 6 - Revisit request.pl for the record, notice the next hold in line is now item-specific 7 - Checkout the item to the patron, notice the remaining hold is marked waiting 8 - Attempt to place another hold for your patron, notice that it requires an item-specific hold 8 - Apply this patch 9 - Repeat steps 1-5 10 - Revisit request.pl for the record, notice the next hold in line has *not* become item-specific 11 - Checkout the item to the patron, ensure the first hold is filled and the second remains record level 12 - Repeat whole test plan without building holds queue to confirm holds are still treated correctly Signed-off-by: Bonnie Gardner Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Bouzid Fergani changed: What|Removed |Added Attachment #93111|0 |1 is obsolete|| --- Comment #30 from Bouzid Fergani --- Created attachment 93216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93216=edit Bug 18958 - If patron has multiple record level holds on one record transferring first hold causes next hold to become item level Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB and LibraryC respectively. Now, a patron places to record level holds for pickup at LibraryD. When any of the items are checked in, that item is trapped to fill the first hold, but a side affect is that the next open hold because item level for the item that was just checked in! This is clearly incorrect and prevents the patron from placing more record level holds on the record. Test Plan: 1. Create and use a patron that can place multiple record level holds per record 2. Create a record with X items, each at a different library 3. Place X 'Next available' holds on the record for the patron using the 'Holds to place' box 4. Rebuild the holds queue 5. Check in LibraryA's copy as LibraryA and confirm the hold 6. Revisit request.pl for the record, notice the next hold in line is now item-specific 7. Attempt to place another hold for your patron, notice that it requires an item-specific hold 8. Apply this patch 9. Repeat steps 1-4 10. Revisit request.pl for the record, notice the next hold in line has *not* become item-specific Signed-off-by: Kyle M Hall Signed-off-by: Jason Robb Signed-off-by: Josef Moravec Bug 18958 [QA Followup] - Bring back data needed for the diffbranch block of the template Signed-off-by: Bonnie Gardner Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Bouzid Fergani changed: What|Removed |Added Attachment #93112|0 |1 is obsolete|| --- Comment #31 from Bouzid Fergani --- Created attachment 93217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93217=edit Bug 18958: Unit tests Signed-off-by: Bonnie Gardner Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23522] Actual price should be shown in basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Bouzid Fergani changed: What|Removed |Added Attachment #93000|0 |1 is obsolete|| --- Comment #3 from Bouzid Fergani --- Created attachment 93215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93215=edit Bug 23522: Show actual price on in baskets To test: 1 - Create a new basket in acq, mark it as 'standing' 2 - Add an item, leave the RRP and Vendor price as 0 3 - Receive shipments for the vendor 4 - Select the title from this basket 5 - On receipt enter an actual cost 6 - Finsih receiving 7 - Go to the basket 8 - Note the total for the order and the basket are 0, keep this browser tab open 9 - Open a new browser tab and create a new non standing basket 10 - Add to basket, again with no RRP or vendor price 11 - Close the basket, receive the item 12 - Enter an actual cost on receipt 13 - Return to view the basket 14 - Total and order are $0 15 - Apply patch 16 - Refresh the basket in both tabs 17 - You now see the actual price for the orders Signed-off-by: Rhonda Kuiper Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23679] Software error when trying to transfer an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Bin Wen changed: What|Removed |Added Attachment #93212|0 |1 is obsolete|| --- Comment #7 from Bin Wen --- Created attachment 93213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93213=edit Bug 23679: fix software error when trying to transfer an unknown barcode When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. Test plan : 1) Go to /cgi-bin/koha/circ/branchtransfers.pl 2) Enter a barcode not existing in database 3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' 4) Enter a barcode existing in database and check transfer is OK Signed-off-by: Owen Leonard Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23679] Software error when trying to transfer an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Bin Wen changed: What|Removed |Added Attachment #93211|0 |1 is obsolete|| --- Comment #8 from Bin Wen --- Created attachment 93214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93214=edit Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t I've choosen to add it to db_dependent because we may add other tests to cover transferbook() cases that will change DB Signed-off-by: Owen Leonard Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23679] Software error when trying to transfer an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Bin Wen changed: What|Removed |Added Attachment #93199|0 |1 is obsolete|| --- Comment #6 from Bin Wen --- Created attachment 93212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93212=edit Bug 23679: fix software error when trying to transfer an unknown barcode When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. Test plan : 1) Go to /cgi-bin/koha/circ/branchtransfers.pl 2) Enter a barcode not existing in database 3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' 4) Enter a barcode existing in database and check transfer is OK Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23679] Software error when trying to transfer an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Bin Wen changed: What|Removed |Added Attachment #93198|0 |1 is obsolete|| --- Comment #5 from Bin Wen --- Created attachment 93211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93211=edit Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t I've choosen to add it to db_dependent because we may add other tests to cover transferbook() cases that will change DB Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23688] System preference uppercasesurnames broken by typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23688 ByWater Sandboxes changed: What|Removed |Added Attachment #93189|0 |1 is obsolete|| --- Comment #3 from ByWater Sandboxes --- Created attachment 93210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93210=edit Bug 23688 - System preference uppercasesurnames broken by typo In the process of moving this feature from memberentry.pl to Patron.pm, the 's' on uppercasesurnames was dropped, breaking the feature. Test Plan: 1) Test uppercasesurnames, note it does not work 2) Apply this patch 3) Test uppercasesurnames, note it works now! Signed-off-by: Kyle Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23688] System preference uppercasesurnames broken by typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23688 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #4 from Andrew Fuerste-Henry --- Signed off for Karen Fellows, karen.fell...@citruslibraries.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #47 from Tomás Cohen Arazi --- This route: POST /return_claims/claim/{item_id} { notes: ..., created_by: ..., charge_lost_fee: ... } should really be POST /return_claims { item_id: ..., notes: ..., created_by: ..., charge_lost_fee: ... } -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23685] Exporting report may consume unlimited memory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #2 from Paul Hoffman --- (In reply to Katrin Fischer from comment #1) > Hi Paul, can you share why you closed INVALID? I tweaked bug #23626 (memory consumption related to the charting feature) to encompass this problem, because they involve the same files and the same underlying problem -- running a report and then doing something with the results (charting or exporting) potentially consumes all available memory. Maybe I should post a comment there with the details from this ticket? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23685] Exporting report may consume unlimited memory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Paul, can you share why you closed INVALID? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23684] Import items only with merging rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23684 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Can you share what your items looked like? A common problem would be branchcodes in $a and $b not matching exactly (case-sensitive) what was configured in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23447] Fix capitalization and other minor edits on patron batch edit template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23447 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23447] Fix capitalization and other minor edits on patron batch edit template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23447 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 93209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93209=edit Bug 23447: Fix capitalization and other minor edits on patron batch edit template Just some small fixes: - Category => Patron category (more specific for translation) - Attribute => Patron attribute - Opac Note => OPAC note - Add missing colons (:) after some of the labels To test: - Find an existing cardnumber - Go to Tools > Patron batch modification - Use cardnumber in input field and continue - Verify strings show as noted above - Apply patch - Repeat and verify strings have changed, everything still works Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23447] Fix capitalization and other minor edits on patron batch edit template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23447 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23447] Fix capitalization and other minor edits on patron batch edit template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23447 Tomás Cohen Arazi changed: What|Removed |Added Attachment #92272|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8778] Add Keyword phrase search to OPAC search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778 Tomás Cohen Arazi changed: What|Removed |Added QA Contact||tomasco...@gmail.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23690] During checkout, window hangs with a pop up "Loading...you may continue scanning."
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23690 --- Comment #1 from Owen Leonard --- Did this behavior start after an upgrade? Have you tried clearing your browser cache? Do you have any custom JavaScript in the IntranetUserJS system preference? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23690] During checkout, window hangs with a pop up "Loading...you may continue scanning."
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23690 Owen Leonard changed: What|Removed |Added Summary|During checkout, window |During checkout, window |hangs with a pop up |hangs with a pop up |"Loading...you may continue |"Loading...you may continue |scanning." This message,|scanning." |whilst confounding, impedes | |staff from accessing other | |aspects of the patron | |record. Our work around| |has been to advise staff | |to print check-out slip.| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23660] Add system preference to remove message body from sent notices after notice status switches to sent.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23660 Brendon Ford changed: What|Removed |Added CC||brendon.f...@manhattan.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23688] System preference uppercasesurnames broken by typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23688 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #2 from Lisette Scheer --- Both before and after applying the patch I had to go edit a patron to make their name display in uppercase after turning the setting on. We don't use this feature, so I'm not sure if that is the desired effect or if it should do it as soon as you turn the setting. Lisette -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23690] New: During checkout, window hangs with a pop up "Loading...you may continue scanning." This message, whilst confounding, impedes staff from accessing other aspects of the patr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23690 Bug ID: 23690 Summary: During checkout, window hangs with a pop up "Loading...you may continue scanning." This message, whilst confounding, impedes staff from accessing other aspects of the patron record. Our work around has been to advise staff to print check-out slip. Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: julie.k...@huntsvillelibrary.ca QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Created attachment 93208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93208=edit screen shot of pop-up message "Loading...you can continue scanning." This message, whilst confounding, impedes staff from accessing other aspects of the patron record. Our work-around has been to advise staff to print check-out slip. Patrons with email do received an confirmation of checked out items. However, if this is a system preference that can be removed without compromising the integrity of the patron record nor check out process, I would like to know and to know how to change the system preference. Please, help! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 robbi...@middlesex.mass.edu changed: What|Removed |Added CC||robbi...@middlesex.mass.edu --- Comment #26 from robbi...@middlesex.mass.edu --- Does this fix take into account patron type? We have some item types that are requestable by one type of patron category but not by other patron categories. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23689] Terminology: Branches limitations should be libraries limitations - Authorised Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23689 --- Comment #4 from Martin Renvoize --- (In reply to Martin Renvoize from comment #2) > The patch updates the tooltip to use the bootstrap tooltip but I have no > idea how it was displaying a tooltip in the first place and I'm still seeing > some markup at the bottom of the page pertaining to the original tooltip > implementation. Ignore that.. the markup I was seeing was inserted by a browser extension. Still, no idea how the original tooltip was working but this does update it to use the same implementation as elsewhere (itemtypes table for instance) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23689] Terminology: Branches limitations should be libraries limitations - Authorised Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23689 Owen Leonard changed: What|Removed |Added Attachment #93206|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 93207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93207=edit Bug 23689: Fix terminology for branches limitations on authorized values This patch corrects the terminology and also updates the tooltip to use the current bootstrap tooltip library. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23689] Terminology: Branches limitations should be libraries limitations - Authorised Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23689 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23689] Terminology: Branches limitations should be libraries limitations - Authorised Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23689 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23689] Terminology: Branches limitations should be libraries limitations - Authorised Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23689 --- Comment #2 from Martin Renvoize --- The patch updates the tooltip to use the bootstrap tooltip but I have no idea how it was displaying a tooltip in the first place and I'm still seeing some markup at the bottom of the page pertaining to the original tooltip implementation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23689] Terminology: Branches limitations should be libraries limitations - Authorised Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23689 Martin Renvoize changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23689] Terminology: Branches limitations should be libraries limitations - Authorised Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23689 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23689] Terminology: Branches limitations should be libraries limitations - Authorised Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23689 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23689] Terminology: Branches limitations should be libraries limitations - Authorised Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23689 --- Comment #1 from Martin Renvoize --- Created attachment 93206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93206=edit Bug 23689: Fix terminology for branches limitations on authorized values This patch corrects the terminology and also updates the tooltip to use the current bootstrap tooltip library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23685] Exporting report may consume unlimited memory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Paul Hoffman changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23252] Missing input_marceditor class in item editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252 --- Comment #11 from Fridolin SOMERS --- (In reply to Marcel de Rooy from comment #10) > $(document).ready(function() { > $("input.input_marceditor, input.indicator").addClass('noEnterSubmit'); > +$(document).ajaxSuccess(function() { > +$("input.input_marceditor, > input.indicator").addClass('noEnterSubmit'); > +}); > }); > > Christophe: I am having the impression that only orderreceive needs this. In > the context of cataloging.js and its broader use, it seems to me that adding > it closer to the needed location would be better? Please confirm. Actually indeed, but for me having all in cataloging.js is better. Imagine we change the name of the class "input_marceditor". Or if we change serials receive to use Ajax. Thanks a lot for your time :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23631] fr-CA translation of NEW_SUGGESTION notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23631 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23631] fr-CA translation of NEW_SUGGESTION notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23631 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23602] Library limitations should display in the item types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 --- Comment #12 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23602] Library limitations should display in the item types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23213] OPAC check mimimum payment threshold from payment plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 --- Comment #10 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23214] OPAC add ability to pay guarantees fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 --- Comment #13 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23214] OPAC add ability to pay guarantees fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23213] OPAC check mimimum payment threshold from payment plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23651] RestrictedPage system preferences should include the address of the page in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23651 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23683] Course reserves public notes on specific items should allow for HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23683 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23651] RestrictedPage system preferences should include the address of the page in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23651 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23683] Course reserves public notes on specific items should allow for HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23683 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23627] Koha::Biblio->get_coins too noisy if no 245$b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23627 --- Comment #6 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23627] Koha::Biblio->get_coins too noisy if no 245$b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23627 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 --- Comment #9 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23625] ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23625 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23607] Make /patrons/:patron_id/account staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23607 --- Comment #7 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23607] Make /patrons/:patron_id/account staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23607 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23101] Contracts permissions for staff patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 --- Comment #18 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 --- Comment #11 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #5 from Anke --- (In reply to Anke from comment #4) > (In reply to Anke from comment #3) > > As I noticed, the German Umlauts aren't displayed correctly after patron > > import even in patron names, patron attributes and other fields. Even with UTF 8 chosen for encoding, as mentioned in the documentation, the umlaute are shown correctly in the import "log" list, but in the "real" patron entries they are still shown as question marks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18710] Wrong subfield modified in batch item modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18710 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Paul Hoffman changed: What|Removed |Added Summary|Add a system preference to |Add a system preference to |limit the number of rows of |limit the number of rows of |data used in a chart when |data used when charting or |viewing report results |exporting report results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used in a chart when viewing report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #33 from Paul Hoffman --- (In reply to Martin Renvoize from comment #30) > We discussed this bug during the Development Meeting and concluded that a > simpler fix for now would be to add a system preference to enable/disable > charting functionality entirely. > > In this way we would be able to skip the 'all results' call entirely whilst > we work on another implementation to allow fetching of results in a more > memory friendly way. Since the problem now turns out to affect exporting as well as charting, I don't think we should add a system preference to enable/disable charting. Or, if we do, it should be a lower priority than this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23689] New: Terminology: Branches limitations should be libraries limitations - Authorised Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23689 Bug ID: 23689 Summary: Terminology: Branches limitations should be libraries limitations - Authorised Values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com On the authorized value administration pages we should use 'libraries limitations' instead of 'branches limitations'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23602] Library limitations should display in the item types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize --- Passing QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23602] Library limitations should display in the item types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Owen Leonard changed: What|Removed |Added Attachment #93202|0 |1 is obsolete|| --- Comment #10 from Owen Leonard --- Created attachment 93205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93205=edit Bug 23602: (follow-up) Improve tooltip formatting This follow-up changes the formatting of the tooltip to add a newline for library limit. To test, apply the patch and go to Administration -> Item types. In the table of item types, find one with library limitations. Hovering over the "# library limitations" test should trigger a Bootstrap-styled tooltip showing the library name and code, one per line. Signed-off-by: Martin Renvoize Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #4 from Anke --- (In reply to Anke from comment #3) > As I noticed, the German Umlauts aren't displayed correctly after patron > import even in patron names, patron attributes and other fields. Update - sorry, got this wrong! If UTF 8 (without BOM") is chosen for encoding, it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used in a chart when viewing report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Paul Hoffman changed: What|Removed |Added Attachment #92919|0 |1 is obsolete|| Attachment #92920|0 |1 is obsolete|| Attachment #92921|0 |1 is obsolete|| Attachment #92994|0 |1 is obsolete|| --- Comment #32 from Paul Hoffman --- Created attachment 93204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93204=edit Broaden the scope of the system preference to include exported report results This patch brings the previous set of patches together, renames the system preference, and applies the limit (if set) to exported results. It will require some additional tweaking to insert a prominent note in the UI when the limit has been set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23686] Check onsite checkout when the last checkout was an onsite one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23686 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23686] Check onsite checkout when the last checkout was an onsite one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23686 Owen Leonard changed: What|Removed |Added Attachment #93186|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 93203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93203=edit Bug 23686: Check onsite checkout when the last checkout was an onsite one Prevent from checking again and again the onsite checkout box when doing onsite checkouts in batches. If preceding checkout was an onsite one, the box will be checked. Test plan: 1. enable OnSiteCheckouts 2. make your circulation rules able to checkout onsite 3. onsite checkout a document 4. you should return to the checkout page, the box isn't checked 5. apply patch 6. updatedatabase.pl 7. redo steps 3, it should again print a checkout page with an unchecked onsite checkout box 8. enable OnSiteCheckoutAutoCheck system preference 9. redo step 3 10. when returning to the checkout page, the onsite checkout box should be already checked Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23602] Library limitations should display in the item types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Anke changed: What|Removed |Added CC||anke.br...@gwdg.de --- Comment #3 from Anke --- As I noticed, the German Umlauts aren't displayed correctly after patron import even in patron names, patron attributes and other fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23602] Library limitations should display in the item types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 --- Comment #9 from Martin Renvoize --- Created attachment 93202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93202=edit Bug 23602: (follow-up) Improve tooltip formatting This follow-up changes the formatting of the tooltip to add a newline for library limit. To test, apply the patch and go to Administration -> Item types. In the table of item types, find one with library limitations. Hovering over the "# library limitations" test should trigger a Bootstrap-styled tooltip showing the library name and code, one per line. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23602] Library limitations should display in the item types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize changed: What|Removed |Added Attachment #93046|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 93201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93201=edit Bug 23602: (follow-up) Correct terminology, add tooltip This follow-up changes the use of "branch" to the Koha standard "library." The patch also adds the use of a Bootstrap tooltip for showing an item type's library limitations in the main table of item types. To test, apply the patch and go to Administration -> Item types. In the table of item types, find one with library limitations. Hovering over the "# library limitations" test should trigger a Bootstrap-styled tooltip showing the library name and code. Signed-off-by: Maryse Simard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23602] Library limitations should display in the item types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 Martin Renvoize changed: What|Removed |Added Attachment #93044|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 93200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93200=edit Bug 23602: Display branch limitations in itemtype table This patch adds a column in itemtype table to display branch limitations. To test: 1) Open item types admin page. CHECK => there is no column for branch limitations, even if you add a limitation in an item type. 2) Apply this patch SUCCESS => A new column appears that displays branch limitations per item type 3) Sign off Signed-off-by: Owen Leonard Signed-off-by: Maryse Simard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23630] Elasticsearch indexing is removing field 999
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23630 Fridolin SOMERS changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #71 from Lari Taskula --- (In reply to Lari Taskula from comment #63) > We are also trying to solve this issue. About a month ago I created some > patches for the National Library of Finland to test within the Finnish Koha > fork. I did not yet rebase those patches for master, but they can be found > in this PR > > https://github.com/KohaSuomi/Koha/pull/104 > > Sorry for causing duplicate work. I should had mentioned this as I started > the task. Here are my patches from GitHub, rebased on current master branch. I didn't test team Lyon's patch, but it seems the main difference is that this version displays a more specific error message "Transfer is forbidden between [% Branches.GetName( holdingbranch ) %] (item's current library) and [% LoginBranchname | html %]." The location for logic is also different. Mine checks transfer limits in CanBookBeReturned() while the original patch does it in AddReturn(). Not sure if it currently makes a difference, but it could help covering some edge cases. AddReturn of course internally uses CanBookBeReturned so I suppose this is more appropriate place to add the logic into. But as the original patch, this is also missing unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23679] Software error when trying to transfer an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 --- Comment #4 from Owen Leonard --- Created attachment 93199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93199=edit Bug 23679: fix software error when trying to transfer an unknown barcode When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. Test plan : 1) Go to /cgi-bin/koha/circ/branchtransfers.pl 2) Enter a barcode not existing in database 3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' 4) Enter a barcode existing in database and check transfer is OK Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23679] Software error when trying to transfer an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23679] Software error when trying to transfer an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Owen Leonard changed: What|Removed |Added Attachment #93164|0 |1 is obsolete|| Attachment #93165|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 93198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93198=edit Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t I've choosen to add it to db_dependent because we may add other tests to cover transferbook() cases that will change DB Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used in a chart when viewing report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #31 from Paul Hoffman --- (In reply to Paul Hoffman from comment #0) > The attached patch introduces a system preference to limit the number of > rows used when charting report results; at this time, and with bug #23624 > fixed, that is the only aspect of reporting that loads all results into > memory at once. Well, I was totally wrong. Exporting the results (tab-delimited, CSV, or *.ods) also loads all results into memory at once. I am working on patches that broaden the sys pref and use it to limit the rows when exporting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Lari Taskula changed: What|Removed |Added Attachment #93190|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Lari Taskula changed: What|Removed |Added Attachment #93192|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Lari Taskula changed: What|Removed |Added Attachment #93191|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272 --- Comment #15 from Martin Renvoize --- Created attachment 93197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93197=edit Bug 23272: (RM followup) Fix edit action This bug introduced a regression whereby if an authorized value has no branch limitations then the authorized value cannot be edited once it has been created. The edit page would display an error and not load. This is the second case of a simple ternary correcting the issue, but the logic of returning 'undef' from 'get_branch_limits' being called into question. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #70 from Lari Taskula --- Created attachment 93196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93196=edit (ANOTHER IMPLEMENTATION) Bug 7376: Transfer limits should be checked at check-in Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup After the patch, the behaviour respect the branch transfer limit parameter: you can check-in if you accept transfers, you can't if you refuse them. (Note: IndependantBranches must be OFF, otherwise it's not possible to do the checkin whatever the branch transfer limits) Sponsored-by: National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #69 from Lari Taskula --- Created attachment 93195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93195=edit (ANOTHER IMPLEMENTATION) Bug 7376: Fix wrong indentation of CanBookBeReturned To test: 1. git diff -w --word-diff-regex=[^[:space:]] HEAD~1 2. Observe no differences (above cmd ignores space changes) 3. Therefore patch only includes whitespace changes Sponsored-by: National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Lari Taskula changed: What|Removed |Added Attachment #93193|0 |1 is obsolete|| --- Comment #68 from Lari Taskula --- Created attachment 93194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93194=edit (ANOTHER IMPLEMENTATION) Bug 7376: Refactoring subroutines CanBookBeReturned: - Take Koha::Item as parameter instead of HASHref of an item To test: 1. cd into your Koha root directory 2. grep -rn 'CanBookBeReturned(' 3. Make sure all returned occurences are using Koha::Item Sponsored-by: National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #67 from Lari Taskula --- Created attachment 93193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93193=edit Bug 7376: Refactoring subroutines CanBookBeReturned: - Take Koha::Item as parameter instead of HASHref of an item To test: 1. cd into your Koha root directory 2. grep -rn 'CanBookBeReturned(' 3. Make sure all returned occurences are using Koha::Item Sponsored-by: National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #66 from Lari Taskula --- Created attachment 93192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93192=edit (ANOTHER IMPLEMENTATION) Bug 7376: Transfer limits should be checked at check-in Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup After the patch, the behaviour respect the branch transfer limit parameter: you can check-in if you accept transfers, you can't if you refuse them. (Note: IndependantBranches must be OFF, otherwise it's not possible to do the checkin whatever the branch transfer limits) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #65 from Lari Taskula --- Created attachment 93191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93191=edit (ANOTHER IMPLEMENTATION) Bug 7376: Fix wrong indentation of CanBookBeReturned To test: 1. git diff -w --word-diff-regex=[^[:space:]] HEAD~1 2. Observe no differences (above cmd ignores space changes) 3. Therefore patch only includes whitespace changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #64 from Lari Taskula --- Created attachment 93190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93190=edit (ANOTHER IMPLEMENTATION) Bug 7376: Refactoring subroutines CanBookBeReturned: - Take Koha::Item as parameter instead of HASHref of an item To test: 1. cd into your Koha root directory 2. grep -rn 'CanBookBeReturned(' 3. Make sure all returned occurences are using Koha::Item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23688] System preference uppercasesurnames broken by typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23688 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23688] System preference uppercasesurnames broken by typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23688 --- Comment #1 from Kyle M Hall --- Created attachment 93189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93189=edit Bug 23688 - System preference uppercasesurnames broken by typo In the process of moving this feature from memberentry.pl to Patron.pm, the 's' on uppercasesurnames was dropped, breaking the feature. Test Plan: 1) Test uppercasesurnames, note it does not work 2) Apply this patch 3) Test uppercasesurnames, note it works now! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23688] System preference uppercasesurnames broken by typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23688 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23199] Koha::Patron->store and uppercasesurname syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199 Kyle M Hall changed: What|Removed |Added Blocks||23688 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23688 [Bug 23688] System preference uppercasesurnames broken by typo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23688] New: System preference uppercasesurnames broken by typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23688 Bug ID: 23688 Summary: System preference uppercasesurnames broken by typo Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com In the process of moving this feature from memberentry.pl to Patron.pm, the 's' on uppercasesurnames was dropped, breaking the feature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23688] System preference uppercasesurnames broken by typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23688 Kyle M Hall changed: What|Removed |Added Depends on||23199 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23199 [Bug 23199] Koha::Patron->store and uppercasesurname syspref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/