[Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Martin Renvoize changed: What|Removed |Added Depends on|25236 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize changed: What|Removed |Added Blocks|25237 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25150] Accessibility: 2.4.10 Section Headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25150 Martin Renvoize changed: What|Removed |Added Depends on||25237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize changed: What|Removed |Added Blocks||25237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25237] New: Accessibility: The 'Author details' in the full record display contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Bug ID: 25237 Summary: Accessibility: The 'Author details' in the full record display contains semantically incorrect headings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: oleon...@myacpl.org, testo...@bugs.koha-community.org Depends on: 25236 Blocks: 25150 Library Catalogue - OPAC The ‘Author’ heading is not logical because it increases by more than one heading level. This means that screen reader users may not be able to determine the structure of content on the page. 1/ Search for an item 2/ Click through to a records full details disaply 3/ Note that the author details are semantically marked as a heading of the wrong level. Current Code: By: Barty, James | Morgan Grenfell. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25150 [Bug 25150] Accessibility: 2.4.10 Section Headings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize changed: What|Removed |Added Depends on|25155 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25236] New: Accessibility: The 'Refine your search' box contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Bug ID: 25236 Summary: Accessibility: The 'Refine your search' box contains semantically incorrect headings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: oleon...@myacpl.org, testo...@bugs.koha-community.org Depends on: 25155 Blocks: 25150 Library Catalogue - OPAC The ‘Refine your search’ heading is not logical because it increases by more than one heading level. This means that screen reader users may not be able to determine the structure of content on the page. 1/ Search for an item 3/ The resultant page contains a 'Regine your search' box containing filters. Current Code: Refine your search Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25150 [Bug 25150] Accessibility: 2.4.10 Section Headings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 Martin Renvoize changed: What|Removed |Added Blocks|25236 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25150] Accessibility: 2.4.10 Section Headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25150 Martin Renvoize changed: What|Removed |Added Depends on||25236 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 Martin Renvoize changed: What|Removed |Added Blocks||25236 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25235] Don't alert when replacing an authority record via Z39.50
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25235 --- Comment #1 from Phil Ringnalda --- Created attachment 103439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103439=edit Bug 25235: Rename the button instead of alerting when replacing an existing record Test plan: Pre-patch 1 - Go to the main Authorities page, search for any authority, click the Actions menubutton and choose Edit 2 - Note the button saying Z39.50 search 3 - Note the modal alert forcing you to click it 4 - Cancel and cancel again, and in the New authority menubutton choose Default 5 - Click the button saying Z39.50 search again, note that it warns you about replacing your totally blank record Apply this patch 6 - Edit an existing authority, note the button says "Replace record via Z39.50/SRU search" 2 - Click the button, verify it still opens the search window with the main entry of the record filled in without an alert 3 - Create a new authority, note the button says "Z39.50/SRU search" 4 - Click the button, verify it still opens the search window but without an alert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25235] Don't alert when replacing an authority record via Z39.50
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25235 Phil Ringnalda changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25235] New: Don't alert when replacing an authority record via Z39.50
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25235 Bug ID: 25235 Summary: Don't alert when replacing an authority record via Z39.50 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: p...@chetcolibrary.org Reporter: p...@chetcolibrary.org QA Contact: testo...@bugs.koha-community.org The authority version of bug 25231 From the details page for an authority record, we just have a menuitem that says "Replace record via Z39.50/SRU" without any followup modal alert, but if you edit the authority (which you do, of course, because the details page choice doesn't fill in a search term like the edit page does) then clicking the button brings up a modal alert to tell you what you already knew you were doing. Just changing the button label from "search" to "replace" depending on whether you are creating a new record or editing an existing one will be smoother. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25074] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25074 --- Comment #1 from Deni mardiansyah --- Created attachment 103438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103438=edit Qontol -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23852] Merge biblio-title.inc and biblio-default-view.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23852 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Hi Owen. Just checking on this one before I sign it off. There are several areas where, while they reflect current behaviour, are inconsistent. I'm assuming this bug is 'like for like' and that any corrections to address inconsistencies should be a separate bug. Examples include: - Home › Circulation › Checkouts <-- Checkouts is in bold, should possibly be Check out (to match with other buttons and labels) - Home › Circulation › Checkouts › [Patron name (ID)] <-- should possibly be Check out rather than Checkouts (after putting in a patron) - For several items the last part of the breadcrumb is linked: . Home › Circulation › Article requests . Home › Circulation › Holds queue . Home › Circulation › Holds awaiting pickup . Home › Circulation › Set library . Home › Tools › Batch record deletion - Other things noticed: . Home › Circulation › Transfers <-- Button on the circulation page is Transfer, although it does have a group heading Transfers . Home › Circulation › Overdues at [Library name] <-- For Overdues with fines, should this display as Overdues with fines at [Library name] instead? Notes for myself from testing - enable these system preferences: - StockRotation (enable) - ArticleRequests (enable) - BatchCheckouts (allow) + BatchCheckoutsValidCategories (add patron categories) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia changed: What|Removed |Added Attachment #98779|0 |1 is obsolete|| --- Comment #7 from Aleisha Amohia --- Created attachment 103437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103437=edit Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20662] The "most popular" function on the opac does not honour opac supression
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20662 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19704 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19704] OPACs most popular feature includes titles hidden by OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20662 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20662] The "most popular" function on the opac does not honour opac supression
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20662 David Cook changed: What|Removed |Added Summary|The "most poplular" |The "most popular" function |function on the opac does |on the opac does not honour |not honour opac supression |opac supression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361 Alex Buckley changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #14 from Alex Buckley --- Looking over this bug report again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25082] Unknown language code if 041 $a is linked to an authorized value list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25082 --- Comment #7 from Pablo AB --- Thanks to both! Will be backported to stable releases? I don't know where to check this info. I'm not sure if this bug is related to Bug 20307. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25234] Update OPAC search results pagination with aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 --- Comment #4 from Owen Leonard --- (In reply to Lucas Gass from comment #2) > Not 100% sure if we should fix that here or in a separate bug? Easy enough to fix up the patch. Thanks for noticing it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25234] Update OPAC search results pagination with aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Owen Leonard changed: What|Removed |Added Attachment #103423|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 103436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103436=edit Bug 25234: Update OPAC search results pagination with aria labels This patch updates the include file which generates OPAC search results pagination so that it has better semantic markup and correct aria labels. To test, apply the patch and do a search in the OPAC which will return multiple pages of search results. View the source to confirm the markup changes: - instead of surrounding the list of links, with a corresponding aria label - Navigation links should have labels indicating which page in the results they point to. - The current link should have "aria-disabled," and "aria-current" set. - Numbered links should have aria labels that indicate their number. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #32 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #28) > This is quite an old patch that changes more files than you'd think at first > glance. We got a sign-off from Nicole here, but it's from March 2015. Hope > it's ok, but I'd like to ask for a new sign off here. > > Tests pass and QA script too - I like to see the amount of 'red' (removed > code) too. Signed both patches, but sending a list by email fails because there is a forgotten call to GetMember, follow-up added -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 --- Comment #31 from Bernardo Gonzalez Kriegel --- Created attachment 103435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103435=edit Bug 13345: follow-up remove call to GetMember This followup removes a forgotten call to GetMember -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #101998|0 |1 is obsolete|| --- Comment #29 from Bernardo Gonzalez Kriegel --- Created attachment 103433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103433=edit Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Note that subtitles are not displayed in all these cases. Note for QA: This patch refactors 3 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Not that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl 3/ Build the subject and body of the email sent Same as before, the job was done at the same places. Now it's done in Koha::Email->fill_body_for_sending (feel free to suggestion a better name) and tests are provided in t/Koha_Email.t Sponsored-by: Mines Paristech Signed-off-by: Nicole C. Engard Signed-off-by: Bernardo Gonzalez Kriegel Test pass and mail sent, no errors. But a follow-up to remove useless call to GetMember is needed for email list to work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #101999|0 |1 is obsolete|| --- Comment #30 from Bernardo Gonzalez Kriegel --- Created attachment 103434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103434=edit Bug 13345: Fix BuildBiblioDataForExport tests Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #27 from David Nind --- (In reply to Martin Renvoize from comment #20) > I've now obsoleted patch three as discussed. > > Test plan wise, the Unit tests effectively emulate the plan in Nicks first > comment. It's never a bad idea to give it a go manually as a double check > that the unit tests are doing what they're supposed to. I applied the patch and ran prove t/db_dependent/Overdues.t Hope that is sufficient for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 David Nind changed: What|Removed |Added Attachment #103327|0 |1 is obsolete|| --- Comment #26 from David Nind --- Created attachment 103432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103432=edit Bug 25127: Use Koha::Number::Price->round for comparison Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 David Nind changed: What|Removed |Added Attachment #103325|0 |1 is obsolete|| --- Comment #24 from David Nind --- Created attachment 103430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103430=edit Bug 25127: Unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 David Nind changed: What|Removed |Added Attachment #103326|0 |1 is obsolete|| --- Comment #25 from David Nind --- Created attachment 103431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103431=edit Bug 25127: Correction to tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25233] Staff XSLT material type label "Book" should be "Text"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #8 from David Cook --- (In reply to Katrin Fischer from comment #6) > Yes, sorry, just typed up the other comment - I had worked that out a while > ago when we got the complaints and I was trying to see if our records were > correct. Yep, I totally agree with you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24197] Custom destination for failed overdue notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #7 from Alex Buckley --- All ready to test :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24197] Custom destination for failed overdue notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #6 from Alex Buckley --- Created attachment 103429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103429=edit Bug 24197: Changed use of 'branch' terminology to 'library' Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #9 from David Cook --- (In reply to Julian Maurice from comment #8) > (In reply to Kyle M Hall from comment #6) > > (In reply to Julian Maurice from comment #5) > > > Hi Kyle, > > > > > > Can you comment on why you chose to name the file META.yml ? Is it related > > > to https://metacpan.org/pod/CPAN::Meta::Spec ? > > > > You are essentially correct. The file name is inspired by CPAN's > > META.yml/META.json file. > > Won't that be a problem if people want to publish their plugins on CPAN ? I was wary of using META.yml for a name due to its CPAN significance, but publishing plugins on CPAN seems problematic. It seems to me the plugins are their own packages and that the metadata file is part of that packaging scheme, so I don't really see the overlap. Like you could publish the module for a Koha plugin on CPAN, but you'd have to download it and package it into a KPZ and at that point you could provide the META.yml file. That said, maybe META.yml is just too close for comfort. Maybe KMETA.yml or KPMETA.yml? Just to make it a bit more distinctive? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24197] Custom destination for failed overdue notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #5 from Alex Buckley --- Created attachment 103428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103428=edit Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to. Test plan: 1. Set no email addresses in patron record then checkout items to the patron making the due date in the past 2. Visit patron's home library page: Administration > Libraries Set a branch email and in global system preferences observe there is no syspref named RedirectAddressForFailedOverdueNotices 3. Manually run overdue_notices.pl 4. Check the message_queue database table and observe there is a print overdue notice and a email notice with to_address of the branch email address 5. Apply patch 6. Run database update: cd installer/data/mysql sudo koha-shell ./updatedb.pl 7. Confirm there is a new system preference named: RedirectAddressForFailedOverdueNotices Give it a different email address to that in the branch email. 7. Repeat steps 1,3,4 and observe that the failed overdue notices have been sent to the email defined in RedirectAddressForFailedOverdueNotices Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24197] Custom destination for failed overdue notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 --- Comment #4 from Alex Buckley --- Thanks for tagging this 20.05 candidate Martin, I've just applying the patch and it doesn't apply on master. Attaching a corrected patch now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24197] Custom destination for failed overdue notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Alex Buckley changed: What|Removed |Added Attachment #96125|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22188] Use publication date as numbering pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871 --- Comment #12 from Bernardo Gonzalez Kriegel --- (In reply to Victor Grousset/tuxayo from comment #11) > > Take for example language 'eo', current master, wo/patch > > That's a fine example for me. > Tio estas bona ekzemplo por mi. ;) > I know :) Thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24251] Patron modification logs should be ordered most recent first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24251 Todd Goatley changed: What|Removed |Added CC||tgoat...@gmail.com --- Comment #1 from Todd Goatley --- Agreed Martin. I've also experienced an issue with exporting a files with data from the modification log. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Aleisha Amohia changed: What|Removed |Added Attachment #103323|0 |1 is obsolete|| --- Comment #12 from Aleisha Amohia --- Created attachment 103427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103427=edit Bug 14866: Make high holds work with different item types To test: 1) Apply patch, update database, restart services 2) Enable decreaseLoanHighHolds sysprefs if not already active 3) Go to circulation rules and set a value under 'Decrease loan holds (day)' that is DIFFERENT from decreaseLoanHighHoldsDuration 4) Check out an item with holds and confirm that the value from the rule is used instead of the system preference 5) Confirm tests pass before and after the patch t/db_dependent/DecreaseLoanHighHolds.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #11 from Victor Grousset/tuxayo --- > Take for example language 'eo', current master, wo/patch That's a fine example for me. Tio estas bona ekzemplo por mi. ;) Thanks for the clarifications, it work :D. I tried to reflect the explanations in the test plan. Here are the changes: == Previous test plan == 1) Update your preferred language 2) Check missing *installer*po files 3) Create new translation files: cd /misc/translation ./translate create xx-YY check *installer*po files 4) Apply patch 5) Repeat 1, verify installer files are updated see last modification time == current test plan == 1) Count the number of po files of your preferred language (replace XX) ls misc/translator/po/XX-*po | wc -l 2) You should have 8 of them 3) Update it and recount (cd misc/translator/; ./translate update XX); ls misc/translator/po/XX-*.po | wc -l 4) still 8, it means that the update process doesn't add new po files 5) Re-create the language (cd misc/translator/; rm -f po/XX-*.po; ./translate create XX); 6) recount: ls misc/translator/po/XX-*po | wc -l 7) It's 10 8) note: it means that the creation process adds new po files 9) restore to a clean state git restore misc/translator/po/ rm misc/translator/po/eo-installer-MARC21.po misc/translator/po/eo-installer.po 10) manually apply the patch (because it's too big to be directly here) 1) download 2) extact the xz file 3) apply it 4) git am 0001-Bug-24871-Add-new-installer-.po-translation-files.patch-1 11) check the modification time of the installer .po files of your preferred language ls -l misc/translator/po/XX-installer* 12) note: this also checks for their presence, which is what this patch actually does, only adding the installer po files 13) Update your preferred language (cd misc/translator/; ./translate update XX); 14) check the modification time ls -l misc/translator/po/XX-installer* 15) It should have been updated, so everything still works correcly :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871 --- Comment #10 from Victor Grousset/tuxayo --- Author: Bernardo González Kriegel Date: Sun Mar 15 18:15:32 2020 -0300 Bug 24871: Add new *-installer*.po translation files This patch simply adds new po files for each supported language. The are not created on update, so the need to add this files. To test: 1) Count the number of po files of your preferred language (replace XX) ls misc/translator/po/XX-*po | wc -l 2) You should have 8 of them 3) Update it and recount (cd misc/translator/; ./translate update XX); ls misc/translator/po/XX-*.po | wc -l 4) still 8, it means that the update process doesn't add new po files 5) Re-create the language (cd misc/translator/; rm -f po/XX-*.po; ./translate create XX); 6) recount: ls misc/translator/po/XX-*po | wc -l 7) It's 10 8) note: it means that the creation process adds new po files 9) restore to a clean state git restore misc/translator/po/ rm misc/translator/po/eo-installer-MARC21.po misc/translator/po/eo-installer.po 10) manually apply the patch (because it's too big to be directly here) 1) download 2) extact the xz file 3) apply it 4) git am 0001-Bug-24871-Add-new-installer-.po-translation-files.patch-1 11) check the modification time of the installer .po files of your preferred language ls -l misc/translator/po/XX-installer* 12) note: this also checks for their presence, which is what this patch actually does, only adding the installer po files 13) Update your preferred language (cd misc/translator/; ./translate update XX); 14) check the modification time ls -l misc/translator/po/XX-installer* 15) It should have been updated, so everything still works correcly :D Pre-filled translations for some languages (https://translate.koha-community.org/projects/marc21/) Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #100709|0 |1 is obsolete|| --- Comment #9 from Victor Grousset/tuxayo --- Created attachment 103426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103426=edit Bug 24871: xz compressed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What|Removed |Added Attachment #92961|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What|Removed |Added Attachment #92958|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What|Removed |Added Attachment #92960|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What|Removed |Added Attachment #92959|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #137 from Aleisha Amohia --- Created attachment 103425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103425=edit Bug 8367: Add holds_pickup_period circulation rule So that pickup delay can have a different value per patron category, item type or branch. To test: 1) Update database, restart services 2) Set ReservesMaxPickUpDelay syspref (if not already set) 3) Edit your circulation rules and set a value under 'Holds pickup period (day) that is DIFFERENT from ReservesMaxPickUpDelay 4) Place a hold on a biblio 5) Check in an item from that biblio and confirm the hold as waiting 6) Confirm the expiration date is calculated using the 'Holds pickup period' value instead of the ReservesMaxPickUpDelay syspref 7) Revert the waiting status and delete the hold 8) Re-place the hold on the biblio 9) Create a holiday with a date that will overlap with the 'Holds pickup period' 10) Check in an item from that biblio and confirm the hold as waiting 11) Confirm the expiration date is calculated using the 'Holds pickup period' value AND considers the special holiday 12) Confirm tests pass t/db_dependent/Holds/WaitingReserves.t I've also added this to the TalkingTech_itiva_outbound.pl cronjob, I'm not sure how to test this. Please test properly if you can, otherwise maybe put some warns in and confirm the correct expiration date is calculated. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What|Removed |Added Text to go in the||This patch adds a new release notes||circulation rule - ||holds_pickup_period - which ||will override the value set ||in the ||ReservesMaxPickUpDelay ||system preference for ||specific item types, or ||patron categories, or ||branches. CC||alei...@catalyst.net.nz Change sponsored?|--- |Sponsored Assignee|hayleymap...@catalyst.net.n |alei...@catalyst.net.nz |z | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25234] Update OPAC search results pagination with aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- I was testing this and caught one small typo that existed before this change: https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25233] Staff XSLT material type label "Book" should be "Text"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 Lucas Gass changed: What|Removed |Added Summary|OPAC XSLT material type |Staff XSLT material type |label "Text" should be |label "Book" should be |"Book" |"Text" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25233] Staff XSLT material type label "Book" should be "Text"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25233] OPAC XSLT material type label "Text" should be "Book"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 Lucas Gass changed: What|Removed |Added Attachment #103420|0 |1 is obsolete|| --- Comment #7 from Lucas Gass --- Created attachment 103424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103424=edit Make the staff client XSLT stylesheets consistent with the ones for the OPAC This patch makes the staff client XSLT stylesheets consistent with the ones for the OPAC, it also makes consitent the use of 'Text' when the leader6 = 't' TO TEST: 1. Have a record with leader06 = 'a' and leader07 = 'c' 'd' or 'm'. 2. Check the staff client results and details page. See that the material type label says "Book" 3. Check the OPAC client results and details page. See that the materila type label says "Text" 4. Apply patch. 5. See that both staff client and OPAC results/details all now say "Text" 6. Set the leader6 = 't' and make sure that is says 'Text' on both the staff client and OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25234] Update OPAC search results pagination with aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 --- Comment #1 from Owen Leonard --- Created attachment 103423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103423=edit Bug 25234: Update OPAC search results pagination with aria labels This patch updates the include file which generates OPAC search results pagination so that it has better semantic markup and correct aria labels. To test, apply the patch and do a search in the OPAC which will return multiple pages of search results. View the source to confirm the markup changes: - instead of surrounding the list of links, with a corresponding aria label - Navigation links should have labels indicating which page in the results they point to. - The current link should have "aria-disabled," and "aria-current" set. - Numbered links should have aria labels that indicate their number. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25234] Update OPAC search results pagination with aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25232] Add ability to skip trapping items with a given notforloan value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25232 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Andrew Fuerste-Henry --- Patch wouldn't apply for me. Got these errors: error: sha1 information is lacking or useless (C4/Reserves.pm). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10562] Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562 Katrin Fischer changed: What|Removed |Added Blocks||25233 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 [Bug 25233] OPAC XSLT material type label "Text" should be "Book" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23003] Accessibility improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Owen Leonard changed: What|Removed |Added Depends on||25234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 [Bug 25234] Update OPAC search results pagination with aria labels -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25233] OPAC XSLT material type label "Text" should be "Book"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 --- Comment #6 from Katrin Fischer --- Yes, sorry, just typed up the other comment - I had worked that out a while ago when we got the complaints and I was trying to see if our records were correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25234] New: Update OPAC search results pagination with aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25234 Bug ID: 25234 Summary: Update OPAC search results pagination with aria labels Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Blocks: 23003 For better accessibility I would like to add aria labels to the include file which generates OPAC search results pagination. See articles: https://a11y-style-guide.com/style-guide/section-navigation.html#kssref-navigation-pagination https://www.a11ymatters.com/pattern/pagination/ Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25233] OPAC XSLT material type label "Text" should be "Book"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 Katrin Fischer changed: What|Removed |Added Depends on||10562 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562 [Bug 10562] Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25233] OPAC XSLT material type label "Text" should be "Book"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 --- Comment #5 from Katrin Fischer --- > leader06 = 'a' and leader07 = 'c' 'd' or 'm' a - Language material Used for non-manuscript language material. Manuscript language material uses code t.Includes microforms and electronic resources that are basically textual in nature, whether they are reproductions from print or originally produced. c - Collection d - Subunit m - Monograph/Item The interesting part is, that a is also used for microforms and electronic resources, so the book and "book" description is not helpful in these cases. I think we should change staff to match. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25224] Add "Large Print" from 008 position 23 to default XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25224 Lucas Gass changed: What|Removed |Added Attachment #103399|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 103422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103422=edit Bug 25224: Show large print format in search results XSLT To test: 1: find a bib with 008 type Book (Leader position 6 = 'a' and leader position 7 = 'm' -- use bib number 1 in master data) 2: set 008 position 23 to 'd' for large print 3: check your book record in opac and intranet search results, note that your change is not reflected in the "format" note in line with material type 4: find a bib with 008 type Continuing Resource (Leader position 6 = 'a' and leader position 7 = 's' -- use bib number 44 in master data) 5: set 008 position 23 to 'd' for large print 6: check your continuing resource record in opac and intranet search results, note that your change is not reflected in the "format" note in line with material type 7: apply patch, restart_all 8: reload search results from steps 3 and 6, confirm they now say "format: large print" Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25224] Add "Large Print" from 008 position 23 to default XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25224 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25233] OPAC XSLT material type label "Text" should be "Book"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 --- Comment #4 from Lucas Gass --- Cait, So to be consistent with between OPAC/staff should be change the wording in the staff client XSLT to 'Text'? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25231] Don't alert when replacing record via Z39.50
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25231 David Nind changed: What|Removed |Added Attachment #103402|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 103421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103421=edit Bug 25231: Rename button instead of alert/confirm when replacing record This test plan applies to the basic editor only To test: 1 - Edit an existing record 2 - Click 'Z3950 Search' 3 - Note the confirmation box 4 - Add a new record 5 - Click 'Z3950 Search' 6 - Note no popup 7 - Apply patch 8 - Edit existing record 9 - Note button now says 'Replace record via Z3950 search' 10 - Add a new blank record 11 - Note the button says 'Z3950 search' 12 - Confirm editing/saving/replacing works as in the past Signed-off-by: Phil Ringnalda Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25233] OPAC XSLT material type label "Text" should be "Book"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 --- Comment #3 from Katrin Fischer --- Not only books is what I mean. I remember because we had librraies complaining about the book icon in some combinations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25233] OPAC XSLT material type label "Text" should be "Book"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 --- Comment #2 from Katrin Fischer --- It was changed to Text on purpose a while ago IIRC, because the description is not book on the MARC standard, it can be anything textual, not only print. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25233] OPAC XSLT material type label "Text" should be "Book"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 --- Comment #1 from Lucas Gass --- Created attachment 103420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103420=edit Bug 25233: Make OPAC XSLT stylesheets consistent with the ones for the staff client This patch makes the OPAC XSLT stylesheets consistent with the ones for the staff client TO TEST: 1. Have a record with leader06 = 'a' and leader07 = 'c' 'd' or 'm'. 2. Check the OPAC results and details page. See that the materila type label says "Text" 3. Check the staff client results and details page. See that the materila type label says "Book" 4. Apply patch. 5. See that both staff client and OPAC results/details all now say "Book" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25233] OPAC XSLT material type label "Text" should be "Book"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25233] OPAC XSLT material type label "Text" should be "Book"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 Lucas Gass changed: What|Removed |Added Summary|MARC21slim2OPACDetail.xsl |OPAC XSLT material type |material type label "Text" |label "Text" should be |should be "Book"|"Book" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25220] maxoutstanding syspref should be disabled by a null value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |and...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24957] OpenLibrarySearch shouldnt display if nothing is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24957 Heather changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #5 from Heather --- I used a sandbox and was able to re-create the problem with the keyword search: first Some of the results had the problem display, "Open Library: " and some results displayed "Open Library: Not found," and there was also the correct display, "Open Library Read Now." I then applied the patch, and the problematic "Open Library: " disappeared--there were still some libraries that said, "Open Library: Not found" and a record with the correct display, "Open Library Read Now." So I went ahead and signed off, because the problematic display disappeared. But this is my first real sign off, so please comment to let me know if I missed something, or if the "Open Library: Not found" should have also disappeared. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24957] OpenLibrarySearch shouldnt display if nothing is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24957 ByWater Sandboxes changed: What|Removed |Added Attachment #103417|0 |1 is obsolete|| --- Comment #4 from ByWater Sandboxes --- Created attachment 103419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103419=edit Bug 24957: OpenLibrarySearch shouldnt display if nothing is returned TO TEST: 1. Turn on OpenLibrarySearch 2. Do an OPAC search that returns results that have results with Open Library results and some that do not. 3. Notice results that return nothing simpliy say "Open Library:" with nothing afterwards. 4. Some results return a png from OpenLibrary or "Not found" 5. Apply patch and look at records again. 6. The results that return nothing for OpenLibrary API should now to hidden. Signed-off-by: Heather Hernandez -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25233] New: MARC21slim2OPACDetail.xsl material type label "Text" should be "Book"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 Bug ID: 25233 Summary: MARC21slim2OPACDetail.xsl material type label "Text" should be "Book" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org In the OPAC Details if you set the leader06 = 'a' and leader07 = 'c' 'd' or 'm' the display says 'Text'. At the same time the Staff Details page will show 'Book'. This should be consistent on both and I believe Book is correct. To Recreate: 1. Have a record with leader06 = 'a' and leader07 = 'c' 'd' or 'm'. 2. Check the OPAC details and see that is says 'Text'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5161] patron attributes clearing if duplicate warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5161 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5161] patron attributes clearing if duplicate warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5161 David Nind changed: What|Removed |Added Attachment #103372|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 103418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103418=edit Bug 5161: Keep patron's attributes on warning/duplicate When a patron is added or modified and a warning appears (duplicate, inconsistent data, etc.) the form lost the patron's attributes. Test plan: Create some attribute types for patrons Create a new patron, use an userid that already exists and fill the attributes => You get a warning and the attributes are kept Modify the userid and save again Edit the same patron Modify the attributes, as well as the userid (to get the duplicate warning) => You get a warning and the attributes are kept with the modified values Modify the userid and save again => The new values are saved Edit the attributes from the detail page (so not with the full edit form) Modify them and save => The new values are saved Signed-off-by: David Nind -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24957] OpenLibrarySearch shouldnt display if nothing is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24957 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24957] OpenLibrarySearch shouldnt display if nothing is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24957 --- Comment #3 from Lucas Gass --- Created attachment 103417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103417=edit Bug 24957: OpenLibrarySearch shouldnt display if nothing is returned TO TEST: 1. Turn on OpenLibrarySearch 2. Do an OPAC search that returns results that have results with Open Library results and some that do not. 3. Notice results that return nothing simpliy say "Open Library:" with nothing afterwards. 4. Some results return a png from OpenLibrary or "Not found" 5. Apply patch and look at records again. 6. The results that return nothing for OpenLibrary API should now to hidden. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 --- Comment #61 from Victor Grousset/tuxayo --- Signed off, I did nothing more than what's the test plan in the patch so I hope I didn't missed something when I rewrote it. The only thing that I'm not confident about is «verify that the database you use usually was untouched» Before there was in the test plan: > (you can edit the test file and comment the lines related to a transaction > (txn_begin, txn_rollback)) There are none in selenium/00-installation.t Is counting the users in the main DB before and after the install tests enough? Or checking that the user "SuperL" created during the test isn't in the main DB? == Diff of the test plan == === Before === Test plan: 1. mysql> GRANT ALL PRIVILEGES ON koha_test.* TO @localhost 2. cd /path/to/koha 3. prove t/db_dependent/.t 4. Verify that it created the database koha_test and that the one you use usually was untouched (you can edit the test file and comment the lines related to a transaction (txn_begin, txn_rollback)) === After === Test plan: 1. Apply bug 19185 which will also apply these patches 2. In the DBMS run `select count(*) from koha_kohadev.borrowers;` (adapt if your usual koha DB isn't koha_kohadev) 3. Run the test plan of bug 19185 and during execution of the installation test, pay attention to the following: 4. List the databases in the DBMS (show databases;) to ensure that koha_test is created 5. After the test has run, the koha_test database should not be here anymore. 6. In the DBMS run `select count(*) from koha_kohadev.borrowers;` 7. That was to verify that the database you use usually was untouched. The counts should be the same. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24957] OpenLibrarySearch shouldnt display if nothing is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24957 --- Comment #2 from Lucas Gass --- Upon further review I don't think the API has changed. According to https://openlibrary.org/dev/docs/api/read, if items is empty "Thw list may be empty if nothing's available." So when no items are available we should not display the ol_readapi_book class in the search results or details. If we do all that displays is 'Open Library:' with nothing else. That seems confusing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 --- Comment #33 from Victor Grousset/tuxayo --- Signed off, I did nothing more than what's the test plan in the patch so I hope I didn't missed something when I rewrote it. == Diff of the test plan == === Before === The test plan was in comment 23 % prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t Config entry 'database_test' does not exist at /home/vagrant/kohaclone/t/lib/Bootstrap.pm line 18 # Edit $KOHA_CONF, add a database_test entry identical to database (then restart_all): % prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t Entries 'database_test' and 'database' have the same value in your config at /home/vagrant/kohaclone/t/lib/Bootstrap.pm line 20. # Edit $KOHA_CONF, edit database_test with koha_kohadev_test (then restart_all) % prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t Access denied for user 'koha_kohadev'@'localhost' to database 'koha_kohadev_test' # Login as the admin mysql user MariaDB [(none)]> GRANT ALL PRIVILEGES ON `koha_kohadev_test`.* TO 'koha_kohadev'@'localhost'; % prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t t/db_dependent/selenium/00-installation.t .. ok All tests successful. Files=1, Tests=2, 25 wallclock secs ( 0.02 usr 0.01 sys + 1.34 cusr 0.24 csys = 1.61 CPU) Result: PASS === After === 1. Apply the patches (including bug 19821) 2. restart_all 3. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 4. result: Config entry 'database_test' does not exist at /home/vagrant/kohaclone/t/lib/Bootstrap.pm line 18 5. Edit $KOHA_CONF, add a database_test entry identical to database You should have: koha_kohadev koha_kohadev 6. restart_all 7. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 8. result: Entries 'database_test' and 'database' have the same value in your config at /home/vagrant/kohaclone/t/lib/Bootstrap.pm line 20. 9. Edit $KOHA_CONF, edit database_test with koha_test as DB name 10. restart_all 11. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 12. result: Access denied for user 'koha_kohadev'@'localhost' to database 'koha_test' 13. Connect to the DBMS 14. Example for koha_testing_docker docker exec -it koha_db_1 bash mysql -u root --password=password 15. GRANT ALL PRIVILEGES ON `koha_test`.* TO 'koha_kohadev'; 16. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 17. result: All tests successful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24957] OpenLibrarySearch shouldnt display if nothing is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24957 Lucas Gass changed: What|Removed |Added Summary|OpenLibrarySearch doesnt|OpenLibrarySearch shouldnt |return result correctly on |display if nothing is |OPAC|returned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #103408|0 |1 is obsolete|| --- Comment #32 from Victor Grousset/tuxayo --- Created attachment 103416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103416=edit Bug 19185: Add selenium tests for installation and onboarding process == Test plan == 1. Apply the patches (including bug 19821) 2. restart_all 3. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 4. result: Config entry 'database_test' does not exist at /home/vagrant/kohaclone/t/lib/Bootstrap.pm line 18 5. Edit $KOHA_CONF, add a database_test entry identical to database You should have: koha_kohadev koha_kohadev 6. restart_all 7. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 8. result: Entries 'database_test' and 'database' have the same value in your config at /home/vagrant/kohaclone/t/lib/Bootstrap.pm line 20. 9. Edit $KOHA_CONF, edit database_test with koha_test as DB name 10. restart_all 11. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 12. result: Access denied for user 'koha_kohadev'@'localhost' to database 'koha_test' 13. Connect to the DBMS 14. Example for koha_testing_docker docker exec -it koha_db_1 bash mysql -u root --password=password 15. GRANT ALL PRIVILEGES ON `koha_test`.* TO 'koha_kohadev'; 16. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 17. result: All tests successful. Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #99439|0 |1 is obsolete|| --- Comment #58 from Victor Grousset/tuxayo --- Created attachment 103413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103413=edit Bug 19821: Do not modify KOHA_CONF, use new database_test entry instead I have tried to use the original idea of this patch for bug 19185, but it cannot work as it. ENV is not shared between processus and KOHA_CONF will not be read by webserver (used for selenium tests). Moreover on bug 19185 we are testing the installation process and we do not want the database to be populated with sample data, we just need a new and clean DB. Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #99440|0 |1 is obsolete|| --- Comment #59 from Victor Grousset/tuxayo --- Created attachment 103414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103414=edit Bug 19821: Use database_test entry if exists If the database_test entry exists in the config file we are going to use it. This will be a trick for developers and CI Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #99441|0 |1 is obsolete|| --- Comment #60 from Victor Grousset/tuxayo --- Created attachment 103415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103415=edit Bug 19821: Require database_test != database To prevent developpers to drop their database. Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #99438|0 |1 is obsolete|| --- Comment #57 from Victor Grousset/tuxayo --- Created attachment 103412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103412=edit Bug 19821: Ignore .proverc and .proverc.dist in Makefile.t Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #99437|0 |1 is obsolete|| --- Comment #56 from Victor Grousset/tuxayo --- Created attachment 103411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103411=edit Bug 19821: Install sample data, ES mappings and Version syspref Also move .proverc to .proverc.dist, so it cannot be used by accident. Different ways to use it: 1/ prove --rc .proverc.dist Use defaults 2/ cp .proverc.dist .proverc && prove Allows to configure db name, marcflavour, and prove options Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #99436|0 |1 is obsolete|| --- Comment #55 from Victor Grousset/tuxayo --- Created attachment 103410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103410=edit Bug 19821: Close filehandle after writing Signed-off-by: Jon Knight Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #81914|0 |1 is obsolete|| --- Comment #30 from Victor Grousset/tuxayo --- Created attachment 103407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103407=edit Bug 19185: Ease elements selection - The marcflavour select needs an id to be selected easily - "Continue to the next step" should be a button (like others) Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #81913|0 |1 is obsolete|| --- Comment #29 from Victor Grousset/tuxayo --- Created attachment 103406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103406=edit Bug 19185: Use submit button if only one exists on the page During the installation process we do not have fieldset.action, in order to not complicate changes we are just going to use the submit button if only one exists. Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #81915|0 |1 is obsolete|| --- Comment #31 from Victor Grousset/tuxayo --- Created attachment 103408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103408=edit Bug 19185: Add selenium tests for installation and onboarding process Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo == Test plan == 1. Apply the patches (including bug 19821) 2. restart_all 3. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 4. result: Config entry 'database_test' does not exist at /home/vagrant/kohaclone/t/lib/Bootstrap.pm line 18 5. Edit $KOHA_CONF, add a database_test entry identical to database You should have: koha_kohadev koha_kohadev 6. restart_all 7. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 8. result: Entries 'database_test' and 'database' have the same value in your config at /home/vagrant/kohaclone/t/lib/Bootstrap.pm line 20. 9. Edit $KOHA_CONF, edit database_test with koha_test as DB name 10. restart_all 11. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 12. result: Access denied for user 'koha_kohadev'@'localhost' to database 'koha_test' 13. Connect to the DBMS 14. Example for koha_testing_docker docker exec -it koha_db_1 bash mysql -u root --password=password 15. GRANT ALL PRIVILEGES ON `koha_test`.* TO 'koha_kohadev'; 16. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 17. result: All tests successful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #99435|0 |1 is obsolete|| --- Comment #54 from Victor Grousset/tuxayo --- Created attachment 103409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103409=edit Bug 19821: Run tests on a separate database Running the tests on the same database as the one used for dev has some drawbacks: - Everybody has different data, so we cannot make any assumptions about data in tests and it can make tests fail for non-obvious reasons. - Tests have to clean up every change to the database using SQL transactions, so we cannot write testable code that use transactions (AFAIK) - Transactions in tests happen to be committed sometimes, resulting in garbage data added to the dev database This patch provides a .proverc file that will load t/lib/Bootstrap.pm before the tests are run. t/lib/Bootstrap.pm is responsible for recreating a fresh database and telling the test scripts to use it. To use it, just run prove normally from the root directory of Koha. By default, the database is 'koha_test' and it's created using MARC21 SQL files, it can be changed by running: prove --norc \ --Mt::lib::Bootstrap=database,koha_test,marcflavour,UNIMARC Test plan: 1. Apply bug 19185 which will also apply these patches 2. In the DBMS run `select count(*) from koha_kohadev.borrowers;` (adapt if your usual koha DB isn't koha_kohadev) 3. Run the test plan of bug 19185 and during execution of the installation test, pay attention to the following: 4. List the databases in the DBMS (show databases;) to ensure that koha_test is created 5. After the test has run, the koha_test database should not be here anymore. 6. In the DBMS run `select count(*) from koha_kohadev.borrowers;` 7. That was to verify that the database you use usually was untouched. The counts should be the same. Signed-off-by: Jon Knight Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25110] Allow patrons to add star ratings to titles on their summary/checkout page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25110 David Nind changed: What|Removed |Added Attachment #103365|0 |1 is obsolete|| --- Comment #15 from David Nind --- Created attachment 103405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103405=edit Bug 25110: Allow patrons to add star ratings to titles on their summary/checkout page This patch adds the ability for logged-in patrons to add star ratings to titles in their list of current checkouts and on the reading history page. The reading history page previously only showed existing ratings. Now it will allow the entry of ratings as well. The JS and markup for the feature are in separate include files to facilitate re-use. It includes markup for non-js display of ratings and js-driven ratings controls. To test, apply the patch and set the OpacStarRatings to all, "results, details, and user" pages. - Log in to the OPAC as a user with checkouts. - On the "your summary" page, test the features of setting star ratings: - Any title with existing ratings should show the rating and the average rating number. - Set a rating. Confirm that it shows a message with your rating. - Click the "cancel rating" link, and confirm that your rating is removed. - Set a rating and reload the page. Confirm that the rating was saved. - Test the "cancel rating" link on the title you set before you reloaded the page. The rating should be cancelled. - Test the same functionality on the "your reading history" page. - Test these pages with the OpacStarRatings preference set to "only details" or "no." The pages should function correctly. Edit: Add JS file which was missing from the commit! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
