[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #75 from Victor Grousset/tuxayo --- Thanks Heather for testing :) Thanks Katrin for spotting the "In...", I missed it also! And the for clarifications on the other points. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #37 from David Nind --- Hi Martin. The only wrinkles I found this time were: 1. Step 12 - checkout an item that is waiting for pickup by another patron: was able to checkout the item waiting, even though it wasn't for me. ==> Message says: "Message code 'RESERVE_WAITING' with data '1' Message code 'reswaitingdate' with data '2023-01-13'" . Has Confirm and Close buttons . Confirm button: - checks out item to patron who didn't have the hold waiting (koha) - item shows (in the staff interface) as checked out to koha, and also waiting for pickup (for Mary) 2. Barcodes with a space before it - items aren't found: I recall testing another bug for this, but can't find it. But anyway, this is not specifically related to this bug. I didn't try and use the public API to query for items that are hidden/not visible in the OPAC (not entirely sure how to set this up properly). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 --- Comment #36 from David Nind --- Updated test plan I used (using KTD). Setup 1. Apply patches, updatedatabase, flush_memcached, restart_all 2. Enable OpacTrustedCheckout system preference Testing the API 1. Get details of items for a record: - Visit http://127.0.0.1:8080/api/v1/public/items?external_id=305097 ==> should return details for the item Test the self-checkout feature: 1. Go to the OPAC home page. 2. Login as a patron (in this case I used koha), and note that in the OPAC header there is now a Self checkout option after Cart and Lists. 3. Click on Self checkout ==> window pops up asking you to enter a barcode. 4. Enter a barcode for an item that is available, for example: 306094 ==> Message should say: "Item '306094' was checked out", and an option to enter another barcode, as well as Submit and Close buttons. 5. Click close and check your account > your summary: item checked out should be listed. 6. Repeat step 4 with the same barcode, this time the result should be: ==> Message says: "Item will be renewed" . Click Confirm ==> Message says "Item '306094' was checked out". There is also an input box to enter another item barcode, and there may also be a list of barcodes checked out and the due date. 7. Checkout an item to another patron using the staff interface. . Example: checked out 311418 to Mary Burton 9. As the patron in step 2, use the self-checkout to try and checkout this item: ==> Message says: "This item appears to be checked out to another patron, please return it to the desk" . Has Submit and Close buttons . Click the Close button 10. Use the self-checkout to try and checkout an item on hold: . Place a hold for an item for another patron using the staff interface. Example: Placed a record level hold for Programming the Perl DBI (biblionumber = 13) ==> Message says: "This item appears to be reserved for another patron, please return it to the desk" . Has Submit and Close buttons . Click the Close button 11. Use the self checkout to try and checkout an item on hold that is waiting for pickup for a patron (I used koha): . Place a record-level hold for an item using the staff interface (used Perl Better Practices, biblionumber = 19) . Check in an item for the record and confirm the hold (used 308036), should show status as awaiting pickup . Use the self checkout to try and checkout this item to the patron the hold was placed for (308036 and patron koha in this instance) ==> Item should be successfully checked out with message "Item '308036' was checked out", with options to enter another barcode, Submit and Close buttons ==> Click close and check your account > your summary: item checked out should be listed 12. Repeat step 11, but use the self checkout to try and checkout an item that is on hold and waiting for pickup by another patron (I used Mary Burton to place the hold, and koha to check it out): ==> Message says: "Message code 'RESERVE_WAITING' with data '1' Message code 'reswaitingdate' with data '2023-01-13'" . Has Confirm and Close buttons . Confirm button: - checks out item to patron who didn't have the hold waiting (koha) - item shows (in the staff interface) as checked out to koha, and also waiting for pickup (for Mary) 13. Try and checkout and item not for loan: . Update an item for a record so that is not for loan . Try and checkout using the self-checkout ==> message says: "This item is not normally for loan, please select another or ask at the desk" . Has Submit and Close buttons ==> Item does not check out, as expected. 14. Try and checkout an item recorded as Withdrawn: . Update an item for a record so that it is withdrawn . Try and checkout using the self-checkout ==> message says: "This item is marked withdrawn, please select another or ask at the desk" 15. Add a manual charge for the koha patron then try and check out an item. . Add a manual invoice for the koha patron of $20. ==> message says: "Your account is currently in debt by '20'" ==> Does not checkout item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32636] New: More info with batch patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32636 Bug ID: 32636 Summary: More info with batch patron deletion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org When batch deleting patrons, it tells you how many patrons will be deleted. It would be great if it also told you how many patrons fit your parameters, but are being skipped because they have active loans or fees. Better yet, if that piece of information could link to a report showing which patrons are skipped and why, that would even be helpful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32628] Add 'page-section' to various serials pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32628 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32628] Add 'page-section' to various serials pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32628 ByWater Sandboxes changed: What|Removed |Added Attachment #145276|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 145326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145326=edit Bug 32628: Add 'page-section' to various serials pages This patch adds a "page-section" container div around the main section of serials pages which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test you must have at least one subscription in your system. Apply the patch and view the following pages to confirm that the main content is contained in a white box: - Subscription batch edit: - Go to Serials -> Search subscriptions -> Results - Check the box next to one or more search results and click "Edit selected serials." - Subscription frequencies: - Serials -> Manage frequencies - View subscription alerts: - Log in to the OPAC and search for a subscription. - On the subscription detail page click the "Subscribe to to email notification on new issues." - In the staff interface, locate that subscription and view its details. - Click the "subscribers" link under "Patron notification." Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 solene.nga...@inlibro.com changed: What|Removed |Added CC||solene.nga...@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #24 from solene.nga...@inlibro.com --- Bug 12133 - Guarantor requirements when registering a patron 134013 - Bug 12133: Add requirements for guarantor and guarantee 134014 - Bug 12133: Fix issues with modifying child patron and adding guarantors 134015 - Bug 12133: Enforce guarantor restrictions on Koha::Patron->store() Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12133: Add requirements for guarantor and guarantee Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref M koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt M members/memberentry.pl Falling back to patching base and 3-way merge... Auto-merging members/memberentry.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref error: Failed to merge in the changes. Patch failed at 0001 Bug 12133: Add requirements for guarantor and guarantee hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12133-Add-requirements-for-guarantor-and-guara-ofLCAA.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32631] Error when previewing record during batch record modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32631 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32631] Error when previewing record during batch record modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32631 ByWater Sandboxes changed: What|Removed |Added Attachment #145278|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 145325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145325=edit Bug 32631: Error when previewing record during batch record modification This patch corrects an error in the script which outputs MARC data for preview during batch record modification. To test, apply the patch and restart services. You will need at least one MARC modification template in your system. - Go to Cataloging -> Batch record modification - Submit a batch of bibliographic records - In the table of records that follows, click any "Show MARC" button. A modal window should appear with a preview of the modified record. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32633] Add 'page-section' to cataloging and authority pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- Owen, Should the page section on cataloging search include the pagination links? I know it is not a dataTable but I am comparing it to item search. I am still a bit confused on what the standard should be. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32632] Add 'page-section' to some tools pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32632 Lucas Gass changed: What|Removed |Added Attachment #145298|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 145324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145324=edit Bug 32632: Add 'page-section' to some tools pages This patch adds a "page-section" container div around the main section of some tools pages which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. Apply the patch and view the following pages to confirm that the main content is contained in a white box: - From the cataloging home page: Item modifications by age. If necessary, add at least one rule to see the table listing all rules. - Go to Tools -> Batch extend due dates, and submit values which will return one or more results, keeping the "Preview results" checkbox checked. Confirm that the page previewing the results looks correct. - Go to Tools -> Quote editor. If necessary, add at least one quote in order to see the table of quotes. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32632] Add 'page-section' to some tools pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32632 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 David Nind changed: What|Removed |Added Attachment #145275|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 145323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145323=edit Bug 30869: Stock rotation rotas cannot be deleted 'At the moment, it isn't possible to delete any rotas that have 0 items linked to it. The only way to do it is in MySQL - it would be good if this was possible from the staff client.' This patch implements this, and also implements the possibility of deleting a rota with items linked to it, providing a warning that the item(s) currently in rotation will remain at its/their current stage library. Test plan: 1) Enable StockRotation system preference 2) Cataloging > Stock rotation > New rota 3) Enter Name, save 4) Verify 'Delete' button shows on the right 5) Click 'Delete' -> Confirm 'Yes' 6) Repeat steps 1-3 and click 'Manage'->'Stages' 7) Add a new stage, enter Library and Duration, click 'Save' 8) Return to rotas, click 'Manage'->'Items' 9) Add item, enter barcode, click 'Save' (optional: add more than 1 item) 10) Optional: Click 'Move to next stage' and verify that item is now in different branch 11) Click 'return to rotas' and press 'Delete' 12) Verify the warning now shows, because items are attached, with the attached items count 13) Click 'Delete' -> Deletion is successful 14) If you did step 10, verify the item is still in the branch that it was at the time the rota was deleted Sponsored-by: PTFS-Europe Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869 --- Comment #9 from David Nind --- (In reply to Pedro Amorim from comment #8) > Can you please check now that the patch applies and/or if the test plan goes > accordingly. Thanks Pedro! The patch now applies, sign off shortly. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Owen Leonard changed: What|Removed |Added Depends on||32600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 [Bug 32600] Housebound module needs page-section treatment -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32600] Housebound module needs page-section treatment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32600 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Blocks||31757 Status|NEW |ASSIGNED Version|22.05 |master Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32634] Add 'page-section' to various pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 --- Comment #2 from Owen Leonard --- Created attachment 145322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145322=edit Bug 32634: Add 'page-section' to various pages This patch adds a "page-section" container div around the main section of various pages which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. Apply the patch and view the following pages to confirm that the main content is contained in a white box: - Locate a patron who has one or more account transactions. - Go to the Accounting tab -> Transactions. Click "Details" on one of the lines. - The "Details of debit" and "History" sections should be wrapped in .page-section. - Go to Tools -> Patron card creator -> Manage -> Batches - If there is not a list of batches you will need to create at least one to see the page-section container. - Go to Reports -> View dictionary. - If necessary, add a definition. - The "Current terms" table should be wrapped in .page-section. - Go to Lists and view the contents of a list with one or more titles on it. The table of titles should be wrapped in .page-section. - Go to Circulation -> Upload offline circulation file (.koc) - Upload a .koc file and click the "Add to offline circulation queue." - On the confirmation page the "Your file was uploaded" message should be wrapped in .page-section. - Click "View pending offline circulation actions" - The list of pending actions should be wrapped in .page-section -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32634] Add 'page-section' to various pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32634] Add 'page-section' to various pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 --- Comment #1 from Owen Leonard --- Also including: - offline_circ/enqueue_koc.tt - offline_circ/list.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #81 from Kyle M Hall --- Created attachment 145321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145321=edit Bug 14784: (follow-up) Unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Kyle M Hall changed: What|Removed |Added Attachment #137727|0 |1 is obsolete|| Attachment #137728|0 |1 is obsolete|| --- Comment #80 from Kyle M Hall --- Created attachment 145320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145320=edit Bug 14784: Fix checkin message for restricted patrons Test plan: Before 1) Select a user with active indefinite or definite restrictions (manual restriction works) 2) Make sure finedays=0 for the user category. See [1] 3) Checkout and return an item (not overdue) A previous restriction reminder will appear 4) Checkout and return an overdue item (change the date at checkout) No previous restriction reminder will appear After applying patch: Same steps, but a reminder should appear for step 4) [1] The "finedays" setting is called "Suspension in days" in the web interface, if you're searching for it like I did... Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 --- Comment #2 from Nick Clemens --- Created attachment 145319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145319=edit Bug 32250: Only reindex records when commiting This patch adds an array to catch updated bibs, and defers indexing until a batch of changes is committed To test: 1 - Set LinkerModule system preference to either first or last match Alternate this between runs of the linker to ensure changes are made 2 - Set SearchEngine to Elasticsearch and reindex (to ensure index is built) 3 - perl misc/link_bibs_to_authorities.pl -v 4 - Check Admin->Jobs and see that many ES index jobs are queued 5 - Apply patch 6 - perl misc/link_bibs_to_authorities.pl -v 7 - Check Admin->Jobs and see that 1 index per commit from is enqueued -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #79 from Kyle M Hall --- (In reply to Katrin Fischer from comment #78) > @Kyle: could you maybe weigh in here? IIRC you were the one to write a part > of this code at least? Yes, considering Koha::Paron::is_debarred checks that calculated field, I think it's passible, but it would be best practice to search for patron restrictions that have no time limit. We don't have classes for borrower_debarments at the moment, so I think that would be a bit onerous to require. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #73 from Kyle M Hall --- Created attachment 145318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145318=edit Bug 30358 (follow-up) Simplify regex The regex does the following: 1. Replace newlines and carriage returns with a space 2. Replace leading and trailing whitespace with nothing (strip) Signed-off-by: Hammat Wele Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #72 from Kyle M Hall --- Created attachment 145317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145317=edit Bug 30358 (follow-up): Do not strip whitespace from control fields Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #71 from Kyle M Hall --- Created attachment 145316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145316=edit Bug 30358: (follow-up) Fixing ModBiblioMarc.t tests Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #70 from Kyle M Hall --- Created attachment 145315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145315=edit Bug 30358: (follow-up) stripWhitespaceChars subroutine and tests To test: Confirm test plan above still works as expected and tests pass in t/Koha_MetadataRecord.t Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #69 from Kyle M Hall --- Created attachment 145314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145314=edit Bug 30358: (follow-up) Put multiple subfields fix on auth side Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #68 from Kyle M Hall --- Created attachment 145313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145313=edit Bug 30358: (follow-up) Consider field has multiple subfields of same key To test: 1) Click the clone subfield button to make multiple subfields with the same key, i.e. 500$a$a$a 2) Save the record and confirm that the fields contain the correct data after whitespaces are stripped. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #67 from Kyle M Hall --- Created attachment 145312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145312=edit Bug 30358: (follow-up) Clarify syspref wording about fields affected Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #66 from Kyle M Hall --- Created attachment 145311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145311=edit Bug 30358: (follow-up) Fixing tests and including for inner newlines Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #65 from Kyle M Hall --- Created attachment 145310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145310=edit Bug 30358: (follow-up) Inner newlines should be replaced with a space Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 --- Comment #64 from Kyle M Hall --- Created attachment 145309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145309=edit Bug 30358: (follow-up) Also strip inner newlines This patch amends the StripWhitespaceChars system preference to also strip inner newlines (line breaks and carriage returns) when enabled. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Kyle M Hall changed: What|Removed |Added Attachment #144120|0 |1 is obsolete|| Attachment #144121|0 |1 is obsolete|| Attachment #144122|0 |1 is obsolete|| Attachment #144123|0 |1 is obsolete|| Attachment #144124|0 |1 is obsolete|| Attachment #144125|0 |1 is obsolete|| Attachment #144126|0 |1 is obsolete|| Attachment #144127|0 |1 is obsolete|| Attachment #144128|0 |1 is obsolete|| Attachment #144129|0 |1 is obsolete|| Attachment #144171|0 |1 is obsolete|| --- Comment #63 from Kyle M Hall --- Created attachment 145308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145308=edit Bug 30358: Strip leading/trailing whitespace characters from input fields when cataloguing This enhancement adds a system preference StripWhitespaceChars which, when enabled, will strip leading and trailing whitespace characters from all fields when cataloguing both bibliographic records and authority records. Whitespace characters that will be stripped are: - spaces - newlines - carriage returns - tabs To test: 1. Apply patch and install database updates 2. Go to Administration, system preferences, find the new StripWhitespaceChars preference. It should be "Don't strip" by default. Change it to "Strip". 3. Search for a biblio record and edit it. Put some leading or trailing whitespace characters in input fields and textarea fields and save. 4. Confirm these characters are removed when you save the record. 5. Repeat steps 3 and 4 for authority records. 6. Confirm tests pass t/db_dependent/Biblio/ModBiblioMarc.t Sponsored-by: Educational Services Australia SCIS Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 --- Comment #21 from David Nind --- Created attachment 145307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145307=edit Bug 32418 - Can't call method 'unblessed' on an undefined value at cataloguing/additem.pl Check whether the current op is edititem or dupeitem and if so check whether the itemnumber supplied as a query param actually exists. If the item is not defined we output_and_exit and save the time to execute the rest of the controller code. Additionally we now don't have to process the whole template anymore. The only caveat is that we now have the suggested actions above the actual error message. Still an improvement. though. Again, thanks Frido. Hope, that this is what you had in mind. To test: 1. Go to any record 2. Hit the edit button on an item in the holdings table 3. Modify the URL so that the query param for the itemnumber is either 3.1 empty: /cgi-bin/koha/cataloguing/additem.pl?op=edititem=384= 3.2 an itemnumber that doesn't exist: /cgi-bin/koha/cataloguing/additem.pl?op=edititem=384=99 3.3 whatever else you come up with.. 4. Check the same thing for the dupe option (op=dupeitem) 5. Sign off Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 David Nind changed: What|Removed |Added Attachment #144794|0 |1 is obsolete|| Attachment #144812|0 |1 is obsolete|| --- Comment #20 from David Nind --- Created attachment 145306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145306=edit Bug 32418 - Can't call method 'unblessed' on an undefined value at cataloguing/additem.pl Check whether the current op is edititem or dupeitem and if so check whether the itemnumber supplied as a query param actually exists. If it doesn't, redirect to the additem op and hide all UI elements except for a dialog that gives options to add a new item to the record or to view the records holdings. This behaviour was adapted from the addbiblio view, as suggested by Fridolin. To test: 1. Go to any record 2. Hit the edit button on an item in the holdings table 3. Modify the URL so that the query param for the itemnumber is either 3.1 empty: /cgi-bin/koha/cataloguing/additem.pl?op=edititem=384= 3.2 an itemnumber that doesn't exist: /cgi-bin/koha/cataloguing/additem.pl?op=edititem=384=99 3.3 whatever else you come up with.. 4. Check the same thing for the dupe option (op=dupeitem) 5. Sign off Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 --- Comment #1 from Nick Clemens --- Created attachment 145305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145305=edit Bug 32250: Linking authorities does not change holdability If the only change is a linked heading, we don't need to rebuild the holds queue To test: 1 - Set preference RealTimeHoldsQueue to enable 2 - Run link_bibs_to_authorities 3 - Note holds queue jobs generated 4 - Apply patch 5 - repeat 6 - No holds queue updates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32624] Patrons fines are not accurate in SIP2 when NoIssuesChargeGuarantorsWithGuarantees or NoIssuesChargeGuarantees are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32624 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32624] Patrons fines are not accurate in SIP2 when NoIssuesChargeGuarantorsWithGuarantees or NoIssuesChargeGuarantees are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32624 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32624] Patrons fines are not accurate in SIP2 when NoIssuesChargeGuarantorsWithGuarantees or NoIssuesChargeGuarantees are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32624 --- Comment #1 from Nick Clemens --- Created attachment 145304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145304=edit Bug 32624: Don't include guarantee or guarantor fines in BV (fines amount) in SIP messages This patch chanegs the code to report only the patron's personal fines, and to report a block from other fines in the screen message This is to prevent overpayment on accounts from SIP machines To test: 1 - prove t/db_dependent/SIP/Patron.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32624] Patrons fines are not accurate in SIP2 when NoIssuesChargeGuarantorsWithGuarantees or NoIssuesChargeGuarantees are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32624 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31492] Patron image upload fails on first attempt with CSRF failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31492 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31492] Patron image upload fails on first attempt with CSRF failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31492 --- Comment #6 from Lucas Gass --- Created attachment 145303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145303=edit Bug 31492: Set CSRF token in circulation.pl To test: * Turn on patronimages system preferences * Go to any patron account * Hover over the 'dummy image' for the Add button * Browse and select an image for upload * Saving results in the following error: The form submission failed (Wrong CSRF token). Try to come back, refresh the page, then try again. Apply patch and try again. You shouldn't need to try twice, it should work on the first attempt now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31492] Patron image upload fails on first attempt with CSRF failure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31492 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 --- Comment #2 from Michal Denar --- +100 too :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32635] New: Holds Awaiting Pickup should note whether or not titles waiting past expiration date have additional holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32635 Bug ID: 32635 Summary: Holds Awaiting Pickup should note whether or not titles waiting past expiration date have additional holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andre...@dubcolib.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com On the Holds Awaiting Pickup page (waitingreserves.pl), the "Holds waiting over X days" tab lists holds that have gone past their expiration date but haven't yet been cancelled. Some libraries leave items in this state for a few extra days, in case the patron is simply running behind. It would be helpful to have some indication here if the title has additional holds that could be filled by the expired waiting item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Michael Adamyk changed: What|Removed |Added CC||mada...@ckls.org --- Comment #23 from Michael Adamyk --- (In reply to Owen Leonard from comment #8) > (In reply to Katrin Fischer from comment #6) > > > Has this worked before? > > Patron searching works correctly in 22.05 with the comma included, so this > is a regression. I'm running Koha 22.05.07, and this is affecting us. We can't do patron searches with commas or we get no results. I don't know if it was present in previous versions of 22.05 or not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 --- Comment #19 from David Nind --- (In reply to Paul Derscheid from comment #18) > The second patch relies on changes in the first. > Works correctly if you apply both. Thanks Paul. I have done that now and will sign off. I was a bit confused as the patch titles and test plan were the same/almost identical, and I thought (without actually looking at the patches) that they were the same. You may want to amend the patches for the QA Team so that the subject line is in the format Bug X: Bug title, as per https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Owen Leonard changed: What|Removed |Added Depends on||32634 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 [Bug 32634] Add 'page-section' to various pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Owen Leonard changed: What|Removed |Added Blocks||32634 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 [Bug 32634] Add 'page-section' to various pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32634] New: Add 'page-section' to various pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 Bug ID: 32634 Summary: Add 'page-section' to various pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 30952 Blocks: 31757 A forthcoming patch will fix several templates that need to have main content wrapped in a "page-section" container. - members/accountline-details.tt - patroncards/manage.tt - reports/dictionary.tt - virtualshelves/shelves.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32633] Add 'page-section' to cataloging and authority pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 --- Comment #1 from Owen Leonard --- Created attachment 145302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145302=edit Bug 32633: Add 'page-section' to cataloging and authority pages This patch adds a "page-section" container div around the main section of cataloging and authority pages which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. Apply the patch and view the following pages to confirm that the main content is contained in a white box: - Cataloging -> Cataloging search results - Cataloging -> Edit items: The table of items and the item edit form should each be contained in a page-section. - Authorities -> Search results - Authorites -> Merge authorities: From the authorities search results list, click "Actions -> Merge" for one result, and then "Actions -> Merge" for another. - Click "Next" after selecting a merge reference. - The "Destination record" information should be contained in a page-section. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32633] Add 'page-section' to cataloging and authority pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 --- Comment #23 from David Nind --- (In reply to David Gustafsson from comment #21) > Ok! Forgot to include that file in the commit, have now fixed this. Thanks David! Now signed off. Tested with ES7. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32583] Restore display of only one item in catalogue/moredetails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32583 Michael Hafen changed: What|Removed |Added Attachment #145299|0 |1 is obsolete|| --- Comment #6 from Michael Hafen --- Created attachment 145301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145301=edit Bug 32583 - Restore display of only one item in catalogue/moredetails Bug 31315 (Remove GetItemsInfo from moredetail) removed the code that limits the items displayed to only one item if the itemnumber was passed as a parameter to the page. This restores that code. Test plan: 1. find a title with multple items. 2. click on an items barcode in the holdings table on the title details page. 3. observe that all items are shown on the catalogue/moredetails page. 4. apply patch. 5. refresh (catalogue/moredetails) page. 6. observe that only the item for the barcode clicked on is shown. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31757] Add 'page-section' where it's missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Owen Leonard changed: What|Removed |Added Depends on||32633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 [Bug 32633] Add 'page-section' to cataloging and authority pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Owen Leonard changed: What|Removed |Added Blocks||32633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 [Bug 32633] Add 'page-section' to cataloging and authority pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32633] New: Add 'page-section' to cataloging and authority pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32633 Bug ID: 32633 Summary: Add 'page-section' to cataloging and authority pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 30952 Blocks: 31757 A few cataloging and authority templates need to have main content wrapped in a "page-section" container. - includes/merge-record.inc - authorities/searchresultlist.tt - cataloguing/addbooks.tt - cataloguing/additem.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Nind changed: What|Removed |Added Attachment #145263|0 |1 is obsolete|| --- Comment #22 from David Nind --- Created attachment 145300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145300=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. This feature is only supported when using Elasticsearch. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the current user has the tools -> export_catalog permission 5) Perform a search 6) Export the serach result by choosing a format under the "Export results" drop down 7) Verify that link(s) with exported data appear when export is completed 8) Revoke the permission in 3) and ensure exporting is no longer possible 9) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32583] Restore display of only one item in catalogue/moredetails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32583 Michael Hafen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32583] Restore display of only one item in catalogue/moredetails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32583 Michael Hafen changed: What|Removed |Added Attachment #145227|0 |1 is obsolete|| --- Comment #5 from Michael Hafen --- Created attachment 145299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145299=edit Bug 32583 - Restore display of only one item in catalogue/moredetails Bug 31315 (Remove GetItemsInfo from moredetail) removed the code that limits the items displayed to only one item if the itemnumber was passed as a parameter to the page. This restores that code. Test plan: 1. find a title with multple items. 2. click on an items barcode in the holdings table on the title details page. 3. observe that all items are shown on the catalogue/moredetails page. 4. apply patch. 5. refresh (catalogue/moredetails) page. 6. observe that only the item for the barcode clicked on is shown. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32632] Add 'page-section' to some tools pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32632 --- Comment #1 from Owen Leonard --- Created attachment 145298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145298=edit Bug 32632: Add 'page-section' to some tools pages This patch adds a "page-section" container div around the main section of some tools pages which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. Apply the patch and view the following pages to confirm that the main content is contained in a white box: - From the cataloging home page: Item modifications by age. If necessary, add at least one rule to see the table listing all rules. - Go to Tools -> Batch extend due dates, and submit values which will return one or more results, keeping the "Preview results" checkbox checked. Confirm that the page previewing the results looks correct. - Go to Tools -> Quote editor. If necessary, add at least one quote in order to see the table of quotes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32632] Add 'page-section' to some tools pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32632 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31893] Some pages load about.tt template to check authentication rather than using checkauth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31893 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31893] Some pages load about.tt template to check authentication rather than using checkauth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31893 --- Comment #2 from Nick Clemens --- Created attachment 145297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145297=edit Bug 31893: Use checkauth and do not fetch about.tt template This patch updates four scripts to use checkauth instead of get_template_and_user reserve/modrequest.pl reserve/modrequest_suspendall.pl course_reserves/mod_course.pl members/members-update-do.pl No behvaiour change is expected To test: 0 - Apply patch 1 - Place some holds for a patron 2 - From patron page, confirm you can suspend all 3 - confirm you can delete marked holds 4 - Edit a course in course-reserves 5 - Make a chaneg to personal details via OPAC 6 - Confirm change can be approved on staff side -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31893] Some pages load about.tt template to check authentication rather than using checkauth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31893 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32019] Add option to mark items returned in batch modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 --- Comment #14 from Kyle M Hall --- Created attachment 145296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145296=edit Bug 32019: (follow-up) Fix terminology and styling This patch adds periods to description on batch mod form and alters language to follow proper terminology Styling is fixed to align forms Blank option is removed, No made default Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32019] Add option to mark items returned in batch modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 --- Comment #13 from Kyle M Hall --- Created attachment 145295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145295=edit Bug 32019: Add option to mark items returned via batch modification Ther are options that allow avoiding marking an issue returned when se tot lost. Libraries do this to tie a lost item to a patron clearly. Eventually, after the patron has paid, or after some time, the library may wish to delete the item. When doing so, they do not wish to check the item in and affect any statuses or fines. This is also true for withdrawn items It would be helpful to have a way to mark issues returned in bulk, when they have not been marked returned in the past To test: 1 - Apply patches 2 - Restart all 3 - Set 'MarkLostItemsAsReturned' system preferences to 'None' 4 - Check out some items that have replacement fees set 5 - Mark them lost 6 - Check out more items, mark them withdrawn 7 - Set system preference 'BlockReturnOfWithdrawnItems' to block 8 - Enter item barcodes into batch modification 9 - Leave 'Mark items returned as blank 10 - Verify nothing was checked in 11 - Repeat but set 'Mark items as returned' to 'No' 12 - Verify nothing was checked in 13 - Repeat, but set 'Mark items as returned' to 'Yes' 14 - Verify items are returned 15 - Verify no fines have been adjusted 16 - Verify withdrawn items are sitll withdrawn 17 - Verify you can now delete the items Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32019] Add option to mark items returned in batch modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 Kyle M Hall changed: What|Removed |Added Attachment #142823|0 |1 is obsolete|| Attachment #142824|0 |1 is obsolete|| Attachment #142825|0 |1 is obsolete|| --- Comment #12 from Kyle M Hall --- Created attachment 145294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145294=edit Bug 32019: Unit tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32019] Add option to mark items returned in batch modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32019] Add option to mark items returned in batch modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32019 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #419 from Kyle M Hall --- Follow-ups have been squashed into the main patch set to make everything manageable and readable again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #418 from Kyle M Hall --- Created attachment 145293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145293=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #417 from Kyle M Hall --- Created attachment 145292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145292=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32622] Auth.t failing on D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Martin Renvoize changed: What|Removed |Added Version(s)|22.11.02|23.05.00, 22.11.02 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #416 from Kyle M Hall --- Created attachment 145291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145291=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #415 from Kyle M Hall --- Created attachment 145290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145290=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #414 from Kyle M Hall --- Created attachment 145289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145289=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #413 from Kyle M Hall --- Created attachment 145288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145288=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32622] Auth.t failing on D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 --- Comment #6 from Martin Renvoize --- I'm a Muppet.. I forgot to update bugzilla that this is in master too... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #412 from Kyle M Hall --- Created attachment 145287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145287=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall changed: What|Removed |Added Attachment #143527|0 |1 is obsolete|| Attachment #143529|0 |1 is obsolete|| Attachment #143530|0 |1 is obsolete|| Attachment #143531|0 |1 is obsolete|| Attachment #143532|0 |1 is obsolete|| Attachment #143533|0 |1 is obsolete|| Attachment #143534|0 |1 is obsolete|| Attachment #143535|0 |1 is obsolete|| Attachment #143536|0 |1 is obsolete|| Attachment #143537|0 |1 is obsolete|| Attachment #143538|0 |1 is obsolete|| Attachment #143539|0 |1 is obsolete|| Attachment #143540|0 |1 is obsolete|| Attachment #143541|0 |1 is obsolete|| Attachment #143542|0 |1 is obsolete|| Attachment #143543|0 |1 is obsolete|| Attachment #143544|0 |1 is obsolete|| Attachment #143545|0 |1 is obsolete|| Attachment #143546|0 |1 is obsolete|| Attachment #143547|0 |1 is obsolete|| Attachment #143548|0 |1 is obsolete|| Attachment #143549|0 |1 is obsolete|| Attachment #143550|0 |1 is obsolete|| Attachment #143551|0 |1 is obsolete|| Attachment #143552|0 |1 is obsolete|| Attachment #143553|0 |1 is obsolete|| Attachment #143554|0 |1 is obsolete|| Attachment #143555|0 |1 is obsolete|| Attachment #143556|0 |1 is obsolete|| --- Comment #411 from Kyle M Hall --- Created attachment 145286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145286=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19822] Add system preferences for ILL Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19822] Add system preferences for ILL Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Martin Renvoize changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Martin Renvoize changed: What|Removed |Added Assignee|a...@komputilo.eu |pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32622] Auth.t failing on D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Jacob O'Mara changed: What|Removed |Added Status|Passed QA |Pushed to stable Version(s)||22.11.02 released in|| CC||jacob.om...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32596] Background jobs viewer not showing finished jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32596 --- Comment #8 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32596] Background jobs viewer not showing finished jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32596 Jacob O'Mara changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.02 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528 --- Comment #12 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528 Jacob O'Mara changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.02 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 --- Comment #22 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32491] Can no longer search patrons in format 'surname, firstname'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32491 Jacob O'Mara changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.02 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32481] Rabbit times out when too many jobs are queued and the response takes too long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32481 --- Comment #37 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
