[Koha-bugs] [Bug 8737] Incorrect icon at login in staff client

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8737

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |mtomp...@hotmail.com

--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 12032
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12032action=edit
Sets missing environment variable so correct icon is displayed.

I initially did a tarball install of 3.6.3 and hacked the template files to get
it right. This patch against master should be the correct solution to the
problem. This problem exists in 3.6.X and I believe 3.8.X as well.

I followed the simple steps given in my previous comments to confirm after
applying the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002

--- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 12033
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12033action=edit
Bug 8002: FIX Change datatype from varchar 1 to 10 for
borrower_attribute_types.category_code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002

--- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 12034
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12034action=edit
[3.8.X] Bug 8002: FIX Change datatype from varchar 1 to 10 for
borrower_attribute_types.category_code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #18)
  Yes I have just seen that ! But why mysql breaks a constraint ??
 
 When category_code is truncated to 1 character, it is no more possible
 to link borrower attribute types to borrower categories which are still
 10 characters length. And if 2 attributes have been linked to 2
 distinct borrower categories like ENFANT and ETUDIANT, category_code
 will contain E after ALTER TABLE for both attributes, and the link won't
 work anymore.

Hi Frédéric,
Yes, I has understand.
I would said it is strange that MySQL does not keep integrity and raise an
error when we want to reduce data.
Besides
But it is normal MySQL does what we ask him :)

I proposed 2 patchs (same as previous). 1 for master, 1 for 3.8.x
A warning message is displayed on the updatedatabase page.
I hope it is what you wanted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002

--- Comment #22 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #21)
 But it is normal MySQL does what we ask him :)

Definetly it's not normal, and it's a bug !
When you don't have a constraint and try to add one, if there are data that
would not respect the constraint, you get a message, and the constraint is not
set. Seel update22to30.pl to see how I handled this case in the past = I throw
a clear warning, with the query to run to see which data was wrong, so the
library could fix it and put the constraint.

I'm expecting from ALTER TABLE that an existing constraint is checked before
the table is altered !
Also note that, iirc, you can't put a constraint on 2 columns with different
type/size. That could be easily checked by mysql when you ALTER TABLE !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7673] New patron permissions

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

delaye stephane.del...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241

--- Comment #25 from Adrien SAURAT adrien.sau...@biblibre.com ---
Ok, I made a test with this request and it modified all the timestamps of my
updated rows.
That's because this field is designed to store the date of each sql update:
`timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE
CURRENT_TIMESTAMP,

It seems to me that, for these logs, the important date is the library action
date and not the last SQL modification date.

---

I suggest adding also the following line before the UPDATE:
ALTER TABLE action_logs CHANGE timestamp timestamp TIMESTAMP NOT NULL DEFAULT
CURRENT_TIMESTAMP;

The timestamp will still be automatically set when creating a row, but updating
won't change the original date/time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8381] Paging broken in OPAC search results

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381

claire.hernan...@biblibre.com claire.hernan...@biblibre.com changed:

   What|Removed |Added

 CC||claire.hernandez@biblibre.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #10567|0   |1
is obsolete||

--- Comment #3 from Colin Campbell colin.campb...@ptfs-europe.com ---
Created attachment 12035
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12035action=edit
Revised Patch

Cleaned up the code. Handle some cases better - rebased against current master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high
   Severity|enhancement |major

--- Comment #4 from Colin Campbell colin.campb...@ptfs-europe.com ---
Changed status to bug as without this patch the SIPServer crashes when faced
with a RenewAll transaction. Also the current sip server reports to the client
that it supports Renew and Renewall transactions but it does not and in ways
that cause the client and/or server to fail.

Tested by Staffordshire University with Talking Tech telephone renewals

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7684] inventory : datatable fix actions etc.

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

delaye stephane.del...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #10069|0   |1
is obsolete||

--- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 12036
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12036action=edit
Bug 6835 - Ability to specify types of email address in overdue_notices.pl

Adds the -email option to overdue_notices.pl, which is repeatable

 -email value can be:
   - 'email'
   - 'emailpro' or
   - 'B_email'

- perltidy done
- in production for a BibLibre customer
- validated by the customer

Signed-off-by: Claire Hernandez claire.hernan...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com ---
Last patch is just a rebased patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7993] saved report with hierarchies

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com ---
Patch does not apply
CONFLICT (content): Merge conflict in reports/guided_reports.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7583] undo receive

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #11547|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 12037
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12037action=edit
Bug 7583: Cancel a receipt

In acqui/parcel.pl, there is now the possibility to cancel a receipt.
In Already received table, just click on Cancel receipt and the
order line will go back to pending orders.
If it was a partial receipt, order line is merged to its 'parent' line.
Attached items are modified so that they become attached to the merged
order line.
If AcqCreateItem is 'receiving', attached items are deleted.
If an order line was first partially received, and then completed. You
must cancel the 'parent' order line before cancelling the 'child'.

Signed-off-by: Marc Veron ve...@veron.ch

The patch behaves like expected, and the feature is really helpfull.

Just a tiny remark about the following message:

-
Cannot cancel receipt. Possible reasons :
You are trying to cancel the receipt of an order line whose parent order line
is already received. Cancel this parent order line and retry.
-

Maybe it would be good
- to explain a little bit more why it happend and re-word the message for non
technical people (not everybody understands 'parent' the same way)

- prevent the situation to happen (e.g. forbid order lines to be deleted if
they are already received) - but that would be in the scope of an other bug, I
think.

I think such things could be fixed in the future during the ongoing work for
Acquisitions module. Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7583] undo receive

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #11590|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 12038
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12038action=edit
Bug 7583 follow-up: Prevent users to cancel receipt if they can't

Disable the link for cancelling instead of displaying an error message
after the click. This is only valid if parent order line is received,
not if it's deleted.
When the user gets his mouse over the disabled link, he gets a message
telling him which order (ordernumber) blocks him so he knows immediately
which receipt to cancel.
Also improve error messages for non technical people

Signed-off-by: Chris Cormack chr...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7583] undo receive

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583

--- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com ---
Rebased patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7583] undo receive

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 QA Contact|koha.sek...@gmail.com   |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8730] browse overlaying powered by

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
The result of applying the patch should be this (starting at line 2219):

a.koha_url {
text-decoration:none;
}
/* pagination */
.pagination {
position: absolute;
top:32px;
left: -1px;
width: 100%;
height:auto;
border: 1px solid #D0D0D0;
display: none;
background-color:#F3F3F3;
padding-bottom:10px;
+z-index: 100;
}

Are you sure you're applying the patch on master?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11980|0   |1
is obsolete||

--- Comment #36 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12039
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12039action=edit
Bug 8215 - Course Reserves

Adds a course reserves system for academic libraries.

The course reserves system allows libraries to create courses
and put items on reserves for those courses.

Each item with at least one reserve can have some of its attributes
modified while it is on reserve for at least one active course.
These attributes include item type, collection code, shelving location,
and holding library. If there are no active courses with this item
on reserve, it's attributes will revert to the original attributes
it had before going on reserve.

Testing Scenario:
  1) Create new authorised value categories DEPARTMENT and TERM
  2) Create a new course, add instructors to that course.
  3) Reserve items for that course, verify item attributes have changed.
  4) Disable course, verify item attributes have reverted.
  5) Enable course again, verify item attributes again.
  6) Delete course, verify item attributes again.
  7) Create two new courses, add the same item(s) to both courses.
  8) Disable one course, verify item attributes have not reverted.
  9) Disable both courses, verify item attributes have reverted.
 10) Enable one course, verify item attributes are again set to the
 new values.
 11) Edit reserve item attributes, verify.
 12) Disable all courses, edit reserve item attributes, verify
 the item itself still has its original attributes, verify
 the reserve item attributes have been updated.
 13) Verify the ability to remove instructors from a course.
 14) Verify new permissions, top level coursereserves, with
 subpermissions add_reserves and delete_reserves.

Bug 8215 - Add Course Reserves - Followup - Fix DB Updater  Makefile

Bug 8215 - Add Course Reserves - Followup - Hide disabled course reserves on
catalog details page.

Bug 8215 - Add Course Reserves - Followup - One Hit Searching Bugfix

When searching courses, a search that results in a single hit will
automatically forward to the details for that course. If only a single
course has been added to the system, Koha will always forward to that
course and there will be no way to get to course-reserves.pl to add
a second course!

Fixed by testing for an actual search, rather than looking only at
the number of hits returned.

 Bug 8215 - Add Course Reserves - Followup - Prevent submitting form on 'enter'

When using the instructor search, hitting enter will attempt to submit the
form.
This is unwanted behavior. Fixed by adding some jquery, such that any form
field
with the class noEnterSubmit will but trigger a form submission. This class
can be used on any form in the librarian interface to prevent a field from
triggering
a form submission via the enter key.

Bug 8215 - Course Reserves - Followup - Remove checkEnter() and reimplement
with noEnterSubmit class

 Bug 8215 - Course Reserves - Followup - Fix permissions typos

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8215] Add Course Reserves

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

--- Comment #37 from Kyle M Hall k...@bywatersolutions.com ---
 Permissions related:
 - if one wanted to delegate ADD/DEL reserves permissions without also the
 manage(ADE/EDIT?DEL) courses permission, that can't be done.  Without manage
 courses, course_reserves is not an accessible page, so one can't get to the
 links to add/del  reserves.

This should be fixed in this new patch.

 - Also, while i had permissions to delete reserves, I copied the url of the
 remove link to the clipboard.  then i removed the staff permssion allowing
 delete reserves.  i logged in as staff and saw only the edit link (no
 remove), BUT I pasted the remove action url from my clipboard and the delete
 worked. So a check needs to be in the script/controller/security layer to
 see what is an accepted action.  The same probably goes for courses.

Also fixed in the new patch.

 - Maybe the TERM and DEPARTMENT could be added to the optional data that
 folks choose to load. The future testers would be helped.

We could definitely do this, but the values for TERM and DEPARTMENT are so
library-specific that any data we add would certainly not be usable out of the
box. I think it is just as good if not better to just document them as part of
the setup process in the manual.

 - I don't know the repercussion of having no library set. (NULL in columns?),
 You might want a check and popup to prevent adding rows unless a library is
 set.

There are no repercussions for not having a library set. None of the code for
this feature uses the logged in user's set branch for anything, so no worries
there!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #11470|0   |1
is obsolete||

--- Comment #233 from Paul Poulain paul.poul...@biblibre.com ---
Comment on attachment 11470
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11470
[PASSED-QA] Bug 5327 follow-up: add DBD::Mock dependency

This patch has been pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #11500|0   |1
is obsolete||

--- Comment #234 from Paul Poulain paul.poul...@biblibre.com ---
Comment on attachment 11500
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11500
[PASSED-QA]Bug 5327 : Added a few more lines of code to the ItemType.t unit
test

This patch has been pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #11503|0   |1
is obsolete||

--- Comment #235 from Paul Poulain paul.poul...@biblibre.com ---
Comment on attachment 11503
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11503
[PASSED-QA]Bug 5327 Tests for C4::Matcher

This patch has been pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #11505|0   |1
is obsolete||

--- Comment #236 from Paul Poulain paul.poul...@biblibre.com ---
Comment on attachment 11505
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11505
[PASSED-QA]Added and tested a mock-db tested a couple of features

This patch has been pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #11506|0   |1
is obsolete||

--- Comment #237 from Paul Poulain paul.poul...@biblibre.com ---
Comment on attachment 11506
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11506
[PASSED-QA]Added a mock-db table and tested a line

This patch has been pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #11763|0   |1
is obsolete||

--- Comment #238 from Paul Poulain paul.poul...@biblibre.com ---
Comment on attachment 11763
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11763
[PASSED-QA] Added tests to installer_perlmodules

This patch has been pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #11993|0   |1
is obsolete||

--- Comment #239 from Paul Poulain paul.poul...@biblibre.com ---
Comment on attachment 11993
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11993
[PASSED-QA] Bug 5327 : Fixing a typo in the test that was causing a false fail

This patch has been pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #12002|0   |1
is obsolete||

--- Comment #240 from Paul Poulain paul.poul...@biblibre.com ---
Comment on attachment 12002
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12002
[PASSED-QA]Bug 5327: Unit tests for C4 socialdata

This patch has been pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #12003|0   |1
is obsolete||

--- Comment #241 from Paul Poulain paul.poul...@biblibre.com ---
Comment on attachment 12003
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12003
[PASSED-QA]Bug 5327: Testing c4 Images

This patch has been pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7678] Statistics wizard: patrons

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678

claire.hernan...@biblibre.com claire.hernan...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #7 from claire.hernan...@biblibre.com 
claire.hernan...@biblibre.com ---
I change the patch status for review.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11986|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12040
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12040action=edit
Bug 8644 [staff client] jQueryUI CSS file should not contain customizations

This patch moves jQueryUI customizations into the main CSS
file for the staff client. In order to get the corrected
default version of jquery-ui.css I have upgraded all core
jQueryUI files.

Testers should look at examples of each of the various jQueryUI
widgets we use in Koha to confirm continued functinality: tabs,
autocomplete, datepickers, and slider (in specify due date popup).

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12005|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12041
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12041action=edit
Bug 8644 [OPAC] jQueryUI CSS file should not contain customizations

This patch moves jQueryUI customizations into the main CSS
file for the OPAC. In order to get the corrected
default version of jquery-ui.css I have upgraded all core
jQueryUI files.

Testers should look at examples of each of the various jQueryUI
widgets we use in the OPAC to confirm continued functinality: tabs
and datepickers.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

--- Comment #8 from Kyle M Hall k...@bywatersolutions.com ---
I checked out all the different jQuery widgets I could find. Everything looks
good to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12004|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12042
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12042action=edit
Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result count
is off

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241

Adrien SAURAT adrien.sau...@biblibre.com changed:

   What|Removed |Added

  Attachment #11415|0   |1
is obsolete||

--- Comment #26 from Adrien SAURAT adrien.sau...@biblibre.com ---
Created attachment 12043
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12043action=edit
proposed patch #3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241

Adrien SAURAT adrien.sau...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8730] browse overlaying powered by

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12023|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12044
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12044action=edit
Bug 8730 - browse overlaying powered by

This patch adds a z-index property to the CSS for
the browse results menu so that it will appear
on top of the Powered by Koha link.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8730] browse overlaying powered by

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_10

--- Comment #26 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to master

Agreed the new behaviour is OK. (our idea when updating opac- was to get rid of
those terms that students/patrons don't understand. You reintroduce some terms,
but it's *much* smoother than the initial version, and a few CSS can always
hide that)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8727] Correct help text in rebuild_zebra_sliced.sh

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8727

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11977|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12045
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12045action=edit
Bug 8727 Minor stylistic change to help text

indexing not indexation
some minor grammatical changes

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3462] Link see alsos in authorities

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462

--- Comment #16 from Paul Poulain paul.poul...@biblibre.com ---
Jared, ping on my comment 15 = I need some explanations. Should I see
differences in UNIMARC ? (I think yes, but can't see them)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8727] Correct help text in rebuild_zebra_sliced.sh

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8727

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Looks good to me, definitely an improvement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028

--- Comment #13 from Paul Poulain paul.poul...@biblibre.com ---
Kyle, ping on my comment 12. I need to test that before pushing !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8737] Incorrect icon at login in staff client

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8737

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12032|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12046
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12046action=edit
Bug 8737 - Incorrect icon at login in staff client

Added the following missing code to ensure the correct icon
is used when logged out:
   IntranetFavicon = C4::Context-preference('IntranetFavicon')
This was added into an existing $template-param() call.

Not to be confused with the koha logo on the login page, the
icon is a 16x16 pixel graphic in the browser tab. The default
is found at .../intranet-tmpl/prog/en/includes/favicon.ico.

If the IntranetFavicon system preference is set, it should be
used by the staff client regardless of login state. It was not
being used in the AUTH rejected section of Auth.pm, but the
OpacFavicon variable was being set. This explains why the
OpacFavicon system preference works for the OPAC client, but
not the staff client upon logout.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8737] Incorrect icon at login in staff client

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8737

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017

--- Comment #10 from Paul Poulain paul.poul...@biblibre.com ---
Colin = pinging my comment 8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12029|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12047
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12047action=edit
Bug 8732 : Allowing biblio level itemtypes to display instead of MARC ones

If you switch OpacResultsItemtypeImage to Koha, you will see the Koha
itemtypes, if it is Control you will get the ones generated from the
MARC control fields.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Followed the test plan. Everything works as advertised.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8730] browse overlaying powered by

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730

--- Comment #5 from Marc Véron ve...@veron.ch ---
Owen,

Sorry for the confusion. Maybe it was a cache problem. Just tested again and it
worked fine.

While I was testing Kyle signed off :-)

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8724] Upgrade from NoZebra installs is broken

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8724

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11969|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12048
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12048action=edit
Bug 8724 - Upgrade from NoZebra installs is broken

Properly set the relevant NoZebra and QueryRemoveStopwords sysprefs to 0 to fix
issues on upgrades.
Also removes the sysprefs from preferences/searching.pref

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8738] New: DateTime object being compared to a date string in circulation

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738

  Priority: P5 - low
 Change sponsored?: Sponsored
Bug ID: 8738
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
  Assignee: koha-bugs@lists.koha-community.org
   Summary: DateTime object being compared to a date string in
circulation
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: m...@software.coop
   URL: http://intranet/cgi-bin/koha/circ/circulation.pl
  Hardware: All
Status: NEW
   Version: rel_3_8
 Component: Circulation
   Product: Koha

A DateTime object can only be compared to another DateTime object
(DateTime=HASH(0x54110d8), 0). at
/home/coop/koha/unstable/src/circ/circulation.pl line 346
 at /usr/lib/perl5/DateTime.pm line 1801
DateTime::_compare('DateTime=HASH(0x54110d8)', 0, 0) called at
/usr/lib/perl5/DateTime.pm line 1780
DateTime::compare('DateTime=HASH(0x54110d8)', 0) called at
/usr/lib/perl5/DateTime.pm line 1762
DateTime::_compare_overload('DateTime=HASH(0x54110d8)', 0, '') called at
/home/coop/koha/unstable/src/circ/circulation.pl line 346

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8738] DateTime object being compared to a date string in circulation

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738

MJ Ray (software.coop) m...@software.coop changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Severity|enhancement |major

--- Comment #1 from MJ Ray (software.coop) m...@software.coop ---
This is happening when I try to circulate a book.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8738] DateTime object being compared to a date string in circulation

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738

--- Comment #2 from MJ Ray (software.coop) m...@software.coop ---
Created attachment 12049
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12049action=edit
circ/circulation.pl: force issuedate to a string to fix bug 8738

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417

--- Comment #43 from Paul Poulain paul.poul...@biblibre.com ---
UNIMARC QA comment:
If I'm not mistaking, http://archive.ifla.org/VI/3/p1996-1/uniafull.htm#4--
says that 4xx are for see references, it's the same as in marc21
(http://www.loc.gov/marc/authority/ad4xx.html)

The 2nd digit is not always the same:
UNIMARC = 420 See Reference Tracing - Family Name
MARC21 = 420 does not exits

The code says
# for each field
+foreach my $field ( $record-fields() ) {

# if there is a link to authorities
+my $authid = $field-subfield('9');

# retrieve the authority
+my $authority = Koha::Authority-get_from_authid($authid);

# if there are seefrom fields
+my @seefrom = $auth_marc-field('4..');

# add them in the biblio record

# find the biblio record tag
+my $tag = substr($field-tag(), 0, 1) . substr($authfield-tag(),
1, 2);
# create a new one, where you'll put datas coming from authorities
+my $newfield = MARC::Field-new($tag,
+'z',
+$authfield-indicator(2) || ' ',
+'9' = '1');
# copy each subfield
+foreach my $sub ($authfield-subfields()) {
+my ($code,$val) = @$sub;
+$newfield-add_subfields( $code = $val );
+}


What I don't understand is the '9' = '1'
You're connecting all biblios to the #1 authority ? why ?

Another question = why do you set 1st indicator to 'z' ?

Other question = do you have checked performances ? I think that it will be a
*big* overhead for rebuild_zebra.pl -b -r (ie= rebuilding all the database)
time rebuild_zebra.pl will give us numbers, that we need to have, at least to
warn librarians !

Last question = do you also have checked/tested solr ? I see that you write
+if ($record_type eq 'biblio' 
C4::Context-preference('IncludeSeeFromInSearches')) {
+my $normalizer = Koha::RecordProcessor-new( { filters =
'EmbedSeeFromHeadings' } );
+$record = $normalizer-process($record);
+}
in Koha/SearchEngine/Solr/Index.pm (asking Claire in // to get her feedback on
this)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017

--- Comment #11 from Colin Campbell colin.campb...@ptfs-europe.com ---
Paul, Id be happy to see this pushed as is. I think I'll look at what can be
done to improve the query as a separate piece of work

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3462] Link see alsos in authorities

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462

--- Comment #17 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Paul,

(In reply to comment #16)
 Jared, ping on my comment 15 = I need some explanations. Should I see
 differences in UNIMARC ? (I think yes, but can't see them)

I just spent a while trying to figure out why this wasn't working in UNIMARC
before I realized that in a properly-configured UNIMARC system, it shouldn't.
UNIMARC uses a user-specified summary format in auth_types.summary. MARC21 does
not have that. This patch keeps the existing behavior, since presumably it
matches what you would want. A follow-up patch could remove the
auth_types.summary bit, if you wanted.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417

--- Comment #44 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #43)
 UNIMARC QA comment:
 If I'm not mistaking, http://archive.ifla.org/VI/3/p1996-1/uniafull.htm#4--
 says that 4xx are for see references, it's the same as in marc21
 (http://www.loc.gov/marc/authority/ad4xx.html)
 
 The 2nd digit is not always the same:
 UNIMARC = 420 See Reference Tracing - Family Name
 MARC21 = 420 does not exits

As I understand it (I asked Francois a while ago), ALL 4xx fields work like
this, so it doesn't matter what the second digit is.

 The code says
 # for each field
 +foreach my $field ( $record-fields() ) {
 
 # if there is a link to authorities
 +my $authid = $field-subfield('9');
 
 # retrieve the authority
 +my $authority = Koha::Authority-get_from_authid($authid);
 
 # if there are seefrom fields
 +my @seefrom = $auth_marc-field('4..');
 
 # add them in the biblio record
 
 # find the biblio record tag
 +my $tag = substr($field-tag(), 0, 1) .
 substr($authfield-tag(), 1, 2);
 # create a new one, where you'll put datas coming from authorities
 +my $newfield = MARC::Field-new($tag,
 +'z',
 +$authfield-indicator(2) || ' ',
 +'9' = '1');
 # copy each subfield
 +foreach my $sub ($authfield-subfields()) {
 +my ($code,$val) = @$sub;
 +$newfield-add_subfields( $code = $val );
 +}
 
 
 What I don't understand is the '9' = '1'
 You're connecting all biblios to the #1 authority ? why ?

This is a workaround for a peculiarity in MARC::Record. If you look a bit
further down, you'll see I delete the subfield $9, once I've populated the
other subfields. 
 
 Another question = why do you set 1st indicator to 'z' ?

I needed some way to CLEARLY identify the field as not being a real part of the
record. Since ind1=z is not valid in MARC, that seemed like a good way.
 
 Other question = do you have checked performances ? I think that it will be
 a *big* overhead for rebuild_zebra.pl -b -r (ie= rebuilding all the database)
 time rebuild_zebra.pl will give us numbers, that we need to have, at least
 to warn librarians !

I have. That's a good point. The syspref should note it takes twice as long to
rebuild Zebra with this enabled.

 Last question = do you also have checked/tested solr ? I see that you write
 +if ($record_type eq 'biblio' 
 C4::Context-preference('IncludeSeeFromInSearches')) {
 +my $normalizer = Koha::RecordProcessor-new( { filters =
 'EmbedSeeFromHeadings' } );
 +$record = $normalizer-process($record);
 +}
 in Koha/SearchEngine/Solr/Index.pm (asking Claire in // to get her feedback
 on this)

I have not been able to test it. The Solr dependencies do not compile on Debian
(nor, I think, would Solr run on my little laptop). I thought about not
including the Solr bit, since Solr is still experimental, but decided I would
provide it so that the RM could make that decision.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417

--- Comment #45 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Note that performance could be greatly improved by using Koha::Cache with an
in-memory cache. This depends on the new CHI caching. I did not implement it
yet because I prefer a more gradual approach to larger developments. It reduces
the likelihood of bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8447] can't save new records / indicator error

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8447] can't save new records / indicator error

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447

--- Comment #13 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 12050
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12050action=edit
Bug 8447: Make sure we have enough subfields for broader_headings

Thanks to wajasu for providing the debugging information, as I cannot
seem to duplicate the problem, even seeing where it could come from.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7671] add a real primary key accountlinesid in accountlines

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671

--- Comment #24 from stephane.dela...@biblibre.com ---
Created attachment 12051
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12051action=edit
followup

followup : delete return of makepayment because unused, fix updatedatabase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7671] add a real primary key accountlinesid in accountlines

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671

stephane.dela...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8738] DateTime object being compared to a date string in circulation

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738

MJ Ray (software.coop) m...@software.coop changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #3 from MJ Ray (software.coop) m...@software.coop ---
Tested as working on local development installation. I can now circulate books
again.

I apologise for the incorrect line number in the earlier backtrace. It seems I
had some development code (analytic item types, bug 7716) in the tree at the
time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8724] Upgrade from NoZebra installs is broken

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8724

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11516|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12052
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12052action=edit
Bug 8585 : Add System Preference to specify Holds to Pull List Start Date

Currently, Koha creates a default value of 2 days ago (-2) for the start date
of the Holds to pull List. This system preference allows users to specify their
own default start date for this list, since users might not want to have to
manually change the date all the time when they already know the set date
period they want to view.

The system preference value is specified as a positive integer, which is then
passed as a negative integer in the handler script. This saves users from
having to include a qualifer to the sys pref value.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Works as advertised. I also am for the system preference. A cookie means the
librarian will have to set it every session. We could possibly have the
combination of both, but I think the syspref alone is better than a cookie
alone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record.

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8677] table overlapping to the right on holds waiting

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8677

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Created attachment 12053
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12053action=edit
Bug 8677 - table overlapping to the right on holds waiting

Converting layout to 100% flexible width to allow
table to expand as needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8677] table overlapping to the right on holds waiting

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8677

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8365] Renewal duration in issuingules

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 12054
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12054action=edit
Bug 8365: Add a renewal duration in the issuing rules

Renew an issue for a number of days (filled in the issuing rules).

Test if rules work for any i[item]types and if there is no regression.

- new column issuingrules.renewalperiod
- remove all occurrences of an already removed syspref (globalDueDate)
- remove an unused routine (Overdues::GetIssuingRules)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7671] add a real primary key accountlinesid in accountlines

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #11922|0   |1
is obsolete||

--- Comment #25 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12055
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12055action=edit
Bug 7671 : add a real primary key accountlines_id in accountlines

Signed-off-by: Stéphane Delaune stephane.dela...@biblibre.com
Signed-off-by: Marc Veron ve...@veron.ch

NOTE: After applying the patch I got following errors in members/pay.pl:
Global symbol $writeoff_sth requires explicit package name
Global symbol $add_writeoff_sth requires explicit package name

Added to lines at the begin of members/pay.pl:
our $writeoff_sth;
our $add_writeoff_sth;

Now the patch worked as expected.

However I am not quite sure if signing off is OK in this situation.

Marc

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7671] add a real primary key accountlinesid in accountlines

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12051|0   |1
is obsolete||

--- Comment #26 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12056
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12056action=edit
Bug 7671 : followup : delete return of makepayment because unused, fix
updatedatabase

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7671] add a real primary key accountlinesid in accountlines

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #16 from Paul Poulain paul.poul...@biblibre.com ---
Performances tests:

I tried to run the staff_benchmark on this patch, (with memcached) and so no
noticeable performance improvement
Bug 8089

With patch and with cache
Benchmarking with 20 occurences of each operation and 30 concurrent sessions 
Step 1: staff client main page 5955ms3.358 pages/sec
Step 2: catalog detail page13270ms1.507 biblios/sec
Step 3: catalogue search   23628ms0.846 biblios/sec
Step 4: patron detail page 11629ms1.719 borrowers/sec
Step 5: patron search page 20355ms1.965 borrowers/sec
Step 6a circulation (checkouts)15775ms1.267 checkouts/sec
Step 6b circulation (checkins) 15134ms1.321 checkins/sec
all transactions at once   112801ms1.595 operations/sec

Without patch and with cache
Step 1: staff client main page 5980ms3.344 pages/sec
Step 2: catalog detail page13828ms1.446 biblios/sec
Step 3: catalogue search   21114ms0.947 biblios/sec
Step 4: patron detail page 11378ms1.757 borrowers/sec
Step 5: patron search page 20316ms1.968 borrowers/sec
Step 6a circulation (checkouts)16162ms1.237 checkouts/sec
Step 6b circulation (checkins) 16916ms1.182 checkins/sec
all transactions at once   109549ms1.643 operations/sec

With patch and without caching
Step 1: staff client main page 5914ms3.381 pages/sec
Step 2: catalog detail page13543ms1.476 biblios/sec
Step 3: catalogue search   20992ms0.952 biblios/sec
Step 4: patron detail page 11993ms1.667 borrowers/sec
Step 5: patron search page 20293ms1.971 borrowers/sec
Step 6a circulation (checkouts)15181ms1.317 checkouts/sec
Step 6b circulation (checkins) 16692ms1.198 checkins/sec
all transactions at once   109429ms1.644 operations/sec


checked with  perl -MCache::Memcached -MData::Dumper=Dumper -le 'print
Dumper(Cache::Memcached-new(servers = [localhost:11211])-stats);'
that memcache was running  accessed:
'get_hits' = '1284',
'cmd_get' = '1302',

Could not find any problem, so ... patch pushed

(but I still think we [c|sh]ould store all sysprefs in a single cache entry)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8676] show vendor name in source of acquisition

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Nicole can you please add a screenshot?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8739] New: Partial Fine Payments Saving Amount Paid Incorrectly

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739

  Priority: P5 - low
 Change sponsored?: ---
Bug ID: 8739
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
  Assignee: koha-bugs@lists.koha-community.org
   Summary: Partial Fine Payments Saving Amount Paid Incorrectly
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: k...@bywatersolutions.com
  Hardware: All
Status: NEW
   Version: master
 Component: Circulation
   Product: Koha

When making payments, the amount paid is meant to be stored as a negative
number. C4::Accounts::makepayment does this correctly. However
C4::Accounts::makepartialpayment saves the amount as a positive number. This
means the payment shows up as a fine with no balance outstanding on the
borrowers record.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8739] Partial Fine Payments Saving Amount Paid Incorrectly

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8395] order receive not sorting right

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8395

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 CC||colin.campbell@ptfs-europe.
   ||com

--- Comment #8 from Colin Campbell colin.campb...@ptfs-europe.com ---
I dont think this fixes the problem. At a typical academic/public site
receipting against a major supplier some 500+ orders may appear. But the
sorting by summary only affects the page of results displayed move forward and
sort order reverts to basket order. As there may be multiple orders for one
title locating all of them is difficult.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8739] Partial Fine Payments Saving Amount Paid Incorrectly

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12057
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12057action=edit
Bug 8739 - Partial Fine Payments Saving Amount Paid Incorrectly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8739] Partial Fine Payments Saving Amount Paid Incorrectly

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
  Component|Circulation |Patrons

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8739] Partial Fine Payments Saving Amount Paid Incorrectly

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8598] No patron image or home library on Files Statistics tabs

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

Summary|borrower image and home |No patron image or home
   |library disappear on Files  |library on Files 
   | Statistics tabs   |Statistics tabs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8598] No patron image or home library on Files Statistics tabs

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8598] No patron image or home library on Files Statistics tabs

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
Created attachment 12058
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12058action=edit
Bug 8598 - No patron image or home library on Files  Statistics tabs

Adding the necessary code for patron image, patron
home library, patron category description, and patron
extended attributes to show in the left-hand sidebar.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8598] No patron image or home library on Files Statistics tabs

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028

--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12059
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12059action=edit
Bug 8028 - Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028

--- Comment #15 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to comment #12)
 mmm... I made a basket with 6 lines, and had another one with 2 lines
 pending. When I reach the parcel.pl page, I see the 8 pending lines
 directly, and no link to collapse/expand.
 Am I missing something ?
 
 (I recieved 4 of them, and saw no change)

Good catch. I've attach a small followup to fix the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

--- Comment #17 from Paul Poulain paul.poul...@biblibre.com ---
OK, I had some errors in my setup, so caching was not running in fact.
I've fixed and made my perf tests again:

Step 1: staff client main page 8722ms2.293 pages/sec
Step 2: catalog detail page13303ms1.503 biblios/sec
Step 3: catalogue search   19606ms1.02 biblios/sec
Step 4: patron detail page 11635ms1.718 borrowers/sec
Step 5: patron search page 18413ms2.172 borrowers/sec
Step 6a circulation (checkouts)17861ms1.119 checkouts/sec
Step 6b circulation (checkins) 15223ms1.313 checkins/sec


= no noticeable improvements again. Jared pointed that it could be because CHI
uses Moose if it's available, it is on my setup. And Moose is heavy to load :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7068] autobarcode not working when duplicating patrons

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7068

MJ Ray (software.coop) m...@software.coop changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||m...@software.coop
   Assignee|kyle.m.h...@gmail.com   |m...@software.coop

--- Comment #1 from MJ Ray (software.coop) m...@software.coop ---
I confirm this bug.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

Version|master  |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #40 from Paul Poulain paul.poul...@biblibre.com ---
I still can't apply patch #6

Bug 8597: Add system preferences to configure the mobile view.
Apply? [yn] y

Applying: Bug 8597: Add system preferences to configure the mobile view.
fatal: sha1 information is lacking or useless
(koha-tmpl/opac-tmpl/ccsr/en/css/opac.css).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 8597: Add system preferences to configure the mobile
view.
When you have resolved this problem run git am --resolved.
If you would prefer to skip this patch, instead run git am --skip.
To restore the original branch and stop patching run git am --abort.
Patch left in
/tmp/Bug-8597-Add-system-preferences-to-configure-the-m-IzlCyk.patch


(Also note that there is a trivial conflict on patch #1)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #36 from Paul Poulain paul.poul...@biblibre.com ---
Follow-up pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8678] XSLT stylesheets output XML, but HTML is needed

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8678

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||paul.poul...@biblibre.com
Version|master  |rel_3_8

--- Comment #6 from Paul Poulain paul.poul...@biblibre.com ---
Patch pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view

2012-09-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #11853|0   |1
is obsolete||
  Attachment #11854|0   |1
is obsolete||
  Attachment #11855|0   |1
is obsolete||
  Attachment #11856|0   |1
is obsolete||
  Attachment #11857|0   |1
is obsolete||
  Attachment #11974|0   |1
is obsolete||
  Attachment #11975|0   |1
is obsolete||

--- Comment #41 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 12060
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12060action=edit
Bug 8597: Improve template markup to prepare for mobile

The templates were missing classes on a number of elements that
will need classes in order for a mobile view to function.

Signed-off-by: Chris Cormack chr...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >