[Koha-bugs] [Bug 7409] Missing dependencies for Debian package

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

   Attachment #7601|0   |1
is obsolete||

--- Comment #9 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 12258
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12258action=edit
Bug 7409 : Missing dependency on libtest-mockmodule-perl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7409] Missing dependencies for Debian package

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Stable|ASSIGNED
 CC||ch...@bigballofwax.co.nz
Version|rel_3_6 |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7409] Missing dependencies for Debian package

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #28 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.8.x, will be in 3.8.5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #26 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.8.x, will be in 3.8.5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8743] ZOOM error when merging authority change to biblios

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8743

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #9 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.8.x, will be in 3.8.5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8420] tool statisticfines.pl(bz 6858) and hourly loan(bz5549)

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz ---
Doesn't apply cleanly to 3.8.x, please supply a patch for it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

--- Comment #23 from Chris Cormack ch...@bigballofwax.co.nz ---
String changes, held until after the string freeze

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8653] With DOM indexing turned on subject authority links are not indexed

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.8.x, will be in 3.8.5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8428] can't save contracts

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #11 from Chris Cormack ch...@bigballofwax.co.nz ---
Doesn't apply on 3.8.x please reformat if needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #31 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.8.x, will be in 3.8.5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8378] fine syntax not working on overdues anymore

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #12 from Chris Cormack ch...@bigballofwax.co.nz ---
Doesn't apply cleanly to 3.8.x, please send a patch that applies on 3.8.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7409] Missing dependencies for Debian package

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #12258|0   |1
is obsolete||

--- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 12259
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12259action=edit
Bug 7409 : Adding missing dependency

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #12035|0   |1
is obsolete||

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 12260
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12260action=edit
Bug 8336 Support Sip Renewal Transaction

Renewals were being rejected for incorrect reasons
Checking was being done against the wrong object
Add more informative messages on failure
Correctly set due_date for renewal response
Avoid crashing the SIPServer because it handles RenewAll
incorrectly

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7913] Automatically receive serial issues

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com

--- Comment #9 from Mason James m...@kohaaloha.com ---
 Signed-off-by: Delaye Stephane stephane.del...@biblibre.com

patch looks good, passing QA…

$ koha-qa.pl 

testing 1 commit(s) (applied to commit ce03893)
 * 551e5b2 Receiving serials in a loop
  koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
  serials/serials-collection.pl

* serials/serials-collection.plOK
* koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.ttOK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5339] Parcel closing in acq

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #76 from Mason James m...@kohaaloha.com ---
(In reply to comment #75)
 Kyle,
 The patch is waiting for 9 months then I think it can pass qa without UT.
 But a followup will be required.

Jonathan, hmmm, i an OK with a follow-up patch for unit-test

Julian, sorry, i had some small merge conflicts against master (ce03893) :/
if you rebase against master again, i will QA this the same day

#   both modified:  C4/Acquisition.pm
#   both modified:  acqui/finishreceive.pl
#   both modified:  acqui/parcel.pl


changing status to 'patch does not apply' (sorry)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||m...@kohaaloha.com

--- Comment #8 from Mason James m...@kohaaloha.com ---
 Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com
 Signed-off-by: Chris Cormack chr...@catalyst.net.nz


Jared, i get some conflicts applying both patches to master (ce03893)

can you rebase, then ping me for QA?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8627] Fixing pipe values in MARC21 controlfield 008 of authorities

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8627

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com
 QA Contact||m...@kohaaloha.com

--- Comment #6 from Mason James m...@kohaaloha.com ---
 Signed-off-by: Julian Maurice julian.maur...@biblibre.com

patch looks good, passing QA…

$ koha-qa.pl 

testing 1 commit(s) (applied to commit a64c811)
 * 6dee396 8627 Followup for removing tabs
  cataloguing/value_builder/marc21_field_008_authorities.pl

* cataloguing/value_builder/marc21_field_008_authorities.plOK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com

--- Comment #56 from Mason James m...@kohaaloha.com ---
 Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com
 Signed-off-by: Kyle M Hall k...@bywatersolutions.com

patch looks good, passing QA - well done everyone  :)

$ koha-qa.pl 

testing 1 commit(s) (applied to commit bf79b88)
 * d24fd5c bug_5786, bug_5787, bug_5788: Holds rewrite
  C4/Auth.pm
  C4/ILSDI/Services.pm
  C4/Items.pm
  C4/Reserves.pm
  C4/VirtualShelves/Page.pm
  admin/smart-rules.pl
  admin/systempreferences.pl
  installer/data/mysql/it-IT/necessari/system_preferences.sql
  installer/data/mysql/kohastructure.sql
  installer/data/mysql/sysprefs.sql
  installer/data/mysql/updatedatabase.pl
  installer/html-template-to-template-toolkit.pl
 
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
  koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
  koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
  koha-tmpl/opac-tmpl/prog/en/includes/opac-detail-sidebar.inc
  koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
  koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt
  koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
  koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt
  opac/opac-ISBDdetail.pl
  opac/opac-MARCdetail.pl
  opac/opac-detail.pl
  opac/opac-reserve.pl
  opac/opac-search.pl
  reserve/request.pl

* C4/Auth.pm   OK
* C4/ILSDI/Services.pm OK
* C4/Items.pm  OK
* C4/Reserves.pm   OK
* C4/VirtualShelves/Page.pmOK
* admin/smart-rules.pl OK
* admin/systempreferences.pl   OK
* installer/data/mysql/updatedatabase.pl   OK
* installer/html-template-to-template-toolkit.pl   OK
* opac/opac-ISBDdetail.pl  OK
* opac/opac-MARCdetail.pl  OK
* opac/opac-detail.pl  OK
* opac/opac-reserve.pl OK
* opac/opac-search.pl  OK
* reserve/request.pl   OK
* koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt OK
* koha-tmpl/opac-tmpl/prog/en/includes/opac-detail-sidebar.inc OK
* koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt  OK
* koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt  OK
* koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt  OK
* koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt  OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8757] Longer size text for authorised values lib

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8757

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com
 QA Contact||m...@kohaaloha.com

--- Comment #3 from Mason James m...@kohaaloha.com ---
 Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

patch looks good, passing QA…

$ koha-qa.pl 

testing 1 commit(s) (applied to commit bf79b88)
 * 292d4c7 Bug 8757: longer descriptions for authorised values
  installer/data/mysql/kohastructure.sql
  installer/data/mysql/updatedatabase.pl
  koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt

* installer/data/mysql/updatedatabase.pl   OK
* koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt   OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6945] Add a link to show a MARC preview in the normal view

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6945

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com
 QA Contact|koha-b...@lists.koha-commun |m...@kohaaloha.com
   |ity.org |

--- Comment #22 from Mason James m...@kohaaloha.com ---
 Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com

patches looks good, passing QA…

$ koha-qa.pl  -c 2

testing 2 commit(s) (applied to commit b592d34)
 * 86b0a36 Bug 6945 [FOLLOW-UP] Add a link to show a MARC preview in the nor
  koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt

 * 1227251 Add a link to show a MARC preview in the normal view of the detai
  koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt

* koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt  OK

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page.

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff
 CC||m...@kohaaloha.com

--- Comment #9 from Mason James m...@kohaaloha.com ---
 Works perfectly *if* you are the superlibrarian. There was an error in the
 permissions checking, I've attached a followup to fix it. I also had to add
 execution permissions to the file circ/send_recall_notice.pl.
 
 These are extremely minor fixes, so I'll set it to 'signed off' for now and
 assume whoever passes qa on it will be testing it. If you feel this needs a
 separate signoff, please set the status back to 'Needs Signoff and feel
 free to yell at me.

ok, this follow-up patch still needs testing/sign-off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8112] Overdues with Fines report, giving duplicates

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 CC||m...@kohaaloha.com
Summary|Overdues with Fines giving  |Overdues with Fines report,
   |duplicates  |giving duplicates

--- Comment #13 from Mason James m...@kohaaloha.com ---
(In reply to comment #6)
 Created attachment 11813 [details]
 0001-SIGNED-OFF-Bug-8112-Overdues-with-Fines-giving-dupli
 
 
 This patch deals with fixing the overdues with fines report only.
 
 Handling of reconciling those dups must be addressed somewhere else.
 
 I only tested the behavior of the report with the above two patches.
 
 Test:
 1) configured a patron with overdue items with fines.
 2) i ran the overdue with fines report
 i saw two rows, one for each patron ( normal scenario)
 3) to emulate a dupe FU fine update in accountlines, I insert the row
 refer to attachment above ...
 circulation_overdues_report_createdupefine_same_item.png
 for mysql work
 4) i ran the overdue with fines report
 I saw three rows, but two for the same patron and same item (multiple FU
 case)
 refer to attachment above ... circulation_overdues_report_dupefine.png
 5) applied 0001 and 0002 patches, and ran report gain
 I saw only two rows, even tough dups exist in the database.
 refer to  circulation_overdues_report_dupefine1_nodupeshowing.png
 
 This reports behaviour will work wether dups exist or not.  But when in
 place,
 it hides the dups.
 
 Note: Folks on IRC mentioned this was the result of an upgrade from 3.6.x to
 3.8.x
 In leiu of performing an upgrade, I took this route.
 
 wajasu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #11519|0   |1
is obsolete||
  Attachment #11591|0   |1
is obsolete||

--- Comment #9 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 12261
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12261action=edit
Bug 8210: add links to authorities to headings in OPAC

At the moment, there is no way to get to an authority record from a bib
record that uses it other than doing a new search on the authority file.
This patch adds a link (a cute little magnifying glass) to linked
authority records on the OPAC detail view for MARC21 and NORMARC
with XSLT enabled. A follow-up patch will add the link to regular mode.
Because UNIMARC handles authorities differently, the link is not added
to the XSLT.

Test plan:
1) Set OPACXSLTDetailsDisplay to 'default'
2) View a record that has some headings that are linked to authority
   records in the OPAC (easiest way to find a record like that is to
   edit a record and add some headings using the thesaurus plugin)
3) Observe the cute little magnifying glass links to the authority.

Revised version of the patch adds a space between the heading and the
magnifying glass.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Patch works nicely.

If a library does not like to see the
magnifying glass/link to the authority, it's easy to disable it
by adding the line .authlink {display:none;} to OpacUserCSS.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8112] Overdues with Fines report, giving duplicates

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 QA Contact||m...@kohaaloha.com

--- Comment #14 from Mason James m...@kohaaloha.com ---
 0001-SIGNED-OFF-Bug-8112-Overdues-with-Fines-giving-dupli

we have a test plan here, and a sign-off
i think this is OK to pass-QA on...

$ koha-qa.pl  -c 2

testing 2 commit(s) (applied to commit ce03893)
 * 7ba58d0 Bug 8112 - Overdues with Fines dup Followup - Add items.itemnumbe
  C4/Overdues.pm

 * 16abfcc Bug 8112 - Overdues with Fines giving duplicates
  C4/Overdues.pm

* C4/Overdues.pm   OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8112] Overdues with Fines report, giving duplicates

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

--- Comment #15 from Mason James m...@kohaaloha.com ---
(In reply to comment #12)
 Is it normal the followup changes only 1 query ?
 I think the problem exists in the 2 cases. But I have not tested !

oops, i missed Jonathans comment

Kyle, any response for only the 1 query change, not 2?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210

--- Comment #10 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 12262
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12262action=edit
Bug 8210: add links to authorities in normal mode headings

Cherry-picked from BibLibre's work on bug 5888:
opac-detail subject/author links improvements

Added a link to opac-authoritiesdetail.pl when possible.

Only affects 'Normal view'. Does not affect XSLT display.

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com
Signed-off-by: Chris Cormack chr...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8519] Make koha-index-daemon run on startup

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 CC||m...@kohaaloha.com
 Depends on||8774

--- Comment #12 from Mason James m...@kohaaloha.com ---
ive added a new bug '8774' as a blocker for this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8774] make a deb package of Koha::Contrib::Tamil::IndexerDaemon

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8774

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Blocks||8519

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8693] Sort biblio checkout history by checkout date instead of patron name

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8693

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com
 QA Contact||m...@kohaaloha.com

--- Comment #3 from Mason James m...@kohaaloha.com ---
(In reply to comment #2)
 Created attachment 11868 [details]
 [SIGNED-OFF] Bug 8693 - Sort biblio checkout history by checkout date
 instead of patron name
 
 Adding a default sort on checkout date.
 
 Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com

patch looks good, passing QA…

$ koha-qa.pl  

testing 1 commit(s) (applied to commit ce03893)
 * 9394921 Bug 8693 - Sort biblio checkout history by checkout date instead 
  koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt

* koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.ttOK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 QA Contact||m...@kohaaloha.com

--- Comment #11 from Mason James m...@kohaaloha.com ---
(In reply to comment #8)
  Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com
  Signed-off-by: Chris Cormack chr...@catalyst.net.nz

patch looks good, passing QA…

$ koha-qa.pl  -c 2

testing 2 commit(s) (applied to commit ce03893)
 * f0af280 Bug 8210: add links to authorities in normal mode headings
  C4/Biblio.pm
  koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt

 * 2a60d49 Bug 8210: add links to authorities to headings in OPAC
  koha-tmpl/opac-tmpl/prog/en/css/opac.css
  koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl
  koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl

* C4/Biblio.pm OK
* koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt   OK
* koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl   OK
* koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl  OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4321] C4::Biblio::GetBiblio is badly coded

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4321

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com
 QA Contact|koha-b...@lists.koha-commun |m...@kohaaloha.com
   |ity.org |

--- Comment #5 from Mason James m...@kohaaloha.com ---
(In reply to comment #4)
 Created attachment 11849 [details]
 Bug 4321: clean C4::Biblio::GetBiblio and uses
 
 Signed-off-by: Kyle M Hall k...@bywatersolutions.com
 Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

nice patch!, passing QA…

$ koha-qa.pl  

testing 1 commit(s) (applied to commit 2a60d49)
 * fb741a8 Bug 4321: clean C4::Biblio::GetBiblio and uses
  C4/Biblio.pm
  C4/ILSDI/Services.pm
  C4/ImportBatch.pm
  C4/Serials.pm
  catalogue/imageviewer.pl
  catalogue/issuehistory.pl
  opac/opac-imageviewer.pl

* C4/Biblio.pm OK
* C4/ILSDI/Services.pm OK
* C4/ImportBatch.pmOK
* C4/Serials.pmOK
* catalogue/imageviewer.pl OK
* catalogue/issuehistory.plOK
* opac/opac-imageviewer.pl OK

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8709] Subfield 0 does not show in MARC detail in intranet

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8709

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com
 QA Contact||m...@kohaaloha.com

--- Comment #3 from Mason James m...@kohaaloha.com ---
(In reply to comment #2)
 Created attachment 11935 [details]
 Bug 8709: Subfield 0 does not show in MARC detail in intranet
 
 Signed-off-by: Chris Cormack chr...@catalyst.net.nz

patch looks good, passing QA…

$ koha-qa.pl  

testing 1 commit(s) (applied to commit 2a60d49)
 * 058b2c6 Bug 8709: Subfield 0 does not show in MARC detail in intranet
  authorities/detail-biblio-search.pl
  authorities/detail.pl
  catalogue/MARCdetail.pl
  opac/opac-authoritiesdetail.pl

* authorities/detail-biblio-search.pl  OK
* authorities/detail.plOK
* catalogue/MARCdetail.pl  OK
* opac/opac-authoritiesdetail.pl   OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8429] Unnecessary use of Exporter in SIP/ILS objects

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8429

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com
 QA Contact||m...@kohaaloha.com

--- Comment #3 from Mason James m...@kohaaloha.com ---
 Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

nice patch!, passing QA…

$ koha-qa.pl  

testing 1 commit(s) (applied to commit 2a60d49)
 * 3e771fc Bug 8429: Remove unnecessary use of Exporter from SIP/ILS
  C4/SIP/ILS/Item.pm
  C4/SIP/ILS/Patron.pm
  C4/SIP/ILS/Transaction/Checkin.pm
  C4/SIP/ILS/Transaction/Checkout.pm
  C4/SIP/ILS/Transaction/FeePayment.pm
  C4/SIP/ILS/Transaction/Hold.pm
  C4/SIP/ILS/Transaction/Renew.pm
  C4/SIP/ILS/Transaction/RenewAll.pm

* C4/SIP/ILS/Item.pm   OK
* C4/SIP/ILS/Patron.pm OK
* C4/SIP/ILS/Transaction/Checkin.pmOK
* C4/SIP/ILS/Transaction/Checkout.pm   OK
* C4/SIP/ILS/Transaction/FeePayment.pm OK
* C4/SIP/ILS/Transaction/Hold.pm   OK
* C4/SIP/ILS/Transaction/Renew.pm  OK
* C4/SIP/ILS/Transaction/RenewAll.pm   OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com
 QA Contact||m...@kohaaloha.com

--- Comment #6 from Mason James m...@kohaaloha.com ---
 Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

$ koha-qa.pl  

patch looks good, passing QA…

testing 1 commit(s) (applied to commit 2a60d49)
 * 551c673 Bug 8336 Support Sip Renewal Transaction
  C4/SIP/ILS.pm
  C4/SIP/ILS/Transaction/Renew.pm
  C4/SIP/ILS/Transaction/RenewAll.pm
  C4/SIP/Sip/MsgType.pm

* C4/SIP/ILS.pmOK
* C4/SIP/ILS/Transaction/Renew.pm  OK
* C4/SIP/ILS/Transaction/RenewAll.pm   OK
* C4/SIP/Sip/MsgType.pmOK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8717] Wrong subscription notes are showing in catalogue detail view of serials in staff client

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com
 QA Contact||m...@kohaaloha.com

--- Comment #7 from Mason James m...@kohaaloha.com ---
 Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

patch looks good, passing QA…

$ koha-qa.pl  

testing 1 commit(s) (applied to commit 2a60d49)
 * 1685fe5 Bug 8717 - Wrong subscription notes are showing in catalogue deta
  catalogue/detail.pl

* catalogue/detail.pl  OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8774] make a deb package of Koha::Contrib::Tamil::IndexerDaemon

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8774

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com ---
And for 8773

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Depends on||8774

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8774] make a deb package of Koha::Contrib::Tamil::IndexerDaemon

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8774

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Blocks||8773

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5357] Subscription search and displays

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #25 from Mason James m...@kohaaloha.com ---
(In reply to comment #24)
 (In reply to comment #22)
  I noticed that the new serials-search.tt file is using 2 spaces for
  identation. Maybe we should fix that too?
 
 Hi Katrin,
 I think there is no coding guidelines for that in the wiki page.
 For the tt files, if we choose 4 spaces, after the 4 mandatory div (div
 id=doc3 class=yui-t2div id=bddiv id=yui-maindiv
 class=yui-b), we write each line with 12 spaces. After 3 or 4 blocks, we
 have a indentation of 24-28 spaces. It's why I prefer to choose only 2
 spaces.

yes, i completely agree Jonathan! :)

lets remember to discuss this sometime on the koha-lists

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5357] Subscription search and displays

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 QA Contact|koha-b...@lists.koha-commun |m...@kohaaloha.com
   |ity.org |

--- Comment #26 from Mason James m...@kohaaloha.com ---
 Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

patches looks good, passing QA…

$ koha-qa.pl  -c 2 

testing 2 commit(s) (applied to commit 2a60d49)
 * 02e2c00 Bug 5357: Follow-up - layout and EAN search
  koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
  serials/serials-search.pl

 * 3f31617 Bug 5357: Adds a new page for searching subscriptions
  C4/Serials.pm
  koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
  koha-tmpl/intranet-tmpl/prog/en/includes/serials-search.inc
  koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt
  koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt
  koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
  serials/serials-home.pl
  serials/serials-search.pl

* serials/serials-search.plOK
* C4/Serials.pmOK
* serials/serials-home.pl  OK
* koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.ttOK
* koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.incOK
* koha-tmpl/intranet-tmpl/prog/en/includes/serials-search.inc  OK
* koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt OK
* koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt  OK

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3782] delivered z39.50 targets wrong for NY Public Library and NY University Library

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3782

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com
 QA Contact||m...@kohaaloha.com

--- Comment #15 from Mason James m...@kohaaloha.com ---
(In reply to comment #14)
 Created attachment 11758 [details]
 Bug 3782: Remove broken z39.50 targets from sample files
 
 Removes NYPL and NYU from the list of sample z39.50 servers, because
 they don't work or only work inconsistently.
 
 Signed-off-by: Chris Cormack chr...@catalyst.net.nz

nice patch!, passing QA…

$ koha-qa.pl  

testing 1 commit(s) (applied to commit 3f31617)
 * 73857bf Bug 3782: Remove broken z39.50 targets from sample files
  installer/data/mysql/de-DE/optional/sample_z3950_servers.sql
  installer/data/mysql/en/optional/sample_z3950_servers.sql
  installer/data/mysql/es-ES/optional/sample_z3950_servers.sql
  installer/data/mysql/pl-PL/optional/sample_z3950_servers.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com
 QA Contact|koha.sek...@gmail.com   |m...@kohaaloha.com

--- Comment #37 from Mason James m...@kohaaloha.com ---
(In reply to comment #36)
 Created attachment 12254 [details]
 [SIGNED-OFF] Bug 7401 - Shelving Location facet
 Signed-off-by: Owen Leonard oleon...@myacpl.org

patch looks good, passing QA…

$ koha-qa.pl  

testing 1 commit(s) (applied to commit 3f31617)
 * 663f5e5 Bug 7401 - Shelving Location facet
  C4/Branch.pm
  C4/Koha.pm
  C4/Search.pm
  koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc
  koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc
  opac/opac-search.pl

* C4/Branch.pm OK
* C4/Koha.pm   OK
* C4/Search.pm OK
* opac/opac-search.pl  OK
* koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc  OK
* koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7993] saved report with hierarchies

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m...@kohaaloha.com
 QA Contact|koha.sek...@gmail.com   |m...@kohaaloha.com

--- Comment #20 from Mason James m...@kohaaloha.com ---
(In reply to comment #19)
 Created attachment 12126 [details]
 Bug 7993: Save reports with Group/Subgroup hierarchy
  Signed-off-by: Delaye Stephane stephane.del...@biblibre.com

patch looks good, passing QA…

$ koha-qa.pl  

testing 1 commit(s) (applied to commit 3f31617)
 * 4d90348 Bug 7993: Save reports with Group/Subgroup hierarchy
  C4/Reports/Guided.pm
  admin/authorised_values.pl
  installer/data/mysql/kohastructure.sql
  installer/data/mysql/updatedatabase.pl
  koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt
  koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
  misc/cronjobs/runreport.pl
  opac/svc/report
  reports/dictionary.pl
  reports/guided_reports.pl
  svc/report

* C4/Reports/Guided.pm OK
* admin/authorised_values.pl   OK
* installer/data/mysql/updatedatabase.pl   OK
* misc/cronjobs/runreport.pl   OK
* reports/dictionary.plOK
* reports/guided_reports.plOK
* koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.ttOK
* koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt  OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5339] Parcel closing in acq

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

 CC|srd...@catalyst.net.nz  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8749] Missing Ubuntu library files in ubuntu.packages and ubuntu.12.04.packages

2012-09-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8749

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
After looking at the 3.8.x repo, I realized this was only a problem with the
3.8.4 release. It should be corrected in the 3.8.5 release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/