[Koha-bugs] [Bug 9192] UNIMARC_sync_date_created_with_marc_biblio.pl field creation

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9192] UNIMARC_sync_date_created_with_marc_biblio.pl field creation

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #14281|0   |1
is obsolete||

--- Comment #4 from Mason James m...@kohaaloha.com ---
Created attachment 14939
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14939action=edit
Bug 9192: UNIMARC_sync_date_created_with_marc_biblio.pl field creation

Signed-off-by: Chris Cormack chr...@catalyst.net.nz
Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9192] UNIMARC_sync_date_created_with_marc_biblio.pl field creation

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #5 from Mason James m...@kohaaloha.com ---
(In reply to comment #4)
 Created attachment 14939 [details]
 Bug 9192: UNIMARC_sync_date_created_with_marc_biblio.pl field creation
 
 Signed-off-by: Chris Cormack chr...@catalyst.net.nz
 Signed-off-by: Mason James m...@kohaaloha.com

testing 1 commit(s) (applied to f8686e9 'Bug 9116: Remove some useless tmp
var')

passing QA.. patch looks good

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9201] OAI-PMH mapping value cannot be 0

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9201

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9201] OAI-PMH mapping value cannot be 0

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9201

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #14271|0   |1
is obsolete||

--- Comment #5 from Mason James m...@kohaaloha.com ---
Created attachment 14940
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14940action=edit
Bug 9201 OAI-PMH mapping value cannot be 0

Allow the value of a OAI set mapping to be 0 / empty. Delete the mapping if
field or subfield are empty.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Now it is possible to add a value == 0 or an empty string.
Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9201] OAI-PMH mapping value cannot be 0

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9201

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #6 from Mason James m...@kohaaloha.com ---
(In reply to comment #5)
 Created attachment 14940 [details]
 Bug 9201 OAI-PMH mapping value cannot be 0
 
 Allow the value of a OAI set mapping to be 0 / empty. Delete the mapping if
 field or subfield are empty.
 
 Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
 Now it is possible to add a value == 0 or an empty string.
 Signed-off-by: Mason James m...@kohaaloha.com

passing QA, works as expected...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9068] Babelthèque: New podcasts area

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9068

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #13418|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14941
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14941action=edit
Bug 9068: Babelthèque: Add podcasts

This patch is applied on one of our server. You can see the result on this
page:
http://catalogue.master33-dev.biblibre.com/cgi-bin/koha/opac-detail.pl?biblionumber=211739

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7495] Tax calculations problem for new orders.

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7495

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Assignee|henridam...@koha-fr.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9505] New: acqui/invoices.pl contains an unnecessary loop

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505

Bug ID: 9505
   Summary: acqui/invoices.pl contains an unnecessary loop
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: colin.campb...@ptfs-europe.com

Script retrieves a list of invoices it loops through the list to produce a new
bu identical list. While the execution time wasted is trivial it obscures the
purpose of the code

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe.
   |ity.org |com

--- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com ---
Created attachment 14942
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14942action=edit
Proposed Patch

Testing: Should not change functionality of searching invoices and displaying
results. Refactoring is for readability and maintainability of code

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #14942|0   |1
is obsolete||

--- Comment #2 from Colin Campbell colin.campb...@ptfs-europe.com ---
Created attachment 14943
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14943action=edit
Revised patch

The commit message mentioned cleaning the name space but that change wasnt
included in the patch. Amended accordingly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9506] New: Values are false in the generated pdf for basketgroups

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506

Bug ID: 9506
   Summary: Values are false in the generated pdf for basketgroups
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@biblibre.com

Due to the multi VAT development (Bug 5335), values are not well calculated in
the pdf generated by the basketgroup print action.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9506] Values are false in the generated pdf for basketgroups

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9506] Values are false in the generated pdf for basketgroups

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14944
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14944action=edit
Bug 9506: FIX GST values for the basketgroup print action

Due to the multi VAT development (Bug 5335), values are not well calculated in
the pdf generated by the basketgroup print action.

Test plan:
- Add one or more basket to a basketgroup.
- Close and print this basketgroup
- Check that different values correspond to values in the basket detail page.

Don't forget to test with different parameters (multiple vat, vendor
include/don't include tax).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9506] Values are false in the generated pdf for basketgroups

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9506] Values are false in the generated pdf for basketgroups

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9506] Values are false in the generated pdf for basketgroups

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||5335

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5335] define VAT/taxes at orderline level, with default value for supplier and list of valid tax rates

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||9506

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8943] Add table sorting to labels

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8943

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #13148|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9075] Show material type and item type on staff detail (with xslt)

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075

--- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to comment #9)
 If the goal is to show the item type on detail pages when item_level_itypes
 is set to biblio, why not simply add that information to the part of the
 page which displays biblio-level information? I don't like that this patch
 puts itemtype information into the display of holdings. If item_level_itypes
 is set to biblio then itemtype should not be displayed with item-specific
 data.
Can understand your point of view. But note that as mentioned earlier, the 942c
at biblio level does not prevent items from having a different value in 952y.
So the information is item-specific as holding information is as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9075] Show material type and item type on staff detail (with xslt)

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
In our union catalog setting we use a standard value for the 942$c and don't
want that to show up somewhere as it does not give any information about the
record. I think as the value currently has not a lot of meaning/importance if
you use item level itypes it might be similar for other institutions. Could
this be something that can be controlled by a pref?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14745|0   |1
is obsolete||

--- Comment #33 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14945
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14945action=edit
[SIGNED-OFF] Bug 7241: circulation action logs record biblionumber instead of
item number

Issue log and and circulation logs are incorrectly recording biblionumber
instead of item number, creating incorrect logs.
This patch corrects this, and modifies the action_logs table in two ways:
- the timestamp is not updated anymore with UPDATES (but still automatically
filled when INSERTing)
- to partially correct the broken logs, the log history is filled with the
first found item for each biblio

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9268] Scanning in barcode or ISBN in Acquisitions - new order submits the form unexpectedly

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:

This patch works as expected.
It would be great to factorize this code (it appears in 3 tt files).

Marked as Passed QA.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9268] Scanning in barcode or ISBN in Acquisitions - new order submits the form unexpectedly

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |l...@catalyst.net.nz
   |ity.org |
 QA Contact||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9268] Scanning in barcode or ISBN in Acquisitions - new order submits the form unexpectedly

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14328|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14946
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14946action=edit
Bug 9268 - Scanning in barcode or ISBN in Acquisitions - new order submits the
form unexpectedly

To Test:

* Go to Acquisitions - Manage Orders
* Search for a vendor
* Click New Basket.
* Fill required fields
* Press Save.
* Click on From a new (empty) record
* Type in title Private Oz, Author Patterson, James.
* Scan (or type) ISBN - 9781864711875.
* (If not scanning, PRESS ENTER HERE)
* Nothing should happen. Form should not be submitted, no error message should
appear.

Sponsored by: Hauraki District Libraries, New Zealand

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Tested according to test plan in Firefox and Chromium on Ubuntu.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9507] New: In order not to submit a form unexpectedly some code is duplicated

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507

Bug ID: 9507
   Summary: In order not to submit a form unexpectedly some code
is duplicated
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@biblibre.com
CC: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9507] In order not to submit a form unexpectedly some code is duplicated

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9507] In order not to submit a form unexpectedly some code is duplicated

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14947
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14947action=edit
Bug 9507: prevent submit: factorize some code in a js file

This patch factorize code in a js file.

Test plan:
On acqui/neworderempty.pl, acqui/orderreceive.pl and
serials/serials-edit.tt try to scan a barcode (or press enter) on the
form and check that it is not sent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9507] In order not to submit a form unexpectedly some code is duplicated

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9268] Scanning in barcode or ISBN in Acquisitions - new order submits the form unexpectedly

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9268

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||9507

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9507] In order not to submit a form unexpectedly some code is duplicated

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||9268

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9147] OPAC hidden fields are not hidden in ISBD view

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147

--- Comment #6 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Can it be pushed to stable versions ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8733] Adding critic reviews to book pages

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733

--- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #15)

No answer ?

 I cannot test this feature.
 Where is the class 'isbn' used to set the js variable isbn ?
 var isbn = $(.isbn:last).text().split( )[1];
 I don't find any occurrence of this class in the opac detail page.

Finally I understand, the class is added by the webservice.

 Question: What is the key (key=8bf66516232d1b72f3e47df939653e1e) used in the
 url to idreambooks.com ? Is it a good idea to hard code it in the template ?

But I would like to have an answer for these questions before to pass qa this
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9308] logo-koha.png not transparent in ccsr theme.

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9308

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m
 QA Contact||jonathan.dru...@biblibre.co
   ||m

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:
change the logo image for the ccsr theme.
Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9308] logo-koha.png not transparent in ccsr theme.

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9308

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14382|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14948
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14948action=edit
Bug 9308 - logo-koha.png not transparent in ccsr theme

This patch will allow the koha logo to be transparent so you can change the
background color.

To test this please change the background color within the css.

http://bugs.koha-community.org/show_bug.cgi?id=9308
Signed-off-by: Chris Cormack chr...@catalyst.net.nz
Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8990] Jquery UI images missing in OPAC

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8990

--- Comment #2 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to comment #1)
 As far as I know the images are not used in the OPAC. Any reference to the
 images in the default jQueryUI CSS is overridden in opac.css. If this is
 incorrect, can you point out under what circumstances the images should
 appear?

This appears for a library that has an OPAC very customized with JQuery UI.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14180|0   |1
is obsolete||

--- Comment #19 from Elliott Davis elli...@bywatersolutions.com ---
Created attachment 14949
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14949action=edit
[PAssed QA] Bug 9239: Add QueryParser module to Koha

Although the OpenILS::QueryParser class is going to be moved into a
separate CPAN distribution, this hasn't been done yet, and for ease of
testing it makes sense to include the class in Koha for the moment.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Elliott Davis elli...@bywatersolions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14181|0   |1
is obsolete||

--- Comment #20 from Elliott Davis elli...@bywatersolutions.com ---
Created attachment 14950
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14950action=edit
[Passed QA] Bug 9239: Introduce QueryParser driver for PQF

Since the most expressive query language supported by Zebra is PQF, this
patch adds a PQF driver for QueryParser which will translate QueryParser
queries into standard PQF (guided by mappings which have been written to
match Koha's existing Zebra configuration) which can then be sent to
Zebra. This driver, Koha::QueryParser::Driver::PQF(::*) extends the
OpenILS::QueryParser(::*) class(es), so as to preserve maximum
interoperability between the various users of the QueryParser driver.

Initially, search syntax is as follows:
* AND operator: 
* OR operator: ||
* GROUPING operators: ( )

Fields can mostly be searched using the ccl prefixes they have now. The
exception is the various date limits which are searched with a syntax
like this: pubdate(2008)

For sorting, you can simply add #title-sort-az (etc.) to your query.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Elliott Davis elli...@bywatersolions.com
Test Passed successfully after installing missing dep for Test::Deep

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14182|0   |1
is obsolete||

--- Comment #21 from Elliott Davis elli...@bywatersolutions.com ---
Created attachment 14951
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14951action=edit
[Passed QA] Bug 9239: Add syspref to enable QueryParser

In light of the experimental nature of the QueryParser code at this
juncture, it behooves Koha to have the option of disabling QP, at least
for the purpose of comparing results between QP-enabled and QP-disabled
searches. This patch adds a UseQueryParser syspref to do just that. In
cases where the user enables QP without having QP installed, however,
there will be no dramatic failure, and Koha will simply fall back to
using the non-QP search code.

In order to reduce the overhead added by the introduction of QueryParser,
this patch adds a C4::Context-queryparser accessor to a static
QueryParser object which is initialized the first time it is required
and then reset thereafter.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Elliott Davis elli...@bywatersolions.com
Fixed merge conflict in sysprefs.sql and updatedatabase.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14183|0   |1
is obsolete||

--- Comment #22 from Elliott Davis elli...@bywatersolutions.com ---
Created attachment 14952
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14952action=edit
[Passed QA] Bug 9239: Allow the use of QueryParser for all queries

With the inclusion of this patch, all searches will (try) to use
QueryParser for handling queries for both the bibliographic and authority
databases if UseQueryParser is enabled. If QueryParser is unavailable,
UseQueryParser is disabled, or the search uses CCL indexes, the old
search code will be used.

To test:
1) Apply patch.
2) Run the unit test with `prove t/QueryParser.t`
3) Enable the UseQueryParser syspref.
4) Try searches that should return results in the following places:
   * OPAC (simple search)
   * OPAC (advanced search)
   * OPAC (authorities)
   * Staff client (header search)
   * Staff client (advanced search)
   * Staff client (cataloging search)
   * Staff client (authorities)
   * Staff client (importing a batch using a match point)
   * Staff client (searching for an item for adding to a label)
   * Staff client (acquisitions)
   * Staff client (searching for a record to create a serial)
   * ANYWHERE ELSE I HAVE FORGOTTEN
5) Disable the UseQueryParser syspref. Repeat at least some of the
   searches you did above.
6) If all searches worked, sign off.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Elliott Davis elli...@bywatersolions.com
Searching still works as expected for variuos places.  QueryParser syspref
seemed to be enabled by default

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14847|0   |1
is obsolete||

--- Comment #23 from Elliott Davis elli...@bywatersolutions.com ---
Created attachment 14953
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14953action=edit
[Signed off] Bug 9239 follow-up: POD and perlcritic fixes

There were several perlcritic violations for returning explicit undef,
and splitting up the various driver classes resulted in POD compliance
errors, where the POD was starting with head2 rather than head1. This
patch fixes those errors (but has no functional impact).

Signed-off-by: Elliott Davis elli...@bywatersolions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9508] New: the dateformat variable is not standardize in template files

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9508

Bug ID: 9508
   Summary: the dateformat variable is not standardize in template
files
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: jonathan.dru...@biblibre.com

It would be great to use the following test everywhere
  if ( dateformat == metric )
instead of
  if ( dateformat_metric )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9508] the dateformat variable is not standardized in template files

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9508

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

Summary|the dateformat variable is  |the dateformat variable is
   |not standardize in template |not standardized in
   |files   |template files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239

Elliott Davis elli...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||elli...@bywatersolutions.co
   ||m

--- Comment #24 from Elliott Davis elli...@bywatersolutions.com ---
Applied to fix a couple of merge issues.  Appears to work as advertised. 
Provided test plan passes.  I didn't experience the issues that katrin did but
I already had those fields in my koha-conf xml file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9508] the dateformat variable is not standardized in template files

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9508

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14954
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14954action=edit
Bug 9508: Standardize the dateformat value from C4::Auth

- the dateformat value is send to all templates (from
  C4::Auth::get_template_and_user)
- remove all assignment of dateformat in all .pl files

- Remove all occurrences (those I found!) of dateformat_*
From now the only way to get the date format is a string comparaison
(dateformat == metric)

Checked with the command:
  git grep \(dateformat_us\|dateformat_metric\|dateformat_iso\) | grep
  -v translator

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9108] Add uk/euro date sort filter to pages which require it

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9108

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||9508

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9508] the dateformat variable is not standardized in template files

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9508

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Medium patch
 Depends on||9108

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9508] the dateformat variable is not standardized in template files

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9508

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |jonathan.dru...@biblibre.co
   ||m

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Checked with 

git grep
\(dateformat_us\|dateformat_metric\|dateformat_iso|\dateformatmetric|\dateformatus|\dateformatiso\)
| grep -v translator

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8733] Adding critic reviews to book pages

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733

--- Comment #18 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #17)
 (In reply to comment #15)
 
 No answer ?
 
  I cannot test this feature.
  Where is the class 'isbn' used to set the js variable isbn ?
  var isbn = $(.isbn:last).text().split( )[1];
  I don't find any occurrence of this class in the opac detail page.
 
 Finally I understand, the class is added by the webservice.
 
  Question: What is the key (key=8bf66516232d1b72f3e47df939653e1e) used in the
  url to idreambooks.com ? Is it a good idea to hard code it in the template ?
 
 But I would like to have an answer for these questions before to pass qa
 this patch.

Sorry, I didn't see the question. The key was assigned by idreambooks.com for
Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6473] Test bug for Git-bz

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

--- Comment #66 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 14955
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14955action=edit
9105: Followup for closing Zoom connections

Housekeeping: close the results sets and connections from Z3950 searches.
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6473] Test bug for Git-bz

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #14955|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9431] Use DataTables on Patron Category Administration page

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9431

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9431] Use DataTables on Patron Category Administration page

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9431

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14915|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14956
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14956action=edit
Bug 9431 [Revised] Use DataTables on Patron Category Administration page

Replace the tablesorter plugin with the DataTables plugin on the
patron category administration page. Structural changes were made to the
table markup for validity and to deal with a DataTables bug which
prevents it from properly parsing a th with a colspan.

To test, open the Patron Category Administration page (Administration -
Patron types and categories). Confirm that table sorting works
correctly.

Revision adds a natural sort plugin to the main datatables
configuration JavaScript file to enable sorting of columns like those in
this table which include mixed numeric and text data. Allows correct
numeric sorting of data like 0 years, 1 years, 2 years, 18 years, etc.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Amended patch: Add the aLengthMenu values.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9088] Default values for fund and item type on neworderempty form

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #13460|0   |1
is obsolete||

--- Comment #5 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 14957
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14957action=edit
9088 Default values for fund and item type on neworderempty form

Adds a syspref AcqNewOrderEmptyDefaults containing default codes for item type
and fund code.
The neworderempty form checks these values for a new empty record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9088] Default values for fund and item type on neworderempty form

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9088

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #13461|0   |1
is obsolete||

--- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 14958
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14958action=edit
9088: Default values for fund and item type on neworderempty form (dbrev)

Adds pref to database for install and upgrade.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   Priority|P5 - low|P3

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239

--- Comment #25 from Elliott Davis elli...@bywatersolutions.com ---
I went back and removed a line from my conf file that I had from testing
previously (which is why it worked for me initially) and re-ran make and got
the same error as KF.  

Apologies for the mis-informed test.  I think there should be a follow up to
add this line to make but shouldn't be a reason to fail the test.

(In reply to comment #24)
 Applied to fix a couple of merge issues.  Appears to work as advertised. 
 Provided test plan passes.  I didn't experience the issues that katrin did
 but I already had those fields in my koha-conf xml file.

--- Comment #26 from Elliott Davis elli...@bywatersolutions.com ---
I went back and removed a line from my conf file that I had from testing
previously (which is why it worked for me initially) and re-ran make and got
the same error as KF.  

Apologies for the mis-informed test.  I think there should be a follow up to
add this line to make but shouldn't be a reason to fail the test.

(In reply to comment #24)
 Applied to fix a couple of merge issues.  Appears to work as advertised. 
 Provided test plan passes.  I didn't experience the issues that katrin did
 but I already had those fields in my koha-conf xml file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239

--- Comment #25 from Elliott Davis elli...@bywatersolutions.com ---
I went back and removed a line from my conf file that I had from testing
previously (which is why it worked for me initially) and re-ran make and got
the same error as KF.  

Apologies for the mis-informed test.  I think there should be a follow up to
add this line to make but shouldn't be a reason to fail the test.

(In reply to comment #24)
 Applied to fix a couple of merge issues.  Appears to work as advertised. 
 Provided test plan passes.  I didn't experience the issues that katrin did
 but I already had those fields in my koha-conf xml file.

--- Comment #26 from Elliott Davis elli...@bywatersolutions.com ---
I went back and removed a line from my conf file that I had from testing
previously (which is why it worked for me initially) and re-ran make and got
the same error as KF.  

Apologies for the mis-informed test.  I think there should be a follow up to
add this line to make but shouldn't be a reason to fail the test.

(In reply to comment #24)
 Applied to fix a couple of merge issues.  Appears to work as advertised. 
 Provided test plan passes.  I didn't experience the issues that katrin did
 but I already had those fields in my koha-conf xml file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com ---
Kyle: What do you think about this last patch? Do you agree with it?

Fridolyn: Why do you remove the circulate_remaining_permissions permission?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5790] Deleting a biblio should alert/fail if there are existent subscriptions and holds

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5790

--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14959
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14959action=edit
Bug 5790 - Prevent deletion of records with holds

Test Plan:
1) Apply patch
2) Create a record
3) Create an item for the record
3) Place a hold on the bib
4) Attempt to 'Delete all items', you should recieve
   an error message stating to delete all holds before
   deleting all items.

Also, it is possible to get into a situation where a record has
holds but no items. In this situation, it is not possible to
view/delete the holds without adding an item back to the record.
In this case, attempting to delete the bib causes a warning, but
does not prevent deletion.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5790] Deleting a biblio should alert/fail if there are existent subscriptions and holds

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5790

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
   Assignee|ch...@bigballofwax.co.nz|k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5790] Deleting a biblio should alert/fail if there are existent subscriptions and holds

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5790

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9265] Switch to HTML5 doctype in OPAC and staff client

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9265

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #14078|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9509] New: batchMod.pl does not ensure each barcode is unique

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9509

Bug ID: 9509
   Summary: batchMod.pl does not ensure each barcode is unique
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com

batchMod.pl does not ensure each barcode is unique. This means that if a
barcode is list twice, the actions are applied to it twice. This is not a
problem, unless the modification is to batch delete items, in which case the
batch deletion fails at the first duplicate barcode.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9509] batchMod.pl does not ensure each barcode is unique

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9509

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9509] batchMod.pl does not ensure each barcode is unique

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9509

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8212] Omnibus bug report for C P authority developments

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8212

Bug 8212 depends on bug 7417, which changed state.

Bug 7417 Summary: Include alternate forms from authorities in bibliographic 
searches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417

Elaine Bradtke e...@efdss.org changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||e...@efdss.org
 Resolution|FIXED   |---

--- Comment #56 from Elaine Bradtke e...@efdss.org ---
Tested this in our installation of 3.10.0 and 3.10.1
Three comments:
1) In both cases, despite having the box ticked for AuthorityFile in Intranet -
(Home › Administration › Did you mean?) It does not work in the staff
interface.  Whereas in the OPAC there's a bar above the search results with
suggestions, nothing appears in the staff interface.

1)Also in both cases, it appears to be pulling results from all fields in the
authority records. For example the term Chanties - It suggests the correct
term: Shanties, but also the name of an author who has a machine generated
authority record with the title of the book: Old sea chanties.
-Would it be possible to restrict the search to 4XX fields?

3) An unexpected behavior -  
If you click on a suggested term that does not have any biblios attached it
runs a search on the authority number.  This in turn returns suggested terms
based on that authority number as a stem.  So if I click on a suggestion with
authority no. 271 (but there are no biblios linked to this authority) it comes
back with suggestions for authority number 2715 and 2716
We uploaded all our authority files first and are adding the biblios in
batches, which is why we have authority records not yet linked to biblios.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #13006|0   |1
is obsolete||

--- Comment #18 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14961
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14961action=edit
Bug 7639 - system preference to forgive fines on lost items

Forgive fine when an item is set to lost status, fines are forgiven only when
syspref ForgiveFineWhenLost is set to yes. Item can be set to lost status from:
catalogue/moredetail.pl
cataloguing/additem.pl
tools/batchMod.pl
misc/cronjobs/longoverdue.pl

Changed sub C4::Circulation::LostItem to forgive fines on the item
depending on the value of syspref ForgiveFineWhenLost. This sub is currently
used to return an item and charge a replacement cost.

Also added a new syspref in C4::Circulation::LostItem -
ChargeReplFeeWhenLost. Replacement fee will now be charged only if this syspref
is set to yes.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #13007|0   |1
is obsolete||

--- Comment #19 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14962
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14962action=edit
Bug 7639 - system preference to forgive fines on lost items - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 CC||gmcha...@gmail.com
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #14943|0   |1
is obsolete||

--- Comment #3 from Galen Charlton gmcha...@gmail.com ---
Created attachment 14963
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14963action=edit
bug 9505 refactor loops in invoices.pl

- Remove an unnecessary loop where output just
  recreated input.
- Remove unnecessary temp variables that obscure code purpose.
- Call the variable containing invoices, invoices
  rather than anonymous and ambiguous results
  reflect namechange in template.
- Lists are passed to template as array refs;
  declare them as scalars as that is how we use them.
- No need to introduce the whole namespace of some C4
  modules for 1 routine.

Test plan:

Note that this patch should not change any visible behavior.

[1] Open the invoice search page.
[2] Verify that the list of suppliers in the drop-down
on the search form is complete.
[3] Verify that the list of libraries in the drop-down
on the saerch form is complete.
[4] Perform a search.  Verify that the list of invoices
is correct.

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #57 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #56)
 Tested this in our installation of 3.10.0 and 3.10.1

Bug 7417 (this bug) is for including see-from headings directly in search
results, and has nothing to do with the Did you mean? suggestions, which are
described in 8209. In order to use the feature described on this bug, you can
enable the IncludeSeeFromInSearches system preference and reindex.

 Three comments:
 1) In both cases, despite having the box ticked for AuthorityFile in
 Intranet - (Home › Administration › Did you mean?) It does not work in the
 staff interface.  Whereas in the OPAC there's a bar above the search results
 with suggestions, nothing appears in the staff interface.

Did you mean is not yet implemented for the intranet (from the administration
page: NOTE: Did you mean? functionality is not yet enabled on the staff
client).

 1)Also in both cases, it appears to be pulling results from all fields in
 the authority records. For example the term Chanties - It suggests the
 correct term: Shanties, but also the name of an author who has a machine
 generated authority record with the title of the book: Old sea chanties.
 -Would it be possible to restrict the search to 4XX fields?

It would be possible to write an additional Did you mean plugin to do this if
you so desired.

 3) An unexpected behavior -  
 If you click on a suggested term that does not have any biblios attached it
 runs a search on the authority number.  This in turn returns suggested terms
 based on that authority number as a stem.  So if I click on a suggestion
 with authority no. 271 (but there are no biblios linked to this authority)
 it comes back with suggestions for authority number 2715 and 2716
 We uploaded all our authority files first and are adding the biblios in
 batches, which is why we have authority records not yet linked to biblios.

The problem here is that checking prior to the search whether a particular
authority record is used would make searches so slow as to be unusable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8212] Omnibus bug report for C P authority developments

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8212

Bug 8212 depends on bug 7417, which changed state.

Bug 7417 Summary: Include alternate forms from authorities in bibliographic 
searches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9510] New: holiday exceptions are being ignored

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9510

Bug ID: 9510
   Summary: holiday exceptions are being ignored
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: 3.8
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Holidays
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: me...@bywatersolutions.com

In 3.8, holiday exceptions are still being ignored.

What's happening is that when calculating the due date and skipping the days
that the library is closed, the holiday exceptions are being ignored and
skipped, even though the library is open.

To reproduce:
1) Set a repeating holiday.  Closed on Sats and Suns, for example.
2) Make an exception.  We're open this Saturday (but closed all of the other
ones).
3) Set usedaysmode sys pref to skip all days the library is closed.
4) Set renewalbaseperiod to use the current date.
5) Check out some items.  See if due date is correctly calculated.
6) Renew some items.  See if due date is correctly calculated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9511] New: DOM indexing problem

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9511

Bug ID: 9511
   Summary: DOM indexing problem
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: 3.8
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: me...@bywatersolutions.com

On sites using DOM, when you delete a bib record, it doesn't go away
immediately. When the fast indexer runs, the edit appeared in the search
results, but the deleted record did not go away. It can take 3 or 4 days but
does eventually disappear.  

This also causes problems when trying to import records because it's matching
things that they've already deleted that really should be gone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9511] DOM indexing problem

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9511

--- Comment #1 from Galen Charlton gmcha...@gmail.com ---
Could you add the exact cronjob invocation to this bug?  I tried deleting bibs
in a tiny test database that's using DOM indexing, both with and without the
patch for bug 9496, and the records were deleted from the Zebra index when I
ran rebuild_zebra.pl -b -z or rebuild_zebra.pl -b -x -z.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9511] DOM indexing problem

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9511

Larry Baerveldt la...@bywatersolutions.com changed:

   What|Removed |Added

 CC||la...@bywatersolutions.com

--- Comment #2 from Larry Baerveldt la...@bywatersolutions.com ---
Galen,

What we typically use on all sites is 'rebuild_zebra.pl -x -b -z'.

- Larry

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9512] New: Did you mean searches authority number as a stem, returns false positives

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9512

Bug ID: 9512
   Summary: Did you mean searches authority number as a stem,
returns false positives
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: 3.10
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: e...@efdss.org
CC: jcam...@cpbibliography.com

If you click on a suggested term that has no biblios attached to it, it runs a
search on the authority number as a stem.  This returns suggested terms based
on that start with the same digits.  Example:  Suggested term has authority no.
271 (but there are no biblios linked to this authority. Clicking on this term
returns suggestions for terms with authority numbers 2715 and 2716, completely
unrelated to the original term.

Would it be possible to  have it search the authority number exactly, instead
of using it as a stem? If nothing is found, a statement like:   'no records use
this term' rather than suggesting inappropriate alternatives based on a
truncated authority number.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9513] New: Did you mean? Option to search only 4XX in authority records

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9513

Bug ID: 9513
   Summary: Did you mean? Option to search only 4XX in authority
records
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: 3.10
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: e...@efdss.org

Currently the Did you mean? searches all fields in the authority records. 
This can produce confusing results
For example the term Chanties - It suggests the correct term: Shanties, but
also the name of an author whose authority record mentions the title of the
book: Old sea chanties. 

-Would it be possible to restrict the search to 4XX fields as an option?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9514] New: 'and' in subject searches causes a problem

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9514

Bug ID: 9514
   Summary: 'and' in subject searches causes a problem
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: 3.8
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P1 - high
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: neng...@gmail.com

I looked in to this a bit and it looks like it's a problem with the combo of
the word 'and' and using the complete-subfield:

/cgi-bin/koha/opac-search.pl?q=su,complete-subfield:{Rites%20and%20ceremonies.} 

gets no results

but 

/cgi-bin/koha/opac-search.pl?q=su,complete-subfield:{Ritual.} 

gets results

and so does 

/cgi-bin/koha/opac-search.pl?idx=kwq=opening%20doors%20wondersort_by=pubdate_dsclimit=su-to:Rites%20and%20ceremonies.


This is a 3.8 and master problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9515] New: A browser-based (javascript) non-Latin IME for Koha

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9515

Bug ID: 9515
   Summary: A browser-based (javascript) non-Latin IME for Koha
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: indr...@gmail.com
CC: frede...@tamil.fr

Created attachment 14964
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14964action=edit
Screenshot of JQuery IME working with Koha v3.10

Indian installations with large holdings in vernacular languages (India has 22
recognized official languages) need input method (IME) to input and query
data in the Indic languages. Largely, the user preference is for a
browser-based IME.

I've used the JQuery IME[1] from Wikimedia Language Engineering team with Koha
v3.10 and found it to be suitably working (see scrnshot).

I would like to see the IME included into future Koha versions. The plugin is
dual-licensed GPLv2+ and MIT and should pose no problem in license
compatibility with Koha.

How to take this forward?


Reference:

[1] https://github.com/wikimedia/jquery.ime/ - jQuery Input method editor
library supporting 50+ input methods across several languages. This is the
jQuery version of the input method tool used in Wikimedia projects, a.k.a.
Narayam. These input methods are well tested and contributed by large Wikimedia
community. This project is a Wikimedia foundation initiative to provide
language technology tools to wider audience outside the Wikimedia universe

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9516] New: Item Availability/Data missing from OPAC tag search

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9516

Bug ID: 9516
   Summary: Item Availability/Data missing from OPAC tag search
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: dc...@prosentient.com.au

For example:

.../cgi-bin/koha/opac-search.pl?tag=Importantq=Important

Availability: No items available: appears for each result, even if there
actually are items available.

This is because the raw marc is being retrieved straight from the database
without having any item data embedded in it...

If you do a regular search, you will get the correct item availability. I
assume this is because Koha adds the item information to the MARCXML before
passing it to Zebra which returns the item data inside the raw MARC...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5790] Deleting a biblio should alert/fail if there are existent subscriptions and holds

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5790

Liz Rea (CatalystIT) l...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5790] Deleting a biblio should alert/fail if there are existent subscriptions and holds

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5790

--- Comment #11 from Liz Rea (CatalystIT) l...@catalyst.net.nz ---
Created attachment 14965
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14965action=edit
Bug 5790 - Prevent deletion of records with holds

Test Plan:
1) Apply patch
2) Create a record
3) Create an item for the record
3) Place a hold on the bib
4) Attempt to 'Delete all items', you should recieve
   an error message stating to delete all holds before
   deleting all items.

Also, it is possible to get into a situation where a record has
holds but no items. In this situation, it is not possible to
view/delete the holds without adding an item back to the record.
In this case, attempting to delete the bib causes a warning, but
does not prevent deletion.

Signed-off-by: Liz Rea l...@catalyst.net.nz
Tested all scenarios - works in all instances. Thanks, this is a longstanding
bug.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5790] Deleting a biblio should alert/fail if there are existent subscriptions and holds

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5790

Liz Rea (CatalystIT) l...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #14959|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5333] Undefined value stops import from z39.50

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5333

Elaine Bradtke e...@efdss.org changed:

   What|Removed |Added

 CC||e...@efdss.org

--- Comment #3 from Elaine Bradtke e...@efdss.org ---
Also in 3.10.0
 set the sys pref z3950NormalizeAuthor z3950AuthorAuthFields to 'Don't copy'
fixed it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9384] With OPACPatronDetails set to 'don't allow' a form shows

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9384

Liz Rea (CatalystIT) l...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9384] With OPACPatronDetails set to 'don't allow' a form shows

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9384

Liz Rea (CatalystIT) l...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #14597|0   |1
is obsolete||

--- Comment #4 from Liz Rea (CatalystIT) l...@catalyst.net.nz ---
Created attachment 14966
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14966action=edit
Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows

Because of the new feature to allow patrons to register for a card
via the opac when you have OPACPatronDetails  set to 'don't allow'
it still shows a from for the patron details, but you can't edit the form.
It would be better if this showed as a text display like it used to so
that it's not confusing to patrons ( even with the note about seeing
the librarian ).

Test Plan:
1) Apply patch
2) Log into OPAC
3) Set OPACPatronDetails to Allow
4) Refresh the page and click my personal details
5) Verify you get the editable form ( opac-memberentry.pl )
6) Set OPACPatronDetails to Don't allow
7) Refresh the page and click my personal details again
8) Verify you get the non-editable non-form details page ( opac-userupdate.pl )

Signed-off-by: Liz Rea l...@catalyst.net.nz
Passes tests, works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9516] Item Availability/Data missing from OPAC tag search

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9516

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |dc...@prosentient.com.au

--- Comment #1 from David Cook dc...@prosentient.com.au ---
Created attachment 14967
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14967action=edit
Bug 9516 - Item Availability/Data missing from OPAC tag search

Currently, an OPAC search using the tag and q query strings will have
results with no item data. Next to Availability, it will say No items
available: (N.B. without reference to why the items are unavailable, like
Checked out, In transit, etc.).

The reason is that the opac-search.pl script is just pulling the marc blob
straight from the database without embedding any item data. I've used the
GetMarcBiblio sub with the embed item data option, and then converted the
resulting Marc object to us marc using the as_usmarc method.

---

To test:
(Before patch)
1) Click on Tag cloud
2) Click on any of the tags
3) Note that all results say Availability: No items available:
4) Click on any result and note the actual status of the items for that
biblio record

(Apply patch)
1) Click on Tag cloud
2) Click on  any of the tags
3) Note that the results actually have the correct item availability next
to the Availability label.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9517] New: Change slipcss syspref to be editable from interface like intranetusercss

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9517

Bug ID: 9517
   Summary: Change slipcss syspref to be editable from interface
like intranetusercss
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: l...@catalyst.net.nz

In order to be modifiable by libraries without often needing to go through
their hosting provider, SlipCSS needs to be converted from looking for a file
to including CSS from the database like intranetusercss or opacusercss.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8682] quick slip: renewals do not appear on quick slips

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8682

--- Comment #1 from Liz Rea (CatalystIT) l...@catalyst.net.nz ---
Created attachment 14968
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14968action=edit
Bug 8682 - Renewals do not appear on quick slips

To test:
Issue two books to a patron.
Do a renewal on one of them.
update the issuedate on the item that has been renewed to something before
today (renewals on the same day will work even without this patch)
I did: select * from issues;
update issues set issuedate=2013-01-25 14:00:00 where itemnumber = 948;
(itemnumber is variable depending on your test data.)

Print a quick slip before the patch - the renewal will not show up as one of
today's issues.
Print a quick slip after the patch - the renewal will show up as one of today's
issues.

If you need reasoning as to why a renewal should show up on the quick slip,
think of it as a record of everything
a borrower did today, without the hassle of overdues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8682] quick slip: renewals do not appear on quick slips

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8682

Liz Rea (CatalystIT) l...@catalyst.net.nz changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||l...@catalyst.net.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9516] Item Availability/Data missing from OPAC tag search

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9516

--- Comment #2 from David Cook dc...@prosentient.com.au ---
Just another little note...make sure that the item availability information is
actually correct for the items in your list. The data in my test system is a
hodge-podge of backups, so I wasn't able to verify this one 100% (i.e. the item
record says it's onloan, but there is no matching issue record, so it says
checked out in the search results but available at the item level).

Looking at the code, it should work, but doesn't hurt to keep a careful eye
out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6473] Test bug for Git-bz

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

--- Comment #67 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 14969
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14969action=edit
9088: Default values for fund and item type on neworderempty form (dbrev)

Adds pref to database for install and upgrade.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6473] Test bug for Git-bz

2013-01-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

--- Comment #68 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 14970
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14970action=edit
9088: Default values for fund and item type on neworderempty form (dbrev)

Adds pref to database for install and upgrade.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

http://bugs.koha-community.org/show_bug.cgi?id=6473

Passed-QA-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/