[Koha-bugs] [Bug 9928] no way to see all purchase suggestions at all

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #13 from Chris Cormack ch...@bigballofwax.co.nz ---
Actually Katrin was right (she usually is), pushed to master is the queue I
watch, but Jared alerted me on IRC.

When its something like this, that has been pushed to master, and we have a
rebased patch for a maintenance branch it's better to leave it pushed to
master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9928] no way to see all purchase suggestions at all

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #14 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.10.x will be in 3.10.5

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Looking into this now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278

--- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to comment #5)
 Looking into this now

And yes I can full recreate the issue Owen and Katrin describe, if the
permissions don't match, it logs you out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278

--- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 17110
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17110action=edit
Bug 8278 : Follow up, fixing the permissions on cataloguing/ysearch.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9954] CSV profile encoding not selected on editing

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9954

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.10.x and 3.8.x will be in 3.10.5 and 3.8.12

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9463] Use DataTables on patron sent notices page

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 17111
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17111action=edit
Bug 9463: FIX DT sort by date for the last column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9463] Use DataTables on patron sent notices page

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463

--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
Owen, I got a js error with your patch:
  TypeError: y[((string + -) + m[Q][1])] is not a function

I fix it with 3 simple changes, I use uk_date for the Time column and it seems
to be well sorted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9902] item subfields not populating

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902

--- Comment #8 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to comment #7)
 Created attachment 17093 [details] [review]
 Bug 9902 - item subfields not populating


Thanks for addressing the review, ill retest now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #87 from Jonathan Druart jonathan.dru...@biblibre.com ---
Strange, I didn't get any problem to apply all of them against master.

I just push a branch on our kohac repository:
  http://git.biblibre.com/?p=kohac;a=shortlog;h=refs/heads/BZ8015

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853

--- Comment #2 from Mason James m...@kohaaloha.com ---
Created attachment 17112
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17112action=edit
Bug 7853 - opac-maintanance.pl should correctly redirect back to opac-main.pl,
if no updates are outstanding

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9902] item subfields not populating

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902

--- Comment #9 from Chris Cormack ch...@bigballofwax.co.nz ---
Interestingly in 3.8.x we did

 if (   ( $tagslib-{$tag}-{$subfield}-{kohafield} eq 'items.holdingbranch'
|| $tagslib-{$tag}-{$subfield}-{kohafield} eq 'items.homebranch' )
 $defaultvalues
 $defaultvalues-{'branchcode'} ) {
my $temp;
if ($itemrecord) {
$temp = $itemrecord-field($subfield);
}
unless ($temp) {
$defaultvalue = $defaultvalues-{branchcode} if
$defaultvalues;
}
}  

Bug 9116 removed these, and inadvertently caused this regression

 if (   ( $tagslib-{$tag}-{$subfield}-{kohafield} eq
'items.holdingbranch' || $tagslib-{$tag
  $defaultvalues
  $defaultvalues-{'branchcode'} ) {
-my $temp;
-if ($itemrecord) {
-$temp = $itemrecord-field($subfield);
-}
-unless ($temp) {
-$defaultvalue = $defaultvalues-{branchcode} if
$defaultvalues;
+if ( $itemrecord and $defaultvalues and not
$itemrecord-field($subfield) ) {
+$defaultvalue = $defaultvalues-{branchcode};
 }
 }


You'll notice the new behaviour is not the same as the old one, basically the
change in bug 9116 is fine for editing any item, but means that default values
are never used on new items, causing the problem that Nicole discovered and
Kyle fixed.

We have a couple of choices, revert bug 9116 (probably hard to do now) as it
was just a code cleaning fix that broke functionality, or use Kyle's patch.

I think probably best to use Kyles patch. This does prove a good illustration
of why code cleaning is good in theory, hard to get right in practice. 
http://blog.bigballofwax.co.nz/2012/07/31/yes-you-should-rewrite-it-no-not-like-that/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6506] deleting patron history missing errors

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6506

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6506] deleting patron history missing errors

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6506

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #16955|0   |1
is obsolete||

--- Comment #8 from Mason James m...@kohaaloha.com ---
Created attachment 17113
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17113action=edit
Bug 6506: When AnonymousPatron not set, deletion of issue history silently
failed.

Remedied by:
- in Circulation.pm changing AnonymiseIssueHistory so that it returns ($rows,
$err_history_not_deleted) instead of $rows
- consequential change to misc/cronjobs/batch_anonymise.pl to handle updated
return value, and fail if there is an error
- consequential change to tools/cleanborrowers.pl although this still fails
silently (raised as bug 9944)
- update of opac-privacy.pl to check return value and pass on error
- update of opac-privacy.tt to display error if appropriate

Note bug 9942 remains unfixed, which is a similar issue upon issue return.

To test:
1. OPAC
- enable privacy mode (preference OpacPrivacy)
- leave anonymous patron set to zero (preference AnonymousPatron)
- attempt to delete user history
- observe error
- check history - still there
- change anonymous patron to a valid user
- attempt to delete user history
- observe success message
- check history - gone

2. cleanborrowers.pl
- test it functions as before.  bug 9944 has been raised for it continuing to
silently fail.

3. batch_anonymise.pl
- enable privacy mode (preference OpacPrivacy)
- leave anonymous patron set to zero (preference AnonymousPatron)
- run script (I use --days -1 for testing)
- script should fail with a Carp message
- change anonymous patron to a valid user
- run script as before
- script returns quietly
- check history - gone

Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6506] deleting patron history missing errors

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6506

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #9 from Mason James m...@kohaaloha.com ---
(In reply to comment #8)
 Created attachment 17113 [details] [review]
 Bug 6506: When AnonymousPatron not set, deletion of issue history silently
 failed.
 
 Signed-off-by: Mason James m...@kohaaloha.com

tested patch on master - works as advertised for me, so signing-off

nice one Peter :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9902] item subfields not populating

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9902] item subfields not populating

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #17093|0   |1
is obsolete||

--- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 17114
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17114action=edit
Bug 9902 - item subfields not populating

Test Plan:
1) Create a new serial with a default location, call number, and library
   ( the library will need to be any but the one you are logged in as )
2) Click the Recieve button for this serial
3) Click Click to add item
4) Note those values are not populated
5) Apply the patch
6) Reload the page
7) Click Click to add item
8) Note those values are now populated

Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com
All tests pass!

Signed-off-by: Chris Cormack chr...@catalyst.net.nz

This seems to restore the former behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4862] Browse by subject is misnamed

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4862

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4862] Browse by subject is misnamed

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4862

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #16923|0   |1
is obsolete||

--- Comment #11 from Mason James m...@kohaaloha.com ---
Created attachment 17115
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17115action=edit
bug 4862 - Change label of Browse by subject or author to Authority search

Replicate:
Load the OPAC
You should see Browse by Subject or Author right below the search box

To test:
Apply patch
Load the OPAC
You should see Authority search where Browse by Subject or Author was .

Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4862] Browse by subject is misnamed

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4862

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #12 from Mason James m...@kohaaloha.com ---
(In reply to comment #11)
 Created attachment 17115 [details] [review]
 bug 4862 - Change label of Browse by subject or author to Authority search
 
 Signed-off-by: Mason James m...@kohaaloha.com

works as stated - so signing-off...

thanks Liz

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #3 from Mason James m...@kohaaloha.com ---
(In reply to comment #2)
 Created attachment 17112 [details] [review]
 Bug 7853 - opac-maintanance.pl should correctly redirect back to
 opac-main.pl, if no updates are outstanding

to test, 

before patch is applied…

1/ edit your 'version' syspref and make your version just less that it
currently is

so from 3.1200202 to to 3.1200201, (your version number may be differnt to
mine)

2/ load your OPAC url in a browser, you should be redirected to the 'OPAC
maintenance' page (leave this window/tab open)

3/ change your version syspref back to the original number

4/ reload your 'OPAC maintenance' page, it should *not* return to OPAC page
(fyi, this is the bug)

5/ apply patch

6/ repeat steps 1 thru 3 

7/ reload your 'OPAC maintenance' page, it should now redirect to the OPAC page
( bug is now fixed)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8745] disallow rebuild_zebra.pl from executing, when run by root user

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8745

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8745] disallow rebuild_zebra.pl from executing, when run by root user

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8745

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #13477|0   |1
is obsolete||

--- Comment #9 from Mason James m...@kohaaloha.com ---
Created attachment 17116
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17116action=edit
Bug 8745 - Disallow rebuild_zebra.pl from executing, when run by root user.

Added a check to warn users of execution as root user.
Added a 'runas-root' switch to allow users to force execution as root user.

Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8745] disallow rebuild_zebra.pl from executing, when run by root user

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8745

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8745] disallow rebuild_zebra.pl from executing, when run by root user

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8745

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #17116|0   |1
is obsolete||

--- Comment #10 from Mason James m...@kohaaloha.com ---
Created attachment 17117
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17117action=edit
Bug 8745 - Disallow rebuild_zebra.pl from executing, when run by root user.

Added a check to warn users of execution as root user.
Added a 'runas-root' switch to allow users to force execution as root user.

Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8745] disallow rebuild_zebra.pl from executing, when run by root user

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8745

--- Comment #11 from Mason James m...@kohaaloha.com ---
Created attachment 17118
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17118action=edit
general whitespace and tab tidy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8988] item status uses authorized value description for intranet

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8988

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #16126|[SIGNED-OFF] Bug 8988: item |[3.6][SIGNED-OFF] Bug 8988:
description|status uses authorized  |item status uses authorized
   |value description for   |value description for
   |intranet|intranet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8745] disallow rebuild_zebra.pl from executing, when run by root user

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8745

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #12 from Mason James m...@kohaaloha.com ---
(In reply to comment #8)
 This patch cannot work.
 
 the following line is wrong:
 if( undef $run_as_root and $run_user eq 'root')
 
 undef $run_as_root is always false.
 
 You wanted write
 if ( not defined $run_as_root and $run_user eq 'root' )
 
 Marked as Failed QA.

Jonathan, thanks for spotting the mistake. i have fixed it now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8988] item status uses authorized value description for intranet

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8988

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:

[3.6] $nfldata-{'lib_opac'} is never defined.
Please fix the sql query.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8745] disallow rebuild_zebra.pl from executing, when run by root user

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8745

--- Comment #13 from Mason James m...@kohaaloha.com ---
(In reply to comment #1)
 Created attachment 12107 [details] [review]
 Addition of executed by user check to warn if execute by root user.
 
 This patch will check the uid of user who executed the script. If it is the
 root user a warning will be issued and die. A user can force execute as
 root by using the -runas-root switch.


to test, apply patch...

1/ run script as root user, script should quit

2/ run script as root user with -run-as-root arg, script should *not* quit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8745] disallow rebuild_zebra.pl from executing, when run by root user

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8745

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9838] SIP tests : fix in 04patron_status.t

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9838

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m
 QA Contact||jonathan.dru...@biblibre.co
   ||m

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:
I can't launch tests for SIP but this patch looks good.
Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9838] SIP tests : fix in 04patron_status.t

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9838

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #16389|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 17119
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17119action=edit
Bug 9838: fix on 04patron_status.t

Some patron infos were hard coded instead
of using the variables defined in SIPtest.pm

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9463] Use DataTables on patron sent notices page

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463

--- Comment #11 from Owen Leonard oleon...@myacpl.org ---
Jonathan did you apply the patch for Bug 9887 first? I don't mind solving this
sort with the uk_date routine, but I've found the title attribute sort to be
really easy to implement, especially on pages where a lot of logic is going
into displaying columns or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2046] Suggestions: Title Field too small

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2046

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Yay! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9968] New: Error when a search is done with Standard number option

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9968

Bug ID: 9968
   Summary: Error when a search is done with Standard number
option
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: rus.sil...@masmedios.com

In file etc\zebradb\ccl.properties the label  Local-number is being
abbreviated by sn, it seems an error because sn should be the abbreviation
of standard number.

The label of standard number is Identifier-standard abbreviated by ident.

The standard numbers sholud be the 020, 022 and 024 MARC fields and not the in
001 and 035 fields.

For this reason searching in Advanced Search is wrong in search-indexes.inc
it find the following code:

[% IF (numbersphr) %]
option value=sn,phrStandard number/option
[% ELSE %]
option value=snStandard number/option
[% END %]

Should be:

[% IF (numbersphr) %]
option value=ident,phrStandard number/option
[% ELSE %]
option value=identStandard number/option
[% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com ---
Kyle, why didn't you use Koha::Calendar instead of C4::Calendar ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9737] Local Covers sometimes appear then disappear on OPAC Search Results/Lists

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9737

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:

The local cover image is displayed but I got 2 no cover image available
blocks.
Only 1 is displayed on master.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9961] Truncation and QueryAutoTruncate not working properly with new QueryParser

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9969] New: Sorting budget by labels rather than by codes

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9969

Bug ID: 9969
   Summary: Sorting budget by labels rather than by codes
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: sophie.meyni...@biblibre.com

When modifying a command line, budgets are proposed in a dropdown list, sorted
by budget code. It would be better to have them sorted by name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9969] Sorting budget by labels rather than by codes

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9969

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

  Attachment #16886|0   |1
is obsolete||

--- Comment #79 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 17120
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17120action=edit
Bug 7736 - Edifact QUOTE and ORDER functionality

This is a patch brining together the original
work by Mark Gavillet and the subsequent patches
by Mark, Martin Renvoize and myself

It contains the code as currently runnng in
production

In addition I've added updatedatebase entries to
installer and replaced the hardcoded currency with
a currency extraction. As the db currently does not
force the standard codes we check if that is 3 uppercase
ascii characters before using it.

Elliott Davis:
Added unit test for EDI

Zeno Tajoli:
Rebased on last master git tree.
I have change only the file installer/data/mysql/sysprefs.sql
Added missing end tag for tools-home.tt

Brendan Gallagher:
Rebased on current master
Changed installer/data/mysql/sysprefs.sql
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt

Bug 7736 - Edifact QUOTE and ORDER functionality - Followup - cordinate this
with template tools-home.tt

After the writting of the patch, the template tools-home.tt has a little
change.

I have have tested the ench wit instruction and I confirm that works.
Attention on dir misc/edi_files, you need to give permission to koha and to web
server
user (standard: www-data on debian)

Signed-off-by: Zeno Tajoli taj...@cilea.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #80 from Kyle M Hall kyle.m.h...@gmail.com ---
Created attachment 17121
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17121action=edit
Bug 7736 - Edifact QUOTE and ORDER functionality - Followup - Fix UI Issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9463] Use DataTables on patron sent notices page

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9463

--- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #11)
 Jonathan did you apply the patch for Bug 9887 first? I don't mind solving
 this sort with the uk_date routine, but I've found the title attribute sort
 to be really easy to implement, especially on pages where a lot of logic is
 going into displaying columns or not.

No, I forgot to apply the patch for bug 9887! And now it works.

This means all dates in DT tables should be replaced using this method?
We should standardized the way to sort dates and your patch add a new one. The
goal is to delete the uk_date js functions and add a span around td values?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9952] MARC tab: tab 0 is not translated correctly

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9952

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9613] items namespace missing in XSLT

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9613

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Needs Signoff

--- Comment #8 from Jared Camins-Esakov jcam...@cpbibliography.com ---
I would like another sign off on this from someone who uses UNIMARC. Another
BibLibre employee is fine. But since neither Marcel nor I can actually test
this patch thanks to bug 3087, another sign off would be a good idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9571] Fix width for textareas in Edit Item screen

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9571

--- Comment #13 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #12)
 What about doing both? Does the CSS correctly size the fields when the rows
 and cols are set? I'd like the markup to be valid.

Yes. I am satisfied with this. Pushing now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9571] Fix width for textareas in Edit Item screen

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9571

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #14 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4862] Browse by subject is misnamed

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4862

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com ---
Liz, don't you think we should replace 2 strings in opac-authorities-home.tt
too (Browse by author or subject)?

I can do it in my signed-off patch if you agree.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9850] Koha 3.12 Help Files Update

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9850

--- Comment #46 from Nicole C. Engard neng...@gmail.com ---
Created attachment 17122
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17122action=edit
Bug 9850: FOLLOW UP: Add Missing Plugin Help for 3.12

This patch is a follow up to the one that adds the plugin help.

To test:

Visit the upload a plugin page and review the help and links.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9887] Use DataTables on circulation page

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9887

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9838] SIP tests : fix in 04patron_status.t

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9838

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9609] Rebuild zebra reports double numbers for exported records with -z option

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9609

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5719] Update UNIMARC plugins

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5719

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9172] Move TinyMCE library outside of language-specific directory

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9572] Opac info tooltip from branches is not well positioned

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572

--- Comment #9 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 17123
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17123action=edit
Bug 9572 follow-up: duplicate jQueryUI upgrade in CCSR

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9572] Opac info tooltip from branches is not well positioned

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #10 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9970] New: Add datepicker widget default configuration to OPAC patron entry form

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9970

Bug ID: 9970
   Summary: Add datepicker widget default configuration to OPAC
patron entry form
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org

The patron entry form in the OPAC (opac-memberentry.pl) has a datepicker widget
but doesn't include the include file which sets some datepicker widget
defaults. calendar.inc includes translatable strings for labels on the calendar
and the path to the calendar image associated with datepicker form fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9947] Creating item for received serial prefills enumchron subfield

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9947

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9971] New: Plugins system is broken!

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9971

Bug ID: 9971
   Summary: Plugins system is broken!
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: kyle.m.h...@gmail.com

Trying to run a plugin results in the following error:

Software error:

Undefined subroutine Koha::Plugins::Base::get_template_and_user called at
/home/koha/kohaclone/Koha/Plugins/Base.pm line 108.

The is caused by the change from 'use C4::Auth' to 'require C4::Auth' which
does not export get_template_and_user.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9971] Plugins system is broken!

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9971

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9951] Resolve encoding problems where script parameters are not decoded

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9951

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9951] Resolve encoding problems where script parameters are not decoded

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9951

--- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 17124
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17124action=edit
Bug 9951: Followup for Tools

Adds decoding for Patron Cards/Patron Search and Tags (moderation).

Test plan:
Goto Tools. Add accent with diacritics in both areas. Check if you do not see
converted characters.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] New: Add/ change some zebra indexes (MARC21) (GRS1)

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Bug ID: 9972
   Summary: Add/ change some zebra indexes (MARC21) (GRS1)
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: mi...@abunchofthings.net
  Reporter: mi...@abunchofthings.net

This patch adds :w and :p versions to the index for »Lexile number« (it has
only :n so far) and adds indexes for 653$a (Index term uncontrolled) and 655$a
(Index term Genre/Form). It also adds the »curriculum«-index to Search.pm.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2835] Inconsistent use of colon at the end of sentences

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2835

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #6 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9971] Plugins system is broken!

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9971

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9971] Plugins system is broken!

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9971

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 17125
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17125action=edit
Bug 9971 - Plugins system is broken!

Trying to run a plugin results in the following error:

Software error:

Undefined subroutine Koha::Plugins::Base::get_template_and_user called
at /home/koha/kohaclone/Koha/Plugins/Base.pm line 108.

The is caused by the change from 'use C4::Auth' to 'require C4::Auth'
which does not export get_template_and_user.

Test Plan:
1) Install the KitchenSink plugin
2) Try to run the report, tool or configuration for the plugin
3) Note the error
4) Apply the patch
5) Try again

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1)

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

--- Comment #1 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 17126
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17126action=edit
9972 Add/ change some zebra indexes (MARC21) (GRS1)

This patch adds :w and :p versions to the index for »Lexile number« (it has
only :n so far) and adds indexes for 653$a (Index term uncontrolled) and 655$a
(Index term Genre/Form). It also adds the »curriculum«-index to Search.pm.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9951] Resolve encoding problems where script parameters are not decoded

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9951

--- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl ---
It seems that the scripts that are posting data generally do not have problems
(at this moment..) but when GET is used for searching on names etc., we need to
decode the parameters. This has to do with CGI.pm internals: the GET params are
coming from the environment, the POST values are read from STDIN.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9951] Resolve encoding problems where script parameters are not decoded

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9951

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9172] Move TinyMCE library outside of language-specific directory

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172

--- Comment #7 from Owen Leonard oleon...@myacpl.org ---
(In reply to comment #5)

  #===
  sub get_params {
  #===

Since these lines are in a file which is part of the TinyMCE distribution I
hesitate to modify them. I notice too that we have a couple of examples of that
construction in existing Koha scripts:

kohaclone/authorities/authorities.pl:
  535  #  
  536  #  MAIN 
  537: #=
  538  my $input = new CGI;
  539  my $z3950 = $input-param('z3950');

kohaclone/cataloguing/addbiblio.pl:
  714  # 
  715  #  MAIN
  716: #=
  717  my $input = new CGI;
  718  my $error = $input-param('error');

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9970] Add datepicker widget default configuration to OPAC patron entry form

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9970

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9970] Add datepicker widget default configuration to OPAC patron entry form

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9970

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Created attachment 17127
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17127action=edit
Bug 9970 - Add datepicker default configuration to OPAC patron entry form

The datepicker on the OPAC patron entry/update form
(opac-memberentry.pl) doesn't show a calendar icon. This is because
although there is in-page JS to trigger the widget, the page doesn't
include the file which sets some widget defaults, including the path to
the calendar icon and the translatable strings for calendar labels.

This patch simply adds calendar.inc to the template.

To test, load the patron entry/update form (click personal details for
an existing patron or a start new patron registration). The date of
birth entry field should show a calendar icon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1)

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #2 from Mirko Tietgen mi...@abunchofthings.net ---
(this patch is for GRS1 indexing, not DOM)

To test:

- apply patch

A) prepare a record with data in
-- 521$a (VALUE1) (please use a non-numerical value here)
-- 653$a (VALUE2)
-- 655$a (VALUE3)

- reindex

B) Try to find the record in your OPAC:

URL_to_your_OPAC/opac-search.pl?idx=lexq=VALUE1
URL_to_your_OPAC/opac-search.pl?idx=Index-term-uncontrolledq=VALUE2
URL_to_your_OPAC/opac-search.pl?idx=Index-term-genreq=VALUE3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9951] Resolve encoding problems where script parameters are not decoded

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9951

--- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 17128
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17128action=edit
Bug 9951: Followup for tools/viewlog.pl

Adds utf8 cgi parameter decoding.

Test plan: Enter diacritics in librarian field. Submit. Check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8200] /home/chris/git/koha.git in /usr/share/koha/misc/translator/update.pl

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8200

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Here's the conversation FWIW:

15:09  mtompsetokay, okay... a weirdness got my attention before
   getting to bed.
15:09  mtompsetuse lib '/home/chris/git/koha.git';
15:09  mtompsetin the misc/translator/update.pl program.
15:12  jcamins mtompset: don't use update.pl.
15:12  jcamins It's deprecated.
15:12  jcamins Use translate.
15:13  mtompsetI'm not using it... I was just looking for perl use 
   statements, to make sure the package lists were up to date.
15:13  jcamins mtompset: okay, good.
15:13  jcamins mtompset: definitely a bug, though. I'd report it.
15:13  jcamins Eventually the script will be removed, I think.
15:14  mtompsetwhen was it deprecated?
15:15  jcamins mtompset: not sure, exactly. A while ago.

http://stats.workbuffer.org/irclog/koha/2012-06-06#i_987956

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8200] /home/chris/git/koha.git in /usr/share/koha/misc/translator/update.pl

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8200

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

Version|3.6 |master
   Assignee|gmcha...@gmail.com  |ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8200] /home/chris/git/koha.git in /usr/share/koha/misc/translator/update.pl

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8200

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8200] /home/chris/git/koha.git in /usr/share/koha/misc/translator/update.pl

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8200

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #16829|0   |1
is obsolete||

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
Created attachment 17129
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17129action=edit
[SIGNED-OFF] Bug 8200 - removing misc/translator/update.pl - deprecated file

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9973] New: Catching error when currency is wrong formatted in imported notices

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9973

Bug ID: 9973
   Summary: Catching error when currency is wrong formatted in
imported notices
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: sophie.meyni...@biblibre.com

When price is not formatted as expected, import of notices dies silently

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9973] Catching error when currency is wrong formatted in imported notices

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9973

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739

Koha Team AMU koha.aixmarsei...@gmail.com changed:

   What|Removed |Added

 CC||koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9535] Patron card creator Remove duplicates function doesn't work

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9535

--- Comment #3 from Chris Nighswonger cnighswon...@foundations.edu ---
Created attachment 17130
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17130action=edit
Proposed Fix

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9535] Patron card creator Remove duplicates function doesn't work

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9535

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7853] opac-maintanance.pl should correctly redirect back to opac-main.pl, if no updates are outstanding

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7853

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #17112|0   |1
is obsolete||

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
Created attachment 17131
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17131action=edit
[SIGNED-OFF] Bug 7853 - opac-maintanance.pl should correctly redirect back to
opac-main.pl, if no updates are outstanding

Signed-off-by: Owen Leonard oleon...@myacpl.org

Works exactly as it should according to the test plan. This is a nice
improvement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9535] Patron card creator Remove duplicates function doesn't work

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9535

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9535] Patron card creator Remove duplicates function doesn't work

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9535

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #17130|0   |1
is obsolete||

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
Created attachment 17132
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17132action=edit
[SIGNED-OFF] Bug 9535 - Patron card creator Remove duplicates function
doesn't work

This bug was due to a difference in field names used in the item data
for items versus patrons. This patch adds a ternary to discern between
the two.

To test:

Before applying patch:

1. Create a batch of patroncards with one duplicate.
2. Run the de-duplication on the batch.
3. Note that all patrons beyond the first in the batch are now
   deleted.

After applying patch:
4. Repeat steps 1-2.
5. Note that only the duplicate patron is removed.

Signed-off-by: Chris Nighswonger cnighswon...@foundations.edu
Signed-off-by: Owen Leonard oleon...@myacpl.org

Tested successfully with both patron card batches and label batches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9381] Add Catalan language

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9381

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #15313|0   |1
is obsolete||

--- Comment #13 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 17133
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17133action=edit
Bug 9381: Add Catalan language

Simply add catalan language.

No translation yet, so can't be really tested.
But it will come soon.

Until then, to test:
1) cp misc/translator/po/es-ES* to ca-ES*
2) do perl translate install ca-ES,
3) apply the patch
4) run updatedatabase.pl
5) enable language and display on system preferences.
6) check labels

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

Rebased to current master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9381] Add Catalan language

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9381

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #15749|0   |1
is obsolete||

--- Comment #14 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 17134
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17134action=edit
Followup Bug 9381 - Add Catalan language

This followup adds Catalan language into languages
other than english.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

Rebased to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9381] Add Catalan language

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9381

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #15750|0   |1
is obsolete||

--- Comment #15 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 17135
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17135action=edit
Followup 2 - Bug 9381 - Add Catalan language

Sorry, this followup fulfills K. Fischer request to
base de-DE file in english one.

The differences are small corrections and added languages.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

Rebased to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9381] Add Catalan language

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9381

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #16 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
All rebased. Switched to Signed-off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1)

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

--- Comment #3 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 17136
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17136action=edit
9972 Follow-up: DOM version

A DOM version of the same indexes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

Summary|Add/ change some zebra  |Add/ change some zebra
   |indexes (MARC21) (GRS1) |indexes (MARC21) (GRS1+DOM)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #17126|0   |1
is obsolete||
  Attachment #17136|0   |1
is obsolete||

--- Comment #4 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 17137
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17137action=edit
9972 Add/ change some zebra indexes (MARC21) (GRS1)

This patch adds :w and :p versions to the index for »Lexile number« (it has
only :n so far) and adds indexes for 653$a (Index term uncontrolled) and 655$a
(Index term Genre/Form). It also adds the »curriculum«-index to Search.pm.

9972 Follow-up: DOM version

A DOM version of the same indexes

Squashed both patches together.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9971] Plugins system is broken!

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9971

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9971] Plugins system is broken!

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9971

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #17125|0   |1
is obsolete||

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Created attachment 17138
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17138action=edit
[SIGNED-OFF] Bug 9971 - Plugins system is broken!

Trying to run a plugin results in the following error:

Software error:

Undefined subroutine Koha::Plugins::Base::get_template_and_user called
at /home/koha/kohaclone/Koha/Plugins/Base.pm line 108.

The is caused by the change from 'use C4::Auth' to 'require C4::Auth'
which does not export get_template_and_user.

Test Plan:
1) Install the KitchenSink plugin
2) Try to run the report, tool or configuration for the plugin
3) Note the error
4) Apply the patch
5) Try again

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9973] Catching error when currency is wrong formatted in imported notices

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9973

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Sophie MEYNIEUX sophie.meyni...@biblibre.com ---
This problem is not relevant

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9850] Koha 3.12 Help Files Update

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9850

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #17094|0   |1
is obsolete||

--- Comment #47 from Owen Leonard oleon...@myacpl.org ---
Created attachment 17139
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17139action=edit
[SIGNED-OFF] Bug 9850: Cataloging Help for 3.12

This updates just the links in the cataloging help, no text changes where made.

To test:

Visit help in cataloging and click the manual links and make sure they're
right.

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9850] Koha 3.12 Help Files Update

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9850

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #17095|0   |1
is obsolete||

--- Comment #48 from Owen Leonard oleon...@myacpl.org ---
Created attachment 17140
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17140action=edit
[SIGNED-OFF] Bug 9850: Update Reports Help for 3.12

This updates the reports help for Koha 3.12.

To test:

Visit all reports pages and review the help for textual changes
and correct links.

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >