[Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Passed QA   |Signed Off
   Patch complexity|Small patch |---

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
As we are very close to release I suggest to file a separate bug for using the
new TT plugin for displaying all item status and use this patch to fix the
existing bug in the upcoming release and the older releases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #18162|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |RESOLVED
 Resolution|--- |FIXED

--- Comment #34 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I have opened bug 10266 for the new patch and passed QA on the patch there. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993

--- Comment #29 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Sophie,

I am at a loss here... I don't know how to fix the problem with permissions on
running at. I have added the users to a newly created at.allow file, but it's
just not working. :(

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993

--- Comment #30 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 18183
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18183action=edit
screenshot

Actually, the logs show no new permission errors now, but I still get the same
message in the interface about the job not being added (see screenshot)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7593] merging bib records loses connection to order line

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593

--- Comment #56 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #55)

Chris,
Thank you for your quick reply!

 The tests fail, because they are dependent on orders existing for an
 existing supplier, but the test does not set up any of this up, so they work
 coincidentally on systems that have it set up, skip on others that have no
 orders, fail on others that have some orders but not the ones the test is
 expecting.

So what was the case for the DB used by jenkins? Was an order exist ?

I think yes:
Yesterday, the jenkins report for t/db_dependent/Acquisition.t was 

[...]
ok 2 - NewBasket(  1 , 1  ) returns 18575
ok 3 - GetBasket(18575) returns HASH(0x3b1a960)
ok 4 - The reference isa ARRAY
ok 5 - GetOrdersByBiblionumber : no argument, return undef
not ok 6 - GetOrdersByBiblionumber : result is defined
not ok 7 - GetOrdersByBiblionumber : result contains at least one element
ok 8 - all orders match
ok 9 - AddClaim : Check claimed_date
ok 10 - This order has a basketno field
ok 11 - This order has a biblioitemnumber field
ok 12 - This order has a biblionumber field
ok 13 - This order has a invoiceid field
[...]

If no orders existed we should have:
ok 1 - use C4::Acquisition;
ok 2 - NewBasket(  1 , 1  ) returns 92
ok 3 - GetBasket(92) returns HASH(0x402ecc8)
ok 4 - The reference isa ARRAY
ok 5 - GetOrdersByBiblionumber : no argument, return undef
ok 6 # skip No Orders, cannot test GetOrdersByBiblionumber
ok 7 # skip No Orders, cannot test GetOrdersByBiblionumber
ok 8 # skip No Orders, cannot test GetOrdersByBiblionumber
ok 9 - AddClaim : Check claimed_date
ok 10 # skip No relevant orders in database, cannot test baskets
ok 11 # skip No relevant orders in database, cannot test baskets
ok 12 # skip No relevant orders in database, cannot test baskets

So yesterday an order existed before tests was launched, but I don't find why.
It was not inserted by sample data (which I know) or unit test itself.
I would like to unravel this mystery :)

 I will make jenkins have data to make these tests pass, in future it would
 be good to make the tests test creating and deleting orders too, so that
 they can pass on any database.

Yes, it is what I do and I think Mathieu should propose another patch to go in
that way. Otherwise, it will be even more complicated to understand how tests
are launched and how launching them with a local DB.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #31 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to comment #29)
 I am at a loss here... I don't know how to fix the problem with permissions
 on running at. I have added the users to a newly created at.allow file, but
 it's just not working. :(

If you have Linux distro with SELinux enforced, that could be a reason too. In
that case you need to tell SELinux too that this is okay..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7593] merging bib records loses connection to order line

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593

--- Comment #57 from mathieu saby mathieu.s...@univ-rennes2.fr ---
  I will make jenkins have data to make these tests pass, in future it would
  be good to make the tests test creating and deleting orders too, so that
  they can pass on any database.
 
 Yes, it is what I do and I think Mathieu should propose another patch to go
 in that way. Otherwise, it will be even more complicated to understand how
 tests are launched and how launching them with a local DB.


It may be beyond my competencies :(
I think the best would be some real good developper create a strong and
comprehensive set of tests for Acquisition.t. A lot of functions are not tested
at that time.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10267] New: No error message when entering an invalid cardnumber

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

Bug ID: 10267
   Summary: No error message when entering an invalid cardnumber
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The cardnumber field is limited to 16 in Koha. When you enter a longer
cardnumber the number is cut off. When you try to change it adding the missing
part, there is no error message shown and your change is just not saved.

Koha should give a useful error message.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10268] New: add missing perl packages for Koha on wheezy (perl5.14)

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10268

Bug ID: 10268
   Summary: add missing perl packages for Koha on wheezy
(perl5.14)
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m...@kohaaloha.com
CC: ro...@catalyst.net.nz

i just upgraded my squeeze box to wheezy, 
and got some errors about some missing perl modules

a quick cpanm fixed the errors...
 # cpanm LWP/UserAgent.pm Try/Tiny.pm URI/Escape.pm


this bug will attempt to fix this problem

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993

--- Comment #32 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I am using Ubuntu and didn't activate anything. Maybe it's realted to the form
that has changed between the screenshots and the current version in master?
The error from the logs is gone, so I think I must have solved the permission
problem, but I still can't schedule anything, which makes me think that there
is something wrong with my input or something else inside Koha?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993

--- Comment #33 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Katrin:
Just another observation. I set my SELinux temporarily to Permissive. I can add
a job, but there is another security issue.
At job run time, I receive the mail: This account is currently not available.
Why? Because my apache user is not allowed to login. So the job cannot be run,
although it is allowed via at.allow etc.

This brings me to a more important question: Should we encourage Koha users to
allow login for apache user to make use of the Task Scheduler? Note that is a
general Apache hardening measure to not allow interactive login for the apache
user. IMO we (as Koha developers) should not stimulate Koha users to lower
security barriers to enable Koha functionality.

Another approach to the Task Scheduler could be to have a specific cronjob,
look for Koha reports to run at specified times without allowing apache to add
generic jobs with all security risks attached..

Moving this report to In Discussion. Will send a mail to the dev list.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10269] New: add a way to define a specific replyto email address for some notice

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

Bug ID: 10269
   Summary: add a way to define a specific replyto email address
for some notice
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mathieu.s...@univ-rennes2.fr

I am defining a notice template for ILL. I want to use a specific email address
(like i...@mylibrary.fr, instead of the adress of the banch or the adress of
the Koha administrator.

I believe it is not possible.

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7593] merging bib records loses connection to order line

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593

--- Comment #58 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #55)

 The tests fail, because they are dependent on orders existing for an
 existing supplier, but the test does not set up any of this up, so they work
 coincidentally on systems that have it set up, skip on others that have no
 orders, fail on others that have some orders but not the ones the test is
 expecting.
 
 I will make jenkins have data to make these tests pass, in future it would
 be good to make the tests test creating and deleting orders too, so that
 they can pass on any database.

Hi Chris, and thx for the DB fix. Is it written somewhere how the jenkins
database is filled ? I thought it was filled with default datas, and default
datas only, but we're not sure, because other acq tests should have failed.
what are we missing ?
(about having datas to make there tests pass, that could be Kenza main work. 2
weeks to wait before she's onboard ;-) -and maybe 2-3 more weeks before she can
really produce high value code - )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #23 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA: Looking at this one now..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

--- Comment #24 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
Works fine. My only question was: How to find back this basket if it is no
longer on that list. But with Order search or its Advanced Search, you can
still find it.
Small patch. No complaints from qa-tools. Looks good.

BTW: I do not think that quantityreceived could be NULL (constrained), but this
test does not hurt either.

Final thought: Perhaps another improvement could be: always show baskets that
are still open and apply your condition only on the closed ones..
If you agree on that, could you add a followup?

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #18168|0   |1
is obsolete||

--- Comment #25 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 18184
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18184action=edit
Bug 9824 - Hide basket with no expected items in basqket list by bookseller

Before patch you will see in acqui/booksellers.pl all the baskets ever
created.
After the patch you will see in acqui/booksellers.pl only the basket
with expected items.

Test plan :
* Create a basket with some orders lines
You should see this basket in acqui/booksellers.pl
* receive or cancel all the line in this basket
This basket shouldn't appear any more in acqui/booksellers.pl

Signed-off-by: Owen Leonard oleon...@myacpl.org
Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] New: GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

Bug ID: 10270
   Summary: GetOrdersByBiblionumber needs better unit tests
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||7593

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7593] merging bib records loses connection to order line

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||10270

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10269] add a way to define a specific replyto email address for some notice

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #1 from Liz Rea l...@catalyst.net.nz ---
I agree this is desirable. Reply to should probably be a configuration option
in notices and tools, per branch and per notice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18185
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18185action=edit
Bug 10270: GetOrdersByBiblionumber needs better unit tests

prove t/db_dependent/Acquisition/GetOrdersByBiblionumber.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

Version|master  |3.12
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9417] Allow number of results per page to be selectable for guided reports

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9417

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9719

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9719] Changing the rows per page on a custom report fails if it has user supplied parameters

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9417

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #18185|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18186
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18186action=edit
Bug 10270: GetOrdersByBiblionumber needs better unit tests

prove t/db_dependent/Acquisition/GetOrdersByBiblionumber.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

--- Comment #3 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Thank you Jonathan, that looks GREAT!
I am going to test it right now.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9719] Changing the rows per page on a custom report fails if it has user supplied parameters

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719

--- Comment #7 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to comment #5)
 Does not apply to 3.10.x please rebase if needed

This bug corrects an enhancement added by bug 9417 which has only been pushed
on master.
So no need to create a 3.10.x rebase.

@Kyle : nice job, you're like a bug hunter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #17650|0   |1
is obsolete||

--- Comment #39 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18187
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18187action=edit
Bug 5336: Add unit tests for 3 acq routines

Unit tests In C4::Acquisition for:
- CloseBasket
- ReopenBasket
- GetBiblioCountByBasketno

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10174] Digest is confusing

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

--- Comment #7 from mathieu saby mathieu.s...@univ-rennes2.fr ---
In french, we have no exact translation for digest. For us it is the same world
as summary or abstract.
So we translate it by résumé (summary), but it sounds a bit strange.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #4 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I made 2 tests :

$prove -v t/db_dependent/Acquisition/GetOrdersByBiblionumber.t
t/db_dependent/Acquisition/GetOrdersByBiblionumber.t .. 
ok 1 - GetOrdersByBiblionumber : no argument, return undef
ok 2 - 1 order on biblionumber 1
ok 3 - 2 orders on biblionumber 2
1..3
ok
All tests successful.
Files=1, Tests=3,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.36 cusr  0.03
csys =  0.41 CPU)
Result: PASS

and

$prove -v t/db_dependent/Acquisition.t
t/db_dependent/Acquisition.t .. 
1..37
[...]
All tests successful.
Files=1, Tests=37,  1 wallclock secs ( 0.01 usr  0.01 sys +  0.36 cusr  0.04
csys =  0.42 CPU)
Result: PASS

I sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

  Attachment #18186|0   |1
is obsolete||

--- Comment #5 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Created attachment 18188
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18188action=edit
[SIGNED OFF][PATCH] Bug 10270: GetOrdersByBiblionumber needs better unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7593] merging bib records loses connection to order line

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593

--- Comment #59 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I signed off BZ 10270
Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master and 3.12.x.

I agree with Katrin- I'd rather see this go into 3.12, as the patch is merely
correcting the order of two lines already in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10271] New: An index containing ns or nb does not work

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271

Bug ID: 10271
   Summary: An index containing ns or nb does not work
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: fridolyn.som...@biblibre.com

When an index does not contain a structure part, the structure wrdl is
automatically added and a structure is mandatory to build search query (to
convert ':' into '=').
But the code that tests that the structure is not already defined looks in
entire index string : 
  $index =~ /(st-|phr|ext|wrdl|nb|ns)/
It should look for a comma followed by a structure and in the case of nb and
ns look for an exact match.

The consequence is that an index containing ns or nb or phr or etc does not
work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10272] New: CheckReserves returns not respecting ReservesControlBranch

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272

Bug ID: 10272
   Summary: CheckReserves returns not respecting
ReservesControlBranch
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: kyle.m.h...@gmail.com
CC: gmcha...@gmail.com

CheckReserves is using the CircControl system preference to determine what
patrons an item can fill a hold for. It should be using ReservesControlBranch
instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #26 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master and 3.12.x.

I have serious reservations about this patch, but am pushing it anyway as it
simply reverts Koha to its previous behavior, problematic as that was. With
this patch, I am no longer able to get an overview of baskets for a particular
vendor. I can see a list of orders using the Orders search, but there's no
overview of baskets available. I am pushing this only because I trust that
someone will fix this issue properly for the 3.12.1 release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18189
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18189action=edit
Bug 10272 - CheckReserves returns not respecting ReservesControlBranch

CheckReserves is using the CircControl system preference to determine what
patrons an item can fill a hold for. It should be using ReservesControlBranch
instead.

Test Plan:
1) Create an item at Library A, place holds for it for patrons at
   Library B, Library C, and Library A in that order,
   for pickup at the patrons home library.

2) Make sure the holds policy for Library A is set to
   Hold Policy = From home library and
   Return Policy = Item returns home.

   Make sure the holds policies for the other libraries are set to
   Hold Policy = From any library.

3) Check the item in at Library C, the hold for the patron at Library B
   should pop up, even though it's in violation of the circulation rules.
   Don't click the confirm button!

4) Apply this patch, and reload the page,
   now the hold listed should be for the last hold,
   the hold for the patron at Library A, which is correct.

This patch adds the subroutine C4::Reserves::GetReservesControlBranch as
an equivilent to C4::Circulation::_GetCircControlBranch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |kyle.m.h...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #18189|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18190
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18190action=edit
Bug 10272 - CheckReserves returns not respecting ReservesControlBranch

Perltidy'ed the new sub.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

--- Comment #27 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I have been thinking about this for a while now and I can see that it's
problematic because the old behaviour has been broken quite a while ago and now
it could be a problematic change for other libraries using Koha's acq. 

I was wondering if I could use jQuery to 'revert' to the original behaviour...
probably a bit tricky, but it could work until we see this fixed properly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

--- Comment #28 from mathieu saby mathieu.s...@univ-rennes2.fr ---
For 3.12.1, what about a filter on the left of the page, giving ability to
choose to display received/pending/closed/open baskets, according to the whish
of the librarians ?

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

--- Comment #29 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
That sounds nice - as long as we get something. I think having the shorter list
(limited to 'unfinished' baskets) might be a good default, but have an option
to show all/pending/open/closed baskets would certainly be nice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

--- Comment #30 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #27)
 I have been thinking about this for a while now and I can see that it's
 problematic because the old behaviour has been broken quite a while ago and
 now it could be a problematic change for other libraries using Koha's acq. 
 
 I was wondering if I could use jQuery to 'revert' to the original
 behaviour... probably a bit tricky, but it could work until we see this
 fixed properly.

That would be quite easy to do:
$('.baskets tbody tr').each(function () {
if ($('td:eq(2)', this).text() == $('td:eq(4)', this).text() 
$('td:eq(2)', this).text() != '0') {
$(this).hide();
}
});

It sounds like a better patch is in the works for 3.12.1, so I am inclined to
revert this patch for now, as it will change the behavior for anyone already
using 3.8 or 3.10, and no one who upgraded from 3.6 noticed the change until
this March. I will delay a decision until later today.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

--- Comment #31 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #26)
 This patch has been pushed to master and 3.12.x.
 
 I have serious reservations about this patch, but am pushing it anyway as it
 simply reverts Koha to its previous behavior, problematic as that was. With
 this patch, I am no longer able to get an overview of baskets for a
 particular vendor. I can see a list of orders using the Orders search, but
 there's no overview of baskets available. I am pushing this only because I
 trust that someone will fix this issue properly for the 3.12.1 release.

Am I missing something ?
Koha  Acquisitions  Order search  Advanced search  enter basket # in basket
field, and you'll get all the content of basket # !
Doesn't that fit your need ?

Which use case could achieve a list of baskets for a particular vendor ? I
don't see one (but I'm OK to be convinced being wrong ;-) )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

--- Comment #32 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #31)
 (In reply to comment #26)
 Am I missing something ?
 Koha  Acquisitions  Order search  Advanced search  enter basket # in
 basket field, and you'll get all the content of basket # !
 Doesn't that fit your need ?

Not smoothly.

 Which use case could achieve a list of baskets for a particular vendor ? I
 don't see one (but I'm OK to be convinced being wrong ;-) )

I have a library that uses Acquisitions to record gifts, and each gift is a
separate basket, and with a list of baskets they can review how often/when they
received gifts, without needing to slog through lists of items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266

--- Comment #5 from Rafal r...@poczta.onet.pl ---
(In reply to comment #1)
 Created attachment 18181 [details] [review]
 Proposed patch
 
 Moved patch and bug description to a new bug.

Thanks Katrin for correcting this bugfix :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Rafal, thx to you for fixing an annoying bug and welcome :)

http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=3898e70fe55b9e56a474220223adcf205a12add1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

--- Comment #33 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
no one who upgraded from 3.6 noticed the change until this March
I can say that my colleagues noticed and come to complain very often !!
I know that Lyon2 university had to change all the vendor every year to get
around this problem.
I take account of the desire of people who manage the acquisitions in my
university, but if operations differ in other organizations, i can understand
that we try to giving ability to choose to display received/pending/closed/open
baskets.
What is the need of people that really deals with acquisitions ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

--- Comment #34 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
I'm sorry but using acquistions module for gift is a sort of diversion, no ?
If this change is introduced not for the proper use, i'm not sure it's a good
idea..
Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10271] An index containing ns or nb does not work

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |fridolyn.som...@biblibre.co
   ||m

--- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 18191
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18191action=edit
Proposed patch

See commit message.

I know there is a work on QueryParser but this patch is very small.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10271] An index containing ns or nb does not work

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

--- Comment #35 from mathieu saby mathieu.s...@univ-rennes2.fr ---
In Rennes 2, we agree the default behavior MUST be changed, and we are fine
with this patch being pushed in master.

The only remark is that MAYBE it could be useful for a lib, or the chief
librarian responsible for acquisitions to see all baskets. But not everyday ;-)
And we could add new possibilities for filtering and sorting baskets (for ex.
sorting by date, showing only open baskets etc).

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

--- Comment #25 from mathieu saby mathieu.s...@univ-rennes2.fr ---
My 1st test, just to check the new behavior of currency module
= seems ok

My test plan:

1. $perl installer/data/mysql/updatedatabase.pl
Upgrade to 3.11.00.XXX done (Added isocode to the currency table)
2. going to admin/currency.pl page : there is a new column for iso code
= ok
3. editing my two currencies (euro and dollar) to add iso codes (EUR and USD)
= ok
4. adding a new currency (sterling pound) with symbol £ and iso code GBP
= ok
5. suppressing a currency
= ok
6. changing the active currency
= ok


I am now testing the import of marc record

Mathieu

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #1 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
I've just been going through the options and if my understanding is correct it
would appear there's been a regression somewhere.

I'm sure it used to be that when you enabled EasyAnalytics, then the 'Analyze
items' menu option replaced 'New child record' as an option under the 'New'
menu in a record display.

With both options present it's very easy to get confused between the two
different mutually exclusive procedures for creating analytics.

However.. I do think we should be able to enhance the functionality such that
the options are no longer mutually exclusive. I'll open another bug for this as
an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #18188|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18192
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18192action=edit
Bug 10270: GetOrdersByBiblionumber needs better unit tests

prove t/db_dependent/Acquisition/GetOrdersByBiblionumber.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
typo in the last patch:

-use C4::Biblio qw( AddBiblio );
+use C4::Biblio;
[...]
-( undef, $ordernumber2 ) = C4::Acquisition::NewOrder(
+( undef, $ordernumber3 ) = C4::Acquisition::NewOrder(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

--- Comment #8 from mathieu saby mathieu.s...@univ-rennes2.fr ---
However, it worked. Need to be tested again?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #15204|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18193
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18193action=edit
Bug 9531 - Make SIP2 message terminator configurable via SIPconfig.xml

Add a delimeter option to SIPConfig.xml, choices for 'delimeter' are 'CR' or
'CRLF'.
The default continues to be 'CRLF' if 'delimeter' is undefined.

Test Plan:
1) Apply patch
2) Start SIP server
3) Run C4/SIP/t/04patron_status.t
4) Stop SIP server
5) Add terminator=CR for account login 'term1'
6) Run 04patron_status.t again, you should see no change

Signed-off-by: Frédéric Demians f.demi...@tamil.fr

Make sense. With this patch, starting 2 SIP2 servers, it is possible to serve
heterogeneous Self check devices. Shouldn't we need some doc somewhere about
this parameter?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
Needs SO

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10273] New: Unit tests should not be dependent on the Jenkins database

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273

Bug ID: 10273
   Summary: Unit tests should not be dependent on the Jenkins
database
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com

This report is an omnibus. The idea is to have a test suite to launch on any
instance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10274] New: UT: Acquisition.t needs to create its own data

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274

Bug ID: 10274
   Summary: UT: Acquisition.t needs to create its own data
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com

t/db_dependent/Acquisition.t depends on the Jenkins database.
We should create the data we want and delete them at the end.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Depends on||10273
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||10274

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||10270

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||10274

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #16044|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18194
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18194action=edit
Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to
Check Out Books

Add checks in C4::ILS::Patron and C4::ILS::Transaction::Renew to make sure the
patron
is below the noissuescharge system pref for issues and OPACFineNoRenewals for
renewals.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #16045|0   |1
is obsolete||

--- Comment #17 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18195
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18195action=edit
Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to
Check Out Books - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #16048|0   |1
is obsolete||

--- Comment #18 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18196
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18196action=edit
Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to
Check Out Books - QA Followup 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18197
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18197action=edit
MT10274: UT: Acquisition.t needs to create its own data

Try before the patch:
prove t/db_dependent/Acquisition.t

And after, it should produce:
  t/db_dependent/Acquisition.t .. ok
  All tests successful.
  Files=1, Tests=41,  2 wallclock secs ( 0.03 usr  0.00 sys +  0.42 cusr
  0.02 csys =  0.47 CPU)
  Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #18196|0   |1
is obsolete||

--- Comment #19 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18198
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18198action=edit
Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to
Check Out Books - QA Followup 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #18198|0   |1
is obsolete||

--- Comment #20 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18199
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18199action=edit
Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to
Check Out Books - QA Followup 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #18199|0   |1
is obsolete||

--- Comment #21 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18200
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18200action=edit
Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to
Check Out Books - QA Followup 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

--- Comment #26 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Following of my test : 

add currencies matching codes and symbols in your records

CANADA 1.0 $ CAN
DOLLAR 1.0 $ USD
EGYPT 1.0 £E EGP
EUR 1.0 € EUR
KENYAN SHI 1.0 KSh KES
LIVRE 1.0 £ GBP
YEN 1.0 ¥ JPY

(CAN should be CAD I suppose, but this is cosmetic)
active currency : EUR

Checking 010$d fields of your records in with yaz-marcdump.

Staging records
Filling a basket with staged records, selecting currency : EUR.

Checking content of the basket : 

A hauteur d'homme / Rousseau et l'écriture de soi by Lionel Bourg
subfield code=d75.40 EUR, 93.5 USD, 20 250 EGP/subfield
RRP tax exc : 75.40

A la conquête du Graal by Alicia Bekhouche
subfield code=d$44, 23 €, 64 Br,£30/subfield
RRP tax exc : 23.00

Bernanos et les {copy}ages de la vie / actes du colloque d'Aix-en-Provence, 23,
24, 25 octobre 2008 by sous la direction de André Not
subfield code=d25,5 EUR, $US32, $LD35/subfield
RRP tax exc : 25.50

Chateaubriand et la gravité du comique by Fabio Vasarri
subfield code=d38 Ksh, ¥300, $62/subfield
RRP tax exc : 0 (uncertain)

Ecrire la sculpture, XIXe-XXe siècles / actes du colloque organisé à l'Ecole
normale supérieure et à la Maison de la recherche du 16 au 18 juin 2011 by sous
la direction d'Ivanne Rialland
subfield code=d32 EUR, 45$ CAN, 46$ USD/subfield
RRP tax exc : 32.00


= problem with Chateaubriand et la gravité du comique.
But I suppose we would never find such thing as 38 Ksh, ¥300, $62 in 010$d
(more likely Ksh38, ¥300, $62, or 38 Ksh, 300¥, 62$).

I will make other tests later

Mathieu

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10275] New: UT: OrderFromSubscription.t needs to create its own data

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275

Bug ID: 10275
   Summary: UT: OrderFromSubscription.t needs to create its own
data
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com

t/db_dependent/Acquisition/OrderFromSubscription.t depends on the Jenkins
database.
We should create the data we want and delete them at the end.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||10275

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Depends on||10273
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18201
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18201action=edit
MT10275: UT: OrderFromSubscription.t needs to create its own data

Try before the patch:
prove t/db_dependent/Acquisition/OrderFromSubscription.t

And after, it should produce:
  t/db_dependent/Acquisition/OrderFromSubscription.t .. ok
  All tests successful.
  Files=1, Tests=12,  2 wallclock secs ( 0.02 usr  0.00 sys +  0.46 cusr
  0.02 csys =  0.50 CPU)
  Result: PASS

And some warnings...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

  Attachment #18192|0   |1
is obsolete||

--- Comment #10 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Created attachment 18202
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18202action=edit
[SIGNED OFF][PATCH] Bug 10270: GetOrdersByBiblionumber needs better unit tests

Tested again.
The 2 test files 
Acquisition/GetOrdersByBiblionumber.t
and
Acquisition.t
are successful.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9288] Add a script to test SIP from the command line

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9288] Add a script to test SIP from the command line

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14640|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18203
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18203action=edit
Bug 9288 - Add a script to test SIP from the command line

This is a very basic start to a sip server testing script.
I imagine we will want to make it interactive in end,
essentially replicating what a SIP based self-checkout machine does.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

--- Comment #27 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Hey Mathieu,
My god, you are everywhere !
fallen in a magic potion barrel when a baby ?

As for Chateaubriand case, it's a normal result with euro as active currency
because there's no euro currency in the string price '38 Ksh, ¥300, $62'
As I 'd mentionned :
Whenever active currency is enabled and neather the symbol nor the isocode of
this currency is found in the price string, the resulting price is set to 0
(rather than picking the first one by default).
I did this knowingly to make clear that no price has been picked.
If first price would be picked, in your test context,38 would be the resulting
price and we could think it's in euro.

Olivier

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #11 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Jonathan, a question about:

+++ b/t/db_dependent/Acquisition/GetOrdersByBiblionumber.t
@@ -0,0 +1,84 @@
+#!/usr/bin/env perl

Why use env perl instead of perl? Note that we only use env perl in 6 Koha
files (2 in the test directory t).
I understand that it is more portable. But then we should do it more often..
All our scripts contain the fixed perl path.
Just for consistency.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10206] Add Koha TT Plugin

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA: Looking at this one now..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10206] Add Koha TT Plugin

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 QA Contact||m.de.r...@rijksmuseum.nl

--- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Kyle,
This works fine. Two questions remain:
1) To have this work, you currently do not need to do a use C4::Koha. Without
that line, it works too. Why did you add it?
2) If it can be removed, please repair the typo: replated- related :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

2013-05-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

--- Comment #28 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I did not read all your description, I must confess ;-)
Not sure to agree with this behavior if it is a new one.

I think it should be : 
- in Koha, 3 currencies = euros €, dollar $, pound £ ; and active currency =
euro

- in 010 : 40 €, 50 $
= 40 €
- in 010 : 50 $
= convert 50 $ in € using the exchange rate defined in Koha
- in 010 : 50 $, 60 ¥
= convert 50 $ in € using the exchange rate defined in Koha
(¥ should be ignored, as ¥ is not defined in Koha list of currencies)
- in 010 : 60 ¥
= 0 (undefined)
(¥ should be ignored, as ¥ is not defined in Koha list of currencies)
- in 010 : 50 $, 30 £
= 2 solutions : 
- either 0 (undefined)
- or maybe convert the first price of the list in euros, using exchange rate

What's your opinion?

Mathieu

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

  1   2   >