[Koha-bugs] [Bug 9558] Customize CSS for mobile

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9558

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #18218|0   |1
is obsolete||

--- Comment #4 from Srdjan Jankovic srd...@catalyst.net.nz ---
Created attachment 18637
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18637action=edit
[SIGNED-OFF] Bug 9558 - Customize CSS for mobile

It is possible to use an environment variable to specify a custom
stylesheet for different libraries in a multi-library system:
$ENV{'OPAC_CSS_OVERRIDE'}. This patch adds an additional option to
override the CCSR theme's mobile stylesheet.

The changes in this patch are courtesy Zachary Spalding as described in
Bug 9558. Patch and test plan created by Owen Leonard.

Signed-off-by: Srdjan srd...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9558] Customize CSS for mobile

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9558

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||srd...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think the point of having the itemtype on item level is that you often have
several different itemtypes on one record - like some items are for reference,
overnight loan, or normal loan. So the statistics would just be wrong and
missing the interesting bit, if we don't look at item level here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10385] item-level_itype checks need to be refactored

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10385

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think there has been some work to make use of the biblio level itemtype for
display in the result lists even when item level itemtypes are being used. So I
am not sure it will work for everyone to only use the itype from the level set
in the system preference. Maybe we could return 3 values? Both itemtypes for
biblio and item level and the one to be used for circulation logic?

As our libraries participate in a union catalog where the records are
imported/updated automatically into Koha, we don't set bilbio level itemtypes
at all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973

--- Comment #24 from Dobrica Pavlinusic dpav...@rot13.org ---
David, can you please post your ldap config from koha-conf.xml? From looking at
a code I agree with Rolando that setting auth_by_bind to 1 should fix your
problem (hopefully).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576

--- Comment #6 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Yes, I completely forgot, sorry.
And now the patch doesn't apply any more...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8662] Remove unused famfamfam icons

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662

--- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com ---
Sorry Owen but I always get the same error, tested on several instance :-/

Could someone else try to apply it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #5)
 Do I need to do some prep first, or some special config?
No, it is the goal of this patch :)

Since the course course are removed at the end of the test file, I think the
truncate queries are useless. I will provide a new patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #18382|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18638
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18638action=edit
Bug 10332: CourseReserves.t needs to create its own data

prove t/db_dependent/CourseReserves.t
t/db_dependent/CourseReserves.t .. ok
All tests successful.
Files=1, Tests=20,  2 wallclock secs ( 0.02 usr  0.00 sys +  0.43 cusr
0.03 csys =  0.48 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

   Priority|P5 - low|P3
   Severity|major   |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #4)
 Looks like this needs updated a bit.

Kyle, did you seen my comment 2? :)
Do you plan to work on it? That would be really good if this file passes all
the tests. I managed to pass all tests from all others files, but not these
ones.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9930] can't update patron info in ccsr

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9930

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

--- Comment #6 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to comment #5)
 Pushed to 3.10.x will be in 3.10.5

This patch depends on Bug 7067 which is only pushed in 3.12.
Actually in 3.10.x the link leads to 404 page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10399] New: rebuild_zebra.pl should reset the indexes with -r even if zebraqueue empty

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10399

Bug ID: 10399
   Summary: rebuild_zebra.pl should reset the indexes with -r even
if zebraqueue empty
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com

Currently, the only way to get indexes reset is to run the zebraidx... init by
hand on each database (authorities or biblios). This leads to several problems:
ownership, permission, wrong paths, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336

--- Comment #6 from Kyle M Hall kyle.m.h...@gmail.com ---
I read it, but I didn't fully understand it until today. I should have noticed
the WIP in the title. I hadn't planned on working on this. If I can get some
free time I'd be more than happy to assist! However, I cannot say when that may
be.

(In reply to comment #5)
 (In reply to comment #4)
  Looks like this needs updated a bit.
 
 Kyle, did you seen my comment 2? :)
 Do you plan to work on it? That would be really good if this file passes all
 the tests. I managed to pass all tests from all others files, but not these
 ones.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10399] rebuild_zebra.pl should reset the indexes with -r even if zebraqueue empty

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10399

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10399] rebuild_zebra.pl should reset the indexes with -r even if zebraqueue empty

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10399

--- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 18639
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18639action=edit
Bug 10399 - rebuild_zebra.pl should reset the indexes with -r even if
zebraqueue empty

This patch add the reset_indexes sub to the rebuild_zebra.pl script. And
changes
the scripts' logic to run it in case -r was passed and there are no records
pending
on the zebraqueue table.

Regards
To+

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361

--- Comment #3 from Mirko Tietgen mi...@abunchofthings.net ---
Actually I was thinking it should go into some kind of privacy section in the
future. There is more personal data that may have to be deleted on a regular
basis to meet privacy/data protection requirements. I see the relation to
Search.pm but it is not the place I would have been looking for this kind of
feature. And Search.pm is bloated as it is.

I'd welcome more comments on this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

  Attachment #18070|0   |1
is obsolete||
  Attachment #18265|0   |1
is obsolete||

--- Comment #35 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 18640
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18640action=edit
Bug 9593 Prices not imported correctly from a staged file

Hello Mathieu
The last patch I proposed was not coherent with the possibility to choose in
currency choice list of Accounting detail block a different currency than the
active one. It could produce a double conversion of the price. 
So, at the end, I propose again the previous patch(with marginal
modifications).
You wrote in comment 28 Not sure to agree with this behavior if it is a new
one but it's not. Even if it modifies thoroughly the MungeMarcPrice routine,
it keeps the main logic ( picking the active currency if possible) with the
advantage of finding it whatever the position of symbol or isocode regarding
the digits part.

Olivier

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #4 from Galen Charlton gmcha...@gmail.com ---
From IRC:

[06:54:14] drojf @later tell gmcharlt could you have a look at the comments
on bug 10361 please? do you agree i should move the query to Search.pm?
...
[07:16:14] gmcharlt to answer your question, if you don't want to spend too
much effort at it, I agree with Srdjan that it should go into C4::Search --
that's where AddSearchHistory and GetSearchHistory live at the moment
[07:17:05] gmcharlt if you want to take a little more time and refactor,
maybe put it in a new module called Koha::Search::History on thel ike

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10400] New: Text::CSV_XS error-checking should be standardized

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10400

Bug ID: 10400
   Summary: Text::CSV_XS error-checking should be standardized
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Label printing
  Assignee: cnighswon...@foundations.edu
  Reporter: gmcha...@gmail.com

As reported by Doug Kingston on koha-devel on 2013-06-02, if version 0.97 of
Text::CSV_XS is installed, it can segfault.  From Doug's email:

The error from t/Labels.t is a segmentation fault when calling
$csv-error_input() in Labels/Label.pm.

sub _get_text_fields {
my $format_string = shift;
my $csv = Text::CSV_XS-new({allow_whitespace = 1});
my $status = $csv-parse($format_string);
my @sorted_fields = map {{ 'code' = $_, desc = $_ }}
map { $_ eq 'callnumber' ? 'itemcallnumber' : $_ }
# see bug 5653
$csv-fields();
my $error = $csv-error_input();
warn sprintf('Text field sort failed with this error: %s', $error) if
$error;
return \@sorted_fields;
}

A ticket was opened with the maintainer of Text::CSV_XS
(https://rt.cpan.org/Ticket/Display.html?id=85810), and he fixed the segfault
bug in version 0.98 of the module.

Nonetheless, Koha code that uses Text::CSV_XS should follow the module's
documentation more closely; in particular, it looks like the correct thing to
do is the check the value of the $status returned by $csv-parse() before
deciding whether to invoke error_input().

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10385] item-level_itype checks need to be refactored

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10385

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
In light of that... how about no syspref at all?

What I mean is that we make *both* biblio- and item-level item types visible. 
For the sake of clarity, I'll call the biblo-level ones material types.

For circulation rules, *both* the item type and the material type could be
taken into account by adding a material type column to issuingrules (and on
upgrade, populating it based on the value of the syspref).

For OPAC display, allow icons to be associated with both material types and
item types.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10400] Text::CSV_XS error-checking should be standardized

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10400

--- Comment #1 from Galen Charlton gmcha...@gmail.com ---
Also, in that snippet of code, there's no point in calling -fields() until we
know that the parsing was successful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10384] Software error when LDAP connexion fails

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10384

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #18540|0   |1
is obsolete||

--- Comment #3 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 18641
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18641action=edit
Proposed patch

Here is a new patch with warn regardless to debug mode.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #18367|0   |1
is obsolete||
  Attachment #18370|0   |1
is obsolete||
  Attachment #18371|0   |1
is obsolete||

--- Comment #34 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18642
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18642action=edit
Bug 9129 - Add the ability to set the maximum fine for an item to its
replacement price

This patch adds the ability to set the maximum fine for a given item to
its replacement price ( assuming the replacement price is set ). If
overduefinescap is also set, the fine will be the lesser of the two, if
both apply to the given overdue checkout.

To enable this new limit, create or edit your circulation rules and
check the checkbox for Cap fines at replacement price

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Pick an item, and set it's replacement price to 3.99
4) Edit the circulation rule that would apply to this item
   and the patron you will check it out to.
5) Check out the item to the patron, and backdate the due date
   such that the fine generated would be more than 3.99
6) Enable CalculateFinesOnReturn
7) Return the item, and view the fine generated, it should be 3.99

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #18642|0   |1
is obsolete||

--- Comment #35 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18643
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18643action=edit
Bug 9129 - Add the ability to set the maximum fine for an item to its
replacement price

This patch adds the ability to set the maximum fine for a given item to
its replacement price ( assuming the replacement price is set ). If
overduefinescap is also set, the fine will be the lesser of the two, if
both apply to the given overdue checkout.

To enable this new limit, create or edit your circulation rules and
check the checkbox for Cap fines at replacement price

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Pick an item, and set it's replacement price to 3.99
4) Edit the circulation rule that would apply to this item
   and the patron you will check it out to.
5) Check out the item to the patron, and backdate the due date
   such that the fine generated would be more than 3.99
6) Enable CalculateFinesOnReturn
7) Return the item, and view the fine generated, it should be 3.99

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com ---
This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks for the fix
Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access'

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #11 from Tomás Cohen Arazi tomasco...@gmail.com ---
This patch has been pushed to 3.12.x, will be in 3.12.1.

Leaving as ASSIGNED, waiting for the followups.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292

--- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com ---
(In reply to comment #6)
 This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks for the fix
 Kyle!

Thanks Galen, I mixed my bug comments with 10262 :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #16 from Tomás Cohen Arazi tomasco...@gmail.com ---
This patch has been pushed to 3.12.x, will be in 3.12.1.

Thanks Kyle for the fix!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access'

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218

--- Comment #12 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Sorry, my VM is broken, so the followups won't be there until some days...

Mathieu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10401] New: Add ability to merge invoices

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10401

Bug ID: 10401
   Summary: Add ability to merge invoices
Classification: Unclassified
 Change sponsored?: Sponsored
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: new feature
  Priority: P5 - low
 Component: Acquisitions
  Assignee: jcam...@cpbibliography.com
  Reporter: jcam...@cpbibliography.com

In situations where items from a single vendor invoice are received on more
than one Koha invoice, it would be really useful to be able to merge invoices.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] New: Add multiple contacts for vendors

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Bug ID: 10402
   Summary: Add multiple contacts for vendors
Classification: Unclassified
 Change sponsored?: Sponsored
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: new feature
  Priority: P5 - low
 Component: Acquisitions
  Assignee: jcam...@cpbibliography.com
  Reporter: jcam...@cpbibliography.com

Some vendors may have more than one contact. For example, a technical contact
and a billing contact, or a contact for journals and a contact for monographs.
Rather than require that each contact be either made into a separate vendor or
recorded somewhere outside of Koha, it would be really useful of Koha had the
ability to add multiple additional contacts to vendors i the acquisitions
module.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351

--- Comment #10 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to comment #9)
And do you agree with the patch ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10403] New: Add ability to set fund/budget on receipt

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10403

Bug ID: 10403
   Summary: Add ability to set fund/budget on receipt
Classification: Unclassified
 Change sponsored?: Sponsored
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: jcam...@cpbibliography.com
  Reporter: jcam...@cpbibliography.com

Right now there is no way to change the budget or fund when receiving an item,
which is annoying, particularly at the end of the fiscal year when every item
not already received has to be switched to the following year's budget. This
development will add the ability to change the budget and fund when receiving.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10404] New: Add previous/next browsing to staff client search results

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404

Bug ID: 10404
   Summary: Add previous/next browsing to staff client search
results
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: new feature
  Priority: P5 - low
 Component: Staff Client
  Assignee: jcam...@cpbibliography.com
  Reporter: jcam...@cpbibliography.com
CC: gmcha...@gmail.com

There is currently no way to go to the next record in a search result list on
the staff client, and there really should be some sort of previous/next browse
functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5695] Cart display should show proper item type

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5695

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10405] New: User-editable sections should have ids

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10405

Bug ID: 10405
   Summary: User-editable sections should have ids
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: jcam...@cpbibliography.com

Right now the following user-editable sections do not have css ids:
opacheader
OpacNavBottom
OpacNavRight
OpacSearchForTitleIn
OpacUserCSS
opacuserjs

They should.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10406] New: Remove obsolete CSS related to YUI autocomplete

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10406

Bug ID: 10406
   Summary: Remove obsolete CSS related to YUI autocomplete
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org

There are a couple of sections in staff-global.css which relate to YUI
autocomplete. Since this has been replaced with jQueryUI autocomplete they can
be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10406] Remove obsolete CSS related to YUI autocomplete

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10406

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Created attachment 18644
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18644action=edit
Bug 10406 - Remove obsolete CSS related to YUI autocomplete

staff-global.css contains CSS which related to the old YUI autocomplete
widget. Since this has been replaced with jQueryUI the CSS is now unused
and can be removed.

To test, apply the patch and confirm that autocomplete looks correct and
works correctly in the global circulation search box (with CircAutocompl
enabled) and in the overdues report when entering a value into the
filter form in a patron attribute field which is linked to an authorized
value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10406] Remove obsolete CSS related to YUI autocomplete

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10406

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #18638|0   |1
is obsolete||

--- Comment #8 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 18645
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18645action=edit
Bug 10332: CourseReserves.t needs to create its own data

prove t/db_dependent/CourseReserves.t
t/db_dependent/CourseReserves.t .. ok
All tests successful.
Files=1, Tests=20,  2 wallclock secs ( 0.02 usr  0.00 sys +  0.43 cusr
0.03 csys =  0.48 CPU)
Result: PASS

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com
Without correct data, test fails prior to patch, passes no matter what
after patch is applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This one does not work for me. I get the following output (with DEBUG on):

jcamins@kohadev:~/kohaclone$ perl t/db_dependent/Reserves.t 
1..4
ok 1 - use C4::Reserves;
# 
# Creating biblio instance for testing.
# Creating item instance for testing.
 INSERT INTO borrowers SET   borrowers.firstname = ? ,  borrowers.dateenrolled
= ? ,  borrowers.userid = ? ,  borrowers.categorycode = ? ,  borrowers.surname
= ? ,  borrowers.dateexpiry = ? ,  borrowers.password = ? , 
borrowers.cardnumber = ? ,  borrowers.branchcode = ? my
firstname,2013-06-04,myfirstname.mysurname,S,my
surname,2021-09-04,!,CARDNUMBER42,CPL at
/home/jcamins/kohaclone/C4/SQLHelper.pm line 182.
SELECT borrowers.*, categories.category_type, categories.description
FROM borrowers 
LEFT JOIN categories on borrowers.categorycode=categories.categorycode
WHERE borrowernumber = ? 75 at /home/jcamins/kohaclone/C4/Members.pm line 556.
SELECT borrowers.*, categories.category_type, categories.description
FROM borrowers 
LEFT JOIN categories on borrowers.categorycode=categories.categorycode
WHERE borrowernumber = ? 75 at /home/jcamins/kohaclone/C4/Members.pm line 556.
not ok 2 - CheckReserves Test 1
#   Failed test 'CheckReserves Test 1'
#   at t/db_dependent/Reserves.t line 66.
SELECT borrowers.*, categories.category_type, categories.description
FROM borrowers 
LEFT JOIN categories on borrowers.categorycode=categories.categorycode
WHERE borrowernumber = ? 75 at /home/jcamins/kohaclone/C4/Members.pm line 556.
not ok 3 - CheckReserves Test 2
#   Failed test 'CheckReserves Test 2'
#   at t/db_dependent/Reserves.t line 69.
SELECT borrowers.*, categories.category_type, categories.description
FROM borrowers 
LEFT JOIN categories on borrowers.categorycode=categories.categorycode
WHERE borrowernumber = ? 75 at /home/jcamins/kohaclone/C4/Members.pm line 556.
not ok 4 - CheckReserves Test 3
#   Failed test 'CheckReserves Test 3'
#   at t/db_dependent/Reserves.t line 72.
# Deleting item testing instance.
# Deleting biblio testing instance.
# Deleting borrower.
# Looks like you failed 3 tests of 4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com ---
I am not sure this one is right. It looks like the DelOrder calls are hardcoded
to expect the bib records to have biblionumbers 1-3, which doesn't make sense
to me. Should it perhaps be DelOrder($biblionumber1, $ordernumber1) ... etc.?

Setting to In Discussion in case I am misunderstanding the code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #18235|0   |1
is obsolete||

--- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 18646
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18646action=edit
Bug 10249: Fix untranslatable strings in OPAC detail page

Star ratings feature:
- Your CGI session cookie is not current. Please refresh
  the page and try again.
- average rating:
- your rating:

Browse results feature:
- Click to rewind the list to
- See biblio
- with biblionumber
- by (between title and author)
- Click to forward the list to
- Go to detail

To test:
- Update the po file using 'perl translate update langcode'
- Translate all new strings, maybe mark them with XX to make it easier
  to find them
- Install the updated translation file using 'perl translate install
  langcode'
- Test the ratings and browse results features in the OPAC detail page
- Verify everything is still working/displaying like it should
- Check that you don't find any unstranslated strings/terms

Some hints where the changes are:
- Change an existing rating - the average and your rating will change
- Browse result list and check mouse over tooltips for all links

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com
Strings are now translated, and no emergent JS errors have revealed
themselves.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639

--- Comment #32 from Kyle M Hall kyle.m.h...@gmail.com ---
Melia is correct, the each enable different functionality.

(In reply to comment #31)
 I think they are two different things - one is concerned with overdue fines
 only, and the other is concerned with paying/refunding the replacement price.
 
 ForgiveFineWhenLost - an item goes overdue and starts to accrue fines. 
 Eventually, it goes to lost status but has maybe accrued $300 in overdue
 fines already.  Now that the item is lost, the library wants to charge the
 replacement price for the lost item but is not concerned about collecting
 the $300 in overdue fines.  So this sys pref lets you forgive all of the
 overdue fines when the item goes to lost.
 
 RefundLostItemFeeOnReturn - an item goes to lost, and the replacement price
 is charged.  But then later the patron finds the lost item and returns it. 
 Right now, I think Koha refunds the replacement price to the patron.  Some
 libraries aren't allowed to refund money that patrons have already paid
 them, so this sys pref makes it so that you can choose whether the
 replacement price is refunded to the patron or not.  ('He found the book, so
 he is not required to pay the replacement price any more and gets a refund'
 versus 'He kept the book for so long that we thought it was lost, so now he
 must pay regardless').
 
 At least I think that's the idea...  Kyle, please correct me if I got any of
 that is wrong!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10307] z39.50 server search tab shows z390.50

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10307

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
Version|3.12|master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10307] z39.50 server search tab shows z390.50

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10307

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Created attachment 18647
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18647action=edit
Bug 10307 - z39.50 server search tab shows z390.50

The label on the global search form for Z39.50 administration reads
Z390.50. This patch corrects the typo.

To test, apply the patch and navigate to Administration - Z39.50
servers. The label on the global search tab should read Search Z39.50
servers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10307] z39.50 server search tab shows z390.50

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10307

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10307] z39.50 server search tab shows z390.50

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10307

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10307] z39.50 server search tab shows z390.50

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10307

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
Trivial string patch; pushing directly to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10307] z39.50 server search tab shows z390.50

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10307

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10407] New: allow MARCXML records to be imported via Koha's GUI

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

Bug ID: 10407
   Summary: allow MARCXML records to be imported via Koha's GUI
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic record staging/import
  Assignee: gmcha...@gmail.com
  Reporter: m...@kohaaloha.com

currently, you can only import MARCXML records into Koha using the
./bulkmarcimport.pl tool, from the command-line


this bug will attempt to add that functionality to Koha's GUI

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10408] New: allow Koha to automatically link to authoritiy records, when importing bibs

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10408

Bug ID: 10408
   Summary: allow Koha to automatically link to authoritiy
records, when importing bibs
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic record staging/import
  Assignee: gmcha...@gmail.com
  Reporter: m...@kohaaloha.com

currently, Koha does not attempt to link bibs to existing auth records, during
bib import

this bug will attempt to add that functionality

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED
Version|3.14|master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10409] New: Do not show course entry form if no departments are found

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409

Bug ID: 10409
   Summary: Do not show course entry form if no departments are
found
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/course_reserves/course.pl
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Course reserves
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org

The course reserves entry form shows an error message instead of a form field
for the department if no departments are defined: No DEPARTMENT authorised
values found! Please create one or more authorised values with the category
DEPARTMENT.

If you can't fill out the form because there are no departments, there's no
reason to display the form. Otherwise people might fill in the rest of the
fields and find they can't submit the form.

It would be better to show the error message alone on the page and link the
user to the authorized values page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||m...@kohaaloha.com

--- Comment #8 from Mason James m...@kohaaloha.com ---
(In reply to comment #7)
 Created attachment 18108 [details] [review]
 Bug 10096 [DB Follow-up] - Add a Z39.50 interface for authority searching
 
 This patch adds the recordtype column to the z3950servers table.
 
 The value in this column (biblio or authority) then controls whether
 the z3950 server shows up in a bibliographic search (through the
 Acq and Cataloguing modules) or in an authority search (through
 the Authorities module).
 
 I also edited the z3950 management console to show this value
 and allow users to edit it. The default value is biblio, since
 the vast majority of z3950 targets will be bibliographic. However,
 there is an option to add/edit a z3950 target as a source of
 authority records.
 
 Test Plan:
 
 1) Apply both patches

hmm, the 2nd patch does not apply to master (b74ac4a)

---
head$ git reset --hard origin/master
HEAD is now at b74ac4a Bug 10307 - z39.50 server search tab shows z390.50
mason@xen1:~/g/head$ git bz attach 10096

Bug 10096 - Add a Z39.50 interface for authority searching (2)
Apply? [yn] y

Applying: Bug 10096 - Add a Z39.50 interface for authority searching
Bug 10096 [DB Follow-up] - Add a Z39.50 interface for authority searching
Apply? [yn] y

Applying: Bug 10096 [FOLLOW-UP] - Add a z39.50 interface for authority
searching
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 10096 [FOLLOW-UP] - Add a z39.50 interface for
authority searching
---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

--- Comment #1 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I agree it is a needed feature.
For example, if librarians want to use a tool like Zotero to gather
bibliographic references on the web, and import the result into Koha for
creating orders, presently, they need to use an extra-koha tool for converting
marcxml records into iso2709 records.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #18108|0   |1
is obsolete||

--- Comment #9 from Mason James m...@kohaaloha.com ---
Created attachment 18648
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18648action=edit
Bug 10096 [FOLLOW-UP] - Add a z39.50 interface for authority searching

This patch adds the recordtype column to the z3950servers table.

The value in this column (biblio or authority) then controls whether
the z3950 server shows up in a bibliographic search (through the
Acq and Cataloguing modules) or in an authority search (through
the Authorities module).

I also edited the z3950 management console to show this value
and allow users to edit it. The default value is biblio, since
the vast majority of z3950 targets will be bibliographic. However,
there is an option to add/edit a z3950 target as a source of
authority records.

Test Plan:

1) Apply both patches
2) Run updatedatabase.pl (after setting your KOHA_CONF and PERL5
environmental variables)
3) Use the test plan from the 1st patch

N.B. Make sure that your Z39.50 client target has a Record Type
of Authority, otherwise it won't display when you're doing a
Z3950 search for authorities.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096

--- Comment #10 from Mason James m...@kohaaloha.com ---
  Test Plan:
  
  1) Apply both patches
 
 hmm, the 2nd patch does not apply to master (b74ac4a)
 

i've uploaded a 2nd patch that does apply to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9747] sort issue for the z3950 results

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||ch...@bigballofwax.co.nz

--- Comment #9 from Chris Cormack ch...@bigballofwax.co.nz ---
Conflict in  koha-tmpl/intranet-tmpl/prog/en/js/datatables.js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #12 from Chris Cormack ch...@bigballofwax.co.nz ---
I like the idea of use Net::Printer,  but did you know there is already a
printer queue and a script to set the printer (network one).

This could be generalised to use this
Check admin/printers.pl

And
DROP TABLE IF EXISTS `printers`;
CREATE TABLE `printers` (
  `printername` varchar(40) NOT NULL default '',
  `printqueue` varchar(20) default NULL,
  `printtype` varchar(20) default NULL,
  PRIMARY KEY  (`printername`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

So i'd like to see it use this (extended if nessecary). 

Will put this to In discussion and will wait for an opinion from Galen, if he
is happy with it as it is, I will continue with QA on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||ch...@bigballofwax.co.nz

--- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz ---
This seems to work well, 

1/ but could you please do a follow up fixing the text in the
ilsdi.pl?service=Describeverb=CancelHold page

2/ Also we introduce 2 new subroutines, so could we get a unit test for each
one.

3/ Finally we do this

$query = qq{
INSERT INTO old_reserves
SELECT * FROM reserves
WHERE reserve_id = ?
};
$sth = $dbh-prepare($query);
$sth-execute($reserve_id);

$query = qq{
DELETE FROM reserves
WHERE reserve_id = ?
};
$sth = $dbh-prepare($query);
$sth-execute($reserve_id);

It would be safer/nicer to check the result of our execute into the
old_reserves before we delete it from reserves, if that insert fails we do the
delete anyway at the moment

Failing QA for 1 and 2, bonus points if you fix 3 also

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8600] Remove search terms in advanced search

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8600] Remove search terms in advanced search

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #16592|0   |1
is obsolete||

--- Comment #21 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 18649
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18649action=edit
Bug 8600 - Remove search terms in advanced search

Rewrote parts of previous patch by Marc Veron to remove remove href and onclick
of links and instead use jQuery

Signed-off-by: Cedric Vita cedric.v...@dracenie.com
Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10358] add a syspref to allow BLOCKED patrons to return items, via the SCO

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10358

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

Summary|Unable to return *overdue*  |add a syspref to allow
   |items via self check|BLOCKED patrons to return
   ||items, via the SCO

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7382] normalization on isbn matching rule

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7382

JaTara Barnes jenday...@gmail.com changed:

   What|Removed |Added

 CC||jenday...@gmail.com

--- Comment #4 from JaTara Barnes jenday...@gmail.com ---
What's a good starting point for getting this fixed? I'd love to help with this
project.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9728] XISBN use simple search instead of SQL

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9728

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #16633|0   |1
is obsolete||

--- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 18650
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18650action=edit
Bug 9728: XISBN use simple search instead of SQL

XISBN API uses normalized ISBN of a biblio to get a list of ISBNs, then
searches via SQL in database for notices with those ISBNs.

I noticed that if input ISBN has hyphens then returned ISBNs have hyphens else
they don't have. So SQL query will not find if ISBNs have hyphens in database.
Also, if biblio has several ISBN, only first one can be found with actual SQL
query (isbn LIKE '$xisbn%').

This patch replaces SQL query by a simple search nb=$xisbn. This will find
biblio from ISBN with or without hyphen.

Test plan :
- Activate FRBRizeEditions and XISBN sysprefs
- Go to a biblio witch has several editions
- Note its normalized ISBN (you may look in amazon links)
- Replace [ISBN] by biblio normalized ISBN in this URL :
http://xisbn.worldcat.org/webservices/xid/isbn/[ISBN]?method=getEditionsformat=xmlfl=form,year,lang,ed
- Go to this URL and see which ISBNs are returned
- Perform a simple search on thoses ISBNs : nb:1234567890
- Look at Editions tab
= Check that diplayed biblios are the same you found by simple search

Signed-off-by: jmbroust jean-manuel.bro...@univ-lyon2.fr
Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9728] XISBN use simple search instead of SQL

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9728

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332

--- Comment #9 from Srdjan Jankovic srd...@catalyst.net.nz ---
I know this is not the right forum to raise the topic, but I've done worse
things in my life:

When I do this kind of testing, I do it within a transaction, and rollback at
the end. That way I do not need to think about a proper cleanup. Has there been
any thoughts on that subject?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10410] New: SCO displays 'return this item' even if item's barcode is not found

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10410

Bug ID: 10410
   Summary: SCO displays 'return this item' even if item's barcode
is not found
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Self checkout
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m...@kohaaloha.com

Created attachment 18651
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18651action=edit
pic

currently in the SCO, when returning an item - the SCO displays 'return this
item' even if item's barcode is not found

pic attached

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332

--- Comment #10 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #9)
 I know this is not the right forum to raise the topic, but I've done worse
 things in my life:
 
 When I do this kind of testing, I do it within a transaction, and rollback
 at the end. That way I do not need to think about a proper cleanup. Has
 there been any thoughts on that subject?

I love that idea! But I have no idea if it's possible to do that within our
existing code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299

--- Comment #2 from Srdjan Jankovic srd...@catalyst.net.nz ---
Created attachment 18652
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18652action=edit
bug_9299: rework unique attributes check on ldap login

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #3 from Srdjan Jankovic srd...@catalyst.net.nz ---
To test:

Have ldap server set up in koha-conf.xml and  ExtendedPatronAttributes syspref
enabled, with no extended attributes defined.
Successful login should not throw an exception.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

Pierre Angot tredok.pie...@gmail.com changed:

   What|Removed |Added

 CC||tredok.pie...@gmail.com

--- Comment #2 from Pierre Angot tredok.pie...@gmail.com ---
+1 !
It's really a good idea !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10411] New: Add cache control headers to static resources in the apache config

2013-06-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411

Bug ID: 10411
   Summary: Add cache control headers to static resources in the
apache config
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ro...@catalyst.net.nz
CC: ro...@catalyst.net.nz

Currently, the static resources aren't explicitly cached. In the case of
firefox, this causes a request every time for every image, that usually results
in a 304 Not Modified response. This isn't a good use of apache's time, also
may make the page appear to render a bit slower.

The patch for this will put a 12 hour cache timeout on the images, javascript,
and CSS files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/