[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #45 from Julian Maurice julian.maur...@biblibre.com --- Hi Katrin, thank you for the review. This patch fixes 1) 2) and 3) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299 Nuño López Ansótegui nu...@masmedios.com changed: What|Removed |Added Attachment #18652|0 |1 is obsolete|| Status|Needs Signoff |Signed Off CC||nu...@masmedios.com Assignee|srd...@catalyst.net.nz |nu...@masmedios.com --- Comment #4 from Nuño López Ansótegui nu...@masmedios.com --- Created attachment 19861 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19861action=edit [SIGNED-OFF] bug_9299: rework unique attributes check on ldap login Works fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299 Nuño López Ansótegui nu...@masmedios.com changed: What|Removed |Added Version|3.10|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9253] If an item is reserved, at the opac it is marked as available
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Assignee|mi...@abunchofthings.net|oleon...@myacpl.org --- Comment #9 from Mirko Tietgen mi...@abunchofthings.net --- Not sure why this bug was assigned to me, I am not working on this so I reset it to default -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10628] New: AutomaticItemReturn prevents holds queue from filling local holds with local items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 Bug ID: 10628 Summary: AutomaticItemReturn prevents holds queue from filling local holds with local items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com For some reason, C4::HoldsQueue::MapItemsToHoldRequests uses the system preference AutomaticItemReturn to decide if an attempt to fill local holds with local items. No explanation of this behavior is provided. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19862 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19862action=edit Bug 10628 - AutomaticItemReturn prevents holds queue from filling local holds with local items For some reason, C4::HoldsQueue::MapItemsToHoldRequests uses the system preference AutomaticItemReturn to decide if an attempt to fill local holds with local items. No explanation of this behavior is provided. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- I could not come up with a reliable test plan for this bug. However, inspection of the code should be extremely simple. The patch actually contains two changes, either of which solves the problem, but I see no reason not to include both. The first is is the removal of the use of AutomaticItemReturn to control if we should try filling local holds with local items. The second is the rather strange situation where the least_cost_branch subroutine completely ignores the fact that the pickup branch might be in the list of branches that can be pulled from. I suggest both be implemented, the former for the fact that I cannot find any reason for this behavior, and the latter ( though obviated by the former ) because in the future someone may again modify the holds queue system and not realize that some code in MapItemsToHoldRequests would make this addition to least_cost_branch unnecessary. It seems to me that a unit test for least_cost_branch should fail immediately in it's current state. However, there is, for some reason, no unit test for least_cost_branch itself in HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19863 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19863action=edit Bug 10628 - AutomaticItemReturn prevents holds queue from filling local holds with local items - Add unit test from least_cost_branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 --- Comment #7 from Owen Leonard oleon...@myacpl.org --- I picked up this patch because it looked useful and wasn't getting a follow-up from the original author. I think Galen's suggestions would make this better, but someone else would have to take it from here. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #30 from kenza kenza.z...@biblibre.com --- Created attachment 19864 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19864action=edit C4::Branch.pm needs unit tests Unit tests are wrap in a transaction. To test: prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207. t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=36, 1 wallclock secs ( 0.02 usr 0.02 sys + 0.13 cusr 0.01 csys = 0.18 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #31 from kenza kenza.z...@biblibre.com --- (In reply to kenza from comment #30) Created attachment 19864 [details] [review] C4::Branch.pm needs unit tests Unit tests are wrap in a transaction. To test: prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207. t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=36, 1 wallclock secs ( 0.02 usr 0.02 sys + 0.13 cusr 0.01 csys = 0.18 CPU) Result: PASS Now, the patch only does the tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10629] New: Inappropriate uses of $sth-finish() in C4::Branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 Bug ID: 10629 Summary: Inappropriate uses of $sth-finish() in C4::Branches Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: kenza.z...@biblibre.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 kenza kenza.z...@biblibre.com changed: What|Removed |Added Blocks||10629 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10629] Inappropriate uses of $sth-finish() in C4::Branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||kenza.z...@biblibre.com Depends on||10508 Assignee|gmcha...@gmail.com |kenza.z...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 kenza kenza.z...@biblibre.com changed: What|Removed |Added Blocks|10629 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10629] Inappropriate uses of $sth-finish() in C4::Branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 kenza kenza.z...@biblibre.com changed: What|Removed |Added Depends on|10508 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10401] Add ability to merge invoices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10401 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #19523|0 |1 is obsolete|| --- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 19865 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19865action=edit Bug 10401: Add ability to merge invoices Given how easy it is to accidentally receive items from one invoice on multiple invoices, the ability to merge invoices can be quite handy. This patch adds that ability to Koha's Acquisitions module. To test: 1) Apply patch. 2) Run unit test: prove t/db_dependent/Acquisition/Invoices.t 3) Create two invoices from the same vendor for merging, and receive at least one order on each. 4) Do a search on the Invoices page that brings up both the invoices you created. 5) Check the boxes next to the two invoices. 6) Click Merge selected invoices. 7) Choose which invoice you want to keep (the default will be the first). 8) Click Merge. 9) Confirm that the resulting invoice has all the orders you received listed on it. 10) Sign off. Rebased on latest master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10629] Inappropriate uses of $sth-finish() in C4::Branch.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 kenza kenza.z...@biblibre.com changed: What|Removed |Added Summary|Inappropriate uses of |Inappropriate uses of |$sth-finish() in |$sth-finish() in |C4::Branches|C4::Branch.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 kenza kenza.z...@biblibre.com changed: What|Removed |Added Depends on||10629 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10626] Remove doubled up TT plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10629] Inappropriate uses of $sth-finish() in C4::Branch.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 kenza kenza.z...@biblibre.com changed: What|Removed |Added Blocks||10508 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10626] Remove doubled up TT plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19866 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19866action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaAuthorisedValues.pm AuthorisedValues.pm Test Plan: 1) Apply this patch 2) View the pages that this patch has modified, make sure the branch name is still visible -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10626] Remove doubled up TT plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10626] Remove doubled up TT plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #19866|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19867 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19867action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaAuthorisedValues.pm AuthorisedValues.pm Test Plan: 1) Apply this patch 2) View the pages that this patch has modified, make sure the branch name is still visible -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10629] Inappropriate uses of $sth-finish() in C4::Branch.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10629] Inappropriate uses of $sth-finish() in C4::Branch.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 --- Comment #1 from kenza kenza.z...@biblibre.com --- Created attachment 19868 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19868action=edit Inappropriate uses of $sth-finish() in C4::Branch.pm Test plan : Check if the regression tests still works prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207. t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=36, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.12 cusr 0.00 csys = 0.16 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #103 from Jared Camins-Esakov jcam...@cpbibliography.com --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10626] Remove doubled up TT plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19869 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19869action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaBranchName.pm Branches.pm Test Plan: 1) Apply this patch 2) View a basket group, note the branch name is displayed 3) View a subscription's details, note the branch name is displayed 4) View suggestions, note the branch names are displayed 5) Return an item that needs transfered, note the branch name is displayed 6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10626] Remove doubled up TT plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #19869|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19870 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19870action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaBranchName.pm Branches.pm Test Plan: 1) Apply this patch 2) View a basket group, note the branch name is displayed 3) View a subscription's details, note the branch name is displayed 4) View suggestions, note the branch names are displayed 5) Return an item that needs transfered, note the branch name is displayed 6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #104 from Jared Camins-Esakov jcam...@cpbibliography.com --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov jcam...@cpbibliography.com Testing upload again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #105 from Jared Camins-Esakov jcam...@cpbibliography.com --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov jcam...@cpbibliography.com Testing uploading again, this time with git-bz actually installed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #106 from Jared Camins-Esakov jcam...@cpbibliography.com --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov jcam...@cpbibliography.com Let's try this once more. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #107 from Jared Camins-Esakov jcam...@cpbibliography.com --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov jcam...@cpbibliography.com Argh! Why does it hate me?!? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 --- Comment #9 from Owen Leonard oleon...@myacpl.org --- When I tested this I found that I did not see the custom message if the item was on hold (prompting a hold message) or required a transfer (prompting a transfer message). Is this a bug, or is it by design? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #109 from Jared Camins-Esakov jcam...@cpbibliography.com --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov jcam...@cpbibliography.com Unfortunately, configuring git-bz is harder than it looks. Maybe. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #110 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 19871 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19871action=edit Bug 10403: add ability to change fund on receipt Right now there is no way to change the budget or fund when receiving an item, which is annoying, particularly at the end of the fiscal year when every item not already received has to be switched to the following year's budget. This patch adds the ability to change the budget and fund when receiving. To test: 1) Apply patch. 2) Create an order for a vendor, choosing a fund to use for that order. 3) Receive the order, leaving the fund unchanged. Make sure the fund did not change. 4) Create another order for a vendor, choosing a fund to use for that order. 5) Receive the order, this time changing the fund. Make sure the fund is changed. 6) Run the unit test: prove t/db_dependent/Acquisition.t 7) Sign off. (Notes: this patch depends on the Acquisitions.t unit test improvements in bug 10274; the seemingly-unrelated change in SQLHelper quiets an irritating warning caused by the NewOrder call in ModReceiveOrder) Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #19871|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #111 from Jared Camins-Esakov jcam...@cpbibliography.com --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov jcam...@cpbibliography.com Ah-ha! When using koha-gitify, git-bz has to work for *TWO* users. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #108 from Jared Camins-Esakov jcam...@cpbibliography.com --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov jcam...@cpbibliography.com The problem was git-bz wasn't fully configured, I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #112 from Jared Camins-Esakov jcam...@cpbibliography.com --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov jcam...@cpbibliography.com Actually, it looks like Apache just massacres the environment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Attachment #19836|0 |1 is obsolete|| --- Comment #27 from Mirko Tietgen mi...@abunchofthings.net --- Created attachment 19872 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19872action=edit Bug 8897 [ENH] GPG Mail encryption -- New version Koha should offer patrons the option to receive their emails encrypted. This patch adds a dialog to the user interface (OPAC side) for patrons to add or delete a GPG public key. The key is directly added to or deleted from gpg (gnupg needs to be installed, binary expected at /usr/bin/gpg). This feature does not require sysadmins/librarians to do anything as long as the gpg binary if found. So far, mails are encrypted if a key for the recipient is avaliable - when sending lists or carts (encryption of email text + attachment) - when mails are sent through the message queue - … Missing so far: - hide public key interface from OPAC/userdetails when no binary is found - de-hardcode path to gpg (syspref) - deal with BCC mails (send message explaining that an encrypted email has been send to the patron instead of a BCC) - … Maybe later: - library-side key management: secret key for signing - encryption of emails from library to vendors - … Test plan: -apply patch * Add/delete key: - in OPAC, log in as a user you got GPG kes for (primary email needs to match the key) - go to user details, email encryption - paste your public key into the form, save. when the page reloads, your key should be displayed in the form and a delete button at the bottom. in the terminal (as the koha-user!), do 'gpg --list-keys' and verify the key you just added is present - press the delete button under the form. on reload the form should be empty and your key gone. verify with (as the koha user) 'gpg --list-keys' in the terminal. - paste your key into the form again and save to do the following tests. * Encrypted cart emails - do a search, save a record in the the cart. open the cart, send it to the adress you added the key for. - check if the mail you receive has encrypted text and an encrypted attachment - decrypt both the text and the attachment, check if they are what you would expect * Encrypted list emails - if you do not have any lists, set up one with one record. - open the list from the opac, send it to you. enter the address you just added the key for - check that the mail you receive has encrypted text and an encrypted attachment. - decrypt both the text and the attachment, check if they are what you would expect * Encrypted message queue emails - check some items in and out for the patron you added the key for - wait for the message queue cronjob to run or run it manually - check if the email(s) you receive are encrypted and after decryption contain what you would expect Check all this again with another patron (without a gpg key) or use the same but delete the key before. Check that all mails and attachments are unencrypted and contain what you would expect (nothing is broken). If all that works for you, sign off the patch. Squashed a few minor changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Attachment #19840|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #19697|0 |1 is obsolete|| --- Comment #4 from Owen Leonard oleon...@myacpl.org --- Created attachment 19873 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19873action=edit [SIGNED-OFF] Bug 10195 Records hidden with OpacSuppression can still be accessed Records hidden with OpacSuppression are filtered from the search results, but the opac-detail page is still visible if you know the biblio number. This patch hides the detail page for suppressed biblios by redirecting (controlled by the syspref OpacSuppressionRedirect) either to opac-blocked (default), explaining that the record is blocked (including optional explanatory text from the syspref OpacSuppressionMessage) or to Koha's 404 page, giving no hint that a biblio with that number exists in the system. Test plan: Make sure you have at least one record with 942$n == 1. Set OpacSuppression to Don't hide. Do an OPAC search that should bring up your hidden record and other records. Observe that your record is found. Open the detail page for the record. Observe that it is accessible. Copy the URL for later(!). Set OpacSuppression to Hide. Leave OpacSuppressionByIPRange blank. Set OpacSuppressionRedirect to an explanatory page ('This record is blocked'). Leave OpacSuppressionMessage blank for now. Disable queryparser(!) (because of bug 10542). Do a full zebra reindex. Do an OPAC search that should bring up your hidden record and other records. Observe that your record is not found. Open the opac-detail URL of the record (the one you copied before). Observe that you are redirected to opac-blocked and it displays a short standard message. Edit OpacSuppressionMessage and input some text. Open the opac-detail URL of the record again (the one you copied before). Observe that the text you entered in OpacSuppressionMessage is displayed under the standard text you have seen before. Set OpacSuppressionRedirect to the 404 error page ('Not found'). Open the opac-detail URL of the record again (the one you copied before). Observe that you are redirected to Koha's 404 error page. Sign off the patch. :) Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #158 from Kyle M Hall k...@bywatersolutions.com --- RFC: http://wiki.koha-community.org/wiki/Online_Borrower_Registration_RFC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 --- Comment #13 from kenza kenza.z...@biblibre.com --- Created attachment 19874 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19874action=edit C4::Bookseller.pm need unit tests The tests are wrap in a transaction. NOTE: some tests should pass but doesn't because of incoherences in the code. These tests are in comments and preceded by FIXME Test plan: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 15/53 [Some warnings about uninitialised values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=53, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.46 cusr 0.03 csys = 0.51 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 kenza kenza.z...@biblibre.com changed: What|Removed |Added Blocks||10630 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza kenza.z...@biblibre.com changed: What|Removed |Added Depends on||10628 Assignee|koha-b...@lists.koha-commun |kenza.z...@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10630] New: DelBookseller's return value needs to be more explicit in C4::Bookseller.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Bug ID: 10630 Summary: DelBookseller's return value needs to be more explicit in C4::Bookseller.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: kenza.z...@biblibre.com QA Contact: testo...@bugs.koha-community.org DelBookSeller always returns undef, even if nothing has been deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 kenza kenza.z...@biblibre.com changed: What|Removed |Added Blocks||10630 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #23 from Owen Leonard oleon...@myacpl.org --- Applying: Bug 9044: Provide item selection in record detail page (staff client) Applying: Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Applying: Bug 9044: QA followup fatal: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9044: QA followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza kenza.z...@biblibre.com changed: What|Removed |Added Depends on|10628 |10528 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 kenza kenza.z...@biblibre.com changed: What|Removed |Added Blocks|10630 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #19359|0 |1 is obsolete|| --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Created attachment 19875 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19875action=edit [SIGNED-OFF] Bug 10533: basketgroup js functions should in a separated js file This patch moves js functions used for managing basketgroup into a separated js file. Test plan: - Try all actions for basketgroup ( drag/drop, add, delete, close, print, reopen, edit, export as csv). - Check that there is no regression on others acquisition pages: * acqui/neworderempty.tt * acqui/uncertainprice.tt * acqui/addorderiso2709.tt * acqui/basketheader.tt * admin/aqbudgets.tt * admin/aqcontract.tt * admin/aqbudgetperiods.tt * admin/aqplan.tt * suggestion/suggestion.tt Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Failed QA CC||gmcha...@gmail.com --- Comment #11 from Galen Charlton gmcha...@gmail.com --- This patch changes what gets returned as the LCCN. The acronym LCCN is ambiguous, unfortunately, as it can refer to LC Control Number or LC Call Number. The current behavior of the Z39.50 search is to return the former (i.e., the control number or LC-assigned identification number). Here is a diff (before and after applying the patch) of the output of a little test script I wrote that searches LC's Z39.50 server for ISBN 9780415964845. 'total_pages' = 1, 'breeding_loop' = [ { -'lccn' = ' 2008005439', -'breedingid' = '91', -'date' = '2008', -'author' = undef, +'lccn' = 'PR6068.O93', +'date' = '2008.', +'breedingid' = '92', +'author' = '', 'biblionumber' = undef, 'edition' = '2nd ed.', 'server' = 'LIBRARY OF CONGRESS', I'm marking this as failed QA for the change in visible behavior, but this issue speaks to a broader concern I have with this patch: why replace the call to TransformMarcToKoha, which uses the installed default bibliographic framework to extract strings from the MARC record, with hardcoding the tags and subfields for each MARC flavor? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10631] New: Table alert should have a FK on borrowernumber and entries be deleted with the referenced borrower
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10631 Bug ID: 10631 Summary: Table alert should have a FK on borrowernumber and entries be deleted with the referenced borrower Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org The table alert is currently used to store information about email subscriptons for new serial issues. The current table defnition is: 2682 DROP TABLE IF EXISTS `alert`; 2683 CREATE TABLE `alert` ( 2684 `alertid` int(11) NOT NULL auto_increment, 2685 `borrowernumber` int(11) NOT NULL default 0, 2686 `type` varchar(10) NOT NULL default '', 2687 `externalid` varchar(20) NOT NULL default '', 2688 PRIMARY KEY (`alertid`), 2689 KEY `borrowernumber` (`borrowernumber`), 2690 KEY `type` (`type`,`externalid`) 2691 ) ENGINE=InnoDB DEFAULT CHARSET=utf8; 2692 As I see it borrowernumber should be a FK and we are missing some cascades to make sure the table is cleaned up when a borrower is deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10631] Table alert should have a FK on borrowernumber and entries be deleted with the referenced borrower
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10631 --- Comment #1 from Galen Charlton gmcha...@gmail.com --- Some relevant commentary from #koha: kf hm wondering... we delete all that, but that will make it impossible to do an 'undelete' bringing borrowers back from deletedborrowers kf we already delete a lot - that would make it more consistent, but I coudl imagine that might be the eaosn it was not done in the first place? kf i am working on a 'concept for deletion of personal data' so that's where those questions come from :) gmcharlt I'd rather have the FKs kf i will file a bug kf and note it for manual deletion for now... *meh* :) gmcharlt and if there's a desire for a more complete patron undelete, add new tables as needed gmcharlt e.g., deleted_borrower_alerts, etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10566] Improve OPAC course reserves pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Blocks||10632 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Depends on||10566 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10632] New: Enable datatables for courses and course details in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Bug ID: 10632 Summary: Enable datatables for courses and course details in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org We should use datatables for the courses and course items tables. This will make the tables sortable and searchable from the client side. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19876 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19876action=edit Bug 10632 - Enable datatables for courses and course details in the OPAC We should use datatables for the courses and course items tables. This will make the tables sortable and searchable from the client side. Test Plan: 1) Apply this patch 2) View the courses in the OPAC, try sorting and searching 3) View the course details for a course, try sorting and searching the items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10633] New: Table suggestions needs some work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10633 Bug ID: 10633 Summary: Table suggestions needs some work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org The table suggestions is missing FK constraints and cascades to ensure a suggestion is anonymized when the borrower who suggested it gets deleted. The current table definition is: 2077 DROP TABLE IF EXISTS `suggestions`; 2078 CREATE TABLE `suggestions` ( -- purchase suggestions 2079 `suggestionid` int(8) NOT NULL auto_increment, -- unique identifier assigned automatically by Koha 2080 `suggestedby` int(11) NOT NULL default 0, -- borrowernumber for the person making the suggestion, foreign key linking to the borrowers table 2081 `suggesteddate` date NOT NULL default 0, -- date the suggestion was submitted 2082 `managedby` int(11) default NULL, -- borrowernumber for the librarian managing the suggestion, foreign key linking to the borrowers table 2083 `manageddate` date default NULL, -- date the suggestion was updated 2084acceptedby INT(11) default NULL, -- borrowernumber for the librarian who accepted the suggestion, foreign key linking to the borrowers table 2085accepteddate date default NULL, -- date the suggestion was marked as accepted 2086rejectedby INT(11) default NULL, -- borrowernumber for the librarian who rejected the suggestion, foreign key linking to the borrowers table 2087rejecteddate date default NULL, -- date the suggestion was marked as rejected 2088 `STATUS` varchar(10) NOT NULL default '', -- suggestion status (ASKED, CHECKED, ACCEPTED, or REJECTED) 2089 `note` mediumtext, -- note entered on the suggestion 2090 `author` varchar(80) default NULL, -- author of the suggested item 2091 `title` varchar(255) default NULL, -- title of the suggested item 2092 `copyrightdate` smallint(6) default NULL, -- copyright date of the suggested item 2093 `publishercode` varchar(255) default NULL, -- publisher of the suggested item 2094 `date` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- date and time the suggestion was updated 2095 `volumedesc` varchar(255) default NULL, 2096 `publicationyear` smallint(6) default 0, 2097 `place` varchar(255) default NULL, -- publication place of the suggested item 2098 `isbn` varchar(30) default NULL, -- isbn of the suggested item 2099 `mailoverseeing` smallint(1) default 0, 2100 `biblionumber` int(11) default NULL, -- foreign key linking the suggestion to the biblio table after the suggestion has been ordered 2101 `reason` text, -- reason for accepting or rejecting the suggestion 2102 `patronreason` text, -- reason for making the suggestion 2103budgetid INT(11), -- foreign key linking the suggested budget to the aqbudgets table 2104branchcode VARCHAR(10) default NULL, -- foreign key linking the suggested branch to the branches table 2105collectiontitle text default NULL, -- collection name for the suggested item 2106itemtype VARCHAR(30) default NULL, -- suggested item type 2107 quantity SMALLINT(6) default NULL, -- suggested quantity to be purchased 2108 currency VARCHAR(3) default NULL, -- suggested currency for the suggested price 2109 price DECIMAL(28,6) default NULL, -- suggested price 2110 total DECIMAL(28,6) default NULL, -- suggested total cost (price*quantity updated for currency) 2111 PRIMARY KEY (`suggestionid`), 2112 KEY `suggestedby` (`suggestedby`), 2113 KEY `managedby` (`managedby`) 2114 ) ENGINE=InnoDB DEFAULT CHARSET=utf8; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10505] Add a separator between title and subtitle for OPAC without XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10505 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard oleon...@myacpl.org --- In our case (MARC21) titles (245 $a) have the colon included. If this patch were added we would end up with double colons. As far as I know our data is correct according to the MARC21 rules, so I don't know how you could accomplish this for UNIMARC without causing problems for MARC21 libraries. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10634] New: Use datatables for course details items table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 Bug ID: 10634 Summary: Use datatables for course details items table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org We should make the course items table in the course details a datatable to enable searching or sorting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10634] Use datatables for course details items table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10634] Use datatables for course details items table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10634] Use datatables for course details items table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19877 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19877action=edit Bug 10634 - Use datatables for course details items table We should make the course items table in the course details a datatable to enable searching or sorting. Test Plan: 1) Apply this patch 2) View the details page for a course with items 3) Verify the table displays and is now a datatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10634] Use datatables for course details items table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #19877|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19878 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19878action=edit Bug 10634 - Use datatables for course details items table We should make the course items table in the course details a datatable to enable searching or sorting. Test Plan: 1) Apply this patch 2) View the details page for a course with items 3) Verify the table displays and is now a datatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #113 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 19879 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19879action=edit Signed off 0001-Bug-10402-Add-ability-to-enter-multiple-contacts.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #19879|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #114 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 19880 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19880action=edit Signed off 0001-Bug-10402-Add-ability-to-enter-multiple-contacts.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #115 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 19881 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19881action=edit Signed off 0001-Bug-10402-Use-an-object-for-contacts.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #19880|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #116 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 19882 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19882action=edit Signed off 0001-Bug-10402-Move-contacts-to-separate-table.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #117 from Jared Camins-Esakov jcam...@cpbibliography.com --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov jcam...@cpbibliography.com And now we've lost my snarky comments? Oh no! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10634] Use datatables for course details items table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #19878|0 |1 is obsolete|| --- Comment #3 from Owen Leonard oleon...@myacpl.org --- Created attachment 19883 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19883action=edit [SIGNED-OFF] Bug 10634 - Use datatables for course details items table We should make the course items table in the course details a datatable to enable searching or sorting. Test Plan: 1) Apply this patch 2) View the details page for a course with items 3) Verify the table displays and is now a datatable Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10634] Use datatables for course details items table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard oleon...@myacpl.org --- DataTables won't be styled correctly without changes to the CSS and the addition of DataTables-related images. That needs to be taken care of before this patch goes in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #19774|0 |1 is obsolete|| --- Comment #18 from Owen Leonard oleon...@myacpl.org --- Created attachment 19884 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19884action=edit [SIGNED-OFF] Bug 10320 - Integrate OverDrive search into OPAC This show results from the OverDrive ebook/audiobook service in the OPAC. Added the sysprefs and copied the relevant JS to CCSR. Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Henry Bankhead hbankh...@losgatosca.gov Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #19775|0 |1 is obsolete|| --- Comment #19 from Owen Leonard oleon...@myacpl.org --- Created attachment 19885 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19885action=edit [SIGNED-OFF] Followup for bug 10320: minor bugfixes and style improvements Switch to the new method of showing star ratings. Also, fix some translation bugs, an error that occurred when caching was disabled and add a stub unit test. Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Version|unspecified |master --- Comment #20 from Owen Leonard oleon...@myacpl.org --- These patches work well in my tests. One minor thing needs a follow-up: Some of the copyright statements on the new scripts appear to be copypasta. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/