[Koha-bugs] [Bug 10664] New: Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Bug ID: 10664 Summary: Software error in overdue_notices.pl if there is no active currency Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: sophie.meyni...@biblibre.com QA Contact: testo...@bugs.koha-community.org Bug introduced by http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 If there is no active currency, when running overdue_notices.pl you get a sofware error Can't use an undefined value as a HASH reference on GetCurrency() function call -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 --- Comment #1 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- Created attachment 19991 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19991action=edit Bug 10664 : Software error in overdue_notices.pl if there is no active currency If there is no active currency, when running overdue_notices.pl you get a sofware error Can't use an undefined value as a HASH reference on GetCurrency() function call With this patch, if there is no active currency, fines are formated by default 0,00 and notices are correctly generated. Test plan : - have at least one borrower with overdue that should trigger a notice - verify that there is no active currency (Adminitration Currency Exchange rates) - run misc/cronjobs/overdue_notices.pl -v -n (to get the notice directly on output) = without the patch you get the software error = with the patch, notices are correctly generated If an active currency is defined, the script overdue_notices.pl runs the same with or without patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8378 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8378] fine syntax not working on overdues anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10664 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |sophie.meyni...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Priority|P5 - low|P4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9916] Use DataTables in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added CC||srd...@catalyst.net.nz --- Comment #2 from Srdjan Jankovic srd...@catalyst.net.nz --- On opac-serial-issues.pl?selectview=full I got currentYear is not defined. Is that just my setup? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10004] Delay batch record count updates until the end of the z39.50 search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10004 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl --- Bug 10462 has resolved the issue of the unused batch record counts for Z3950 search. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Derryn derr...@gmail.com changed: What|Removed |Added CC||derr...@gmail.com --- Comment #62 from Derryn derr...@gmail.com --- I would like to voice my annoyance at this bug. We have no printer, no need or want for receipts. Why should our users be forced to get out the mouse/keyboard and hit no every time they log out? This should be an option in the preferences and not forced upon everyone. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10663] Holds never block renewals
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- The more I look into this the more I think that GetReserveStatus is not suitable to determine if something is Reserved on title level. For item level holds we have the itemnumer and all is fine, given the patch I wrote is applied. To determine if an item can fill a title level hold is much more complicated. I don't think CheckReserves is perfect for this job either - but it might be worth reverting to using this in CanBookBeRenewed and try to improve after restoring the old behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10642] Inappropriate uses of $sth-finish() in C4::RotatingCollections.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10642 kenza kenza.z...@biblibre.com changed: What|Removed |Added Blocks||10653 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 kenza kenza.z...@biblibre.com changed: What|Removed |Added Depends on||10642 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #63 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to Derryn from comment #62) I would like to voice my annoyance at this bug. We have no printer, no need or want for receipts. Why should our users be forced to get out the mouse/keyboard and hit no every time they log out? This should be an option in the preferences and not forced upon everyone. Awesome, I look forward to your patch implementing this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 --- Comment #4 from kenza kenza.z...@biblibre.com --- (In reply to Srdjan Jankovic from comment #3) t/db_dependent/RotatingCollections.t .. 1/41 DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at t/db_dependent/RotatingCollections.t line 41. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at t/db_dependent/RotatingCollections.t line 41. Is my db out of sync? I just try and indeed if i just do prove t/db_dependent/RotatingCollections.t , i have the same errors. But if i'm in root or if i do sudo prove t/db_dependent/RotatingCollections.t, it works! I really don't understand why. I'll try to fix this problem... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10665] New: koha-index-daemon-ctl.sh needs mysql dependency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Bug ID: 10665 Summary: koha-index-daemon-ctl.sh needs mysql dependency Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: fridolyn.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org koha-index-daemon-ctl.sh is a init script for koha-index-daemon from Koha::Contrib::Tamil::IndexerDaemon. When starting system, this script needs to be started after the MySQL server because it uses it to access to Koha database. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh needs mysql dependency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh needs mysql dependency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |fridolyn.som...@biblibre.co ||m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19992 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19992action=edit Bug 10665 - koha-index-daemon-ctl.sh needs mysql dependency Proposed patch. Without this patch, the log file show on startup : DBD::mysql::st execute failed: MySQL server has gone away at /usr/local/share/perl/5.14.2/Koha/Contrib/Tamil/IndexerDaemon.pm line 71. DBD::mysql::st fetchrow failed: fetch() without execute() at /usr/local/share/perl/5.14.2/Koha/Contrib/Tamil/IndexerDaemon.pm line 73. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #19553|0 |1 is obsolete|| --- Comment #65 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19993 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19993action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #19555|0 |1 is obsolete|| --- Comment #67 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19995 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19995action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 2 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #19554|0 |1 is obsolete|| --- Comment #66 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19994 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19994action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 1 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #19678|0 |1 is obsolete|| --- Comment #68 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19996 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19996action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Rebased master. I recreated this patch manually. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #19679|0 |1 is obsolete|| --- Comment #69 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19997 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19997action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10666] New: Daily quotes tests are failing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666
Bug ID: 10666
Summary: Daily quotes tests are failing
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Test Suite
Assignee: gmcha...@gmail.com
Reporter: fridolyn.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
In t/db_dependent/Koha.t, the test Got a quote based on today's date is
failing :
$prove t/db_dependent/Koha.t :
t/db_dependent/Koha.t .. 1/6
# Failed test 'Got a quote based on today's date.'
# at t/db_dependent/Koha.t line 126.
# Compared $data-{source}
#got : 'Herbert Hoover'
# expect : 'Abraham Lincoln'
# Be sure to run this test on a clean install of sample data.
# Looks like you failed 1 test of 4.
# Failed test 'Daily Quotes Test'
# at t/db_dependent/Koha.t line 129.
Looks like the wrong quote is returned by GetDailyQuote().
I'm using a databased created with the English sample SQL datas.
I think I found the cause :
The test Got a random quote. calls GetDailyQuote('random'=1) which changes
the quote timestamp to now. When then testing GetDailyQuote(), this quote
(which may not be the one created by test) is the most recent quote.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10666] Daily quotes tests are failing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |fridolyn.som...@biblibre.co ||m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19998 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19998action=edit Bug 10666 - Daily quotes tests are failing See commit message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8769] Allow SIP2 return backdating
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #15248|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 1 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=1action=edit Bug 8769 - Allow SIP2 return backdating Currently Koha's SIP server ignores the return date part of an 09 ( aka CHECKIN ) message. Koha should backdate a return, and remove fines accordingly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8769] Allow SIP2 return backdating
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #1|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 2 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2action=edit Bug 8769 - Allow SIP2 return backdating Currently Koha's SIP server ignores the return date part of an 09 ( aka CHECKIN ) message. Koha should backdate a return, and remove fines accordingly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10666] Daily quotes tests are failing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #19998|0 |1
is obsolete||
--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20001
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20001action=edit
Bug 10666 - Daily quotes tests are failing
In t/db_dependent/Koha.t, the test Got a quote based on today's date is
failing :
$prove t/db_dependent/Koha.t :
t/db_dependent/Koha.t .. 1/6
# Failed test 'Got a quote based on today's date.'
# at t/db_dependent/Koha.t line 126.
# Compared $data-{source}
#got : 'Herbert Hoover'
# expect : 'Abraham Lincoln'
# Be sure to run this test on a clean install of sample data.
# Looks like you failed 1 test of 4.
Looks like the wrong quote is returned by GetDailyQuote().
I'm using a databased created with the English sample SQL datas.
I think I found the cause :
The test Got a random quote. calls GetDailyQuote('random'=1) which changes
the quote timestamp to now. When then testing GetDailyQuote(), this quote
(which may not be the one created by test) is the most recent quote.
This patch moves the Got a random quote. test after Got a quote based on
today's date to solve the problem.
Signed-off-by: Kyle M Hall k...@bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10666] Daily quotes tests are failing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10667] New: ILS-DI: AuthenticatePatron should also work with cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 Bug ID: 10667 Summary: ILS-DI: AuthenticatePatron should also work with cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: katrin.fisc...@bsz-bw.de Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org .../cgi-bin/koha/ilsdi.pl?service=Describeverb=AuthenticatePatron Currently only username + password is supported. Authentication should also be possible with cardnumber + password to match OPAC authentication. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #16602|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20002 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20002action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons This patch adds a new tab to the patron side menu for purchase suggestions. From this new tab, a librarian can view the patron's existing purchase suggestios and also create new suggestions in the name of that patron. Test Plan: 1) Apply patch 2) Ensure the system preference 'suggestions' is enabled 3) View the details for a patron 4) Click the new 'Purchase suggestions' tab 5) Click the 'New purchase suggestion' button 6) Add the new purchase suggestions 7) You should now end up back at the borrowers purchase suggetions 8) Verify the new purchase suggestion was added Signed-off-by: Corey Fuimaono agent@gmail.com Step though the test plan. All OK. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #16603|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20003 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20003action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #7 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Two last patches need signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9916] Use DataTables in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 --- Comment #3 from Owen Leonard oleon...@myacpl.org --- (In reply to Srdjan Jankovic from comment #2) On opac-serial-issues.pl?selectview=full I got currentYear is not defined. Thanks for testing Srdjan. Where did you see that error? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9916] Use DataTables in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 --- Comment #4 from Owen Leonard oleon...@myacpl.org --- Oh I see: If you navigate directly to /cgi-bin/koha/opac-serial-issues.pl?selectview=full without coming to it from an existing subscription you do get that error. You have to search for a biblio with a subscription and click the subscriptions tab. Click more details at the bottom, then the full history tab. There should be a biblionumber parameter: /cgi-bin/koha/opac-serial-issues.pl?selectview=fullbiblionumber=XXX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10304] Add avanced search filter for not for loan items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard oleon...@myacpl.org --- This patch appears to break the only available option, whether it is used on its own or in conjunction with the new only for loan option. I get no results for a search which should return available items. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18194|0 |1 is obsolete|| --- Comment #27 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20004 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20004action=edit Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books Add checks in C4::ILS::Patron and C4::ILS::Transaction::Renew to make sure the patron is below the noissuescharge system pref for issues and OPACFineNoRenewals for renewals. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18195|0 |1 is obsolete|| --- Comment #28 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20005 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20005action=edit Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books - QA Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #15 from Owen Leonard oleon...@myacpl.org --- A couple of issues: - The template tries to build an old YUI-style button instead of the current Bootstrap version. - The table of suggestions should link to the suggestions detail page for that entry if the user has the correct permissions. (/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=Xop=show I assume, a page which should probably be made more useful somehow). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 --- Comment #29 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20006 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20006action=edit Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books - Unit Test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 --- Comment #16 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20007 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20007action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #20007|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20008 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20008action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh needs mysql dependency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #19992|0 |1 is obsolete|| --- Comment #2 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 20009 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20009action=edit Bug 10665 - koha-index-daemon-ctl.sh dependency I revised patch because indexer may use a remote MySQL server and so the dependency on $mysql may not be possible. I changed for $all as dependency at startup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh dependency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Summary|koha-index-daemon-ctl.sh|koha-index-daemon-ctl.sh |needs mysql dependency |dependency -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- (In reply to Liz Rea from comment #3) Hi, Tried to test this, got the following: Falling back to patching base and 3-way merge... Auto-merging tools/modborrowers.pl CONFLICT (content): Merge conflict in tools/modborrowers.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt Failed to merge in the changes. Patch failed at 0001 Bug 10612 - Add ability to delete patrons with batch patron modification tool It applied fine for me. Did you apply all the dependencies? First you need to apply 8798, then 10565, then finally this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20010 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20010action=edit Bug 10628 - AutomaticItemReturn prevents holds queue from filling local holds with local items - Switch grep to any -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #19882|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #118 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 20011 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20011action=edit Signed off 0001-Bug-10402-Move-contacts-to-separate-table.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #119 from Jared Camins-Esakov jcam...@cpbibliography.com --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov jcam...@cpbibliography.com Clever commentary on the patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #122 from Owen Leonard oleon...@myacpl.org --- Created attachment 20014 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20014action=edit Bug 9223 [Follow-up] Multiple values of AdvancedSearchTypes in suggestions This follow-up implements some things I think will improve on the previous patches: - Change the system preference name to SuggestionsUseValues - Change the description of the preference to Suggestions can be submitted using the following authorized values: - Move the new preference to the OPAC tab so that it is grouped with other suggestions-related preferences. - Add the option offer no itemtype/collection code chooser on the submission form. - Display the correct label on the submission form depending on the value of the SuggestionsUseValues preference. To test, apply this patch on top of the previous ones. Test submission of purchase suggestions through the OPAC and staff client with the SuggestionsUseValues preference set to all the various choices: item type, collection code, shelving location, and 'none.' The suggestion forms should look correct and work correctly. HOwEVER, neither the previous patches nor mine address the problem of the suggestions management page's organize by option, which is hard-coded to work with item types. Whether or not my patch is acceptable this issue will need to be addressed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #120 from Owen Leonard oleon...@myacpl.org --- Created attachment 20012 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20012action=edit Bug 9223: Multiple values of AdvancedSearchTypes in suggestions Suggestion form uses C4::Koha::GetSupportList to get a list of supports that can come from itemtypes or authoritized values LOC or CCODE. C4::Koha::GetSupportList uses AdvancedSearchTypes syspref like it has only one value. But this syspref can contain several values separated by a pipe. This patch introduces a new syspref SupportsAuthorizedValues to select wich authorized values category that represents the physical support (itemtypes by default, loc or ccode). These authorized values will be used in suggestion management, known as 'document type'. (Note that database field is still 'itemtype'). Test plan : --- - Set SupportsAuthorizedValues with itemtypes or loc or ccode - Get to suggestion form (OPAC or intranet) - Look at Document type combobox, it must contains descriptions of selected authorized values - Save the suggestion - Get to intranet suggestions management - Organize suggestions by document type = your suggestion must appear in a tab with its document type description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #20014|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #20012|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #20013|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #14428|0 |1 is obsolete|| --- Comment #18 from Owen Leonard oleon...@myacpl.org --- Created attachment 20016 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20016action=edit Bug 9223: Add SupportsAuthorizedValues syspref (followup 1) http://bugs.koha-community.org/show_bug.cgi?id=6473 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 --- Comment #19 from Owen Leonard oleon...@myacpl.org --- Created attachment 20017 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20017action=edit Bug 9223 [Follow-up] Multiple values of AdvancedSearchTypes in suggestions This follow-up implements some things I think will improve on the previous patches: - Change the system preference name to SuggestionsUseValues - Change the description of the preference to Suggestions can be submitted using the following authorized values: - Move the new preference to the OPAC tab so that it is grouped with other suggestions-related preferences. - Add the option offer no itemtype/collection code chooser on the submission form. - Display the correct label on the submission form depending on the value of the SuggestionsUseValues preference. To test, apply this patch on top of the previous ones. Test submission of purchase suggestions through the OPAC and staff client with the SuggestionsUseValues preference set to all the various choices: item type, collection code, shelving location, and 'none.' The suggestion forms should look correct and work correctly. HOWEVER, neither the previous patches nor mine address the problem of the suggestions management page's organize by option, which is hard-coded to work with item types. Whether or not my patch is acceptable this issue will need to be addressed. http://bugs.koha-community.org/show_bug.cgi?id=6473 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #20 from Owen Leonard oleon...@myacpl.org --- I've attached rebased versions of the original patches along with mine. I'm setting back to needs signoff although I don't think this can go to QA without an additional followup for the issue I describe in comment 19. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #121 from Owen Leonard oleon...@myacpl.org --- Created attachment 20013 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20013action=edit Bug 9223: Add SupportsAuthorizedValues syspref (followup 1) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #14427|0 |1 is obsolete|| --- Comment #17 from Owen Leonard oleon...@myacpl.org --- Created attachment 20015 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20015action=edit Bug 9223: Multiple values of AdvancedSearchTypes in suggestions Suggestion form uses C4::Koha::GetSupportList to get a list of supports that can come from itemtypes or authoritized values LOC or CCODE. C4::Koha::GetSupportList uses AdvancedSearchTypes syspref like it has only one value. But this syspref can contain several values separated by a pipe. This patch introduces a new syspref SupportsAuthorizedValues to select wich authorized values category that represents the physical support (itemtypes by default, loc or ccode). These authorized values will be used in suggestion management, known as 'document type'. (Note that database field is still 'itemtype'). Test plan : --- - Set SupportsAuthorizedValues with itemtypes or loc or ccode - Get to suggestion form (OPAC or intranet) - Look at Document type combobox, it must contains descriptions of selected authorized values - Save the suggestion - Get to intranet suggestions management - Organize suggestions by document type = your suggestion must appear in a tab with its document type description http://bugs.koha-community.org/show_bug.cgi?id=6473 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7518] searches with quotation marks don't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518 --- Comment #37 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to Galen Charlton from comment #36) I'm having difficulty reproducing this bug. For those who can, perchance are there any ZOOM error messages associated with it showing up in the Apache error log? The best way is to look at Zebra server output. - launch Zebra server manually : zebrasrv -f /home/koha/etc/koha-conf.xml - Set syspref QueryWeightFields on - Perform a search on two words. For example : centre ville : - Look at zebrasrv log : 19:15:18-31/07 zebrasrv(4) [request] Search biblios OK 0 1 1+0 RPN @attrset Bib-1 @or @or @or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 centre ville @attr 1=4 @attr 4=1 @attr 6=3 @attr 9=28 @attr 2=102 centre ville @attr 1=36 @attr 4=1 @attr 9=26 @attr 2=102 centre ville @attr 4=6 @attr 9=14 @attr 2=102 centre ville - Perform a search with a double quote. For example : centre ville : - Look at zebrasrv log : 19:15:13-31/07 zebrasrv(3) [request] Search biblios OK 0 1 1+0 RPN @attrset Bib-1 @or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 centre ville or ti,ext,r2=centre ville @attr 1=36 @attr 4=1 @attr 9=26 @attr 2=102 centre ville or wrdl,r9=centre ville = You see that with double quote, there is some unconverted CCL into PQF query : or wrdl,r9= -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #1 from Galen Charlton gmcha...@gmail.com --- (In reply to David Cook from comment #0) Currently, Koha only acts as a OAI-PMH server, I propose to add a harvesting client as well (likely using the HTTP::OAI::Harvester module), so that Koha can ingest records from other data sources (such as digital repositories like Dspace). Interesting idea. I've only started reading about it but despite initial reservations about resumption tokens, I think the hardest part will not be with the retrieval of records so much as the parsing of those records into MARC. This may be less of a problem in the long run with my plans to allow Koha to support multiple metadata formats (although even once that's available, you may still want the harvester to be able to convert the source metadata into something else). One thing I'd suggest is that the harvester keep a copy of the original metadata record in a database table; that would be more flexible than immediately converting it to MARC and discarding the source data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10668] New: Improve suggestion detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 Bug ID: 10668 Summary: Improve suggestion detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org The suggestion detail page, shown if you click the title of a suggestion on the suggestion management page, could be more useful. I propose adding 'edit' and 'delete' buttons so that there are other options besides simply going back. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10668] Improve suggestion detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10668] Improve suggestion detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 20018 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20018action=edit Bug 10668 - Improve suggestion detail page This patch makes several improvements to the suggestions template: - Improved breadcrumbs and page title. - Fixed a JavaScript error which appeared when viewing or editing a suggestion. - Added an 'Edit' and a 'Delete' button to the suggestion detail page. - Corrected capitalization. To test: - Perform various operations with suggestions management and confirm that page titles and breadcrumbs are correct. - View the detail page for an individual suggestion and confirm that the edit and delete buttons work correctly. - Confirm that there are no JavaScript errors when viewing or editing a suggestion, in particular when changing Acquisition information (quantity, currency, price). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10402] Add multiple contacts for vendors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #19808|0 |1 is obsolete|| --- Comment #15 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 20019 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20019action=edit Bug 10402: Use an object for contacts In preparation for adding the ability to handle multiple contacts, this patch moves booksellers' contacts into their own class, C4::Bookseller::Contact. To test: 1) Apply patch. 2) Run database update. 3) Edit a bookseller, making sure to add a contact. 4) View the bookseller's information, making sure the contact information is there. 5) Run the unit test: prove t/db_dependent/Bookseller.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10402] Add multiple contacts for vendors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #19809|0 |1 is obsolete|| --- Comment #16 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 20020 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20020action=edit Bug 10402: Move contacts to separate table This patch normalizes the data structures used for bookseller contacts. To test: 1) Repeat tests described on previous patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10402] Add multiple contacts for vendors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #19810|0 |1 is obsolete|| --- Comment #17 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 20021 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20021action=edit Bug 10402: Add ability to enter multiple contacts Some vendors may have more than one contact. For example, a technical contact and a billing contact, or a contact for journals and a contact for monographs. Rather than require that each contact be either made into a separate vendor or recorded somewhere outside of Koha, it would be really useful of Koha had the ability to add multiple additional contacts to vendors in the Acquisitions module. To test: 1) Apply patch. 2) Edit a bookseller, making sure to add a contact. 3) View the bookseller's information, making sure the contact information is there. 4) Run the unit test: prove t/db_dependent/Bookseller.t 5) Add multiple contacts to a vendor, see that they show up. 6) Delete one contact from a vendor with multiple contacts, see that the result is correct. 7) Sign off. Note: This test plan can supersede that on the previous two patches, as all functionality of the previous two patches is required by this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #18 from Owen Leonard oleon...@myacpl.org --- This latest patch doesn't remove the YUI JavaScript, so even though the button looks correct there is still a JS error on the page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10669] New: LiveDVD manager for 3.12 missing in about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10669 Bug ID: 10669 Summary: LiveDVD manager for 3.12 missing in about page Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: About Assignee: neng...@gmail.com Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10669] LiveDVD manager for 3.12 missing in about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10669 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10669] LiveDVD manager for 3.12 missing in about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10669 --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 20022 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20022action=edit Bug 10669 - LiveDVD manager for 3.12 missing in about page This fixes the error. Regards To+ Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10669] LiveDVD manager for 3.12 missing in about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10669 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10669] LiveDVD manager for 3.12 missing in about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10669 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Assignee|neng...@gmail.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #19853|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10669] LiveDVD manager for 3.12 missing in about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10669 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10669] LiveDVD manager for 3.12 missing in about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10669 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #19864|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #19900|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #33 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Srdjan, could you confirm the patch works? There were 2 attachements, the second one contained changes that it seems were already part of the first patch, but only the second had your sign-off... *confused* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #19966|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20023 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20023action=edit [PASSED QA] Bug 10609 - Use branch name rather than branch code in serials-collection.pl The serials collection page displays branchcode instead of library name. This patch uses the Branches template plugin to display the library name instead. Also corrected: Added missing datatables config include to prevent a JavaScript error. To test, view the serials collection page for a subsciption with existing issues. Library names should be displayed instead of branchcodes. There should be no JavaScript errors reported by the browser. Signed-off-by: Mirko Tietgen mi...@abunchofthings.net Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works well and uses the new TT plugin for displaying the branch name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #19989|0 |1 is obsolete|| --- Comment #26 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20024 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20024action=edit [PASSED QA] QA followup for bug 10320 - Fix copyright and style errors This patch fixes a copypasta'd copyright statement, and some incorrect POD and indentation. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 --- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 20025 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20025action=edit Bug 10404: add previous/next browsing to staff client Although previous/next browsing was added for searches in the OPAC in 2011, the staff client has been without any sort of search browsing. Until now. This patch is an all-singing, all-dancing, all-compatible implementation of search browsing that will work across multiple browser tabs and on any browser since IE7 (though the staff client layout is broken on IE7). To test: 1) Perform a search that will bring up multiple results. 2) View one of the results. 3) Use the Previous and Next links to browse along the search results. 4) Use the Return to results button to check that you end up at the correct page of results, even if you page through more than 20 records. 5) Sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #19973|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20026 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20026action=edit [PASSED QA] Bug 10644: ClassSource.pm needs unit tests The tests are wrap in a database transaction. To test: prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 1/24 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 attempting to use non-existent class sorting routine routine1 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.12 cusr 0.01 csys = 0.15 CPU) Result: PASS Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20026|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20027 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20027action=edit [PASSED QA] Bug 10644: ClassSource.pm needs unit tests The tests are wrap in a database transaction. To test: prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 1/24 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 attempting to use non-existent class sorting routine routine1 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.12 cusr 0.01 csys = 0.15 CPU) Result: PASS Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20027|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20028 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20028action=edit [PASSED QA] Bug 10644: ClassSource.pm needs unit tests The tests are wrap in a database transaction. To test: prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 1/24 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 attempting to use non-existent class sorting routine routine1 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.12 cusr 0.01 csys = 0.15 CPU) Result: PASS Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kenza, I have fixed(?) your name and email address to what it was in your last patch going in - could you check if I did it right? You may also want to change your git configuration to have the email address of your choice and your full name in the patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #19864|0 |1 is obsolete|| --- Comment #34 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 20029 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20029action=edit [SIGNED-OFF] C4::Branch.pm needs unit tests Unit tests are wrap in a transaction. To test: prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207. t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=36, 1 wallclock secs ( 0.02 usr 0.02 sys + 0.13 cusr 0.01 csys = 0.18 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10508 Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #35 from Srdjan Jankovic srd...@catalyst.net.nz --- Yes it is ok, my mistake, sorry about that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628
--- Comment #6 from Srdjan Jankovic srd...@catalyst.net.nz ---
# Failed test 'take from holdingbranch AutomaticItemReturn on (use cost
matrix) holding branch'
# at t/db_dependent/HoldsQueue.t line 196.
# got: 'CPL'
# expected: 'IPT'
# Wrong pick-up/hold for first target (pick_branch, hold_branch, reserves,
hold_fill_targets, tmp_holdsqueue): $VAR1 = 'CPL';
# $VAR2 = 'IPT';
# $VAR3 = [
# {
# 'priority' = '1',
# 'reservenotes' = undef,
# 'reservedate' = '2013-08-00',
# 'found' = undef,
# 'expirationdate' = undef,
# 'suspend_until' = undef,
# 'reminderdate' = undef,
# 'biblionumber' = '92704',
# 'timestamp' = '2013-08-01 12:27:34',
# 'notificationdate' = undef,
# 'borrowernumber' = '122266',
# 'branchcode' = 'CPL',
# 'itemnumber' = undef,
# 'constrainttype' = '',
# 'lowestPriority' = '0',
# 'suspend' = '0',
# 'waitingdate' = undef,
# 'cancellationdate' = undef,
# 'reserve_id' = '4361'
# }
# ];
# $VAR4 = [
# {
# 'itemnumber' = '68955',
# 'biblionumber' = '92704',
# 'source_branchcode' = 'CPL',
# 'borrowernumber' = '122266',
# 'item_level_request' = '0'
# }
# ];
# $VAR5 = [
# {
# 'firstname' = 'my firstname',
# 'pickbranch' = 'CPL',
# 'itemnumber' = '68955',
# 'itemcallnumber' = undef,
# 'reservedate' = '2013-08-00',
# 'barcode' = '531703236591',
# 'phone' = undef,
# 'item_level_request' = '0',
# 'surname' = 'my surname',
# 'biblionumber' = '92704',
# 'holdingbranch' = 'CPL',
# 'cardnumber' = 'CARDNUMBER42',
# 'notes' = undef,
# 'title' = 'Test Holds Queue XXX',
# 'borrowernumber' = '122266'
# }
# ];
Illegal date specified (year = 2013, month = 8, day = 00) at C4/HoldsQueue.pm
line 138
# Looks like you failed 1 test of 19.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9916] Use DataTables in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9916] Use DataTables in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #19951|0 |1 is obsolete|| --- Comment #5 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 20030 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20030action=edit Bug 9916 - Use DataTables in the OPAC The OPAC still uses the old tablesorter plugin which isn't being actively maintained. We use DataTables in the staff client and should in the OPAC too. The plugin was added a while ago but never implemented on any pages. This patch upgrades the plugin to the latest version and places it in opac-tmpl/lib for cross-theme access. The patch implements DataTables on all pages which previously used the tablesorter plugin. The old tablesorter plugin is removed. The customized DataTable configuration script, datatables.js, has been trimmed-down from the staff client version in order to limit it to only that functionality required in the OPAC. Sorting based on date is done based on the data's enclosing span title attribute as it is in the staff client: span title= [% iso date %][% date | $KohaDates %]/span Slight modifications to Serials.pm and opac-search-history.pl have been made to accommodate this change. To test, view each page in the OPAC which uses JS-based table sorting: - The bibliographic detail page - The cart - The search history page - The suggestions page - The tags page (logged in as a user who has entered tags) - The most popular page (opac-topissues.pl) - The logged in user summary page (opac-user.pl) - The subscription full history page (opac-serial-issues.pl?selectview=full) - The self-checkout main page (with existing checkouts) Table sorting should work correctly on all pages in both the prog and ccsr themes. Sorting should work for dates whatever your dateformat system preference setting. Tables listing titles should exclude articles (a, an, and the in English) when sorting. Also test the serial collection page in the staff client, which is affected by the change to Serials.pm. Confirm that dates are displayed and sorted correctly. Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
