[Koha-bugs] [Bug 9192] UNIMARC_sync_date_created_with_marc_biblio.pl field creation

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192

--- Comment #20 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to Galen Charlton from comment #18)
 I've pushed the current patch to master, BTW.  Thanks, Fridolyn!

Thanks a lot.
I know that using this script with cron once a day and not when record is
created/modified is to speed up those actions.
It was even more usefull when items where in MARCXML.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #19925|0   |1
is obsolete||

--- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 22344
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22344action=edit
Bug 10544 - add Number-local-acquisition in QueryParser config

This patch adds the Number-local-acquisition into QueryParser configuration
file.
Like in ccl.properties, Number-local-acquisition is the main index name and
stocknumber and inv are aliases.

Test plan :
Enable QueryParser :
- Enable UseQueryParser syspref
- Edit your koha-conf.xml
- Add to config node : queryparser_config[your
path]/etc/searchengine/queryparser.yaml/queryparser_config, adapt [your
patch] to your install configuration folder
- If needed copy from sources etc/searchengine/queryparser.yaml into your
install configuration folder
Test search :
- Add Number-local-acquisition on an existing subfield in records.abs. For
example on item barcode field
- Reindex Zebra database
- Choose a value of this field that will match some results. For example : 0*
will match all barcodes beginning with zero
- In intranet, enter this URL : your
server/cgi-bin/koha/catalogue/search.pl?idx=stocknumberq=0*sort_by=relevance
= You get some results
- In intranet, enter this URL : your
server/cgi-bin/koha/catalogue/search.pl?idx=invq=0*sort_by=relevance
= You get the same results
- In intranet, enter this URL : your
server/cgi-bin/koha/catalogue/search.pl?idx=Number-local-acquisitionq=0*sort_by=relevance
= You get the same results

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #19443|0   |1
is obsolete||

--- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 22345
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22345action=edit
Bug 10544 - stocknumber index is an alias of Number-local-acquisition

Bug 6256 replaced in bib1.att stocknumber by Number-local-acquisition for
number 1062.
In this case, Number-local-acquisition must be used in record.abs and
stocknumber can be an alias of it in ccl.properties.

Test plan :
- drop zebra database (rebuild_zebra.pl -r ...)
- reindex
- test in simple search : ccl=Number-local-acquisition,alwaysmatches=''
= you get all records with a stocknumber
- test in simple search : ccl=stocknumber,alwaysmatches=''
= you get the same results

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #22344|0   |1
is obsolete||

--- Comment #12 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 22347
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22347action=edit
Bug 10544 - add Number-local-acquisition in QueryParser config

This patch adds the Number-local-acquisition into QueryParser configuration
file.
Like in ccl.properties, Number-local-acquisition is the main index name and
stocknumber and inv are aliases.

Test plan :
Enable QueryParser :
- Enable UseQueryParser syspref
- Edit your koha-conf.xml
- Add to config node : queryparser_config[your
path]/etc/searchengine/queryparser.yaml/queryparser_config, adapt [your
patch] to your install configuration folder
- If needed copy from sources etc/searchengine/queryparser.yaml into your
install configuration folder
Test search :
- Add Number-local-acquisition on an existing subfield in records.abs. For
example on item barcode field
- Reindex Zebra database
- Choose a value of this field that will match some results. For example : 0*
will match all barcodes beginning with zero
- In intranet, enter this URL : your
server/cgi-bin/koha/catalogue/search.pl?idx=stocknumberq=0*sort_by=relevance
= You get some results
- In intranet, enter this URL : your
server/cgi-bin/koha/catalogue/search.pl?idx=invq=0*sort_by=relevance
= You get the same results
- In intranet, enter this URL : your
server/cgi-bin/koha/catalogue/search.pl?idx=Number-local-acquisitionq=0*sort_by=relevance
= You get the same results

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #19924|0   |1
is obsolete||

--- Comment #11 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 22346
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22346action=edit
Bug 10544 - add Number-local-acquisition in known indexes

Adding Number-local-acquisition in C4::Search known indexes allows to search
without using ccl= prefix.
Also corrects in ccl.properties : inv must be an alias of
Number-local-acquisition.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #13 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Just some comments for QAer:

I tested the Zebra changes with MARC21/GRS1. It works as advertised.

MARC21 field 037 is mapped to Stock-number. It may be somewhat confusing to
have Stocknumber and Stock-number indexing different MARC fields. Can they be
merged into the same index?

If I search with catalogue/search.pl?idx=number-local-acquisitionq=stock*
I have the error: Can't call method sort on an undefined value at
/usr/share/koha/testclone/C4/Search.pm line 426. 
This is outside the scope of this report, but I would personally like to
receive the same search results (just interpret the idx parameter case
insensitive) instead of this error.

Your editing of the query parser config file now shows another index variant:
number-local-acq. Why not just Number-local-acquisition? Is it really needed to
have four names for this index?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #7 from M. de Rooy m.de.r...@rijksmuseum.nl ---
+if (!($sendAllEmailsTo  $sendAllEmailsTo =~ /@/) ){ # some
validation.  This could be improved.

Why not use Email::Valid-address() ? (This would be a new dependency.)
I suggested to use this cpan module under report 9032 (failed qa for now).
From there we could go further in checking email addresses in Koha in a
consistent way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE)

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED

--- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl ---
dep. 10520 does not apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8854] invoice filters don't all work

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11001

--- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Galen Charlton from comment #9)
 Hmm, the patches for bug 5336, which is now pushed, do not add an
 aqorders.branchcode column.  Maybe something else does?

Galen,
Finally I decided to abandon this field (see bug 11001).
I am not sure searching by branch for invoices is relevant since orders from
different branches can exist for a same invoice.
Moreover I don't know if filtering on the patron branchcode is the better
choice: if the aqbasketgroups.billingplace is different, results could be a
source of misunderstanding. Given that libraries have different work flow for
acquisitions, results could be good for some and wrong for others.
Maybe should we simply remove the search by library for invoices?

I'm adding Katrin and Mathieu to this discussion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in the DB

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8854

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11090] Bootstrap theme: CSS problem with suggestions toolbar links

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22288|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22348
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22348action=edit
Bug 11090 - Bootstrap theme: CSS problem with suggestions toolbar links

There is a problem with the style on the toolbar on the suggestions page
which makes it float incorrectly. This patch corrects the problem.

To test, log in to the OPAC as a user who has suggestions. The
selections toolbar (which shows the select all, etc. controls) should
look correct.

Signed-off-by: JD@TeTakere joan...@tetakere.org.nz
Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11090] Bootstrap theme: CSS problem with suggestions toolbar links

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed for QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11090] Bootstrap theme: CSS problem with suggestions toolbar links

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to JD@TeTakere from comment #3)
 Logged into Sandbox 8, viewed My Purchase Suggestions.  Toolbar looks fine
 (screenshot attached).

I added your sign off to the patch.
Please switch the status to Signed off instead of Pushed for QA when you
sign off a patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11127] New: OPAC suggestion: the delete link is active when no suggestion selected

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

Bug ID: 11127
   Summary: OPAC suggestion: the delete link is active when no
suggestion selected
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active when no suggestion selected

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|oleon...@myacpl.org |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active when no suggestion selected

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22349
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22349action=edit
Bug 11127: OPAC suggestion: the delete link is active when no suggestion
selected

To reproduce:
1/ go on opac-suggestions.pl
2/ create a suggestion
3/ click on the delete link without checking any checkbox
The form is submitted with a message The selected suggestions have been
deleted..

Test plan:
1/ after applying the patch, click on delete without any checkbox
checked, a js alert should occur.
2/ check at least a cb and click on the delete link. The deletion should
work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active when no suggestion selected

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active when no suggestion selected

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Should I produce the same fix for others themes (bootstrap and ccsr)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11090] Bootstrap theme: CSS problem with suggestions toolbar links

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11127

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
I discovered a bug on testing this patch, see bug 11127.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active when no suggestion selected

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11090

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8854] invoice filters don't all work

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

--- Comment #14 from mathieu saby mathieu.s...@univ-rennes2.fr ---
(In reply to Jonathan Druart from comment #13)
 (In reply to Galen Charlton from comment #9)
  Hmm, the patches for bug 5336, which is now pushed, do not add an
  aqorders.branchcode column.  Maybe something else does?
 
 Galen,
 Finally I decided to abandon this field (see bug 11001).
 I am not sure searching by branch for invoices is relevant since orders from
 different branches can exist for a same invoice.
 Moreover I don't know if filtering on the patron branchcode is the better
 choice: if the aqbasketgroups.billingplace is different, results could be a
 source of misunderstanding. Given that libraries have different work flow
 for acquisitions, results could be good for some and wrong for others.
 Maybe should we simply remove the search by library for invoices?
 
 I'm adding Katrin and Mathieu to this discussion.

Hi
Not sure of what could be the best solution.

But I can tell you how we deal with that in Rennes 2 : 

But the only time whe had to search invoices in Koha, it was to compare the
number and amount of invoices of Koha with the financial tool of the University
(Sifac), to fix discrepancies (invoices received in one tool and not in the
other...)
Koha invoices display was not good for that, so I had to make a SQL report.
The result look like that
Poste budgetaireFournisseurN° factureNom factureFrais de port
(montant)Frais de ports (poste)Qté reçueCout reelPrix public
TTCPrix remisé TTCCout reel * QtéCout reel * Qté + Frais de ports

The first column Poste budgétaire is the name of the fund, which in my
library includes the name of the branch. For ex : BMUS for Library of MUSic.

But if the name of the fund had not included the name of the branch, I probably
would have added 2 columns with basketgroup.billingplace and
basketgroup.deliveryplace.
Because, as we use basketgroups are our main grouping entity for our
relations with our vendors (they receive no info at all about our Koha
baksets), the relevant information for us are basketgroup fields.
But in some libraries it could be baskets fields I presume.


By the way, the filling of basketgroup.{delivery/billing}place should be
syspref dependant. Filling it with the connection site of the librarian is not
good at all for us, and I suppose we are not an isolated case.

Mathieu

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11128] On cancelling receipt, the order is still listed in the received orders

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8230] Show the ordered status in catalogue page

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11128

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11128] On cancelling receipt, the order is still listed in the received orders

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8230

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11128] On cancelling receipt, the order is still listed in the received orders

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22350
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22350action=edit
Bug 11128: On cancelling receipt, the order is still listed in the received
orders

Cause: The list of received orders is built *before* cancelling the receipt!

Test plan:
0/ don't apply the patch
1/ create a basket
2/ create an order with 3 items
3/ receive 1 item
4/ cancel the receipt
= The order is still listed in the received orders table!
5/ apply the patch
6/ do again steps 1 to 4
= The order is not listed in the received orders table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2546] Description of charges: string hardcoded

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #22307|0   |1
is obsolete||

--- Comment #7 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 22351
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22351action=edit
Bug 2546: Description of charges is not translatable

The descriptions for charges are stored in English in the DB
(accountlines.description). So they are not translatable.

This patch removes the descriptions automatically added and generates
the string in the template.

Test plan:
1/ Execute the updatedatabase entry.
2/ Verify in the following pages the description is consistent:
- members/pay.pl?borrowernumber=
- members/boraccount.pl?borrowernumber=
- opac-account.pl
3/ Launch the translate script and update the po files in order to
translate the new strings.
4/ Verify the strings are translated in the interface.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Works as advertised. Corrected few typos in the commit message.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2546] Description of charges: string hardcoded

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11129] New: Limiting the display of Serial issues OR Searching a specific Serial issue

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

Bug ID: 11129
   Summary: Limiting the display of Serial issues OR Searching a
specific Serial issue
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

One can easily have thousands of Serial issue items in the database.
Currently they are shown in the OPAC and Staff Client in one huge table.
Finding and placing a hold on the desired issue number is hard.
Also there are performance considerations when showing huge amounts of issues
unnecessarily.

By filtering the display of issues before they are loaded on screen, we can
fulfill those requirements.
Changing the default view from huge blob to the most recent items saves DB
effort.
All these modifications apply only to biblios which have subscriptions and more
than AllSerialIssuesDisplayThreshold -system preference items.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11129] Limiting the display of Serial issues OR Searching a specific Serial issue

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11129] Limiting the display of Serial issues OR Searching a specific Serial issue

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

--- Comment #1 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Results are filtered by:
branch, volume, number/issue, fromDate, toDate.

Tricky part is ambiguation in volume, number/issue.
This is pulled from the items.enumchron and can have various different ways of
spelling.
Will add a system preference to define the organisation-wide way of labeling
Serial issues.
Filtering cannot be done if the enumerations are not reasonably consistent.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

--- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 22352
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22352action=edit
Bug 11123: 2 routines are unused in C4::Account

C4::Accounts::fixcredit and C4::Accounts::refund are marked as
deprecated and are not used. They can be removed.

Use:
  git grep fixcredit
  git grep refund
and verify these routines are not currently in used.

Bonus: The module exports reconcileaccount which is not defined. The
export is removed too.

MLT: Ran qa tool on this patch with no issues either.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #22319|0   |1
is obsolete||
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #22345|0   |1
is obsolete||

--- Comment #14 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 22353
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22353action=edit
[SIGNED-OFF]  Bug 10544 - stocknumber index is an alias of
Number-local-acquisition

No change

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #22346|0   |1
is obsolete||

--- Comment #15 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 22354
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22354action=edit
[SIGNED-OFF] Bug 10544 - add Number-local-acquisition in known indexes

No change

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2546] Description of charges: string hardcoded

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #8 from M. Tompsett mtomp...@hotmail.com ---
I was looking at the updatedatabase.pl portion of the diff. What descriptions
aren't updated? Why is the table not altered and the description column just
dropped?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #22347|0   |1
is obsolete||

--- Comment #16 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 22355
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22355action=edit
Bug 10544 - add Number-local-acquisition in QueryParser config

I revised QP config.
I changed 'number-local-acq' to 'number-local-acquisition'
It appears all indexes are lowercase in this config.

Please re-sign.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2546] Description of charges: string hardcoded

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546

--- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to M. Tompsett from comment #8)
 I was looking at the updatedatabase.pl portion of the diff. What
 descriptions aren't updated? Why is the table not altered and the
 description column just dropped?

The description may contain your typed-in comments etc.
We cannot drop it.
Go to Fines and pay something just to see..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric format

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

--- Comment #10 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to Koha Team Lyon 3 from comment #9)
 ?!! I deleted these lines, there are not any more in the last patch. Did you
 really test this one (id=2263) ?
I still see those lines in actual patch.

(In reply to Owen Leonard from comment #8)
 I prefer the newer method where the DataTables plugin looks for an
 ISO-formatted date in a title attribute
Me too, it is more clear and alows to display the time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11130] New: Change pl Place-publication index for Marc21

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130

Bug ID: 11130
   Summary: Change pl Place-publication index for Marc21
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: mi...@abunchofthings.net
QA Contact: testo...@bugs.koha-community.org

According to ccl.properties, the pl Place-publication index is supposed to
include 008/15-17 and 260$a. In record.abs, we have the index include all 260
fields. This patch removes the index for the whole field 260, leaving only $a
(and 008/15-17).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11130] Change pl Place-publication index for Marc21

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130

--- Comment #1 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 22356
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22356action=edit
Bug 11130 Change pl Place-publication index for Marc21

According to ccl.properties, the pl Place-publication index is supposed to
include 008/15-17 and 260$a. In record.abs, we have the index include all 260
fields. This patch removes the index for the whole field 260, leaving only $a
(and 008/15-17).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

--- Comment #8 from Blou philippe.blo...@inlibro.com ---
I'd go one step further: All emailing should go through one and only one Koha
method.
It's good practice to have system calls isolated so that when upgrade or a new
platform require adjustment, we don't need to run around touching 10 files.
Or when we simply want to improve the process with validation...

I'd be happy to do that... on a different bug :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11128] On cancelling receipt, the order is still listed in the received orders

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 22125
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22125
Bug 11077: Uninitialized value $pki_field warning

Review of attachment 22125:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11077attachment=22125)
-

::: C4/Auth.pm
@@ +754,5 @@
  -value= $session-id,
  -HttpOnly = 1
  );
 +$userid = $query-param('userid');
 +my $pki_field = C4::Context-preference('AllowPKIAuth') // 'None';

I am not sure it is a good idea to suppress the warning caused by an undefined
syspref. This syspref should exist in the DB, else something wrong happened
when updating the DB. Logs must contain this alert.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

--- Comment #10 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Jonathan Druart from comment #9)
 I am not sure it is a good idea to suppress the warning caused by an
 undefined syspref. This syspref should exist in the DB, else something wrong
 happened when updating the DB. Logs must contain this alert.

If something went wrong updating the DB, should that not be in the logs
already? Suppressing while running in a bad state avoids flooding the logs
more. Flooded logs don't get read. TL;DR is a new short form I've come to
learn: Too Long; Didn't Read. This means the the less flooded log has a better
chance of having someone catch the error and correct it. Just my thoughts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #22323|0   |1
is obsolete||

--- Comment #31 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 22357
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22357action=edit
Bug 7376 - Transfer limits should be checked at check-in

Extended UseBranchTransferLimits-check to the check-in case.
Made it possible to override the check-in with circulation-permission if
BranchTransfer is denied.
Made unit tests for the C4/Circulation.pm and C4/SIP/t/08checkin.t

*Also added override-functionality to Circulation::AddReturn() to override
BranchTransferLimits. (+unit tests)
*Renamed CanBookBeReturned to CanItemBeReturned since that function was
referenced from AddReturn only.
--This is because function name misguidingly references to a
book/Biblio/Title-level, even if the functionality is strictly
--Item dependent.
*Removed duplicating code by making CanItemBeTransferred() call
IsBranchTransferAllowed().
*Made a unit test library out of CanItemBeTransferred.t's environment
initialization parts,
  so these need not be duplicated whenever UseBranchTransferLimits-related
functionality is tested.
*Documented SIP-testing hardships to C4/SIP/README

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to M. Tompsett from comment #10)
 If something went wrong updating the DB, should that not be in the logs
 already?

I still disagree :) For some reasons, the administrator may have not seen the
error when updating the DB. If there is nothing in logs, there is nothing to
warn him.
So, I let another QAer to have a look at this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10075] Extend CGI to provide a param_utf8_decode method

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10075

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|NEW |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11131] Authority search does not display summary while searching by all auth types

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11131] New: Authority search does not display summary while searching by all auth types

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131

Bug ID: 11131
   Summary: Authority search does not display summary while
searching by all auth types
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

To reproduce:
- go on authorities/authorities-home.pl
- search 'hugo' by authtype author
- results are displayed with summary
- now select the all authority types entry and search hugo: the results but
without the summary

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11131] Authority search does not display summary while searching by all auth types

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22358
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22358action=edit
Bug 11131: Authority search does not display summary while searching by all
auth types

The summary is built using the authtypecode selected from the interface.
So when a search is launch on all auth types, the summary is not
correctly built by the BuildSummary routine.
It should get the authtypecode from the authority (call to
GetAuthTypeCode).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11131] Authority search does not display summary while searching by all auth types

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active when no suggestion selected

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
Instead of adding the disabled attribute to an element which isn't really
supposed to have it (according to the specification) I think it would be better
to check for the existence of a checked checkbox:

  var checkedBoxes = $(input:checked);
  if ($(checkedBoxes).size() == 0) {
 alert(MSG_NO_RECORD_SELECTED);
 return false;
  }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22056|0   |1
is obsolete||
  Attachment #22057|0   |1
is obsolete||

--- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22359
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22359action=edit
Bug 10855: FIX: Add additional fields for closed subscriptions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22360
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22360action=edit
Bug 10855: Fix instance vs static method

This patch fixes the error message.
The 3 modified routines *are* static methods.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11132] The results list is reset on adding a biblio to a list

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|oleon...@myacpl.org |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11132] New: The results list is reset on adding a biblio to a list

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132

Bug ID: 11132
   Summary: The results list is reset on adding a biblio to a list
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

To reproduce:
- launch a search at the OPAC (opac-search.pl).
- click on a result and browse results (using previous/next links).
- a title attract your attention and you add it to a list (Save to yours
lists link on the right).
- save the list
- browse again results: you cannot, the browse results bloc has disappeared.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11133] New: Markup errors in OPAC place hold form HTML

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133

Bug ID: 11133
   Summary: Markup errors in OPAC place hold form HTML
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

There are a couple of markup errors in the new OPAC place hold form. They don't
appear to cause problems but should be fixed for validity's sake.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11132] The results list is reset on adding a biblio to a list

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22362
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22362action=edit
Bug 11132: The results list is reset on adding a biblio to a list

A busc param is cleared if the template name is not opac-.*detail.tt.
So if a user adds a biblio to a list, he cannot continue to browse
results.

Test plan:
- launch a search at the OPAC (opac-search.pl).
- click on a result and browse results (using previous/next links).
- a title attract your attention and you add it to a list (Save to yours
lists link on the right).
- save the list.
- browse again results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11132] The results list is reset on adding a biblio to a list

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11132

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10626] Remove doubled up TT plugins

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20847|0   |1
is obsolete||

--- Comment #20 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22363
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22363action=edit
Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches -
Followup

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
To test:
Make sure
- independentbranches is turned on
- Your user doesn't have superlibrarian permission
Then
- Try to check out an item with home and holding branch !=
  logged in branch

Patch works alright.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11132] The results list is reset on adding a biblio to a list

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10858

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10626] Remove doubled up TT plugins

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

--- Comment #24 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22367
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22367action=edit
Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and
AuthorisedValues

Looking at the TT plugin directory I notice we have some plugins that
seem to do the same thing:

KohaAuthorisedValues.pm
AuthorisedValues.pm

Test Plan:
1) Apply this patch
2) View the pages that this patch has modified, make sure the branch
   name is still visible

Signed-off-by: Chris Cormack chr...@catalyst.net.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Comments on second patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10626] Remove doubled up TT plugins

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

--- Comment #21 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22364
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22364action=edit
Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and
AuthorisedValues

Looking at the TT plugin directory I notice we have some plugins that
seem to do the same thing:

KohaAuthorisedValues.pm
AuthorisedValues.pm

Test Plan:
1) Apply this patch
2) View the pages that this patch has modified, make sure the branch
   name is still visible

Signed-off-by: Chris Cormack chr...@catalyst.net.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Comments on second patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10626] Remove doubled up TT plugins

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20848|0   |1
is obsolete||
  Attachment #20849|0   |1
is obsolete||
  Attachment #20962|0   |1
is obsolete||
  Attachment #22361|0   |1
is obsolete||
  Attachment #22363|0   |1
is obsolete||
  Attachment #22364|0   |1
is obsolete||

--- Comment #22 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22365
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22365action=edit
Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches

Looking at the TT plugin directory I notice we have some plugins that
seem to do the same thing:

KohaBranchName.pm
Branches.pm

Test Plan:
1) Apply this patch
2) View a basket group, note the branch name is displayed
3) View a subscription's details, note the branch name is displayed
4) View suggestions, note the branch names are displayed
5) Return an item that needs transfered, note the branch name is displayed
6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t'

Signed-off-by: Chris Cormack chr...@catalyst.net.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes all tests and QA script.
Also tested with a branch name with umlauts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10626] Remove doubled up TT plugins

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

--- Comment #23 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22366
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22366action=edit
Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches -
Followup

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
To test:
Make sure
- independentbranches is turned on
- Your user doesn't have superlibrarian permission
Then
- Try to check out an item with home and holding branch !=
  logged in branch

Patch works alright.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10626] Remove doubled up TT plugins

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

--- Comment #25 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22368
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22368action=edit
Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and
AuthorisedValues - Followup

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Trying to write my own test plan here:

1) AllowNotForLoanOverride = Allow
   Mark single item not for loan and try to check it out.
   Check item not for loan status shows up correctly in message:
   Item is normally not for loan (Staff Collection). Check out anyway?

2) Toggle AllowNotForLoanOverride = Not Allow
   Try to check out your not for loan item again.
   Message has changed, but not for loan status should still show:
   Item not for loan (Staff Collection).

3) Check out item that is marked damaged.
   Check damaged status shows correctly in list of checkouts.

4) Mark item as lost and check it out.
   Check lost status shows up correctly in message:
   This item has been lost with a status of Lange überfällig (Verloren).

5) Create your own custom SUGGEST_STATUS and check that it shows
   up correctly on the suggestion page.

6) Test item status show up correctly on OPAC detail page (lost, not
   for loan, damaged, etc). Requires follow-up patch to be applied.

7) Mark a suggestion with your custom status and make sure it shows
   up in the patron account in OPAC correctly.

Passes tests and QA script - needs a follow up for item-status-schema-org.inc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10626] Remove doubled up TT plugins

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

--- Comment #26 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22369
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22369action=edit
Bug 10626: Remove doubled up TT plugins - Merge KohaAuthorisedValues and
AuthorisedValues - Followup 2

Removes USE KohaAuthorisedValues plugin from
item-status-schema-org.inc as it does not seem to be used
in the file.

Couldn't detect regressions removing it on OPAC detail page.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10626] Remove doubled up TT plugins

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

--- Comment #27 from Kyle M Hall k...@bywatersolutions.com ---
Rebased first patch to fix merge conflicts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries'

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high
   Severity|enhancement |critical

--- Comment #1 from Galen Charlton gmcha...@gmail.com ---
Here is the error message that gets logged when I try such a search with both
UseQueryParser and OpacSuppression on:

opac-search.pl: WARNING: query problem with (@attr 2=102 @or @or @attr 1=1016
@attr 5=1 @attr 4=6 history @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6
history @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 history) not Suppress=1
ZOOM error 20003 can't set prefix query (addinfo: (@attr 2=102 @or @or @attr
1=1016 @attr 5=1 @attr 4=6 history @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6
history @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 history) not
Suppress=1) from diag-set 'ZOOM' at /home/gmc/koha/C4/Search.pm line 378.,
referer:
http://opac.zadi.librarypolice.com/cgi-bin/koha/opac-search.pl?idx=q=historybranch_group_limit=

I'm bumping up the severity to critical as this would be a blocker to making
QueryParser turned on by default for new installations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10626] Remove doubled up TT plugins

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20846|0   |1
is obsolete||

--- Comment #19 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22361
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22361action=edit
Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches

Looking at the TT plugin directory I notice we have some plugins that
seem to do the same thing:

KohaBranchName.pm
Branches.pm

Test Plan:
1) Apply this patch
2) View a basket group, note the branch name is displayed
3) View a subscription's details, note the branch name is displayed
4) View suggestions, note the branch names are displayed
5) Return an item that needs transfered, note the branch name is displayed
6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t'

Signed-off-by: Chris Cormack chr...@catalyst.net.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes all tests and QA script.
Also tested with a branch name with umlauts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11134] New: Typo on course reserves help

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11134

Bug ID: 11134
   Summary: Typo on course reserves help
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Course reserves
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bgkrie...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Small typo con course reserves help

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11134] Typo on course reserves help

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11134

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8004] Items on hold lose transfer after being scanned twice

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004

--- Comment #15 from Kyle M Hall k...@bywatersolutions.com ---
I'm a but confused about the state of this bug. The initial patch is in master.
Do we still need these followups?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11134] Typo on course reserves help

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11134

--- Comment #1 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 22370
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22370action=edit
Bug 11134 - Typo on course reserves help

This patch fixes a small typo on course reserves help

To test:
1) Go to Course reserves
2) Press 'New course'
3) Press Help
4) On 3dr paragraph you will read To link a ninstructor ...
5) Apply patch
6) Now it reads To link an instructor ...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11134] Typo on course reserves help

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11134

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11135] New: Parsing of OVERRIDE_SYSPREF_NAMES logs warnings

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11135

Bug ID: 11135
   Summary: Parsing of OVERRIDE_SYSPREF_NAMES logs warnings
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: colin.campb...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

The recently added environment variable OVERRIDE_SYSPREF_NAMES is parsed using
split but most of the time we're splitting an undefined variable. This fills
the error log with warnings, so we should check theres something to split
before executing it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

  Attachment #22371|0   |1
is obsolete||

--- Comment #38 from Nicole C. Engard neng...@gmail.com ---
Created attachment 22372
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22372action=edit
Bug 10671: Update Circ Help Files

This patch updates the existing help files and
adds the missing offline circ help file.

To test:

* Visit all circ pages and check the manual links
* Visit the new offline circulation page and confirm text
and link are there (link will work after 10/25)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11135] Parsing of OVERRIDE_SYSPREF_NAMES logs warnings

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11135

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |colin.campbell@ptfs-europe.
   ||com

--- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com ---
Created attachment 22373
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22373action=edit
Proposed patch

lets take warnings seriously folks 

To test this patch should stop 'Use of uninitialized value in split' be
generated when viewing and updating system preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #39 from Nicole C. Engard neng...@gmail.com ---
Created attachment 22374
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22374action=edit
Bug 10671: Update Offline Circ Help

This patch updates the offline circulation help files.

To test:

Visit the KOC file upload and pending transactions page
Review the help and check the links

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #40 from Nicole C. Engard neng...@gmail.com ---
Created attachment 22375
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22375action=edit
Bug 10671: Remove Unused Help File

This patch removes an unused help file in the help/export
folder.

To test:

Just confirm that the file is removed, there were no links
to it anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #41 from Nicole C. Engard neng...@gmail.com ---
Created attachment 22376
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22376action=edit
Bug 10671: Update Reviews Help

This patch updates the link to the manual in the comments
moderation help.

To test:

* Visit comments moderation
* Click the help link
* Confirm manual link works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #42 from Nicole C. Engard neng...@gmail.com ---
Created attachment 22377
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22377action=edit
Bug 10671: Update holds help

This patch updates the manual link in the holds help
file.

To test:

* Place a hold in the staff client
* Click the help link
* Confirm manual link works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries'

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
Poking at this more, the immediate cause of the problem is that tacking on 'not
Suppress=1' to the end of a PQF query generated by QP is a syntax error.  That
can be addressed by munging the input to buildQuery(), but I've run into a
roadblock: the PQF QueryParser driver needs to be taught how to use the
negation operator.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #5 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8854] invoice filters don't all work

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

--- Comment #15 from Galen Charlton gmcha...@gmail.com ---
(In reply to mathieu saby from comment #14)
 By the way, the filling of basketgroup.{delivery/billing}place should be
 syspref dependant. Filling it with the connection site of the librarian is
 not good at all for us, and I suppose we are not an isolated case.

I'm not sure it warrants a syspref, and I'd prefer that deliveryplace and
billingplace be FKs to the branches table.  Would adding a freebillingplace
column in addition to the exsting freedeliveryplace column meet your needs?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11136] New: action_logs should be a MyISAM table, not InnoDB

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

Bug ID: 11136
   Summary: action_logs should be a MyISAM table, not InnoDB
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The table action_logs is written too at a higher rate than practically any
other table. Additionally, action_logs has no foreign key constraints. It seems
that this would be a somewhat unique situation where using MyISAM would provide
quite a performance boost for large sites with many transactions that use the
Action Logs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11136] action_logs should be a MyISAM table, not InnoDB

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22378
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22378action=edit
Bug 11136 - action_logs should be a MyISAM table, not InnoDB

The table action_logs is written too at a higher rate than practically
any other table. Additionally, action_logs has no foreign key
constraints. It seems that this would be a somewhat unique situation
where using MyISAM would provide quite a performance boost for large
sites with many transactions that use the Action Logs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11136] action_logs should be a MyISAM table, not InnoDB

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11136] action_logs should be a MyISAM table, not InnoDB

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

--- Comment #12 from M. Tompsett mtomp...@hotmail.com ---
I did the following testing to see what the current behaviour is and what the
modified behaviour is:
1) I restored a database from 3 months ago.
2) echo  koha-error_log
3) echo  koha-opac-error_log
4) echo  koha-zebradaemon.err
5) ran the staff client upgrade process.
6) logged in.
7) logged out.
8) deleted the AllowPKIAuth system preference.
9) echo  koha-error_log
10) echo  koha-opac-error_log
11) echo  koha-zebradaemon.err
12) clicked the login in button with nothing.

(I chose this case, because between valid, invalid, username only, password
only, and completely blank, the completely blank is easiest to test and show
the difference)

[Thu Oct 24 14:30:42 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:42
2013] mainpage.pl: Use of uninitialized value in string ne at
/home/mtompset/kohaclone/C4/Auth.pm line 685., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl?logout.x=1
[Thu Oct 24 14:30:42 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:42
2013] mainpage.pl: Use of uninitialized value $pki_field in string ne at
/home/mtompset/kohaclone/C4/Auth.pm line 758., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl?logout.x=1
[Thu Oct 24 14:30:42 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:42
2013] mainpage.pl: Use of uninitialized value $pki_field in string eq at
/home/mtompset/kohaclone/C4/Auth.pm line 795., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl?logout.x=1
[Thu Oct 24 14:30:42 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:42
2013] mainpage.pl: Use of uninitialized value $pki_field in string eq at
/home/mtompset/kohaclone/C4/Auth.pm line 795., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl?logout.x=1
[Thu Oct 24 14:30:42 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:42
2013] mainpage.pl: Use of uninitialized value $retuserid in string ne at
/home/mtompset/kohaclone/C4/Auth.pm line 832., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl?logout.x=1
[Thu Oct 24 14:30:42 2013] [error] [client 192.168.45.23] File does not exist:
/home/mtompset/kohaclone/koha-tmpl/intranet-tmpl/prog/en/css/color.css,
referer: http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl
[Thu Oct 24 14:30:43 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:43
2013] 404.pl: Use of uninitialized value $lasttime in numeric lt () at
/home/mtompset/kohaclone/C4/Auth.pm line 709., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl
[Thu Oct 24 14:30:43 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:43
2013] 404.pl: Use of uninitialized value $pki_field in string ne at
/home/mtompset/kohaclone/C4/Auth.pm line 758., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl
[Thu Oct 24 14:30:43 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:43
2013] 404.pl: Use of uninitialized value $pki_field in string eq at
/home/mtompset/kohaclone/C4/Auth.pm line 795., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl
[Thu Oct 24 14:30:43 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:43
2013] 404.pl: Use of uninitialized value $pki_field in string eq at
/home/mtompset/kohaclone/C4/Auth.pm line 795., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl
[Thu Oct 24 14:30:43 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:43
2013] 404.pl: Use of uninitialized value $retuserid in string ne at
/home/mtompset/kohaclone/C4/Auth.pm line 832., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl

Now apply the patch, clear the logs, and click that login button again.


[Thu Oct 24 14:32:54 2013] [error] [client 192.168.45.23] File does not exist:
/home/mtompset/kohaclone/koha-tmpl/intranet-tmpl/prog/en/css/color.css,
referer: http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl
[Thu Oct 24 14:32:54 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:32:54
2013] 404.pl: Use of uninitialized value $lasttime in numeric lt () at
/home/mtompset/kohaclone/C4/Auth.pm line 709., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl

The key is noticing that 832 did not trigger an error! This else is inside the
if which we fixed. So, 'None' is wrong, because it is a different behaviour. I
changed it to '', and retried.

[Thu Oct 24 14:37:04 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:37:04
2013] mainpage.pl: Use of uninitialized value $retuserid in string ne at
/home/mtompset/kohaclone/C4/Auth.pm line 833., referer:

[Koha-bugs] [Bug 8991] Add a script to delete old orders

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

   When did the bot|2013-09-24 00:00:00 |2013-10-25
last check this||

--- Comment #17 from I'm just a bot git...@bugs.koha-community.org ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10480] Cataloging plugins without redefining

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

   When did the bot|2013-09-24 00:00:00 |2013-10-25
last check this||

--- Comment #11 from I'm just a bot git...@bugs.koha-community.org ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date.

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

   When did the bot|2013-09-24 00:00:00 |2013-10-25
last check this||

--- Comment #12 from I'm just a bot git...@bugs.koha-community.org ---
This bug depends on 8367 which is in status Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9940] Add a new index for original language of document

2013-10-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9940

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
   When did the bot|2013-09-24 00:00:00 |2013-10-25
last check this||

--- Comment #3 from I'm just a bot git...@bugs.koha-community.org ---
Applying: Bug 9940 : Add a new index for the original language of a document
Using index info to reconstruct a base tree...
MC4/Search.pm
Metc/zebradb/biblios/etc/bib1.att
Metc/zebradb/ccl.properties
Metc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml
Metc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
Metc/zebradb/marc_defs/marc21/biblios/record.abs
Metc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
Metc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl
Metc/zebradb/marc_defs/unimarc/biblios/record.abs
Falling back to patching base and 3-way merge...
Auto-merging etc/zebradb/marc_defs/unimarc/biblios/record.abs
CONFLICT (content): Merge conflict in
etc/zebradb/marc_defs/unimarc/biblios/record.abs
Auto-merging etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl
Auto-merging etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
Auto-merging etc/zebradb/marc_defs/marc21/biblios/record.abs
Auto-merging etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
Auto-merging etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml
Auto-merging etc/zebradb/ccl.properties
Auto-merging etc/zebradb/biblios/etc/bib1.att
Auto-merging C4/Search.pm
Patch failed at 0001 Bug 9940 : Add a new index for the original language of a
document
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run git am --continue.
If you prefer to skip this patch, run git am --skip instead.
To restore the original branch and stop patching, run git am --abort.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >