[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #32 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to M. Tompsett from comment #30)
Also, my patch depends on his, so should I squash our patches together, and
get a single sign off? Should I correct mine after he corrects his? This is
a very weird scenario to have with 3 pieces in 3 vastly different states.
I'm happy to fix them any which way, but what is the best course of action?
I agree with most changes, including the one where s_userid and q_userid are
compared.
I think the second patch should not be pushed in its current form, although the
third patch resolves the situation.
So I recommend to squash both patches and get a signoff on the new patch.
If you can add a test plan too, go ahead :)
One point remaining: I do not agree with the PKIAuth change in your last patch.
If you do:
+my $pki_field = C4::Context-preference('AllowPKIAuth') // '';
combined with: || $pki_field ne 'None', what is the result?
An undef in AllowPKIAuth now makes None ne '' so the compare is true. The test
should only be true if AllowPKIAuth is a value not equal to None or empty
string (undef). So leaving it preference // None was correct.
Thanks for your attention to these details!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Galen Charlton from comment #32) Kyle, Paul, Jonathan: do any of you have the wherewithal to run with that idea for 3.16? I don't plan to work on that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11129] Filtering Items based on type in opac-detail.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #23172|0 |1 is obsolete|| --- Comment #8 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 23205 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23205action=edit Bug 11129 - Filtering Items based on type in opac-detail.pl Currently all Items are always shown on the opac-detail.pl. This is difficult when the amount of Items grows substantially large. Implemented a filter to limit the Items shown (and SELECTed from the DB) based on some typical filters, locationbranch, volume, number, issue, fromDate, toDate. Also streamlined how Serials-data is pulled from the DB to prevent substantial extra work in C4::Items::GetItemsInfo(). C4::Items::GetItemsInfo() extended to support various filters. All modifications: Item filter shown when there are over 50 items (lotsofitems-flag). Filter fields can be changed based on the Biblio type (isSerial-flag). -Volume + Issue + Number available only for serials. Can syspref if Issue-field is used in serial records. Can syspref a regexp to parse the Volume + Number + Issue from the enumeration or chronology field. FromDate and ToDate filter the serial.publisheddate when dealing with serials otherwise target the items.timestamp -column. C4::Items::GetItemsInfo() simplified to include the serial data in the BIG SQL. This makes filtering by publisheddate much more faster. User input validated using HTML5 input number Business layer validations as well. Unit tests: Serials enumeration and chronology filtering Items date and branch filtering Sponsored by the Joensuu Regional Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11319] New: Marc modification templates improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Bug ID: 11319 Summary: Marc modification templates improvements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org Bug 8015 is pushed and I plan to take over bug 5725. The idea will be to provide a batch modification tools for records (biblios and authorities). But before, I have to prepare the ground: Koha::SimpleMARC does not split clearly fields and subfields manipulations. The API should provide routines like copy_field and copy_subfield for example. Later the UI will have to reflect this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11319] Marc modification templates improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23206 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23206action=edit Bug 11319: POC Marc modification templates improvements This patch is a POC. Please give me your feedback on the implementation of the fields/subfields split. This patch only implements the delete and the read routines. See new UT at the end of t/SimpleMARC.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11319] Marc modification templates improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |In Discussion CC||gmcha...@gmail.com, ||k...@bywatersolutions.com Depends on||8015 Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Kyle and Galen, I really would like to have your opinion on this patch please. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||11319 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6385] All items should optionally be displayed by default in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #23173|0 |1 is obsolete|| --- Comment #10 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 23207 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23207action=edit Bug 6385 - All items should optionally be displayed by default in the OPAC Added a system preference OPACmaxItemsOnDetail to set a threshold after which only results from the users branch are displayed, or Items from the past year if homebranch cannot be defined. This tightly couples with bug 11129 which provides the filtering mechanism to display smaller result sets. Also added lots of complexity to define the warning messages based on is the filter used to override the OPACmaxItemsOnDetail. Added a new limit-filter to C4::Items::GetItemsInfo() which adds the LIMIT-clause to the big SQL. Added a unit test for the filter to the Items.t Fixed a use-case where a user has no items in his branch, and the limited items set is emtpy. Now using items from past year if none available in the users branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6385] All items should optionally be displayed by default in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #23207|0 |1 is obsolete|| --- Comment #11 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 23208 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23208action=edit Bug 6385 - All items should optionally be displayed by default in the OPAC Added a system preference OPACmaxItemsOnDetail to set a threshold after which only results from the users branch are displayed, or Items from the past year if homebranch cannot be defined. This tightly couples with bug 11129 which provides the filtering mechanism to display smaller result sets. Also added lots of complexity to define the warning messages based on is the filter used to override the OPACmaxItemsOnDetail. Added a new limit-filter to C4::Items::GetItemsInfo() which adds the LIMIT-clause to the big SQL. Added a unit test for the filter to the Items.t Fixed a use-case where a user has no items in his branch, and the limited items set is emtpy. Now using items from past year if none available in the users branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11157] Placing a simple item-level hold for serials.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #22571|0 |1 is obsolete|| --- Comment #18 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 23209 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23209action=edit Bug 11157 - Placing a simple item-level hold for serials in OPAC. For biblios marked as a serial or if the syspref: -OPACShowPlaceItemLevelHold or is enabled. Adds a Place hold-link after each item in the detailed biblio view. Uses the template parameter 'norequest', to disable the Place hold-link in the sidebar opac-detail-sidebar.inc for serials. Added a new parameter itemnumber to opac-reserve.pl/.tt. This causes the reserving module to display only the desired item, preselect it and hide unnecessary buttons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11157] Placing a simple item-level hold for serials.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #22572|0 |1 is obsolete|| --- Comment #19 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 23210 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23210action=edit Bug 11157 - Placing a simple item-level hold for serials in staff client. For biblios marked as a serial or if the syspref: -ShowPlaceItemLevelHold is enabled. Adds a Place hold-link after each item in the detailed biblio view. Added a new parameter itemnumber to reserve.pl/.tt. This causes the reserving module to display only the desired item, preselect it and hide unnecessary buttons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact|testo...@bugs.koha-communit |jonathan.dru...@biblibre.co |y.org |m --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Looks good, the patch works as expected. No regression found. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #20710|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23211 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23211action=edit Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to my summary and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold 6) Disable AutoResumeSuspendedHolds, ensure the suspend until date field is no longer visible. 7) Disable SuspendHoldsOpac, ensure all suspension related fields are no longer visible. Signed-off-by: Chris Rohde cro...@roseville.ca.us Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11244] notices ignoring the dateformat preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Kyle, The patch works but don't you think it is easier to parse the variable value and assume it is a date if it matches -MM-DD or -MM-DD HH:MM:SS? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23212 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23212action=edit [ALT] Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23212|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Wrong bug number... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11244] notices ignoring the dateformat preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23213 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23213action=edit [ALT] Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Assignee|k...@bywatersolutions.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jcam...@cpbibliography.com --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Blou from comment #3) Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced it but I couldn't find ANY usage of it to fix. Same for me. Jared, could you confirm your development for Offline circulation (bug 10240) includes this js file but don't use it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #23199|0 |1
is obsolete||
--- Comment #33 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 23214
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23214action=edit
Bug 11077 - Correct silent warnings in C4/Auth.pm
This patch corrects a noisy ne condition.
$userid = $retuserid if ( $retuserid ne '');
became
$userid = $retuserid if ( $retuserid );
It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's
patch, while correcting the problems found.
This includes:
my $q_userid = $query-param('userid') // '';
along with:
my $s_userid = '';
and:
my $s_userid = $session-param('id') // '';
Indentation does not reflect actual scoping.
And the 'None' is changed to '', since that behaves properly
in the undef case:
my $pki_field = C4::Context-preference('AllowPKIAuth');
if (!defined($pki_field)) {
print STDERR Error: Missing AllowPKIAuth System Preference!\n;
$pki_field = '';
}
Because if it was set to 'None' in the undefined case, then
'None' ne 'None' is false, and the if case would not run.
However, undef ne 'None' is true and runs with an error log
entry. By putting the define check as a separate if clause, a
meaningful error message can be given rather than a ubiquitous
undef compare check failure message.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #34 from M. Tompsett mtomp...@hotmail.com --- Created attachment 23215 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23215action=edit Confirmation of what I said regarding undef ne 'None' I believe this clarifies the problem even better, and this sample program demonstrates why I believe '' is the correct value to default in the undef case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 --- Comment #7 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to Jonathan Druart from comment #6) (In reply to Blou from comment #3) Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced it but I couldn't find ANY usage of it to fix. Same for me. Jared, could you confirm your development for Offline circulation (bug 10240) includes this js file but don't use it? The offline circulation module includes the file via doc-head-close.inc. If the file is changed there, it must be changed in the manifest as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #35 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to M. Tompsett from comment #34) Created attachment 23215 [details] Confirmation of what I said regarding undef ne 'None' I believe this clarifies the problem even better, and this sample program demonstrates why I believe '' is the correct value to default in the undef case. Maybe we have some misunderstanding? Correct me if I am wrong but if PKIAuth is None or undef, the if statement should not be run (so we should make the expr be false). Do you agree? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #36 from M. Tompsett mtomp...@hotmail.com --- (In reply to M. de Rooy from comment #35) Maybe we have some misunderstanding? We may have some cross-talk. Correct me if I am wrong but if PKIAuth is None or undef, the if statement should not be run (so we should make the expr be false). Do you agree? My sample program demonstrates how it currently works and does not make a judgement one way or another about how it should work. Using '' mimics current behaviour. And though that may not be correct in how it should behave, patches fixing one thing (floody logs) should not cause a behaviour change in another (how it does work). If the issue remains about how it should work (as compared to how it does work), that would be another bug fix in my opinion. Does that clarify where I am coming from? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com --- Early QA comment: 1/ new routine needs unit tests 2/ remove tab characters 3/ perltidy new pl script 4/ use Modern::Perl; (you only use strict) 5/ only 1 syspref is added to sysprefs.sql 6/ why don't you sent the email using utf8? 7/ on generating the new password char, maybe should you use the alphabet syspref (+ numbers) 8/ why don't you use koha opac header for opac-send-password-recovery template file? 9/ use the tt plugin to access to syspref value (Koha.Preference(mypref)). 10/ what is the 'UNAUTHORIZ' check (in opac-password-recovery.pl)? 10 is a good number. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Haaa :) Thanks Jared for the clarification! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9224] acqui/finishreceive.pl is not Plack-compatible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9224 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9224] acqui/finishreceive.pl is not Plack-compatible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9224 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #22020|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23216 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23216action=edit Bug 9224: Make acqui/finishreceive.pl Plack-compatible Under Plack/mod_perl wrapping, sub update_item() will become a closure, so after the 1st run it will retain it's own private instances of the following variables: $booksellerid, $datereceived, $unitprice, $rrp, $biblionumber. I.e., in case update_item() gets invoked 2nd+ time (inside the same process, but for different-subsequent receives) it may incorrectly flag the (old, wrong) biblionumber for Zebra reindexing, and erronously modify the current item[s] with the previously used (wrong) values. This simple patch should make acqui/finishreceive.pl Plack-compatible. Test plan: Test patched acqui/finishreceive.pl script (create and receive some orders w/ items, etc.). Ensure items are gettting added and/or modified correctly during receiving process. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #37 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to M. Tompsett from comment #36) Correct me if I am wrong but if PKIAuth is None or undef, the if statement should not be run (so we should make the expr be false). Do you agree? My sample program demonstrates how it currently works and does not make a judgement one way or another about how it should work. Using '' mimics current behaviour. And though that may not be correct in how it should behave, patches fixing one thing (floody logs) should not cause a behaviour change in another (how it does work). If the issue remains about how it should work (as compared to how it does work), that would be another bug fix in my opinion. Does that clarify where I am coming from? That makes sense. Actually, we are talking about functionality. But for such a fictive situation (you need to delete your AllowPKIAuth pref and have all other conditions be false), I think we do not need to open a new report. This behavior change is so minimal that touching this line and fixing it can be done rightaway. For the record, the behavior change is actually made in the first patch that has been signed off and passed qa and your third patch changes it back to current behavior with the latent undef-mini-minibug. But if you scroll through the code, you will see that in both cases the overall effect will be: userid=return=0, auth rejected. So no big deal. Just theory. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #38 from M. Tompsett mtomp...@hotmail.com --- Created attachment 23217 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23217action=edit Bug 11077 - Fix indents to trace code more easily -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #39 from M. Tompsett mtomp...@hotmail.com --- Yes, my patch does change it back. I did as you suggested and looked at the code again. If we set the variable to 'None', it bypasses the if completely. If we set the variable to '', it goes through the elsif check, but runs the else which fail (due to a lack of userid). The return check fails, triggering the else which does nothings, because of the lack of userid. In the end, a lack of login is accomplished either way. Since 'None' was approved via the QA process, I'll change my patch to exclude that tweak. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #23217|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #23214|0 |1
is obsolete||
--- Comment #40 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 23218
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23218action=edit
Bug 11077 - Correct silent warnings in C4/Auth.pm
This patch corrects a noisy ne condition.
$userid = $retuserid if ( $retuserid ne '');
became
$userid = $retuserid if ( $retuserid );
It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's
patch, while correcting the problems found.
This includes:
my $q_userid = $query-param('userid') // '';
along with:
my $s_userid = '';
and:
my $s_userid = $session-param('id') // '';
Indentation does not reflect actual scoping.
A missing system preference would have triggered a ubiquitous
undef compare check failure message. This makes the flooding
message more useful, so as to help correct it.
The change to accomplish this was:
my $pki_field = C4::Context-preference('AllowPKIAuth');
if (!defined($pki_field)) {
print STDERR Error: Missing AllowPKIAuth System Preference!\n;
$pki_field = 'None';
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #23215|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8676] show vendor name in source of acquisition
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 marjorie barry-vila marjorie.barry-v...@ccsr.qc.ca changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #41 from M. Tompsett mtomp...@hotmail.com --- Test Plan: - Go to staff client - Click the login button without typing anything - Type just a username without a password and click the login button - Backup DB - Delete the AllowPKIAuth System Preference - Restore DB Note the amount of noise. - Apply Patches (All three) - Go to staff client - Click the login button without typing anything - Type just a username without a password and click the login button - Backup DB - Delete the AllowPKIAuth System Preference - Restore DB The only noise should be the clarified error: ERROR: Missing system preference AllowPKIAuth. This makes the non-sensical flood clearer. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #42 from M. Tompsett mtomp...@hotmail.com --- (In reply to M. Tompsett from comment #41) - Delete the AllowPKIAuth System Preference Oops... and click the login button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #23218|0 |1
is obsolete||
--- Comment #43 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 23219
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23219action=edit
Bug 11077 - Correct silent warnings in C4/Auth.pm
This gets rid of some more warnings.
It also corrects a noisy ne condition.
$userid = $retuserid if ( $retuserid ne '');
became
$userid = $retuserid if ( $retuserid );
It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's
patch, while correcting the problems found.
This includes:
my $q_userid = $query-param('userid') // '';
along with:
my $s_userid = '';
and:
my $s_userid = $session-param('id') // '';
Indentation does not reflect actual scoping.
A missing system preference would have triggered a ubiquitous
undef compare check failure message. This makes the flooding
message more useful, so as to help correct it.
The change to accomplish this was:
my $pki_field = C4::Context-preference('AllowPKIAuth');
if (!defined($pki_field)) {
print STDERR Error: Missing AllowPKIAuth System Preference!\n;
$pki_field = 'None';
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #23198|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #44 from M. Tompsett mtomp...@hotmail.com --- Confirmed with Srdjan Jankovic that is was okay to squash our patches together. All should be good to go. Here is the latest test plan: - Go to staff client - Click the login button without typing anything - Type just a username without a password and click the login button - Backup DB - Delete the AllowPKIAuth System Preference, and refresh the staff client. - Restore DB Note the amount of noise. - Apply Patches (Both) - Go to staff client - Click the login button without typing anything - Type just a username without a password and click the login button - Backup DB - Delete the AllowPKIAuth System Preference, and refresh the staff client. - Restore DB The only noise should be the clarified error: ERROR: Missing system preference AllowPKIAuth. This makes the non-sensical flood clearer. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 Doug Kingston d...@randomnotes.org changed: What|Removed |Added Attachment #22458|0 |1 is obsolete|| Attachment #22506|0 |1 is obsolete|| Attachment #22508|0 |1 is obsolete|| Attachment #22532|0 |1 is obsolete|| Attachment #22985|0 |1 is obsolete|| Attachment #22992|0 |1 is obsolete|| --- Comment #33 from Doug Kingston d...@randomnotes.org --- Created attachment 23220 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23220action=edit Bug 11078 Add locking to rebuild_zebra (rollup 11/28) This patch is a rollup of earlier patches and moves the lockfile to a parallel directory to the other zebra lock files. This should address all the issues as to where this file should be indifferent cases. It now behaves just like the other zebra lock files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
