[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #18 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hm, from the subject of this it looks a bit like it should better be several
patches ('Ätell the RM a story' ;) ) than one big patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11363] New: Label printer profile units are not translatable

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11363

Bug ID: 11363
   Summary: Label printer profile units are not translatable
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pasi.kalli...@pttk.fi
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

Tools  Labels  Printer profiles  Edit printer profile has a pull-down for
printing units. The pull-down has entries such as Postscript Points, Adobe
Agates, etc. The values in the pull-down cannot be translated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11364] New: Label layout types and text justification types are not translatable

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364

Bug ID: 11364
   Summary: Label layout types and text justification types are
not translatable
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pasi.kalli...@pttk.fi
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

Tools  Labels home  Manage label layouts  Create Label layout has two
untranslatable pull-downs, a layout type one, and text justification one. The
texts for those pull-downs comes from C4/Creators/Lib.pm

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11248] Problems with translated list email sent

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #23360|0   |1
is obsolete||

--- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 23369
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23369action=edit
[SIGNED OFF] Bug 11248: Follow up - Fix template for translated list emails in
staff

- Fixes some capitalization problems
- Adds an URL filter

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11248] Problems with translated list email sent

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11248] Problems with translated list email sent

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248

--- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com ---
Katrin, Thank you the followup. It looks good now :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11248] Problems with translated list email sent

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248

--- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com ---
for*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11365] New: Label card element title texts cannot be translated

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11365

Bug ID: 11365
   Summary: Label card element title texts cannot be translated
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pasi.kalli...@pttk.fi
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

Tools  Labels home  Manage label Layouts lists the currently available
layouts. The word Layouts eg. in the Currently Available Layouts -text
cannot be translated. This also applies to Templates, Profiles and
Batches - these texts come from patroncards/manage.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11365] Label card element title texts cannot be translated

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11365

--- Comment #1 from paxed pasi.kalli...@pttk.fi ---
This also applies to the table that lists the available Layouts - the table
column headers cannot be translated, and those texts come from the same place.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11366] New: Acq basket group No group untranslatable

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11366

Bug ID: 11366
   Summary: Acq basket group No group untranslatable
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pasi.kalli...@pttk.fi
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

in Acq baskets, there's a pull-down for basket groups. One of the entries in
that pull-down is No group, which is untranslatable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #21020|0   |1
is obsolete||

--- Comment #42 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 23371
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23371action=edit
Bug 10402: Move contacts to separate table

This patch normalizes the data structures used for bookseller
contacts.

To test:
1) Repeat tests described on previous patch.

Signed-off-by: Owen Leonard oleon...@myacpl.org
Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #21019|0   |1
is obsolete||

--- Comment #41 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 23370
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23370action=edit
Bug 10402: Use an object for contacts

In preparation for adding the ability to handle multiple contacts, this
patch moves booksellers' contacts into their own class,
C4::Bookseller::Contact.

To test:
1) Apply patch.
2) Run database update.
3) Edit a bookseller, making sure to add a contact.
4) View the bookseller's information, making sure the contact
   information is there.
5) Run the unit test:
 prove t/db_dependent/Bookseller.t

Signed-off-by: Owen Leonard oleon...@myacpl.org
Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #21021|0   |1
is obsolete||

--- Comment #43 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 23372
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23372action=edit
Bug 10402: Add ability to enter multiple contacts

Some vendors may have more than one contact. For example, a technical
contact and a billing contact, or a contact for journals and a contact
for monographs. Rather than require that each contact be either made
into a separate vendor or recorded somewhere outside of Koha, it would
be really useful of Koha had the ability to add multiple additional
contacts to vendors in the Acquisitions module.

To test:
1) Apply patch.
2) Edit a bookseller, making sure to add a contact.
3) View the bookseller's information, making sure the contact
   information is there.
4) Run the unit test:
 prove t/db_dependent/Bookseller.t
5) Add multiple contacts to a vendor, see that they show up.
6) Delete one contact from a vendor with multiple contacts,
   see that the result is correct.
7) Sign off.

Note: This test plan can supersede that on the previous two patches,
as all functionality of the previous two patches is required by this
one.

Signed-off-by: Owen Leonard oleon...@myacpl.org
Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #21023|0   |1
is obsolete||

--- Comment #45 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 23374
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23374action=edit
Bug 10402 follow-up: rebase onto latest master

Because of the complexity of the rebase, I have chosen to correct
a couple merge errors in a separate patch rather than squashing the
corrections into the last patch in the patchset.

This rebase patch does one thing that may not be completely obvious:
in order to keep the existing tests matching their stated aims, it
centralizes contact-related unit testing at the end of the Bookseller.t
unit test, and removes contacts from earlier tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #21022|0   |1
is obsolete||

--- Comment #44 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 23373
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23373action=edit
Bug 10402 [Template follow-up] Add multiple contacts for vendors

This template-only follow-up tweaks the button labels and restructures
the vendor view layout a little bit to make it more amenable to multiple
contacts:

- Add spaces after button icons
- Change Add contact to Add another contact in hopes of making it
  less ambiguous whether clicking it will submit the whole form.
- Eliminate duplicate headers on the vendor view page by making the
  contact name the subheading for each individual contact.

To test, view details for vendors with one or more contacts, and try
editing to add additional contacts. Everything should look good and work
correctly.

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

--- Comment #48 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 23377
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23377action=edit
Bug 10402: correct number of tests

When merging t/db_dependent/Bookseller.t, the number of tests listed
was not changed, causing the test to fail with too many tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #21056|0   |1
is obsolete||

--- Comment #46 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 23375
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23375action=edit
Bug 10402 follow-up: fix perlcritic exception

Perlcritic doesn't like the syntax keys $variable, and requires that
you explicitly dereference a hashref to a hash before using keys.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #21804|0   |1
is obsolete||

--- Comment #47 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 23376
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23376action=edit
Bug 10402 follow-up: choose contacts for serials and acq claims

This patch makes it possible to choose a particular contact for
acquisitions and serials claims. To test:

1) Select a contact to use for claiming late orders and a contact
   to use for claiming late issues.
2) Send a claim for a late order and a claim for a late issue.
3) Note that the claims went out to the proper people.
4) Run the unit test with:
 prove t/db_dependent/Letters.t
5) Sign off.

Note: the claim messages are recorded in the logs in the *Acquisitions*
module, not the Letters module as you might expect

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567

--- Comment #19 from M. Tompsett mtomp...@hotmail.com ---
I would, except everything is so interdependent, I don't see where to break it
up right now. I suppose I could try to break the change from (parameter,
parameter, parameter,etc.) into hash ref portion out, but I didn't think to do
that early on. I'll see if I can generate some sensible break lines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #23368|0   |1
is obsolete||

--- Comment #20 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 23378
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23378action=edit
Bug 7567 - News by Branch

By selecting a particular branch, news specific to a branch
can be showed once the user logs into the opac (or the staff)
client.

This includes adding a non-NULL default '' branchcode field
to the opac_news table.

When a user is logged in they receive both '' and their branch
news. When no user is logged in, they only receive '' news. ''
means all branches.

REVISED TEST PLAN
-
 1) Do a fresh install, to ensure that branchcode is created as a field
 in the opac_news table.
 2) Do an upgrade to confirm that the branchcode field is added
 to the opac_news table.
 3) prove -v t/db_dependent/NewsChannels.t
 This should test all the changes in C4::NewsChannels functions.
 4) Log into the staff client
- Does the News display on the main page bust?
 5) Add a new dummy branch (so it has no items or borrowers)
 6) Go to Tools-News
- Are the locations properly display?
 7) Add a News item, for 'All' interfaces for 'All Branches'.
 8) Add a News item, for 'Librarian interface' interfaces for
 the dummy branch.
 9) Add a News item, for 'Slip' interfaces at your user branch.
10) Add a News item, for 'OPAC' interface at your user branch.
11) Change the Location and Branch filters.
- Do they show what you select after you click the Filter button?
  (Unpatched the Location does not!)
- Are the items displayed matching what is selected?
- Are the drop downs containing the expected values?
  (All, Librarian Interface, Slip,
and OPAC (lang -- for each lang installed)
  (All Branches, and every branch listed)
12) Click 'Edit' for one of the news items added.
- Does what comes up match what was displayed?
  ( Unpatched the Location may be 'All' )
- Are the drop downs containing the expected values?
  (All, Librarian Interface, Slip,
and OPAC (lang -- for each lang installed)
  (All Branches, and every branch listed)
- Does the submitted values match the changes made?
13) Find a patron to print a slip for. Print Slip.
- Does both the 'All' and 'Slip' news show up on the print slip?
14) In a new tab, go to OPAC
- Does the News display on the main page bust?
- Does it display the news item for a specific branch?
  (It shouldn't when patched, but unpatched it would)
  (Only one of the new things added should be displayed)
15) Log in as yourself on OPAC.
- Does that piece of News display now too?
  (Both things added should be displayed)
16) In the staff client, delete the dummy branch.
- Does the 'Librarian interface' news item exist any more?
  It shouldn't.
17) Check the news items added and click the delete button in the
 staff client.
- Did it delete them appropriately?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11367] New: Clicking letter links on paid support (alphabetical) returns you to the home page

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11367

Bug ID: 11367
   Summary: Clicking letter links on paid support (alphabetical)
returns you to the home page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: http://koha-community.org/support/paid-support/alpha/
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Websites, Mailing Lists, etc
  Assignee: wizzy...@gmail.com
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

If you sort support companies alphabetically the letter links don't take you to
that place on the page, they return you to the home page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11368] New: Add script to import Lexile scores

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

Bug ID: 11368
   Summary: Add script to import Lexile scores
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Koha needs a script to automate the importing of Lexile score data for titles
that have available scores but are not currently in the title's record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11368] Add script to import Lexile scores

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11368] Add script to import Lexile scores

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23379
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23379action=edit
Very small example Lexile CSV file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11368] Add script to import Lexile scores

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23379|Very small example Lexile   |LexileTitlesTruncated.txt
description|CSV file|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11368] Add script to import Lexile scores

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Depends on||10500

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1047] Punctuation in site names breaks Edit/Delete z39.50 server administration

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1047

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
It doesn't work if you use an 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11368] Add script to import Lexile scores

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11368] Add script to import Lexile scores

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23380
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23380action=edit
Bug 11368 - Add script to import Lexile scores

Koha needs a script to automate the importing of Lexile score data for
titles that have available scores but are not currently in the title's
record.

This script will take a CSV file of Lexile scores, and locate any
matching records in the Koha database ( by ISBN ). If the record already
has a score, it will be updated. If not, the Lexile score field will be
created.

Test Plan:
1) Apply this patch
2) Catalog a record for each of the following ISBNs:
   0789170191
   9780673779410
3) Download the file LexileTitlesTruncated.txt attached
   to this bug report
4) Run the script from the command line:
   ./misc/migraction_tools/import_lexile.pl -v --file
/path/to/LexileTitlesTruncated.txt
5) View those records in Koha
6) Note those records now have valid Lexile scores
7) Edit the Lexile score ( 521$a ) and change the value to something else
8) Repeat step 4
9) Note the original Lexile score has been restored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10500] Improve isbn matching when importing records

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks||11368

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360

--- Comment #5 from Owen Leonard oleon...@myacpl.org ---
Sorry to come late to this patch, but I want to jump in:

Is there any reason to show the input field at all if it's disabled? We are
inconsistent on the checkout page. Sometimes the input is displayed as
disabled, sometimes it is hidden. I think we should stick with hiding the input
(and the options checkboxes too in this case) if the user cannot interact
with them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11369] New: Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client.

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369

Bug ID: 11369
   Summary: Too many search cursor cookies overflow HTTP-header
size, when making multiple searches in the staff
client.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

When making a new search or navigating the search result pages,
catalogue/search.pl-browser.js generates a search cursor cookie for every page
change or search. When 30+ search/page change -actions are done, browser has
collected 30+ search cursor cookies.

This causes the HTTP-header to bloat and get rejected by apache2. User needs to
reset cookies to get rid of this issue and be able to continue using Koha.


- SOLUTION -


Name searchCookies (search cursor cookies) as scs_timestamp and remove the
3 oldest cookies if more than 15 searchCookies are present.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client.

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |olli-antti.kivila...@jns.fi
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client.

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #1 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Sponsored by the Joensuu Regional Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11112] Koha::Calendar-new loads all holidays

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #5 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Jonathan!

Note that I've pushed two follow-ups.  One just repairs breakage of the
add_holidays() method; the other adds a FIXME.

The FIXME is important: using of package-level variables for caching is not
compatible with persistence engines.  However, I'm allowing this regression on
the basis that I'll be resurrecting the patches for bug 8089.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

--- Comment #45 from Galen Charlton gmcha...@gmail.com ---
The patch for bug 2 that I pushed just now adds another instance of
caching-via-package-variables that will need to be converted to using
Koha::Cache as part of resurrecting the patch for this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11009] Do not allow reading records of anonymous patron

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Galen Charlton gmcha...@gmail.com ---
This reminds me of the old joke:

Doctor, it hurts when I do this!
Well, stop doing it then!

Anyway, pushed to master -- though I would not be entirely surprised if
somebody will end up wanting to be able to display a list of anonymized loans. 
Thanks, Fridolin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11371] New: Add a new report : Orders by budget

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Bug ID: 11371
   Summary: Add a new report : Orders by budget
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: fcapovi...@live.ca
QA Contact: testo...@bugs.koha-community.org

Created attachment 23381
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23381action=edit
Add the Orders by budget report.

This patch adds the Orders by budget report to the reports page.

This report can generate the list of all orders on a specific budget. The All
budgets and All active budgets options are also available to have different
views of all your orders.

A [i] is also added before the names of inactive budgets in the budget
selection box.

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11370] make news branch specific

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11370

Heather Braum hbr...@nekls.org changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11370] New: make news branch specific

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11370

Bug ID: 11370
   Summary: make news branch specific
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

It would be great if the news could be branch specific and show on branch
specific OPACs and branch specific slips.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11370] make news branch specific

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11370

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Blocks||11372

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11372] show only branch specific news on slips

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11372

Heather Braum hbr...@nekls.org changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11372] New: show only branch specific news on slips

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11372

Bug ID: 11372
   Summary: show only branch specific news on slips
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 11370

It would be nice if the news that shows on the slips was specific to the branch
without having to do specific slips for each branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11371] Add a new report : Orders by budget

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

Frédérick Capovilla fcapovi...@live.ca changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11371] Add a new report : Orders by budget

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

marjorie barry-vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11370] make news branch specific

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11370

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---


*** This bug has been marked as a duplicate of bug 7567 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11372] show only branch specific news on slips

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11372

Bug 11372 depends on bug 11370, which changed state.

Bug 11370 Summary: make news branch specific
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11370

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567

--- Comment #21 from Owen Leonard oleon...@myacpl.org ---
*** Bug 11370 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567

Heather Braum hbr...@nekls.org changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #1 from Chris Cormack ch...@bigballofwax.co.nz ---
Ouch sounds nasty,

So the deleted count is actually correct? IE if you look in the db, it did
actually delete that many?

And just the warning count is incorrect? 

Is it deleting ones it shouldn't?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11368] Add script to import Lexile scores

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352

--- Comment #2 from Danielle Elder danie...@bywatersolutions.com ---
Yes, it is deleting ones it shouldn't and we couldn't get any of the numbers to
show up: warning, count, or on the database. We even queried with the deletion
parameters before deletion and could not get numbers to match up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

--- Comment #12 from Christopher Brannon cbran...@cdalibrary.org ---
Kyle,
Did more testing.  A few issues:

First, this may be an issue with the sandbox.  Not sure.  I'll need to do a
fresh install with the patch.  I tested on master first, then I applied the
patch, and I received this e-mail:

The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 10904:
h1Something went wrong !/h1Applying: Bug 10904 - would like to limit patron
update request management by branch
Applying: Bug 10904 [QA Followup] - would like to limit patron update request
management by branch Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/sysprefs.sql Auto-merging
installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 10904 [QA Followup] - would like to limit patron
update request management by branch When you have resolved this problem run git
bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 10904 - would like to limit patron update request management by branch

22494 - Bug 10904 - would like to limit patron update request management by
branch
23104 - Bug 10904 [QA Followup] - would like to limit patron update request
management by branch

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-10904-QA-Followup---would-like-to-limit-patron-3o7VHx.patch .


Second issue, it looks like from your input on this ticket there should be two
preference settings: IndependentBranches and
IndependentBranchesPatronModifications.  I only see the first.

Third issue, I turned on IndependentBranches, and it works in letting the staff
see only their patron requests, but we've lost some of the other features you
had at first.  Parts 6 and 7 of your test plan fail.  This modification does
not exist.  They should be there with or without the IndependentBranches set,
and they are not there at all.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

Christopher Brannon cbran...@cdalibrary.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #13 from Christopher Brannon cbran...@cdalibrary.org ---
Kyle,
It appears that the patch gives the same error message on the sandbox setup
that I posted previously, even if I do a new database on setup.  Didn't have
anything to do with a previous master install and using No change on the
database.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360

--- Comment #6 from Christopher Brannon cbran...@cdalibrary.org ---
Owen,
Can you provide any examples of when the field is hidden?  I was unaware it did
this.  Maybe I have not been in a circumstance that it has.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11373] Add a cash register feature to the fine payment form.

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Frédérick Capovilla fcapovi...@live.ca changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Medium patch
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11373] New: Add a cash register feature to the fine payment form.

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Bug ID: 11373
   Summary: Add a cash register feature to the fine payment
form.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fcapovi...@live.ca
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 23382
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23382action=edit
Add a cash register feature to the fine payment form.

This patch improves the fines payment form to allow automatic calculation of
the amount to give back to the patron once a fine payment is received.

For example, if a patron wants to pay a 3$ fine with a 5$ bill, you can set
Amount paid to 3 and Collect from patron to 5. A message will then tell you
to give back 2$ to the patron.

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #23378|0   |1
is obsolete||

--- Comment #22 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 23383
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23383action=edit
Bug 7567 - News by Branch

By selecting a particular branch, news specific to a branch
can be showed once the user logs into the opac (or the staff)
client.

This includes adding a non-NULL default '' branchcode field
to the opac_news table.

When a user is logged in they receive both '' and their branch
news. When no user is logged in, they only receive '' news. ''
means all branches.

REVISED TEST PLAN
-
 1) Do a fresh install, to ensure that branchcode is created as a field
 in the opac_news table.
 2) Do an upgrade to confirm that the branchcode field is added
 to the opac_news table.
 3) prove -v t/db_dependent/NewsChannels.t
 This should test all the changes in C4::NewsChannels functions.
 4) Log into the staff client
- Does the News display on the main page bust?
 5) Add a new dummy branch (so it has no items or borrowers)
 6) Go to Tools-News
- Are the locations properly display?
 7) Add a News item, for 'All' interfaces for 'All Branches'.
 8) Add a News item, for 'Librarian interface' interfaces for
 the dummy branch.
 9) Add a News item, for 'Slip' interfaces at your user branch.
10) Add a News item, for 'OPAC' interface at your user branch.
11) Change the Location and Branch filters.
- Do they show what you select after you click the Filter button?
  (Unpatched the Location does not!)
- Are the items displayed matching what is selected?
- Are the drop downs containing the expected values?
  (All, Librarian Interface, Slip,
and OPAC (lang -- for each lang installed)
  (All Branches, and every branch listed)
12) Click 'Edit' for one of the news items added.
- Does what comes up match what was displayed?
  ( Unpatched the Location may be 'All' )
- Are the drop downs containing the expected values?
  (All, Librarian Interface, Slip,
and OPAC (lang -- for each lang installed)
  (All Branches, and every branch listed)
- Does the submitted values match the changes made?
13) Find a patron to print a slip for. Print Slip.
- Does both the 'All' and 'Slip' news show up on the print slip?
14) In a new tab, go to OPAC
- Does the News display on the main page bust?
- Does it display the news item for a specific branch?
  (It shouldn't when patched, but unpatched it would)
  (Only one of the new things added should be displayed)
15) Log in as yourself on OPAC.
- Does that piece of News display now too?
  (Both things added should be displayed)
16) In the staff client, delete the dummy branch.
- Does the 'Librarian interface' news item exist any more?
  It shouldn't.
17) Check the news items added and click the delete button in the
 staff client.
- Did it delete them appropriately?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #4 from sandbo...@biblibre.com sandbo...@biblibre.com ---
Patch tested with a sandbox, by Christopher Brannon cbran...@cdalibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

  Attachment #23286|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336

Christopher Brannon cbran...@cdalibrary.org changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #3 from Christopher Brannon cbran...@cdalibrary.org ---
Looks like it does what is expected.  Thanks for addressing this issue.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336

--- Comment #5 from sandbo...@biblibre.com sandbo...@biblibre.com ---
Created attachment 23384
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23384action=edit
Bug 11336: Priority is not updated on deleting holds

There are a lot of places where a hold deletion is possible. But I just found 1
place where it works!

To reproduce:
- select or create 2 users U1 and U2
- select or create an holdable item
- place on hold for both U1 and U2. U1 has priority 1 and U2 has priority 2.
- delete the hold for U1
- go on circ/circulation.pl?borrowernumber= for U2 (or in the DB directly)
and verify the priority has not been set to 1

The issue is repeatable (at least) on these 2 pages:
 * circ/circulation.pl?borrowernumber= (tab 'Holds', select yes in the
dropdown list and submit the form)
 * reserve/request.pl?biblionumber= (clic on the red cross)

The CancelReserve calls _FixPriority with a reserveid. _FixPriority try to
retrieve the reserve with this reserveid but it does not exist anymore...

Signed-off-by: Christopher Brannon cbran...@cdalibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331

Christopher Brannon cbran...@cdalibrary.org changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #2 from Christopher Brannon cbran...@cdalibrary.org ---
Can you please provide a test plan?

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11255] sort by relevance asc generates a wrong query

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #9 from sandbo...@biblibre.com sandbo...@biblibre.com ---
Patch tested with a sandbox, by Christopher Brannon cbran...@cdalibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11255] sort by relevance asc generates a wrong query

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255

--- Comment #10 from sandbo...@biblibre.com sandbo...@biblibre.com ---
Created attachment 23385
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23385action=edit
Bug 11255: allow sorting by relevance asc

The query parser config does not declare relevance asc as possible
modifier.

Test plan:
0/ create some biblio with history in the title
1/ define prefs defaultSortField = relevance and defaultSortOrder = asc
2/ search history on the staff interface
3/ note that no result is returned.
4/ apply the patch
5/ verify the queryparser config file in use takes the modification into
account (see the queryparser_config value in your $KOHA_CONF file).
6/ relaunch the search and verify results are returned

Signed-off-by: Christopher Brannon cbran...@cdalibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11255] sort by relevance asc generates a wrong query

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

  Attachment #22957|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11255] sort by relevance asc generates a wrong query

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11255

Christopher Brannon cbran...@cdalibrary.org changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #11 from Christopher Brannon cbran...@cdalibrary.org ---
The patch works as expected, according to the test plan.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Christopher Brannon cbran...@cdalibrary.org changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #20 from Christopher Brannon cbran...@cdalibrary.org ---
Kyle,
This patch seems to fix more than just the ability to place a hold on an On
Order item.  It appears that prior to the patch, one could not place a hold any
any available item if at least the first item was setup as On Order and
theAllowOnShelfHolds is set to Don't Allow.  So, it seems you fixed more than
you stated.  Good work.

Christopher

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #27 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Unfortunately this breaks the authority results display when 5xx$w is set:
http://screencast.com/t/J40kB4bJ8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #23383|0   |1
is obsolete||

--- Comment #23 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 23386
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23386action=edit
Bug 7567 - News by Branch

By selecting a particular branch, news specific to a branch
can be showed once the user logs into the opac (or the staff)
client.

This includes adding a non-NULL default '' branchcode field
to the opac_news table.

When a user is logged in they receive both '' and their branch
news. When no user is logged in, they only receive '' news. ''
means all branches.

REVISED TEST PLAN
-
 1) Do a fresh install, to ensure that branchcode is created as a field
 in the opac_news table.
 2) Do an upgrade to confirm that the branchcode field is added
 to the opac_news table.
 3) prove -v t/db_dependent/NewsChannels.t
 This should test all the changes in C4::NewsChannels functions.
 4) Log into the staff client
- Does the News display on the main page bust?
 5) Add a new dummy branch (so it has no items or borrowers)
 6) Go to Tools-News
- Are the locations properly display?
 7) Add a News item, for 'All' interfaces for 'All Branches'.
 8) Add a News item, for 'Librarian interface' interfaces for
 the dummy branch.
 9) Add a News item, for 'Slip' interfaces at your user branch.
10) Add a News item, for 'OPAC' interface at your user branch.
11) Change the Location and Branch filters.
- Do they show what you select after you click the Filter button?
  (Unpatched the Location does not!)
- Are the items displayed matching what is selected?
- Are the drop downs containing the expected values?
  (All, Librarian Interface, Slip,
and OPAC (lang -- for each lang installed)
  (All Branches, and every branch listed)
12) Click 'Edit' for one of the news items added.
- Does what comes up match what was displayed?
  ( Unpatched the Location may be 'All' )
- Are the drop downs containing the expected values?
  (All, Librarian Interface, Slip,
and OPAC (lang -- for each lang installed)
  (All Branches, and every branch listed)
- Does the submitted values match the changes made?
13) Find a patron to print a slip for. Print Slip.
- Does both the 'All' and 'Slip' news show up on the print slip?
14) In a new tab, go to OPAC
- Does the News display on the main page bust?
- Does it display the news item for a specific branch?
  (It shouldn't when patched, but unpatched it would)
  (Only one of the new things added should be displayed)
15) Log in as yourself on OPAC.
- Does that piece of News display now too?
  (Both things added should be displayed)
16) In the staff client, delete the dummy branch.
- Does the 'Librarian interface' news item exist any more?
  It shouldn't.
17) Check the news items added and click the delete button in the
 staff client.
- Did it delete them appropriately?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix

2013-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Medium patch

--- Comment #24 from M. Tompsett mtomp...@hotmail.com ---
I know it's big, and I didn't split it up, but I finally got through my test
plan and it all works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/