[Koha-bugs] [Bug 9245] Visual Bug under fines tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 --- Comment #6 from Viktor Sarge viktor.sa...@regionhalland.se --- (In reply to Christopher Brannon from comment #5) Viktor, looks like we have the same issue we had on bug 12332. Please start the commit message of your patches by Bug X. Otherwise the sandboxes cannot signoff them. Thanks. Christopher Yes I missed formatting the first line with Bug in my first five patches. Would I mess up anything if I resubmit those that are not yet signed off with a correct first line? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than any
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC||dc...@prosentient.com.au See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11291 --- Comment #39 from David Cook dc...@prosentient.com.au --- Martin, I noticed that you've only done biblios, but I believe that authorities are needed as well. Hmm, the more I look at this...the more I think that it's sub-optimal to pepper any:w and any:p throughout biblio-koha-indexdefs.xml. It might make more sense to add index_any elements to biblio-koha-indexdefs.xml and authority-koha-indexdefs.xml, and create a new template in koha-indexdefs-to-zebra.xsl to create the appropriate XSLTs as necessary. Galen, as it looks like you did a lot of work on koha-indexdefs-to-zebra.xsl, what are your thoughts on doing it that way? (As a sidebar, I think we could optimize koha-indexdefs-to-zebra.xsl a bit more in terms of how templates are applied, but also of the mind if it ain't broke, don't fix it.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11291] Change the behavior of any index in DOM indexing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11291 David Cook dc...@prosentient.com.au changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8962 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook dc...@prosentient.com.au --- I'll take a look at this one later... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12450] Closing libraries for the summer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added CC||mag...@enger.priv.no --- Comment #1 from Magnus Enger mag...@enger.priv.no --- Hi! I'm working on exactly these same things at the moment, for Oslo Public Library. Do you plan to work on this, or is it more of a wishlist? Either way I'd be happy to collaborate. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12450] Closing libraries for the summer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 Viktor Sarge viktor.sa...@regionhalland.se changed: What|Removed |Added CC||viktor.sarge@regionhalland. ||se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7843] Create RSS for OPAC news
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 --- Comment #4 from Viktor Sarge viktor.sa...@regionhalland.se --- (In reply to Owen Leonard from comment #3) (In reply to Viktor Sarge from comment #2) * The news items have no individual links since there is no graphical view of individual news items in the way that a blog would have. Is this a problem for RSS-readers? I think it could be potentially confusing. Maybe we should add an id to each news item header row and link to that as an in-page anchor? opac-main.pl#newsitem4 If we use an id that stays unique over time that would work quite well. I would however like it better if we could create a view where news article are displayed as single page items. Then we could also create a news archive where news items are migrated as the time out. * Should we add additional metadata like author, administrator, publishing dates etc? I would add publish date. We don't store author or administrator information with individual news items so we can't show anything relevant there. * I'll look into picking up publish date. I do think that the possibility of auto displaying author would be great. If you run with that thought you might even end up with auto created staff pages and a tab for Our staff you could enable. * Currently the feed will display news for all libraries + your home branch if you access it while logged in. Would only all libraries be better? Or maybe all libraries + every item for individual branches? I would assume that anyone who was looking at the RSS feed would be doing so in a feed reader outside the context of a logged-in session, so I'm not sure the home branch items are going to get seen. I don't like that the feed a logged-in user would see in their RSS reader would be different from the news they see on the site, but I'm not sure there's a better way to handle it. A feed for all libraries might be inappropriate or simply too much data. One option might be to offer the user a choice? - All libraries news plus the user's library - All libraries news plus news for all libraries I don't know how savvy users are with multiple RSS feeds. * This is a bit of a problem. The quickest solution might be to only display news that is for all libraries. But I think the actual problem is that you have to log in to see news that should be public from the start. If we use the news to customize the opac to be used as websites for all the different branches then there should be a public way to navigate between branches. My suggestion would be to only display all libraries in the RSS if we want to push this functionality quick. Would looking (and searching) another branch than the home branch you have on your account mess with anything? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Yohann Dufour yohann.duf...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 --- Comment #1 from Yohann Dufour yohann.duf...@biblibre.com --- Created attachment 28973 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28973action=edit Bug 12445: Improving unit tests for C4::Suggestions.pm Now, the tests used 'is' instead of 'ok', the tests are wrapped in a transaction, adding tests for the routines NewSuggestion, GetSuggestion, ModSuggestion, GetSuggestionFromBiblionumber and GetInfoFromBiblionumber. The tests for the routines DelSuggestionsOlderThan, CountSuggestion, ConnectSuggestionAndBiblio, SearchSuggestion, GetSuggestionInfo, DelSuggestion and GetSuggestionByStatus will be arrived in another patch. Test plan: 1/ Execute the command : prove t/db_dependent/Suggestions.t 2/ The result has to be a success without warning or error : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=32, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.49 cusr 0.08 csys = 1.61 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5342] Serial claiming improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Jacek Ablewicz a...@biblos.pk.edu.pl changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #22727|0 |1 is obsolete|| --- Comment #59 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 28974 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28974action=edit Bug 8296: Add descriptive (text) published date field for serials Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #22728|0 |1 is obsolete|| --- Comment #60 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 28975 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28975action=edit Bug 8296: set input maxlength to the same of sql field length Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #22729|0 |1 is obsolete|| --- Comment #61 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 28976 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28976action=edit Bug 8296: Follow up for QA Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #22730|0 |1 is obsolete|| --- Comment #62 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 28977 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28977action=edit Bug 8296: Don't fill text field automatically Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26072|0 |1 is obsolete|| --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28978 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28978action=edit Bug 11395: DB: Add permission tools_records_batchmod -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Chris Cormack from comment #4) Do we care about that? Or do we only care that it passes on an empty (or near empty) database? Hi Chris, I recommend to Yohann to execute the unit tests with the DB generated by the patch on bug 10337. I have been doing this for 1 year now. All db_dependent tests pass using this DB (except the 3 broken currently). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12451] New: circulation rule cant be edited if itemtype contains a space character
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12451 Bug ID: 12451 Summary: circulation rule cant be edited if itemtype contains a space character Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When an itemtype description contains a space character like Book (often used to set this itemtype as first in sorted lists), the edition of an existing circulation rule does not work, it selects the default itemtype. Same for patron category. It's because the JavaScript code performs a trim on value existing in table itm = itm.replace(/^\s*|\s*$/g,''); The same trim must be performed on combobox in editing line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12451] circulation rule cant be edited if itemtype contains a space character
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12451 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added URL||cgi-bin/koha/admin/smart-ru ||les.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12415] Fee receipt: description of charges is empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12415 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Nicole C. Engard from comment #3) I tested this and what I got is in the attached images. I see a description on the account tab, but when I go to print I see payment thanks 2 times - without the patch I see payment thanks 1 time - but I never see the full description that I see on the accounts tab. Hi Nicole, This means you have Payment,Thanks in one or more accountlines.description fields. The updatedb entry of bug 2546 should have removed them. Did you get error on updating your DB? Are you sure this updatedb entry have been executed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12451] circulation rule cant be edited if itemtype contains a space character
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12451 --- Comment #1 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Created attachment 28979 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28979action=edit Bug 12451 - circulation rule cant be edited if itemtype contains a space character When an itemtype description contains a space character like Book (often used to set this itemtype as first in sorted lists), the edition of an existing circulation rule does not work, it selects the default itemtype. Same for patron category. It's because the JavaScript code performs a trim on value existing in table itm = itm.replace(/^\s*|\s*$/g,''); This patch adds trim on select options in editing line. Test plan : - Create an itemtype with a leading or trailling space in description : ie Book - Go to cgi-bin/koha/admin/smart-rules.pl - Create a rule with this itemtype, Unit=hours and Hard due date=Exactly on 31/12/2015 (any date) - Click on Edit on this rule line = Without this patch, the default itemtype is selected in edition line = With this patch, the correct itemtype is selected in edition line Check others selects are ok : - Create a rule with Unit=hours and Hard due date=Exactly on 31/12/2015 (any date) - Click on Edit on this rule line = The correct options are selected Same tests with a patron category containing a leading or trailling space in description -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12451] circulation rule cant be edited if itemtype contains a space character
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12451 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added CC||k...@univ-lyon3.fr --- Comment #3 from Koha Team Lyon 3 k...@univ-lyon3.fr --- We didn't understand the bug to be fixed, we could not manage to see the bug on the master version in english, we give up. The bug should be explained with more details. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #7 from Viktor Sarge viktor.sa...@regionhalland.se --- (In reply to Nicole C. Engard from comment #6) I'd say just have the RSS icon to the left of the search terms without a header row. The icon is pretty clear on it's own. But I signed off cause it got the functionality in there and figured a follow up could make it pretty. To the left of the search sounds good. It's an easy fix but what's the workflow for fixing that? Should I submit a new patch to this thread even though it's signed off? Or do I have to wait until the patch is pushed to master until I can pick it up and change it? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5956] Highlight holds on check-in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5956 --- Comment #4 from Viktor Sarge viktor.sa...@regionhalland.se --- Please note - I see that I omitted Bug as the first word of the commit. That will make it impossible to sign of on the bug from the sandboxes. I'm not yet clear on how to resubmit a patch correctly but will be careful to write correctly formated commits in the future. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Koha Team Lyon 3 from comment #3) We didn't understand the bug to be fixed, we could not manage to see the bug on the master version in english, we give up. The bug should be explained with more details. See with Lyon 3, the item-level_itypes pref should be set to item specific. They use biblio record, so they won't test this patch. But no regression found for biblio level :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Viktor Sarge from comment #7) To the left of the search sounds good. It's an easy fix but what's the workflow for fixing that? Should I submit a new patch to this thread even though it's signed off? Or do I have to wait until the patch is pushed to master until I can pick it up and change it? You can submit a follow-up on this bug report and switch the status back to Needs Signoff. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12304] Creating a user via LDAP doesn't populate message preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12304 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12304] Creating a user via LDAP doesn't populate message preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12304 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #28855|0 |1 is obsolete|| --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 28980 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28980action=edit BUG 12304: LDAP auto-provisioning set default messaging preferences LDAP auto-provisioning should set default messaging preferences upon creation of a user. Signed-off-by: Ulrich Kleiber ulrich.klei...@bsz-bw.de Manually applied to 3.12.9 and it works beautifully in test and production. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12411] Encoding broken in the syspref template plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Without this patch, I filled NoLoginInstructions with Hello éàç. Go on opac-user.pl and I see Hello ��� Template 'en' and bootstrap theme. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9245] Visual Bug under fines tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9245] Visual Bug under fines tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28874|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28981 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28981action=edit 9245 Fixes visual bux with fines tab not highlighting This patch makes shure that mancredit.pl, maninvoice.pl and pay.pl passes the value finesview=1 that makes the tab active. Test plan: 1) Go to a library user and the fines tab. Note that the Fines tab loses it's highlight when you click Pay fines, Create manual invoice and Create manual credit. 2) Install the patch. 3) Redo the first step and make shure that the left menu tab Fines is now highlighted all the time. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9245] Visual Bug under fines tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- I developed exactly the same fix yesterday on bug 12447. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12447] Fines tabs do not show selected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12447 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- *** This bug has been marked as a duplicate of bug 9245 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #9 from Viktor Sarge viktor.sa...@regionhalland.se --- You can submit a follow-up on this bug report and switch the status back to Needs Signoff. Seems I have messed something up with my git. It won't add the file again since it thinks nothing is changed. Working on it since it RSS icons to the left of the search instead looks quite a bit better. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9245] Visual Bug under fines tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- *** Bug 12447 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11650] multiplicated authorities after link_bibs_to_authorities.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11650 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #24947|0 |1 is obsolete|| --- Comment #3 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 28982 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28982action=edit Bug 11650: multiplicated authorities after link_bibs_to_authorities.pl Under certain circumstances misc/link_bibs_to_authorities.pl creates multiple authority with identical heading. Test plan: 1. Have some (2-3) biblio records with some repeated headings Have BiblioAddsAuthorities = allow, AutoCreateAuthorities = generate Have no authority records 2. Run misc/link_bibs_to_authorities.pl script 3. You will get multiple authority records -- one for each occurence of a heading in biblio record. 4. Apply the patch. 5. Repeat 1-3 (remember to have fresh biblios, without $9, and no authorities). 6. The problem should be fixed. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11650] multiplicated authorities after link_bibs_to_authorities.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11650 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9245] Visual Bug under fines tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Small patch Version|3.8 |master Assignee|koha-b...@lists.koha-commun |viktor.sarge@regionhalland. |ity.org |se QA Contact||jonathan.dru...@biblibre.co ||m Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12323] Acquisitions search results fixed in order of biblionumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12323 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28525|0 |1 is obsolete|| CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #10 from Viktor Sarge viktor.sa...@regionhalland.se --- Created attachment 28983 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28983action=edit Bug 5672 Gives RSS icons to search history placed to the left of saved searches Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Viktor Sarge viktor.sa...@regionhalland.se changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #28905|0 |1 is obsolete|| --- Comment #11 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 28984 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28984action=edit 5672 Gives RSS icons to search history This patch adds an extra column to the table for the search history (this session and previous searches) with RSS icons for each search. Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #28983|0 |1 is obsolete|| --- Comment #12 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 28985 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28985action=edit Bug 5672 Gives RSS icons to search history placed to the left of saved searches Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@univ-lyon3.fr --- Comment #43 from Koha Team Lyon 3 k...@univ-lyon3.fr --- This patch works well : adds 2 new sysprefs: OpacAdvSearchOptions and OpacAdvSearchMoreOptions. There is just one thing to remember when configuring the advance search options : When you fill OpacAdvSearchOptions with Item types and Languages (for example)you should fill also OpacAdvSearchMoreOptions with the same options : Item types, Languages, otherwise, when you click on more options, you get fiewer options (the options filled in OpacAdvSearchOptions are not showed)which is quite surprising, it's a logical mistake in configuring the advance search options : more options must be filled with at least the options filled in the default options. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #26589|0 |1 is obsolete|| --- Comment #5 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 28986 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28986action=edit Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
Attachment #28857|0 |1
is obsolete||
--- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 28987
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28987action=edit
Bug 11575 - OPACBaseURL sometimes set by ENV variable and not system preference
This patch changes how the OPACBaseURL parameter gets set in the subroutine
get_template_and_user in Auth.pm.
Currently, it's being set by the $ENV{'SERVER_NAME'} variable. In many
cases, this will probably match the URL that the user uses to access a
page. However, this causes problems with reverse proxies.
There are ways to compensate for proxy servers (such as inspecting
other variables set by the web server), but such a solution seems
a bit convoluted...especially since we already use the system preference
OPACBaseURL in many other parts of Koha.
We probably shouldn't be passing OPACBaseURL from Auth.pm at all, and
instead use the Koha TT plugin and using_https param to determine
protocol. However, that's outside the scope of this bug/patch.
This patch is just meant to fix an existing bug.
I did leave the $ENV{'SERVER_NAME'} as a full back if OPACBaseURL isn't
set, but that's it.
_TEST PLAN_
Before applying:
1) Clear your OPACBaseURL preference
2) Perform a search in the OPAC
3) Click on or hover over the orange RSS icon
4) Note that the URL used for the RSS links is either:
a) The same URL you used to access Koha (no reverse proxy)
b) The ServerName from your Koha apache conf which isn't the
same URL you used to access Koha (reverse proxy)
5) Add an OPACBaseURL that isn't the same as the actual OPAC URL
6) Note that the OPACBaseURL system preference has no effect here
After applying the patch:
7) Refresh the page
8) Note that the URL you see now is actually the OPACBaseURL system
preference that you set
9) Clear your OPACBaseURL system preference
10) Refresh your search page
11) Note that the URL has reverted back to the URL that you saw before
(either the original Koha site URL or the Koha ServerName defined
in Apache and not the URL of the proxy)
Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11319] Marc modification templates improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25751|0 |1 is obsolete|| Attachment #25752|0 |1 is obsolete|| Attachment #25753|0 |1 is obsolete|| Attachment #25754|0 |1 is obsolete|| Attachment #25755|0 |1 is obsolete|| --- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28988 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28988action=edit Bug 11319: Koha::SimpleMARC should take a hashref for parameters In order to avoid a long list of parameters, it should be better to pass all of them into a hashref. This patch does not add or modify a behavior. Test plan: Verify the unit tests still pass - prove t/SimpleMARC.t - prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11319] Marc modification templates improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28989 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28989action=edit Bug 11319: Add UT for the fields management -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11319] Marc modification templates improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28992 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28992action=edit Bug 11319: Template modifications This patch add template modifications for the restrictions: - the source field is always mandatory - on move and copy, the source and destination subfield should be both filled or blank. - on move and copy, the destination subfield should be filled. - on update, the subfield value should be filled. Test plan: Verify you are not able to create/modify template actions according to these restrictions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11319] Marc modification templates improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28990 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28990action=edit Bug 11319: Add the field management for Koha::SimpleMARC Currently the Koha::SimpleMARC module call a field a subfield. And the way to manage field is not implemented for all routines. This patch does not modify the API. The routine's names are kept. It just creates 2 privates routines for each action (e.g. delete_field will call _delete_field if the action affects field and _delete_subfield if the action affects subfields). Before this patch the move action was authorised by the interface but caused an error if executed. Note: I don't see the meaning for the add/update action if no subfield is given. So the call without subfield raises an error. Test plan: - apply all patches - create or modify an existent template - try at least the correct behavior for the following actions: * delete subfield and field * add new subfield to an existing field * add new subfield to an nonexisting field * move a subfield * move an entire field * copy a subfield * copy an entire field - import a biblio and use this template - verify the imported biblio matches actions defined. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11319] Marc modification templates improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com --- Last patch set fixes silly error introduced by previous rebase (c/p error). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11319] Marc modification templates improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28991 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28991action=edit Bug 11319: Add specific UT for nonexistent field/subfield This patch only adds unit tests for the copy and move actions. They test if the action does not create a field/subfield if the source did not exist. Also it adds a unit tests for the existing behavior (in order not to lost it): we can use the '^' and the '$' character in regex for substituing. For example: Copy 245$a to 245$a with the regex s/^/BEGIN / This will add the string BEGIN at the beginning of the 245$a fields. To test: prove t/SimpleMARC.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25759|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28994 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28994action=edit Bug 11413: UT to show up the issue These UT reflect this change: - deletion of the field 245 if 245$a='Bad title' - move of the 650 field to 651 if 650$9=499 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25760|0 |1 is obsolete|| --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28995 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28995action=edit Bug 11413: Reflect the changes to the interface Test plan: - add/edit an action on the marc modification templates tools - choose an action and define a condition - define the source field as same as the condition field - verify the All/1st dropdown list is changed to Every/1st -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25758|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28993 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28993action=edit Bug 11413: Change the field number logic This patch series is a bugfix for the Marc modification templates tool. Bug description: If you want to do an action (delete/update/move/...) on a multivalued field and if a condition is defined on the same field, it is highly probable the resulted record will not be what you expect. For example: Deleting All (or the first) fields 650 if 245$a=Bad title works with the current code. BUT if you want to delete All (or the first) fields 650 with a condition on 650$9=42, and if at least one field matches the condition : - if you have selected all, all fields 650 will be deleted, even the ones who do not match the condition. - if you have selected first, the first 650 field will be deleted, even if it does not match the condition. The expected behavior is to delete the fields matching the condition (and not all the 650 fields). What this patch does: This patch introduces 2 changes in the logic of Koha::SimpleMARC. The first change is a change of the prototypes for the 2 routines field_exists and field_equals. Now they return the field number of the matching fields. The second change is the type of the n parameter for all routines using it in Koha::SimpleMARC. Before this patch, the n parameter was a boolean in most cases. If 0, the action was done on all fields, if 1 on the first one only. Now it is possible to specify the field numbers (so the array of field numbers which is returned by field_exists or field_equals) for all routines which had the n parameter. Test plan for the patch series: Note: This test plan describes a specific example, feel free to create your own one. 0/ Define a marc modification template with the following action: Delete field 245 if 245$9 = 42 1/ choose and export a record with several 245 fields. For ex: 245 $a The art of computer programming $c Donald E. Knuth. $9 41 245 $a Bad title $c Bad author $9 42 2/ import it using the Stage MARC for import tool. 3/ verify the imported record does not contain any 245 field. 4/ apply all the patches from this bug report 5/ do again steps 2 and 3 6/ verify the imported record contains only one 245 field, the one with 245$9=41 7/ verify the unit tests passed: prove t/SimpleMARC.t prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28993|0 |1 is obsolete|| --- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28996 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28996action=edit Bug 11413: Change the field number logic This patch series is a bugfix for the Marc modification templates tool. Bug description: If you want to do an action (delete/update/move/...) on a multivalued field and if a condition is defined on the same field, it is highly probable the resulted record will not be what you expect. For example: Deleting All (or the first) fields 650 if 245$a=Bad title works with the current code. BUT if you want to delete All (or the first) fields 650 with a condition on 650$9=42, and if at least one field matches the condition : - if you have selected all, all fields 650 will be deleted, even the ones who do not match the condition. - if you have selected first, the first 650 field will be deleted, even if it does not match the condition. The expected behavior is to delete the fields matching the condition (and not all the 650 fields). What this patch does: This patch introduces 2 changes in the logic of Koha::SimpleMARC. The first change is a change of the prototypes for the 2 routines field_exists and field_equals. Now they return the field number of the matching fields. The second change is the type of the n parameter for all routines using it in Koha::SimpleMARC. Before this patch, the n parameter was a boolean in most cases. If 0, the action was done on all fields, if 1 on the first one only. Now it is possible to specify the field numbers (so the array of field numbers which is returned by field_exists or field_equals) for all routines which had the n parameter. Test plan for the patch series: Note: This test plan describes a specific example, feel free to create your own one. 0/ Define a marc modification template with the following action: Delete field 245 if 245$9 = 42 1/ choose and export a record with several 245 fields. For ex: 245 $a The art of computer programming $c Donald E. Knuth. $9 41 245 $a Bad title $c Bad author $9 42 2/ import it using the Stage MARC for import tool. 3/ verify the imported record does not contain any 245 field. 4/ apply all the patches from this bug report 5/ do again steps 2 and 3 6/ verify the imported record contains only one 245 field, the one with 245$9=41 7/ verify the unit tests passed: prove t/SimpleMARC.t prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28994|0 |1 is obsolete|| --- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28997 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28997action=edit Bug 11413: UT to show up the issue These UT reflect this change: - deletion of the field 245 if 245$a='Bad title' - move of the 650 field to 651 if 650$9=499 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28995|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28998 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28998action=edit Bug 11413: Reflect the changes to the interface Test plan: - add/edit an action on the marc modification templates tools - choose an action and define a condition - define the source field as same as the condition field - verify the All/1st dropdown list is changed to Every/1st -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23502|0 |1 is obsolete|| --- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 28999 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28999action=edit Bug 11395: Add a batch record modification This patch offers a new tool to modify records in a batch. This feature adds: - a new pl/tt files tools/batch_record_modification - a new permission: tools records_batchmod Test plan for biblios: 0/ Create a new marc modification template with some actions. 1/ Generate a list of biblionumbers you want to modify. There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the Action button Modify - generating a list from a report 2/ On the Batch record modification tool verify: - information is correct. - the preview link show you the needed record. 3/ After clicking on the Modify selected recors button, verify the records have been modified as you wanted. Test plan for authority: 0/ Create a new marc modification template with some actions. 1/ Generate a list of authid using a report: 2/ On the Batch record modification tool verify: - authorities are display with the summary. - the preview link show you the needed record. 3/ After clicking on the Modify selected recors button, verify the records have been modified as you wanted. Catch of errors: if an error occurs during the modification process, the tool displays an error message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23503|0 |1 is obsolete|| --- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 29000 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29000action=edit Bug 11395: Add links to the new tool page This patch adds links in the tool module to the new batch tool and in the basket. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23504|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 29001 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29001action=edit Bug 11395: Fix return for ModifyRecordWithTemplate Make sure the ModifyRecordWithTemplate routine returns undef. This patch also removes a warning if GetModificationTemplates is called without parameter. Verify prove t/db_dependent/MarcModificationTemplates.t returns green. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28978|0 |1 is obsolete|| --- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 29004 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29004action=edit Bug 11395: DB: Add permission tools_records_batchmod -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26981|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 29003 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29003action=edit Bug 11395: The modification template should be changed on the list view This patch fixes the following issue: If the user comes from a basket, the list view is displayed but there is no way to select the modification template. Now the template can be chosen on the list view. This way, the user is able to change the modifications to apply and see the previewed records. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23506|0 |1 is obsolete|| --- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 29002 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29002action=edit Bug 11395: New service to preview a record. The main patch adds the ability to preview a record. This is done using an AJAX way. The preview record is processed on the server side. Note: I don't think an authentification check is necessary here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||11395 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Depends on||11413 --- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com --- I added the dependency on bug 11413 since this enhancement is dangerous without fixing the current issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #46 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 29007 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29007action=edit Bug 9043: Changes to the advanced search page This patch adds 2 new sysprefs: OpacAdvSearchOptions and OpacAdvSearchMoreOptions. These sysprefs are multivalued and you can add or remove some elements on the adv search page. This patch allows to display/hide some entries in the advanced search page at the OPAC. On this way, it is possible to configure the search options to display. Test plan: 1/ Fill OpacAdvSearchOptions with Item types and Languages. Fill OpacAdvSearchMoreOptions with Item types, Languages and Location. On the advanced search page, verify the Location is only displayed for the More options view. 2/ Try different settings for these prefs 3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that the More options does not displayed additional options. 4/ Remove all entries for the OpacAdvSearchOptions and verify that the normal view does not displayed any options. Note that this patch only affects the bootstrap theme. Signed-off-by: Koha Team Lyon 3 k...@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11291] Change the behavior of any index in DOM indexing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11291 --- Comment #5 from mathieu saby mathsaby...@gmail.com --- Hello Martin and David as I am no longer involved in Koha development, except for a few bugs I am still watching, I won't work anymore on this bug, or bug 8962. But I hope you will find a solution for improving Koha's indexing, which is not perfect ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Looking quickly at this patch, the only dependencies are +categorycode = 'S', +branchcode = 'CPL', This is the case for almost ALL db dependent unit tests. Some tests are very painful to write (for instance, try to write a unit tests in the ACQ module...). It is good not to have to add all data before starting to test something. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- However, I think this discussion should have done on bug 10337 (in discussion for 1 year ago). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427 --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- You are right, that this is not the right place for a general discussion. I was referring to this comment from Chris: Fails on a non empty db, (ie if you have any borrowers who have attributes in the database Maybe it would be enough then to add another delete line to make sure there are no other borrowers with patron attributes? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28921|0 |1 is obsolete|| Attachment #28922|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 29008 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29008action=edit Bug 12427: adding unit tests of module C4::Members::Attributes.pm The subroutines UpdateBorrowerAttribute, SearchIdMatchingAttribute, DeleteBorrowerAttribute, GetBorrowerAttributes, GetAttributes, GetBorrowerAttributeValue, SetBorrowerAttributes and CheckUniqueness of the module C4::Members::Attributes.pm were not tested. Test plan: 1/ Execute the command: prove t/db_dependent/Members_Attributes.t 2/ The result has to be: t/db_dependent/Members_Attributes.t .. ok All tests successful. Files=1, Tests=60, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.45 cusr 0.08 csys = 1.58 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427 --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 29009 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29009action=edit Bug 12427: Allow execution of UTs on a DB with issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #9) Maybe it would be enough then to add another delete line to make sure there are no other borrowers with patron attributes? Agreed, the deletion failed if the DB contains issues. I squashed the 2 first patches and added a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Biblio search history should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Summary|Search History Should have |Biblio search history |RSS Feeds |should have RSS Feeds -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Catalog search history should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Summary|Biblio search history |Catalog search history |should have RSS Feeds |should have RSS Feeds -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Catalog search history should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28984|0 |1 is obsolete|| Attachment #28985|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 29010 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29010action=edit Bug 5672 Gives RSS icons to catalog search history This patch adds an extra column to the table for the search history (this session and previous searches) with RSS icons for each search. Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Catalog search history should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 29011 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29011action=edit Bug 5672 Gives RSS icons to catalog search history placed to the left of saved searches Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Catalog search history should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5672] Catalog search history should have RSS Feeds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672 --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- I updated bug report summary and commit message to highlight that the patches only affect catalog search history (not authority). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 643] Allow override of 'debarred' status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Bug 10863 introduced the lift_restriction permission. I think this button/action should be only displayed/possible if the librarian has this permission. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12377] Add date pickers to serials-edit.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Kyle, can I get an answer please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12452] New: check susbscription expiration doesn't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12452 Bug ID: 12452 Summary: check susbscription expiration doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: k...@univ-lyon3.fr QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com May be I missed something but it's impossible to get any results in the subscriptions check expiration page even if there are expired subscriptions in the database. Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11357] biblio.size value not correctly displayed in list emails sent from OPAC and intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11357 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10466 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11357] biblio.size value not correctly displayed in list emails sent from OPAC and intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11357 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m Assignee|oleon...@myacpl.org |fridolyn.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10466] Lists: Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10466 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11357 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11357] biblio.size value not correctly displayed in list emails sent from OPAC and intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11357 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=6374 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6374] Use size as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11357 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added CC||k...@univ-lyon3.fr --- Comment #11 from Koha Team Lyon 3 k...@univ-lyon3.fr --- difficult to test this patch before solving bug 12452 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 simith.dolive...@inlibro.com changed: What|Removed |Added CC||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 simith.dolive...@inlibro.com changed: What|Removed |Added CC||simith.dolive...@inlibro.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11357] biblio.size value not correctly displayed in list emails sent from OPAC and intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11357 --- Comment #2 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Has said in Bug 10466 and Bug 6374 the size is a virtual method of TT. When biblio.size is not defined, [% BIBLIO_RESULT.size %] will return the number of keys : http://template-toolkit.org/docs/manual/VMethods.html#section_Hash_Virtual_Methods There I think a better way of correcting than setting size in perl : using item virtual method in TT : http://template-toolkit.org/docs/manual/VMethods.html#section_item I found this solution here : http://stackoverflow.com/questions/2311303/how-can-i-handle-hash-keys-containing-illegal-identifier-characters-in-template This may append for other cases, like keys with space, hyphen, other colmns named like virtual method. (I've been on this several months). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
