[Koha-bugs] [Bug 13691] Add some selenium scripts

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35798
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35798action=edit
Bug 13691: Remove existing selenium scripts

They are not usable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13691] Add some selenium scripts

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
This is a POC, feedback welcome :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13690] 3.18 performance issues

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35796
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35796action=edit
Bug 13690: use Koha::Schema only when it's needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13657] Don't show extra comma after guarantor name on patron details

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657

--- Comment #2 from Marc Véron ve...@veron.ch ---
Created attachment 35805
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35805action=edit
[ALTERNATIVE PATCH] Bug 13657 - Don't show extra comma after guarantor name on
patron details

This patch suppresses the first name part (including comma) if first name is
empty. This way, first name is still displays with natural persons, but not
with organizations.

To test:
Apply this patch (without the first patch).
Have one patron with a natural person as guarantor and one patron with an
organization as guarantor. Verify that both display properly on the patron
details page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13688] New: Hiding subfields in edit item form leaves empty space

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13688

Bug ID: 13688
   Summary: Hiding subfields in edit item form leaves empty
space
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

When hiding a lot of subfields in the edit item form you might be left with big
white gaps between the fields.

To test:
- Hide every 952 between 3 and i (or later)
- Look at the item edit form and see that there is a visible gap between 3 and
i

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13645] DBIx connection needs to be cached

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13690

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13691] Add some selenium scripts

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13689] Remove opac-old.css and sco-old.css

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13692] series link is taking you to just 800a instead of whole 800

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13692

--- Comment #1 from Nicole C. Engard neng...@gmail.com ---
Created attachment 35800
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35800action=edit
series in marc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #35709|0   |1
is obsolete||

--- Comment #23 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35801
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35801action=edit
Bug 7957: Routing lists enhancements

- Manage several routing list per subscription
- Export a routing list as CSV

Test plan:

Run the updatedatabase.pl script
Existing routing lists should have been imported in a routing list named
'import'

From the serials-home.pl page:
  1 Make a search, in the results list you have a column 'Routing lists'
(if not, consider setting RoutingSerials syspref). If the
subscription doesn't have a routing list, you should have a 'New'
link. Otherwise you have an 'Edit(X)' link, where X is the number of
routing lists.
  2 Choose a subscription which have no routing lists and click on 'New'
  3 You are on the routing list creation page. Enter a title for the
routing list and click on 'Save'.
  4 The routing list has been created and now you are on the routing
list modification page. The behaviour of this page is quite the same
as before. A sensible change is that reordering borrowers doesn't
reload the page each time you make a change.
  5 Click on 'Save' to finish routing list modifications.
  6 Now you are on the routing lists management page. You can edit a
routing list by clicking on its title, preview it, export it, and
delete it by clicking on the corresponding link.
  7 Click on 'Preview'.
  8 You will be asked to choose a serial. Pick the one you want to print
the routing list for and click on 'Continue'.
  9 If RoutingListAddReserves is OFF, the routing list is displayed and
you just have to click on 'Print'. If the syspref is ON, you will
have to click on 'Confirm and print', an alert will show telling you
that holds will be placed on the serial you chose. Click 'OK' and
you will be able to print the slip. Now check if the holds have been
placed. (It works only if an item is attached to this serial).
 10 Go back to the routing lists management page (routinglists.pl) and
click on 'Export'. Download the CSV and check that it contains
correct data.

From serials-collection.pl page:
 11 In the serials list, click on 'Print list'.
 12 You will be asked to choose a routing list. Pick one and click on
'Continue'.
 13 ... (same behaviour as above)

Try to add and delete routing lists to show if links are correctly
updated in serials-home.pl, serials-collection.pl and
subscription-detail.pl

(rebased and test plan updated)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13689] Remove opac-old.css and sco-old.css

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13545] Add barcode image generator service

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||tomasco...@gmail.com

--- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com ---
I'm failing this one, even though I attached a followup so the author checks
both the followup and the POD I added.

It should be clear which barcode 'types' we support, and they should be added
to the dependencies if needed. For instance, I'm not sure we might add
GD::Barcode to the dependencies.

I tried with GD::Barcode:::QRcode and GD::Barcode::UPCE, and it works fine.

I tested using an empty barcode number to generate an error.

Please revisit and sign if it is ok, but at least the POD should be ammended.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13689] Remove opac-old.css and sco-old.css

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689

--- Comment #1 from Marc Véron ve...@veron.ch ---
Created attachment 35795
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35795action=edit
Bug 13689 - Remove opac-old.css and sco-old.css

The following files are obsolete and should be removed:
koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css
koha-tmpl/opac-tmpl/bootstrap/css/sco-old.css

To test: Apply patch. Search for the files; they should no longer exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13691] New: Add some selenium scripts

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691

Bug ID: 13691
   Summary: Add some selenium scripts
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: jonathan.dru...@biblibre.com
QA Contact: gmcha...@gmail.com

To catch performance regressions it would be great to have some selenium
scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13691] Add some selenium scripts

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35797
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35797action=edit
Bug 13691: Add basic selenium script

This script has been used to compare 3.16.x and 3.18.x performances on
bug 13690.

What it does:
- Go on the mainpage and process a log in
- Create a patron category
- Create a patron
- Add 3 items
- check the 3 items out to the patron
- check the 3 items in

How to use it?

$ wget
http://selenium-release.storage.googleapis.com/2.44/selenium-server-standalone-2.44.0.jar

$ vim /etc/apt/sources.list.d/firefox.list
  deb http://packages.linuxmint.com debian import
$ apt-get update
$ apt-get install firefox
$ sudo apt-get install xvfb

$ SELENIUM_PATH=/home/koha/tools/selenium-server-standalone-2.44.0.jar
$ Xvfb :1 -screen 0 1024x768x24 21 /dev/null 
$ DISPLAY=:1 java -jar $SELENIUM_PATH

perl t/db_dependent/selenium/basic_workflow.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13545] Add barcode image generator service

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

--- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 35806
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35806action=edit
Bug 13545: (followup) POD and error handling

This patch adds POD to the new /svc/barcode service, and also implements some
error handling.

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13685] Sorting Patron Reading History

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Does this bug refer to /cgi-bin/koha/opac-readingrecord.pl? That page can
already sort by title. Do you mean sorting by title and author together?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #35470|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612

--- Comment #5 from Marc Véron ve...@veron.ch ---
Created attachment 35793
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35793action=edit
[Signed-off] Bug 13612 - Remove old YUI javacript libraries from opac-tmpl

YUI files were left behind in opac-tmpl/lib/yui after the removal of the
prog theme. These files are unused and can be safely removed.

To test, apply the patch and search for references to any of the YUI
files. You should find none in the OPAC templates.

No references found.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13688] Hiding subfields in edit item form leaves empty space

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13688

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 35794
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35794action=edit
screenshot

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #22 from Paola Rossi paola.ro...@cineca.it ---
Thanks, Julian.

I've applied the patch against master 3.19.00.010 head 13675.

On /cgi-bin/koha/serials/subscription-detail.pl I've selected the
Create routing list [/ Edit routing list]
at the left of the page.
I've received the Create routing list [/ Routing list for ] page.

In both the 2 cases, then I've selected :
Serial collection at the left of this page.
I saw:

h1Software error:/h1
preUndefined subroutine amp;main::check_routing called at
/[]/serials/serials-collection.pl line 132.
/pre

So I pass the patch to Failed QA status.


NB-1) The patch needed a trivial rebase.

NB-2) Step 1:
Make a search, in the results list you have a column 'Routing lists'
(if not, consider setting RoutingSerials syspref). If the
subscription doesn't have a routing list, you should have a 'New'
link. Otherwise you have an 'Edit(X)' link, where X is the number of
routing lists.

RoutingSerials Use/Don't use is OK as required.
But at present the column is an Actions.
Could you update the test plan please?
[A numbered indentation would be very helpful to me in this long test plan.]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #35801|0   |1
is obsolete||

--- Comment #25 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35803
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35803action=edit
Bug 7957: Routing lists enhancements

- Manage several routing list per subscription
- Export a routing list as CSV

Test plan:

Run the updatedatabase.pl script
Existing routing lists should have been imported in a routing list named
'import'

From the serials-home.pl page:
  1 Make a search, in the results list you have a column 'Actions' that
should contain a New/Edit routing list link (if not, consider
setting RoutingSerials syspref). If the subscription doesn't have a
routing list, you should have a 'New routing list' link. Otherwise
you have an 'Edit routing lists (X)' link, where X is the number of
routing lists.
  2 Choose a subscription which have no routing lists and click on 'New
routing list'
  3 You are on the routing list creation page. Enter a title for the
routing list and click on 'Save'.
  4 The routing list has been created and now you are on the routing
list modification page. The behaviour of this page is quite the same
as before. A sensible change is that reordering borrowers doesn't
reload the page each time you make a change.
  5 Click on 'Save' to finish routing list modifications.
  6 Now you are on the routing lists management page. You can edit a
routing list by clicking on its title, preview it, export it, and
delete it by clicking on the corresponding link.
  7 Click on 'Preview'.
  8 You will be asked to choose a serial. Pick the one you want to print
the routing list for and click on 'Continue'.
  9 If RoutingListAddReserves is OFF, the routing list is displayed and
you just have to click on 'Print'. If the syspref is ON, you will
have to click on 'Confirm and print', an alert will show telling you
that holds will be placed on the serial you chose. Click 'OK' and
you will be able to print the slip. Now check if the holds have been
placed. (It works only if an item is attached to this serial).
 10 Go back to the routing lists management page (routinglists.pl) and
click on 'Export'. Download the CSV and check that it contains
correct data.

From serials-collection.pl page:
 11 In the serials list, click on 'Print list'.
 12 You will be asked to choose a routing list. Pick one and click on
'Continue'.
 13 ... (same behaviour as above)

Try to add and delete routing lists to show if links are correctly
updated in serials-home.pl, serials-collection.pl and
subscription-detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #35802|0   |1
is obsolete||

--- Comment #26 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35804
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35804action=edit
Bug 7957: Remove uses of check_routing which doesn't exist anymore

Also remove a unit tests about C4::Serials::addroutingmember which
also no longer exists

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13689] New: Remove opac-old.css and sco-old.css

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689

Bug ID: 13689
   Summary: Remove opac-old.css and sco-old.css
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

The following files are obsolete and should be removed:
koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css
koha-tmpl/opac-tmpl/bootstrap/css/sco-old.css

(see Bug 13612, Comment #4)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13689] Remove opac-old.css and sco-old.css

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13612

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13689

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13691] Add some selenium scripts

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13690

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13690] 3.18 performance issues

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13691,
   ||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13645

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #2 from Marc Véron ve...@veron.ch ---
Patch does not apply:

CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13690] 3.18 performance issues

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

--- Comment #5 from Marc Véron ve...@veron.ch ---
Created attachment 35807
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35807action=edit
[Signed-off] Bug 12911 - batch_id for new labels batches can be asssigned to
several batches

Currently batch_id is assigned upon creation of a new batch object.  This patch
leaves batch_id as 0 at creation and adds a check when adding items.  If batch
is new then batch_id is created then

Test plan:
1 -In one browser window, go to tools-label creator and click the new batch
button
2 - Before adding items, open a new browser, and go tools-label creator and
click the new batch button
3 - Note that both batches have the same number listed
4 - Add an item to the first batch - you should now see one item in the batch
5 - Add an item to the second batch, you should see two items in the batch
6 - Apply patch and repeat steps 12
7 - Note that neither batch lists a batch number
8 - Add an item to the first batch, you should see one item and a batch number
9 - Add an item to the second batch, you should see one item and a new batch
number

Patch behaves as expected.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #35719|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13690] 3.18 performance issues

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Some users have the feeling that 3.18.x is slower than 3.18.x
I tried to prove that.

I have created a selenium script (see bug 13691) which:
- goes on the mainpage and processes a log in (main)
- creates a patron category (add patron category)
- creates a patron (add patron)
- adds 3 items (add items)
- checks the 3 items out to the patron (checkout)
- checks the 3 items in (checkin)

On 3.18.x, the execution of the script takes ~65sec against 50sec on 3.16.x
But looking at the detailed times, the difference is much more important.
(Note that the values are the same for master and 3.18.x)

Here is the time spent for each operation
=3.18=
CP main = 4.04 + 4.52 + 3.86 + 4.17 = 4.15
CP add patron category  = 5.87 + 5.75 + 5.84 + 6.64 = 6.02
CP add patron   = 7.71 + 6.84 + 7.31 + 8.15 = 7.5
CP add items= 15.08 + 15.47 + 15.09 + 14.82 = 15.12
CP checkout = 13.31 + 14.00 + 13.63 + 13.93 = 13.72
CP checkin  = 11.78 + 12.70 + 12.81 + 11.71 = 12.25

=3.16=
CP main = 2.73 + 2.64 + 2.74 + 2.78 + 2.70  = 2.72
CP add patron category  = 3.93 + 3.76 + 3.82 + 3.85 + 3.78  = 3.83
CP add patron   = 5.44 + 5.12 + 5.37 + 5.18 + 5.15  = 5.25
CP add items= 10.82 + 10.90 + 10.34 + 11.44 + 10.64 = 10.83
CP checkout = 14.18 + 13.49 + 13.60 + 13.35 + 15.58 = 14.04
CP checkin  = 8.32 + 8.30 + 8.50 + 8.17 + 8.28  = 8.31

# Difference between both version
# diff ((3.18-3.16)/3.16)*100
CP main = +53%
CP add patron category = +57%
CP add patron = +43%
CP add items = +40%
CP checkout = -2%
CP checkin = +47%

Now, I would like to know if the patch I submitted on bug 13645 (Bug 13645:
Cache the DBIx connection) is useful or not, repeat again

=3.18+13645=
CP main= 4.20 + 4.15 + 4.42 + 4.06 + 4.52  = 4.3
CP add patron category = 6.01 + 5.89 + 5.92 + 5.78 + 6.32  =  6
CP add patron  = 7.02 + 7.79 + 7.06 + 6.80 + 7.30  = 7.2
CP add items   = 15.34 + 15.10 + 15.31 + 16.89 + 17.03 = 15.9
CP checkout= 15.35 + 14.01 + 14.14 + 14.07 + 14.08 = 14.3
CP checkin = 14.38 + 11.85 + 11.86 + 12.17 + 12.17 = 12.5

Quite the same as without the patch, even a bit worse...

I would like to understand what is the difference (4.15 vs 2.72) for the main
page.

Go to see the apache access logs for the GET + POST on the main page:
3.16
GET /cgi-bin/koha/mainpage.pl HTTP/1.1 200 2233 time=738896
POST /cgi-bin/koha/mainpage.pl HTTP/1.1 200 3675 time=763546

3.18
GET /cgi-bin/koha/mainpage.pl HTTP/1.1 200 2285 time=1374552
POST /cgi-bin/koha/mainpage.pl HTTP/1.1 200 3836 time=1381786

So NYTProf should help us, comparing the profiling between 3.16 and 3.18.

$ git checkout 3.16.x;rm -r /tmp/home;perl -d:NYTProf mainpage.pl
Profile of mainpage.pl for 185ms (of 258ms), executing 62528 statements and
9841 subroutine calls in 89 source files and 24 string evals.

$ git checkout 3.18.x;rm -r /tmp/home;perl -d:NYTProf mainpage.pl
Profile of mainpage.pl for 209ms (of 276ms), executing 63812 statements and
9444 subroutine calls in 81 source files and 23 string evals.
Not really...

With wget, I can reproduce the difference easily.
$ time wget http://pro.koha-qa.vm/cgi-bin/koha/mainpage.pl
3.16 ~700ms
3.18 ~1300-1400ms

Now that it's easy to reproduce the difference, I will try to find the first
bad commit with git bisect:
$ git checkout 3.18.x
$ git bisect start HEAD 50078d04c6c3e3e85d6f8ed3645368f7a69402e5
$ time perl mainpage.pl

= 1a737dcee6f600fc9d853f7318e1591b75b1349b is the first bad commit

$ git show 1a737dcee6f600fc9d853f7318e1591b75b1349b
  commit 1a737dcee6f600fc9d853f7318e1591b75b1349b
  Date:   Thu Dec 5 07:35:00 2013 -0500
  Bug 6254: make it possible to set default privacy setting for new patrons

I suspect it's because C4::Members now uses Koha::Database which uses
Koha::Schema

I comment Koha::Database l.12
  #__PACKAGE__-load_namespaces;

$ time wget http://pro.koha-qa.vm/cgi-bin/koha/mainpage.pl
  returns ~700ms

So 700ms more spent in the mainpage is caused by the DBIx::Class schema
loading.
But the DBIC schema is not used in the mainpage...

Try the second patch on bug 13645 (Bug 13645: Use DBIx::Connector)
$ git checkout 3.18
$ git apply patches 1, 2
$ git log --oneline
 e64240b Bug 13645: Use DBIx::Connector
 73f3835 Bug 13645: Cache the DBIx connection

CP main= 4.06 + 4.11 + 4.09 + 4.18 + 4.32  = 4.2
CP add patron category = 5.86 + 5.77 + 5.70 + 6.15 + 5.85  = 5.9
CP add patron  = 6.88 + 7.30 + 7.47 + 6.58 + 6.56  = 7

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |
   Patch complexity|--- |Trivial patch
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13690] 3.18 performance issues

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35808
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35808action=edit
Perf differences between 3.16 and 3.18

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13693] course reserve status isn't correct

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13693

--- Comment #1 from Carmen car...@bywatersolutions.com ---
Created attachment 35810
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35810action=edit
Course status wrong

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #19 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13682] Capitalization: Holds Queue

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682

--- Comment #1 from Marc Véron ve...@veron.ch ---
Created attachment 35811
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35811action=edit
Bug 13682 - Capitalization: Holds Queue

This patch changes capitalization of Holds Queue to Holds queue in
koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueu$

To test:
Apply patch
Go to Circulation  Holds queue page
Verify that the capitalization is correct

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

--- Comment #1 from Marc Véron ve...@veron.ch ---
Created attachment 35812
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35812action=edit
Bug 13676 - OpacSuppression description says 'items' but means 'records'

This patch changes the wording for the OpacSuppression preference description.

Without patch:
... items marked as suppressed from OPAC search results. Note that you must
have the codeSuppress/code index set up in Zebra and at least one
suppressed item, or your searches will be broken. ...

With patch:
... items marked as suppressed from OPAC search results. Note that you must
have the codeSuppress/code index set up in Zebra and at least one
suppressed biblio record, or your searches will be broken. ...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13682] Capitalization: Holds Queue

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13693] New: course reserve status isn't correct

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13693

Bug ID: 13693
   Summary: course reserve status isn't correct
 Change sponsored?: ---
   Product: Koha
   Version: 3.16
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Course reserves
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: car...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 35809
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35809action=edit
Status correct in catalog

when an item is on order, the status shows properly in the catalog but not in
course reserve. (see attachments)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13682] Capitalization: Holds Queue

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 CC||ve...@veron.ch
 Status|NEW |Needs Signoff
   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee!

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #11 from Colin Campbell colin.campb...@ptfs-europe.com ---
I tried using the patch on a site and it didnt accept the fee acknowledgement.
I've got a fixed patch which a site is testing with some 3M machines, will
upload if they dont find any further probs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13670] Patron holds table not loading when holds tab anchor is used

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12323] Acquisitions search results fixed in order of biblionumber

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12323

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #14 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13319] On inserting an order, the parent_ordernumber attribute is not set to the object

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13319

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13049] Improve self-registration cronjobs

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Are you still planning on submitting a patch for this bug?

(In reply to M. de Rooy from comment #2)
 (In reply to Kyle M Hall from comment #1)
  What do you think?
 
 Thanks. This is quite clear. I will send a proposed patch. Still thinking a
 little bit on the provisional category-case..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

--- Comment #35 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35764
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35764action=edit
Bug 13417: (qa follow-up) Rename the permission to delete_public_lists

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

--- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #18)
 Wondering, what is meant here?
 Restocking = Already ordered

Yes I am not sure it's what I meant.
Restocking means the supplier does not have the item and you want to cancel it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

--- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Joubu, 
I think there is a little typo:
('ORDER_CANCELLATION_REASON', 1, 'Old of stock'),
it's in a/installer/data/mysql/updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #8 from Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no ---
As a sidenote, I can confirm that if the returned character 3in the SIP
Checkout Response is 0 for an item that is not checked out, it breaks
automation and circulation logic altogether, as any item returned should
trigger a transfer if applicable.

Therefore I'd like to up the severity of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12529] Overdue notices do not respect holidays

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529

--- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com ---
Thanks Chris for the fix (bug 13679). It looks easier than I expected :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

--- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
And I commented on both... I am getting old :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

--- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35767
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35767action=edit
Bug 13380: Wording changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

--- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35768
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35768action=edit
Bug 13380: Add ORDER_CANCELLATION_REASON AV to all language files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

--- Comment #22 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Maybe we could just leave it out and go with 2 status?
Restocking and out of stock seem very similar.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||13007

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13637

--- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com ---
Weird, I opened the same bug report on the same day!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13637] Make the permission's descriptions translatable in template

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13637

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13632

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13007] suggestions.budgetid should be a foreign key

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13007

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||13675

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

--- Comment #34 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35763
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35763action=edit
Bug 13417: Limit the permission to delete

It's preferable to limit the permission to delete shelves.

Apply both patches before testing, then follow this test plan

Currently a public list can only be deleted by its owner.
This means lists can exist infinitely.
This will introduce a new permission for list. With this permission, a
staff member will be allow to delete any public lists.

Test plan:
1/ Add the manage_shelves permission to a patron.
2/ Login with this patron
3/ Go on the public list view
4/ You should be able to delete all public lists

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

--- Comment #37 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35766
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35766action=edit
Bug 13417: Remove warnings

Without this patch
  perl -wc C4/VirtualShelves.pm
failed:
Constant subroutine C4::VirtualShelves::SHELVES_MASTHEAD_MAX redefined
at /usr/share/perl/5.20/constant.pm line 156.
Constant subroutine C4::VirtualShelves::SHELVES_COMBO_MAX redefined at
/usr/share/perl/5.20/constant.pm line 156.
Constant subroutine C4::VirtualShelves::SHELVES_MGRPAGE_MAX redefined at
/usr/share/perl/5.20/constant.pm line 156.
Constant subroutine C4::VirtualShelves::SHELVES_POPUP_MAX redefined at
/usr/share/perl/5.20/constant.pm line 156.
Constant subroutine C4::VirtualShelves::SHARE_INVITATION_EXPIRY_DAYS
redefined at /usr/share/perl/5.20/constant.pm line 156.
Subroutine GetShelves redefined at C4/VirtualShelves.pm line 103.
Subroutine GetAllShelves redefined at C4/VirtualShelves.pm line 159.
Subroutine GetSomeShelfNames redefined at C4/VirtualShelves.pm line 189.
Subroutine GetShelf redefined at C4/VirtualShelves.pm line 230.
Subroutine GetShelfContents redefined at C4/VirtualShelves.pm line 262.
Subroutine AddShelf redefined at C4/VirtualShelves.pm line 315.
Subroutine AddToShelf redefined at C4/VirtualShelves.pm line 353.
Subroutine ModShelf redefined at C4/VirtualShelves.pm line 394.
Subroutine ShelfPossibleAction redefined at C4/VirtualShelves.pm line
454.
Subroutine DelFromShelf redefined at C4/VirtualShelves.pm line 545.
Subroutine DelShelf redefined at C4/VirtualShelves.pm line 589.
Subroutine GetBibliosShelves redefined at C4/VirtualShelves.pm line 603.
Subroutine ShelvesMax redefined at C4/VirtualShelves.pm line 628.
Subroutine HandleDelBorrower redefined at C4/VirtualShelves.pm line 648.
Subroutine AddShare redefined at C4/VirtualShelves.pm line 683.
Subroutine AcceptShare redefined at C4/VirtualShelves.pm line 703.
Subroutine IsSharedList redefined at C4/VirtualShelves.pm line 731.
Subroutine RemoveShare redefined at C4/VirtualShelves.pm line 750.
Subroutine _shelf_count redefined at C4/VirtualShelves.pm line 764.
Subroutine _CheckShelfName redefined at C4/VirtualShelves.pm line 788.
C4/VirtualShelves.pm syntax OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

--- Comment #36 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35765
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35765action=edit
Bug 13417: Add the permission for all languages

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #35083|0   |1
is obsolete||
  Attachment #35084|0   |1
is obsolete||
  Attachment #35085|0   |1
is obsolete||
  Attachment #35086|0   |1
is obsolete||
  Attachment #35089|0   |1
is obsolete||

--- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35762
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35762action=edit
Bug 13417: Allow staff members to manage public lists

Currently a public list can only be deleted by its owner.
This means lists can exist infinitely.
This will introduce a new permission for list. With this permission, a
staff member will be allow to delete any public lists.

Test plan:
1/ Add the manage_shelves permission to a patron.
2/ Login with this patron
3/ Go on the public list view
4/ You should be able to edit all public lists

Followed test plan. Works as expected.
Signed-off-by: Marc Veron ve...@veron.ch

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #35767|0   |1
is obsolete||

--- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35773
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35773action=edit
Bug 13380: Wording changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13645] DBIx connection needs to be cached

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

--- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com ---
This needs discussion, I really would like to see more people involved here.

I submitted a second patch, here the benchmark result for
  Koha::Acquisition::Bookseller-search;

Patch 1 is Cache the DBIx connection
Patch 2 is Use DBIx::Connector

With 14 suppliers in DB

On master
Perl benchmark_bookseller.pl  1.34s user 0.05s system 96% cpu 1.444 total
Perl benchmark_bookseller.pl  1.38s user 0.03s system 97% cpu 1.448 total
Perl benchmark_bookseller.pl  1.37s user 0.04s system 97% cpu 1.445 total
Perl benchmark_bookseller.pl  1.38s user 0.02s system 97% cpu 1.437 total
Perl benchmark_bookseller.pl  1.35s user 0.03s system 97% cpu 1.418 total

On master + patch 1
Perl benchmark_bookseller.pl  0.92s user 0.04s system 96% cpu 0.999 total
Perl benchmark_bookseller.pl  0.94s user 0.05s system 96% cpu 1.031 total
Perl benchmark_bookseller.pl  0.90s user 0.06s system 96% cpu 0.988 total
Perl benchmark_bookseller.pl  0.94s user 0.04s system 96% cpu 1.021 total
Perl benchmark_bookseller.pl  0.93s user 0.04s system 96% cpu 1.003 total

On master + patch 1  patch 2
Perl benchmark_bookseller.pl  0.93s user 0.03s system 95% cpu 1.002 total
Perl benchmark_bookseller.pl  0.96s user 0.03s system 95% cpu 1.031 total
Perl benchmark_bookseller.pl  0.97s user 0.03s system 95% cpu 1.046 total
Perl benchmark_bookseller.pl  0.99s user 0.02s system 96% cpu 1.048 total
Perl benchmark_bookseller.pl  0.93s user 0.04s system 95% cpu 1.013 total

On master + patch 2
Perl benchmark_bookseller.pl  1.40s user 0.02s system 97% cpu 1.464 total
Perl benchmark_bookseller.pl  1.36s user 0.04s system 96% cpu 1.436 total
Perl benchmark_bookseller.pl  1.36s user 0.04s system 97% cpu 1.428 total
Perl benchmark_bookseller.pl  1.39s user 0.01s system 97% cpu 1.439 total
Perl benchmark_bookseller.pl  1.37s user 0.05s system 97% cpu 1.454 total

With 1014 suppliers in DB
On master
perl benchmark_bookseller.pl  35.66s user 0.14s system 99% cpu 35.977 total 
perl benchmark_bookseller.pl  35.36s user 0.14s system 99% cpu 35.591 total

On master + patch 1
perl benchmark_bookseller.pl  2.50s user 0.07s system 95% cpu 2.675 total
perl benchmark_bookseller.pl  2.56s user 0.07s system 95% cpu 2.739 total
perl benchmark_bookseller.pl  2.66s user 0.05s system 95% cpu 2.849 total
perl benchmark_bookseller.pl  2.49s user 0.06s system 96% cpu 2.655 total
perl benchmark_bookseller.pl  2.42s user 0.08s system 96% cpu 2.581 total

On master + patch 1  patch 2
perl benchmark_bookseller.pl  2.45s user 0.05s system 96% cpu 2.596 total
perl benchmark_bookseller.pl  2.49s user 0.04s system 96% cpu 2.629 total
perl benchmark_bookseller.pl  2.49s user 0.04s system 96% cpu 2.629 total
perl benchmark_bookseller.pl  2.48s user 0.09s system 96% cpu 2.678 total
perl benchmark_bookseller.pl  2.40s user 0.08s system 96% cpu 2.562 total

On master + patch 2
perl benchmark_bookseller.pl  34.75s user 0.11s system 99% cpu 34.927 total
perl benchmark_bookseller.pl  34.22s user 0.12s system 99% cpu 34.397 total
perl benchmark_bookseller.pl  35.12s user 0.15s system 99% cpu 35.343 total

At first glance, patch 2 does not seem to be efficient, but I am not confident
with patch 1, I got bad results with other tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #26 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35772
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35772action=edit
Bug 12395: Add unit test to check created_by is correctly set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #33839|0   |1
is obsolete||

--- Comment #25 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35771
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35771action=edit
Bug 12395: Update aqorders.created_by with aqbasket.authorisedby

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #33837|0   |1
is obsolete||

--- Comment #23 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35769
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35769action=edit
Bug 12395: Save order line's creator

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #33838|0   |1
is obsolete||

--- Comment #24 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35770
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35770action=edit
Bug 12395 [QA Followup]

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #27 from Julian Maurice julian.maur...@biblibre.com ---
Patches rebased on master + new unit test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13645] DBIx connection needs to be cached

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645

--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35774
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35774action=edit
Bug 13645: Use DBIx::Connector

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13645] DBIx connection needs to be cached

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645

--- Comment #12 from Jacek Ablewicz a...@biblos.pk.edu.pl ---
(In reply to Jonathan Druart from comment #11)

 I got bad results with other tests.

What kinds of bad results? Do you mean something performance-related only, or
did you perhaps encountered some unforseen problems, regressions etc elsewhere?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #15 from Julian Maurice julian.maur...@biblibre.com ---
(In reply to M. de Rooy from comment #14)
 Current master e5b834a1c474f761c9f9c8c01dd6abeb99ee5eac does not fail this
 test with me.

Maybe this is the kind of test that depends on some configuration in database
that you have and I have not.
Could you try to apply the patch and see if the test pass ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13645] DBIx connection needs to be cached

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645

--- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com ---
It's performance-related only, I will sent an email to koha-devel today
(hopefully).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12041] Improve Koha::Cache

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
This patch set changed the prototype of set_in_cache, but did not update the
calls in t/Cache.t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #35770|0   |1
is obsolete||

--- Comment #30 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35780
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35780action=edit
Bug 12395 [QA Followup]

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #35771|0   |1
is obsolete||

--- Comment #31 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35781
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35781action=edit
Bug 12395: Update aqorders.created_by with aqbasket.authorisedby

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #35769|0   |1
is obsolete||

--- Comment #29 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35779
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35779action=edit
Bug 12395: Save order line's creator

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #35772|0   |1
is obsolete||

--- Comment #32 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35782
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35782action=edit
Bug 12395: Add unit test to check created_by is correctly set

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee!

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #10 from Colin Campbell colin.campb...@ptfs-europe.com ---
Updated status to signed off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11395] Batch modifications for records

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #34554|0   |1
is obsolete||

--- Comment #99 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 35784
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35784action=edit
Bug 11395: Add links to the new tool page

This patch adds links in the tool module to the new batch tool and in
the basket.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11395] Batch modifications for records

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #34553|0   |1
is obsolete||

--- Comment #98 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 35783
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35783action=edit
Bug 11395: Add a batch record modification

This patch offers a new tool to modify records in a batch.

This feature adds:
- a new pl/tt files tools/batch_record_modification
- a new permission: tools  records_batchmod

Test plan for biblios:
0/ Create a new marc modification template with some actions.
1/ Generate a list of biblionumbers you want to modify.
There are two ways to generate a list of biblionumbers:
- using the basket: do a search, add some biblio to your basket, open
  the basket and click on the Action button  Modify
- generating a list from a report
2/ On the Batch record modification tool verify:
- information is correct.
- the preview link show you the needed record.
3/ After clicking on the Modify selected recors button, verify
the records have been modified as you wanted.

Test plan for authority:
0/ Create a new marc modification template with some actions.
1/ Generate a list of authid using a report:
2/ On the Batch record modification tool verify:
- authorities are display with the summary.
- the preview link show you the needed record.
3/ After clicking on the Modify selected recors button, verify
the records have been modified as you wanted.

Catch of errors:
if an error occurs during the modification process, the tool
displays an error message.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11395] Batch modifications for records

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #34556|0   |1
is obsolete||

--- Comment #101 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 35786
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35786action=edit
Bug 11395: The modification template should be changed on the list view

This patch fixes the following issue:
If the user comes from a basket, the list view is displayed but there is
no way to select the modification template.

Now the template can be chosen on the list view. This way, the user is
able to change the modifications to apply and see the previewed records.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11395] Batch modifications for records

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #34558|0   |1
is obsolete||

--- Comment #103 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 35788
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35788action=edit
Bug 11395: Fix path for the checkboxes jQuery plugin

This patch fixes a bad resolution conflict (bug 12107).

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11395] Batch modifications for records

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #34555|0   |1
is obsolete||

--- Comment #100 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 35785
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35785action=edit
Bug 11395: New service to preview a record.

The main patch adds the ability to preview a record. This is done using
an AJAX way. The preview record is processed on the server side.

Note: I don't think an authentification check is necessary here.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11395] Batch modifications for records

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #34557|0   |1
is obsolete||

--- Comment #102 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 35787
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35787action=edit
Bug 11395: DB: Add permission tools_records_batchmod

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11395] Batch modifications for records

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #34560|0   |1
is obsolete||

--- Comment #105 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 35790
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35790action=edit
Bug 11395: Raise an alert if control field is used

If a control field is used with a copy or move action, the interface
should block the user in some cases:
- If a control field is used with a regular field
- The subfield should be empty

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11395] Batch modifications for records

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #34559|0   |1
is obsolete||

--- Comment #104 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 35789
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35789action=edit
Bug 11395: prevent processing no record

If no record is selected, the modification should not be launched.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11395] Batch modifications for records

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #34561|0   |1
is obsolete||

--- Comment #106 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 35791
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35791action=edit
Bug 11395: exit should be done after displaying the output

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11395] Batch modifications for records

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #34562|0   |1
is obsolete||

--- Comment #107 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 35792
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35792action=edit
Bug 11395: A control field is a field with tag  10

This patch fixes the existing test about control fields.
A control field is  10, not =10!

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11395] Batch modifications for records

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Signed Off
 CC||tomasco...@gmail.com

--- Comment #108 from Tomás Cohen Arazi tomasco...@gmail.com ---
Hi, i like this patch set, I signed it myself too.
But I'm marking as Signed-off because I want more people involved. It is a
great feature, that could potentially break people's records. So I'm asking
Marcel and/or Katrin to give it a ride before pushing it.

I rebased it to current master also.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects

2015-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35814|0   |1
is obsolete||

--- Comment #56 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35815
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35815action=edit
Bug 13019 [QA Followup] - Fix stale unit test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >