[Koha-bugs] [Bug 12616] Locale in subscriptions not preselecting correctly

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5025] discrepancy between opac doc-head-open.inc and staff doc-head-open.inc

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12552] Odd error caused by URI Escape

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #6 from M. Tompsett mtomp...@hotmail.com ---
Problem. I entered $_ as my note, and once saved, the note portion displayed as
\$_.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5025] discrepancy between opac doc-head-open.inc and staff doc-head-open.inc

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #40201|0   |1
is obsolete||

--- Comment #12 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 40248
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40248action=edit
[SIGNED-OFF] Bug 5025: discrepancy between opac doc-head-open.inc and staff
doc-head-open.inc

http://library.debiankoha.ca/cgi-bin/koha/errors/400.pl
http://library.debiankoha.ca/cgi-bin/koha/errors/401.pl
http://library.debiankoha.ca/cgi-bin/koha/errors/402.pl
http://library.debiankoha.ca/cgi-bin/koha/errors/403.pl
http://library.debiankoha.ca/cgi-bin/koha/errors/404.pl
http://library.debiankoha.ca/cgi-bin/koha/errors/500.pl
http://library.debiankoha.ca/cgi-bin/koha/ilsdi.pl
Set OpacMaintenance to Show in the Staff client system preferences.
http://library.debiankoha.ca/cgi-bin/koha/maintenance.pl
Set OpacMaintenance to Don't show in the Staff client system preferences.
http://library.debiankoha.ca/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=5390
http://library.debiankoha.ca/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=5390
Log into OPAC Client
http://library.debiankoha.ca/cgi-bin/koha/opac-account.pl
http://library.debiankoha.ca/cgi-bin/koha/opac-search.pl
-- This is actually the advanced search.
FIXME: Don't know how to trigger opac-alert-subscribe.tt
FIXME: Don't know how to trigger opac-auth-MARCdetail.tt
FIXME: Don't know how to trigger opac-auth-detail.tt
FIXME: Don't know how to trigger opac-auth.tt
Click 'Authority search' in OPAC
Click 'Submit'
Search for something in the catalog
Click 'Select all'
Change 'With selected titles:' drop down to 'cart'
View the cart.
Click 'Send'
Click 'Cancel'
Click 'Download'
Click 'Cancel'
Close cart window
Search for something in the catalog
Select 'Select all'
Change 'With selected titles:' drop down to '[ New List ]'
Save the list
Click 'Lists'
Click the list you saved
Click 'Download list'
Click 'Cancel'
Click 'Send list'
Click 'Cancel'
Copy the URL from download list and remove the 'context=modal'
Click 'Cancel'
http://library.debiankoha.ca/cgi-bin/koha/opac-blocked.pl
http://library.debiankoha.ca/cgi-bin/koha/opac-browser.pl
FIXME: Don't know how to trigger opac-course-details.tt
http://library.debiankoha.ca/cgi-bin/koha/opac-course-reserves.pl
http://library.debiankoha.ca/cgi-bin/koha/opac-detail.pl?biblionumber=5336
FIXME: Don't know how to trigger opac-full-serial-issues.tt
http://library.debiankoha.ca/cgi-bin/koha/opac-imageviewer.pl
http://library.debiankoha.ca/cgi-bin/koha/opac-main.pl
Click on the user name in the top area.
Click the 'your personal details' tab.
Change the birth date.
Click 'Submit'
http://library.debiankoha.ca/cgi-bin/koha/opac-messaging.pl
http://library.debiankoha.ca/cgi-bin/koha/opac-overdrive-search.pl
Click on the user name in the top area.
Click the 'change your password' tab.
Set OPACPrivacy to Allow in the Staff client system preferences.
Refresh OPAC page
click on the user name in the top area.
Click the 'your privacy' tab.
Click the 'your reading history' tab.
Change the PatronSelfRegistration to Allow in the Staff client system
preferences.
Change the PatronSelfRegistrationCategory to PT or some other valid patron
category code.
Change the PatronSelfRegistrationAdditionalInstructions to something.
Refresh OPAC page
Log out
Click the 'Register Here' link.

http://bugs.koha-community.org/show_bug.cgi?id=5025

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Tested most pages, inspected all of them.
No errors

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #40242|0   |1
is obsolete||

--- Comment #2 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40249
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40249action=edit
Bug 14404 - Checkouts default sort order for Self Checkout (SCO) confusing for
patrons

Libraries are reporting that patrons are very confused during
self-checkout. The problem is they are expecting the list of checkouts
to be in the order they checked out the items ( first checkout on the
bottom, last item checked out on top ). However, the checkouts
table is sorted by title ( ascending ) then due date ( descending ).
This is not intuitive.

Test Plan:
1) Enable Koha's self checkout
2) Use the SCO to check out a random assortment of items,
   make sure you don't check them out in alphabetical order
3) Note the order of the items in the list is not based on the order
   you checked them out in
4) Apply this patch
5) Refresh the page
6) Note the items are now in the order you checked them out
   with the last on top and the first on bottom

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||mtomp...@hotmail.com

--- Comment #8 from M. Tompsett mtomp...@hotmail.com ---
The first __KOHA_USER__ tells the OS to run the command as that user. However,
the second and third are like trying to run: ls  mtompset ls  mtompset ls.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

--- Comment #7 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 40044
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40044
Bug 11144: Fix sequence of cronjobs: automatic renewal - fines - overdue
notices

Review of attachment 40044:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11144attachment=40044)
-

::: misc/cronjobs/crontab.example
@@ +49,4 @@
  # FINES
 +# OVERDUE NOTICES
 +# Sequence is important - renew what can be renewed, charge fines for the 
 rest, print fine amount into overdue notices
 +51 * * *  __KOHA_USER__ $KOHA_CRON_PATH/automatic_renewals.pl  
 __KOHA_USER__  $KOHA_CRON_PATH/fines.pl  __KOHA_USER__  
 $KOHA_CRON_PATH/overdue_notices.pl -t

Not quite. __KOHA_USER__ the first time, sure. But those others seem wrong to
me.

@@ -86,5 @@
  # delete old purchase suggestions weekly. Replace XX with a number to define 
 the age of suggestions to delete.
  @weekly  __KOHA_USER__  $KOHA_CRON_PATH/purge_suggestions.pl --days XX  
 /dev/null 21
 -
 -# every day at 3AM renew all issues scheduled for automatic renewal
 -0 3 * * *  __KOHA_USER__ $KOHA_CRON_PATH/automatic_renewals.pl

Do we want to shift renewals to 1:05am, or should we shift overdues and fines
to 3:00am? I see no reason one way or another. Just wanted to point this out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7710] multiple holds per title

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

--- Comment #87 from Nick Clemens n...@quecheelibrary.org ---
(In reply to Alex Arnaud from comment #86)
 I let this bug in discussion.
 Librarians/non librarians, feel free to comment/advice  /help :)

Based on IRC chat with rangi, cait, and liz:

- You shouldn't be able to mix record level / item level holds (tie to
OPACItemHolds pref?)
- Staff/Patrons should be able to place multiple item level holds
- Staff should be able to place a record level hold and specify number of
copies needed
- Allowing multiple holds should be not be a global syspref, but should be in
circ rules (so you can only allow on certain types of items/patron etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14350] Missing statement in kohastructure.sql - DROP TABLE IF EXISTS borrower_sync;

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14350

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.20.x will be in 3.20.1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14351] Remove given-when from opac-search.pl

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.20.x will be in 3.20.1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11467] Untranslatable strings in opac-detail.tt

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14400] Automated backup to cloud storage

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14400

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
Thought this might be handy.
https://github.com/andreafabrizi/Dropbox-Uploader

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12616] Locale in subscriptions not preselecting correctly

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #40246|0   |1
is obsolete||

--- Comment #12 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40250
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40250action=edit
Bug 12616: Locale in subscriptions not preselecting correctly

There is a problem if a language is present but
don't have ISO639-2 code. Locale pulldown on serial
suscription is malformed.

To reproduce on master:
a) remove some entries on language_rfc4646_to_iso639
b) go to Serials  New suscription
c) Put any value on Vendor and record, press Next
d) Look at locale pulldown, it must default to last
removed lang from a), also other langs has no value
and are also 'selected' on html

To test:
1) Reproduce the problem
2) Apply the patch
3) Add New suscription, pulldown must be fixed

NOTE: Deleted Urdu and Chinese.
  Master had both selected in the HTML.
  Applied patch, neither were added.
  Defaults to first item, which is blank meaning English.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12616] Locale in subscriptions not preselecting correctly

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11229] Payments wrongly saved in Statistics table by C4::Accounts::makepartialpayment and makepayment

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |In Discussion

--- Comment #6 from M. Tompsett mtomp...@hotmail.com ---
This patch is insufficient in my mind. Read the C4::Account code to which you
linked.

recordpayment sets $branch to logged in user's branch. Function seems to be SIP
based on comments, so should be user paying own fine, right?

recordpayment_selectaccts sets $branch to logged in user's branch. Function
seems to be SIP based on comments, so should be user paying own fine, right?

makepayment takes $branch as a parameter, but then uses $user in the
UpdateStats call?! This patch fixes that.

makepartialpayment takes $branch as a parameter, but then uses $user in the
UpdateStats call?! This patch misses this.

WriteOffFee takes $branch as a parameter, but if it is 0, '', or undef, it uses
the logged in user's branch. It correctly uses $branch for UpdateStats. I think
the handling used here should be duplicated in the makepayment and
makepartialpayment functions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11467] Untranslatable strings in opac-detail.tt

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #39968|0   |1
is obsolete||

--- Comment #2 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40251
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40251action=edit
Bug Untranslatable srings in opac-detail.tt (IDreamBooks*, OpacBrowseResults)

Patch marks several strings in the Javascript on the OPAC detail
and result page for translation.

1) IDreamBooks*
- Activate the 3 IDreamBooks* system preferences
- Check the 'cloud' and additional content shows up correctly on
  the detail and result pages
- Verify everything works as expected and the same as without the patch

2) OpacBrowseResults
- Activate OpacBrowseResults
- Do various searches
- Verify the nex, previous, browse result list features still
  work the same as without the patch

Bonus: Check new strings appear in the .po files by updating one
   language with the patch applied (perl translate update de-DE)

NOTE: Really should have read the test plan more closely.
  I couldn't find the 'Go to detail:' section, until I clicked
  'Browse results'.
  Did not test additional language po files. Did trigger all
  code segments.

http://bugs.koha-community.org/show_bug.cgi?id=11467

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10988] Allow login via Google OAuth2

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

Nicholas van Oudtshoorn vano...@gmail.com changed:

   What|Removed |Added

  Attachment #40087|0   |1
is obsolete||

--- Comment #32 from Nicholas van Oudtshoorn vano...@gmail.com ---
Created attachment 40252
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40252action=edit
Bug 10988 - Allow login via Google OAuth2

Modified patch to address issues found in the review. Thanks for that! 

Turns out in our live site, I'd already patched masthead.inc as suggested. (We
run another patch on top of the one provided here to put different login
buttons into Koha (library.pbc.wa.edu.au) - not sure if that's appropriate for
this patch or not...

And hopefully all the pink spots are gone now! :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13851] Replace waiting holds logic in circulation.pl with Koha Objects

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851

--- Comment #12 from Kyle M Hall k...@bywatersolutions.com ---
 There is a lack of tests for new module added by this patch.

I'll add some unit tests!

 ::: Koha/Hold.pm
 @@ +45,5 @@
  +
  +sub biblio {
  +my ($self) = @_;
  +
  +$self-{_biblio} ||= Koha::Biblios-find( $self-biblionumber() );
 
 Why not
 return $self-{_result}-biblio;
 ?

That would return a DBIC restultset and not a Koha::Biblios object.

 ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
 @@ +763,5 @@
   
  +[% IF ( WaitingHolds ) %]
  +div id=holdswaiting class=circmessage
  +h4Holds waiting:/h4
  +[% FOREACH w IN WaitingHolds %]
 
 WaitingHolds is an array??
 You have passed
 WaitingHolds = scalar $holds-waiting()
 in the pl script.

WaitingHolds is a Koha::Holds object, which Template Toolkit can iterate over.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13851] Replace waiting holds logic in circulation.pl with Koha Objects

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851

--- Comment #13 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 40247
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40247action=edit
Bug 13851 [QA Followup] - Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13851] Replace waiting holds logic in circulation.pl with Koha Objects

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12616] Locale in subscriptions not preselecting correctly

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616

--- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
You're the best - thx Bernardo!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

--- Comment #77 from M. Tompsett mtomp...@hotmail.com ---
Oops... found a mistake in my rebase... Let's try again. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #40215|0   |1
is obsolete||

--- Comment #78 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40223
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40223action=edit
Bug 8000 - Override emails of every message sent from Koha

For testing purposes, we do not want emails sent to (legitimate) users.
And sometime we also like to actually see what would be generated for the
users.
This preference will allow to override every message sent by koha with
a new (temporary) To address.  Leave it empty for normal usage.

C4/Letters.pm
installer/data/mysql/sysprefs.sql
installer/data/mysql/updatedatabase.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref

TESTING:
0) Run updatedatabase.pl
1) Enter a valid address for new preference SendAllEmailsTo, something that
will be easily identified
   as NOT the normal destination for the Koha emails.
2) Have koha generate an email to a user.  Or any other mean prefered that
cause Koha to send email.
3) Validate that the email is NOT sent to the user.
4) Validate that the email IS sent to the overriding address.
5) Clean the preference
6) Redo the test, validate that the email is going to the right address.

PS Not sure if those steps are precise enough.  Here's one way:
   a) set AutoEmailOpacUser to true
   b) create a new user, with an email address
   c) Normally, a confirmation email is sent to the user. Validate that it
goes to the SendAllEmailsTo one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #40216|0   |1
is obsolete||

--- Comment #79 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40224
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40224action=edit
Bug 8000 - Missing test to trigger code change

This adds a test case which will trigger _send_message_by_email
and thus provide a way to run the changes made.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #40221|0   |1
is obsolete||

--- Comment #84 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40229
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40229action=edit
Bug 8000 - Updated the remaining email validation to Email::Valid .

Replaced the =~ @ validation with Email::Valid-address();

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #40222|0   |1
is obsolete||

--- Comment #85 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40230
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40230action=edit
Bug 8000 - Atomic Update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11325] Focus not on Add Item in Lists

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325

--- Comment #9 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 40231
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40231action=edit
Bug 11325 - Focus not on Add Item in Lists

When viewing a list, the focus/cursor is no longer on the add items field
below the list.

This patch moves the Add Item form at left part of page so that it is always
shown (usefull when there are a lot of items). And adds focus to barcode input
so you can enter several items with a barcode scanner.

Test instructions:
1. Create a list
2. Make sure you have an object with an assigned barcode
3. Go to the list
= The barcode entry interface should be at left and has the focus
4. Enter the barcode and press enter (or use a scanner)
= The item is added to the list

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
 CC||mtomp...@hotmail.com

--- Comment #23 from M. Tompsett mtomp...@hotmail.com ---
This applies just fine for me off of master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605

--- Comment #4 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 30089
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30089
[SIGNED-OFF] Bug 12604: refactoring close_reopen_basket.t with TestBuilder

Review of attachment 30089:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=12605attachment=30089)
-

::: t/db_dependent/Acquisition/close_reopen_basket.t
@@ -46,5 @@
 -my ($ordernumber1, $ordernumber2);
 -( undef, $ordernumber1 ) = C4::Acquisition::NewOrder(
 -{
 -basketno = $basketno,
 -quantity = 24,

How is this quantity reflected in the refactored code?

@@ -55,5 @@
  
 -( undef, $ordernumber2 ) = C4::Acquisition::NewOrder(
 -{
 -basketno = $basketno,
 -quantity = 42,

How is this quantity reflected in the refactored code?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden bar...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |bar...@bywatersolutions.com
  Change sponsored?|--- |Sponsored
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #40219|0   |1
is obsolete||

--- Comment #82 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40227
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40227action=edit
Bug 8000 - Validate allEmailsTo email address before using it

This patch adds Data::Validate::Email to validate the allEmailsTo address
before using it as a unique destination.
Added to PerlDependencies.pm for this and future potential usages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #40220|0   |1
is obsolete||

--- Comment #83 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40228
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40228action=edit
Bug 8000: Replace Data::Validate::Email with Email::Valid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #40218|0   |1
is obsolete||

--- Comment #81 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40226
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40226action=edit
Bug 8000 - Correct inability to know where message was sent

The added column in the previous patch is used to determine where
the message was actually sent when using email.

This include a modification to the C4/Letters.pm libraries to
appropriate track and update the column and revising the test
file to check that the system preference actually does override
or not the destination.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #40217|0   |1
is obsolete||

--- Comment #80 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40225
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40225action=edit
Bug 8000 - Add a sentto_address column to message_queue

The problem with message_queue is the inability to tell if the
to_address was overriden at the time it was sent/attempted.
This column will reflect what was attempted.

MessageQueue.pm was generated by running the script
installer/data/mysql/updatedatabase.pl and then git add'ing
the resulting Koha/Schema/Result/MessageQueue.pm file. This was
generated by running ./misc/devel/update_dbix_class_files.pl
using appropriate -db_name=... -db_user=... -db_passwd=...
parameters. This file is necessary for 3.16 and higher.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8643] Add important constraint to marc subfields

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #31032|0   |1
is obsolete||

--- Comment #9 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40232
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40232action=edit
Bug 8643 - Add important constraint to marc subfields

This fix permits to add an Important option to the marc structure pages.

Testing:

I Apply the patch
II Run updatedatabase.pl

0) Define 100 as an important field ( Administration » MARC bibliographic
framework » MARC structure ( Default Frameword) » Edit )
1) Define 100$a as an important subfield (Administration » MARC bibliographic
framework » MARC structure (Default Frameword) » Subfield » Onglet a)
2) Edit a record to clear the field 100
3) Save the record.
4) Validate the following message:

A few important fields are not filled:

* tag 100 subfield a Nom de personne in tab
* Field 100 is important, at least one of its subfields should be filled.

Are you sure you want to save?

sponsored by the CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11325] Focus not on Add Item in Lists

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #10 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
I propose another patch, nearlyby :

It moves the Add Item form at left part of page so that it is always shown
(usefull when there are a lot of items).
And adds focus to barcode input so you can enter several items with a barcode
scanner.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14402] New: Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Bug ID: 14402
   Summary: Add --fees option to cleanup_database.pl to purge all
0 balance fees and payments older than the given
number of days
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: gmcha...@gmail.com
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

Work to be done:
Goal: Add ability to purge paid fees and payments that are older than a given
number of days.
Course of action: Add new option --fees to cleanup_database.pl to purge all 0
balance fees and payments older than the given number of days

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #86 from M. Tompsett mtomp...@hotmail.com ---
All those changes in Letters.t and the line removals in those two conflicting
areas: ARG! :) Anyways... Should be good to go again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

--- Comment #87 from Indranil Das Gupta indr...@gmail.com ---
(In reply to M. Tompsett from comment #86)
 All those changes in Letters.t and the line removals in those two
 conflicting areas: ARG! :) Anyways... Should be good to go again.

yes. all commits in the set apply cleanly now. thank you mark tompsett.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11325] Focus not on Add Item in Lists

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   Severity|minor   |enhancement

--- Comment #11 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
It set this as enhancement, I think its not a bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11325] Focus not on Add Item in Lists

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

Version|3.14|master
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7710] multiple holds per title

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

--- Comment #86 from Alex Arnaud alex.arn...@biblibre.com ---
I let this bug in discussion.
Librarians/non librarians, feel free to comment/advice  /help :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14403] New: Remove unconditional warn from Koha::NorwegianPatronDB

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14403

Bug ID: 14403
   Summary: Remove unconditional warn from Koha::NorwegianPatronDB
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: mag...@libriotech.no
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Line 99 og Koha/NorwegianPatronDB.pm looks like this: 

  warn $combined_username = $combined_password;

This is clearly a leftover from development and should be deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14400] New: Automated backup to cloud storage - Dropbox (tm)

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14400

Bug ID: 14400
   Summary: Automated backup to cloud storage - Dropbox (tm)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: indr...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Current cron job handle automated backup of Koha database and config schema.
This patch is designed to extend the function of automated backup on Dropbox
based cloud storage.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14400] Automated backup to cloud storage - Dropbox (tm)

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14400

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |indr...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8190] Add a logging module to Koha

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #122 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
I'm in general preferring the simplicity of Bug 14167 for now. Lets go with
that and get this much needed feature into Koha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167

--- Comment #30 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
I'm happy with Marcels and Kyles follow-ups, just the file permissions issue
Marcel brought to our attention that needs addressing now, and then I think we
should be good to go with this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7843] Add RSS feeds for OPAC news

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #31 from Viktor Sarge viktor.sa...@regionhalland.se ---
Had another look at this one and just have to say thanks! You are quite awesome
all of you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC.

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #35336|0   |1
is obsolete||

--- Comment #24 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 40214
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40214action=edit
Bug 13540 - Item's permanent_location is set to CART|PROC if an Item is edited
when it's location is CART|PROC.

This bug is rather nasty as it happens very discreetly when editing Items that
are
in either locations 'CART' or 'PROC'.
For example when changing one of the Item's statuses or barcode, the
permanent_location
gets overwritten without the user noticing it immediately. The damage becomes
apparent
only weeks later when there are potentially thousands of Items missing the
permanent_location and location.

:-:TEST SETUP:-:
0a. System preference ReturnToShelvingCart must be 'Move'.
0b. Find any Item (I69)
0c. Set I69's location to Book Cart (BC) or anything but empty.

:-:REPLICATE ISSUE:-:
1. Check-in the I69 and the location should turn to 'CART' (returned today).
2. Go to the Edit Item-view for I69, don't change anything, simply click
   Save changes
3. Observe that the permanent_location has changed to 'CART'.
   This is not good since now the location data is forever lost again (Bugg
7817).
   The cart_to_shelf.pl --hours 24-script cannot return the Item to the
proper
   place ;(

:-:AFTER THIS PATCH:-:
Repeat steps 1-2.
3. Observe that the permanent_location is still the old one, instead of getting
   overwritten by 'CART'.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi
 Working in prod for ~6 months.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14399] Remove missingitem code from inventory.pl

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14398

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14399] missingitem code from inventory.pl doesn't work properly

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399

--- Comment #1 from David Cook dc...@prosentient.com.au ---
Overall, I'm in favour of being able to mark inventory items as missing both
in the inventory report and in the actual Koha system.

So... I'm not sure if it's better to remove this code and start over with that
feature, or to refactor this code, or...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #20 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
I'm in general preferring the simplicity of Bug 14167 for now. Lets go with
that and get this much needed feature into Koha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13950] Sort Item search home library list by branch name

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13950

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Thx Nick and Indranil :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14357] Cannot delete branch specific notice

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14357

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com

--- Comment #2 from Indranil Das Gupta indr...@gmail.com ---
(In reply to Aleisha Amohia from comment #1)
 Hi Katrin, I didn't get this problem. Table had all the right details and
 notice deleted as it should.
 
 Can someone else check this out?

Just checked on 3.21.00.008. Added a custom ACQ notice for Centerville. Could
filter down to it, select delete option. Delete conf with the tds loaded
properly. Deletion worked.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC.

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #25 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Tests are broken... :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||indr...@gmail.com

--- Comment #68 from Indranil Das Gupta indr...@gmail.com ---
Hi Maxime,

On Koha 3.21.00.008:

CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl

CONFLICT (content): Merge conflict in basket/sendbasket.pl

Patch failed at 0001 Bug 8000 - Override emails of every message sent from Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14400] Automated backup to cloud storage

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14400

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

Summary|Automated backup to cloud   |Automated backup to cloud
   |storage - Dropbox (tm)  |storage

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14357] Cannot delete branch specific notice

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14357

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Thx - not sure what's going wrong - maybe some other patch fixed it since?
Closing this WORKSFORME.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13950] Sort Item search home library list by branch name

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13950

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #40211|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 40213
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40213action=edit
Bug 13950 - Sort Item search home library list by branch name

On the item search form the list of home libraries isn't sorted
alphabetically by their descrption.

To test:
- Ensure that you have libraries whose code/name are sorted in a different
alphabetical order (e.g. Aardvark/ZZZ  Zebra/AAA)
- Staff: Advanced search - item search
- See that libraries are sorted in code order
- Apply patch
- Verify selection block for home library is correctly sorted after
  applying the patch.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) indr...@gmail.com

Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13950] Sort Item search home library list by branch name

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13950

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13881] Add desk management

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14381] viewlog bug

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14381

--- Comment #1 from Mason James m...@kohaaloha.com ---
Hi

I'll take a look at this on 3.16.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14381] viewlog bug

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14381

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14401] New: Zebra index configuration doesn't allow exact search for 'C.'

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14401

Bug ID: 14401
   Summary: Zebra index configuration doesn't allow exact search
for 'C.'
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

This has been reported by a library that uses [A-Z]. for call numbers. Every
character in the alphabet can be searched perfectly fine using
callnum,ext:[A-Z]. - except for C.

After taking a look at the  /etc/zebradb/etc/word-phrase-utf.chr those 2 lines
are to blame for the problem:

333 map (^c\.)  @
335 map (^C\.)  @

I propose to remove them.

To test:
- catalog a record with an item with callnumber: C.
- catalog a record with an item with callnumber: B.
- try seaching for the second using callnum,ext:B. (exact field search)
  - Verify search works.
- try searching for the other with callnum,ext:C.
  - Verify no result.
- apply the patch - copy the zebra config file if necessary into the right spot
- reindex
- repeat searches - both should not bring up the correct record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #39989|0   |1
is obsolete||

--- Comment #73 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40219
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40219action=edit
Bug 8000 - Validate allEmailsTo email address before using it

This patch adds Data::Validate::Email to validate the allEmailsTo address
before using it as a unique destination.
Added to PerlDependencies.pm for this and future potential usages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #39988|0   |1
is obsolete||

--- Comment #72 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40218
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40218action=edit
Bug 8000 - Correct inability to know where message was sent

The added column in the previous patch is used to determine where
the message was actually sent when using email.

This include a modification to the C4/Letters.pm libraries to
appropriate track and update the column and revising the test
file to check that the system preference actually does override
or not the destination.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #39986|0   |1
is obsolete||

--- Comment #70 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40216
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40216action=edit
Bug 8000 - Missing test to trigger code change

This adds a test case which will trigger _send_message_by_email
and thus provide a way to run the changes made.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #39985|0   |1
is obsolete||

--- Comment #69 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40215
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40215action=edit
Bug 8000 - Override emails of every message sent from Koha

For testing purposes, we do not want emails sent to (legitimate) users.
And sometime we also like to actually see what would be generated for the
users.
This preference will allow to override every message sent by koha with
a new (temporary) To address.  Leave it empty for normal usage.

C4/Letters.pm
installer/data/mysql/sysprefs.sql
installer/data/mysql/updatedatabase.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref

TESTING:
0) Run updatedatabase.pl
1) Enter a valid address for new preference SendAllEmailsTo, something that
will be easily identified
   as NOT the normal destination for the Koha emails.
2) Have koha generate an email to a user.  Or any other mean prefered that
cause Koha to send email.
3) Validate that the email is NOT sent to the user.
4) Validate that the email IS sent to the overriding address.
5) Clean the preference
6) Redo the test, validate that the email is going to the right address.

PS Not sure if those steps are precise enough.  Here's one way:
   a) set AutoEmailOpacUser to true
   b) create a new user, with an email address
   c) Normally, a confirmation email is sent to the user. Validate that it
goes to the SendAllEmailsTo one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #39992|0   |1
is obsolete||

--- Comment #76 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40222
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40222action=edit
Bug 8000 - Atomic Update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #39987|0   |1
is obsolete||

--- Comment #71 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40217
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40217action=edit
Bug 8000 - Add a sentto_address column to message_queue

The problem with message_queue is the inability to tell if the
to_address was overriden at the time it was sent/attempted.
This column will reflect what was attempted.

MessageQueue.pm was generated by running the script
installer/data/mysql/updatedatabase.pl and then git add'ing
the resulting Koha/Schema/Result/MessageQueue.pm file. This was
generated by running ./misc/devel/update_dbix_class_files.pl
using appropriate -db_name=... -db_user=... -db_passwd=...
parameters. This file is necessary for 3.16 and higher.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC.

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540

--- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Olli-Antti Kivilahti from comment #25)
 Tests are broken... :(

Which ones?
I tried t/db_dependent/Circulation.t, and they pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14173] Paging on 'recent comments' page in OPAC is not displaying correctly

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173

--- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Liz, can you pick this for 3.18 maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14381] viewlog bug

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14381

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

   Keywords||rel_3_16_candidate
   Priority|P5 - low|P3
 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #39991|0   |1
is obsolete||

--- Comment #75 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40221
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40221action=edit
Bug 8000 - Updated the remaining email validation to Email::Valid .

Replaced the =~ @ validation with Email::Valid-address();

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #39990|0   |1
is obsolete||

--- Comment #74 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40220
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40220action=edit
Bug 8000: Replace Data::Validate::Email with Email::Valid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14403] Remove unconditional warn from Koha::NorwegianPatronDB

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14403

--- Comment #1 from Magnus Enger mag...@libriotech.no ---
Created attachment 40233
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40233action=edit
Bug 14403 - Remove warn in Koha::NorwegianPatronDB

Line 99 has an unconditional warn, left over from development:

warn $combined_username = $combined_password;

This patch deletes the line i question.

To test:
No testing needed, just have a look at the diff and see that
it makes sense to delete the warn.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14361] koha-restart-zebra fails and probably breaks upgrade

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14361

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #40234|0   |1
is obsolete||

--- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 40235
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40235action=edit
Bug 14361: koha-restart-zebra fails and probably breaks upgrade

This patch fixes the koha-restart-zebra and koha-stop-zebra scripts
by adding pidfiles folder to the test is_zebra_running.
It also adds pidfiles to the test is_indexer_running so that
koha-rebuild-zebra will work properly.

Test plan:
1) check if zebrasrv is running, get pid of zebrasrv
   ps ax | grep zebrasrv
2) In my case, there was also a warning on the about.pl page on a fresh
   install: Error message from Zebra: 1011 (bad credentials)
3) try to restart zebra
   koha-restart-zebra instancename
   You will get a msg :
   Zebra does not appear to have been running for instancename
   Starting Zebra server for instancename
4) check again if zebrasrv is running
ps ax | grep zebrasrv
   and see that pid has not changed, thus it is not restarted
5) Apply patch
6) repeat 4) and watch now how pid has changed
   If there was a warning on about.pl it should now be gone

Signed-off-by: Mason James m...@kohaaloha.com
Signed-off-by: Tomas Cohen Arazi tomasco...@theke.io
Good catch Benjamin! It works as expected with the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

   Assignee|simith.dolive...@inlibro.co |maxime.beaul...@inlibro.com
   |m   |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

   Assignee|simith.dolive...@inlibro.co |maxime.beaul...@inlibro.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14401] Zebra index configuration doesn't allow exact search for 'C.'

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14401

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

  Attachment #40238|0   |1
is obsolete||

--- Comment #2 from Indranil Das Gupta indr...@gmail.com ---
Created attachment 40243
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40243action=edit
Bug 14401: Zebra index configuration doesn't allow exact search for C.

2 lines in the Zebra configuration files prevent an exact search for C.,
while all other [A-Z]. searches work correctly.

After taking a look at the  /etc/zebradb/etc/word-phrase-utf.chr
those 2 lines cause the problem:

map (^c\.)  @
map (^C\.)  @

I propose to remove them.

To test:
- Catalog a record with an item with callnumber: C.
- Catalog a record with an item with callnumber: B.
- Try seaching for the second using callnum,ext:B. (exact field search)
  - Verify search works.
- Try searching for the other with callnum,ext:C.
  - Verify no result.
- Apply the patch - copy the zebra config file if necessary into the right spot
- Reindex
- Repeat searches - both should not bring up the correct record.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14403] Remove unconditional warn from Koha::NorwegianPatronDB

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14403

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8643] Add important constraint to marc subfields

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #40232|0   |1
is obsolete||

--- Comment #10 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40237
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40237action=edit
Bug 8643 - Add important constraint to marc subfields

This fix permits to add an Important option to the marc structure pages.

Testing:

I Apply the patch
II Run updatedatabase.pl

0) Define 100 as an important field ( Administration » MARC bibliographic
framework » MARC structure ( Default Frameword) » Edit )
1) Define 100$a as an important subfield (Administration » MARC bibliographic
framework » MARC structure (Default Frameword) » Subfield » Onglet a)
2) Edit a record to clear the field 100
3) Save the record.
4) Validate the following message:

A few important fields are not filled:

* tag 100 subfield a Nom de personne in tab
* Field 100 is important, at least one of its subfields should be filled.

Are you sure you want to save?

sponsored by the CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14350] Missing statement in kohastructure.sql - DROP TABLE IF EXISTS borrower_sync;

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14350

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8643] Add important constraint to marc subfields

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #11 from M. Tompsett mtomp...@hotmail.com ---
Sorry, the Authorized Dropdown is HASH now. I'll attempt to fix later, unless
simith.dolive...@inlibro.com wants to post a rebase. That would make everyone
happy. I dislike Patch doesn't apply. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14351] Remove given-when from opac-search.pl

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155

Alex Arnaud alex.arn...@biblibre.com changed:

   What|Removed |Added

  Attachment #40208|0   |1
is obsolete||

--- Comment #13 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 40240
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40240action=edit
(fix typo) AddBiblio call in Reserves.t

Fix for the typo, it read :

my ($broken_id, $title, $bibitemnum) = AddBiblio($miniaturist, '');

it should read :

my ($broken_id, $title, $bibitemnum) = AddBiblio($broken, '');

Signed-off-by: Alex Arnaud (Biblibre) alex.arn...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155

Alex Arnaud alex.arn...@biblibre.com changed:

   What|Removed |Added

  Attachment #40239|0   |1
is obsolete||

--- Comment #14 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 40241
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40241action=edit
(qa followup) variable declaration and cleanup

1/ running koha qa tools showed up valid FAIL. This patch fix
   that error.

   FAILt/db_dependent/Reserves.t
 OK   critic
 OK   forbidden patterns
 OK   pod
 FAIL  valid
my variable $title masks earlier declaration in same scope
my variable $bibitemnum masks earlier declaration in same scope

2/ the following redundant line was removed as it had no use:

   t::lib::Mocks::mock_preference('maxreserves', 15);

Signed-off-by: Alex Arnaud (Biblibre) alex.arn...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14361] koha-restart-zebra fails and probably breaks upgrade

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14361

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

   Keywords||rel_3_16_candidate,
   ||rel_3_18_candidate

--- Comment #7 from Mason James m...@kohaaloha.com ---
This patch needs to be pulled to 3.16, 3.18 and 3.20 branches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13966] Backport HEA to Koha 3.16 and/or 3.14

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

Version|master  |3.16
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8643] Add important constraint to marc subfields

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

   Assignee|simith.dolive...@inlibro.co |maxime.beaul...@inlibro.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14403] Remove unconditional warn from Koha::NorwegianPatronDB

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14403

Magnus Enger mag...@libriotech.no changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14361] koha-restart-zebra fails and probably breaks upgrade

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14361

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

  Attachment #39984|0   |1
is obsolete||

--- Comment #4 from Mason James m...@kohaaloha.com ---
Created attachment 40234
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40234action=edit
Bug 14361 - koha-restart-zebra fails and probably breaks upgrade

This patch fixes the koha-restart-zebra and koha-stop-zebra scripts
by adding pidfiles folder to the test is_zebra_running.
It also adds pidfiles to the test is_indexer_running so that
koha-rebuild-zebra will work properly.

Test plan:
1) check if zebrasrv is running, get pid of zebrasrv
   ps ax | grep zebrasrv
2) In my case, there was also a warning on the about.pl page on a fresh
   install: Error message from Zebra: 1011 (bad credentials)
3) try to restart zebra
   koha-restart-zebra instancename
   You will get a msg :
   Zebra does not appear to have been running for instancename
   Starting Zebra server for instancename
4) check again if zebrasrv is running
ps ax | grep zebrasrv
   and see that pid has not changed, thus it is not restarted
5) Apply patch
6) repeat 4) and watch now how pid has changed
   If there was a warning on about.pl it should now be gone

Signed-off-by: Mason James m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14401] Zebra index configuration doesn't allow exact search for 'C.'

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14401

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 40238
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40238action=edit
Bug 14401: Zebra index configuration doesn't allow exact search for C.

2 lines in the Zebra configuration files prevent an exact search for C.,
while all other [A-Z]. searches work correctly.

After taking a look at the  /etc/zebradb/etc/word-phrase-utf.chr
those 2 lines cause the problem:

map (^c\.)  @
map (^C\.)  @

I propose to remove them.

To test:
- Catalog a record with an item with callnumber: C.
- Catalog a record with an item with callnumber: B.
- Try seaching for the second using callnum,ext:B. (exact field search)
  - Verify search works.
- Try searching for the other with callnum,ext:C.
  - Verify no result.
- Apply the patch - copy the zebra config file if necessary into the right spot
- Reindex
- Repeat searches - both should not bring up the correct record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14401] Zebra index configuration doesn't allow exact search for 'C.'

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14401

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14070] Notice not saved when mandatory fields are not filled

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14070

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #12 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6968] Show items expired before today in check expiration of serials page

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

   Assignee|charles.far...@inlibro.com  |maxime.beaul...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155

Alex Arnaud alex.arn...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons

2015-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >