[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #15 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- % more /etc/debian_version jessie/sid % perl --version | grep version This is perl 5, version 20, subversion 2 (v5.20.2) built for i586-linux-gnu-thread-multi-64int % git reset --hard origin/master % prove t/db_dependent/Auth_with_cas.t t/db_dependent/Auth_with_cas.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.96 cusr 0.02 csys = 1.00 CPU) Result: PASS No warn here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14498] uri_escape error triggered by duplicate accountno's for patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- 2) Edit the accountno's for those fines and set them to 0 I suppose you mean by editing the row in DB using the sql CLI? Do you have an idea how it's possible to generate 2 rows with the same accountno for the same patron? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #48 from Tomás Cohen Arazi tomasco...@gmail.com --- Maybe we should add an option to control this on the YAML configuration for OAI sets, so it is set-specific. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508
--- Comment #5 from Marc Véron ve...@veron.ch ---
Created attachment 40887
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40887action=edit
[Signed-off] Bug 14508: 'New patron' dropdown empty list on circulation.pl
This patch makes includes/patron-toolbar.inc (the one in charge of
rendering the 'New patron' dropdown) make use of the Categories
Template Toolkit plugin to create the list of categories.
(1) To check the setup is sane:
- Go to the Patrons page
= SUCCESS: The 'New patron' dropdown is populated
- Click on the [+] symbol on the Patron search on the top
= SUCCESS: The Categories dropdown is populated
(2) To test the patch:
- On the checkout form, perform a patron search that
(a) returns more than one result
(b) returns zero results
- Click the dropdown menu to create a new patron
= FAIL: Dropdown is empty
- Repeat for (a) or (b)
- Apply the patch and reload
= SUCCESS: The dropdown is correctly populated
- Repeat (1)
= SUCCESS: Nothing got broken
- Verify the logs
= SUCCESS: No new warnings
- Sign off :-D
- Get a cookie
- Smile
Regards
Discussion: we might need a new bug to start cleaning stuff like this:
@categories=C4::Category-all;
if(scalar(@categories) 1){
$no_add = 1;
$template-param(no_categories = 1);
}
else {
$template-param(categories=\@categories);
}
but it belongs to a new bug me thinks. Well, suggestions are welcome, but this
must
be fixed on stable ASAP so hurry :-D
Followed test plan, works as expected.
Signed-off-by: Marc Véron ve...@veron.ch
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508
Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:
What|Removed |Added
Attachment #40887|0 |1
is obsolete||
--- Comment #6 from Jonathan Druart jonathan.dru...@bugs.koha-community.org
---
Created attachment 40891
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40891action=edit
Bug 14508: 'New patron' dropdown empty list on circulation.pl
This patch makes includes/patron-toolbar.inc (the one in charge of
rendering the 'New patron' dropdown) make use of the Categories
Template Toolkit plugin to create the list of categories.
(1) To check the setup is sane:
- Go to the Patrons page
= SUCCESS: The 'New patron' dropdown is populated
- Click on the [+] symbol on the Patron search on the top
= SUCCESS: The Categories dropdown is populated
(2) To test the patch:
- On the checkout form, perform a patron search that
(a) returns more than one result
(b) returns zero results
- Click the dropdown menu to create a new patron
= FAIL: Dropdown is empty
- Repeat for (a) or (b)
- Apply the patch and reload
= SUCCESS: The dropdown is correctly populated
- Repeat (1)
= SUCCESS: Nothing got broken
- Verify the logs
= SUCCESS: No new warnings
- Sign off :-D
- Get a cookie
- Smile
Regards
Discussion: we might need a new bug to start cleaning stuff like this:
@categories=C4::Category-all;
if(scalar(@categories) 1){
$no_add = 1;
$template-param(no_categories = 1);
}
else {
$template-param(categories=\@categories);
}
but it belongs to a new bug me thinks. Well, suggestions are welcome, but this
must
be fixed on stable ASAP so hurry :-D
Followed test plan, works as expected.
Signed-off-by: Marc Véron ve...@veron.ch
Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7380] Can't filter patron search on detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Blocks||14508 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #19 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40892 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40892action=edit Bug 13517 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #40892|0 |1 is obsolete|| --- Comment #20 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40893 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40893action=edit Bug 13517 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #17 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- I suppose it comes from this line: 217 $uri_params_part .= URI::Escape::uri_escape( $query-param($_) ); Could you confirm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #40885|0 |1
is obsolete||
--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 40886
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40886action=edit
Bug 14512 - Add support for AV field to Koha's SIP2 Server
Koha's SIP2 server should have support for the AV field ( field items ).
The biggest problem with this field is that its' contents are not really
defined in SIP2 protocol specification. All it says is this field
should be sent for each fine item. Due to this, I think the contents of
the field need to be configurable at the login level, so that the
contents can be defined based on the SIP2 devices requirements for the
AV field.
Test Plan:
1) Apply this patch
2) Find a patron with outstanding fines
3) Run a patron information request using misc/sip_cli_emulator.pl using the
new -s option with the valueY
4) Note there is an AV field for each fee containing the description and amount
5) Edit your sip config, add an av_field_template parameter to the login you
are using such as
av_field_template=TEST [% accountline.description %] [%
accountline.amountoutstanding | format('%.2f') %]
6) Restart your SIP server
7) Repeat the patron information request
8) Note your custom AV field is being used!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #47 from Gaetan Boisson gaetan.bois...@biblibre.com --- This is a change in behaviour. People might have built things assuming the item data is not there and might suddenly expose more data, than they wanted to. I agree but they will still be exposing this data, even if they switch it off for OAI, through the marc view, the marc downloads, etc. It's true i think we have enough sysprefs, but especially here, i feel we will add one to do something that can already be achieved using extended mode, and that it will only very partially fix an issue we have in a lot of other places. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #37873|0 |1 is obsolete|| --- Comment #143 from Marc Véron ve...@veron.ch --- Created attachment 40894 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40894action=edit Bug 13813 - Remove C4::Dates from circ/circ/transferstoreceive.pl To test: Go to Home Circulation Transfers to your library (Circulation Reports - Transfers to receive) Verify that date in page title appears correcty Amendend following comment #58 /MV Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com It ssemed that the amendent did not work out. Amended again following comment #58 / MV -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13881] Add desk management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881
Nicolas Legrand nicolas.legr...@bulac.fr changed:
What|Removed |Added
Attachment #40569|0 |1
is obsolete||
--- Comment #11 from Nicolas Legrand nicolas.legr...@bulac.fr ---
Comment on attachment 40569
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40569
Bug 13881: attach a reserve to a desk
From 61e00bd675d86d6f3f3f6590c0ad403e19e2a1e0 Mon Sep 17 00:00:00 2001
From: Nicolas Legrand nicolas.legr...@bulac.fr
Date: Wed, 24 Jun 2015 12:20:27 +0200
Subject: [PATCH] Bug 13881: attach a reserve to a desk
In the intranet, if desks are defined, a librarian can set her desk as
she sets her branch. If the desk is set, and she checks in an items on
which a patron made a hold, the desk deskcode is attached to the
reserve and can be viewed in the Holds awaiting pickup circulation
report.
Test plan:
Set a desk, put a book on hold, check it in, confirm hold, it should
appear in the holds awaiting pickup circulation page, it should
appear as waiting at the desk on the patron's session.
---
C4/Auth.pm | 32 ++--
C4/Reserves.pm | 20 ++--
circ/returns.pl|3 +-
circ/waitingreserves.pl|9 ++
.../bug_138881_link_desk_to_reserves.sql | 10 ++
installer/data/mysql/kohastructure.sql |6 +++-
.../prog/en/modules/circ/waitingreserves.tt|6
.../opac-tmpl/bootstrap/en/modules/opac-user.tt|2 +-
opac/opac-user.pl |7 +
9 files changed, 73 insertions(+), 22 deletions(-)
create mode 100644
installer/data/mysql/atomicupdate/bug_138881_link_desk_to_reserves.sql
diff --git a/C4/Auth.pm b/C4/Auth.pm
index 5cd5823..2dd92d5 100644
--- a/C4/Auth.pm
+++ b/C4/Auth.pm
@@ -392,21 +392,6 @@ sub get_template_and_user {
persona= C4::Context-preference(persona),
OPACBaseURL= C4::Context-preference('OPACBaseURL'),
);
-if (C4::Context-userenv-{branch}) {
-my $desksaref = GetDesks(C4::Context-userenv-{branch});
-if ($#$desksaref -1) {
-$template-param(
-LoginDeskcode = ( C4::Context-userenv ?
C4::Context-userenv-{deskcode}: undef ),
-LoginDeskname = ( C4::Context-userenv ?
C4::Context-userenv-{deskname}: undef ),
-HasDesk = (1),
-);
-}
-else {
-$template-param(
-HasDesk = (undef),
-);
-}
-}
if ( $in-{'type'} eq intranet ) {
$template-param(
AmazonCoverImages
= C4::Context-preference(AmazonCoverImages),
@@ -441,7 +426,22 @@ sub get_template_and_user {
UseKohaPlugins
= C4::Context-preference('UseKohaPlugins'),
UseCourseReserves
= C4::Context-preference(UseCourseReserves),
useDischarge
= C4::Context-preference('useDischarge'),
-);
+);
+if ( C4::Context-userenv ? C4::Context-userenv-{branch} : undef)
{
+my $desksaref = GetDesks(C4::Context-userenv-{branch});
+if ($#$desksaref -1) {
+$template-param(
+ LoginDeskcode = (
C4::Context-userenv-{deskcode} ),
+ LoginDeskname = (
C4::Context-userenv-{deskname} ),
+ HasDesk = (1),
+);
+}
+else {
+$template-param(
+ HasDesk = ( undef ),
+);
+}
+}
}
else {
warn template type should be OPAC, here it is=[ . $in-{'type'} .
] unless ( $in-{'type'} eq 'opac' );
diff --git a/C4/Reserves.pm b/C4/Reserves.pm
index 9c760b6..9a43585 100644
--- a/C4/Reserves.pm
+++ b/C4/Reserves.pm
@@ -843,7 +843,7 @@ sub GetReservesForBranch {
my $dbh = C4::Context-dbh;
my $query =
-SELECT reserve_id,borrowernumber,reservedate,itemnumber,waitingdate
+SELECT reserve_id,borrowernumber,reservedate,itemnumber,waitingdate,
deskcode
FROM reserves
WHERE priority='0'
AND found='W'
@@ -1353,7 +1353,7 @@ sub ModReserveStatus {
=head2 ModReserveAffect
- ModReserveAffect($itemnumber,$borrowernumber,$diffBranchSend);
+
[Koha-bugs] [Bug 13881] Add desk management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand nicolas.legr...@bulac.fr changed: What|Removed |Added Attachment #40709|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13881] Add desk management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand nicolas.legr...@bulac.fr changed: What|Removed |Added Attachment #39837|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #16 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- % pmvers CGI 3.65 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512
--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 40885
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40885action=edit
Bug 14512 - Add support for AV field to Koha's SIP2 Server
Koha's SIP2 server should have support for the AV field ( field items ).
The biggest problem with this field is that its' contents are not really
defined in SIP2 protocol specification. All it says is this field
should be sent for each fine item. Due to this, I think the contents of
the field need to be configurable at the login level, so that the
contents can be defined based on the SIP2 devices requirements for the
AV field.
Test Plan:
1) Apply this patch
2) Find a patron with outstanding fines
3) Run a patron information request using misc/sip_cli_emulator.pl using the
new -s option with the valueY
4) Note there is an AV field for each fee containing the description and amount
5) Edit your sip config, add an av_field_template parameter to the login you
are using such as
av_field_template=TEST [% accountline.description %] [%
accountline.amountoutstanding | format('%.2f') %]
6) Restart your SIP server
7) Repeat the patron information request
8) Note your custom AV field is being used!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13881] Add desk management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 --- Comment #10 from Nicolas Legrand nicolas.legr...@bulac.fr --- Created attachment 40895 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40895action=edit Bug 13881: Add desk management Desks can be created for a branch. If a librarian sets a desk in the intranet and check in a document on hold, the document is then attached to a desk. Test plan, basic desk creation/modification/deletion: 1/ perl installer/data/mysql/updatedatabase.pl (create new table desks) 2/ prove t/db_dependent/Desks.t 3/ go to admin page, click on desk management, try to create, modify and delete desks Test plan, setting desk in the intranet: 1/ Go to the intranet administration, remove all desks if you have any. The desks should not appear in the header. 2/ add some desks in administration, without selecting some. The message « NO DESK SET » should appear at the left of the branchname. 3/ set a desk for your session. The desk deskcode should appear beside the branchname. 4/ change desk, the new name should appear also. Test plan, attach holds awaiting pickup to a desk: Set a desk, put a book on hold, check it in, confirm hold, it should appear in the holds awaiting pickup circulation page, it should appear as waiting at the desk on the patron's session. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #38 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Kyle, 1/ You propose a --test option to the script, but I think the test behavior should be the default and --confirm should sent the job to the printer, don't you think? 2/ Please avoid sql queries in pl scripts. 3/ You should also address Bernardo's concern. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2735] authority search stops at 15 pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- This is fixed: Authority search results 1 2 3 ... 204 Results 1 to 20 of 4066 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch Attachment #40850|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14506] barcode printing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14506 Pedro Ferreira pedro.m.ferre...@mail.cm-portel.pt changed: What|Removed |Added CC||pedro.m.ferre...@mail.cm-po ||rtel.pt --- Comment #1 from Pedro Ferreira pedro.m.ferre...@mail.cm-portel.pt --- Created attachment 40888 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40888action=edit two C4/Labels : version 3.12 and version 3.20 With C4/Labels/Label.pm from version 3.12 i can print labels. With C4/Labels/Label.pm from version 3.20.X label printing does not work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch Attachment #40829|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14512] New: Add support for AV field to Koha's SIP2 Server
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512 Bug ID: 14512 Summary: Add support for AV field to Koha's SIP2 Server Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Koha's SIP2 server should have support for the AV field ( field items ). The biggest problem with this field is that its' contents are not really defined in SIP2 protocol specification. All it says is this field should be sent for each fine item. Due to this, I think the contents of the field need to be configurable at the login level, so that the contents can be defined based on the SIP2 devices requirements for the AV field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464
--- Comment #6 from Jesse Weaver jwea...@bywatersolutions.com ---
(In reply to Jonathan Druart from comment #5)
Comment on attachment 40752 [details] [review]
Bug 14464 - Add ability to cancel waiting holds from checkin screen
Review of attachment 40752 [details] [review]:
-
::: circ/returns.pl
@@ +30,5 @@
use strict;
use warnings;
+use Carp 'verbose';
+$SIG{ __DIE__ } = sub { Carp::confess( @_ ) };
Why do you need that?
... because I forgot to remove some debugging code, apologies. That's safe to
remove.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #25 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Jonathan Druart from comment #21) Ok, let's consider it comes from my DB. I think it's better to know if a bug exists somewhere else, instead of adding useless tests in this (already messy) script. But, dear RM, don't push it just before the release :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #21 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- So... I was passing qa on this one (I promise!) and, during my last test, I have found a waiting reserve in my DB without itemnumber (??) Which makes the script explodes: Can't call method holdingbranch on an undefined value at /home/koha/src/reserve/request.pl line 488. It's an old data and a DB I used to test, so maybe this case is impossible to reach reserve_id: 2051 borrowernumber: 7781 reservedate: 2011-08-19 biblionumber: 4934 constrainttype: a branchcode: MAURES notificationdate: NULL reminderdate: NULL cancellationdate: NULL reservenotes: priority: 0 found: W timestamp: 2015-04-28 16:41:22 itemnumber: NULL waitingdate: 2015-04-28 expirationdate: NULL lowestPriority: 0 suspend: 0 suspend_until: NULL Sorry I don't remember what I did on April 28th :) I don't really know what to do, we could let the code as it, and see if someone report the issue. Or add an existing test on the item. What do you prefer? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #18 from M. Tompsett mtomp...@hotmail.com --- (In reply to Jonathan Druart from comment #17) I suppose it comes from this line: 217 $uri_params_part .= URI::Escape::uri_escape( $query-param($_) ); Could you confirm? Yes, the other change is an optimization. It's faster to access a variable than function call twice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Attachment #40676|0 |1 is obsolete|| Attachment #40677|0 |1 is obsolete|| Attachment #40893|0 |1 is obsolete|| --- Comment #22 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 40898 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40898action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl In addition, if the ReservesMaxPickUpDelay syspref is set, we should display the date when the waiting hold expires. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Find a waiting hold 4) Browse to reserve/request.pl for that record 5) Notice the Item waiting message now has since waitingdate 6) Notice the expiration field now has the date of waitingdate + 7 days Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Cathi Wiggins cwigg...@ci.arcadia.ca.us Signed-off-by: Megan Wianecki mwiane...@mplmain.mtpl.org Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #23 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 40899 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40899action=edit Bug 13517 [QA Followup] - Add unit tests Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14511] Allow zebra search for MARC 027 tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14511 --- Comment #2 from Amit Gupta amitddng...@gmail.com --- so what are you proposing to do here? Giving option to search Standard technical report number in both OPAC advance search and Staff search i.e 027$a -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #24 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 40900 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40900action=edit Bug 13517 [QA Followup] - Fix unit tests Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #19 from M. Tompsett mtomp...@hotmail.com --- mtompset@debian:~/kohaclone$ cat /etc/debian_version 8.1 mtompset@debian:~/kohaclone$ perl --version | grep version This is perl 5, version 20, subversion 2 (v5.20.2) built for x86_64-linux-gnu-thread-multi mtompset@debian:~/kohaclone$ git reset --hard origin/master HEAD is now at 6e9086f Bug 3206: (QA followup) missing comma on sysprefs.sql mtompset@debian:~/kohaclone$ prove t/db_dependent/Auth_with_cas.t t/db_dependent/Auth_with_cas.t .. 1/4 CGI::param called in list context from package C4::Auth_with_cas line 217, this can lead to vulnerabilities. See the warning in Fetching the value or values of a single named parameter at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package C4::Auth_with_cas line 217, this can lead to vulnerabilities. See the warning in Fetching the value or values of a single named parameter at /usr/share/perl5/CGI.pm line 436. t/db_dependent/Auth_with_cas.t .. ok All tests successful. Files=1, Tests=4, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.67 cusr 0.01 csys = 0.70 CPU) Result: PASS mtompset@debian:~/kohaclone$ pmvers CGI 4.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14514] New: LocalHoldsPriority and the HoldsQueue conflict with each other
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Bug ID: 14514 Summary: LocalHoldsPriority and the HoldsQueue conflict with each other Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com It appears that the LocalHoldsPriority feature and the Holds Queue are fundamentally at odds with each other. The problem appears to be that both are attempting to choose the best way to fill holds. When you are using the holds queue and you check in an item that has been selected by the holds queue builder, that part of Koha where the LocalHoldsPriority feature lives doesn't get to see all the holds in order to pick the best one. Instead only the hold selected by the holds queue builder is returned so to the LocalHoldsPriority feature, that is only one hold to pick from! The solution *may* be to add the similar logic that appears C4::Reserves::CheckReserves for handling local hold priority to C4::HoldsQueue::MapItemsToHoldRequests at the very beginning before it even attempts to match item level requests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14513] New: keep track of patron last activity
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14513 Bug ID: 14513 Summary: keep track of patron last activity Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, jsa...@plumcreeklibrary.net, kyle.m.h...@gmail.com, n...@quecheelibrary.org It would be nice if there was a way on the patron record to see the date of their last activity - their last checkout, renewal, return - like there is on the items with date last seen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Juan Romay Sieira juan.sie...@xercode.es changed: What|Removed |Added CC||juan.sie...@xercode.es --- Comment #62 from Juan Romay Sieira juan.sie...@xercode.es --- I'm testing ES. My problem is that Koha is always trying to connect to localhost:9200, but my koha-conf.xml has: elasticsearch server192.168.0.213:9200/server index_namecore/index_name /elasticsearch my instance of ES it not in localhost. Do I have to do something to force to connect to 192.168.0.213 and not to localhost? This is the error: [NoNodes] ** No nodes are available: [http://localhost:9200], called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/local/share/perl/5.10.1/Catmandu/Store/ElasticSearch.pm line 61 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Blocks||13924 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13924] LocalHoldsPriority needs dateaccessioned limits.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13924 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Depends on||12632 CC||k...@bywatersolutions.com --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- I imagine a good solution would be to move the LocalHoldsPriority settings to the circulation rules. That way you could give new items a different itemtype than older items such that the new items honor LocalHoldsPriority and the older items do not. This would only work if bug 12632 is a dependency. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14428] Remove C4::Input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Summary|use dbh directly, not |Remove C4::Input |C4::Context-prepare| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14428] Remove C4::Input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 --- Comment #1 from M. Tompsett mtomp...@hotmail.com --- After discussing on mailing list a little, and with no objections, it seems that C4/Input.pm is beyond its useful days. This bug has been repurposed to remove it, rather than correct the C4::Context-prepare autoload mess. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14428] Remove C4::Input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428
--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40906
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40906action=edit
Bug 14428: Remove C4::Input
Jonathan Druart agreed that C4::Input is vestigial code that should be removed.
Here is how I checked. First I found where C4::Input was used. Then, I checked
what functions are in the package: just checkdigit. Then, I confirmed that
checkdigit is not used at all in any acquisition, administration, or member
related perl scripts. Lastly, I took a look at our supposed test file for the
package. It was painfully sparse.
As such, this patch removes the test file and the package file, and removes
C4::Input references from these six files:
- acqui/addorderiso2709.pl
- acqui/basketgroup.pl
- acqui/neworderempty.pl
- acqui/uncertainprice.pl
- admin/aqplan.pl
- members/memberentry.pl
NOTE: neworderempty had 3 lines of it?! Didn't anyone see that?!
Here is the output of what I did to confirm this correction:
mtompset@debian:~/kohaclone$ git reset --hard origin/master
HEAD is now at 6e9086f Bug 3206: (QA followup) missing comma on sysprefs.sql
mtompset@debian:~/kohaclone$ git grep C4::Input
C4/Input.pm:package C4::Input; #assumes C4/Input
C4/Input.pm:C4::Input - Miscellaneous sanity checks
C4/Input.pm: use C4::Input;
acqui/addorderiso2709.pl:use C4::Input;
acqui/basketgroup.pl:use C4::Input;
acqui/neworderempty.pl:use C4::Input;
acqui/neworderempty.pl:use C4::Input;
acqui/neworderempty.pl:use C4::Input;
acqui/uncertainprice.pl:use C4::Input;
admin/aqplan.pl:use C4::Input;
members/memberentry.pl:use C4::Input;
t/Input.t:use_ok('C4::Input');
mtompset@debian:~/kohaclone$ grep sub C4/Input.pm
sub checkdigit ($;$) {
my $temp2 = substr($infl,$i,1);
if ($rem eq substr($infl,8,1)) {
} # sub checkdigit
mtompset@debian:~/kohaclone$ grep checkdigit `find acqui -type f`
mtompset@debian:~/kohaclone$ grep checkdigit `find admin -type f`
mtompset@debian:~/kohaclone$ grep checkdigit `find members -type f`
mtompset@debian:~/kohaclone$ cat t/Input.t
use strict;
use warnings;
use Test::More tests = 1;
BEGIN {
use_ok('C4::Input');
}
Apply this patch, and the output of git grep C4::Input will be empty.
Run koha qa test tools (kind of overkill)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14428] Remove C4::Input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14428] Remove C4::Input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks||9006 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9006 [Bug 9006] autoload in C4::Context is a bad idea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9006] autoload in C4::Context is a bad idea
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9006 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |BLOCKED Depends on||14428 --- Comment #7 from M. Tompsett mtomp...@hotmail.com --- Setting this to depends on 14428, because 14428 removes the one non-intranetdir autoload by removing C4::Input (good bye, crud!). Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 [Bug 14428] Remove C4::Input -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14428] Remove C4::Input
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428
--- Comment #2 from M. Tompsett mtomp...@hotmail.com ---
mtompset@debian:~/kohaclone$ git reset --hard origin/master
HEAD is now at 6e9086f Bug 3206: (QA followup) missing comma on sysprefs.sql
mtompset@debian:~/kohaclone$ git grep C4::Input
C4/Input.pm:package C4::Input; #assumes C4/Input
C4/Input.pm:C4::Input - Miscellaneous sanity checks
C4/Input.pm: use C4::Input;
acqui/addorderiso2709.pl:use C4::Input;
acqui/basketgroup.pl:use C4::Input;
acqui/neworderempty.pl:use C4::Input;
acqui/neworderempty.pl:use C4::Input;
acqui/neworderempty.pl:use C4::Input;
acqui/uncertainprice.pl:use C4::Input;
admin/aqplan.pl:use C4::Input;
members/memberentry.pl:use C4::Input;
t/Input.t:use_ok('C4::Input');
mtompset@debian:~/kohaclone$ grep sub C4/Input.pm
sub checkdigit ($;$) {
my $temp2 = substr($infl,$i,1);
if ($rem eq substr($infl,8,1)) {
} # sub checkdigit
mtompset@debian:~/kohaclone$ grep checkdigit `find acqui -type f`
mtompset@debian:~/kohaclone$ grep checkdigit `find admin -type f`
mtompset@debian:~/kohaclone$ grep checkdigit `find members -type f`
mtompset@debian:~/kohaclone$ cat t/Input.t
#!/usr/bin/perl
#
# This Koha test module is a stub!
# Add more tests here!!!
use strict;
use warnings;
use Test::More tests = 1;
BEGIN {
use_ok('C4::Input');
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 40904 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40904action=edit Sample broken lists (es-ES) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 --- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 40905 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40905action=edit Sample working lists (en) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #158 from Chris Cormack ch...@bigballofwax.co.nz --- testing upgraded bugzilla --- Comment #159 from Chris Cormack ch...@bigballofwax.co.nz --- test 2 --- Comment #160 from Chris Cormack ch...@bigballofwax.co.nz --- test 2 --- Comment #161 from Chris Cormack ch...@bigballofwax.co.nz --- test 2 --- Comment #162 from Chris Cormack ch...@bigballofwax.co.nz --- test 2 --- Comment #163 from Chris Cormack ch...@bigballofwax.co.nz --- test 2 --- Comment #164 from Chris Cormack ch...@bigballofwax.co.nz --- test 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14517] New: Private lists browsing broken in translated staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517
Bug ID: 14517
Summary: Private lists browsing broken in translated staff
interface
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Lists
Assignee: gmcha...@gmail.com
Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
This bug affects (at least) master and 3.20.x.
To reproduce:
- On the staff interface create a private list
- Go to More Lists ('Your lists' tab)
= SUCCESS: Your private list is shown.
- Translate the templates to any language like:
$ cd misc/translator/
$ perl translate install es-ES
- Enable the translated templates on the sysprefs
- Switch to the translated language
- Go to the lists page (Mas Listas in es-ES)
= FAIL: The datatable hangs waiting for the svc/shelves script to return data
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14356] Improvements to the 'Transfers to receive' page (branchname, mailto link)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14356 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Pushed to Master|Pushed to Stable --- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Aleisha Amohia from comment #6) (In reply to Jonathan Druart from comment #5) This is wrong, we want to display the length of the content. With your patch, the string displayed is always Message body: 0/160 characters Hi Jonathan, this tests correctly for me, but do you know a better way to silence this warn? You should have used letter.content.length. I have amended your 2 patches, please have a look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #40789|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40858 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40858action=edit Bug 14485 - HTML comment disables translation in cataloguing/addbooks.tt In cataloguing/addbooks.tt, the line : [% total %] result(s) found in catalog, is not present in PO files even after an update. I've found that the cause is the previous HTML comment line. This patch converts HTML comment into TT comment and adds a div to have a more comprehensive string to translate. Test plan : - without patch - go into sources/misc/translator - run PO update for example in french : translate update fr-FR = the text result(s) found in catalog is missing from PO file : fr-FR-staff-prog.po - restore default PO files - apply patch - go into sources/misc/translator - run PO update for example in french : translate update fr-FR = You find text result(s) found in catalog in PO file : fr-FR-staff-prog.po Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Eduardo Castro Avalos hector.hecax...@gmail.com Works as advertised. Just one msgid appear with msgid %s result(s) found in catalog, Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #14 from Chris Cormack ch...@bigballofwax.co.nz --- The rule for developing on Koha is that we don't change behaviour that people will have been using for years. (The specify due date feature is about 8 years old, so suddenly changing the way it works will most definitely catch some people out) The reason we have this rule is so people won't be scared to upgrade (it's also the rule why new features go in switched off by default on upgrade) Hope this makes sense -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime-new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime-new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40860 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40860action=edit Bug 14494: Prevent slow checkout if the patron does not have an expiry date If a patron has a expiry date set to -12-31 (for organizations for instance), the checkouts are very slow. It's caused by 2 different calls to DateTime in CanBookBeIssued: 1/ DateTime-new( year = , month = 12, day = 31, time_zone = C4::Context-tz ); The time_zone should not be set (as it's done in Koha::DateUtils), set to UTC or floating tz. 2/ DateTime-compare($today, $expiry_dt) The comparaison of 2 DT with 1 related to is very slow, as you can imagine. For 1/ we need to call Koha::DateUtils::dt_from_string (actually, we should never call DateTime directly). For 2/ we just need to test if the date is != , no need to compare it in this case. Test plan: Before this patch, confirm that the checkouts are slow if the patron has a dateexpiry set to -12-31. update borrowers set dateexpiry=-12-31 where borrowernumber=42; After this patch, you should not see any regression when checking out items to an expired patron and to a valid patron. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime-new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||14197 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Depends on||14494 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Jonathan Druart from comment #1) To see the warning see patches on bug 14045. And the errors with the patch on bug 14494. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime-new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, I feel a bit like this builds in a secret feature - if I use 9998 it will be slow, but if I use it will be faster? When we fixed the same thing for debarments it made more sense, as the 'ulimited' debarment uses automatically, without the user entering a date. For the patron expiry the date is defined by the library and could be anything. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime-new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #40873|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 40874 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40874action=edit Bug 14494: Terribly slow checkout caused by DateTime-new in far future An expiry date like -12-31 in the local timezone will make DateTime spend a lot of time (maybe 60 seconds) on date calculation. See the DateTime documention on CPAN. A calculation in floating (or alternatively in UTC) would only take a few milliseconds. This patch makes two changes in this regard: [1] The compare between expiry date and today in CanBookBeIssued has been adjusted in Jonathan's patch. I am moving the compare to the floating timezone (as was done in my original patch). This removes a hardcoded . [2] If ReturnBeforeExpiry is enabled, CalcDateDue compares the normal due date with the expiry date. The comparison is now done in the floating timezone. If the expiry date is before the due date, it is returned in the user context's timezone. NOTE: The calls to set_time_zone moving to or from floating do not adjust the local time. TEST PLAN: First without this patch (and the one from Jonathan): [1] Set expiry date to -12-31 for a patron. [2] Enable ReturnBeforeExpiry. [3] Checkout a book to this patron. This will be (very) slow. Continue now with this patch applied: [4] Check in the same book. [5] Check it out again. Should be much faster. Bonus test: [6] Set borrower expiry date to today. Change relevant circulation rule to loan period of 21 hours. Test checking out with a manual due date /time just before today 23:59 and after that. In the second case the due date/time should become today 23:59 (note that 23:59 is not shown on the checkout form). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime-new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #12 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- not ok 49 - No items due in less than one day (0 days in advance) # Failed test 'No items due in less than one day (0 days in advance)' # at t/db_dependent/Circulation.t line 527. # got: '2' # expected: '0' Resolved this one now. The staff expiry was too quick :) Still looking now at: ok 61 - Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1339. DBIx::Class::Schema::txn_begin(): DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1339. at /home/koha/testclone/t/lib/TestBuilder.pm line 75 DBIx::Class::Schema::txn_rollback(): Storage transaction_depth 0 does not match false AutoCommit of DBI::db=HASH(0xb24823c), attempting ROLLBACK anyway at /home/koha/testclone/t/lib/TestBuilder.pm line 360 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Attachment #40695|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 40875 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40875action=edit Bug 14387 - Merge reference selection has no effect when merging authorities. This patch swaps the authority records according to the refenrece record selection. To TEST: Merge two authority records, select the second as merge reference. The reference authority is always the first. Apply the patch. Repeat previous steps, the authority is now merged using the selected reference record. modified: authorities/merge.pl Signed-off-by: Nick Clemens n...@quecheelibrary.org Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14303] Fix item search CSV export - obsolete by and display of publication year for MARC21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14303 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Attachment #40029|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 40876 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40876action=edit Bug 14303: Fix item search CSV export - obsolete by and display of publication year for MARC21 The exported CSV file from the item search didn't display the publication year in MARC21 installations and the title always contained 'by' even if there was no author information to display. Also the by is not needed by MARC21 as the data should include punctuation. This basically copies the changes done to the JSON format on bug 13859 to the CSV include. To test: Switch from 'Screen' to 'CSV' - Check publication date always displays (MARC21 and UNIMARC) - Check that for MARC21 the 'by' has been removed from the title information - Check that for UNIMARC the 'by' only displays when there is also an author to display Tested for MARC21, works as expected. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14303] Fix item search CSV export - obsolete by and display of publication year for MARC21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14303 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Attachment #40793|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 40877 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40877action=edit Bug 11693: Default emailing preferences not loaded for self registering patron The call to AddMember_Opac does not take care of the messaging prefs when enhanced messaging is enabled. This patch adds the call to handle_form_action to do that. Test plan: Enable self registering patrons and enhanced messaging. Check the (default) message prefs for the relevant patron category. At least enable email for one notice. Self-register a user with and without verification email enabled. Check in both cases that the message prefs of the user conform to those in the patron category. (So at least one enabled.) Followed test plan, works as expected. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14452] Remember if user used more/fewer options on advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14452 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- I'd tempt to remove the pref and use sessionStorage, but it won't work at the OPAC if JS is disabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14452] Remember if user used more/fewer options on advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14452 --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Thinking of our libraries there seems to be a difference in what people like to be the default - so I am not sure about removing the pref. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 --- Comment #14 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Liz Rea from comment #13) Created attachment 40505 [details] [review] Bug 12919 - perltidy and consistent sub naming Liz, could you confirm this one can leave the FQA queue? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #40545|0 |1 is obsolete|| Attachment #40743|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40856 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40856action=edit Bug 14445: Silences warn in letter.pl When changing Koha module to 'Circulation', there is a warn saying that $code is uninitialized. This patch sets $code to an empty string to silence the warn. To test: 1) Go to Tools, the Notices Slips 2) Click 'new notice' (This will trigger warns, but ignore these as they will be corrected in the next patch) 3) Change Koha module to 'Circulation' 4) Notice warn about uninitialized $code variable 5) Apply patch and reload page, change Koha module to 'Circulation' 6) Notice page still works and warns are gone Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40857 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40857action=edit Bug 14445: Silences warns in letter.tt When creating a new notice, warn is triggered Argument isn't numeric in numeric gt () at line 400. Same warn is triggered when changing Koha module option to any other module. To test: 1) Go to Tools, then Notices Slips 2) Click 'new notice'. Notice warn in intranet-error.log 3) Change Koha module to another module. Notice warn is triggered for every change 4) Apply patch and reload page 5) Change Koha module to another module. Notice there are no longer warns 6) Go back to Notices Slips and click 'new notice' again. Notice there are no warns Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Nicholas van Oudtshoorn vano...@gmail.com changed: What|Removed |Added Attachment #40852|0 |1 is obsolete|| --- Comment #8 from Nicholas van Oudtshoorn vano...@gmail.com --- Created attachment 40854 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40854action=edit Bug 14407 - Allow web-based self checkout to be limited by IP addresses/ranges (In reply to Robin in Comment #7) Brilliant, Net::CIDR has been in Debian since the dawn of time, so that makes me happier :) :-) Glad to have brought a sigh of relief! You've missed updating the use lines in sco-patron-image.pl though. D'oh! Fixed that now Also don't forget to update C4/Installer/PerlDependencies.pm (keep an eye on the version version numbers being correct, wheezy has 0.15.) Ah! Hadn't thought about that at all. Should be done now. If this patch is acceptable, would another to adjust opac-search to use Net::CIDR be a nice tidying to one standard patch? I'd make a new bug for that, it'll possibly be more complicated than you expect as it'll have to account for the possibility of the format of a syspref changing, and either correcting that in the database or accepting the old form as well as the new one. Agreed it would need a new bug. Have had a quick squiz, and it seems that NET::CIDR::range2cidr is perfectly happy with the format required by the current preference. It could, however, be changed to allow for much greater variety... (multiple subnets, individual IPs, etc.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #13 from Eivin Giske Skaaren ei...@sysmystic.com --- Obviuously I am rather new to Koha but I actually thought it was the other way. Since you have the Remember for session checkbox and also probably a default due date in the system (perhaps even on item level? have not checked/can not remember right now) I found it strange that the value was not cleared. Do we want the default behavior to be that the value is cleared only when the due date is shortened? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #45 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Tomás Cohen Arazi from comment #43) I definitely think this might not be a feature for some institutions and we should make it opt-in. Because as Galen mentioned, it is not obvious that everyone will want to include items data. I am pretty sure it's a bug and a regression introduced by bug 5579. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Jonathan Druart from comment #16) The patch removes the tables/fields if data exist (which is certainly not the case), or leave them. Hum, trying again... The patch removes the tables/fields when they don't contain any data (which is certainly the case) or keep them if they are not empty. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14388] add sorting to funds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. Tompsett from comment #2) second child, not first. Please fix typo. Fixed, thanks (In reply to M. Tompsett from comment #3) I was not able to duplicate issue with Debian Jessie on Master. Though, this patch clearly forces sorting. They are currently sorted by budget_id. Additionally, tests failed to run with my initial data set. Requires CPL. Which is the case for almost all tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14388] add sorting to funds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #40765|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40855 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40855action=edit Bug 14388: Funds should be sorted by budget_code Before this patch, the funds were sorted by budget_id, which does not make any sense. This patch adds a sort by budget_code on the fund list (acqui/acqui-home.pl and admin/aqbudgets.pl) Test plan: On both pages (acqui/acqui-home.pl and admin/aqbudgets.pl) confirm that the funds are now sorted by fund code (DB column budget_code) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime-new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime-new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks|14197 | Depends on||14197 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||14494 Depends on|14494 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40859 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40859action=edit Bug 14197: TestBuilder - Remove the error on starting the transaction DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. DBIx::Class::Storage::DBI::txn_rollback(): Storage transaction_depth 0 does not match false AutoCommit of DBI::db=HASH(0xa429648), attempting ROLLBACK anyway at t/lib/TestBuilder.pm line 363 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime-new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #2) Hm, I feel a bit like this builds in a secret feature - if I use 9998 it will be slow, but if I use it will be faster? When we fixed the same thing for debarments it made more sense, as the 'ulimited' debarment uses automatically, without the user entering a date. For the patron expiry the date is defined by the library and could be anything. As I understood the description, the feature has existed. Anyway we should call Koha::DateUtils here and not directly DateTime. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 --- Comment #28 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I have rebased the last patch hopefully correctly and fixed problems with the POD in the test file noted by the QA script. But: $ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 25/69 # Failed test 'ReturnToShelvingCart: Modifying the whole Item doesn't overwrite permanent_location!' # at t/db_dependent/Circulation.t line 684. # Failed test 'ReturnToShelvingCart: Adding a new Item with location also sets the permanent_location.'$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 25/69 # Failed test 'ReturnToShelvingCart: Modifying the whole Item doesn't overwrite permanent_location!' # at t/db_dependent/Circulation.t line 684. # Failed test 'ReturnToShelvingCart: Adding a new Item with location also sets the permanent_location.' # at t/db_dependent/Circulation.t line 704. # Looks like you failed 2 tests of 69. t/db_dependent/Circulation.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/69 subtests Test Summary Report --- t/db_dependent/Circulation.t (Wstat: 512 Tests: 69 Failed: 2) Failed tests: 67, 69 Non-zero exit status: 2 Files=1, Tests=69, 2 wallclock secs ( 0.03 usr 0.00 sys + 1.50 cusr 0.08 csys = 1.61 CPU) Result: FAIL # at t/db_dependent/Circulation.t line 704. # Looks like you failed 2 tests of 69. t/db_dependent/Circulation.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/69 subtests Test Summary Report --- t/db_dependent/Circulation.t (Wstat: 512 Tests: 69 Failed: 2) Failed tests: 67, 69 Non-zero exit status: 2 Files=1, Tests=69, 2 wallclock secs ( 0.03 usr 0.00 sys + 1.50 cusr 0.08 csys = 1.61 CPU) Result: FAIL Leaving this in Failed QA for now - but would love to see this fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Needs Signoff CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #13 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- I would like to get another signoff to confirm that the concerns raised in comment 11 are fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13881] Add desk management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |nicolas.legr...@bulac.fr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14468] Remove warnings when creating Labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #9 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Chris Nighswonger from comment #6) That all sounds good. I wish I had time to sign off! Chris, I am not confident with part of code, it would be great to get your signoff on this one :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime-new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #40881|0 |1 is obsolete|| --- Comment #17 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 40882 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40882action=edit Bug 14494: Unit test Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Moved the test on its own. Nicer than adding TestBuilder in the final part of the test. No warnings/errors from TestBuilder, no dependency.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime-new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13622] Display a datetime without time in a notice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 --- Comment #18 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Patches look ok to me on first glance, thx Indranil! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14420] bulkmarcimport.pl - Some problems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Ah, also make sure test plan and problem description are part of your commit message! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452
Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
Status|Signed Off |Failed QA
--- Comment #6 from Jonathan Druart jonathan.dru...@bugs.koha-community.org
---
I won't use the splinter review, it will be confusing.
1/ There are 2 different ways to do the same thing:
247 if ( $line=~/itemtype/ ) { $line = $itype; }
257 $linefilter[0] = @$filters[9] if ($line =~ /itemtype/ ) ;
and
263 if ( $column=~/itemtype/ ) { $column = $itype; }
274 $colfilter[0] = @$filters[9] if ($column =~ $itype ) ;
2/ Please use sql placeholders for issuingrules.itemtype=$itype (x3)
3/
if (( @colfilter ) and ($colfilter[1])){
$sth2-execute('.$colfilter[0].','.$colfilter[1].');
} elsif ($colfilter[0]) {
$sth2-execute;
} else {
$sth2-execute;
}
Could be :
if (( @colfilter ) and ($colfilter[1])){
$sth2-execute('.$colfilter[0].','.$colfilter[1].');
} else {
$sth2-execute;
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #61 from Blou philippe.blo...@inlibro.com --- All those comments are perfectly valid. I'll correct them all (the use Dumper are most probably something forgotten by the dev, no excuse). Regarding the name, which one would you prefer ITYPECAT or ITEMTYPECAT? Or a bit different: ITYPEGROUP If no response, I'll go with ITYPEGROUP (of course, I'll do a patch's patch. I'm not messing with a passed qa) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
