[Koha-bugs] [Bug 12144] Book drop mode mode erasing fine when CalculateFinesOnReturn is enabled

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12144

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14591

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12144

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13044

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14591] New: book drop / drop box mode incorrectly decrements accrued overdue fines

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591

Bug ID: 14591
   Summary: book drop / drop box mode incorrectly decrements
accrued overdue fines
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: gmcha...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Book drop mode will always subtract the lastincrement value from accrued
overdue fines, even if the loan is so overdue that it reached the max fine
amount prior to effective return date.

For example, if a loan was due on 1/15/2015 and is charged 0.20 per day with a
maximum fine of 1.00, if it is returned on 2/1/2015 (assume no holidays), the
fine should remain at 1.00.  However, currently the fine will be reduced to
0.80 if the item is checked in using book drop mode.

I believe this can also account for the behavior that Kyle reported in bug
12144

Bug 13044 is also relevant here: making book drop mode become a special case of
the SpecifyReturnDate functionality (and in particular, removing the dropbox
logic from _FixOverduesOnReturn) is an opportunity to avoid inappropriate
reduction of max overdue fines.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13044] Deprecate old book drop mode

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14591

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13044] Deprecate old book drop mode

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
(In reply to Christopher Brannon from comment #1)
 This is a great idea.  Makes sense.  I wonder if it would be better to do
 away with the Book drop checkbox all together and put a button next to the
 calendar field to Set last open date?  Maybe wordy.  Just a thought.

I'm not in favor of always displaying the calendar widget, as there's a user
permissions issue here: circ staff may be permitted to set the effective return
date to the previous open day, but may not be permitted to set it to an
arbitrary date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14390] On renewal, the last fine is not marked as accounttype 'F' when item is checked in.

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
I don't think that renewing a loan actually converts accrued overdue fines to
committed/closed ones.  Rather, I think the sequence of events is this:

- make loan
- loan becomes overdue
- accrued fines start getting calculated (accounttype = FU)
- loan is renewed
- accrued fine record is not changed (and while the fine itself shouldn't go
away, the accounttype *ought* to be changed to F and the description updated to
indicate that the loan was renewed while overdue)
- loan becomes overdue again
- accrued fines start getting calculated on a second accountlines row
- loan gets returned

During the return processing, _FixOverduesOnReturn will change the accounttype
of accrued fines from FU to F.  However, it currently assumes that there is
exactly one such fine; if there are multiple ones, only one gets its
accounttype changed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

Rolando Isidoro rolando.isid...@gmail.com changed:

   What|Removed |Added

 CC||rolando.isid...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14586] Update 3.18 Koha team with new release maintainers

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14586

--- Comment #2 from Liz Rea l...@catalyst.net.nz ---
Created attachment 41116
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41116action=edit
[3.18.x] Bug 14586 - Update about page with new 3.18 release team

To test:

Look at more - about koha in the staff client, Koha team tab. It should list
the correct names for the release maintainers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14586] Update 3.18 Koha team with new release maintainers

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14586

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
They are listed correctly with the 3.22 release team in master :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14586] Update 3.18 Koha team with new release maintainers

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14586

--- Comment #3 from Liz Rea l...@catalyst.net.nz ---
Hehe yeah, only for 3.18.x :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14586] Update 3.18 Koha team with new release maintainers

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14586

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing.

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540

Jacek Ablewicz a...@biblos.pk.edu.pl changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14586] New: Update 3.18 Koha team with new release maintainers

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14586

Bug ID: 14586
   Summary: Update 3.18 Koha team with new release maintainers
 Change sponsored?: ---
   Product: Koha
   Version: 3.18
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: About
  Assignee: neng...@gmail.com
  Reporter: l...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

Slightly selfish, but the release maintainers on the about page don't list the
current release maintainers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14583] Subfields not deleted when automatically merging authorities.

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583

Jacek Ablewicz a...@biblos.pk.edu.pl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11315

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14583] Subfields not deleted when automatically merging authorities.

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583

Jacek Ablewicz a...@biblos.pk.edu.pl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=5572
 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572

Jacek Ablewicz a...@biblos.pk.edu.pl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14583

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges.

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315

Jacek Ablewicz a...@biblos.pk.edu.pl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14583

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14587] New: Acq: Make it possible to edit asort1 and asort2 values on receive

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14587

Bug ID: 14587
   Summary: Acq: Make it possible to edit asort1 and asort2 values
on receive
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

The values for asort1 and asort2 might change between order and receiving the
book, but there is currently no way to change it, without reopening the basket
which will mess with your order history. 

The other use case is changing the fund on receive - which might make the fund
and the asort values not match as they are defined on the fund level.

It would be nice if the statistic values could be edited during the receive
process.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14560] Rameau authorities

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560

--- Comment #3 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Sorry, I will try to make this more understandable:

The before and after fields are the part of the biblio record in which a
composed rameau authority has been merged to.

What we need to be done correctly during the merge is to add multiple $9,
corresponding to the koha internal links to the authorities.

In this example:

This part of the 606 : 

_311954119
_aGuerillas

needs to be linked to the koha authority of authid 26311

This part of the 606 : 

_311943195
_yBolivie

needs to be linked to the koha authority of authid 26312

And this part of the 606 :

_311976947
_z1945-1970

needs to be linked to the koha authority of authid 26313


This is the reason for the extra $9 fields that are being added, leading to:

606_311954119
   _926311
   _aGuerillas
   _311943195
   _926312
   _yBolivie
   _311976947
   _926313
   _z1945-1970
   _2rameau

The matching koha authority is found by matching the value of the external auth
id in the biblio ($3) with the value of the external auth id in the authority
(specified by the zebra index in the rameauBnfIdIndex syspref).


If this is still not clear enough, maybe a librarian could explain that better
than I do.

And yes, currently this is used for an external tool ( see
https://git.biblibre.com/biblibre/vendangeur ) we use to import records from
the BnF Z3950 server ( see
http://www.bnf.fr/en/professionals/bnf_data_services_tools/a.z3950_server_bnf_profile.html
)

But this is the first and mandatory step for further developpments in koha,
like supporting composed rameau authorities visual creation and edition in the
admin interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7174] Authentication rewriting

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Depends on|14437   |14540
   Assignee|paul.poul...@biblibre.com   |olli-antti.kivila...@jns.fi
 Status|NEW |Needs Signoff


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14437
[Bug 14437] Refactor C4::Auth::haspermission() to Koha::Object and return
better errors.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540
[Bug 14540] Move member-flags.pl to PermissionsManager to better manage
permissions for testing.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14437] Refactor C4::Auth::haspermission() to Koha::Object and return better errors.

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14437

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Blocks|7174|


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174
[Bug 7174] Authentication rewriting
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing.

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Blocks||7174


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174
[Bug 7174] Authentication rewriting
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7174] Authentication rewriting

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #40739|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing.

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #41071|0   |1
is obsolete||

--- Comment #10 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 41123
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41123action=edit
Bug 14540 - Move member-flags.pl to PermissionsManager to better manage
permissions for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7174] Authentication rewriting

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174

--- Comment #14 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 41124
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41124action=edit
Bug 7174 - Authentication Rewrite

Depends heavily on Buugg 14540, which introduces many tests to spot regression
caused by this feature.

Introduces a new modular authentication system based on Exception signaling
and reusable authentication components/challenges.
This system is cross-framework -compatible, currently supporting Mojolicious
and CGI, but adding support for any other framework is straightforward.

Central idea is to provide a single authentication function to deal with all
types of authentication scenarios, REST API, Cookie, Password, LDAP...
Also it is important to make a system that is easy to extend and can deal with
many future authentication scenarios.

Currently only CGI password, LDAP and cookie login is tested. Legacy behaviour
is used to deal with other types of authentication.

Deprecates a lot of subroutines in C4::Auth.

See the attached schematic in Bugzilla for a more architectural overview.

The basic principle is:
1. We get an authentication request from any Web/GUI-framework, for ex CGI.
2. Request is normalized by extracting all necessary authentication data
   elements to a separate data structure.
3. Based on the found authentication data elements, system decides which
   authentication route to take.
4. Route implements all challenges needed to authenticate the request.
   Route returns the authenticated Koha::Borrower or an Exception if login
   failed.
5. The user environment/session is set/deleted based on the Route result.
6. a Koha::Borrower and the CGISESSID-cookie is returned to the calling
   framework in the format the framework needs.
7. Framework needs to catch possible exceptions and deal with them.
   Eg. login failed, no permission, under maintenance.
8. Authentication succeeds and session is set, or failure is reported to user.

---
-::- TEST PLAN:-::-
---

Use PageObject tests from Buugg 14540 and Buugg 14536 to test against
regression.

::MANUAL TESTS::
OPAC:
1. Go to opac-main.pl
1.1. Try to access a restricted page like /cgi-bin/koha/opac-account.pl
2. Login with password.
3. Navigate to any OPAC page requiring login.
4. Observe that the login is still valid and correct username is displayed on
   top right of the browser window.
5. Logout
5.1. Try to access a restricted page.
6. Login again.
7. Browse a bit.
8. Logout.

Anonymous search history (OPAC):
1. Make a search
2. Make another search
3. Login
4. Make yet another search
5. Go to my search history.
6. Observe that the last three searches are shown in your search history.
7. Logout

STAFF CLIENT (Intra):
0. Try to access a restricted page, like /cgi-bin/koha/mainpage.pl
1. Login
2. Navigate a bit to confirm that the login remains active.
3. Logout.
4. Login again.
5. Navigate to a restricted page.
6. Logout.
6.1. Try to access a restricted page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #41063|0   |1
is obsolete||

--- Comment #3 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 41122
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41122action=edit
Bug 14539 - Introduction to castToObject(), aka. make a Koha::Object from
various input types

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13995] Proper Exception handling

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #41018|0   |1
is obsolete||

--- Comment #11 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 41118
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41118action=edit
Bug 13995 - Proper Exception handling

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7174] Authentication rewriting

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174

--- Comment #13 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 41117
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41117action=edit
AuthenticationRewrite schematic

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11512] Forced holds that violate issuing rules will never be filled

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I have another report from a library about this - it's really annoying that we
offer to override holds, but then they just never get filled... hard to
explain.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14536] PageObject-pattern base implementation

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #41052|0   |1
is obsolete||

--- Comment #4 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 41121
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41121action=edit
Bug 14536 - PageObject-pattern base implementation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents.

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #41022|0   |1
is obsolete||

--- Comment #7 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 41120
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41120action=edit
Bug 14495 - WebDriver/WebTester Factory for easy generation of Web testing
UserAgents.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #41021|0   |1
is obsolete||

--- Comment #6 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 41119
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41119action=edit
Bug 13906 - TestObjectFactory(ies) for Koha objects. Enable easy Test object
creation from HASHes or from preconfigured test groups.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14589

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14588

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7174] Authentication rewriting

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Patch complexity|--- |Large patch
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7174] Authentication rewriting

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174

--- Comment #16 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
(In reply to M. Tompsett from comment #15)
 Comment on attachment 41124 [details] [review]
 Bug 7174 - Authentication Rewrite
 
 Review of attachment 41124 [details] [review]:
 -
 
 What about CAS? About PKI authentication? Until someone write instructions
 on how to set those up for testing, I fear something is likely broken.

Very true. The C4::Auth subroutine interfaces haven't changed at all so there
should be no issues.
It would be great if somebody who knows how to set them up could help with
this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14564] Export configuration: Unfortunately, no backups are available.

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564

--- Comment #7 from Mirko Tietgen mi...@abunchofthings.net ---
Maybe the question really is, what is the purpose of this.

Being able to download the data is very important and something we allow
easily, others don't. It makes perfect sense to have in Koha.

Being able to download server specific configuration, while not being the
administrator of that particular server… does that really help anyone, is it
just something that looks »good« and »open« or is it just something that ended
in the code analogue to the other part of the backup (the actual data)?

The longer I think about it, the more I lean towards keeping the backup
function as it is and either taking away the »Export configuration« part or
leaving it up to the admin to change the permissions if they really want to
allow download. It should probably be documented then that setting
backup_conf_via_tools is not enough though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14590] New: Checkboxes should be disabled without valid contact information in messaging preferences

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Bug ID: 14590
   Summary: Checkboxes should be disabled without valid contact
information in messaging preferences
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: la...@student.uef.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Currently, in Patron message preferences, it is possible to set message
transport type without valid contact information (e.g. send sms even if patron
does not have a phone number set).

This is very problematic for us since we have several Borrowers with
misconfigured messaging preferences, and that causes issues, like Borrowers not
knowing they have Items waiting for pickup. This makes customers angry and our
librarians sad, not to mention the technical staff.
Reasons for this are myriad but one big challenge is misconfigured messaging
preferences, both in OPAC and the staff client.

I have listed messaging preferences that would need to require valid contact
information:
#1 SMS (this requires valid SMSnumber)
#2 Phone (this requires valid phone)
#3 Email (this requires valid email)

Validations will be done both client-side and server-side. I am working on the
following plan:

Server-side validation 
- In C4::Form::MessagingPreferences::handle_form_action(), check for each
parameter (SMSnumber, phone, email) to see if they are provided.
- If the parameter is provided, allow message_transport_types to contain said
transport method for this message.
- If the parameter is not provided, remove the said transport method for this
message from message_transport_types.

Client-side validation
- Has to be done in both OPAC and staff client.
- With JavaScript, check the contents of each contact field (SMSnumber, phone,
email).
- If the contact field is invalid or empty, remove all checks from messaging
preferences checkboxes for this transport type. Also disable these checkboxes.
- Once the contact field becomes valid on input event, enable checkboxes for
this transport type and restore any previously stored state (e.g. we just want
to change phone number without setting all messaging preferences again).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14588] New: Simplify merge_ajax.pl

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588

Bug ID: 14588
   Summary: Simplify merge_ajax.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14518] Deleting records with reservations (and no item) does not work

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518

--- Comment #9 from Maxime Beaulieu maxime.beaul...@inlibro.com ---
(In reply to Aleisha Amohia from comment #8)
 Hi I wasn't able to reproduce this bug, I was able to delete the record just
 fine

Hi, did you complete step II correctly?
After this step. The record should have a hold placed on it, but no items.

When placing the hold for the record, did you check the Place a hold on the
next available item checkbox?

The item needs to be deleted directy in the database using a mysql query ( see
III.4 )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588

--- Comment #1 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 41126
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41126action=edit
Bug 14588: Simplify merge_ajax.pl

This script does not need a few modules:
IO::File; CGI::Session; C4::UploadedFile.
Warnings can be enabled (with Modern::Perl).
Indirect object syntax replaced for CGI and CGI::Cookie. (Note that
Class::-method is preferred above Class-method. See perlobj.)
Moved the $reply line upwards (not needed twice anymore).

Test plan:
[1] Log in as staff user. Run the URL cataloguing/merge_ajax.pl.
You should see the JSON reponse in the browser.
[2] Logout. Run the URL again. Blank screen.
[3] Go to addbooks.pl (Cataloging Search). Search something, select two
biblios and click Merge selected, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7174] Authentication rewriting

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174

--- Comment #15 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 41124
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41124
Bug 7174 - Authentication Rewrite

Review of attachment 41124:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=7174attachment=41124)
-

What about CAS? About PKI authentication? Until someone write instructions on
how to set those up for testing, I fear something is likely broken.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14564] Export configuration: Unfortunately, no backups are available.

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564

--- Comment #8 from Robin Sheat ro...@catalyst.net.nz ---
I think that pretty much jibes with my opinion. No point removing it, people
may have cause to use it, but documenting that it's going to be more than just
flicking an option if you want to use it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14456] EmbedSeeFromHeadings record filter shouldn't process MARC holding fields

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14456

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #40596|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 41128
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41128action=edit
[SIGNED OFF] Bug 14456: EmbedSeeFromHeadings record filter shouldn't process
MARC holding fields

If the system preference IncludeSeeFromInSearches is enabled, records
exported for zebra indexing are being additionally processed by
EmbedSeeFromHeadings record filter (right now used only in rebuild_zebra.pl
script). This filter embeds 'see from' fields (extracted from authority
records linked with the given biblio via $9 subfields) into target MARC
record, which is then subsequently indexed in zebra.

Currently all fields containing $9 are getting the same exact treatment
by this filter. But on the export stage when the filter is applied, MARC
record being processed already does have holdings data fields added in
the previous stage (usually 952 / 995, depending on the MARC format).
Problem is that holdings data fields use to have $9 subfields in them
as well (mapped to item.itemnumber by default). As a consequence, some
(great many in the typical setup) records exported for zebra indexing
may have surplus see from fields added erroneously in semi-random
fashion, so biblio searches would often return some completely
unexpected additional results.

EmbedSeeFromHeadings record filter should not process holdings fields
when dealing with MARC records intended for zebra indexing.

To reproduce:

1) database with as many sample or real-world biblio, item and authority
records as possible is recommended for testing purposes
2) enable IncludeSeeFromInSearches
3) export a bunch of biblio records for zebra (e.g.:
misc/migration_tools/rebuild_zebra.pl -I -b -x -k -length=1000),
inspect the result xml records in /tmp/whatever file; observe that at
the end of many records, here and there some extra see from (= 1st
indicator: 'z') fields tend to appear, which shouldn't be there ;)

To test:

4) apply patch
5) redo 3)
6) compare results from 3) and 5) with diff

Signed-off-by: Tomas Cohen Arazi tomasco...@theke.io
I introduced a regression test for this. You should run the tests
without/with the patch and verify that the patch actually fixes the problem.
Good job Jacek! I'm sure writing the regression test would take less time
than such a detailed commit message!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14456] EmbedSeeFromHeadings record filter shouldn't process MARC holding fields

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14456

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14456] EmbedSeeFromHeadings record filter shouldn't process MARC holding fields

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14456

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 QA Contact|tomasco...@gmail.com|testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14456] EmbedSeeFromHeadings record filter shouldn't process MARC holding fields

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14456

--- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 41127
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41127action=edit
[SIGNED OFF] Bug 14456: (regression test) Holdings fields should be skipped by
EmbedSeeFromHeadings

This patch introduces a regression test for the situation in which
an itemnumber on a record matches the authid of an authority record
and the current implementation of the EmbedSeeFromHeadings filter
wrongly includes new holding fields with authority data...

To test:
- Apply the patch
- Run:
  $ prove t/db_dependent/RecordProcessor_EmbedSeeFromHeadings.t
= FAIL: The test 'Holdings fields not processed to introduce See-from heading'
   fails.

Signed-off-by: Tomas Cohen Arazi tomasco...@theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14456] EmbedSeeFromHeadings record filter shouldn't process MARC holding fields

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14456

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14456] EmbedSeeFromHeadings record filter shouldn't process MARC holding fields

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14456

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14589] New: Replace fetch CGI::Cookie calls

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589

Bug ID: 14589
   Summary: Replace fetch CGI::Cookie calls
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589

--- Comment #1 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 41125
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41125action=edit
Bug 14589: Replace fetch CGI::Cookie calls

This patch is inspired by the change in bug 14588.
It replaces the indirect object syntax for CGI::Cookie.
Some trivial corrections are made to authorities/merge_ajax.pl just as
bug 14588 does for cataloguing.

Test plan:
Run the URL authorities/merge_ajax.pl in staff.
Upload a file with Stage MARC records for import.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl
 Status|NEW |Needs Signoff
   Severity|enhancement |minor
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl

2015-07-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch
   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/