[Koha-bugs] [Bug 14580] Warn when accessing Help from error pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14580 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added CC||j.kylm...@gmail.com --- Comment #3 from Joonas Kylmälä j.kylm...@gmail.com --- The problem is with C4::Templates::themelanguage function, it doesn't return anything in this situation. Should we fix that function instead, because bug 14681 has the same problem and I'm thinking other pages might have it too. I tried to look into a fix to that function but didn't come up with any clever fix. One idea was to default to some default themes/language but then we cannot know if they're installed or not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14682] New: Export.pl doesn't work from command line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14682 Bug ID: 14682 Summary: Export.pl doesn't work from command line Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: josef.mora...@gmail.com QA Contact: testo...@bugs.koha-community.org When I'm calling export.pl script from command line, I'm receiving this error message and nothing is exported: Can't use an undefined value as a HASH reference at /usr/share/koha/intranet/cgi-bin/tools/export.pl line 149. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14621] Messaging preferences table needs to be sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 --- Comment #1 from Lari Taskula la...@student.uef.fi --- Created attachment 41494 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41494action=edit Bug 14621 - Messaging preferences table needs to be sorted I have been working with messaging preferences and I noticed a weird issue in Firefox on Ubuntu. On messaging preferences page, the table is unsorted and the content in rows are generated randomly on every page refresh. When you select/deselect checkboxes and refresh the page (without posting the changes), Firefox will remember your choices. Now the issue is that when the table is unsorted and the rows keep changing on page refresh, Firefox has trouble remembering your choices. This makes it appear as if the checkboxes are magically changing values on each page refresh. Here is a patch that prevents this problem by sorting the messaging settings. Test plan: 1. Apply patch and have Perl version 5.18 or higher 2. In OPAC, navigate to your messaging 3. Observe the order of rows in the messaging settings table 4. Refresh the page 5. Observe that the order of rows is still the same as in step 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14679] die with bad template path on item search because template file name has a period which is not a safe character
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14679 --- Comment #1 from Anthony Moore a...@bom.gov.au --- Created attachment 41488 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41488action=edit koha-bom-get_template_and_user-regex.patch Attached proposed fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14679] die with bad template path on item search because template file name has a period which is not a safe character
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14679 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Anthony, could this be a duplicate of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14450? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14679] die with bad template path on item search because template file name has a period which is not a safe character
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14679 --- Comment #3 from Anthony Moore a...@bom.gov.au --- Sounds like it.. says that a fix is in 3.18.09, i'm on 3.18.08. I will try 09 and report back. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14679] die with bad template path on item search because template file name has a period which is not a safe character
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14679 Anthony Moore a...@bom.gov.au changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Anthony Moore a...@bom.gov.au --- Katrin, This bug is fixed for me in version 3.18.09. Thanks for your help. *** This bug has been marked as a duplicate of bug 14450 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14450] Stricter template name rules cause itemsearch to stop working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14450 Anthony Moore a...@bom.gov.au changed: What|Removed |Added CC||a...@bom.gov.au --- Comment #10 from Anthony Moore a...@bom.gov.au --- *** Bug 14679 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added CC||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14666] adds fixed_fines for overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Fridolin SOMERS fridolin.som...@biblibre.com changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9016 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Fridolin SOMERS fridolin.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14666 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14666] adds fixed_fines for overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Fridolin SOMERS fridolin.som...@biblibre.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m Version|3.18|master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Summary|when doing acquisitions,|when doing acquisitions |MarcFieldsToOrder-syspref |from a staged file, |discounts are instead |MarcFieldsToOrder-syspref |added. |discounts are instead ||added. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14680] New: when doing acquisitions, MarcFieldsToOrder-syspref discounts are instead added.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Bug ID: 14680 Summary: when doing acquisitions, MarcFieldsToOrder-syspref discounts are instead added. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: olli-antti.kivila...@jns.fi QA Contact: testo...@bugs.koha-community.org Using the syspref 'MarcFieldsToOrder', getting the discount directly from the MARC causes the price to actually increase by the discount percentage, not decrease, if the Vendor/Bookseller is configured to include the VAT/GST in the list price. REPLICATE ISSUE: -1. Define 'MarcFieldsToOrder'-syspref to match the discount and price columns of your staged MARC Records. 0. Stage a MARC batch. 1. Make and acquisition from the staged file using /acqui/addorderiso2709.pl (Save the big staging list, don't click Add order on an individual Biblio.) 2. Observe that the Replacement price (rrp) is actually the (price + discount) instead of (price - discount). And the estimated cost is just the price in the MARC Record without any discount. AFTER THIS PATCH: Replay step 1. 2. rrp is now the price in the MARC Record incl. VAT/GST. ecost is now the VAT/GST included discounted price. NOTE! Because the subroutine I modified doesn't make much sense, it is presumed that there can be regression in other parts for other kinds of vendor configurations. Because the acquisitions module is in urgent need of complete back-end refactoring + PageObject/Cucumber regression test coverage, no further investigation is made to resolve those. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 --- Comment #1 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 41489 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41489action=edit Bug 14680 - when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added. Using the syspref 'MarcFieldsToOrder', getting the discount directly from the MARC causes the price to actually increase by the discount percentage, not decrease, if the Vendor/Bookseller is configured to include the VAT/GST in the list price. REPLICATE ISSUE: -1. Define 'MarcFieldsToOrder'-syspref to match the discount and price columns of your staged MARC Records. 0. Stage a MARC batch. 1. Make and acquisition from the staged file using /acqui/addorderiso2709.pl (Save the big staging list, don't click Add order on an individual Biblio.) 2. Observe that the Replacement price (rrp) is actually the (price + discount) instead of (price - discount). And the estimated cost is just the price in the MARC Record without any discount. AFTER THIS PATCH: Replay step 1. 2. rrp is now the price in the MARC Record incl. VAT/GST. ecost is now the VAT/GST included discounted price. NOTE! Because the subroutine I modified doesn't make much sense, it is presumed that there can be regression in other parts for other kinds of vendor configurations. Because the acquisitions module is in urgent need of complete back-end refactoring + PageObject/Cucumber regression test coverage, no further investigation is made to resolve those. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Failed QA because missing test coverage. Because the modification is in the controller, no unit testing is possible. Only way to test is with PageObjects. This needs a lot of scaffolding to be made to enable running tests on Acquisitions module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14620] Contact information validations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula la...@student.uef.fi changed: What|Removed |Added Attachment #41461|0 |1 is obsolete|| --- Comment #8 from Lari Taskula la...@student.uef.fi --- Created attachment 41502 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41502action=edit Bug 14620 - Contact information validations I'm thinking we should centralize all patron's contact information validators into one module. Currently we only have validations for e-mail addresses, using the Email::Valid module. In our local library we also want to validate phone numbers with a regex that only recognizes phone numbers from my country. So I suggest we create a phone number validation as well, with an option to easily create custom regex for your local use. If a library does not wish to use validations, we should give them an option to turn them off. If more local validators are implemented, we should also give the library an option to select which validator they wish to use. With this method we could implement phone number validators from around the world and add them into our module. Then we would make the validations simply by calling our validator. The validator would know by system preference which one of the implemented phone number validators it should use. Validations should be both client and server side. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14683] New: Unable to clear SMS number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683
Bug ID: 14683
Summary: Unable to clear SMS number
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: OPAC
Assignee: oleon...@myacpl.org
Reporter: la...@student.uef.fi
QA Contact: testo...@bugs.koha-community.org
In opac-messaging.pl (your messaging) you cannot unset your SMS number once it
has been set if your mobile (other phone) field is empty.
When checking for modified SMS number, we also check if SMS number does not
equal mobile phone. This is causing the bug:
$query-param('SMSnumber') ne $borrower-{'mobile'}
Since mobile is empty and the given SMS number is also empty, the given SMS
number will not be saved. Does anybody have an idea why we have this kind of
condition?
to reproduce:
-2. Make sure borrower does not have mobile (other phone) set
-1. Make sure you have SMS messaging enabled
1. Navigate to your messaging
2. Insert SMS number and submit
3. Clear SMS number and submit
4. Observe that the sms number did not change
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #41482|0 |1 is obsolete|| --- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41504 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41504action=edit Bug 13791: Apache configuration files This patch adds an include to each VirtualHost definition (OPAC and Intranet) and a variable definition, taking advantage of Apache 2.4.x features. The instance name is reused inside the includes providing a simple way of dealing with the apache - plack configuration. A check for the right apache version is introduced, in the for of an IfVersion block: IfVersion = 2.4 --- Plack configuration here --- /IfVersion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added CC||n...@quecheelibrary.org --- Comment #119 from Nick Clemens n...@quecheelibrary.org --- Test plan went well, a couple things I noticed along the way: MAJOR: Editing or adding an item deletes all items from the record MINOR: 1 - Backspacing on indicators or field number is hard to fix (insert mode keeps changing and have to press the button after each insertion) 2 - Letters should not be valid in field number 3 - Spaces (as opposed to underscores) invalidate the field, but it is hard to tell that is the problem. Could they possibly translate to underscores? 4 - Using delete you can bring another field into the current field, however you can't use enter to return it to the next line. You should either not be able to pull the line up, or you should have some recourse to return it. 5 - Pressing end on a new blank field moves the cursor in line with the next field and backspacing then deletes the field below 6 - It would be nice to have an apply button when selecting/deselecting search sources. If you want to make more than one change the waiting between each click is tedious 7 - Ctrl+X to delete a field works nicely, but it doesn't work as 'cut' if text is highlighted. Having the ability to move text between fields would be appreciated if possible 8 - Error message Missing mandatory subfield $a when field a is present but empty could say Mandatory subfield $a is blank -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #41483|0 |1 is obsolete|| --- Comment #9 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41505 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41505action=edit Bug 13791: koha-plack documentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #41481|0 |1 is obsolete|| --- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41503 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41503action=edit Bug 13791: Plack out-of-the-box support on packages This patch introduces a koha-plack script that controls running Plack processes for each instance. They are run using 'starman', listening on a Unix Domain Socket (UDS): /var/run/koha/instancename/plack.sock The plack configuration file[1] is expected to be on: /etc/koha/plack.psgi It also adds the following helper functions to koha-functions.sh: - is_plack_enabled - is_plack_running Done: - koha-plack script - suitable psgi file [1] Yeah, a single file. Because we will be relying on multiple mount points for each app (i.e. 'opac' and 'intranet', and 'api' ;-) ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #41485|0 |1 is obsolete|| --- Comment #11 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41507 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41507action=edit Bug 13791: make koha-common init script aware of plack This patch makes the packages' koha-common script aware of plack. It does so by relying on koha-list --plack to know which instances have Plack configured, and uses the koha-plack script to manage the running daemons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #41486|0 |1 is obsolete|| --- Comment #10 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41506 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41506action=edit Bug 13791: make koha-list aware of plack This patch adds the --plack and --noplack option switches to koha-list for filtering instances to be listed. This is particularly important for init scripts and cronjobs. To test: - Play with koha-list --plack and koha-plack --enable/--disable and verify that koha-list returns the expected results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14506] barcode printing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14506 sy siewy...@yahoo.com changed: What|Removed |Added CC||siewy...@yahoo.com --- Comment #3 from sy siewy...@yahoo.com --- had this issue also. homebranch in the Koha to MARC mapping was not mapped to a value. solution: Home › Administration › Koha to MARC mapping (items) homebranch: map it to 952 a Permanent location -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14530] 856$u URL checker ( check-url.pl ) complains about ftp based URLs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 --- Comment #5 from Kyle M Hall kyle.m.h...@gmail.com --- (In reply to M. Tompsett from comment #3) Also, quick says it replaces the non-quick version. Perhaps we should delete the non-quick version? That sounds good to me. Would you want to file a separate bug report for that? If that bug/patch makes it into master before this one, I'll just have to update it. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added CC||kyle.m.h...@gmail.com --- Comment #6 from Kyle M Hall kyle.m.h...@gmail.com --- (In reply to Jonathan Druart from comment #5) Any chances to get some tests to highlight this change? I'll see what I can do! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14530] 856$u URL checker ( check-url.pl ) complains about ftp based URLs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added CC||kyle.m.h...@gmail.com --- Comment #4 from Kyle M Hall kyle.m.h...@gmail.com --- (In reply to M. Tompsett from comment #2) Actually, couldn't you put an http URL for an ftp proxy into host? ./misc/cronjobs/check-url.pl --host=http://this.site.proxies.ftp.requests then it would attempt to go to http://this.site.proxies.ftp.requests/ftp://whatever/whereever/whatever.foo Personally, I'd prefer to see a re-write to allow for other protocols (bring back gopher! :) ). Because skipping the ftp URLs kind of defeats the purpose of the script which is to validate that the URLs exist. This could be a significant problem if a large portion of URLs are not http. That sounds reasonable, but not everyone will want to go to the trouble of setting that up. As a middle ground, I think adding a --skip-ftp parameter should suffice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #41507|0 |1 is obsolete|| --- Comment #16 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41512 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41512action=edit Bug 13791: make koha-common init script aware of plack This patch makes the packages' koha-common script aware of plack. It does so by relying on koha-list --plack to know which instances have Plack configured, and uses the koha-plack script to manage the running daemons. It also introduces a plack_status function to check the status of the Plack daemon when called: $ servive koha-common status Regards -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #41506|0 |1 is obsolete|| --- Comment #15 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41511 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41511action=edit Bug 13791: make koha-list aware of plack This patch adds the --plack and --noplack option switches to koha-list for filtering instances to be listed. This is particularly important for init scripts and cronjobs. To test: - Play with koha-list --plack and koha-plack --enable/--disable and verify that koha-list returns the expected results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #41503|0 |1 is obsolete|| --- Comment #12 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41508 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41508action=edit Bug 13791: Plack out-of-the-box support on packages This patch introduces a koha-plack script that controls running Plack processes for each instance. They are run using 'starman', listening on a Unix Domain Socket (UDS): /var/run/koha/instancename/plack.sock The plack configuration file[1] is expected to be on: /etc/koha/plack.psgi and is installed by the package. It also adds the following helper functions to koha-functions.sh: - is_plack_enabled - is_plack_running Done: - koha-plack script - suitable psgi file [1] Yeah, a single file. Because we will be relying on multiple mount points for each app (i.e. 'opac' and 'intranet', and 'api' ;-) ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #17 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41513 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41513action=edit Bug 13791: tab-completion for koha-plack in bash This patch adds tab-completion in bash for the koha-plack command. After the --start, --stop, --restart and --disable switches it only offers plack-enabled instances. And disabled instances to --enable. --help and -h just finish end the completion. --quiet and -q are trickier to implement. They will work (be offered) only before the action switches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #41504|0 |1 is obsolete|| --- Comment #13 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41509 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41509action=edit Bug 13791: Apache configuration files This patch adds an include to each VirtualHost definition (OPAC and Intranet) and a variable definition, taking advantage of Apache 2.4.x features. The instance name is reused inside the includes providing a simple way of dealing with the apache - plack configuration. A check for the right apache version is introduced, in the for of an IfVersion block: IfVersion = 2.4 --- Plack configuration here --- /IfVersion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #41505|0 |1 is obsolete|| --- Comment #14 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41510 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41510action=edit Bug 13791: koha-plack documentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14530] 856$u URL checker ( check-url.pl ) complains about ftp based URLs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 --- Comment #6 from M. Tompsett mtomp...@hotmail.com --- BTW, I was bored a while back, and actually wrote a forking LWP version. I'll attach it later, once I actually test it in place. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3642] Modify Overdue.pl export to include other borrower information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 Fridolin SOMERS fridolin.som...@biblibre.com changed: What|Removed |Added Alias|CSV, export, in,| |informations, New, overdues | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3642] Modify Overdue.pl export to include other borrower information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 Fridolin SOMERS fridolin.som...@biblibre.com changed: What|Removed |Added Alias||New, informations, in, ||overdues, CSV, export -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3642] Modify Overdue.pl export to include other borrower information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 Fridolin SOMERS fridolin.som...@biblibre.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |fridolin.som...@biblibre.co ||m CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3642] New informations in overdues CSV export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 Fridolin SOMERS fridolin.som...@biblibre.com changed: What|Removed |Added Summary|Modify Overdue.pl export to |New informations in |include other borrower |overdues CSV export |information | --- Comment #3 from Fridolin SOMERS fridolin.som...@biblibre.com --- I propose some patches. not only for borrower informations so I change a bit the title -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3642] New informations in overdues CSV export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 --- Comment #5 from Fridolin SOMERS fridolin.som...@biblibre.com --- Created attachment 41491 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41491action=edit Bug 3642 - New informations in overdues CSV export - add cardnumber This patch adds patron cardnumber to overdues CSV export Test plan : - Go to overdues page : server/cgi-bin/koha/circ/overdue.pl - Find some overdues - Click on Download file of displayed overdues - Open generated CSV = You see cardnumber column with data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3642] New informations in overdues CSV export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 --- Comment #6 from Fridolin SOMERS fridolin.som...@biblibre.com --- Created attachment 41492 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41492action=edit Bug 3642 - New informations in overdues CSV export - add itemtype This patch adds record itemtype to overdues CSV export, from item or biblioitems depending on syspref item-level_itypes Test plan : - Go to overdues page : server/cgi-bin/koha/circ/overdue.pl - Find some overdues - Click on Download file of displayed overdues - Open generated CSV = You see itemtype column with data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3642] New informations in overdues CSV export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 --- Comment #4 from Fridolin SOMERS fridolin.som...@biblibre.com --- Created attachment 41490 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41490action=edit Bug 3642 - New informations in overdues CSV export - prepare This patch prepare columns list to ease other patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3642] New informations in overdues CSV export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 Fridolin SOMERS fridolin.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3642] New informations in overdues CSV export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 --- Comment #7 from Fridolin SOMERS fridolin.som...@biblibre.com --- Created attachment 41493 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41493action=edit Bug 3642 - New informations in overdues CSV export - move streetnumber and streettype This patch moves columns streetnumber and streettype next to address. This is more logical to read the CSV. For example : streetnumber,streettype,address,address2,zipcode,city 181,rue,Breteuil,,13001,Marseille Test plan : - Go to overdues page : server/cgi-bin/koha/circ/overdue.pl - Find some overdues of patrons with streetnumber and streettype - Click on Download file of displayed overdues - Open generated CSV = You see streetnumber and streettype before address -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3642] New informations in overdues CSV export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 --- Comment #8 from Fridolin SOMERS fridolin.som...@biblibre.com --- Enjoy and please test ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14484] Warns when changing patron password
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added Attachment #41487|0 |1 is obsolete|| --- Comment #8 from Joonas Kylmälä j.kylm...@gmail.com --- Created attachment 41495 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41495action=edit Bug 14484: warns when changing patron pw Warning disappears, code looks good. Signed-off-by: Joonas Kylmälä j.kylm...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14484] Warns when changing patron password
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 --- Comment #2 from Lari Taskula la...@student.uef.fi --- Created attachment 41497 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41497action=edit Bug 14590 - PageObject tests for misconfigured messaging preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 --- Comment #1 from Lari Taskula la...@student.uef.fi --- Created attachment 41496 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41496action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences This patch makes both client and server side validations, both in OPAC and Staff client. Test plan for Staff client: 1. Login to Staff client 2. Enable syspref ValidateEmailAddress and set ValidatePhoneNumber to ipn 3. Enable syspref TalkingTechItivaPhoneNotification and SMSSendDriver (write anything) 4. Navigate to modify patron's information at memberentry.pl 5. Insert valid primary phone number, primary email address and SMS number 6. Check all messaging preferences and submit changes 7. Navigate to modify patron's information at memberentry.pl 8. Clear primary email, primary phone and SMS number fields and submit changes 9. Observe that the messaging preferences are disabled Test plan for OPAC: -1. Make sure sysprefs are set like in Staff client test step 2-3 1. Login to OPAC 2. Navigate to your personal details 3. Insert valid primary phone number, primary email address and SMS number 4. Submit changes 5. Login to Staff client 5.1. Navigate to Patrons 5.2. Approve information modification request 6. Back in OPAC, Navigate to your messaging 7. Check all messaging preferences and submit changes 8. Navigate to your personal details 9. Clear primary email, primary phone and submit changes 10. Repeat step 5 and 6 11. Observe that the messaging preferences are disabled for Phone and Email columns 12. Clear SMS number field and submit changes 13. Observe that all the messaging preferences are disabled This patch also includes a maintenance script at misc/maintenance/deleteMisconfiguredMessagingPrefs.pl that goes through all borrowers and automatically deletes their misconfigured messaging preferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14621] Messaging preferences table needs to be sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Lari Taskula la...@student.uef.fi changed: What|Removed |Added Blocks||14590 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula la...@student.uef.fi changed: What|Removed |Added Depends on||14621 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 [Bug 14621] Messaging preferences table needs to be sorted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #2 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41499 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41499action=edit Bug 14321: Add some error checking to Upload.pm This patch makes Upload return some error codes if a file cannot be read or cannot be written. Test plan: [1] Upload a file with stage-marc-import.pl. This is a temporary file; it will be saved in your system's temporary dir (e.g. /tmp) within the folder koha_upload. [2] Change the owner of this koha_upload dir and remove write permissions. [3] Upload the file again. You should get: Upload status: Failed. [4] Restore owner and permissions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #1 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41498 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41498action=edit Bug 14321: Using Koha::Upload in tools/upload-file.pl This patch introduces Koha::Upload. It will replace the modules C4::UploadedFile.pm and the new C4::UploadedFiles.pm (from BZ 6874). This operation will be performed in a few steps. As a first step, we will use Koha::Upload instead of UploadedFile in the following places. (In these three places files are uploaded temporarily.) [1] stage-marc-import.pl [2] upload-cover-image.pl [3] offline_circ/process_koc.pl and enqueue_koc.pl A new file-upload.js replaces file-upload.inc in the associated template. We now use ajax to get progress figures instead of launching perl script upload-file-progress. Also we do not need the jquery plugin ajaxfileupload.js anymore. A subsequent patch will remove these files. The js changes now also allow for aborting a file upload. This feature has been added to stage-marc-import only for now. NOTE: In editing the process_koc.tt I noticed that the form enqueuefile was hidden and no longer used (with associated code in process_koc.pl). When a file has been uploaded, I display the form again (with the Apply directly button). The code still works. Test plan: [1] Upload a marc file in stage-marc-import. [2] Check new entry in table uploaded_files. Look for the file in the directory defined by upload_path in koha-conf.xml. [3] Upload another (larger) file and abort the upload. Check table and directory again. [4] Verify that Stage for import still works as expected. [5] Test Upload local cover image. (Enable OPACLocalCoverImages.) You can test an individual image or a zip file including images and a file called datalink.txt (with lines biblionumber,filename). [6] Test uploading a offline circulation file: Enable AllowOfflineCirculation, and create a koc file (plain text): Line1: Version=1.0\tA=1\tB=2 Line2: 2015-08-06 08:00:00 345\treturn\t[barcode] Note: Replace tabs and barcode. The number of tabs is essential! Checkout the item with your barcode. Go to Offline circulation file upload. Upload and click Apply directly. Checkout again. Upload again, click Add to offline circulation queue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #4 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41501 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41501action=edit Bug 14321: Redirect upload plugin to general upload script This patch makes the following changes to achieve that: [1] Adds a tools/upload script and template. It allows to upload multiple files at once. [2] Adds additional parameter to js function AjaxUpload (for category and public column). [3] Adds methods to Upload: count, delete, getCategories, httpheaders. [4] Makes upload-file return error messages in JSON. For a multiple upload, we could have some files with errors and others without errors. The upload is now marked as Failed only if there was no upload at all. [5] Adds decode_utf8 statement for UTF-8 chars in filenames (in the CGI hook). Note that we do not want the -utf8 flag here for binary uploads. [6] The upload plugin is converted to use tools/upload with plugin param. Deleting an upload is now presented via the search results form. NOTE: A unit test is supplied in a follow-up patch. Test plan: [1] Upload three files via tools/upload.pl with a category and marked as public. Check the results in the table. [2] Pick one new file and one of the files of step 1. Upload them in the same category. One upload should succeed. Check for reported error. [3] Upload a file via stage-marc-import. Stage it. [4] Go to Cataloguing editor. Connect upload.pl to field 856$u. In an empty 856$u, click the tag editor. Upload a file and click Choose. Save the record. Open the record in the OPAC and click the link. Copy this link to your clipboard for step 5. [5] Go back to editor. Click the tag editor on the same 856 field. Choose for Delete. Open the link in your clipboard again. [6] Check the process of upload, search, download and delete of an upload with some diacritical characters in the filename. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #3 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41500 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41500action=edit Bug 14321: Add public column to uploaded_files This patch adds uploaded_files.public. This column will be used to mark uploaded files as available via opac-retrieve. The db rev sets this flag for current records having a category (as uploaded via the BZ 6874 plugin: so public). A followup patch will adjust the plugin to use Koha::Upload. Test plan: [1] Run the dbrev. [2] Add a record (upload a file) via stage-marc-import. [3] Check that public is null in the new record. (This is a temporary file without category.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #5 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- This shows my progress until now. Almost done :) I will still add a test file and remove some obsolete files. After that there may be some smaller style issues, adding upload to the menu and perhaps adding a specific permission or so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Heather Braum hbr...@nekls.org changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14681] New: Warn when adding help to 404 page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14681 Bug ID: 14681 Summary: Warn when adding help to 404 page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: j.kylm...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Going to cgi-bin/koha/errors/404.pl in staff side and then clicking the Help and after that clicking Add help you get the following warning/error: edithelp.pl: Use of uninitialized value $lang in concatenation (.) or string at kohaclone/edithelp.pl line 74. The problem is the same type as it is in Bug 14580. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14580] Warn when accessing Help from error pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14580 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14681 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14681] Warn when adding help to 404 page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14681 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14580 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14666] adds fixed_fines for overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 --- Comment #2 from Fridolin SOMERS fridolin.som...@biblibre.com --- (In reply to Katrin Fischer from comment #1) Hi Stephane, I am in doubt about this patch - especially the new dependencies. What are they used for? We have a new plugin to format prices now and also some existing code to do that - could it be achieved with the existing modules? Ok thanks for the information. I also think this would be good on separate bugs - for example the colums added to the CSV seem unrelated to the main feature. Indeed, this bug will only focus on adding fixed_fines to overdue notices. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14666] adds fixed_fines for overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Fridolin SOMERS fridolin.som...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
