[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added Attachment #41567|0 |1 is obsolete|| --- Comment #31 from Josef Moravec josef.mora...@gmail.com --- Created attachment 41575 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41575action=edit Bug 13791: make koha-common init script aware of plack This patch makes the packages' koha-common script aware of plack. It does so by relying on koha-list --plack to know which instances have Plack configured, and uses the koha-plack script to manage the running daemons. It also introduces a plack_status function to check the status of the Plack daemon when called: $ servive koha-common status Regards Signed-off-by: Josef Moravec josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added Attachment #41565|0 |1 is obsolete|| --- Comment #29 from Josef Moravec josef.mora...@gmail.com --- Created attachment 41573 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41573action=edit Bug 13791: koha-plack documentation Signed-off-by: Josef Moravec josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added Attachment #41566|0 |1 is obsolete|| --- Comment #30 from Josef Moravec josef.mora...@gmail.com --- Created attachment 41574 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41574action=edit Bug 13791: make koha-list aware of plack This patch adds the --plack and --noplack option switches to koha-list for filtering instances to be listed. This is particularly important for init scripts and cronjobs. To test: - Play with koha-list --plack and koha-plack --enable/--disable and verify that koha-list returns the expected results. Signed-off-by: Josef Moravec josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added Attachment #41564|0 |1 is obsolete|| --- Comment #28 from Josef Moravec josef.mora...@gmail.com --- Created attachment 41572 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41572action=edit Bug 13791: Apache configuration files This patch adds an include to each VirtualHost definition (OPAC and Intranet) and a variable definition, taking advantage of Apache 2.4.x features. The instance name is reused inside the includes providing a simple way of dealing with the apache - plack configuration. A check for the right apache version is introduced, in the for of an IfVersion block: IfVersion = 2.4 --- Plack configuration here --- /IfVersion Signed-off-by: Josef Moravec josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added Attachment #41563|0 |1 is obsolete|| --- Comment #27 from Josef Moravec josef.mora...@gmail.com --- Created attachment 41571 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41571action=edit Bug 13791: Plack out-of-the-box support on packages This patch introduces a koha-plack script that controls running Plack processes for each instance. They are run using 'starman', listening on a Unix Domain Socket (UDS): /var/run/koha/instancename/plack.sock The plack configuration file[1] is expected to be on: /etc/koha/plack.psgi and is installed by the package. It also adds the following helper functions to koha-functions.sh: - is_plack_enabled - is_plack_running Done: - koha-plack script - suitable psgi file To test this patches you will need to install - starman - libplack-middleware-reverseproxy-perl [1] Yeah, a single file. Because we will be relying on multiple mount points for each app (i.e. 'opac' and 'intranet', and 'api' ;-) ) Signed-off-by: Josef Moravec josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14688] Cannot set guarantor for an organisation - professional account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14688 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- *** This bug has been marked as a duplicate of bug 14685 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14685] Cannot set guarantor for a child account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 --- Comment #4 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- *** Bug 14688 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14685] Cannot set guarantor for a child account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Attachment #41570|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41577 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41577action=edit Bug 14685: Fix set guarantor for a child or professional accounts Bug 13970 removed some useful code to automatically set the guarantor when creating a child. But finally there is a better way to do the job, we just need to assume that only children or professional can have a guarantor. Test plan: 1/ Create an adult patron and add a child. 2/ The guarantor info should be retrieved and set on the child creation page. 3/ Create an organization and add a child 4/ The guarantor info should be retrieved and set on the adult creation page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14685] Cannot set guarantor for a child account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Liz, thanks for testing! I have marked bug 14688 as duplicate, the patch should fix the 2 regressions (more?) introduced by bug 13970. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 --- Comment #4 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41578 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41578action=edit Bug 14529: The new list permission is 'lists', not 'shelves' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 --- Comment #1 from Tom Misilo misi...@fit.edu --- Would catalogue = * make sense here? If so I can make a patch for it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14675] Updating personal details on OPAC - request sent even if no changes are made
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14675 Martin Stenberg mar...@bugs.koha-community.org.xinxidi.net changed: What|Removed |Added Assignee|oleon...@myacpl.org |mar...@bugs.koha-community. ||org.xinxidi.net Status|NEW |ASSIGNED CC||mar...@bugs.koha-community. ||org.xinxidi.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #41383|0 |1 is obsolete|| Attachment #41384|0 |1 is obsolete|| Attachment #41385|0 |1 is obsolete|| --- Comment #15 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41627 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41627action=edit [SIGNED-OFF] Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped inside a subtest, and look for AddReturn storing the right itemtype on the 'statistics' table. Note: It also refactors the file a bit, to avoid side effects. And uses TestBuilder to make it independent on already-present db data. It also removes warnings by mocking C4::Context::userenv To test: - Apply the patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t = FAIL: Tests fail bacause AddReturn is not storing the itemtype - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 --- Comment #6 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Joonas Kylmälä from comment #5) (In reply to Owen Leonard from comment #4) (In reply to Joonas Kylmälä from comment #3) Shouldn't we change it to server side as it looks like all the other fields are checked that way. There are changes to the template and to opac-passwd.pl. To confirm, disable JavaScript and see if the server-side check is working correctly as well. opac-passwd.pl is for the end user server side check, right? I disabled JavaScript in the staff side and there wasn't any check from the server side, it allowed to change the password (this was also mentioned in the test plan). So should we change the code so that it checks for the whitespaces in the server side when the password is changed from the staff view? If you like, you can provide it. But I don't know why a librarian will force a password if the application denies it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14666] adds fixed_fines for overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12770 CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14584] Encoding broken with system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|In Discussion |Needs Signoff Assignee|philippe.blo...@inlibro.com |jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14584] Encoding broken with system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584
--- Comment #4 from Jonathan Druart jonathan.dru...@bugs.koha-community.org
---
(In reply to Blou from comment #3)
Well, I'm fine with that, but isn't it just making this function useless? I
think what you're suggesting is what it was before the latest change. I
just presumed there had been a need for that encode('UTF-8' call...
Not useless, it can be called from the templates.
Back 1 year ago, from bug 12411:
This will fix the encoding issues existing in 3.14 and 3.16.
The issue still appear in master but is fixed by bug 11944.
So bug 12411 should not have been pushed to master or 11944 should have
reverted the changes.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14607] Baker Taylor cover images should be accessible by UPC as well as ISBN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14607] Baker Taylor cover images should be accessible by UPC as well as ISBN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added CC||n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14607] Baker Taylor cover images should be accessible by UPC as well as ISBN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver jwea...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12770] Notice template tool enhancement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14666 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14584] Encoding broken with system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 --- Comment #6 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Should be backported to 3.20, not 3.18! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14607] Baker Taylor cover images should be accessible by UPC as well as ISBN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver jwea...@bywatersolutions.com changed: What|Removed |Added Attachment #41393|0 |1 is obsolete|| --- Comment #2 from Jesse Weaver jwea...@bywatersolutions.com --- Created attachment 41633 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41633action=edit Bug 14607: Baker Taylor cover images should be accessible by UPC as well as ISBN Test plan (requires Baker and Taylor cover images to be set up and enabled): 1. Create a record with an ISBN that does not have a cover and a UPC that does. 141985934X/085391174929 is one set that works well. 2. Verify that the record shows up as No image available in the following OPAC locations: shelf browser, reviews, lists, search and reading record. This will require adding reviews/checkouts/etc. for the record in question. 3. Apply patch. 4. Check the locations again, and verify that the record now has a valid cover image. Signed-off-by: Alexis Rodegerdts arodeger...@wallawallawa.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #17 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41629 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41629action=edit [SIGNED-OFF] Bug 14598: (QA followup) Don't die on bad barcode Signed-off-by: Tomas Cohen Arazi tomasco...@theke.io Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #18 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Jonathan Druart from comment #9) Is it a duplicate of bug 9351? I would say we need to update existing rows. What about existing rows? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #82 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41634 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41634action=edit Bug 11431 [QA Followup] - Fix js error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14689] New: Marc field 648 does not appear in the subject index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14689 Bug ID: 14689 Summary: Marc field 648 does not appear in the subject index Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: verolenci...@yahoo.com.ar QA Contact: testo...@bugs.koha-community.org Actually you cannot search content stored in the Marc21 648 field (Subject Added Entry - Chronological Term). Terms stored in the $a subfield of this field should be searchable through the normal subject index. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9472] subfields in order when cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #16 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41628 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41628action=edit [SIGNED-OFF] Bug 14598: Make C4::Circulation::AddReturn store the right itemtype This patch makes C4::Circulation::AddReturn correctly store the itemtype on the 'statistics' table. To reproduce: - Checkout master. - Make a checkout. - Check the 'statistics' table and notice the itemtype is correctly set SELECT * FROM statistics; - Check the item in. - Check the 'statistics' table and notice the itemtype is not set SELECT * FROM statistics WHERE type=return; = FAIL: itemtype is set to NULL To test: - Apply the regression tests patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t = FAIL: Tests fail - Apply this patch - Run the regression tests: $ prove t/db_dependent/Circulation/Returns.t = SUCCESS: Tests now pass. - Repeat the 'To reproduce' steps = SUCCESS: itemtype is now correctly set (in real life) - Happily sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #12 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41631 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41631action=edit Bug 14655: Add a warning on the about page if patrons have requested privacy New warning on the about page if at least a patron has requested a privacy on checkin but the AnonymousPatron is not set to a valid patron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #11 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41630 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41630action=edit Bug 14655: Add a warning if the checkin will fail On the checkin and checkout page, the checkin will fail if the patron has requested the privacy and the AnonymousPatron is not correctly set. This patch adds a warning message on both pages. Test plan: 0/ Be sure you don't have any patron with privacy=2 (Never) 1/ Set OPACPrivacy, not AnonymousPatron 2/ Go on the checkin, you should a warning (same as before this patch). 3/ Set the privacy=2 for a patron 4/ Go on the circulation page, a warning should appear (for this specific patron) 5/ Check an item out to this patron 6/ Check the item in on the checkin page. The item is not checked in and you get a specific message for this patron. Confirm other/correct situations don't trigger the messages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14584] Encoding broken with system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14584] Encoding broken with system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Attachment #41113|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41632 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41632action=edit Bug 14584: Encoding broken with system preferences The pref are double encoded. From bug 12411: This will fix the encoding issues existing in 3.14 and 3.16. The issue still appear in master but is fixed by bug 11944. They should not have been pushed together. Test plan: 1) You need an accentuated language installed. 2) Go to NoLoginInstructions pref, and add some accentuated message like Hélo médames é mècieüx 3) refresh opac home page, message should be gibberish 4) apply patch. Message should be ok now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 --- Comment #7 from Joonas Kylmälä j.kylm...@gmail.com --- (In reply to Jonathan Druart from comment #6) (In reply to Joonas Kylmälä from comment #5) (In reply to Owen Leonard from comment #4) (In reply to Joonas Kylmälä from comment #3) Shouldn't we change it to server side as it looks like all the other fields are checked that way. There are changes to the template and to opac-passwd.pl. To confirm, disable JavaScript and see if the server-side check is working correctly as well. opac-passwd.pl is for the end user server side check, right? I disabled JavaScript in the staff side and there wasn't any check from the server side, it allowed to change the password (this was also mentioned in the test plan). So should we change the code so that it checks for the whitespaces in the server side when the password is changed from the staff view? If you like, you can provide it. But I don't know why a librarian will force a password if the application denies it. Librarian doesn't need to force the password, only use a browser where the JavaScript is disabled. So I give one vote for the server side check. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 --- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41636 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41636action=edit Bug 14651: Koha::Item-effective_itemtype fallback to bib-level In some situations (bad migrations, old bugs that introduced bad data, people having bib-level itypes for ages and switching to item level...) the user ends with undex itype values for items. The current code, if the user has item_level-itype set, just returns undef. It should fallback to bib-level. To test: - Run the regression tets: $ prove t/db_dependent/Items.t = FAIL: tests fail. - Apply the patch - Run the tests again = SUCCESS: The tests now pass. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Depends on||14651 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Blocks||14598 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14689] Marc field 648 does not appear in the subject index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14689 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Component|OPAC|Searching Assignee|tomasco...@gmail.com|gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 --- Comment #1 from Martin Persson xarra...@gmail.com --- Created attachment 41642 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41642action=edit Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library Test plan: * Log into OPAC, search for a title, chose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver jwea...@bywatersolutions.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #1 from Jesse Weaver jwea...@bywatersolutions.com --- Created attachment 41643 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41643action=edit Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing Test plan: 1) Make sure there is at least one field in PatronSelfRegistrationBorrowerUnwantedField. 2) Apply patch, and update database. 3) Check to make sure that the new system preference PatronSelfModificationBorrowerUnwantedField has the same value as PatronSelfRegistrationBorrowerUnwantedField. 4) Verify that the same fields are hidden for self-registering a new borrower and edting a new one (both on the OPAC). 5) Change PatronSelfModificationBorrowerUnwantedField, and verify that the two preferences correctly apply to editing vs. creating. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41635 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41635action=edit Bug 14651: (regression test) fallback to bib-level if itype is undef Koha::Item-effective_itemtype should fallback to biblio-level itemtype even if item-level item types are set, in the case the item has no itemtype set (bad migration, bad old code). To test: - Run $ prove t/db_dependent/Items.t = FAIL: Koha::Item-effective_itemtype doesn't work properly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 Martin Persson xarra...@gmail.com changed: What|Removed |Added Change sponsored?|--- |Sponsored CC||xarra...@gmail.com Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 Heather Braum hbr...@nekls.org changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14690] New: Patron import tool page missing extra search patron options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 Bug ID: 14690 Summary: Patron import tool page missing extra search patron options Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: hbr...@nekls.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The Search Patrons box at the top of import_borrowers.pl has a + sign so you can reveal the extra options to search by library and/or categorycode. All that happens when you click on the [+] link, the [+] changes to a [-], and vice versa. No extra line is revealed. Test plan: 1.) Go to Tools -- Import Patrons. 2.) Click on the Search Patrons box (if it isn't activated already). 3.) Click on the [+] link next to the search box. 4.) Note that it changes to [-], but no extra line is revealed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #19 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41637 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41637action=edit Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows This patch introduces an updatedatabase.pl block that updates the rows that lack itemtype. It relies on Koha::Item-effective_itemtype() to choose the rigt one. I wrote it using SQL because the statistics table lacks PKs. Note: I'm not sure about making this dependent on 14651, I need a QA POV on this, and I'm biased as I wrote all the related patches... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14691] New: Can't delete patron with ' character in cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 Bug ID: 14691 Summary: Can't delete patron with ' character in cardnumber Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: hbr...@nekls.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If a patron cardnumber has a ' character in it, and you try to delete the account, nothing happens -- the delete pop-up message doesn't appear. This appears to not affect cards with any other special character, and I've tested - so far]. It's only cardnumbers with the ' character in them. Test plan: 1. Create patron account with cardnumber sss' and save the account. 2. Try to delete the account. Nothing happens. 3. Edit the account, and remove the ' character. Save the acccount. 4. Try to delete the account; note the Delete pop-up message that now appears. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14689] Marc field 648 does not appear in the subject index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14689 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Assignee|oleon...@myacpl.org |tomasco...@gmail.com Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14689] Marc field 648 does not appear in the subject index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14689 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Version|3.20|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #1 from Martin Persson xarra...@gmail.com --- Created attachment 41638 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41638action=edit Bug : View arbitrary branch's news This patch adds an input named 'branch' to opac-main.pl that allows overriding the home library to view news from any branch. This is part of the 'Use Koha as a CMS' development. To reviewers: Does this create any security implications? The column is text; it is possbile to push SQL statemens into the DB via the opac-membership.pl page, but all the code there seems to use DBIx::Class and prepared statements. When attemped, accepting the changes were rejected because of the foreign key constraint placed on the main borrowers table. It is recommended to use this patch in conjunction with 11584 which adds a WYSIWYG editor to System Preferences. Test plan: * Make sure your Koha installation has multiple branches: * Log in to the Staff interface and select 'Koha administration' * Select 'Libraries and groups', the first item in the list * Add an extra branch named 'BRANCH1': * Press the 'New library' button * Set 'Library code' to 'BRANCH1' * Enter an arbitrary name * Press 'Submit' * Add at least two news items with different branches: * Log in to the Staff interface and select 'Tools' * Under 'Additional tools' select 'News' * On the 'Koha news' page, create a news item for all libraries: * Press the 'New entry' button * Set 'Library' to 'All libraries' and enter a title. * Press 'Submit' * On the 'Koha news' page, create a news item for one library: * Press the 'New entry' button * Set 'Library' to 'BRANCH1' and enter a title * Press 'Submit' * Add links to OPAC to select branch: * Select 'System preferences' and then the 'OPAC' tab * Scroll down to the 'OpacNav' preference and click 'Click to Edit' * Create two hyperlinks with a parameter named 'branch': * 'a href=?branch=BRANCH1BRANCH1/a' * 'a href=?branch=none/a' * Click 'Save all OPAC preferences' * Test OPAC: * By default, global news and news for home branch should show. * When clicking the 'BRANCH1' link, you should see global news plus news for the BRANCH1 branch. * When the parameter 'branch' is set but has no value, news from the home branch should be shown. Issues: Tricky to create a link to the same page which removes existing paramters. The user normally has a home branch set. We can override it with the parameter. If undefined, the home branch should be shown. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14667] Label creator UI/UX revamp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #10 from Liz Rea l...@catalyst.net.nz --- I didn't - the reason I didn't is because it is not like any other page. That help should be in the upper right hand help menu, in my opinion. Also thank you very much for helping out with the translation stuff. :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added CC||n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14667] Label creator UI/UX revamp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #11 from Chris Nighswonger cnighswon...@foundations.edu --- On the other hand, I thought it was cool and that every tool should have a solid intro page which gives a brief overview of its purpose and usage. But that's just my opinion. And pretty biased at that since I created it. ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #1 from Liz Rea l...@catalyst.net.nz --- This is not an issue in 3.20, because of bug 13235. I'm about to attach a modified version of the patch for 3.18. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 --- Comment #2 from Liz Rea l...@catalyst.net.nz --- Created attachment 41646 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41646action=edit Bug 14690 - [3.18.x] Patron import tool page missing extra search patron options To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Also please be sure to check the patron import page. Owen is listed as the author of this, because that's mostly true - I just resolved the conflict for 3.18.x (LR) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13235] Revise layout of patron search form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Heather Braum hbr...@nekls.org changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14584] Encoding broken with system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14685] Cannot set guarantor for a child account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14584] Encoding broken with system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #41632|0 |1 is obsolete|| --- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41641 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41641action=edit [SIGNED OFF] Bug 14584: Encoding broken with system preferences The pref are double encoded. From bug 12411: This will fix the encoding issues existing in 3.14 and 3.16. The issue still appear in master but is fixed by bug 11944. They should not have been pushed together. Test plan: 1) You need an accentuated language installed. 2) Go to NoLoginInstructions pref, and add some accentuated message like Hélo médames é mècieüx 3) refresh opac home page, message should be gibberish 4) apply patch. Message should be ok now. Signed-off-by: Tomas Cohen Arazi tomasco...@theke.io Works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14685] Cannot set guarantor for a child account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Attachment #41577|0 |1 is obsolete|| --- Comment #6 from Liz Rea l...@catalyst.net.nz --- Created attachment 41640 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41640action=edit Bug 14685: Fix set guarantor for a child or professional accounts Bug 13970 removed some useful code to automatically set the guarantor when creating a child. But finally there is a better way to do the job, we just need to assume that only children or professional can have a guarantor. Test plan: 1/ Create an adult patron and add a child. 2/ The guarantor info should be retrieved and set on the child creation page. 3/ Create an organization and add a child 4/ The guarantor info should be retrieved and set on the adult creation page. Signed-off-by: Liz Rea l...@catalyst.net.nz This patch catches both cases, thanks Jonathan! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14667] Label creator UI/UX revamp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #12 from Liz Rea l...@catalyst.net.nz --- :) I can totally understand where you're coming from there. I have observed, when watching librarians learn this tool, that they just don't read it, and the wall of text distracts them from what they are supposed to do. Possibly though, that's because I emphasize the help in the upper right hand corner so they get it drilled into them to look there for help. Certainly the decision to remove it isn't scientific by any stretch, just based on my observations of people using the tool. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added CC||l...@catalyst.net.nz Attachment #41644|0 |1 is obsolete|| --- Comment #2 from Liz Rea l...@catalyst.net.nz --- Comment on attachment 41644 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41644 Bug 14691 - Can't delete patron with ' character in cardnumber Oops, typo. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #3 from Liz Rea l...@catalyst.net.nz --- Created attachment 41645 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41645action=edit Bug 14691 - Can't delete patron with ' character in cardnumber Test plan: 1. Create patron account with cardnumber sss' and save the account. 2. Try to delete the account. Nothing happens. 3. Apply the patch, refresh the page. 4. Try to delete the account; note the Delete pop-up message that now appears. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #1 from Liz Rea l...@catalyst.net.nz --- Created attachment 41644 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41644action=edit Bug 14691 - Can't delete patron with ' character in cardnumber Test plan: 1. Create patron account with cardnumber sss' and save the account. 2. Try to delete the account. Nothing happens. 3. Apply the patch, refresh the page. 4. Try to delete the account; note the Delete pop-up message that now appears. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added Attachment #41612|0 |1 is obsolete|| --- Comment #4 from Joonas Kylmälä j.kylm...@gmail.com --- Created attachment 41647 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41647action=edit Bug 14672 - Payment is not able to done, when the patron has credit balance This is fixed version of the yesterday's patch, the credit was calculated wrongly and now it's fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook dc...@prosentient.com.au --- I encountered this a while ago and thought about fixing it as well, but then Chris Cormack pointed me to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 which should fix this problem everywhere I think? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #43 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41583 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41583action=edit Bug 8352 [QA Followup] - Don't use SQL in pl files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #41 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41581 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41581action=edit Bug 8352 [QA Followup] - Fix column type in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #42 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41582 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41582action=edit Bug 8352 [QA Followup] * Add --confirm option to print_holds.pl * Modify old_reserves to match reserves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #40 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41580 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41580action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #45 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- svc/printer does not follow the coding guidelines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14574] Correcting messages on intranet error pages so they make more sense
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14574 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com |ity.org | CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14574] Correcting messages on intranet error pages so they make more sense
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14574 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Attachment #41522|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41604 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41604action=edit Bug 14574: Fixing error messages on staff client so they make more sense To test: 1) Go to cgi-bin/koha/errors/errornumber.pl to see the error messages which currently don't make sense (ie cgi-bin/koha/errors/401.pl etc). Have only made changes to 401, 403 and 404 2) Apply patch 3) Go to cgi-bin/koha/errors/401.pl -- Check that it now says This error means that you aren't authorized to view this page. and Please log in and try again.. Check that 'log in' redirects to the log in page (mainpage.pl). 4) Go to cgi-bin/koha/errors/403.pl -- Check that it now says This error means that you are forbidden to view this page. 5) Go to cgi-bin/koha/errors/404.pl -- This page should be very different. Check that the 'Error 404' is now in italics and not bold. Check that the page gives a list of reasons the user may have been given this error and some options for their next step. Signed-off-by: Catherine cnorthcott.w...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org Amended patch: replace tab with 4 spaces. Note: I am not sure the em tag is useful here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14574] Correcting messages on intranet error pages so they make more sense
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14574 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #12 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Blou from comment #11) fyi, There is nothing in the current patch that would prevent 4=109 and 4=1. There is nothing in the current patch to make it possible :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #46 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Jonathan Druart from comment #45) svc/printer does not follow the coding guidelines. forget that, it's done in the last patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added CC||kyle.m.h...@gmail.com Attachment #41611|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #10 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Jesse Weaver from comment #9) Doing this with SELECT borrowernumber FROM borrowers WHERE privacy = 2 LIMIT 1 ran in 0.02s on one of our largest sites (~125K borrowers), so it is practical. I don't understand why you want that, could you please detail? Have a look at the updatedb entry 3.21.00.013, we were careful to raise a warning if needed. I don't think it's worth to add a select statement for every checkin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 --- Comment #2 from Joonas Kylmälä j.kylm...@gmail.com --- Created attachment 41612 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41612action=edit Bug 14672 - Payment is not able to done, when the patron has credit balance Enables paying with credit, at least when using C4::Accounts::recordpayment function. The code is still buggy and needs more work. Sponsored-by Vaara-kirjastot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14675] Updating personal details on OPAC - request sent even if no changes are made
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14675 --- Comment #1 from Martin Stenberg mar...@bugs.koha-community.org.xinxidi.net --- Created attachment 41605 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41605action=edit Bug 14675: Don't update details if no changes made if no changes has been made for personal details, bring user back to details page and inform them that no changes has been made. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #35533|0 |1 is obsolete|| Attachment #35534|0 |1 is obsolete|| Attachment #35535|0 |1 is obsolete|| Attachment #35536|0 |1 is obsolete|| Attachment #35537|0 |1 is obsolete|| Attachment #35538|0 |1 is obsolete|| Attachment #35918|0 |1 is obsolete|| --- Comment #34 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41606 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41606action=edit Bug 12933 - Add ability to print overdue slip from staff intranet Some librarians would like to be able to print an overdues slip from the staff intranet. This slip would be defined as the print transport version of the ODUE slip. Test Plan: 1) Apply this patch 2) Locate a patron with overdues 3) Define a print version of the OVERDUES_SLIP slip 4) Try Print Print overdues Signed-off-by: Amy Purvis apur...@galencollege.edu Signed-off-by: Laurie McKee lmc...@littleelm.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #36 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41608 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41608action=edit Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #37 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41609 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41609action=edit Bug 12933 [QA Followup] - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #35 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41607 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41607action=edit Bug 12933 - Add new OVERDUES_SLIP letter Signed-off-by: Amy Purvis apur...@galencollege.edu Signed-off-by: Laurie McKee lmc...@littleelm.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #39 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41611 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41611action=edit Bug 12933 [QA Followup] - Remove Template plugin and use thereof -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #38 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41610 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41610action=edit Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #40 from Kyle M Hall kyle.m.h...@gmail.com --- By using a TT plugin, we don't have to modify each and every script that uses the members toolbar. Yes, but it's the way it's done everywhere into Koha. I still really don't like to see an other overhead to get this kind of info. There is no sacrifice or performance using this method. In fact, based on my followup, using the plugin results in somewhat better performance! The key here is that just because we've always done something in a particular way doesn't mean we should keep doing it that way. In fact, we have precedence for this very pattern. Once we introduced the plugin for getting system preferences, we began to remove the template parameters that only passed system preferences. There is no need to fetch the values in the script and pass them to the template, because the script has absolutely no need for them. Doing so only added unnecessary complexity and by using a plugin we greatly reduce that complexity. This is essentially the exact same issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #40749|0 |1 is obsolete|| Attachment #40750|0 |1 is obsolete|| Attachment #40751|0 |1 is obsolete|| --- Comment #39 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41579 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41579action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud alex.arn...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14580] Warn when accessing Help from error pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14580 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Severity|enhancement |minor Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- We would like a global solution here. themelanguage should be fixed not to return undef. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=6279 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
