[Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 --- Comment #9 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Joonas: If you want to change the patch, go ahead and change the status. But I do not mind pushing this tiny adjustment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #6 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- This is certainly an interesting development! But it might need some further (broader) discussion before getting in. In the first place: Why do we really need it? Can you elaborate/illustrate? If we add conditions, what kind of conditions do we want? Syntax? Etc. A broader design may be easier to maintain.. How do comparable systems implement this? If we add this for Zebra, what about other search engines? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13663] offline circ permission issue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 Mason James m...@kohaaloha.com changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #20 from Mason James m...@kohaaloha.com --- Pushed to 3.16.x, will be in 3.16.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10961] Error in GetMarcBiblio can cause severe data loss
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10961 Mason James m...@kohaaloha.com changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #14 from Mason James m...@kohaaloha.com --- Pushed to 3.16.x, will be in 3.16.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #144 from Marc Véron ve...@veron.ch --- Still applies. Still blocks Bug 12072: New dateformat dd.mm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #31 from Marc Véron ve...@veron.ch --- Still blocked by Bug 13813. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14487] Warns from returns.pl during checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Mason James m...@kohaaloha.com changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #20 from Mason James m...@kohaaloha.com --- Pushed to 3.16.x, will be in 3.16.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Mason James m...@kohaaloha.com changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #7 from Mason James m...@kohaaloha.com --- Pushed to 3.16.x, will be in 3.16.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703
--- Comment #10 from Joonas Kylmälä j.kylm...@gmail.com ---
(In reply to Marcel de Rooy from comment #8)
Hobby holiday project:
See newHolidays.pl
if ($description) {
$description =~ s/\r/\\r/g;
$description =~ s/\n/\\n/g;
}
I looked into that. Changing the new line into br didn't work in the because
then we need to also change the description editor to convert br to \r\n. So
it's similar fix to that what we do now when displaying the description (but
more changes with no reason). And so we have done already the fix to change the
description so I will go with the current patch.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703
--- Comment #8 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Hobby holiday project:
See newHolidays.pl
if ($description) {
$description =~ s/\r/\\r/g;
$description =~ s/\n/\\n/g;
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14749] Add API route to get top issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749 --- Comment #1 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 42047 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42047action=edit Bug 14749: Add API route /v1/topissues See Swagger specification for documentation Refactor opac-topissues.pl code into C4::Circulation::GetTopIssues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Blocks||14749 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749 [Bug 14749] Add API route to get top issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14749] Add API route to get top issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Depends on||13799 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14749] New: Add API route to get top issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749 Bug ID: 14749 Summary: Add API route to get top issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Web services Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org Add API route to get top issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #42037|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 42046 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42046action=edit Bug 14737: wrong permissions required for cn_browser.pl plugin The cn_browser.pl cataloguing plugin only searches for used callnumbers on the bibliographic database. There is no need for this plugin to require special permissions besides access to the catalog. To test: - Link the cb_browser.pl cataloguing plugin to 952$o in your favourite cataloguing framework - Login with a superlibrarian user - Try the plugin = SUCCESS: you can use it - Login with a user that has the full 'tools' permission - Try the plugin = SUCCSES: you can use it - Login with a user that doesn't have full 'tools' permission but has the normal catalogue and cataloguing permissions. - Try the plugin = FAIL: you are requested to login with a different user - Apply the patch - Retry = SUCCESS: you can use it - Sign off :-D Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14683] Unable to clear SMS number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14683] Unable to clear SMS number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #41664|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 42050 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42050action=edit Bug 14683: Unable to clear SMS number Enables to clear SMS number. To test: 1. Go to opac-messaging.pl 2. Insert SMS number and submit 3. Clear SMS number and submit 4. Observe that the sms number did not change 5. Apply patch 6. Clear SMS number and submit 7. Observe that the sms number changes Sponsored-by: Vaara-kirjastot Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Adding a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||m.de.r...@rijksmuseum.nl --- Comment #2 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Applying: Bug 10181: Acq - Improve message for deleted records fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added Attachment #41346|0 |1 is obsolete|| --- Comment #51 from Joonas Kylmälä j.kylm...@gmail.com --- Created attachment 42054 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42054action=edit Bug 13618: Use Template::Stash::AutoEscaping to use the html filter Test plan done and worked. I deleted the commits from 13609, and then applied this and it also solved the xss vulnerability. Signed-off-by: Joonas Kylmälä j.kylm...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula la...@student.uef.fi changed: What|Removed |Added Depends on||13799 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Lari Taskula la...@student.uef.fi changed: What|Removed |Added Blocks||14723 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 [Bug 14723] Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14751] Allow C4::Context-interface to be set to 'sip' or 'commandline'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added CC||j.kylm...@gmail.com --- Comment #52 from Joonas Kylmälä j.kylm...@gmail.com --- (In reply to Joonas Kylmälä from comment #51) Created attachment 42054 [details] [review] Bug 13618: Use Template::Stash::AutoEscaping to use the html filter Test plan done and worked. I deleted the commits from 13609, and then applied this and it also solved the xss vulnerability. Signed-off-by: Joonas Kylmälä j.kylm...@gmail.com Thought it worked, but now noticed it broked the html in /cgi-bin/koha/opac-tags.pl?mine=1 (my tags in opac). Under the title column it only shows html as plain text. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14751] Allow C4::Context-interface to be set to 'sip' or 'commandline'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 42061 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42061action=edit Bug 14751 - Allow C4::Context-interface to be set to 'sip' or 'commandline' Koha::Logger allows us to split up logging to separate files based on the interface. However, right now the interface is limited to just 'opac' or 'intranet'. We should extend this to allow the interface to also be set to 'sip' for SIP server logging, and to 'commandline' for cronjobs and all other command line scripts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14751] Allow C4::Context-interface to be set to 'sip' or 'commandline'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 --- Comment #11 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Yes it was a UNIMARC install. But same on a MARC21 fresh install. Check cn_source is hidden by default. Refresh cataloguing/additem.pl?biblionumber=109 The third column is hidden (damaged status). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #13 from Marc Véron ve...@veron.ch --- Created attachment 42048 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42048action=edit [Signed-off] Bug 14655: Add a warning if the checkin will fail On the checkin and checkout page, the checkin will fail if the patron has requested the privacy and the AnonymousPatron is not correctly set. This patch adds a warning message on both pages. Test plan: 0/ Be sure you don't have any patron with privacy=2 (Never) 1/ Set OPACPrivacy, not AnonymousPatron 2/ Go on the checkin, you should a warning (same as before this patch). 3/ Set the privacy=2 for a patron 4/ Go on the circulation page, a warning should appear (for this specific patron) 5/ Check an item out to this patron 6/ Check the item in on the checkin page. The item is not checked in and you get a specific message for this patron. Confirm other/correct situations don't trigger the messages. Followed test plan. Works as expected. Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch Attachment #41630|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14750] Rename borrowers.mobile to otherphone
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14750 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13142 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14750] Rename borrowers.mobile to otherphone
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14750 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14683 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #17 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Kyle M Hall from comment #16) (In reply to Jonathan Druart from comment #15) Kyle, what does the last patch set? I'm not sure what you mean. Can you explain? (Maybe a do is missing) What does the last patch set do? You have answered my comment 10 by a new patch set, but I don't want to compare the 2 patch sets (before and after my comment) to know if you have taken into account my comments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #9 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Marcel de Rooy from comment #8) Only this question: Why does the test abort with the DESTROY and does it only warn when I undef $builder ? Because the second DESTROY crashes the test :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14683] Unable to clear SMS number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 --- Comment #4 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 42051 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42051action=edit Bug 14683: [QA Follow-up] Mixup between mobile and smsalertnumber This is an issue discussed on older reports already in the past. Column mobile in borrowers is actually 'Other phone', not necessary a mobile number. The name of the field is confusing. (Renaming it is outside the scope of this report.) The field that we are editing here is smsalertnumber. It should not be compared with mobile at all. What could be the side-effect of this correction? === First, the change is only relevant for libraries with pref SMSSendDriver enabled. In the past patrons editing their message preferences saw mobile (read: other phone) in their smsalertnumber field (if the latter was still empty). If they saved it, it was copied to smsalertnumber. This change does not affect these patrons. They just have the same number in two columns. No big deal. What if a patron does not yet have a smsalertnumber? In that case no sms is sent in Letters.pm. So no change in behavior. If he submits opac-messaging now, he will no longer copy his other phone to smsalert [we cannot assume that it was mobile anyway!]. If he enters a mobile number, it will be saved correctly in the right field. Conclusion: this change will not break things or hurt anyone. It only prevents unwanted copying other phone to smsalertnumber. Also modified the compare to prevent uninitialized warnings. And removed a commented warn. Test plan: [1] Add, edit or delete the SMS number on opac-messaging regardless of the value of Other Phone (in the badly named mobile field). Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13142] Change mobile phone label back to other phone
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14750 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14683] Unable to clear SMS number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14750 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch --- Comment #5 from Marc Véron ve...@veron.ch --- Works as expected. However, C4/Letters.pm line 648 has forbidden pattern (trailing space chars). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #148 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Marcel de Rooy from comment #146) Marc: Why do you add MARC::Record in Acquisition.pm? It's a bad merge conflict, in the local branch I have, there is only -use C4::Dates qw(format_date format_date_in_iso); use MARC::Record; Now there is use C4::Dates qw(format_date format_date_in_iso); +use MARC::Record; It should be -use C4::Dates qw(format_date format_date_in_iso); -use MARC::Record; :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #1 from Lari Taskula la...@student.uef.fi --- Created attachment 42053 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42053action=edit Bug 14723 - Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue. They are useful, because there can be multiple reasons for a delivery to fail. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #42056|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 42059 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42059action=edit Used to test the change with/without first two patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #39146|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 42057 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42057action=edit Bug 14197: Remove the warning on destroying TestBuilder objects This module will be called by db_dependent tests, which already create a transaction. TestBuilder creates a new one (which is certainly useless) and the rollback does not do anything. To see the warning see patches on bug 14045. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
--- Comment #81 from Jonathan Druart jonathan.dru...@bugs.koha-community.org
---
(In reply to Robin Sheat from comment #80)
(In reply to Jonathan Druart from comment #79)
The first problem I got was to find a MARC21 DB (since the UNIMARC mappings
are not defined, I cannot test with an UNIMARC DB).
The UNIMARC mappings should be defined, though not tested.
Well, it's defined yes, but does not work at all (the marc21 mappings are used)
:)
It is caused by some errors in the sql file. Patch's coming.
Note the following:
MariaDB [koha_es_unimarc] insert into search_field (name, type) select
distinct mapping, type from elasticsearch_mapping;
Query OK, 73 rows affected, 57 warnings (0.05 sec)
Records: 73 Duplicates: 0 Warnings: 57
MariaDB [koha_es_unimarc] show warnings;
+-+--++
| Level | Code | Message|
+-+--++
| Warning | 1265 | Data truncated for column 'type' at row 1 |
and 72 others.
I have used the one created for the sandboxes
(http://git.koha-community.org/gitweb/?p=contrib/global.git;a=blob;f=sandbox/
sql/sandbox1.sql.gz;h=19268bccb43b2a33d5644b7d86cbb1abb323016b;hb=HEAD). But
there are only 436 biblios, it's not enough to test some stuffs (facets for
instance).
Or maybe you can share your DB?
I could, but I think we'll get more useful results from different databases.
Yes of course, but I am not a real tester, I am a developer, and it would be
useful to share info on specific data.
I am fine to use the sandbox DB, if it's ok for you.
Here some notes:
1/ Add deps to C4/Installer/PerlDependencies.pm
Yeah, I'm mostly waiting for things to settle (which they have now.)
2/ The number of tests provided is very low.
Yes, I've been meaning to go back and add a pile more.
Ok, I let it that for you :)
6/ Verbose does not work as expected, it could be fixed with
Oops. TODOed.
Patch is coming.
7/ perl -e use
Pod::Checker;podchecker('misc/search_tools/rebuild_elastic_search.pl');
*** WARNING: empty section in previous paragraph at line 36 in file
misc/search_tools/rebuild_elastic_search.pl
*** ERROR: =over on line 38 without closing =back at line EOF in file
misc/search_tools/rebuild_elastic_search.pl
TODOed.
Patch is coming.
8/ 2 occurrences of Solr reintroduced in installer/data/mysql/sysprefs.sql
and koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
Must have come about when merging. TODOed.
Patch is coming.
9/ Test!
c. Search for 'harry', sort by title AZ (screenshot
opac_search_for_harry_sort_by_title.png)
- 'Show more' links is displayed even if only 2 entries for a facet are
available
Thought I'd fixed that, I'll have to have a look again.
Patch is coming.
- The order is still different (The discovery of heaven should be sorted
either before Dollhouse (if the is a stopword) either after Hareios*
Dollhouse probably has another title field that's actually being used, as
noted above.
Yes it has:
title:[Dollhouse],[Seasons one two.]]
245$a Dollhouse
490$a Seasons one two.
But 245$a should be used for sorting :)
- The availability is wrong for ES (The item for Dollhouse is not for loan)
Why is it not for loan? Is it by policy, because there are no items, or
because all items are issued?
The item is a Visual Materials which has a itemtype.notforloan flag set.
d. Search for Books (limit by item type in the adv search), sort by pubdate
(screenshot limit_by_book_sort_by_pubdate.png)
- Return to the last advanced search link is not displayed
I wonder how it knows to show that...
I can't actually find that string in my checkout at all.
Yes sorry, introduced by Bug 13307: Create a link to the last advanced search
in search result page (OPAC).
Which is not in your branch yet.
- The item types facet contains several entries, which does not make sense
Curious. Are there situations where you have a biblio-level itemtype that
differs from the item-level item type, or where one biblio might have
multiple items with different item types? At the moment, I think they're all
being thrown into one facet pot.
It comes from biblioitems.itemtype=2WEEK
Not sure if the data I used are correct...
- The number of results highly differ (395 vs 364)
Probably due to biblio-vs-item itemtype selection not being supported yet.
If you can find it giving you a record that plain shouldn't match though,
that'd be interesting.
Outch, not sure how I could find that easily.
- The order is still completely different. I had a look in the index and
found:
Pictura murală* has pubdate: (/_search?q=_id:39pretty)
The Korean Go Association's learn to play go pubdate:
(/_search?q=_id:155pretty)
Where do come from these
[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #6 from Joonas Kylmälä j.kylm...@gmail.com --- (In reply to Marc Véron from comment #5) Works as expected. However, C4/Letters.pm line 648 has forbidden pattern (trailing space chars). I don't see any in that line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #4 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 42055 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42055action=edit Used to test the change -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #5 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Jonathan: I cannot reproduce with the simple third patch. What should I change there to see behavior change with/without your patches? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #40859|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 42058 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42058action=edit Bug 14197: TestBuilder - Remove the error on starting the transaction DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. DBIx::Class::Storage::DBI::txn_rollback(): Storage transaction_depth 0 does not match false AutoCommit of DBI::db=HASH(0xa429648), attempting ROLLBACK anyway at t/lib/TestBuilder.pm line 363 Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula la...@student.uef.fi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |la...@student.uef.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #90 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Something else, there is a sort issue in the facets: [Some entries] Zeitoun, Ariel, Ó Cadhain, Máirtín. Ślez, Ts.. Ó should be after O, not after Z. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #147 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Marcel de Rooy from comment #145) (In reply to Marc Véron from comment #144) Still applies. Still blocks Bug 12072: New dateformat dd.mm. Will have a look now. But the number of patches here is scary.. Do not know if I can finish this in one session. It's almost always the same changes. See comments 134-136 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #146 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Marc: Why do you add MARC::Record in Acquisition.pm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Needs Signoff |Patch doesn't apply --- Comment #59 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Applying: bug_11213: C4::VirtualShelves::Page::shelf_contents() fatal: sha1 information is lacking or useless (C4/VirtualShelves/Page.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #6 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Oops, I lost some changes in that test file. But what exactly should trigger the error on txn_begin or end in testbuilder? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #8 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Only this question: Why does the test abort with the DESTROY and does it only warn when I undef $builder ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14751] New: Allow C4::Context-interface to be set to 'sip' or 'commandline'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Bug ID: 14751 Summary: Allow C4::Context-interface to be set to 'sip' or 'commandline' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: kyle.m.h...@gmail.com QA Contact: testo...@bugs.koha-community.org Koha::Logger allows us to split up logging to separate files based on the interface. However, right now the interface is limited to just 'opac' or 'intranet'. I propose we extend this to allow the interface to also be set to 'sip' for SIP server logging, and to 'commandline' for cronjobs and all other command line scripts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #87 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 42067 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42067action=edit Bug 12478: Display the correct number of facets (5 instead of 6) The loop on facet entries was wrong, it should stop after 5 iterations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #85 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 42065 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42065action=edit Bug 12478: Fix pod in the rebuild_ES.pl script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #88 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 42068 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42068action=edit Bug 12478: Do not display the 'Show more' links if no more facet available -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #86 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 42066 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42066action=edit Bug 12478: Remove Solr occurrences reintroduced by a previous patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
--- Comment #89 from Jonathan Druart jonathan.dru...@bugs.koha-community.org
---
Created attachment 42069
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42069action=edit
Bug 12478: Fix encoding issue on facets
Filer on Ślez, Ts. = Can't escape \x{015A}, try uri_escape_utf8()
instead at
/home/koha/src/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 221.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #41631|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #14 from Marc Véron ve...@veron.ch --- Created attachment 42049 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42049action=edit [Signed-off] Bug 14655: Add a warning on the about page if patrons have requested privacy New warning on the about page if at least a patron has requested a privacy on checkin but the AnonymousPatron is not set to a valid patron. Works as expected. Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14750] New: Rename borrowers.mobile to otherphone
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14750 Bug ID: 14750 Summary: Rename borrowers.mobile to otherphone Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Borrowers.mobile is not mobile phone, but other phone. This had led to several misunderstandings (in the code too). We should rename the column. See also bug 13142 and bug 14683. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #145 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Marc Véron from comment #144) Still applies. Still blocks Bug 12072: New dateformat dd.mm. Will have a look now. But the number of patches here is scary.. Do not know if I can finish this in one session. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #149 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Jonathan Druart from comment #148) It should be -use C4::Dates qw(format_date format_date_in_iso); -use MARC::Record; :) Well no, it should be -use C4::Dates qw(format_date format_date_in_iso); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813
--- Comment #150 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Apart from the previous question, here are the results of the Dutch jury:
=head2 DelItem
@@ -2128,7 +2128,7 @@ Citems.withdrawn
sub _set_defaults_for_add {
my $item = shift;
-$item-{dateaccessioned} ||= C4::Dates-new-output('iso');
+$item-{dateaccessioned} || output_pref({ dt = dt_from_string, dateformat
= 'iso', dateonly = 1 });
$item-{$_} ||= 0 for (qw( notforloan damaged itemlost withdrawn));
}
OOPS: You lost an important character || instead of ||= !!!
C4/Members: $data-{message_date_formatted} = $d-output; [ no longer added ]
GetMessages
Not sure if you also resolved all calls of this sub accordingly.
Could you confirm?
C4/VirtualShelves
-$this_item-{'dateadded'} = format_date(
$this_item-{'dateadded'} );
+$this_item-{'dateadded'} = output_pref({ dt =
dt_from_string( $this_item-{'dateadded'} ), dateformat = 'iso', dateonly = 1
});
No iso ?
circ.bookcount
-lastdate= $lastdate ? format_date($lastdate) : 0,
+lastdate= $lastdate ? output_pref({ dt = dt_from_string(
$lastdate, 'iso' ), dateonly = 1 }) : 0,
No iso?
-format_date($date),
+output_pref({ dt = dt_from_string( $date, 'iso' ), dateonly = 1 }),
Again.
moremember
+$template-param( 'userdebarreddate' = output_pref({ dt =
dt_from_string( $debar, 'iso' ), dateonly = 1 }) );
Looks different
members/printfeercpt.pl
-my %row = ( 'date' = format_date($accts-[$i]{'date'}),
+my %row = ( 'date' = output_pref({ dt = dt_from_string(
$accts-[$i]{'date'}, 'iso' ), dateonly = 1 }),
No iso?
members/printinvoice.pl
Again
opac-showreviews.pl
+timestamp = strftime(%Y-%m-%dT%H:%M:%S-00:00, gmtime),
Could you confirm this is the same as rfc822
Since I see it more, would this be something for the KohaDates module too ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #151 from Marc Véron ve...@veron.ch --- Created attachment 42052 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42052action=edit Bug 13813 - [Follow-up] Remove C4::Dates from C4/Acquisition.pm Fix badly merged lines in C4/Acquisition.pm See comments #146-149 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #42059|Used to test the change |[DO_NOT_PUSH] Used to test description|with/without first two |the change with/without |patches |first two patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14536] PageObject-pattern base implementation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 --- Comment #12 from Lari Taskula la...@student.uef.fi --- Created attachment 42060 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42060action=edit Bug 14536: (follow-up) Add PageObject for members/notices.pl This patch adds a new PageObject Notices for members/notices.pl page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #25 from Colin Campbell colin.campb...@ptfs-europe.com --- Patch not working as advertised - in the rebasings it looks like we've lost the check of the config value to pass to checkin so the checked_in_ok variable is never passed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #42055|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 42056 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42056action=edit Used to test the change This seems to work like it should not.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #82 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 42062 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42062action=edit Bug 12478: Fix the UNIMARC and NORMARC indexing 1/ This patch fixes a major issue on UNIMARC and NORMARC installations (Compulsive c/p on insert into insert into search_marc_to_field for unimarc and normarc) 2/ After fixing that, I got invalid marc path at /usr/share/perl5/Catmandu/Fix/marc_map.pm line 35. on reindexing. It was caused by some values instead of NULL. 3/ Then, a duplicate entry error was caused by 3 lines for Local-number. It seems to be an error, 1 is enough (I suppose 0909 was an error too). Note that the following is not fixed by this patch: MariaDB [koha_es_unimarc] insert into search_field (name, type) select distinct mapping, type from elasticsearch_mapping; Query OK, 73 rows affected, 57 warnings (0.05 sec) Records: 73 Duplicates: 0 Warnings: 57 MariaDB [koha_es_unimarc] show warnings; +-+--++ | Level | Code | Message| +-+--++ | Warning | 1265 | Data truncated for column 'type' at row 1 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #83 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 42063 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42063action=edit Bug 12478: Change the commit count to 5k It will improve the indexing time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #84 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 42064 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42064action=edit Bug 12478: Fix the verbose flag on reindexing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Joonas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #27 from Tomás Cohen Arazi tomasco...@gmail.com --- Enhancement pushed to master. Nice one David! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com, ||nic...@bywatersolutions.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #9 from Joonas Kylmälä j.kylm...@gmail.com --- (In reply to Joonas Kylmälä from comment #8) (In reply to Marc Véron from comment #7) Created attachment 42077 [details] Screenshot from diff view - white chars in empty line 648 in C4/letters.pm Hi Joonas, There are some space chars in an empty line, see screenshot from diff view. Marc When I apply the patch and try to edit with Gedit, Atom, Nano none of these editors see the whitespace. Can you please make a follow-up where you remove it because I'm not able to. I think the problem is with the bugzilla's diff shower because in my patch I didn't even modify that line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14620] Contact information validations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula la...@student.uef.fi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- I would be happy to test this patch if it was not dependent on bug 14541. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14621] Messaging preferences table needs to be sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Lari Taskula la...@student.uef.fi changed: What|Removed |Added Assignee|oleon...@myacpl.org |la...@student.uef.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula la...@student.uef.fi changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #9 from Lari Taskula la...@student.uef.fi --- This patch makes both client and server side validations, both in OPAC and Staff client. Depends on Bug 14620. Test plan for Staff client: 1. Login to Staff client 2. Enable syspref ValidateEmailAddress and set ValidatePhoneNumber to ipn 3. Enable syspref TalkingTechItivaPhoneNotification and SMSSendDriver (write anything), and allow syspref EnhancedMessagingPreferences 4. Navigate to modify patron's information at memberentry.pl 5. Insert valid primary phone number, primary email address and SMS number 6. Check all messaging preferences and submit changes 7. Navigate to modify patron's information at memberentry.pl 8. Clear primary email, primary phone and SMS number fields and submit changes 9. Observe that the messaging preferences are disabled Test plan for OPAC: -1. Make sure sysprefs are set like in Staff client test step 2-3 1. Login to OPAC 2. Navigate to your personal details 3. Insert valid primary phone number, primary email address and SMS number 4. Submit changes 5. Login to Staff client 5.1. Navigate to Patrons 5.2. Approve information modification request 6. Back in OPAC, Navigate to your messaging 7. Check all messaging preferences and submit changes 8. Navigate to your personal details 9. Clear primary email, primary phone and submit changes 10. Repeat step 5 and 6 11. Observe that the messaging preferences are disabled for Phone and Email columns 12. Clear SMS number field and submit changes 13. Observe that all the messaging preferences are disabled This patch also includes a maintenance script at misc/maintenance/deleteMisconfiguredMessagingPrefs.pl that goes through all borrowers and automatically deletes their misconfigured messaging preferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 --- Comment #4 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 42071 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42071action=edit Bug 10181: Acq - Improve message for deleted records There are some issues here: 1/ Message not translatable (set in the pl file) 2/ ' by 'displayed even if no author defined 3/ Message not the same every where 4/ Nothing displayed on the invoice page Test plan: 1/ Create a basket 2/ Add 4 orders A, B, C, D 3/ On the basket, you see $title by $author, or $title if no author defined 4/ Delete order A, B 5/ Close the basket 6/ Receive B, C 7/ Delete record created for A, C 8/ Go on the basket page, you should see the title and Deleted bibliographic record, can't find title for the deleted record 9/ Go on the invoice page, you should see the title and Deleted bibliographic record, can't find title for the deleted record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 --- Comment #5 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Marcel de Rooy from comment #2) Applying: Bug 10181: Acq - Improve message for deleted records fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt). Repository lacks necessary blobs to fall back on 3-way merge. Oops, I have forgotten a patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Attachment #41776|0 |1 is obsolete|| --- Comment #53 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 42072 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42072action=edit Bug 13618: Specific for other prefs opacmainuserblock opacnav opacnavright opaccredits opacheader opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #2 from Lari Taskula la...@student.uef.fi --- To test template modifications: 1. Find a borrower with notices at members/notices.pl 2. Observe that there is no column for Delivery notes 3. Apply patch and run the given database update 4. Repeat step 1. 5. Observe that there is now a column for Delivery notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 --- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com --- (In reply to Marcel de Rooy from comment #6) This is certainly an interesting development! But it might need some further (broader) discussion before getting in. In the first place: Why do we really need it? Can you elaborate/illustrate? If we add conditions, what kind of conditions do we want? Syntax? Etc. A broader design may be easier to maintain.. How do comparable systems implement this? There are some situations where you need to add conditions as Barton told you. Possible conditions (the ones I had in mind are conditions on the indicator values, as I stated on the commit message). As Barton wrote, if you want to send a field/subfield to a different index depending on the value of the indicators, you can do it with this. If you look at it, we already do it for authority records, but with a more complex syntax. Look at authority-koha-indexdefs.xml: kohaidx:index_heading_conditional tag=450 test=substring(marc:subfield[@code='w']/text(), 2, 1) subfields=abvxyz subdivisions=vxyz kohaidx:target_indexPrevious-heading-see-from:p/kohaidx:target_index /kohaidx:index_heading_conditional the whole syntax is similar to the one i implement, but you need to add a new tag name if you want conditional indexing, while i just overload the current syntax, which is really convenient. If we add this for Zebra, what about other search engines? Each search engine provides means to specify what/how to index. I guess stuff like ES are more flexible than Zebra, for sure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #14 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Thanks Frederick and Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #8 from Joonas Kylmälä j.kylm...@gmail.com --- (In reply to Marc Véron from comment #7) Created attachment 42077 [details] Screenshot from diff view - white chars in empty line 648 in C4/letters.pm Hi Joonas, There are some space chars in an empty line, see screenshot from diff view. Marc When I apply the patch and try to edit with Gedit, Atom, Nano none of these editors see the whitespace. Can you please make a follow-up where you remove it because I'm not able to. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14620] Contact information validations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added Attachment #41502|0 |1 is obsolete|| Attachment #41527|0 |1 is obsolete|| --- Comment #10 from Joonas Kylmälä j.kylm...@gmail.com --- Created attachment 42080 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42080action=edit Bug 14620 - Contact information validations I'm thinking we should centralize all patron's contact information validators into one module. Currently we only have validations for e-mail addresses, using the Email::Valid module. In our local library we also want to validate phone numbers with a regex that only recognizes phone numbers from my country. So I suggest we create a phone number validation as well, with an option to easily create custom regex for your local use. If a library does not wish to use validations, we should give them an option to turn them off. If more local validators are implemented, we should also give the library an option to select which validator they wish to use. With this method we could implement phone number validators from around the world and add them into our module. Then we would make the validations simply by calling our validator. The validator would know by system preference which one of the implemented phone number validators it should use. Validations should be both client and server side. Test plan: 1. Apply the patches (and run updatedatabase.pl). 2. Set system preferences ValidateEmailAddress to Enable and ValidatePhoneNumber to International Phone Numbers. 3. Make sure JavaScript is enabled. 4. Navigate to edit user contact informations in Staff client and OPAC. 5. Clear email and phone fields. 6. Insert whitespaces to email and phone fields and submit the form. 7. Edit patron. 8. Observe that there are no longer whitespaces in email and phone fields. 9. Insert invalid email (e.g. invalid) and invalid phone number (+123invalid) and send the form. 10. Confirm that form will not be submitted and errors will be given. 11. Disable JavaScript. 12. Insert invalid email and invalid phone number 13. Try sending the form again. 14. Confirm that form will be submitted but errors will be given on top of the form. 15. Observe that none of the changes are accepted. 16. Set system preferences ValidateEmailAddress to Disable and ValidatePhoneNumber to none. 17. Repeat step 3-9 but observe that errors will not be given and changes will be submitted and saved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #54 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 42073 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42073action=edit Bug 13618: Specific for XSLTBloc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 --- Comment #7 from Barton Chittenden bar...@bywatersolutions.com --- (In reply to Marcel de Rooy from comment #6) This is certainly an interesting development! But it might need some further (broader) discussion before getting in. In the first place: Why do we really need it? Can you elaborate/illustrate? If we add conditions, what kind of conditions do we want? Syntax? Etc. A broader design may be easier to maintain.. How do comparable systems implement this? If we add this for Zebra, what about other search engines? Marcel, The functionality definitely *is* needed -- see, for instance bug 14277, where the meaning of 521$a varies drastically based on the value of ind1. The 'condition=' syntax feels like overkill to me -- before work with the inicators, I assumed that the arguments to the index_subfields xml tag were essentially limits that were ANDed together... I guess they're not, but I think that we could pull a 'convention over configuration' fast one and pretend that they are: 'tag' and 'subfield' are required attributes, specifying the marc field and subfield, alll other attributes are limits -- if not present, all matching tags/subfields will be used. ...or we could go with the 'condition=' syntax, and make it explicit. I'm fine either way, as long as I can limit by indicator. :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #25 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Thanks Christophe and Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
