[Koha-bugs] [Bug 14476] Improving opac-search performances

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

--- Comment #3 from Gaetan Boisson  ---
Works for me, although the performance gain was not as big as expected. I will
test it again on a larger data set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14476] Improving opac-search performances

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

Gaetan Boisson  changed:

   What|Removed |Added

 CC||gaetan.bois...@biblibre.com
  Attachment #40740|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304

--- Comment #1 from Héctor Eduardo Castro Avalos  ---
Created attachment 42178
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42178=edit
Bug 14304 - RDA: Display link in XSLT for 264 field to reflect Zebra indexing

This patch add display link in XSLT for 264 for bug 14198 and reflect the Zebra
indexing.

Test plan
1) Follow test plan for bug 14198
2) Apply the bug 14198
3) Do a search by pv: or pb:
4) Look that there no display link for 264 field.
5) Apply the patch
6) In a like maner of step 3 and 4, check out the new link for 264 field.
7) Check out the display link in OPAC and staff clint

Sponsored-by: Universidad de El Salvador

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #62 from M. Tompsett  ---
(In reply to Marcel de Rooy from comment #61)
> Repeated on fresh master:
> Applying: bug_11213: C4::VirtualShelves::Page::shelf_contents()
> fatal: sha1 information is lacking or useless (C4/VirtualShelves/Page.pm).
> Repository lacks necessary blobs to fall back on 3-way merge.
> Cannot fall back to three-way merge.
> Patch failed at 0001 bug_11213: C4::VirtualShelves::Page::shelf_contents()
> 
> Since our git version may be different, please apply them again with your
> git version and resubmit.

mtompset@debian:~/kohaclone$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
mtompset@debian:~/kohaclone$ git branch -D bug_11213_restart
Deleted branch bug_11213_restart (was 113c548).
mtompset@debian:~/kohaclone$ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
mtompset@debian:~/kohaclone$ git pull
Already up-to-date.
mtompset@debian:~/kohaclone$ git remote update -p
Fetching origin
mtompset@debian:~/kohaclone$ git checkout -b bug_11213_restart origin/master
Branch bug_11213_restart set up to track remote branch master from origin.
Switched to a new branch 'bug_11213_restart'
mtompset@debian:~/kohaclone$ git bz apply 11213
Bug 11213 - GetItemsInfo() called twice

39023 - bug_11213: Changed XSLTParse4Display() interface
39024 - bug_11213: whitespace correction
39025 - bug_11213: Include XSLT processing for searchResults() test
39026 - bug_11213: C4::VirtualShelves::Page::shelf_contents()
39027 - bug_11213: GetItemsInfo() test
39028 - bug_11213: Added XSLTParse4Display() to Items test
39029 - bug_11213: Check for $item->{itype} presence to avoid warning

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: bug_11213: Changed XSLTParse4Display() interface
Applying: bug_11213: whitespace correction
Applying: bug_11213: Include XSLT processing for searchResults() test
Applying: bug_11213: C4::VirtualShelves::Page::shelf_contents()
Using index info to reconstruct a base tree...
M   C4/VirtualShelves/Page.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/VirtualShelves/Page.pm
Applying: bug_11213: GetItemsInfo() test
Applying: bug_11213: Added XSLTParse4Display() to Items test
Using index info to reconstruct a base tree...
M   t/db_dependent/Items.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Items.t
Applying: bug_11213: Check for $item->{itype} presence to avoid warning
mtompset@debian:~/kohaclone$

It works fine for me with Debian Jessie.
Did you check if your 'git bz' is up to date?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14476] Improving opac-search performances

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion
 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi  ---
I have a concern: if we cache the record to be displayed, then the item
statuses won't be up-to-date. If the tradeoff is not enough, maybe this is just
not worth. Because people expect to see updated information on the records.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Blocks||14304


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304
[Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Depends on||14198


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198
[Bug 14198] RDA: Indexing 264 field (Zebra)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14476] Improving opac-search performances

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

--- Comment #2 from Gaetan Boisson  ---
Created attachment 42179
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42179=edit
[SIGNED-OFF] bug 14476 : Caching C4::XSLT::transformMARCXML4XSLT

This patch is improving the opac-search performances by
caching the results of C4::XSLT::transformMARCXML4XSLT

My tests (with Devel::NYTProf) showed a gain of about
65% on C4::XSLT::transformMARCXML4XSLT and
35% on C4::XSLT::XSLTParse4Display.

The gain of performances is increasing with the numbers
of results.

Signed-off-by: Gaetan Boisson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14476] Improving opac-search performances

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

Gaetan Boisson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
Hm, UsageStatsLibraryType already is a drop down, without this patch for me? 
I am also a bit worried about the country, because how complete of a list can
we get and where?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #5 from Katrin Fischer  ---
Hm, this looks to me like the bug is not so much in the staged import, but in
the data - it looks like you might be importing with an itemtype code that is
not defined in your database (942$c). Once you open and save the record again,
the itemtype will probably be set to the first in the pull down of available
codes... and that's why the checkout works after. Could this be possible?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #22 from Jonathan Druart  
---
"For a while" meant " I didn't find any versions where it works.

If you check out the commit before "Bug 5917 : Swapping templates over"
(d4cd05126da3accef83144d8322fcd455d7eba9b), you will see the same structure in
the TT:

128 Waiting


But no track of a atdestination variable passed to the template.

So if this is correct, I am sure nobody will care if we remove this tab :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12952] Log koha actions to syslog too

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12952

--- Comment #6 from Joonas Kylmälä  ---
(In reply to Srdjan Jankovic from comment #5)
> > -chown "$username:$username" "/var/log/koha/$name"
> > +chown "$username:adm" "/var/log/koha/$name"
> > 
> > The last line should not have the group adm but $username instead.
> 
> This is because in case of a multi-site installation we may want to have an
> external process to be able to access all individual site logs. Without a
> common group it makes it hard to manage.

But do we have some script to change the group (during installation)? Hmm.. I'm
not so sure about this. Maybe there could be some config file (not sure if
there is one already for this kind of things) where it could be changed to one
that the user wants or if not specified it would default to $username.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13671] Search returning empty

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671

Ketan Kulkarni  changed:

   What|Removed |Added

 CC||ke...@carvingit.com

--- Comment #4 from Ketan Kulkarni  ---
I am also facing the same issue in koha 3.20.3.

Not sure if any part of the code will need an update to work with CGI::Param.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #7 from Katrin Fischer  ---
005 is a timestamp of the last change and the first positions of the leader
that change are the record length - this change being caused by the other
changes. 
So I think Koha's current behaviour is correct and nothing needs to be changed
on import. I think what we could do is catch an invalid itemtype code better,
so it's easier to locate the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12289] stage_file.pl does not allow control of nomatch options

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289

--- Comment #5 from Joonas Kylmälä  ---
Now it looks to me that this is working as it should. Someone, sign-off this
please! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14363] OAI-PMH should handle records without marcxml

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363

--- Comment #2 from Julian Maurice  ---
Created attachment 42135
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42135=edit
Bug 14363: OAI-PMH: Handle records without marcxml

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #140 from Julian Maurice  ---
The 'borrowers' permission is required for both /borrowers and /borrowers/
except if  is the borrowernumber of the loggedinuser

Test plan for authentication:
  1/ Log in to staff interface with a borrower that have 'borrowers' permission
  2/ Go to http://INTRANET/api/v1/borrowers and
http://INTRANET/api/v1/borrowers/ (where  is a valid borrowernumber).
You should see borrowers data
  3/ Remove the 'borrowers' permission
  4/ Go to http://INTRANET/api/v1/borrowers. You should see an error (and HTTP
code 403)
  5/ Go to http://INTRANET/api/v1/borrowers/ (where  is a valid
borrowernumber different from the logged-in user's borrowernumber). You should
see an error (and HTTP code 403)
  6/ Go to http://INTRANET/api/v1/borrowers/ (where  is the logged-in
user's borrowernumber). You should see borrower's data.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #4 from Joonas Kylmälä  ---
(In reply to Katrin Fischer from comment #3)
> Joonas, this is rather confusing me :) We use the staged imports a lot and
> have never run into problems like you describe. Could you show which
> elements were missing in your record?

Output from diff of MARCXML files:

...

-  00977cam a22003374a 4500
+  00961cam a22003374a 4500

...

-  20150831135648.0
+  20150831142850.0

...

-KI
-2013-08-26 00:00:00
+BK
+ddc

After those changes were made the bug 14755 didn't show up anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12289] stage_file.pl does not allow control of nomatch options

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289

--- Comment #4 from Joonas Kylmälä  ---
Created attachment 42134
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42134=edit
Bug 12289: (follow-up) fix the compilation error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14363] OAI-PMH should handle records without marcxml

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363

--- Comment #1 from Julian Maurice  ---
In master, due to bug 3206, a biblio without marcxml is considered deleted and
thus there is no error.

However, something can be done for stable versions.

In 3.18.x and 3.20.x, oai.pl fails with the following error:

Empty String at /home/koha/src/opac/oai.pl line 228

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14363] OAI-PMH should handle records without marcxml

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363

Julian Maurice  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14363] OAI-PMH should handle records without marcxml

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363

Julian Maurice  changed:

   What|Removed |Added

Version|master  |3.20
 Status|ASSIGNED|Needs Signoff

--- Comment #3 from Julian Maurice  ---
Patch is for 3.20.x but should apply well on 3.18.x as well

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com

--- Comment #2 from Joonas Kylmälä  ---
(In reply to Mason James from comment #1)
>1/ add a bunch of single_holidays to your test koha, (my table has 400 holiday 
>>rows)

Could you give some example table? It would be easier to test.

>2/ add a loong circ rule for an itemtype (my rule has 140 days)

Do you mean loan period?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #15 from David Cook  ---
I think I've nearly arrived at a first draft.

On Friday, I'll look at writing out test plans/instructions, and doing some
last minute changes. 

I still need to fix the POD, add unit tests, and add help pages, but I figure
that can wait until some initial testing is finished, since the first round of
testing might bring more changes to make...

I'm excited though! This is probably the closest the OAI-PMH harvester code has
ever come to actually being usable for other people than just myself :p

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14363] OAI-PMH should handle records without marcxml

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363

Julian Maurice  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |julian.maur...@biblibre.com
   |ity.org |
 CC||julian.maur...@biblibre.com
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #6 from Joonas Kylmälä  ---
(In reply to Katrin Fischer from comment #5)
> Hm, this looks to me like the bug is not so much in the staged import, but
> in the data - it looks like you might be importing with an itemtype code
> that is not defined in your database (942$c). Once you open and save the
> record again, the itemtype will probably be set to the first in the pull
> down of available codes... and that's why the checkout works after. Could
> this be possible?

Adding an item type entry in Koha for code KI solved the problem indeed.

But I think the feature Edit biblio adds still some other data. So why not do
that already in import stage, because some data might be vital(?).

-  00977cam a22003374a 4500
+  00961cam a22003374a 4500

For example, should the line above be like that or is it enough that there is
the old line / is this some info which we really don't need but we just happen
to have?

And I got the picture from that Edit record feature, by quickly looking at the
code, that it also adds some missing subfields. So what if these imported
records don't have those subfields and it will cause some problems... (and then
the only fix would be go one by one through the imported records or fixing the
data some how)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12289] stage_file.pl does not allow control of nomatch options

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com

--- Comment #3 from Joonas Kylmälä  ---
I get this error when running the script after the patch:

Global symbol "$no_create" requires explicit package name at
./misc/stage_file.pl line 57.
Global symbol "$no_create" requires explicit package name at
./misc/stage_file.pl line 123.
Execution of ./misc/stage_file.pl aborted due to compilation errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12952] Log koha actions to syslog too

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12952

--- Comment #7 from Srdjan Jankovic  ---
(In reply to Joonas Kylmälä from comment #6)

> But do we have some script to change the group (during installation)? Hmm..
> I'm not so sure about this. Maybe there could be some config file (not sure
> if there is one already for this kind of things) where it could be changed
> to one that the user wants or if not specified it would default to $username.

That is an interesting idea, and I could even implement it in the debian
config. Although I must say that adm group sounds good enough for me (you don't
give adm to everyone). Another possibility is to create a koha group and put
all sites to that group. How do we go about making decisions like that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8073] Sound cue when checking in items on hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8073

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9817] Add Goodreads reviews tab to the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9817

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #13 from Christopher Brannon  ---
Would love to see this feature.  Interested in the GoodReads content enhancing
Koha.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14685] Cannot set guarantor for a child account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14584] Encoding broken with system preferences

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14584] Encoding broken with system preferences

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #41641|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 42183
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42183=edit
[PASSED QA] Bug 14584: Encoding broken with system preferences

The pref are double encoded.

From bug 12411:
"This will fix the encoding issues existing in 3.14 and 3.16.
The issue still appear in master but is fixed by bug 11944."

They should not have been pushed together.

Test plan:
1) You need an accentuated language installed.
2) Go to NoLoginInstructions pref, and add some accentuated message like
"Hélo médames é mècieüx"
3) refresh opac home page, message should be gibberish
4) apply patch.  Message should be ok now.

Signed-off-by: Tomas Cohen Arazi 
Works as expected.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #11 from Katrin Fischer  ---
Opac works great, but I can't trigger the message changing my password from the
'Change password' page in staff
(http://localhost:8080/cgi-bin/koha/members/member-password.pl?member=1)
It seems to work alright without this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14435] The table saved_reports is never populated

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435

--- Comment #13 from Katrin Fischer  ---
What I am missing here a bit is an idea about what this code was actually used
for in the past. 

According to my research it seems like you used to be able to store the results
of a report in that table - which got broken at some point. We have a newer bug
report asking for such a feature:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10627

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14567] Browse interface for OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

--- Comment #14 from Robin Sheat  ---
(In reply to Heather from comment #13)
> Oh, right!  I'm sorry, I think I wasn't very clear--I was trying to say that
> there's no way right now for a user to ever see the subject headings with
> subdivisions as used in the records.  Maybe this new browse feature, when
> browsing subjects, could return an alphabetic list of subject headings
> *with* subdivisions from the records.  I hope this is clearer!

Ah, this will do that. You just can't see it because this catalogue doesn't
handle subjects like that.

> Our catalog is not the cleanest (I haven't done all our authority work &
> headings clean up), but it's pretty good--if there's any way our records, a
> subset of our records, or even we can help with this, we'd be very, very
> happy to help.  Our catalog is here, http://keys.bywatersolutions.com/
> supported by ByWater, so perhaps if y'all working on this bug contact
> Brendan at ByWater, there's a way that we can help test with our catalog? 
> Or perhaps even ByWater could make our records or a subset of our records
> available so y'all have a more "cataloged catalog" for testing?

More test data is good, I've pinged Brendan to have a look into it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14197] Warning raised by TestBuilder

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #13 from Katrin Fischer  ---
Can I get a test plan please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12952] Log koha actions to syslog too

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12952

--- Comment #8 from Robin Sheat  ---
I think Srdjan is right here. As a rule of thumb, logs are group-owned by adm
so that any user in the adm group can view them. This applies to things like
syslog, mysql logs, mail logs, etc. 

I had a quick look and couldn't find a policy about it, but it seems to be the
de facto thing to do.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown when created from Patron search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

--- Comment #7 from Katrin Fischer  ---
Hm interesting: It doesn't really add a new list, but it adds another entry to
the drop down every time you hit 'save'. Once you reload the page the double
ups in the pull down are gone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14696] useless use of String::Random in catalogue/search.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #41699|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 42186
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42186=edit
[PASSED QA] Bug 14696: useless use of String::Random in catalogue/search.pl

Bug 10404 adds the use of String::Random to catalogue/search.pl but bug
11369 removes it without removing the import line.

Test plan:
  git grep String::Random catalogue/search.pl
should not return anything

Signed-off-by: Joonas Kylmälä 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14764] Add OPAC News branch selector

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

--- Comment #9 from Martin Persson  ---
Apply the RSS fix last to avoid conflict.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13924] LocalHoldsPriority needs dateaccessioned limits.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13924

Joel Sasse  changed:

   What|Removed |Added

 CC||jsa...@plumcreeklibrary.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12885] Search fails with errors when HTML5 Media is enabled and url has plus (+) characters

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12885

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|Search fails with errors|Search fails with errors
   |when HTML5 Media is enabled |when HTML5 Media is enabled
   |and url has plus (+)|and url has plus (+)
   |charcters   |characters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12885] Search fails with errors when HTML5 Media is enabled and url has plus (+) charcters

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12885

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14579] 'You are not logged in' should link to log in page

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #8 from Liz Rea  ---
This patch moved the help menu from the top right, next to the login menu to
inside the dropdown. I don't think we want to hide it like that.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14683] Unable to clear SMS number

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

--- Comment #10 from Katrin Fischer  ---
I feel a bit like Marcel kidnapped the bug ;)... but the changes make sense to
me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14685] Cannot set guarantor for a child account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
One small thing - I think the pop up window is not wide enough now. It forces
you to make it bigger to be able to actually add the patron. Would be good to
adjust that as a follow up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14685] Cannot set guarantor for a child account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685

--- Comment #8 from Katrin Fischer  ---
... or separately :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14696] useless use of String::Random in catalogue/search.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14683] Unable to clear SMS number

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #42162|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14683] Unable to clear SMS number

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #42050|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #41091|0   |1
is obsolete||

--- Comment #17 from Katrin Fischer  ---
Created attachment 42184
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42184=edit
[PASSED QA] Bug 13943: Prevent the deletion of items if the user cancels

On the edit items page, there is some weird JS code: if the user clicks
on the delete link and then cancel, the item is deleted anyway.

It's caused by the following JS code in browser.js
  $('a[href*="biblionumber="]').click(function (ev) {
  ev.preventDefault();
  window.location = $(this).attr('href') + '=' + me.searchid;
  });

Test plan:
- Do a search with multiple results
- Go to the detail page (make sure results browser shows up!)
- Use the "Edit items" link from the toolbar
- Delete an item (try both way)
- Choose "cancel"
- Delete an item (try both way) and confirm the deletion
You should see the browser after the deletion and the item should have
been deleted correctly.
- Edit an item (try both way)
You should see the browser (did not work before this patch)

Note: Before this patch, the 2 first columns didn't contain the
edit/delete item links, now it's only the 1st one.

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 
Much better!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8291] patron import should show error names

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8291

Danielle Elder  changed:

   What|Removed |Added

 CC||danielle@bywatersolutions.c
   ||om

--- Comment #2 from Danielle Elder  ---
Agreed, borrower specific feedback would be great.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14696] useless use of String::Random in catalogue/search.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696

--- Comment #4 from Katrin Fischer  ---
It looks like this had been added as part of 762c3304 (Bug 10404 - add
previous/next browsing to staff client), but the code has since changed and I
couldn't spot a regression.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14685] Cannot set guarantor for a child account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #41640|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 42180
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42180=edit
[PASSED QA] Bug 14685: Fix set guarantor for a child or professional accounts

Bug 13970 removed some useful code to automatically set the guarantor
when creating a child.

But finally there is a better way to do the job, we just need to assume
that only children or professional can have a guarantor.

Test plan:
1/ Create an adult patron and add a child.
2/ The guarantor info should be retrieved and set on the child creation
page.
3/ Create an organization and add a child
4/ The guarantor info should be retrieved and set on the adult creation
page.

Signed-off-by: Liz Rea 
This patch catches both cases, thanks Jonathan!

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

--- Comment #10 from Katrin Fischer  ---
Maybe it could be a good enh to add something like: "Your password hasn't been
changed." to the message in the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #16 from Katrin Fischer  ---
Patch doesn't apply due to a conflict in Circulation.t - can you please fix?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14709] The export tool is broken if used from the command line

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14709] The export tool is broken if used from the command line

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #41847|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 42185
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42185=edit
[PASSED QA] Bug 14709: Do not access to C4::Context->userenv from the
commandline

The script dies with
  Can't use an undefined value as a HASH reference at tools/export.pl
line 149.
if it is called from the command line.

This is introduced by bug 13040.

The C4::Context->userenv is not defined in this case.

Test plan:
Execute the script using the command line.
With the patch applies you should not get the error.

Signed-off-by: Joonas Kylmälä 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown when created from Patron search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
There is something going wrong here:

1) Go to patron search home page
2) Launch a search (I used "d")
3) Check one patron, say [New list] from pull down
4) Name the list, hit the save button behind it
5) Check another patron, pull down list still shows newly created list - hit
save again
6) Another list with the same name is added

It will always create a new list - even if you switch the pull down to another
preexisting list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12965] can create an item type that already exists

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12965] can create an item type that already exists

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #41456|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 42181
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42181=edit
[PASSED QA] Bug 12965: Prevent to erase an existing item type

On creating an item type, if it already exists, it will replace the
existing one.
This patch prevent that and display a message to the interface.

Note: The fields are lost.

Test plan:
1/ Create an item type 'AAA', description 'AAA'
2/ Edit it, update the description with 'BBB'
3/ Create an item type 'AAA' with a description 'CCC' => you should get
a warning "already exists".

Works well, no errors

Signed-off-by: Amit Gupta 
Signed-off-by: Joonas Kylmälä 

Signed-off-by: Katrin Fischer 
Warning message is triggered.
Adding, editing and deleting item types still works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12885] Search fails with errors when HTML5 Media is enabled and url has plus (+) charcters

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12885

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #41523|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 42182
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42182=edit
[PASSED QA] Bug 12885: Fix if url contains +*... and HTML5 Media is enabled

The special regex chars are not escaped in C4::HTML5Media.

Test plan:
1/ Set 856$u=http://www.mrqe.com/lookup?talented+mr.+ripley
2/ Enable the pref HTML5Media
3/ Go on the detail page
It should not explode.

Signed-off-by: Mirko Tietgen 
Signed-off-by: Joonas Kylmälä 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14683] Unable to clear SMS number

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

--- Comment #8 from Katrin Fischer  ---
Created attachment 42188
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42188=edit
[PASSED QA] Bug 14683: [QA Follow-up] Mixup between mobile and smsalertnumber

This is an issue discussed on older reports already in the past.
Column mobile in borrowers is actually 'Other phone', not necessary a
mobile number. The name of the field is confusing. (Renaming it is
outside the scope of this report.)
The field that we are editing here is smsalertnumber. It should not be
compared with mobile at all.

What could be the side-effect of this correction?
===
First, the change is only relevant for libraries with pref SMSSendDriver
enabled.
In the past patrons editing their message preferences saw mobile (read:
other phone) in their smsalertnumber field (if the latter was still empty).
If they saved it, it was copied to smsalertnumber.
This change does not affect these patrons. They just have the same number
in two columns. No big deal.
What if a patron does not yet have a smsalertnumber? In that case no sms
is sent in Letters.pm. So no change in behavior. If he submits
opac-messaging now, he will no longer copy his other phone to smsalert [we
cannot assume that it was mobile anyway!]. If he enters a mobile number,
it will be saved correctly in the right field.

Conclusion: this change will not break things or hurt anyone. It only
prevents unwanted copying other phone to smsalertnumber.

Also modified the compare to prevent uninitialized warnings.
And removed a commented warn.

Test plan:
[1] Add, edit or delete the SMS number on opac-messaging regardless of
the value of Other Phone (in the badly named mobile field).

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14683] Unable to clear SMS number

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

--- Comment #9 from Katrin Fischer  ---
Created attachment 42189
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42189=edit
[PASSED QA] Bug 14683: [QA Follow-up] Similar change for staff

Script memberentry.pl contained a similar line.
Solution is simpler here.

Test plan:
[1] Add, change or clear the sms number at staff side.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14683] Unable to clear SMS number

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #42051|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14683] Unable to clear SMS number

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

--- Comment #7 from Katrin Fischer  ---
Created attachment 42187
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42187=edit
[PASSED QA] Bug 14683: Unable to clear SMS number

Enables to clear SMS number.

To test:
1. Go to opac-messaging.pl
2. Insert SMS number and submit
3. Clear SMS number and submit
4. Observe that the sms number did not change
5. Apply patch
6. Clear SMS number and submit
7. Observe that the sms number changes

Sponsored-by: Vaara-kirjastot

Signed-off-by: Marcel de Rooy 
Adding a follow-up.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14683] Unable to clear SMS number

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14749] Add API route to get top issues

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749

Zeno Tajoli  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 CC||z.taj...@cineca.it

--- Comment #2 from Zeno Tajoli  ---
Patch complexity is 'Medium' because this change has many architectural
connections

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14722] Refactor the export tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14764] Add OPAC News branch selector

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

Martin Persson  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #6 from Martin Persson  ---
Test plan:

1) Add more libraries, at least two in total is needed. Make note of whoich is
your current user's home branch.
2) Go to Tools -> News and add one global ("All") news item and one specific
for each branch.
3) Apply the patches.
4) Perform database upgrades when you log in.
5) Go to OPAC main, it should work as before: Showing global news as well as
the news for your home branch once logged in.
6) Go to System Preferences -> OPAC and set 'OPACNewsBranchSelect' to yes.
7) Go to OPAC main, you should see the global news item plus any items for your
home branch for the current user if logged in.
8) On the left side all branches should be listed as links. Select one, you
should now see global news and the news for the selected branch, regardless of
whether logged in or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

Zeno Tajoli  changed:

   What|Removed |Added

 CC|z.taj...@cineca.it  |
   Patch complexity|--- |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

--- Comment #3 from Jonathan Druart  
---
Comment on attachment 41633
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41633
Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as
ISBN

Review of attachment 41633:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14607=41633)
-

::: koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc
@@ +58,4 @@
> class="[% coce_id %]" id="coce-thumbnail-preview-[% coce_id %]">
>  [% END %]
>  [% IF ( BakerTaylorEnabled ) %]
> +[% bt_id = ( item.browser_normalized_upc 
> || item.browser_normalized_upc ) %]

This does not make any sense :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #61 from Marcel de Rooy  ---
Repeated on fresh master:
Applying: bug_11213: C4::VirtualShelves::Page::shelf_contents()
fatal: sha1 information is lacking or useless (C4/VirtualShelves/Page.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 bug_11213: C4::VirtualShelves::Page::shelf_contents()

Since our git version may be different, please apply them again with your git
version and resubmit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Zeno Tajoli  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Zeno Tajoli  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14747] RESTful API with reverse proxy configuration

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14747

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
   Patch complexity|--- |Medium patch

--- Comment #2 from Zeno Tajoli  ---
Patch complexity is 'Medium' because this change has many architectural
connections

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14717] Adding a new patron can end up with 0000-00-00 as the debarred date

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Zeno Tajoli  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14746] Set up logging and configuration file reading for Mojolicious

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14746

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
   Patch complexity|--- |Large patch

--- Comment #2 from Zeno Tajoli  ---
Patch complexity is 'Large' because this change has many architectural
connections

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Zeno Tajoli  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204

Zeno Tajoli  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13927] Add API route to check hold capabilities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13927

Zeno Tajoli  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510

--- Comment #14 from Jonathan Druart  
---
Ok, I found why it does not work: dateaccessioned is not mapped.

Same with my previous example, barcode is not mapped on my local install.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #153 from Marcel de Rooy  ---
(In reply to Marc Véron from comment #152)
> Hi Marcel,
> 
> Thanks a lot for QAing. I really appreciate.
> 
> Question: 
> Can we remove the 'problematic' patches from this huge patch set and then do
> a second round (maybe with a new bug number) after the 'unproblematic'
> patches have been pushed?
> 
> Marc

It seems to that your corrections should not be that hard or time consuming.
I would favor to reduce the number of patches here. There is no particular need
to add a patch for each module or script.

But of course, I have no objection if you move some patches elsewhere.

Please set back to SO if you are ready..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204

--- Comment #5 from Jonathan Druart  
---
(In reply to Bernardo Gonzalez Kriegel from comment #4)
> (In reply to Jonathan Druart from comment #1)
> > Test plan:
> > 1/ Define RESERVESLIP with, at least,
> > Hold until: <>
> 
> On current master RESERVESLIP belongs to 'circulation' module,
> on edit there is no access to 'reserves' values.
> 
> If you change first to 'Holds' module, and save, 
> then you can access 'reserves' values.
> 
> Could be this the cause of the problem?

No, the value is not retrieved from the DB.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526

--- Comment #15 from Marcel de Rooy  ---
Thx Joonas for signing off.
I have moved your patch to the third position in the list to prevent problems
applying them.
Please take care to keep patches on a report in the right order. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

--- Comment #73 from Jonathan Druart  
---
(In reply to Joonas Kylmälä from comment #68)
> (In reply to Jonathan Druart from comment #28)
> > Created attachment 41347 [details] [review] [review]
> > Bug 13618: Remove html filters at the OPAC
> > 
> > This patch removes the html filters at the OPAC, if necessary.
> > 
> > Generated with:
> >   perl -p -i -e 's/\ ?\|\ ?html(\ ?)%/\1%/g' **/*.tt **/*.inc
> 
> @@ -85,7 +85,7 @@
>  [% END %]
>  ).
>  [% END %]
> - %]/cgi-bin/koha/opac-search.pl?[% query_cgi | url %][% limit_cgi |html | url
> %]count=[% countrss %]sort_by=acqdate_dscformat=rss2~
>  [% END # / IF total %]
>  
>  [% END # / IF searchdesc %]
> 
> Shouldn't that one also be removed?

I don't think so, I think I have tested them.

(In reply to Joonas Kylmälä from comment #71)
> Why not have also raw SCOUserCSS if we let the user have OPACUserCSS as raw?

Done in another patch.

(In reply to Joonas Kylmälä from comment #72)
> The front page in Staff side doesn't render html under News->What's Next.

New patch pushed to the remote branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10468] patron print summary should show more

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751

Zeno Tajoli  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Zeno Tajoli  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #98 from Peter Zhao  ---
ES Opac cannot support Chinese language? I try to search Chinese word in
http://elasticsearch.koha.catalystdemo.net.nz/ and my ES, they also show
"Software error".

Software error:

Can't escape \x{57FA}, try uri_escape_utf8() instead at
/opt/kohaclones/elasticsearch/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
line 217.

For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error. 

Software error:

Can't escape \x{57FA}, try uri_escape_utf8() instead at
/home/koha/kohaes/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 217.

For help, please send mail to the webmaster (webmaster@koha), giving this error
message and the time and date of the error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/